Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-08 Thread Michael Paquier
On Sat, Apr 9, 2016 at 1:46 AM, Christian Ullrich wrote: > * Andrew Dunstan wrote: > >> On 04/08/2016 11:02 AM, Christian Ullrich wrote: > > >>> src/port/chklocale.c(233): warning C4133: 'function': incompatible >>> types - from 'const char *' to 'LPCWSTR'

Re: [HACKERS] Weighted Stats

2016-04-08 Thread David Fetter
On Fri, Mar 18, 2016 at 06:12:12PM -0700, Jeff Janes wrote: > On Tue, Mar 15, 2016 at 8:36 AM, David Fetter wrote: > > > > Please find attached a patch that uses the float8 version to cover the > > numeric types. > > Is there a well-defined meaning for having a negative weight?

Re: [HACKERS] closing CommitFest 2016-03, feature freeze now in effect

2016-04-08 Thread Joshua D. Drake
On 04/08/2016 05:05 PM, Robert Haas wrote: CommitFest 2016-03 is now closed. I have moved "Twophase transactions on slave", "Partial sort", and "amcheck (B-Tree integrity checking tool)" to the next CommitFest in accordance with the policy previous set by the release management team. I have

Re: [HACKERS] multivariate statistics v14

2016-04-08 Thread Tatsuo Ishii
From: Tomas Vondra Subject: Re: [HACKERS] multivariate statistics v14 Date: Fri, 8 Apr 2016 20:55:24 +0200 Message-ID: <5d1d62a6-6228-188c-e079-c1be59942...@2ndquadrant.com> > On 04/08/2016 05:55 PM, Robert Haas wrote: >> On Tue, Mar 29, 2016 at 11:18 AM, David

Re: [HACKERS] Speedup twophase transactions

2016-04-08 Thread Noah Misch
On Fri, Apr 08, 2016 at 02:57:00PM -0400, Jesper Pedersen wrote: > On 04/08/2016 02:37 PM, Robert Haas wrote: > >On Fri, Apr 8, 2016 at 8:49 AM, Jesper Pedersen > >wrote: > >>Should we create an entry for the open item list [0] for this, due to the > >>replication lag

[HACKERS] the buildfarm has measles

2016-04-08 Thread Robert Haas
bowerbird and lorikeet are complaining about the git tree being dirty. prairiedog is not happy about the new plpython error stuff. woodlouse and thrips failed like this (and mastodon in a similar but not identical way): "C:\buildfarm\buildenv\HEAD\pgsql.build\pgsql.sln" (Standardziel) (1) ->

Re: [HACKERS] Support for N synchronous standby servers - take 2

2016-04-08 Thread Tom Lane
Jeff Janes writes: > When I compile now without cassert, I get the compiler warning: > syncrep.c: In function 'SyncRepUpdateConfig': > syncrep.c:878:6: warning: variable 'parse_rc' set but not used > [-Wunused-but-set-variable] If there's a good reason for that to be an

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-08 Thread Petr Jelinek
On 09/04/16 00:41, Michael Paquier wrote: On Sat, Apr 9, 2016 at 1:46 AM, Christian Ullrich wrote: * Andrew Dunstan wrote: On 04/08/2016 11:02 AM, Christian Ullrich wrote: src/port/chklocale.c(233): warning C4133: 'function': incompatible types - from 'const

Re: [HACKERS] the buildfarm has measles

2016-04-08 Thread Alvaro Herrera
Robert Haas wrote: > woodlouse and thrips failed like this (and mastodon in a similar but > not identical way): > > "C:\buildfarm\buildenv\HEAD\pgsql.build\pgsql.sln" (Standardziel) (1) -> > "C:\buildfarm\buildenv\HEAD\pgsql.build\ascii_and_mic.vcxproj" > (Standardziel) (2) -> >

Re: [HACKERS] Support for N synchronous standby servers - take 2

2016-04-08 Thread Jeff Janes
On Wed, Apr 6, 2016 at 1:23 AM, Fujii Masao wrote: > Okay, I pushed the patch! > Many thanks to all involved in the development of this feature! Thanks, a nice feature. When I compile now without cassert, I get the compiler warning: syncrep.c: In function

Re: [HACKERS] the buildfarm has measles

2016-04-08 Thread Tom Lane
Alvaro Herrera writes: > Robert Haas wrote: >> woodlouse and thrips failed like this (and mastodon in a similar but >> not identical way): >> >> "C:\buildfarm\buildenv\HEAD\pgsql.build\pgsql.sln" (Standardziel) (1) -> >>

Re: [HACKERS] [COMMITTERS] pgsql: Add the "snapshot too old" feature

2016-04-08 Thread Kevin Grittner
On Fri, Apr 8, 2016 at 2:45 PM, Kevin Grittner wrote: > Add the "snapshot too old" feature > src/test/modules/Makefile | 1 + > src/test/modules/snapshot_too_old/Makefile | 47 +++ > .../snapshot_too_old/expected/sto_using_cursor.out |

Re: [HACKERS] the buildfarm has measles

2016-04-08 Thread Andrew Dunstan
On 04/08/2016 07:57 PM, Robert Haas wrote: bowerbird and lorikeet are complaining about the git tree being dirty. bowerbird is fixed and rebuilding. cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] the buildfarm has measles

2016-04-08 Thread Andres Freund
On April 8, 2016 8:05:31 PM PDT, Tom Lane wrote: >Alvaro Herrera writes: >> Robert Haas wrote: >>> woodlouse and thrips failed like this (and mastodon in a similar but >>> not identical way): >>> >>>

[HACKERS] closing CommitFest 2016-03, feature freeze now in effect

2016-04-08 Thread Robert Haas
CommitFest 2016-03 is now closed. I have moved "Twophase transactions on slave", "Partial sort", and "amcheck (B-Tree integrity checking tool)" to the next CommitFest in accordance with the policy previous set by the release management team. I have left "Replace buffer manager spinlock with

Re: [HACKERS] the buildfarm has measles

2016-04-08 Thread Andrew Dunstan
On 04/08/2016 10:38 PM, Andrew Dunstan wrote: On 04/08/2016 07:57 PM, Robert Haas wrote: bowerbird and lorikeet are complaining about the git tree being dirty. bowerbird is fixed and rebuilding. lorikeet should be fixed, too. But bowerbird failed compiling an Assert from commit

Re: [HACKERS] Support for N synchronous standby servers - take 2

2016-04-08 Thread Masahiko Sawada
On Fri, Apr 8, 2016 at 4:50 PM, Fujii Masao wrote: > On Fri, Apr 8, 2016 at 2:26 PM, Michael Paquier > wrote: >> On Thu, Apr 7, 2016 at 11:43 PM, Fujii Masao wrote: >>> On Wed, Apr 6, 2016 at 5:04 PM, Michael Paquier >>>

Re: [HACKERS] PATCH: pg_restore parallel-execution-deadlock issue

2016-04-08 Thread Michael Paquier
On Tue, Apr 5, 2016 at 9:28 AM, Armin Schöffmann wrote: > I propose the below patches to parallels.c and pg_backup_utils.c fixing > deadlocks in pg_restore (windows only) if running more than 2 parallel jobs. > This problem was reported by me earlier this year. >

[HACKERS] Lower msvc build verbosity level

2016-04-08 Thread Christian Ullrich
Hello, could we perhaps lower the verbosity level of the msvc build (in src/tools/msvc/build.pl) from "detailed" to "normal"? In my experiment, this reduces the size of the build log by 96.4 percent (from 12.5 MiB to 438 KiB), or if the log is not redirected, it shortens the build time by 45

Re: [HACKERS] [patch] Proposal for \crosstabview in psql

2016-04-08 Thread Daniel Verite
Alvaro Herrera wrote: > I messed with that code some more, as it looked unnecessarily > complicated; please see attached and verify that it still behaves > sanely. This needs those regression tests you promised. I tested a few > cases and it seems good to me. I've fixed a couple things

Re: [HACKERS] Speedup twophase transactions

2016-04-08 Thread Jesper Pedersen
On 04/07/2016 02:29 AM, Michael Paquier wrote: So recovery is conflicting here. My guess is that this patch is missing some lock cleanup. With the test case attached in my case the COMMIT PREPARED record does not even get replayed. Should we create an entry for the open item list [0] for

Re: [HACKERS] Speedup twophase transactions

2016-04-08 Thread Simon Riggs
On 7 April 2016 at 07:29, Michael Paquier wrote: With the test case attached in my case the COMMIT PREPARED record does > not even get replayed. > I was surprised to see this in the test... sleep 2; # wait for changes to arrive on slave I think the test framework

Re: [HACKERS] 2016-03 Commitfest

2016-04-08 Thread Tom Lane
David Steele writes: > So the commitfest is 84% complete with less than twelve hours to go. Have we set a particular time-of-day for closing the CF, and if so what is it exactly? regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] WIP: Covering + unique indexes.

2016-04-08 Thread Anastasia Lubennikova
08.04.2016 15:06, Teodor Sigaev: On Wed, Apr 6, 2016 at 1:50 PM, Peter Geoghegan wrote: Personally, I like documenting assertions, and will sometimes write assertions that the compiler could easily optimize away. Maybe going *that* far is more a matter of personal style, but I

Re: [HACKERS] Lower msvc build verbosity level

2016-04-08 Thread Michael Paquier
On Fri, Apr 8, 2016 at 9:29 PM, Magnus Hagander wrote: > On Fri, Apr 8, 2016 at 2:25 PM, Andrew Dunstan wrote: >> On 04/08/2016 06:19 AM, Christian Ullrich wrote: >>> could we perhaps lower the verbosity level of the msvc build (in >>>

Re: [HACKERS] 2016-03 Commitfest

2016-04-08 Thread David Steele
Here's where we stand on the last day of the 2016-03 commitfest: Needs review: 7 (was 28 last week) Waiting on Author: 4 (was 16 last week) Ready for Committer: 12 Committed: 92 Moved to next CF: 3 Rejected: 7 Returned with Feedback: 23 So the commitfest is 84% complete with less than twelve

Re: [HACKERS] Lower msvc build verbosity level

2016-04-08 Thread Magnus Hagander
On Fri, Apr 8, 2016 at 2:25 PM, Andrew Dunstan wrote: > > > On 04/08/2016 06:19 AM, Christian Ullrich wrote: > >> Hello, >> >> could we perhaps lower the verbosity level of the msvc build (in >> src/tools/msvc/build.pl) from "detailed" to "normal"? In my experiment, >> this

Re: [HACKERS] WIP: Covering + unique indexes.

2016-04-08 Thread Teodor Sigaev
On Wed, Apr 6, 2016 at 1:50 PM, Peter Geoghegan wrote: Personally, I like documenting assertions, and will sometimes write assertions that the compiler could easily optimize away. Maybe going *that* far is more a matter of personal style, but I think an assertion about the new

[HACKERS] Small patch for snapmgr.c

2016-04-08 Thread Aleksander Alekseev
Hello Currently there is a following piece of code in snapmgr.c: ``` /* Copy all required fields */ snapshot = (Snapshot) MemoryContextAlloc(TopTransactionContext, size); snapshot->satisfies = HeapTupleSatisfiesMVCC; snapshot->xmin = serialized_snapshot->xmin; snapshot->xmax =

Re: [HACKERS] Speedup twophase transactions

2016-04-08 Thread Stas Kelvich
> On 07 Apr 2016, at 09:29, Michael Paquier wrote: > > relOid=16385) + 358 at standby.c:627 >frame #11: 0x0001023dac6b > postgres`standby_redo(record=0x7fde50841e38) + 251 at > standby.c:809 > > (LOCALLOCK) $1 = { > tag = { >lock = { >

Re: [HACKERS] Speedup twophase transactions

2016-04-08 Thread Stas Kelvich
> On 08 Apr 2016, at 16:36, Simon Riggs wrote: > > On 7 April 2016 at 07:29, Michael Paquier wrote: > > With the test case attached in my case the COMMIT PREPARED record does > not even get replayed. > > I was surprised to see this in the

Re: [HACKERS] amcheck (B-Tree integrity checking tool)

2016-04-08 Thread Anastasia Lubennikova
29.03.2016 06:13, Peter Geoghegan: On Tue, Mar 22, 2016 at 10:57 AM, Peter Geoghegan wrote: That's right - I have a small number of feedback items to work through. I also determined myself that there could be a very low probability race condition when checking the key space

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-08 Thread Andrew Dunstan
On 04/08/2016 07:15 AM, Christian Ullrich wrote: * Michael Paquier wrote: > On Fri, Apr 8, 2016 at 9:29 AM, Andrew Dunstan > wrote: Not out of the woods yet. Attached is what I got from VS2015 on a fresh W10 VM, with Michael's patch 0002 and 0004 applied.

Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used

2016-04-08 Thread Magnus Hagander
On Tue, Mar 29, 2016 at 11:24 PM, Christian Ullrich wrote: > * Magnus Hagander wrote: > > On Tue, Mar 29, 2016 at 5:09 PM, David Steele wrote: >> > > It seems like this patch should be set "ready for committer". Can one of >>> the reviewers do that if

Re: [HACKERS] Lower msvc build verbosity level

2016-04-08 Thread Andrew Dunstan
On 04/08/2016 06:19 AM, Christian Ullrich wrote: Hello, could we perhaps lower the verbosity level of the msvc build (in src/tools/msvc/build.pl) from "detailed" to "normal"? In my experiment, this reduces the size of the build log by 96.4 percent (from 12.5 MiB to 438 KiB), or if the log

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

2016-04-08 Thread Robert Haas
On Fri, Apr 8, 2016 at 3:05 AM, Etsuro Fujita wrote: >> What do you think? This open item's seven-day deadline has passed. It >> would >> help keep things moving to know whether you consider your latest patch >> optimal >> or whether you wish to change it the way

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

2016-04-08 Thread Rushabh Lathia
On Fri, Apr 8, 2016 at 6:28 PM, Robert Haas wrote: > On Fri, Apr 8, 2016 at 3:05 AM, Etsuro Fujita > wrote: > >> What do you think? This open item's seven-day deadline has passed. It > >> would > >> help keep things moving to know whether

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-08 Thread Tom Lane
Andrew Dunstan writes: > OK, at this stage it appears to me that if today is the deadline for > getting this in for 9.6 then it's going to be missed. It would be unfortunate to go another year without support for that toolchain. My suggestion is that you continue to work

Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers

2016-04-08 Thread Amit Kapila
On Thu, Apr 7, 2016 at 6:48 PM, Andres Freund wrote: > On 2016-04-07 18:40:14 +0530, Amit Kapila wrote: > > > This is the data with -b tpcb-like@1 with 20-min run for each version > and I > > could see almost similar results as the data posted in previous e-mail. > > > >

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-08 Thread Christian Ullrich
* Michael Paquier wrote: > On Fri, Apr 8, 2016 at 9:29 AM, Andrew Dunstan > wrote: Not out of the woods yet. Attached is what I got from VS2015 on a fresh W10 VM, with Michael's patch 0002 and 0004 applied. Interesting, I have no idea what we are doing differently,

Re: [HACKERS] Support for N synchronous standby servers - take 2

2016-04-08 Thread Fujii Masao
On Fri, Apr 8, 2016 at 2:26 PM, Michael Paquier wrote: > On Thu, Apr 7, 2016 at 11:43 PM, Fujii Masao wrote: >> On Wed, Apr 6, 2016 at 5:04 PM, Michael Paquier >> wrote: >>> On Wed, Apr 6, 2016 at 4:08 PM, Michael

Re: [HACKERS] Support for N synchronous standby servers - take 2

2016-04-08 Thread Amit Kapila
On Thu, Apr 7, 2016 at 5:49 PM, Fujii Masao wrote: > > On Thu, Apr 7, 2016 at 7:29 PM, Amit Kapila wrote: > > > > So if we go by this each time backend calls pg_stat_get_wal_senders, it > > needs to do parsing to form SyncRepConfig whether it's

Re: [HACKERS] [patch] Proposal for \crosstabview in psql

2016-04-08 Thread Daniel Verite
Alvaro Herrera wrote: > I wonder if the business of appending values of multiple columns > separated with spaces is doing us any good. Why not require that > there's a single column in the cell? If the user wants to put things > together, they can use format() or just || the fields

Re: [HACKERS] Choosing parallel_degree

2016-04-08 Thread Simon Riggs
On 8 April 2016 at 17:00, Paul Ramsey wrote: > On Fri, Apr 8, 2016 at 8:23 AM, Robert Haas wrote: > > On Fri, Apr 8, 2016 at 1:22 AM, Amit Kapila > wrote: > >> Other than that, patch looks good and I have marked it as

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-08 Thread Andrew Dunstan
On 04/08/2016 11:02 AM, Christian Ullrich wrote: * Michael Paquier wrote: On Fri, Apr 8, 2016 at 10:05 PM, Andrew Dunstan wrote: ¥> On 04/08/2016 07:15 AM, Christian Ullrich wrote: Michael, none of your patches change this, so how does it ever build on your system?

Re: [HACKERS] Batch update of indexes

2016-04-08 Thread David Steele
On 4/2/16 4:21 PM, Konstantin Knizhnik wrote: > Thank you for review, Tom. > > I completely agree with all your arguments against this patch. > I have proposed this patch mostly as prove of concept. I have marked this "returned with feedback". Hopefully you can work on the concept and resubmit

Re: [HACKERS] Choosing parallel_degree

2016-04-08 Thread Paul Ramsey
On Fri, Apr 8, 2016 at 8:23 AM, Robert Haas wrote: > On Fri, Apr 8, 2016 at 1:22 AM, Amit Kapila wrote: >> Other than that, patch looks good and I have marked it as Ready For >> Committer. Hope, we get this for 9.6. > > Committed. I think this is

Re: [HACKERS] Choosing parallel_degree

2016-04-08 Thread Paul Ramsey
On Fri, Apr 8, 2016 at 9:06 AM, Simon Riggs wrote: > On 8 April 2016 at 17:00, Paul Ramsey wrote: >> >> On Fri, Apr 8, 2016 at 8:23 AM, Robert Haas wrote: >> > On Fri, Apr 8, 2016 at 1:22 AM, Amit Kapila

Re: [HACKERS] Choosing parallel_degree

2016-04-08 Thread Robert Haas
On Fri, Apr 8, 2016 at 12:27 PM, Paul Ramsey wrote: > Insofar as the patch is throttling how many parallel workers you get > based solely on your relsize, it does concern this patch, but it's a > general issue in both the extreme and not obviously related costings >

Re: [HACKERS] Proposal: BSD Authentication support

2016-04-08 Thread Tom Lane
David Steele writes: > On 4/8/16 11:20 AM, Robert Haas wrote: >> Should we commit this patch? > To summarize: > Robert Haas and Peter Eisentraut have done code-only reviews. Thomas > Munro has reviewed and tested with a caveat that he is no BSD expert. > Pierre-Emmanuel

Re: [HACKERS] 2016-03 Commitfest

2016-04-08 Thread Gavin Flower
On 09/04/16 02:58, Magnus Hagander wrote: On Fri, Apr 8, 2016 at 4:56 PM, Robert Haas > wrote: On Fri, Apr 8, 2016 at 10:06 AM, David Steele > wrote: > On 4/8/16 10:00 AM, Tom Lane

Re: [HACKERS] 2016-03 Commitfest

2016-04-08 Thread Simon Riggs
On 8 April 2016 at 16:00, Andres Freund wrote: I've finished polishing the Pin/Unpin patch. But the final polishing > happened on an intercontential flight, after days spent preparing my > move to SF. I'd be glad if you would allow me to look over the patch > again, before

Re: [HACKERS] Lower msvc build verbosity level

2016-04-08 Thread Christian Ullrich
* Tom Lane wrote: +several. Grepping for compiler warnings, for example, is really painful right now on any MSVC critter. I've resorted to grepping for "warning C", which skips the noise messages, but I'm never sure if I'm missing something. You miss all diagnostics from other tools than

Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers

2016-04-08 Thread Amit Kapila
On Fri, Apr 8, 2016 at 9:00 PM, Andres Freund wrote: > > On 2016-03-31 15:07:22 +0530, Amit Kapila wrote: > > I think we should change comments on top of this function. I have changed > > the comments as per my previous patch and attached the modified patch with > > this

Re: [HACKERS] Move PinBuffer and UnpinBuffer to atomics

2016-04-08 Thread Andres Freund
On 2016-04-07 16:50:44 +0300, Alexander Korotkov wrote: > On Thu, Apr 7, 2016 at 4:41 PM, Andres Freund wrote: > > > On 2016-03-31 20:21:02 +0300, Alexander Korotkov wrote: > > > ! BEGIN_BUFSTATE_CAS_LOOP(bufHdr); > > > > > > ! Assert(BUF_STATE_GET_REFCOUNT(state) >

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-08 Thread Christian Ullrich
* Andrew Dunstan wrote: On 04/08/2016 11:02 AM, Christian Ullrich wrote: src/port/chklocale.c(233): warning C4133: 'function': incompatible types - from 'const char *' to 'LPCWSTR' [...\postgres.vcxproj] Do you have a fix for the LPCWSTR parameter issue? As long as the locale short

Re: [HACKERS] Lower msvc build verbosity level

2016-04-08 Thread Andrew Dunstan
On 04/08/2016 12:24 PM, Christian Ullrich wrote: * Tom Lane wrote: +several. Grepping for compiler warnings, for example, is really painful right now on any MSVC critter. I've resorted to grepping for "warning C", which skips the noise messages, but I'm never sure if I'm missing

Re: [HACKERS] 2016-03 Commitfest

2016-04-08 Thread Magnus Hagander
On Fri, Apr 8, 2016 at 4:56 PM, Robert Haas wrote: > On Fri, Apr 8, 2016 at 10:06 AM, David Steele wrote: > > On 4/8/16 10:00 AM, Tom Lane wrote: > >> David Steele writes: > >>> So the commitfest is 84% complete with less than

Re: [HACKERS] Choosing parallel_degree

2016-04-08 Thread Robert Haas
On Fri, Apr 8, 2016 at 1:22 AM, Amit Kapila wrote: > Other than that, patch looks good and I have marked it as Ready For > Committer. Hope, we get this for 9.6. Committed. I think this is likely to make parallel query significantly more usable in 9.6. -- Robert Haas

Re: [HACKERS] 2016-03 Commitfest

2016-04-08 Thread Magnus Hagander
On Fri, Apr 8, 2016 at 4:00 PM, Tom Lane wrote: > David Steele writes: > > So the commitfest is 84% complete with less than twelve hours to go. > > Have we set a particular time-of-day for closing the CF, and if so > what is it exactly? > > And timezone?

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-08 Thread Michael Paquier
On Fri, Apr 8, 2016 at 10:05 PM, Andrew Dunstan wrote: ¥> On 04/08/2016 07:15 AM, Christian Ullrich wrote: >> GetLocaleInfoEx() is covered by #if (WINVER >= 0x0600), we define >> _WIN32_WINNT as 0x0501 (src/include/port/win32.h) and WINVER inherits that >> value. Yes, I had

Re: [HACKERS] Execute ignoring cursor?

2016-04-08 Thread Pavel Stehule
Hi 2016-04-08 16:17 GMT+02:00 nummervet nummervet : > Hello. Didn't find dedicated plpgsql list, so decided to post question > here. > I am trying to create a function that will pick up some values from > cursor and execute them as a dynamic query. > However, once i use

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-08 Thread Christian Ullrich
* Michael Paquier wrote: On Fri, Apr 8, 2016 at 10:05 PM, Andrew Dunstan wrote: ¥> On 04/08/2016 07:15 AM, Christian Ullrich wrote: Michael, none of your patches change this, so how does it ever build on your system? Luck. I am getting a warning but the code is able

Re: [HACKERS] Execute ignoring cursor?

2016-04-08 Thread Pavel Stehule
2016-04-08 16:46 GMT+02:00 nummervet nummervet : > That didn't work for me: > > ERROR: syntax error at or near "$" > LINE 1: ...ibute_id, set_id ) (select $."151", '... > should be $1 Regards Pavel > > > Пятница, 8 апреля 2016, 17:25 +03:00 от Pavel Stehule < >

Re: [HACKERS] [PATCH] speeding up GIN build with parallel workers

2016-04-08 Thread Constantin S. Pan
Here is a new version of the patch, which: 1. Fixes some minor stylistic issues. 2. Uses binaryheap (instead of a custom ugly stack) for merging. Regards, Constantin S. Pan Postgres Professional: http://www.postgrespro.com The Russian Postgres Company diff --git a/doc/src/sgml/config.sgml

[HACKERS] Re[2]: [HACKERS] Execute ignoring cursor?

2016-04-08 Thread nummervet nummervet
That didn't work for me: ERROR:  syntax error at or near "$" LINE 1: ...ibute_id, set_id ) (select $."151", '... >Пятница, 8 апреля 2016, 17:25 +03:00 от Pavel Stehule >: > >Hi > >2016-04-08 16:17 GMT+02:00 nummervet nummervet < nummer...@mail.ru > : >>Hello. Didn't

Re: [HACKERS] Proposal: BSD Authentication support

2016-04-08 Thread Robert Haas
On Fri, Apr 8, 2016 at 6:48 AM, Pierre-Emmanuel André wrote: > On Fri, Mar 18, 2016 at 06:30:35PM +1300, Thomas Munro wrote: >> On Fri, Mar 18, 2016 at 12:49 PM, Marisa Emerson wrote: >> > On 18/03/16 03:57, Thomas Munro wrote: >> >> >> >> You used one name in

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-08 Thread Andrew Dunstan
On 04/08/2016 09:52 AM, Tom Lane wrote: Andrew Dunstan writes: OK, at this stage it appears to me that if today is the deadline for getting this in for 9.6 then it's going to be missed. It would be unfortunate to go another year without support for that toolchain. My

Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers

2016-04-08 Thread Andres Freund
On 2016-03-31 15:07:22 +0530, Amit Kapila wrote: > I think we should change comments on top of this function. I have changed > the comments as per my previous patch and attached the modified patch with > this mail, see if that makes sense. I've applied this patch. Regards, Andres -- Sent

Re: [HACKERS] proposal: PL/Pythonu - function ereport

2016-04-08 Thread Teodor Sigaev
Thank you very much thank you, pushed. Pls, pay attention to buildfarm. -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [PATCH] speeding up GIN build with parallel workers

2016-04-08 Thread Robert Haas
On Fri, Apr 8, 2016 at 10:04 AM, Constantin S. Pan wrote: > Here is a new version of the patch, which: > > 1. Fixes some minor stylistic issues. > > 2. Uses binaryheap (instead of a custom ugly stack) for merging. I think we need to push this patch out to 9.7. This code has

Re: [HACKERS] 2016-03 Commitfest

2016-04-08 Thread David Steele
On 4/8/16 10:00 AM, Tom Lane wrote: > David Steele writes: >> So the commitfest is 84% complete with less than twelve hours to go. > > Have we set a particular time-of-day for closing the CF, and if so > what is it exactly? From the referenced email: "Accordingly, the

Re: [HACKERS] Lower msvc build verbosity level

2016-04-08 Thread Tom Lane
Michael Paquier writes: > On Fri, Apr 8, 2016 at 9:29 PM, Magnus Hagander wrote: >> On Fri, Apr 8, 2016 at 2:25 PM, Andrew Dunstan wrote: >>> could we perhaps lower the verbosity level of the msvc build (in >>>

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-04-08 Thread Magnus Hagander
On Fri, Apr 8, 2016 at 4:12 PM, Michael Paquier wrote: > On Fri, Apr 8, 2016 at 10:05 PM, Andrew Dunstan > wrote: > ¥> On 04/08/2016 07:15 AM, Christian Ullrich wrote: > >> GetLocaleInfoEx() is covered by #if (WINVER >= 0x0600), we define > >>

[HACKERS] Execute ignoring cursor?

2016-04-08 Thread nummervet nummervet
Hello. Didn't find dedicated plpgsql list, so decided to post question here. I am trying to create a  function that will pick up some values from cursor and execute them as a dynamic query. However, once i use EXECUTE, its seems to be ignoring the existence of cursor and try to pick up values

[HACKERS] skink vs. phrase full text search

2016-04-08 Thread Tom Lane
Buildfarm member skink has been unhappy since bb14050 went in, but I find that I cannot reproduce any failure by valgrind'ing here. Can you suggest any secret sauce that that animal may be using? regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] 2016-03 Commitfest

2016-04-08 Thread Andres Freund
On 2016-04-08 10:56:28 -0400, Robert Haas wrote: > On Fri, Apr 8, 2016 at 10:06 AM, David Steele wrote: > > On 4/8/16 10:00 AM, Tom Lane wrote: > >> David Steele writes: > >>> So the commitfest is 84% complete with less than twelve hours to go. > >> > >>

Re: [HACKERS] WIP: Covering + unique indexes.

2016-04-08 Thread Anastasia Lubennikova
08.04.2016 15:45, Anastasia Lubennikova: 08.04.2016 15:06, Teodor Sigaev: On Wed, Apr 6, 2016 at 1:50 PM, Peter Geoghegan wrote: Personally, I like documenting assertions, and will sometimes write assertions that the compiler could easily optimize away. Maybe going *that* far

Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers

2016-04-08 Thread Andres Freund
On 2016-04-08 13:07:05 +0530, Amit Kapila wrote: > I think by now, we have done many tests with both approaches and we find > that in some cases, it is slightly better and in most cases it is neutral > and in some cases it is worse than group clog approach. I feel we should > go with group clog

Re: [HACKERS] Proposal: BSD Authentication support

2016-04-08 Thread David Steele
On 4/8/16 11:20 AM, Robert Haas wrote: > On Fri, Apr 8, 2016 at 6:48 AM, Pierre-Emmanuel André > wrote: >> On Fri, Mar 18, 2016 at 06:30:35PM +1300, Thomas Munro wrote: >>> On Fri, Mar 18, 2016 at 12:49 PM, Marisa Emerson wrote: On 18/03/16 03:57, Thomas

Re: [HACKERS] pam auth - add rhost item

2016-04-08 Thread Peter Eisentraut
On 03/22/2016 04:29 PM, Grzegorz Sampolski wrote: New patch, which change pamservice parameter from pamusedns to pam_use_hostname. committed -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] skink vs. phrase full text search

2016-04-08 Thread Andres Freund
Hi, On 2016-04-08 10:45:01 -0400, Tom Lane wrote: > Buildfarm member skink has been unhappy since bb14050 went in, > but I find that I cannot reproduce any failure by valgrind'ing > here. Can you suggest any secret sauce that that animal may > be using? I gather you're compiling with

Re: [HACKERS] 2016-03 Commitfest

2016-04-08 Thread Robert Haas
On Fri, Apr 8, 2016 at 10:06 AM, David Steele wrote: > On 4/8/16 10:00 AM, Tom Lane wrote: >> David Steele writes: >>> So the commitfest is 84% complete with less than twelve hours to go. >> >> Have we set a particular time-of-day for closing the CF, and

Re: [HACKERS] 2016-03 Commitfest

2016-04-08 Thread Robert Haas
On Fri, Apr 8, 2016 at 11:00 AM, Andres Freund wrote: > On 2016-04-08 10:56:28 -0400, Robert Haas wrote: >> On Fri, Apr 8, 2016 at 10:06 AM, David Steele wrote: >> > On 4/8/16 10:00 AM, Tom Lane wrote: >> >> David Steele writes: >>

Re: [HACKERS] multivariate statistics v14

2016-04-08 Thread Robert Haas
On Tue, Mar 29, 2016 at 11:18 AM, David Steele wrote: > On 3/28/16 4:42 AM, Tomas Vondra wrote: >> Yes, those are valid omissions. I plan to address them, and I'd also >> considering adding a section to 65.1 (How the Planner Uses Statistics), >> explaining more thoroughly how

Re: [HACKERS] Combining Aggregates

2016-04-08 Thread Robert Haas
On Wed, Apr 6, 2016 at 5:28 PM, David Rowley wrote: >> Is that everything now? I don't see anything about combining aggs in the git >> log and this is still showing as UnCommitted in the CF app. > > There's just a documentation patch and two combine functions for >

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2016-04-08 Thread Robert Haas
On Fri, Apr 8, 2016 at 4:36 PM, Tom Lane wrote: > Robert Haas writes: >> On Fri, Apr 8, 2016 at 3:24 PM, David Steele wrote: >>> Can one of the reviewers decide if this is ready to commit? I fear it >>> will be pushed to the next

Re: [HACKERS] snapshot too old, configured by time

2016-04-08 Thread David Steele
On 4/8/16 4:30 PM, Peter Geoghegan wrote: > On Fri, Apr 8, 2016 at 12:55 PM, Kevin Grittner wrote: >> Sadly, I forgot to include the reviewer information when writing the >> commit messages. :-( > > Oh well. I'm just glad we got the patch over the line. I think that > there

Re: [HACKERS] Covering + unique indexes

2016-04-08 Thread Andreas Joseph Krogh
På lørdag 09. april 2016 kl. 06:34:39, skrev Tom Lane >: Andreas Joseph Krogh writes: > Any reason $subject didn't make it (commited but reverted)? See the thread on -committers.   Ah, thanks.   -- Andreas Joseph Krogh

[HACKERS] Covering + unique indexes

2016-04-08 Thread Andreas Joseph Krogh
Any reason $subject didn't make it (commited but reverted)?   This is a great feature and lots of work seems to have been put into this patch along with quite some reviewing. It would be nice to know why -hackers think it's not ready for 9.6.   Thanks.   -- Andreas Joseph Krogh

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

2016-04-08 Thread Tom Lane
Peter Eisentraut writes: > On 01/22/2016 03:46 PM, Tom Lane wrote: >> Add trigonometric functions that work in degrees. > I have a host here that is having regression test failures from this commit: > --- src/test/regress/expected/float8.out > +++

Re: [HACKERS] Weighted Stats

2016-04-08 Thread David Fetter
On Fri, Apr 08, 2016 at 01:47:56PM -0700, David Fetter wrote: > Sorry about the delay. This patch disallows negative weights, > although it still has that odd difference Jeff found. Difference corrected. It turned out that my reference was mistaken on the calculation. Cheers, David. -- David

Re: [HACKERS] [patch] Proposal for \crosstabview in psql

2016-04-08 Thread Alvaro Herrera
Daniel Verite wrote: > ISTM that this could be avoided by erroring out for lack of an > explicit 3rd column as argument. IOW, we wouldn't assume > that "no column specified" means "show all columns". > > About simply ripping out the possibility of having multiple > columns into cells, it's more

Re: [HACKERS] the buildfarm has measles

2016-04-08 Thread Alvaro Herrera
Alvaro Herrera wrote: > Robert Haas wrote: > > > crake failed 'make check': > > > > *** /home/bf/bfr/root/HEAD/pgsql.build/src/test/regress/expected/misc.out > > Fri Apr 8 19:38:58 2016 > > --- /home/bf/bfr/root/HEAD/pgsql.build/src/test/regress/results/misc.out > > Fri Apr 8 19:39:12 2016 > >

Re: [HACKERS] Default Roles (was: Additional role attributes)

2016-04-08 Thread Stephen Frost
Noah, Fujii, all, * Noah Misch (n...@leadboat.com) wrote: > At the C level, have a pgstattuple function and a pgstattuple_v1_4 function. > Let them differ only in that the former has a superuser check. Binary > upgrades will use the former, and fresh CREATE EXTENSION shall use the latter.

Re: [HACKERS] [COMMITTERS] pgsql: Add the "snapshot too old" feature

2016-04-08 Thread Alvaro Herrera
Kevin Grittner wrote: > Add the "snapshot too old" feature > > This feature is controlled by a new old_snapshot_threshold GUC. A > value of -1 disables the feature, and that is the default. The > value of 0 is just intended for testing. Above that it is the > number of minutes a snapshot can

Re: [HACKERS] the buildfarm has measles

2016-04-08 Thread Tom Lane
Robert Haas writes: > prairiedog is not happy about the new plpython error stuff. Yeah, see my complaint here: http://www.postgresql.org/message-id/12559.1460141...@sss.pgh.pa.us I think it's just a matter of avoiding invented-in-this-decade Pythonisms. The feature

Re: [HACKERS] Fix for OpenSSL error queue bug

2016-04-08 Thread Peter Geoghegan
On Fri, Apr 8, 2016 at 11:42 AM, Tom Lane wrote: > Seems like a reasonable thing to do, but somebody would have to do the > legwork to produce back-branch patches. I'll do so soon. I was waiting on Peter E to take me up on the offer. -- Peter Geoghegan -- Sent via

Re: [HACKERS] Fix for OpenSSL error queue bug

2016-04-08 Thread Tom Lane
Peter Geoghegan writes: > On Fri, Apr 8, 2016 at 11:20 AM, Peter Geoghegan wrote: >> That seems reasonable. I'm glad we finally got this done. Thanks. > Are we going to backpatch this? Seems like a reasonable thing to do, but somebody would have to do the

Re: [HACKERS] proposal: PL/Pythonu - function ereport

2016-04-08 Thread Tom Lane
Pavel Stehule writes: > 2016-04-08 17:38 GMT+02:00 Teodor Sigaev : >> thank you, pushed. Pls, pay attention to buildfarm. > Thank you very much for commit. According to buildfarm member prairiedog, there's a problem in one of the test cases. I suspect

  1   2   >