Re: [PATCHES] autovacuum multiworkers, patch 5

2007-04-11 Thread Alvaro Herrera
your patch on top of my own. This is the result. Please have a look at whether the new code is correct and behaves sanely (I haven't tested it). -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support Index

Re: [PATCHES] Autovacuum multiworkers, try 6

2007-04-10 Thread Alvaro Herrera
Alvaro Herrera wrote: Ok, here it is, after considerable rejiggering. Hum, just noticed a leftover from a previous version; the changes to procarray.c, sinvaladt.c and lock.c should be discarded (they are just about adding autovacuum_max_workers to code that uses MaxBackends). The changes

Re: [PATCHES] autovacuum multiworkers, patch 5

2007-04-09 Thread Alvaro Herrera
any further work on it, please let me have it to include it in the latest work. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast)--- TIP 2: Don't 'kill

Re: [PATCHES] autovacuum multiworkers, patch 5

2007-04-05 Thread Alvaro Herrera
Another problem seems to be that I'm not checking anywhere that a regular connection (not autovac) is not using an autovac-reserved PGPROC slot :-( I think I should tweak the logic that deals with ReservedBackends but it doesn't look entirely trivial. -- Alvaro Herrera

[PATCHES] autovacuum multiworkers, patch 5

2007-04-04 Thread Alvaro Herrera
that are not autovacuum workers.) FIXME someday. */ -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL

Re: [PATCHES] autovacuum multiworkers, patch 5

2007-04-04 Thread Alvaro Herrera
ITAGAKI Takahiro wrote: Alvaro Herrera [EMAIL PROTECTED] wrote: Here is the autovacuum patch I am currently working with. This is basically the same as the previous patch; I have tweaked the database list management so that after a change in databases (say a new database is created

Re: [PATCHES] autovacuum multiworkers, patch 5

2007-04-04 Thread Alvaro Herrera
Joshua D. Drake wrote: Alvaro Herrera wrote: ITAGAKI Takahiro wrote: Alvaro Herrera [EMAIL PROTECTED] wrote: Here is the autovacuum patch I am currently working with. This is basically the same as the previous patch; I have tweaked the database list management so that after a change

Re: [PATCHES] Current enums patch

2007-03-31 Thread Alvaro Herrera
we were picking our terms based on typography. It is kind of cool. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast)--- TIP 5: don't forget to increase

Re: [PATCHES] DEALLOCATE ALL

2007-03-30 Thread Alvaro Herrera
Neil Conway escribió: As to the implementation, calling hash_remove() in a loop seems a pretty unfortunate way to clear a hash table -- adding a hash_reset() function to the dynahash API would be cleaner and faster. I wonder why hash_drop cannot be used? -- Alvaro Herrera

Re: [PATCHES] DEALLOCATE ALL

2007-03-30 Thread Alvaro Herrera
Marko Kreen escribió: On 3/30/07, Alvaro Herrera [EMAIL PROTECTED] wrote: Neil Conway escribió: As to the implementation, calling hash_remove() in a loop seems a pretty unfortunate way to clear a hash table -- adding a hash_reset() function to the dynahash API would be cleaner and faster

Re: [PATCHES] DEALLOCATE ALL

2007-03-30 Thread Alvaro Herrera
Marko Kreen escribió: On 3/30/07, Alvaro Herrera [EMAIL PROTECTED] wrote: In any case it's not likely that there are going to be thousands of prepared statements, so is this really an issue? I think the issue is here that its very common thing to do, so open-coding it everywhere is waste

Re: [PATCHES] Make CLUSTER MVCC-safe

2007-03-29 Thread Alvaro Herrera
Heikki Linnakangas wrote: Here's an update, fixing conflict by Tom's recent commit of Simon's patch to skip WAL-inserts when archiving is not enabled. Hmm, wouldn't it be better if the rewriteheap.c file was in access/heap/ instead of commands/? -- Alvaro Herrera

Re: [PATCHES] autovacuum: multiple workers

2007-03-28 Thread Alvaro Herrera
Simon Riggs wrote: On Tue, 2007-03-27 at 17:41 -0400, Alvaro Herrera wrote: The main change is to have an array of Worker structs in shared memory; each worker checks the current table of all other Workers, and skips a table that's being vacuumed by any of them. It also rechecks

Re: [PATCHES] [PATCH] add CLUSTER table USING index

2007-03-28 Thread Alvaro Herrera
) { ! completion_info_charp = prev3_wd; ! COMPLETE_WITH_QUERY(Query_for_index_of_table); } Huh? -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast

Re: [PATCHES] DEALLOCATE ALL

2007-03-27 Thread Alvaro Herrera
in the node I can rework the patch. Wouldn't it be easier to just add a bool to DeallocateStmt? -- Alvaro Herrerahttp://www.PlanetPostgreSQL.org Si un desconocido se acerca y te regala un CD de Ubuntu ... Eso es ... Eau de Tux

[PATCHES] autovacuum: recheck logic

2007-03-27 Thread Alvaro Herrera
rechecking almost all tables every time (to be exact, all tables that have a toast table). The autovacuum parameters are only calculated in the second pass (the rechecking). The first pass only yields boolean parameters. Unless there are objections I'll apply this tomorrow. -- Alvaro Herrera

[PATCHES] autovacuum: multiple workers

2007-03-27 Thread Alvaro Herrera
autovacuum_naptime seconds ago are considered failed to start. Neither of these is really minor, but I think they are solvable. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support *** 14recheck/src/backend

Re: [PATCHES] Improvement of procArray.xmin for VACUUM

2007-03-23 Thread Alvaro Herrera
row reuse) -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs

Re: [PATCHES] LIMIT/SORT optimization

2007-03-22 Thread Alvaro Herrera
an updated version of this patch against CVS HEAD: http://community.enterprisedb.com/sort-limit-v5.patch.gz -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end

Re: [PATCHES] Patch for pgstatindex to fix a bug reporting a value of strange leaf_fragmentation

2007-03-16 Thread Alvaro Herrera
Tatsuhito Kasahara wrote: Hello. I found a bug in contrib/pgstatindex.c to reports a strange value of leaf_fragmentation with some cases. Applied to HEAD and 8.2, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt

Re: [PATCHES] remove psql support for ancient copy syntax

2007-03-15 Thread Alvaro Herrera
, right? -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings

Re: [PATCHES] Recalculating OldestXmin in a long-running vacuum

2007-03-13 Thread Alvaro Herrera
with the patch. But only by ~2%, that's slightly less than I expected. But what surprises me is that response times went up a with the patch. I don't know why. Maybe because of increased contention of ProcArrayLock? (I assume you are using that, althought I haven't seen the patch) -- Alvaro

Re: [PATCHES] Packed varlena patch update

2007-03-12 Thread Alvaro Herrera
pg_config.h, so this is not a problem. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end of broadcast)--- TIP 1: if posting/reading through Usenet

Re: [PATCHES] log_autovacuum

2007-03-08 Thread Alvaro Herrera
, 2338 remain CPU usage: whatever CONTEXT: Automatic vacuuming of table database.public.w This looks like the sort of thing comparable to picking a bikeshed color though :-( Keep in mind that it's going to be translated, so it's not useful for machine parsing anyway. -- Alvaro Herrera

Re: [PATCHES] log_autovacuum

2007-03-08 Thread Alvaro Herrera
Darcy Buskermolen wrote: On March 8, 2007 09:53 am, Alvaro Herrera wrote: Keep in mind that it's going to be translated, so it's not useful for machine parsing anyway. This goes back to the request for vacuum loging to a table.. That's right, but please let's have at least *something

Re: [PATCHES] Patch for pgstatindex to fix a bug reporting a value of strange leaf_fragmentation

2007-03-08 Thread Alvaro Herrera
are inserted in results. Right. Checking that code, it seems btpo.xact is also being incorrectly handled, is it not? Incidentally, the return value seems a bit useless. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. Index

Re: [PATCHES] Patch for pgstatindex to fix a bug reporting a value of strange leaf_fragmentation

2007-03-08 Thread Alvaro Herrera
Alvaro Herrera wrote: Right. Checking that code, it seems btpo.xact is also being incorrectly handled, is it not? Incidentally, the return value seems a bit useless. Then again, this looks bogus as well. (Sorry for the unidiff -- I had to use interdiff to get it). -- Alvaro Herrera

Re: [PATCHES] resetStringInfo

2007-03-03 Thread Alvaro Herrera
, if a bit tedious because you just rename the struct and the obvious places, and then let the compiler catch the rest.) -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Re: [PATCHES] [previously on HACKERS] Compacting a relation

2007-02-21 Thread Alvaro Herrera
VACUUM FULL on this relation or : ; -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end of broadcast)--- TIP 4: Have you searched our list

Re: [PATCHES] [previously on HACKERS] Compacting a relation

2007-02-21 Thread Alvaro Herrera
Bruce Momjian wrote: Alvaro Herrera wrote: Bruce Momjian wrote: I applied the optional VACUUM FULL version, but modified to code to say 20% rather than a factor of 5, attached. String construction does not work well with translations; please reformulate

Re: [PATCHES] Fast CLUSTER

2007-02-20 Thread Alvaro Herrera
in this function? -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end of broadcast)--- TIP 4: Have you searched our list archives

Re: [PATCHES] WIP patch - INSERT-able log statements

2007-02-19 Thread Alvaro Herrera
is logged somewhere else (maybe use the same name, and stash a .sql suffix to the filename, or use .sql.log). That way you can choose to have one or the other, or both if you're really dumb. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting

Re: [PATCHES] WIP patch - INSERT-able log statements

2007-02-19 Thread Alvaro Herrera
Guillaume Smet escribió: On 2/19/07, Alvaro Herrera [EMAIL PROTECTED] wrote: Please don't do that. We already have a combined GUC option that is used to change two different things (DateStyle) and I regularly see people confused about how to use it. Perhaps I don't understand your combined

Re: [PATCHES] further bootstrap cleanup

2007-02-19 Thread Alvaro Herrera
Heikki Linnakangas wrote: Alvaro Herrera wrote: Heikki Linnakangas wrote: Alvaro Herrera wrote: Here is a patch further cleaning up dummy process startup and the bootstrap code itself a little. Could we please call the dummy processes something else? Dummy seems a bit belittling

Re: [PATCHES] WIP patch - INSERT-able log statements

2007-02-19 Thread Alvaro Herrera
Guillaume Smet escribió: On 2/19/07, Alvaro Herrera [EMAIL PROTECTED] wrote: I don't think the syslog option is so nice to use these days; the redirect_stderr stuff is more powerful and easy to use. Did you already analyze logs of a highly loaded platform using stderr? It's impossible

Re: [PATCHES] Recalculating OldestXmin in a long-running vacuum

2007-02-19 Thread Alvaro Herrera
this work in conjunction with ITAGAKI Takahiro's patch to correct the dead tuple count estimate. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end of broadcast

Re: [PATCHES] WIP patch - INSERT-able log statements

2007-02-19 Thread Alvaro Herrera
Guillaume Smet escribió: On 2/19/07, Alvaro Herrera [EMAIL PROTECTED] wrote: So add the session ID (%c) to log_line_prefix. It could work if log_line_prefix was added before every line but it's definitely not the case: myuser mydb 45d9d615.4abe LOG: duration : 185.223 ms, statement

Re: [PATCHES] Error correction for n_dead_tuples

2007-02-19 Thread Alvaro Herrera
n_dead_tuples instead of setting it to zero. The statistics accuracy of n_dead_tuples will be better, especially just after finish of a vacuum. The behavior in VACUUM FULL is not changed because concurrent updates are not allowed during VACUUM FULL. -- Alvaro Herrera

Re: [PATCHES] WIP patch - INSERT-able log statements

2007-02-19 Thread Alvaro Herrera
yours.) So lets fix stderr by having a true per-line prefix? -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end of broadcast)--- TIP 5: don't

[PATCHES] further bootstrap cleanup

2007-02-16 Thread Alvaro Herrera
with the idea of extending it into different xlog ops. But we haven't had any. I think this is as far as I'll go with cleaning up this code in this round. Task for some other janitor ... -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command

Re: [PATCHES] [GENERAL] ISO week dates

2007-02-16 Thread Alvaro Herrera
Month month RM MON Mon mon') FROM TIMESTAMPTZ_TBL; http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=agoutidt=2007-02-16%2005:15:01 How can the table fail to exist, and yet not report a problem when it was created? -- Alvaro Herrerahttp

[PATCHES] further bootstrap cleanup

2007-02-16 Thread Alvaro Herrera
it into different xlog ops. But we haven't had any. I think this is as far as I'll go with cleaning up this code in this round. Task for some other janitor ... -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. Index: src/backend

Re: [PATCHES] [GENERAL] ISO week dates

2007-02-16 Thread Alvaro Herrera
. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate

Re: [PATCHES] [GENERAL] ISO week dates

2007-02-16 Thread Alvaro Herrera
Bruce Momjian escribió: Alvaro Herrera wrote: Andrew Dunstan escribi?: Looks to me like the timestamptz test relies on the timestamp test (for timestamp_tbl) but they are set to run in parallel, so we have a race condition. Oops! Good catch :-) I'd guess the answer

Re: [PATCHES] [GENERAL] ISO week dates

2007-02-16 Thread Alvaro Herrera
Andrew Dunstan escribió: Alvaro Herrera wrote: Bruce Momjian escribió: Alvaro Herrera wrote: Andrew Dunstan escribi?: Looks to me like the timestamptz test relies on the timestamp test (for timestamp_tbl) but they are set to run in parallel, so we have a race condition

Re: [PATCHES] [GENERAL] ISO week dates

2007-02-16 Thread Alvaro Herrera
gibberish. But perhaps it should be throwing an error message. My thinking is that erroneous patterns should throw an error, and not try to second-guess the user. (IIRC this was being discussed in some other thread not long ago). -- Alvaro Herrerahttp

Re: [PATCHES] [GENERAL] ISO week dates

2007-02-16 Thread Alvaro Herrera
and timestamptz. Thanks for the clarification. Would you have a look at the tests as they are now and confirm that that's what you wanted? I'll have a patch for proper handling of invalid formatting codes soon. And I'll be sure to test it in every way I can find to do so. Great. -- Alvaro

Re: [PATCHES] patch adding new regexp functions

2007-02-15 Thread Alvaro Herrera
have the position for each match, automatically. Is this information available in the regex code? -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast

Re: [PATCHES] Autovacuum launcher

2007-02-15 Thread Alvaro Herrera
, in_dbname))); /* our database name is gotten from the caller */ strlcpy(dbname, in_dbname, NAMEDATALEN); } } -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7

Re: [PATCHES] Autovacuum launcher

2007-02-15 Thread Alvaro Herrera
a warning comment is warranted here -- will include it when I commit the patch. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast)--- TIP 3: Have you checked our

Re: [PATCHES] patch adding new regexp functions

2007-02-15 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: so that you would have the position for each match, automatically. Is this information available in the regex code? Certainly, that's where we got the text snippets from to begin with. However, I'm not sure that this is important

[PATCHES] remove dbname arg from bootstrap mode

2007-02-15 Thread Alvaro Herrera
. Unless there are objections I intend to apply this shortly. AFAICS it doesn't need a catversion bump. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. Index: src/backend/bootstrap/bootstrap.c

Re: [PATCHES] remove dbname arg from bootstrap mode

2007-02-15 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: This little patch removes the dbname argument to InitPostgres in the bootstrap mode. It also cleans a bit of fallout: initdb uselessly passing an unused database name, postmaster starting a dummy process, and removes the -y option

Re: [PATCHES] WIP patch - INSERT-able log statements

2007-02-15 Thread Alvaro Herrera
reason for the output to be in INSERT stmts.. .. I don't think the TODO entry was particularly carefully thought out. ... which is why discussing stuff in -hackers *before* coding tends to be a good idea. -- Alvaro Herrerahttp://www.CommandPrompt.com

[PATCHES] Autovacuum launcher

2007-02-14 Thread Alvaro Herrera
appreciated. I intend to apply this in a couple of days unless there are objections. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support autovac-launcher.patch.gz Description: Binary data

Re: [HACKERS] [PATCHES] plpgsql, return can contains any expression

2007-02-09 Thread Alvaro Herrera
%. BTW, if you want this patch to make it into 8.2, it needs to be fixed and resubmitted *very* soon. I understand, but I am not able work on it in next four days. And I need help with it from Neil. It will be for 8.3. -- Alvaro Herrerahttp

Re: [PATCHES] [pgsql-patches] Phantom Command IDs, updated patch

2007-02-08 Thread Alvaro Herrera
in the orginal and new version of the patch (attached). I removed it before applying, but I just wanted to confirm this was OK. Huh, you already applied it? -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7

Re: [PATCHES] Have psql show current sequnce values - (Resubmission)

2007-02-08 Thread Alvaro Herrera
non transactional relations, but I'd suggest adding it to the TODO so that we don't forget later. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast)--- TIP

Re: [PATCHES] \prompt for psql

2007-02-08 Thread Alvaro Herrera
COMMIT or ROLLBACK based on the transaction status. Maybe it's not such a bad idea. On the other hand, seeing how the history line numbers patch is still nowhere to be seen, I don't think we should be expecting you to send a patch ... ;-) -- Alvaro Herrerahttp

Re: [PATCHES] large object regression tests, take two

2007-02-08 Thread Alvaro Herrera
about the working directory of psql during the regression tests would open a can of worms, especially wrt VPATH builds where the data files could be in a completely separate tree from the regression tests. -- Alvaro Herrerahttp://www.CommandPrompt.com

Re: [PATCHES] patch adding new regexp functions

2007-02-08 Thread Alvaro Herrera
if Evolution can do that ... (it surprised me that Thunderbird doesn't seem to be capable of searching a message based on Message-Id). -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast

Re: [PATCHES] vcbuild needs strlcat

2007-02-07 Thread Alvaro Herrera
Magnus Hagander wrote: See attached patch. Applied, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end of broadcast)--- TIP 9

Re: [PATCHES] Feature: POSIX Shared memory support

2007-02-07 Thread Alvaro Herrera
or what have you. One serious problem is that if the lock doesn't work for some reason like NFSness, it will fail silently, which is not acceptable. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc

Re: [PATCHES] Feature: POSIX Shared memory support

2007-02-07 Thread Alvaro Herrera
. The relevant code is here http://public.activestate.com/cgi-bin/perlbrowse/f/pp_sys.c -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast)--- TIP 4: Have

Re: [PATCHES] Feature: POSIX Shared memory support

2007-02-06 Thread Alvaro Herrera
? Is there an API call to list all PIDs that are connected to a particular segment? -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end of broadcast)--- TIP

Re: [PATCHES] [pgsql-patches] [GENERAL] Corrupt database? 8.1/FreeBSD6.0

2007-02-05 Thread Alvaro Herrera
does not have this problem. --- Alvaro Herrera wrote: Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Maybe we could forcibly activate the freeze mode on a template database? Might not be a bad

Re: [pgsql-patches] Autovacuum launcher patch

2007-01-29 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: The launcher is a dummy process; it never connects to any database. ... Eventually this will need to be changed so that the launcher tells the worker exactly what table to work on. I detect a certain lack of clarity of thinking

Re: [pgsql-patches] [HACKERS] Win32 WEXITSTATUS too

2007-01-22 Thread Alvaro Herrera
value., + procname, pid, WTERMSIG(exitstatus; + #endif -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast

Re: [pgsql-patches] [HACKERS] Win32 WEXITSTATUS too

2007-01-22 Thread Alvaro Herrera
stuff in there, people looking for mingw might miss it.. OK, maybe /doc or src/tools. A more radical approach would be to put the list in our documentation, or have initdb install it. Why not put it in techdocs or some such? -- Alvaro Herrerahttp

Re: [pgsql-patches] guid/uuid datatype

2007-01-20 Thread Alvaro Herrera
the user can choose the most appropriate generator, even if it's platform-specific. Or he can choose to use a client-side generator. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end

Re: [pgsql-patches] partial pg_regress patch from Magnus

2007-01-19 Thread Alvaro Herrera
Alvaro Herrera wrote: Alvaro Herrera wrote: I tested it in a VPATH and a normal build, and regression test still pass. This is mostly Magnus' code: I merely stripped out the parts unrelated to this change, and reworked the code a little. So the possible bugs are likely mine. Woops

Re: [pgsql-patches] partial pg_regress patch from Magnus

2007-01-19 Thread Alvaro Herrera
Alvaro Herrera wrote: Other than that, if I don't see objections, I'll commit it later today. Applied. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast

Re: [pgsql-patches] [PATCHES] pg_regress updates for vc++ bulid

2007-01-19 Thread Alvaro Herrera
, but it should be considerably thinner than what was in the queue. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [pgsql-patches] partial pg_regress patch from Magnus

2007-01-19 Thread Alvaro Herrera
Alvaro Herrera wrote: Alvaro Herrera wrote: Other than that, if I don't see objections, I'll commit it later today. Applied. And apparently I broke most of the buildfarm, sorry :-( Working on it. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL

[pgsql-patches] partial pg_regress patch from Magnus

2007-01-18 Thread Alvaro Herrera
-- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. Index: src/include/port.h === RCS file: /home/alvherre/Code/cvs/pgsql/src/include/port.h,v retrieving revision

Re: [pgsql-patches] partial pg_regress patch from Magnus

2007-01-18 Thread Alvaro Herrera
Alvaro Herrera wrote: I tested it in a VPATH and a normal build, and regression test still pass. This is mostly Magnus' code: I merely stripped out the parts unrelated to this change, and reworked the code a little. So the possible bugs are likely mine. Woops, it doesn't work in VPATH

Re: [pgsql-patches] [HACKERS] Autovacuum improvements

2007-01-15 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Note that currently there's no way for a backend to know whether another backend is autovacuum or not. I thought about adding a flag to PGPROC, but eventually considered it ugly, No, that was exactly the way I thought we'd do

Re: [pgsql-patches] vcbuild updates

2007-01-15 Thread Alvaro Herrera
. (Can't just set it before calling, doesn't always work when building from the GUI) Is buildenv.bat a generated file, or was it supposed to be attached? -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7

Re: [pgsql-patches] [HACKERS] Autovacuum improvements

2007-01-15 Thread Alvaro Herrera
Alvaro Herrera wrote: Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Here it is. I'd drop the InitProcess API change, which touches many more places than you really need, and just have InitProcess check IsAutoVacuumProcess(), which should be valid by the time control gets

Re: [pgsql-patches] [PATCHES] vcbuild optional packages

2007-01-14 Thread Alvaro Herrera
. Applied. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire

Re: [pgsql-patches] [GENERAL] Corrupt database? 8.1/FreeBSD6.0

2007-01-12 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Maybe we could forcibly activate the freeze mode on a template database? Might not be a bad idea. And even more to the point, forcibly disable analyze. Patch implementing this (albeit untested!) attached. I'll try to reproduce

Re: [pgsql-patches] [GENERAL] Corrupt database? 8.1/FreeBSD6.0

2007-01-12 Thread Alvaro Herrera
Alvaro Herrera wrote: Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Maybe we could forcibly activate the freeze mode on a template database? Might not be a bad idea. And even more to the point, forcibly disable analyze. Patch implementing this (albeit untested

Re: [pgsql-patches] [GENERAL] Corrupt database? 8.1/FreeBSD6.0

2007-01-12 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Ok, it does what it's intended to do. But in testing it I also confirmed that a database-wide vacuum creates a pgstat entry for it and for all tables in it. Is this something we want to prevent? That's odd, because I didn't see

Re: [pgsql-patches] [HACKERS] [PATCHES] Building libpq/psql with Borland BCC5

2007-01-10 Thread Alvaro Herrera
it ... It does build, but the report is that psql crashes after a few commands. What about a Mingw or VC++ psql with a BCC libpq? Is it possible to link something like that? It would be nice to have the libpq at least able to pass the regression tests. -- Alvaro Herrerahttp

Re: [PATCHES] Patch to log usage of temporary files

2007-01-02 Thread Alvaro Herrera
Bill Moran wrote: Thanks to Simon Riggs and Bruce for input that helped me put this together. Please change things to save the stat() syscall when the feature is not in use. Nitpick: also note our brace placement convention (though this would be fixed by pgindent, but still). -- Alvaro

Re: [PATCHES] Allow the identifier length to be increased via a configure option

2006-12-27 Thread Alvaro Herrera
. Can somebody review and comment on this? You should use pg_config.h, not mangle postgres_ext.h like that. Or maybe generate postgres_ext.h from an hypotetical postgres_ext.h.in (but I wouldn't do that, really). -- Alvaro Herrerahttp://www.CommandPrompt.com

Re: [PATCHES] Patch(es) to expose n_live_tuples and

2006-12-26 Thread Alvaro Herrera
that Bruce's proposed names seem any better to me. What's wrong with dead and live? As for backpatching, you already knew the answer :-) -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end

Re: [HACKERS] [PATCHES] Enums patch v2

2006-12-19 Thread Alvaro Herrera
to know how to reduce space lost to padding. So it would be nice to have 2-byte enums on-disk, and resolve them based on the column's typid. But then, I'm not familiar with the patch at all so I'm not sure if it's possible. -- Alvaro Herrerahttp

Re: [PATCHES] zope connection string

2006-12-04 Thread Alvaro Herrera
. If you don't it tries a Unix socket. If the TCP socket is not enabled, obviously the second line will fail. I assume the host is localhost. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc

Re: [PATCHES] [HACKERS] VPATH problems in ECPG again

2006-11-29 Thread Alvaro Herrera
Alvaro Herrera wrote: Hi, I just noticed a VPATH problem in the ecpg_config.h file that was just set up to be installed: $ pwd /pgsql/build/80_rel/src/interfaces/ecpg/include $ make install for i in ecpgerrno.h ecpglib.h ecpgtype.h sqlca.h sql3types.h ecpg_informix.h ecpg_config.h

[PATCHES] gratuituous string difference

2006-11-29 Thread Alvaro Herrera
This patch fixes a gratuituous string difference. Barring objections I'll apply shortly. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support Index: typecmds.c

Re: [PATCHES] gratuituous string difference

2006-11-29 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: This patch fixes a gratuituous string difference. Barring objections I'll apply shortly. I object. We do not quote the output of format_type_be() ... look at its code to see why not. Oh, I see -- it may add double quotes on its

Re: [HACKERS] [PATCHES] WAL logging freezing

2006-10-31 Thread Alvaro Herrera
, but the log would not be flushed for each operation that the vacuum logs. Only when it's going to commit. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end

Re: [PATCHES] WAL logging freezing

2006-10-30 Thread Alvaro Herrera
because it's a PITR related issue. I can write a patch/patches for the other changes if it helps. I'm swamped at the moment, so I'd appreciate it. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc

Re: [HACKERS] [PATCHES] WAL logging freezing

2006-10-30 Thread Alvaro Herrera
Simon Riggs wrote: On Mon, 2006-10-30 at 12:05 -0500, Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Ugh. Is there another solution to this? Say, sync the buffer so that the hint bits are written to disk? Yeah. The original design for all this is explained by the notes

Re: [PATCHES] [HACKERS] COPY does not work with regproc and aclitem

2006-10-26 Thread Alvaro Herrera
promptly ignored. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast)--- TIP 4: Have you searched our list archives? http

Re: [PATCHES] WAL logging freezing

2006-10-24 Thread Alvaro Herrera
the pg_clog cutoff point. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send

Re: [HACKERS] [PATCHES] test: please ignore

2006-10-10 Thread Alvaro Herrera
are silently dropped on- patches for some reason. Hm? They've always worked fine for me, and for a lot of other people. You should ask Marc to look into this. It depends on the MIME type IIRC. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company

Re: [PATCHES] Too many messages from Autovacuum

2006-09-26 Thread Alvaro Herrera
Simon Riggs wrote: No server settings seem appropriate to remove these... So, patch enclosed to change LOG - DEBUG1 Applied, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Re: [HACKERS] [PATCHES] Patch for UUID datatype (beta)

2006-09-19 Thread Alvaro Herrera
mentioned, using MAC address doesn't remove the possibility of a collision. It does, as I control the MAC address. What happens if you have two postmaster running on the same machine? -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company

<    1   2   3   4   5   6   7   8   >