KDE CI: Plasma plasma-integration stable-kf5-qt5 SUSEQt5.9 - Build # 8 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-integration%20stable-kf5-qt5%20SUSEQt5.9/8/ Project: Plasma plasma-integration stable-kf5-qt5 SUSEQt5.9 Date of build: Wed, 14 Feb 2018 09:21:36 + Build duration: 2 min 18 sec and counting

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos updated this revision to Diff 27139. pgkos added a comment. Fix the previous commit REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10487?vs=27138=27139 BRANCH tray-icon-size-fix REVISION DETAIL https://phabricator.kde.org/D10487

D10475: Make it possible to show the title despite having ctx actions

rkflx added a comment. Excuse the very naive question, but why is the title duplicated in the top bar in the first place? It looks very cluttered, unaligned, and jumps around depending on which buttons are in use. It seems the only situation a title on top would be useful is when the

D10495: Workaround to restore KF5 programs from system tray

stikonas added a comment. Well, basically when you click on any KF5 application (e.g. Konversation, KGpg, Akregator, etc...) in the system tray, nothing happens. This does no happen with Qt5-only programs. Clicking on system tray there always brings the window up. From what I can see

D10038: Use QTemporaryDir::filePath() instead of path concatenation

volkov closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10038 To: volkov, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10506: Move autopopulate to AppsModel

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Kickoff uses AppsModel instead of RootModel but since

Re: Latte Dock findings and maybe useful to Plasma also...

On lunedì 5 febbraio 2018 11:28:56 CET Michail Vourlakos wrote: > plasma (shellcorona) I think this is done with a flag indicating when we > are in delete mode in order to indicate when the crashing code to not be > executed... Thanks! indeed very interesting, i think we can do it every time an

D10502: Eliminate unnecessary bottom pading on OverlaySheets

ngraham updated this revision to Diff 27150. ngraham added a comment. Use a more programmatically correct approach (top_adding+buttomPadding instead of Units.gridUnit*2); this will work for clients that change the padding values REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. no. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10487 To: pgkos, #plasma_workspaces, davidedmundson Cc: ngraham,

D10480: align checkable widgets in menu items

hpereiradacosta added a comment. > F5710580: Screenshot_20180214_002713.png > > Why are there only 2 pixels? Because the darker pixel, around the menu is also part of the menu, not the shadow. (meaning, there is a one pixel frame that is

D10461: GMenu-DBusMenu-Proxy

broulik updated this revision to Diff 27142. broulik edited the test plan for this revision. broulik added a comment. - Support unity actions (untested) - Don't mandate actions to be present, it's perfectly valid for a window to have a menu only consisting of application actions or

D10505: [konsolesession runner] Rename to konsoleprofiles, no sessions here

kossebau added a subscriber: ltoscano. kossebau added a comment. @ltoscano Some question about the translation catalog which gets renamed here as well, from "plasma_runner_konsolesessions" to "plasma_runner_konsoleprofiles": Plasma 5.12 branch has the konsolesessions.po catalogs

D10475: Make it possible to show the title despite having ctx actions

ngraham added a comment. @rkflx Not naive at all! In this patch, we are trying to solve the general case of how a navigation header with context actions should look. Once we implement this control in Discover, we will //definitely// be removing the title from the app page's use of it,

D10461: GMenu-DBusMenu-Proxy

broulik added a comment. > So, Unity is dead, but unity action prefixes is live. I just added support for that but I don't know what apps use it to test it, if you may..? :) > To use unity-gtk-module or appmenu-gtk-module you need to install it into correct location (where all gtk

D10505: [konsolesession runner] Rename to konsoleprofiles, no sessions here

kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Possibly because the runner was based on the kate session

D10506: Move autopopulate to AppsModel

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10506 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10502: Eliminate unnecessary bottom pading on OverlaySheets

apol added inline comments. INLINE COMMENTS > OverlaySheet.qml:270 > width: root.contentItem.implicitWidth <= 0 ? mainItem.width : > Math.max(mainItem.width/2, Math.min(mainItem.width, > root.contentItem.implicitWidth)) > -height: scrollView.flickableItem && >

D10461: GMenu-DBusMenu-Proxy

rilian added a comment. 1. Yes, menubar may be empty with appmenu-gtk-module or unity-gtk-module, and if I can fix appmenu-gtk-module, unity-gtk-module will not be fixed. So, I think it is preferred to check on your side. 2. GTK3 applications (file-roller, for example) can use both appmenu

D10506: Move autopopulate to AppsModel

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a0ca2d1bc204: [Kicker] Move autoPopulate to AppsModel (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10506?vs=27145=27148 REVISION

D10502: Eliminate unnecessary bottom pading on OverlaySheets

ngraham edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10502 To: ngraham, #kirigami, apol Cc: plasma-devel, apol, davidedmundson, mart, hein

D10502: Eliminate unnecessary bottom pading on OverlaySheets

ngraham marked an inline comment as done. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10502 To: ngraham, #kirigami, apol Cc: plasma-devel, apol, davidedmundson, mart, hein

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos updated this revision to Diff 27138. pgkos added a comment. Return to previous version, which was better. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10487?vs=27114=27138 BRANCH tray-icon-size-fix REVISION DETAIL

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

mwolff added inline comments. INLINE COMMENTS > xwindowtasksmodel.cpp:516 > + > +QUrl url= windowUrlFromMetadata(info->windowClassClass(), > NETWinInfo(QX11Info::connection(), window, > QX11Info::appRootWindow(), NET::WMPid, 0).pid(), `const auto url = ...`; note the space after

D10461: GMenu-DBusMenu-Proxy

broulik added a comment. Hi Konstantin, thank you very much for your input! > One can be missing, and then incomplete menu should render: In Plasma we don't typically use this separate "app menu" (although I'd like to do that but as a separate menu), so what I do is I show the

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos added a comment. I have returned to the previous version, as the version which used units.smallSpacing looked awful. Yes, it uses magic constant 0.85, but it really looks much better. I have patched the digital clock height too, so it perfectly matches the height of the tray

KDE CI: Plasma plasma-integration stable-kf5-qt5 SUSEQt5.9 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-integration%20stable-kf5-qt5%20SUSEQt5.9/7/ Project: Plasma plasma-integration stable-kf5-qt5 SUSEQt5.9 Date of build: Tue, 13 Feb 2018 13:15:54 + Build duration: 19 hr and counting

D10461: GMenu-DBusMenu-Proxy

rilian added a comment. Thanks so much) 1. Unity is dead, but I forked unity-gtk-module, patched it for all distros, fixed some bugs and called appmenu-gtk-module. So, Unity is dead, but unity action prefixes is live. 2. To use unity-gtk-module or appmenu-gtk-module you need to

D10512: try to preload certain applets in a smart way

mart updated this revision to Diff 27163. mart added a comment. - silence warnings REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10512?vs=27162=27163 BRANCH mart/preload REVISION DETAIL https://phabricator.kde.org/D10512 AFFECTED

D10513: Fix launching by touchscreen tap

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10513 To: hein, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10502: Eliminate unnecessary bottom padding on OverlaySheets

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH less-popup-padding REVISION DETAIL https://phabricator.kde.org/D10502 To: ngraham, #kirigami, apol, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D10461: GMenu-DBusMenu-Proxy

rilian added a comment. What about FIXME unity, what are you mean? I can fix appmenu-gtk-module for you. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10461 To: broulik, #plasma Cc: rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, progwolff,

D10513: Fix launching by touchscreen tap

hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY The mouse handling code relied on onPositionChanged to do setup work prior to onPressed. This is never guaranteed, but it's is

D10513: Fix launching by touchscreen tap

This revision was automatically updated to reflect the committed changes. Closed by commit R119:31bcd0ac9590: Fix launching by touchscreen tap (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10513?vs=27165=27166 REVISION DETAIL

D10507: Turn code.js into a singleton

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise we would create an instance of this JS file for

D10461: GMenu-DBusMenu-Proxy

broulik added a comment. Thanks for your input! > Yes, menubar may be empty Okay. Problem is that for example LibreOffice doesn't have a menu right away, so I can't realy tell "no menu because it's still loading" or "no menu because it doesn't have one" and then fallback to app

D10512: try to preload certain applets in a smart way

mart updated this revision to Diff 27169. mart added a comment. - correct typo REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10512?vs=27163=27169 BRANCH mart/preload REVISION DETAIL https://phabricator.kde.org/D10512 AFFECTED

D10461: GMenu-DBusMenu-Proxy

rilian added a comment. If you need help, I will provide it for you, because for me there is 2 features which should be in KDE for me: 1. Global Menu (for all protocols) 2. QGtkStyle (with GTK3 themes) > Okay. Problem is that for example LibreOffice doesn't have a menu right

D10502: Eliminate unnecessary bottom pading on OverlaySheets

apol added a comment. +1 makes sense to me. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10502 To: ngraham, #kirigami, apol Cc: plasma-devel, apol, davidedmundson, mart, hein

D10461: GMenu-DBusMenu-Proxy

rilian added a comment. UPD: disabled an exporting of empty menubar on X11. Try latest appmenu-gtk-module master, please. I do not know how to do it in GTK Wayland. Can you explain me KDE Wayland Global Menu architecture? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10510: Fix window pin not showing

This revision was automatically updated to reflect the committed changes. Closed by commit R119:840694cc5bbe: Fix window pin not showing (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10510?vs=27157=27160 REVISION DETAIL

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

ngraham added a comment. Going up from the 0.71 magic number to the 0.85 magic number would make the clock bigger than it currently is, no? Can you supply a screenshot of how this works now at standard size, increased size, and witha high-DPI display? Since magic numbers are bad, and

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

davidedmundson added a comment. The part I care about is deciding what the problem is, and understanding the code around it. The goal apparently was to match the application icon on the left, which means any patch needs to be able to describe the current padding that happens there, and

D10510: Fix window pin not showing

hein created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY showPin oscillates during startup and the prop being null'd on destroy() is not sync, so this creates a

D10510: Fix window pin not showing

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10510 To: hein, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10502: Eliminate unnecessary bottom padding on OverlaySheets

ngraham retitled this revision from "Eliminate unnecessary bottom pading on OverlaySheets" to "Eliminate unnecessary bottom padding on OverlaySheets". REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10502 To: ngraham, #kirigami, apol Cc: plasma-devel, apol,

D10461: GMenu-DBusMenu-Proxy

rilian added a comment. O, some another note: You can generate menubar from appmenu. For example, Nautilus: It have 4 sections 1. New Window 2. Sidebar 3. Preferences 4. Keyboard Shortcuts Help About Quit. You can add New Window and Quit to File menu, Sidebar to View,

D10512: try to preload certain applets in a smart way

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mart requested review of this revision. REVISION SUMMARY preload popups of some applets after init in the

D10475: Make it possible to show the title despite having ctx actions

apol updated this revision to Diff 27167. apol added a comment. Fix placement of the navigation arrows REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10475?vs=27129=27167 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10475 AFFECTED

D10502: Eliminate unnecessary bottom padding on OverlaySheets

ngraham closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10502 To: ngraham, #kirigami, apol, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

Re: Closing old Plasma 4 bugs

On 10.02.2018 21:24, Nate Graham wrote: Hello folks, We have more than 2,500 Plasma 4 bugzilla tickets that we don't intend to look at or triage. We've already prevented new tickets from being filed, but it doesn't do anyone any good to just have the old ones sitting there. My sense is that most

D10475: Make it possible to show the title despite having ctx actions

rkflx added a comment. @ngraham > In this patch, we are trying to solve the general case of how a navigation header with context actions should look. I see, but I'm afraid with only a single example (which should be solved differently anyway) it is going to be hard to reach a

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

davidedmundson added a comment. Thanks, that's much more the sort of thought process I'm looking for! > the tray icons are SVG icons, but the application shorcut icons are bitmaps. All application icons are SVGs and they both ultimately come from IconItem? I think we might find

D10516: Update status to NeedsAttention when there is a menu

mvourlakos edited the test plan for this revision. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D10516 To: mvourlakos, martinkostolny Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10516: Update status to NeedsAttention when there is a menu

mvourlakos created this revision. mvourlakos added a reviewer: martinkostolny. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY Following the discussion at:

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

anthonyfieroni added inline comments. INLINE COMMENTS > main.qml:42 > property bool vertical: plasmoid.formFactor == PlasmaCore.Types.Vertical > -property int itemSize: units.roundToIconSize(Math.min(Math.min(width, > height),

D10515: Have all krunner plugin desktop files prefixed with "plasma-runner-"

kossebau created this revision. kossebau added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY With all desktop files being installed in

D10251: [RFC] Use mipmap filtering in window thumbnails

ngraham added a comment. Crisper would definitely be nicer too, but if that's too hard, this is already a big visual win even in its current state. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg Cc: ngraham,

D10480: align checkable widgets in menu items

zzag added a comment. > So 5 does makes sense: there is 1 for the frame, and then 4, that matches the spacing. Right ? Yes, I guess so. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10480 To: zzag, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, ZrenBot,

D10495: Workaround to restore KF5 programs from system tray

stikonas abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D10495 To: stikonas, wbauer, #plasma, davidedmundson, volkov Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai,

D10516: Update status to NeedsAttention when there is a menu

martinkostolny accepted this revision. martinkostolny added a comment. This revision is now accepted and ready to land. Thanks for fixing my code! :) I'm sure I can also provide a flag for menu availability (the code for appmenu is copied for now anyway). But I think in AWC it does not

D10516: Update status to NeedsAttention when there is a menu

mvourlakos added a comment. In D10516#206437 , @martinkostolny wrote: > Thanks for fixing my code! :) can you please confirm also the update that follows @broulik suggestion? I confirmed with Latte that everything works flawlessly now.

D10515: Have all krunner plugin desktop files prefixed with "plasma-runner-"

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ddfc158a6715: Have all krunner plugin desktop files prefixed with plasma-runner- (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10515?vs=27170=27183#toc REPOSITORY

D10516: Update status to NeedsAttention when there is a menu

mvourlakos updated this revision to Diff 27186. mvourlakos added a comment. followed @broulik suggestions and added also an improvement to not update menu index all the time when changing from menu to menu REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE

D10498: Workaround the touchpad toggle button not working

aacid closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10498 To: aacid, davidedmundson, xuetianweng Cc: knambiar, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10475: Make it possible to show the title despite having ctx actions

ngraham added a comment. I agree with @rkflx. I think we need to step back here and do some more long, hard design work before we rush to implementation. The proposed approach will not work for most narrow headers as there will simply not be enough room for navigation buttons, a title,

D10475: Make it possible to show the title despite having ctx actions

rkflx added a comment. Oops, I really didn't want to block progress here. I think the only thing which needs clarification is what "title" entails in relation to the rest of the app, perhaps with a couple of examplary use cases. Another approach would be to define the text element as a

D10475: Make it possible to show the title despite having ctx actions

ngraham added a comment. Don't worry Henrik, you're all good. The underlying issue here is that we haven't actually done the necessary design work for this feature yet. The appropriate Kirigami HIG section is empty: https://community.kde.org/KDE_Visual_Design_Group/KirigamiHIG#Bars If

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos added a comment. There is something wrong and inconstent about SVG icon scaling. For example, if I put this line in systemtray ui main QML code instead: `property int itemSize: Math.min(width, height)` then the KDE Connect icon completely fills the height of the panel.

D10512: try to preload certain applets in a smart way

apol added a comment. It sounds like it should be the shell who decides what needs preloading, rather than the framework guessing it. INLINE COMMENTS > appletquickitem.cpp:87 > +//some applet types we want a bigger weight > +if

D10516: Update status to NeedsAttention when there is a menu

broulik added a comment. Thanks for looking into this! I could prefer a QML binding that also takes into account wheter there is a menu at all, something like Plasmoid.status: { if (currentIndex > -1) { return PlasmaCore.Types.NeedsAttentionStatus; }

D10512: try to preload certain applets in a smart way

ngraham added a comment. Let's keep in mind the PR aspect of this: if we end up 30 MB heavier and a few seconds slower on a cold boot for a new install, advanced users who frequent internet forums and write reviews will notice this, but they probably won't notice that some widgets open more

D10495: Workaround to restore KF5 programs from system tray

stikonas updated this revision to Diff 27181. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10495?vs=27106=27181 REVISION DETAIL https://phabricator.kde.org/D10495 AFFECTED FILES src/kstatusnotifieritem.cpp To: stikonas, wbauer, #plasma,

D10495: Workaround to restore KF5 programs from system tray

stikonas reclaimed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D10495 To: stikonas, wbauer, #plasma, davidedmundson, volkov Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai,

D10495: Workaround to restore KF5 programs from system tray

stikonas abandoned this revision. stikonas added a comment. Le's close it in favour of https://phabricator.kde.org/D10518 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D10495 To: stikonas, wbauer, #plasma, davidedmundson, volkov Cc: graesslin, #kwin,

D10512: try to preload certain applets in a smart way

mart added inline comments. INLINE COMMENTS > apol wrote in appletquickitem.cpp:87 > Isn't X-Plasma-PreloadWeight for that? It's to have some default weights without having to populate every desktop file REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D10512: try to preload certain applets in a smart way

broulik added a comment. Cool! Since this is all applet quick item stuff it will just work™ with applet within system tray? Would be nice to have some `qCInfo` in there somewhere so we can better understand what it's doing, when it's increasing/decreasing the rating, when it's

D10512: try to preload certain applets in a smart way

davidedmundson added inline comments. INLINE COMMENTS > appletquickitem.cpp:789 > +if (!d->applet->isContainment()) { > +applet()->config().writeEntry(QStringLiteral("PreloadWeight"), > qMin(d->preloadWeight() + s_preloadWeigthIncrement, 100)); > +} So if you ever

D10516: Update status to NeedsAttention when there is a menu

mvourlakos added a comment. In D10516#206373 , @broulik wrote: > Thanks for looking into this! > > I could prefer a QML binding that also takes into account wheter there is a menu at all, something like > > Plasmoid.status: { >

D10515: Have all krunner plugin desktop files prefixed with "plasma-runner-"

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH consistentkrunnerdesktopfilenames REVISION DETAIL https://phabricator.kde.org/D10515 To: kossebau, #plasma, broulik, apol Cc: plasma-devel, ZrenBot, progwolff,

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

cfeck added a reviewer: hein. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10342 To: jtamate, #plasma_workspaces, hein Cc: mwolff, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10500: Make the review pop-up a bit more user-friendly

anemeth added a comment. What purpose does the empty space serve? If it has no purpose then the Review textbox could be larger or the window smaller. F5711965: review,_empty.png REPOSITORY R134 Discover Software Store REVISION DETAIL

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos added a comment. It seems the problem is not with SVG icons, but with the systemtray code. If I make the systemtray's Flow's marginHints zero, the padding is preserved correctly! No magic constant is needed anymore: //Do spacing with margins, to correctly compute the number of

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

jtamate updated this revision to Diff 27177. jtamate added a comment. - From 1.03% to 0.08% cpu usage moving 50.000 files fixed mwolf comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10342?vs=26937=27177 BRANCH vivaldi (branched from

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

jtamate marked 2 inline comments as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10342 To: jtamate, #plasma_workspaces Cc: mwolff, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Report on Plasma Wayland 5.13 Meeting at 18-02-14

We set ourselves the following goals for Wayland on Plasma 5.13: * Upgrade Neon base --> Neon team, bshah * Don't force QT_QPA_PLATFORM=wayland --> Mgraesslin * Screen capture / Remote desktop --> Kanedias, reviewed by d_ed and romangg * Security of KWin scripts (see notes) --> Mgraesslin * Mouse

D10500: Make the review pop-up a bit more user-friendly

ngraham added a comment. The empty space on the bottom is a bug in Kirigami that I fixed this morning with D10502: Eliminate unnecessary bottom padding on OverlaySheets . The star rating change is a good idea (because yeah, 1 star as the default is

D10516: Update status to NeedsAttention when there is a menu

broulik added a comment. Oh, sorry, I assumed from the name of the files it was plasma-workspace :) lgtm! REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D10516 To: mvourlakos, martinkostolny Cc: broulik, plasma-devel, ZrenBot,

D10485: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version

This revision was automatically updated to reflect the committed changes. Closed by commit R119:502e8dc1080f: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version (authored by kossebau). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D10512: try to preload certain applets in a smart way

broulik added inline comments. INLINE COMMENTS > appletquickitem.cpp:789 > +if (!d->applet->isContainment()) { > +applet()->config().writeEntry(QStringLiteral("PreloadWeight"), > qMin(d->preloadWeight() + s_preloadWeightIncrement, 100)); > +} I was also wondering

D9638: [effects] replace old slide effect with a new one

zzag updated this revision to Diff 27190. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. rebase on master REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9638?vs=26788=27190 BRANCH effects/slide REVISION DETAIL

D10516: Update status to NeedsAttention when there is a menu

mvourlakos added a comment. In D10516#206458 , @broulik wrote: > Oh, sorry, I assumed from the name of the files it was plasma-workspace :) lgtm! :) if this is accepted, then I will try to send a fix for plasma menu also afterwards...

D10521: Accidental diff. Sorry.

anemeth abandoned this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10521 To: anemeth Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10521: Added vertical separator

anemeth created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D10521 AFFECTED FILES

D10521: Accidental diff. Sorry.

anemeth retitled this revision from "Added vertical separator" to "Accidental diff. Sorry.". REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10521 To: anemeth Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10521: Accidental diff. Sorry.

anemeth removed R31 Breeze as the repository for this revision. anemeth removed a project: Plasma. anemeth removed a subscriber: plasma-devel. REVISION DETAIL https://phabricator.kde.org/D10521 To: anemeth Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:d435e886d56d: Use Kirgami.ToolBarApplicationHeader instead of the view headers (authored by apol). REPOSITORY R134

D10522: Added vertical separator

anemeth created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D10522 AFFECTED FILES

D10522: Added vertical separator

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: ngraham, hpereiradacosta, Breeze, VDG. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10522 To: anemeth, ngraham, hpereiradacosta, #breeze, #vdg Cc:

D10522: Added vertical separator

ngraham added a comment. Reminds me of Windows. I think I could get used to the vertical line, but I don't like how the horizontal lines intersect with it. Makes the menu look like a grid. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10522 To: anemeth, ngraham,

D10507: Turn code.js into a singleton

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10507 To: broulik, #plasma, hein, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

  1   2   >