Re: Review Board 1.7.9 is released

2013-06-06 Thread Bruce Cran
Thanks, that was the problem: everything except diffviewer_filediffdata, extensions_registerextension and reviews_reviewrequest_dependson were in MyISAM format. I converted everything to InnoDB and the upgrade worked (after restoring from a backup - running 'rb-site upgrade' again resulted in

Re: Review Board 1.7.9 is released

2013-06-04 Thread pfee
Hi Christian, Stephen, While testing Stephen's Fedora packages, on a F18 machine I upgraded from 1.7.7.1 to 1.7.9. Following the upgrade, I expected visiting the site's /dashboard URL would have told me to run rb-site upgrade. Instead I got a 500 Something broke... message. Despite not

Re: Review Board 1.7.9 is released

2013-06-04 Thread pfee
Hi Christian, Using Firefox/Firebug, I see that the icon above the My Account, Admin, Log Off menu is server from an external site: http://www.gravatar.com/avatar/0657fda85d3463a3e0784bc6f2e14b69?s=32 Is there a reason why this isn't bundled with ReviewBoard? Someone using ReviewBoard from a

Re: Review Board 1.7.9 is released

2013-06-04 Thread Stephen Gallagher
On Tuesday, June 4, 2013, pfee wrote: Hi Christian, Stephen, While testing Stephen's Fedora packages, on a F18 machine I upgraded from 1.7.7.1 to 1.7.9. Following the upgrade, I expected visiting the site's /dashboard URL would have told me to run rb-site upgrade. Instead I got a 500

Re: Review Board 1.7.9 is released

2013-06-04 Thread Christian Hammond
On Jun 4, 2013, at 2:44 AM, Stephen Gallagher step...@gallagherhome.com wrote: On Tuesday, June 4, 2013, pfee wrote: Hi Christian, Stephen, While testing Stephen's Fedora packages, on a F18 machine I upgraded from 1.7.7.1 to 1.7.9. Following the upgrade, I expected visiting the site's

Re: Review Board 1.7.9 is released

2013-06-04 Thread Christian Hammond
Hi Paul, We've had gravatar support ever since 1.7 came out. Gravatar.com is pretty much the de-facto standard avatar provider out there, which lots of services and even developer tools integrate with. We're optimizing for the 99% case where you at least have a proxy server set up to reach

Re: Review Board 1.7.9 is released

2013-06-04 Thread Stephen Gallagher
On 06/04/2013 05:47 AM, Christian Hammond wrote: On Jun 4, 2013, at 2:44 AM, Stephen Gallagher step...@gallagherhome.com mailto:step...@gallagherhome.com wrote: On Tuesday, June 4, 2013, pfee wrote: Hi Christian, Stephen, While testing Stephen's Fedora packages, on a F18 machine

Re: Review Board 1.7.9 is released

2013-06-04 Thread pfee
Thanks for the explanation. I wasn't aware of gravatar, hence I can view this as a feature not a bug :) On Tuesday, 4 June 2013 10:51:00 UTC+1, Christian Hammond wrote: Hi Paul, We've had gravatar support ever since 1.7 came out. Gravatar.com is pretty much the de-facto standard avatar

Re: Review Board 1.7.9 is released

2013-06-04 Thread victoria
On Tue, Jun 4, 2013 at 1:47 PM, Stephen Gallagher step...@gallagherhome.com wrote: On 06/04/2013 05:47 AM, Christian Hammond wrote: On Jun 4, 2013, at 2:44 AM, Stephen Gallagher step...@gallagherhome.com mailto:step...@gallagherhome.com wrote: On Tuesday, June 4, 2013, pfee wrote:

Re: Review Board 1.7.9 is released

2013-06-04 Thread Stephen Gallagher
On 06/04/2013 09:15 AM, victoria wrote: On Tue, Jun 4, 2013 at 1:47 PM, Stephen Gallagher step...@gallagherhome.com mailto:step...@gallagherhome.com wrote: On 06/04/2013 05:47 AM, Christian Hammond wrote: On Jun 4, 2013, at 2:44 AM, Stephen Gallagher

Re: Review Board 1.7.9 is released

2013-06-04 Thread Christian Hammond
Hi Bruce, Make sure of the following: 1) The configured account for your MySQL that Review Board is using has full permissions on the database. 2) You're not mixing MyISAM and InnoDB tables in the database. Christian On Jun 4, 2013, at 6:35, Bruce Cran bruce.c...@gmail.com wrote: 1.7.9

Re: Review Board 1.7.9 is released

2013-06-04 Thread Bruce Cran
1.7.9 is out, with fixes to installation issues people have hit and reported (thanks!). My installation failed to upgrade from 1.7.6, with what looks to be a foreign key issue: -- begin log output -- Creating tables ... Upgrading Review Board from 1.7.6 to

Re: Review Board 1.7.9 is released

2013-06-04 Thread Stephen Gallagher
On 06/04/2013 09:19 AM, Stephen Gallagher wrote: On 06/04/2013 09:15 AM, victoria wrote: On Tue, Jun 4, 2013 at 1:47 PM, Stephen Gallagher step...@gallagherhome.com mailto:step...@gallagherhome.com wrote: On 06/04/2013 05:47 AM, Christian Hammond wrote: On Jun 4, 2013, at 2:44 AM,

Review Board 1.7.9 is released

2013-06-03 Thread Christian Hammond
1.7.9 is out, with fixes to installation issues people have hit and reported (thanks!). It also adds API for getting the Blocks/Depends On fields for a Review Request resource. Previously, this was only available in the draft.

Re: Review Board 1.7.9 is released

2013-06-03 Thread Stephen Gallagher
On 06/03/2013 03:41 PM, Christian Hammond wrote: 1.7.9 is out, with fixes to installation issues people have hit and reported (thanks!). It also adds API for getting the Blocks/Depends On fields for a Review Request resource. Previously, this was only available in the draft.

Re: Review Board 1.7.9 is released

2013-06-03 Thread Christian Hammond
On Mon, Jun 3, 2013 at 1:29 PM, Stephen Gallagher step...@gallagherhome.com wrote: On 06/03/2013 03:41 PM, Christian Hammond wrote: 1.7.9 is out, with fixes to installation issues people have hit and reported (thanks!). It also adds API for getting the Blocks/Depends On fields for a

Re: Review Board 1.7.9 is released

2013-06-03 Thread Christian Hammond
Hi, Looks like our request parameter injection support isn't working on your setup. I'll need to know more about your setup to know why. What's your web server setup like? Are you using Apache and mod_wsgi, or some other configuration? Do you have any custom modifications at all to Review

Re: Review Board 1.7.9 is released

2013-06-03 Thread Angus Ku
Hi all, I just upgraded my review board site from 1.7.7.1 to 1.7.9. But, when I go to the view diff page of all my post review requests, I got following error messages. _log() got an unexpected keyword argument 'request' Traceback (most recent call last): File

Re: Review Board 1.7.9 is released

2013-06-03 Thread Angus Ku
Hi Christian, Thanks for your reply. I just follow the standard installation guide from the website to setup my server using Apache and mod_wsgi. I don't do any custom modifications for all ReviewBoard files and settings. But, I think i got a message an evolution is required when I run rb-site

Re: Review Board 1.7.9 is released

2013-06-03 Thread Christian Hammond
Hi Angus, The evolution is required message is normal, and just part of our standard database migration work that rb-site does on your behalf. Can you verify for me what version of Djblets is installed? You can do: rb-site manage /path/to/site shell import djblets

Re: Review Board 1.7.9 is released

2013-06-03 Thread Angus Ku
Hi Christian, Here is the result, import djbPython 2.7.3 (default, Aug 1 2012, 05:14:39) [GCC 4.6.3] on linux2 Type help, copyright, credits or license for more information. (InteractiveConsole) le import djblets djblets.__file__

Re: Review Board 1.7.9 is released

2013-06-03 Thread Christian Hammond
Hi Angus, You're definitely running an old version of Djblets. That would explain it, though I can't explain why you would be on that version. Is there a Djblets-0.7.15-py2.7.egg directory alongside the 0.7.12 directory by any chance? Christian -- Christian Hammond - chip...@chipx86.com

Re: Review Board 1.7.9 is released

2013-06-03 Thread Angus Ku
Hi Christian, There is no Djblets-0.7.15-py2.7.egg folder in my /usr/local/lib/python2.7/dist-packages directory. So, I tried to run easy_install -U Djblets manually and Djblets 0.7.15 can be downloaded. After that, I use easy_install -U ReviewBoard to upgrade to 1.7.9 and then the issue is

Re: Review Board 1.7.9 is released

2013-06-03 Thread Christian Hammond
Hi Angus, Looks like there's a small issue in the dependency rule that breaks easy_install's resolution for the version. Packagers, I'm going to be deploying a quick hotfix update to this, but without a version number bump. It's nothing but a package metadata change. Since you control your