date:20140924

Hi everyone,

Early this morning, we put out a release of Review Board 2.0.8. This fixes some 
of the major issues recently brought up on this list, including several issues 
in the New Review Request page, installation problems due to a new release of 
Python-Markdown, and more.

Announcement: 
https://www.reviewboard.org/news/2014/09/24/review-board-2-0-8-released/
Release notes: https://www.reviewboard.org/docs/releasenotes/reviewboard/2.0.8/

As a reminder, we also announce new releases of Review Board, Power Pack, and 
soon some new free Review Board extensions on our mailing list at 
https://www.reviewboard.org/mailing-lists/

You can also follow us on Twitter (https://twitter.com/reviewboard), Facebook 
(https://www.facebook.com/reviewboard.org), and Google+ 
(https://plus.google.com/+reviewboardorg).

Christian

--  
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org  
Beanbag, Inc. - https://www.beanbaginc.com


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

rbt patch failing with perforce

2014-09-24 Thread Henrique de Miranda Gontijo

Hi,

I want to ask help with an issue with rbt patch + perforce.
When I try to apply a patch from review board by using rbt patch, the tool 
fails with a can't find the file to patch error.

$ rbt patch --server https://reviewboard.eng.mydomain.com/ --debug 
--username hgontijo --repository perforce 674130
 RBTools 0.6.2
 Python 2.7.5 (default, Mar  9 2014, 22:15:05) 
[GCC 4.2.1 Compatible Apple LLVM 5.0 (clang-500.0.68)]
 Running on Darwin-13.3.0-x86_64-i386-64bit
 Home = /Users/hgontijo
 Current directory = 
/Users/hgontijo/Perforce/projects/mydomain/p4/vc/vim-clients/vimclients-2015
 Checking for a Subversion repository...
 Running: svn info --non-interactive
 Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: E155007: 
'/Users/hgontijo/Perforce/projects/mydomain/p4/vc/vim-clients/vimclients-2015' 
is not a working copy
---
 Checking for a Git repository...
 Running: git rev-parse --git-dir
 Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
 Checking for a Mercurial repository...
 Unable to execute hg --help: skipping Mercurial
 Checking for a CVS repository...
 Unable to execute cvs: skipping CVS
 Checking for a Perforce repository...
 Running: p4 info
 Running: diff --version
 repository info: Path: ['perforce-vc.eng.mydomain.com:1648', 
'43.8.17.10.in-addr.arpa:1648'], Base path: None, Supports changesets: True
 Making HTTP GET request to https://reviewboard.eng.mydomain.com/api/

== HTTP Authentication Required
Enter authorization information for Web API at 
reviewboard.eng.mydomain.com
Password: 
 Making HTTP GET request to 
https://reviewboard.eng.mydomain.com/api/info/
 Making HTTP GET request to 
https://reviewboard.eng.mydomain.com/api/review-requests/674130/diffs/
 Making HTTP GET request to 
https://reviewboard.eng.mydomain.com/api/review-requests/674130/diffs/1/
 Making HTTP GET request to 
https://reviewboard.eng.mydomain.com/api/review-requests/674130/diffs/1/
*Patch is being applied from request 674130 with diff revision  1.*
* Running: patch -i 
/var/folders/vj/zkmcf_214hg78y1md49qgm_c002glm/T/tmp54TMeV*
*Failed to execute command: ['patch', '-i', 
'/var/folders/vj/zkmcf_214hg78y1md49qgm_c002glm/T/tmp54TMeV']*
*can't find file to patch at input line 3*
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--
|--- 
//depot/vim-clients/vimclients-2015/applications/vsphere-client/server/cm-service/src/main/java/com/mydomain/vsphere/client/cm/util/ServerPropertyValueExtractor.java
 
//depot/vim-clients/vimclients-2015/applications/vsphere-client/server/cm-service/src/main/java/com/mydomain/vsphere/client/cm/util/ServerPropertyValueExtractor.java#42
|+++ 
//depot/vim-clients/vimclients-2015/applications/vsphere-client/server/cm-service/src/main/java/com/mydomain/vsphere/client/cm/util/ServerPropertyValueExtractor.java
 2014-09-24 
11:24:26
--
File to patch: 
Skip this patch? [y] 
Skipping patch.
8 out of 8 hunks ignored

===

I notice that when I execute rbt patch from the file folder, the patch is 
applied successfully:

$ cd 
applications/vsphere-client/server/cm-service/src/main/java/com/mydomain/vsphere/client/cm/util/
$ rbt patch --server https://reviewboard.eng.mydomain.com/ --debug 
--username hgontijo --repository perforce 674130
 RBTools 0.6.2
 Python 2.7.5 (default, Mar  9 2014, 22:15:05) 
[GCC 4.2.1 Compatible Apple LLVM 5.0 (clang-500.0.68)]
 Running on Darwin-13.3.0-x86_64-i386-64bit
 Home = /Users/hgontijo
 Current directory = 
/Users/hgontijo/Perforce/projects/mydomain/p4/vc/vim-clients/vimclients-2015/applications/vsphere-client/server/cm-service/src/main/java/com/mydomain/vsphere/client/cm/util
 Checking for a Subversion repository...
 Running: svn info --non-interactive
 Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: E155007: 
'/Users/hgontijo/Perforce/projects/mydomain/p4/vc/vim-clients/vimclients-2015/applications/vsphere-client/server/cm-service/src/main/java/com/mydomain/vsphere/client/cm/util'
 
is not a working copy
---
 Checking for a Git repository...
 Running: git rev-parse --git-dir
 Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
 Checking for a Mercurial repository...
 Unable to execute hg --help: skipping Mercurial
 Checking for a CVS repository...
 Unable to execute cvs: skipping CVS
 Checking for a Perforce repository...
 Running: p4 info
 Running: diff --version
 repository info: Path: ['perforce-vc.eng.mydomain.com:1648', 
'43.8.17.10.in-addr.arpa:1648'], Base path: None, Supports changesets: True
 Making HTTP GET request to https://reviewboard.eng.mydomain.com/api/

== HTTP Authentication Required
Enter authorization information for Web API at 
reviewboard.eng.mydomain.com
Password: 
 Making HTTP GET request to

Re: please, please, please, please help me with installation

Hi Neel,

lighttpd is not well-supported, which is why it's considered an advanced 
option. Very few people seem to use it.

I'd *strongly* suggest using Apache + mod_wsgi (daemon mode works well these 
days), if at all possible. You'll have the best support that way.

FastCGI is a bad option. We've seen people hit all sorts of issues with it. The 
Python community has rallied around mod_wsgi and similar solutions instead.

I think you'll find that if you use the standard recommended options from 
rb-site, you'll have a much easier time getting going.

As for the 000-default file, I'm sorry it cost you an hour of time. It is 
annoying that Apache ships that..

Christian

--  
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org  
Beanbag, Inc. - https://www.beanbaginc.com


On September 24, 2014 at 7:47:23 AM, neel roy (neelsm...@rediffmail.com) wrote:
 It's 8:10 pm and I have been fighting with reviewboard installation for
 last SIX hours.
  
 I tried with apache2 and I ran into 000-default site problem.. from
 https://www.reviewboard.org/docs/manual/dev/admin/installation/creating-sites/#creating-sites:
   
  
 Some Apache installations (such as the default installs on Debian and
 Ubuntu) by default define a global virtual host that shares /var/www as the
 document root. This may lead to problems with your install. If you access
 your site and see nothing but a directory listing, then you’re affected by
 this problem.
  
 The solution is to remove the “default” site from your
 /etc/apache2/sites-enabled directory. This may be called something like
 default or 000-default.
  
  
 Then I had to figure out after an hour that I had to specify --web-server
 if I want to use lighttpd.
  
  
 After that there were some few more errors (I can go into details but I
 don't think that's going to help my cause). So here is process I have
 followed:
  
  
 http://alephnullplex.appspot.com/blog/view/2009/07/09/tutorial-installing-review-board-on-ubuntu
   
  
  
 Replace installation of apache2 with lighttpd and mod-python with fastcgi.
 Nothing works. Right now I am here:
  
 *rb-site manage /var/www/reviewboard runfcgi method=threaded*
  
 WSGIServer: missing FastCGI param REQUEST_METHOD required by WSGI!
  
 WSGIServer: missing FastCGI param SERVER_NAME required by WSGI!
  
 WSGIServer: missing FastCGI param SERVER_PORT required by WSGI!
  
 WSGIServer: missing FastCGI param SERVER_PROTOCOL required by WSGI!
  
 Status: 302 FOUND
  
 Content-Length: 0
  
 Content-Language: en
  
 Vary: Cookie, Accept-Language
  
 Location: http://localhost/r/
  
 Date: Wed, 24 Sep 2014 14:34:37 GMT
  
 X-Frame-Options: SAMEORIGIN
  
 Content-Type: text/html; charset=utf-8
  
  
 I don't know what I have done which is causing this. file
 reviewboard.settings is missing; don't know why.
  
 Could someone give me steps to install reviewboard on ubuntu (14.04) with
 lighttpd?
  
 Thanks in advance,
 -Neel.
  
 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups 
 reviewboard  
 group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com.  
 For more options, visit https://groups.google.com/d/optout.
  

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: rb-site fails

Hi Pierre,

Can you try using RBTools to post a change?

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org 
Beanbag, Inc. - https://www.beanbaginc.com


On September 24, 2014 at 6:29:41 AM, Pierre Leroy (pierre.lero...@gmail.com) 
wrote:
 Hi Chris,
 
 thanks a lot, the --console flag helped me in sorting out my installation
 issue. Now, I've got a ReviewBoard site running correclty, I think.
 
 Going a bit further, though, I'm a bit stuck in my workflow with RB and
 Mercurial and maybe you could help again.
 
 On the RB website, I've configured a mercurial repository.
 Then, I've cloned this repository on my local machine and made some
 changes.
 I've generated a patch with the following command:
 
 $ hg diff  diff.txt
 
 When I try to create a new review request and upload the diff.txt file
 generated as described above, I've got the error message: *The selected
 file does not appear to be a diff*.
 
 Any idea what I'm doing wrong here again?
 
 Thanks a lot,
 
 /// Pierre
 

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Reviewboard 2.0.6 hungs on new request with non latin symbols

Glad it works, Sara! Thanks for your patience and feedback on this!

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org 
Beanbag, Inc. - https://www.beanbaginc.com


On September 24, 2014 at 6:10:36 AM, Sara Rayburn (sararayb...@gmail.com) wrote:
 2.0.8 fixes this for us. Thanks so much!
 
 On Tuesday, September 23, 2014 6:32:55 PM UTC-5, Christian Hammond wrote:
 
  Hi Sara,
 
  David has a repro case for this now, so we're looking into a fix.
 
  There will be a 2.0.8 release tonight.
 
  Christian
 
  --
  Christian Hammond - chri...@beanbaginc.com 
  Review Board - https://www.reviewboard.org
  Beanbag, Inc. - https://www.beanbaginc.com
 
 
  On September 23, 2014 at 3:17:04 PM, Christian Hammond (
  chri...@beanbaginc.com ) wrote:
   Hi Sara,
  
   Something that would really help is a complete dump of the
  request/responses (headers
   and payloads) for any requests to /api/* in the Network tab of Firefox
  when these issues
   occur.
  
   I know some information was sent before, but those look to be the
  Console tab only.
  
   Christian
  
   --
   Christian Hammond - chri...@beanbaginc.com 
   Review Board - https://www.reviewboard.org
   Beanbag, Inc. - https://www.beanbaginc.com
  
  
   On September 23, 2014 at 2:23:34 PM, Christian Hammond (
  chri...@beanbaginc.com )
   wrote:
I wish I knew too...
   
So, for each of these cases, is the only visible error the rsp is
  null error?
   
This is tricky to diagnose without more direct access to the server.
  Hoping something
will allow me to repro it here.
   
Christian
   
--
Christian Hammond - chri...@beanbaginc.com 
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
   
   
On September 23, 2014 at 1:43:11 PM, Sara Rayburn (sarar...@gmail.com
  ) wrote:
 I wish I knew what this was. We've had three developers run into
  this bug
 today alone. It's becoming a real problem for us. More answers to
  your
 questions inline below.
 Sara

 On Tuesday, September 23, 2014 2:08:28 PM UTC-5, Christian Hammond
  wrote:
 
  Hi Sara,
 
 
  On September 23, 2014 at 11:39:53 AM, Sara Rayburn (
  sarar...@gmail.com
  ) wrote:
   On Tuesday, September 23, 2014 1:11:18 PM UTC-5, Christian
  Hammond
  wrote:
   
Hi Sara,
   
There are several things here that I am very confused about:
   
1) Can you clarify which part is new since 2.0.7? The subject
  says
  2.0.6.
   
  
   That is weird. I wasn't the original poster. We have only seen
  the bug
   since updating to 2.0.7. I know this because we have a request
  with
   non-unicode contents that was uploaded before I updated, without
  problems.
   Trying to reuse the same patch for an additional review request
  triggered
   the same unicode error we saw previously.
 
  On September 9th, you posted saying I am having a similar problem
  after
  upgrading to 2.0.6. We didn't have a 2.0.7 release until the
  15th.
 
 
  Good point. I guess it's a problem since before that.

 
1) Is this still only happening with Firefox?
   
   Yes
  
   
2) What version of Firefox?
   
30
 
  Does 33 work? I haven't had any issues with any recent version...
 
 
  Tried in most recent Firefox (35), issue remains.


4) If MySQL, are the tables set for Unicode?
   
The tables are a mix of latin1 and utf8. Perhaps this is the
  problem?
 
  This is likely to be the cause of at least some of your problems.
  You'll
  need to make sure they're all in utf8, otherwise there will be
  issues even
  populating the database with non-latin1 text. This can break us in
  numerous
  ways.
 
  I made sure the database encodings were utf8 and even set the
  encoding for
 the repository in question to utf8 in the admin repo settings for
 reviewboard. I added utf8 as the charset in settings_local.py. All
  of these
 changes later, I still have the problem.

 
5) Are you using any form of proxy server at your company?
   
No. Very vanilla setup on a VM.
 
  How about HTTP proxies that the users configure in their browsers?
  We've
  seen cases in the past of some proxies messing with the responses
  from our
  API.
 
  Nope, no one.

  Christian
 
 
  --
  Christian Hammond - chri...@beanbaginc.com
  Review Board - https://www.reviewboard.org
  Beanbag, Inc. - https://www.beanbaginc.com
 
 
  
  
  
Thanks,
   
Christian
   
--
Christian Hammond - chri...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

Re: please, please, please, please help me with installation

Hi Neel,

You definitely want to remove the 000-default file.

If the site isn't showing, that's often an indicator that Apache either isn't
seeing the Review Board config file, or the VirtualHost setup is wrong.

Can you provide the reviewboard.conf file along with Apache's httpd.conf?

Can you also look in the error_log in /var/log/{apache2|httpd} to see if it
says anything?

By the way, how are you accessing the site? Can you show me the exact URL
you're using?

Christian

--
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On September 24, 2014 at 10:35:19 AM, neel roy (neelsm...@rediffmail.com) wrote:
Hi Christian,

Thanks for the reply. The problem with Apache was that even if I removed
000-default folder or disabled it, I still could not get apache2 to display
reviewboard site. here are the complete steps I did; these are basically
the same steps mentioned in the tutorial site I mentioned above but little
bit of changes which I have made bold in listing below. Do you think I need
to change something:

sudo apt-get install apache2
*sudo apt-get install libapache2-mod-wsgi*
sudo a2enmod python

sudo apt-get install mysql-server
sudo apt-get install python-mysqldb

sudo apt-get install memcached
sudo apt-get install memcached-dev
sudo apt-get install python-memcache

mysql -uroot -p
mysql create database reviewboard;
Query OK, 1 row affected (0.00 sec)
mysql create user 'rb'@'localhost' identified by 'rb_password';
Query OK, 0 rows affected (0.00 sec)
mysql grant all on reviewboard.* to 'rb'@'localhost'
Query OK, 0 rows affected (0.00 sec)
mysql exit
Bye

sudo apt-get install patch
sudo apt-get install subversion
sudo apt-get install python-svn

sudo apt-get install python-setuptools
sudo easy_install reviewboard

sudo rb-site install /var/www/reviewboard

*sudo chown -R www-data /var/www/reviewboard/htdocs/media/uploaded*
*sudo chown -R www-data /var/www/reviewboard/data*

*cd /etc/apache2/sites-available*
*cp /var/www/reviewboard/conf/apache-wsgi.conf reviewboard.conf*
*cd ../sites-enabled*
*ln -s ../sites-available/reviewboard.conf .*

*If I remove 000-default folder\file, I get this webpage not available
error..*

optional steps (Because default site is still enabled)
sudo a2dissite 000-default
sudo a2ensite reviewboard
sudo /etc/init.d/apache2 restart

-Neel.

On Wednesday, September 24, 2014 10:43:18 PM UTC+5:30, Christian Hammond
wrote:

Hi Neel,

lighttpd is not well-supported, which is why it's considered an advanced
option. Very few people seem to use it.

I'd *strongly* suggest using Apache + mod_wsgi (daemon mode works well
these days), if at all possible. You'll have the best support that way.

FastCGI is a bad option. We've seen people hit all sorts of issues with
it. The Python community has rallied around mod_wsgi and similar solutions
instead.

I think you'll find that if you use the standard recommended options from
rb-site, you'll have a much easier time getting going.

As for the 000-default file, I'm sorry it cost you an hour of time. It is
annoying that Apache ships that..

Christian

--
Christian Hammond - chri...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On September 24, 2014 at 7:47:23 AM, neel roy (neel...@rediffmail.com
) wrote:
It's 8:10 pm and I have been fighting with reviewboard installation for
last SIX hours.

I tried with apache2 and I ran into 000-default site problem.. from

https://www.reviewboard.org/docs/manual/dev/admin/installation/creating-sites/#creating-sites:

Some Apache installations (such as the default installs on Debian and
Ubuntu) by default define a global virtual host that shares /var/www as
the
document root. This may lead to problems with your install. If you
access
your site and see nothing but a directory listing, then you’re affected
by
this problem.

The solution is to remove the “default” site from your
/etc/apache2/sites-enabled directory. This may be called something like
default or 000-default.

Then I had to figure out after an hour that I had to specify
--web-server
if I want to use lighttpd.

After that there were some few more errors (I can go into details but I
don't think that's going to help my cause). So here is process I have
followed:

http://alephnullplex.appspot.com/blog/view/2009/07/09/tutorial-installing-review-board-on-ubuntu

Replace installation of apache2 with lighttpd and mod-python with
fastcgi.
Nothing works. Right now I am here:

*rb-site manage /var/www/reviewboard runfcgi method=threaded*

WSGIServer: missing FastCGI param REQUEST_METHOD required by WSGI!

WSGIServer: missing FastCGI param SERVER_NAME required

Re: please, please, please, please help me with installation

2014-09-24 Thread neel roy

Okay, I fixed the problem. here are the couple of changes I did:

sudo apt-get install apache2
sudo apt-get install libapache2-mod-wsgi
sudo a2enmod *wsgi*

sudo apt-get install mysql-server
sudo apt-get install python-mysqldb

sudo apt-get install memcached
sudo apt-get install memcached-dev
sudo apt-get install python-memcache

mysql -uroot -p
mysql create database reviewboard;
Query OK, 1 row affected (0.00 sec)
mysql create user 'rb'@'localhost' identified by 'rb_password';
Query OK, 0 rows affected (0.00 sec)
mysql grant all on reviewboard.* to 'rb'@'localhost';
Query OK, 0 rows affected (0.00 sec)
mysql exit
Bye

sudo apt-get install patch
sudo apt-get install subversion
sudo apt-get install python-svn

sudo apt-get install python-setuptools
sudo easy_install reviewboard

sudo rb-site install /var/www/reviewboard

sudo chown -R www-data /var/www/reviewboard/htdocs/media/uploaded
sudo chown -R www-data /var/www/reviewboard/data
*sudo chown -R www-data /var/www/reviewboard/htdocs/media/ext*
sudo chown -R www-data /var/www/reviewboard/htdocs/static/ext


cd /etc/apache2/sites-available
cp /var/www/reviewboard/conf/apache-wsgi.conf reviewboard.conf
cd ../sites-enabled
ln -s ../sites-available/reviewboard.conf .

*If I remove 000-default folder\file, I get this webpage not available 
error..*

optional steps (Because default site is still enabled) === *These do NOT 
seem to be optional steps anymore*
sudo a2dissite 000-default
sudo a2ensite reviewboard
sudo /etc/init.d/apache2 restart

*This is a very important step; got it from 
https://groups.google.com/forum/#!topic/reviewboard/_D12QMhA8OY*
*change the /var/www/reviews/conf/settings_local.py ALLOWED_HOSTS = 
['localhost'] to ALLOWED_HOSTS = ['*'].*

*May be we can put this in the installation instructions page as concrete 
steps instead of general directions?*

Now to the next steps.. playing with rb-tools. I will post problems if any..

-Neel.

On Wednesday, September 24, 2014 11:05:16 PM UTC+5:30, neel roy wrote:

 Hi Christian,

 Thanks for the reply. The problem with Apache was that even if I removed 
 000-default folder or disabled it, I still could not get apache2 to display 
 reviewboard site. here are the complete steps I did; these are basically 
 the same steps mentioned in the tutorial site I mentioned above but little 
 bit of changes which I have made bold in listing below. Do you think I need 
 to change something:

 sudo apt-get install apache2
 *sudo apt-get install libapache2-mod-wsgi*
 sudo a2enmod python

 sudo apt-get install mysql-server
 sudo apt-get install python-mysqldb

 sudo apt-get install memcached
 sudo apt-get install memcached-dev
 sudo apt-get install python-memcache

 mysql -uroot -p
 mysql create database reviewboard;
 Query OK, 1 row affected (0.00 sec)
 mysql create user 'rb'@'localhost' identified by 'rb_password';
 Query OK, 0 rows affected (0.00 sec)
 mysql grant all on reviewboard.* to 'rb'@'localhost'
 Query OK, 0 rows affected (0.00 sec)
 mysql exit
 Bye

 sudo apt-get install patch
 sudo apt-get install subversion
 sudo apt-get install python-svn

 sudo apt-get install python-setuptools
 sudo easy_install reviewboard

 sudo rb-site install /var/www/reviewboard

 *sudo chown -R www-data /var/www/reviewboard/htdocs/media/uploaded*
 *sudo chown -R www-data /var/www/reviewboard/data*

 *cd /etc/apache2/sites-available*
 *cp /var/www/reviewboard/conf/apache-wsgi.conf reviewboard.conf*
 *cd ../sites-enabled*
 *ln -s ../sites-available/reviewboard.conf .*

 *If I remove 000-default folder\file, I get this webpage not available 
 error..*

 optional steps (Because default site is still enabled)
 sudo a2dissite 000-default
 sudo a2ensite reviewboard
 sudo /etc/init.d/apache2 restart

 -Neel.




 On Wednesday, September 24, 2014 10:43:18 PM UTC+5:30, Christian Hammond 
 wrote:

 Hi Neel, 

 lighttpd is not well-supported, which is why it's considered an advanced 
 option. Very few people seem to use it. 

 I'd *strongly* suggest using Apache + mod_wsgi (daemon mode works well 
 these days), if at all possible. You'll have the best support that way. 

 FastCGI is a bad option. We've seen people hit all sorts of issues with 
 it. The Python community has rallied around mod_wsgi and similar solutions 
 instead. 

 I think you'll find that if you use the standard recommended options from 
 rb-site, you'll have a much easier time getting going. 

 As for the 000-default file, I'm sorry it cost you an hour of time. It is 
 annoying that Apache ships that.. 

 Christian 

 --   
 Christian Hammond - chri...@beanbaginc.com 
 Review Board - https://www.reviewboard.org   
 Beanbag, Inc. - https://www.beanbaginc.com 


 On September 24, 2014 at 7:47:23 AM, neel roy (neel...@rediffmail.com) 
 wrote: 
  It's 8:10 pm and I have been fighting with reviewboard installation for 
  last SIX hours. 

  I tried with apache2 and I ran into 000-default site problem.. from

Re: Resetting open issue counters

Hi Christian,

Just upgraded to 2.0.8:

[[[
bash-4.1# rb-site manage /var/www.reviewboard reset-issue-counts
--recalculate --verbosity=2 2050
Usage: rb-site command [options] path

rb-site: error: no such option: --recalculate
bash-4.1# rb-site --version
rb-site 2.0.8
]]]

BTW, release notes for 2.0.8 seem to omit the 'manage' argument from the
command line:

rb-site path reset-issue-counts --recalculate --verbosity=2 id

Also, the usage in --help message is wrong: it suggests to use 'rb-site
path manage command' - while the correct order is 'rb-site manage path
command'.

Regards,
Alexey.



On Wed, Sep 24, 2014 at 10:28 AM, Christian Hammond 
christ...@beanbaginc.com wrote:

 Hey,

 2.0.8 contains a new reset-issue-counts management command that can be
 used. I takes a list of IDs, or --all to reset all review requests. Issue
 counts will be recalculated on next access.

 It can also provide debug info about the calculations. Can you find one of
 the miscalculated review requests and run:

 rb-site manage /path/to/site reset-issue-counts -- -verbosity=2
 --recalculate id

 See if the counts are right and then paste the debug output from that
 command. It'll help me get a sense of what's going wrong (hopefully).

 (Also, I added basic --help output to rb-site for the manage command.)

 Christian

 --
 Christian Hammond - christ...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com


 On September 23, 2014 at 4:29:54 PM, Christian Hammond (
 christ...@beanbaginc.com) wrote:
  Oh, regarding the fix the counts script, I can write one, but it's
 very unlikely to matter,
  I realized. It's just going to trigger the exact same logic that's
 triggered when viewing
  the review request for the first time, post-upgrade. If it got it wrong
 before, I don't
  have much reason to believe it'll get it right the next time.
 
  I'll have to fix the bug properly. For that, I'll probably need a
 before/after or a solid
  repro case.
 
  Christian
 
  --
  Christian Hammond - christ...@beanbaginc.com
  Review Board - https://www.reviewboard.org
  Beanbag, Inc. - https://www.beanbaginc.com
 
 
  On September 23, 2014 at 4:21:23 PM, Christian Hammond (
 christ...@beanbaginc.com)
  wrote:
   Do you happen to have a database backup prior to the upgrade? I'd love
 to try with a real
   before/after.
  
   Christian
  
   --
   Christian Hammond - christ...@beanbaginc.com
   Review Board - https://www.reviewboard.org
   Beanbag, Inc. - https://www.beanbaginc.com
  
  
   On September 22, 2014 at 4:15:20 PM, Christian Hammond (
 christ...@beanbaginc.com)
   wrote:
Hi Alexey,
   
That's something we can get in.
   
As for the manage command, it's just an oversight.
   
Christian
   
--
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
   
   
On September 22, 2014 at 3:09:41 PM, Alexey Neyman (
 alexey.ney...@gmail.com) wrote:
 Christian,

 Meanwhile, is it possible to have a rb-site manage subcommand to
 recalculate these counters?

 Thanks,
 Alexey.
 On Sep 22, 2014 2:00 PM, Christian Hammond wrote:
 
  I would love a repro case for this. I've seen a couple of
 reports, and
 have tried desperately to reproduce it, with no luck. The code is
 fairly
 straightforward in how it counts the initial values.
 
  Christian
 
  On Monday, September 22, 2014, Stephen Gallagher 
 step...@gallagherhome.com wrote:
 
  On 09/22/2014 04:30 PM, Alexey Neyman wrote:
   Hi all,
  
   We have just upgraded our installation of RB to 2.0.7. One
 nice new
   feature is that the dashboard now displays the number of open
 issues in
   a review request.
  
   However, I have noticed that the counters don't seem to be
 accurate in
   some request. For example, one of the review requests has 4
 reviews
 with
   ship-its, with 2 of them making a comment on the code which
 were not
   marked as issues. Yet, the status displayed in the dashboard
 is 1 open
   issue. I verified this in admin/database/review requests,
 and this
   review request is indeed recorded as having ship-it count:
 4 and
 open
   issue count: 1.
  
 
  I've hit the same bug on one of my deployments, but I haven't
 been able
  to reproduce it yet.
 
 
   I am not sure if this was a 1.7 bug, or if it was caused by
 the upgrade
   - the request and some of the reviews were submitted before
 the RB
   upgrade. However, I am not sure if the rest of the counters
 are valid -
   going through all the requests and verifying them manually is
 obviously
   a lot of work. So, is there a way to make RB recalculate
 these counters
   - like it was with the dashboard counters and the rb-site
 manage
   /path/to/site fixreviewcounts command?

Re: Resetting open issue counters

Thanks, I'll fix the release notes.

Make sure to put a -- before any --arguments, like:

    rb-site manage /var/www/reviewboard reset-issue-counts -- --verbosity=2 
--recalculate

Not sure what you mean by the help output being wrong though?

Christian

--  
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org  
Beanbag, Inc. - https://www.beanbaginc.com


On September 24, 2014 at 12:40:11 PM, Alexey Neyman (alexey.ney...@gmail.com) 
wrote:
 Hi Christian,
  
 Just upgraded to 2.0.8:
  
 [[[
 bash-4.1# rb-site manage /var/www.reviewboard reset-issue-counts
 --recalculate --verbosity=2 2050
 Usage: rb-site command [options] path
  
 rb-site: error: no such option: --recalculate
 bash-4.1# rb-site --version
 rb-site 2.0.8
 ]]]
  
 BTW, release notes for 2.0.8 seem to omit the 'manage' argument from the
 command line:
  
 rb-site reset-issue-counts --recalculate --verbosity=2  
  
 Also, the usage in --help message is wrong: it suggests to use 'rb-site
 manage command' - while the correct order is 'rb-site manage  
 command'.
  
 Regards,
 Alexey.
  
  
  
 On Wed, Sep 24, 2014 at 10:28 AM, Christian Hammond 
 christ...@beanbaginc.com wrote:
  
  Hey,
 
  2.0.8 contains a new reset-issue-counts management command that can be
  used. I takes a list of IDs, or --all to reset all review requests. Issue
  counts will be recalculated on next access.
 
  It can also provide debug info about the calculations. Can you find one of
  the miscalculated review requests and run:
 
  rb-site manage /path/to/site reset-issue-counts -- -verbosity=2
  --recalculate  
 
  See if the counts are right and then paste the debug output from that
  command. It'll help me get a sense of what's going wrong (hopefully).
 
  (Also, I added basic --help output to rb-site for the manage command.)
 
  Christian
 
  --
  Christian Hammond - christ...@beanbaginc.com
  Review Board - https://www.reviewboard.org
  Beanbag, Inc. - https://www.beanbaginc.com
 
 
  On September 23, 2014 at 4:29:54 PM, Christian Hammond (
  christ...@beanbaginc.com) wrote:
   Oh, regarding the fix the counts script, I can write one, but it's
  very unlikely to matter,
   I realized. It's just going to trigger the exact same logic that's
  triggered when viewing
   the review request for the first time, post-upgrade. If it got it wrong
  before, I don't
   have much reason to believe it'll get it right the next time.
  
   I'll have to fix the bug properly. For that, I'll probably need a
  before/after or a solid
   repro case.
  
   Christian
  
   --
   Christian Hammond - christ...@beanbaginc.com
   Review Board - https://www.reviewboard.org
   Beanbag, Inc. - https://www.beanbaginc.com
  
  
   On September 23, 2014 at 4:21:23 PM, Christian Hammond (
  christ...@beanbaginc.com)
   wrote:
Do you happen to have a database backup prior to the upgrade? I'd love
  to try with a real
before/after.
   
Christian
   
--
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
   
   
On September 22, 2014 at 4:15:20 PM, Christian Hammond (
  christ...@beanbaginc.com)
wrote:
 Hi Alexey,

 That's something we can get in.

 As for the manage command, it's just an oversight.

 Christian

 --
 Christian Hammond - christ...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com


 On September 22, 2014 at 3:09:41 PM, Alexey Neyman (
  alexey.ney...@gmail.com) wrote:
  Christian,
 
  Meanwhile, is it possible to have a rb-site manage subcommand to
  recalculate these counters?
 
  Thanks,
  Alexey.
  On Sep 22, 2014 2:00 PM, Christian Hammond wrote:
  
   I would love a repro case for this. I've seen a couple of
  reports, and
  have tried desperately to reproduce it, with no luck. The code is
  fairly
  straightforward in how it counts the initial values.
  
   Christian
  
   On Monday, September 22, 2014, Stephen Gallagher 
  step...@gallagherhome.com wrote:
  
   On 09/22/2014 04:30 PM, Alexey Neyman wrote:
Hi all,
   
We have just upgraded our installation of RB to 2.0.7. One
  nice new
feature is that the dashboard now displays the number of open
  issues in
a review request.
   
However, I have noticed that the counters don't seem to be
  accurate in
some request. For example, one of the review requests has 4
  reviews
  with
ship-its, with 2 of them making a comment on the code which
  were not
marked as issues. Yet, the status displayed in the dashboard
  is 1 open
issue. I verified this in admin/database/review requests,
  and this
review request is indeed recorded as having ship-it count:
  4 and
  open
issue count: 1.

Re: Resetting open issue counters

Figured it out, needs -- to have --recalculate argument applied to
'reset-issue-counts' rather than rb-site itself.

Here is the output:

DEBUG:root:Calculated issue counts for review request ID 2050 across 5
review(s): Resulting counts = {u'R': 0, u'D': 0, u'O': 1}; DB values =
[{u'screenshot_comments__issue_status': None,
u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
u'comments__pk': None, u'comments__issue_status': None,
u'file_attachment_comments__issue_status': None},
{u'screenshot_comments__issue_status': None,
u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
u'comments__pk': 8194L, u'comments__issue_status': None,
u'file_attachment_comments__issue_status': None},
{u'screenshot_comments__issue_status': None,
u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
u'comments__pk': 8199L, u'comments__issue_status': u'O',
u'file_attachment_comments__issue_status': None},
{u'screenshot_comments__issue_status': None,
u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
u'comments__pk': None, u'comments__issue_status': None,
u'file_attachment_comments__issue_status': None},
{u'screenshot_comments__issue_status': None,
u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
u'comments__pk': None, u'comments__issue_status': None,
u'file_attachment_comments__issue_status': None}]; Field IDs =
{u'screenshot_comments': set([None]), u'comments': set([None, 8194L,
8199L]), u'file_attachment_comments': set([None])}
Issue counts for review request(s) 2050 reset.

However, this review request still shows 1 open issue and there are no
issues raised in any of the reviews - there is even no 'issue summary'
block at the bottom of this request.

Regards,
Alexey.

On Wed, Sep 24, 2014 at 12:40 PM, Alexey Neyman alexey.ney...@gmail.com
wrote:

 Hi Christian,

 Just upgraded to 2.0.8:

 [[[
 bash-4.1# rb-site manage /var/www.reviewboard reset-issue-counts
 --recalculate --verbosity=2 2050
 Usage: rb-site command [options] path

 rb-site: error: no such option: --recalculate
 bash-4.1# rb-site --version
 rb-site 2.0.8
 ]]]

 BTW, release notes for 2.0.8 seem to omit the 'manage' argument from the
 command line:

 rb-site path reset-issue-counts --recalculate --verbosity=2 id

 Also, the usage in --help message is wrong: it suggests to use 'rb-site
 path manage command' - while the correct order is 'rb-site manage path
 command'.

 Regards,
 Alexey.



 On Wed, Sep 24, 2014 at 10:28 AM, Christian Hammond 
 christ...@beanbaginc.com wrote:

 Hey,

 2.0.8 contains a new reset-issue-counts management command that can be
 used. I takes a list of IDs, or --all to reset all review requests. Issue
 counts will be recalculated on next access.

 It can also provide debug info about the calculations. Can you find one
 of the miscalculated review requests and run:

 rb-site manage /path/to/site reset-issue-counts -- -verbosity=2
 --recalculate id

 See if the counts are right and then paste the debug output from that
 command. It'll help me get a sense of what's going wrong (hopefully).

 (Also, I added basic --help output to rb-site for the manage command.)

 Christian

 --
 Christian Hammond - christ...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com


 On September 23, 2014 at 4:29:54 PM, Christian Hammond (
 christ...@beanbaginc.com) wrote:
  Oh, regarding the fix the counts script, I can write one, but it's
 very unlikely to matter,
  I realized. It's just going to trigger the exact same logic that's
 triggered when viewing
  the review request for the first time, post-upgrade. If it got it wrong
 before, I don't
  have much reason to believe it'll get it right the next time.
 
  I'll have to fix the bug properly. For that, I'll probably need a
 before/after or a solid
  repro case.
 
  Christian
 
  --
  Christian Hammond - christ...@beanbaginc.com
  Review Board - https://www.reviewboard.org
  Beanbag, Inc. - https://www.beanbaginc.com
 
 
  On September 23, 2014 at 4:21:23 PM, Christian Hammond (
 christ...@beanbaginc.com)
  wrote:
   Do you happen to have a database backup prior to the upgrade? I'd
 love to try with a real
   before/after.
  
   Christian
  
   --
   Christian Hammond - christ...@beanbaginc.com
   Review Board - https://www.reviewboard.org
   Beanbag, Inc. - https://www.beanbaginc.com
  
  
   On September 22, 2014 at 4:15:20 PM, Christian Hammond (
 christ...@beanbaginc.com)
   wrote:
Hi Alexey,
   
That's something we can get in.
   
As for the manage command, it's just an oversight.
   
Christian
   
--
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
   
   
On September 22, 2014 at 3:09:41 PM, Alexey Neyman (
 alexey.ney...@gmail.com) wrote:
 Christian,

 Meanwhile, is it possible to have a rb-site manage subcommand

Re: Resetting open issue counters

Re help: the order of the 'manage' and path arguments is swapped.

Correct order: rb-site manage path
Help message: rb-site path manage

Regards,
Alexey.

On Wed, Sep 24, 2014 at 12:41 PM, Christian Hammond 
christ...@beanbaginc.com wrote:

 Thanks, I'll fix the release notes.

 Make sure to put a -- before any --arguments, like:

 rb-site manage /var/www/reviewboard reset-issue-counts --
 --verbosity=2 --recalculate

 Not sure what you mean by the help output being wrong though?

 Christian

 --
 Christian Hammond - christ...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com


 On September 24, 2014 at 12:40:11 PM, Alexey Neyman (
 alexey.ney...@gmail.com) wrote:
  Hi Christian,
 
  Just upgraded to 2.0.8:
 
  [[[
  bash-4.1# rb-site manage /var/www.reviewboard reset-issue-counts
  --recalculate --verbosity=2 2050
  Usage: rb-site command [options] path
 
  rb-site: error: no such option: --recalculate
  bash-4.1# rb-site --version
  rb-site 2.0.8
  ]]]
 
  BTW, release notes for 2.0.8 seem to omit the 'manage' argument from the
  command line:
 
  rb-site reset-issue-counts --recalculate --verbosity=2
 
  Also, the usage in --help message is wrong: it suggests to use 'rb-site
  manage command' - while the correct order is 'rb-site manage
  command'.
 
  Regards,
  Alexey.
 
 
 
  On Wed, Sep 24, 2014 at 10:28 AM, Christian Hammond 
  christ...@beanbaginc.com wrote:
 
   Hey,
  
   2.0.8 contains a new reset-issue-counts management command that can be
   used. I takes a list of IDs, or --all to reset all review requests.
 Issue
   counts will be recalculated on next access.
  
   It can also provide debug info about the calculations. Can you find
 one of
   the miscalculated review requests and run:
  
   rb-site manage /path/to/site reset-issue-counts -- -verbosity=2
   --recalculate
  
   See if the counts are right and then paste the debug output from that
   command. It'll help me get a sense of what's going wrong (hopefully).
  
   (Also, I added basic --help output to rb-site for the manage
 command.)
  
   Christian
  
   --
   Christian Hammond - christ...@beanbaginc.com
   Review Board - https://www.reviewboard.org
   Beanbag, Inc. - https://www.beanbaginc.com
  
  
   On September 23, 2014 at 4:29:54 PM, Christian Hammond (
   christ...@beanbaginc.com) wrote:
Oh, regarding the fix the counts script, I can write one, but it's
   very unlikely to matter,
I realized. It's just going to trigger the exact same logic that's
   triggered when viewing
the review request for the first time, post-upgrade. If it got it
 wrong
   before, I don't
have much reason to believe it'll get it right the next time.
   
I'll have to fix the bug properly. For that, I'll probably need a
   before/after or a solid
repro case.
   
Christian
   
--
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
   
   
On September 23, 2014 at 4:21:23 PM, Christian Hammond (
   christ...@beanbaginc.com)
wrote:
 Do you happen to have a database backup prior to the upgrade? I'd
 love
   to try with a real
 before/after.

 Christian

 --
 Christian Hammond - christ...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com


 On September 22, 2014 at 4:15:20 PM, Christian Hammond (
   christ...@beanbaginc.com)
 wrote:
  Hi Alexey,
 
  That's something we can get in.
 
  As for the manage command, it's just an oversight.
 
  Christian
 
  --
  Christian Hammond - christ...@beanbaginc.com
  Review Board - https://www.reviewboard.org
  Beanbag, Inc. - https://www.beanbaginc.com
 
 
  On September 22, 2014 at 3:09:41 PM, Alexey Neyman (
   alexey.ney...@gmail.com) wrote:
   Christian,
  
   Meanwhile, is it possible to have a rb-site manage subcommand
 to
   recalculate these counters?
  
   Thanks,
   Alexey.
   On Sep 22, 2014 2:00 PM, Christian Hammond wrote:
   
I would love a repro case for this. I've seen a couple of
   reports, and
   have tried desperately to reproduce it, with no luck. The code
 is
   fairly
   straightforward in how it counts the initial values.
   
Christian
   
On Monday, September 22, 2014, Stephen Gallagher 
   step...@gallagherhome.com wrote:
   
On 09/22/2014 04:30 PM, Alexey Neyman wrote:
 Hi all,

 We have just upgraded our installation of RB to 2.0.7. One
   nice new
 feature is that the dashboard now displays the number of
 open
   issues in
 a review request.

 However, I have noticed that the counters don't seem to be
   accurate in
 some request. For example, one of the review requests has
 4
   reviews

Re: Resetting open issue counters

Thanks for the debug info!

Yeah, as I mentioned in an earlier reply, a reset command will *not* fix the 
problem, because the calculation is broken. Best I could do is to get this 
command in to reset and provide debug information, so that I can hopefully 
figure out the cause. I'll look into what the output below says and see if I 
can figure this out.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org 
Beanbag, Inc. - https://www.beanbaginc.com


On September 24, 2014 at 12:44:18 PM, Alexey Neyman (alexey.ney...@gmail.com) 
wrote:
 Figured it out, needs -- to have --recalculate argument applied to
 'reset-issue-counts' rather than rb-site itself.
 
 Here is the output:
 
 DEBUG:root:Calculated issue counts for review request ID 2050 across 5
 review(s): Resulting counts = {u'R': 0, u'D': 0, u'O': 1}; DB values =
 [{u'screenshot_comments__issue_status': None,
 u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
 u'comments__pk': None, u'comments__issue_status': None,
 u'file_attachment_comments__issue_status': None},
 {u'screenshot_comments__issue_status': None,
 u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
 u'comments__pk': 8194L, u'comments__issue_status': None,
 u'file_attachment_comments__issue_status': None},
 {u'screenshot_comments__issue_status': None,
 u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
 u'comments__pk': 8199L, u'comments__issue_status': u'O',
 u'file_attachment_comments__issue_status': None},
 {u'screenshot_comments__issue_status': None,
 u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
 u'comments__pk': None, u'comments__issue_status': None,
 u'file_attachment_comments__issue_status': None},
 {u'screenshot_comments__issue_status': None,
 u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
 u'comments__pk': None, u'comments__issue_status': None,
 u'file_attachment_comments__issue_status': None}]; Field IDs =
 {u'screenshot_comments': set([None]), u'comments': set([None, 8194L,
 8199L]), u'file_attachment_comments': set([None])}
 Issue counts for review request(s) 2050 reset.
 
 However, this review request still shows 1 open issue and there are no
 issues raised in any of the reviews - there is even no 'issue summary'
 block at the bottom of this request.
 
 Regards,
 Alexey.
 
 On Wed, Sep 24, 2014 at 12:40 PM, Alexey Neyman 
 wrote:
 
  Hi Christian,
 
  Just upgraded to 2.0.8:
 
  [[[
  bash-4.1# rb-site manage /var/www.reviewboard reset-issue-counts
  --recalculate --verbosity=2 2050
  Usage: rb-site command [options] path
 
  rb-site: error: no such option: --recalculate
  bash-4.1# rb-site --version
  rb-site 2.0.8
  ]]]
 
  BTW, release notes for 2.0.8 seem to omit the 'manage' argument from the
  command line:
 
  rb-site reset-issue-counts --recalculate --verbosity=2 
 
  Also, the usage in --help message is wrong: it suggests to use 'rb-site
  manage command' - while the correct order is 'rb-site manage 
  command'.
 
  Regards,
  Alexey.
 
 
 
  On Wed, Sep 24, 2014 at 10:28 AM, Christian Hammond 
  christ...@beanbaginc.com wrote:
 
  Hey,
 
  2.0.8 contains a new reset-issue-counts management command that can be
  used. I takes a list of IDs, or --all to reset all review requests. Issue
  counts will be recalculated on next access.
 
  It can also provide debug info about the calculations. Can you find one
  of the miscalculated review requests and run:
 
  rb-site manage /path/to/site reset-issue-counts -- -verbosity=2
  --recalculate 
 
  See if the counts are right and then paste the debug output from that
  command. It'll help me get a sense of what's going wrong (hopefully).
 
  (Also, I added basic --help output to rb-site for the manage command.)
 
  Christian
 
  --
  Christian Hammond - christ...@beanbaginc.com
  Review Board - https://www.reviewboard.org
  Beanbag, Inc. - https://www.beanbaginc.com
 
 
  On September 23, 2014 at 4:29:54 PM, Christian Hammond (
  christ...@beanbaginc.com) wrote:
   Oh, regarding the fix the counts script, I can write one, but it's
  very unlikely to matter,
   I realized. It's just going to trigger the exact same logic that's
  triggered when viewing
   the review request for the first time, post-upgrade. If it got it wrong
  before, I don't
   have much reason to believe it'll get it right the next time.
  
   I'll have to fix the bug properly. For that, I'll probably need a
  before/after or a solid
   repro case.
  
   Christian
  
   --
   Christian Hammond - christ...@beanbaginc.com
   Review Board - https://www.reviewboard.org
   Beanbag, Inc. - https://www.beanbaginc.com
  
  
   On September 23, 2014 at 4:21:23 PM, Christian Hammond (
  christ...@beanbaginc.com)
   wrote:
Do you happen to have a database backup prior to the upgrade? I'd
  love to try with a real
before/after.
   
Christian
   
--
Christian Hammond -

Re: Resetting open issue counters

Re release notes: you've fixed only one instance of the two where 'manage'
was missing:

A new rb-site path reset-issue-counts management command has been
added...

On Wed, Sep 24, 2014 at 12:41 PM, Christian Hammond 
christ...@beanbaginc.com wrote:

 Thanks, I'll fix the release notes.

 Make sure to put a -- before any --arguments, like:

 rb-site manage /var/www/reviewboard reset-issue-counts --
 --verbosity=2 --recalculate

 Not sure what you mean by the help output being wrong though?

 Christian

 --
 Christian Hammond - christ...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com


 On September 24, 2014 at 12:40:11 PM, Alexey Neyman (
 alexey.ney...@gmail.com) wrote:
  Hi Christian,
 
  Just upgraded to 2.0.8:
 
  [[[
  bash-4.1# rb-site manage /var/www.reviewboard reset-issue-counts
  --recalculate --verbosity=2 2050
  Usage: rb-site command [options] path
 
  rb-site: error: no such option: --recalculate
  bash-4.1# rb-site --version
  rb-site 2.0.8
  ]]]
 
  BTW, release notes for 2.0.8 seem to omit the 'manage' argument from the
  command line:
 
  rb-site reset-issue-counts --recalculate --verbosity=2
 
  Also, the usage in --help message is wrong: it suggests to use 'rb-site
  manage command' - while the correct order is 'rb-site manage
  command'.
 
  Regards,
  Alexey.
 
 
 
  On Wed, Sep 24, 2014 at 10:28 AM, Christian Hammond 
  christ...@beanbaginc.com wrote:
 
   Hey,
  
   2.0.8 contains a new reset-issue-counts management command that can be
   used. I takes a list of IDs, or --all to reset all review requests.
 Issue
   counts will be recalculated on next access.
  
   It can also provide debug info about the calculations. Can you find
 one of
   the miscalculated review requests and run:
  
   rb-site manage /path/to/site reset-issue-counts -- -verbosity=2
   --recalculate
  
   See if the counts are right and then paste the debug output from that
   command. It'll help me get a sense of what's going wrong (hopefully).
  
   (Also, I added basic --help output to rb-site for the manage
 command.)
  
   Christian
  
   --
   Christian Hammond - christ...@beanbaginc.com
   Review Board - https://www.reviewboard.org
   Beanbag, Inc. - https://www.beanbaginc.com
  
  
   On September 23, 2014 at 4:29:54 PM, Christian Hammond (
   christ...@beanbaginc.com) wrote:
Oh, regarding the fix the counts script, I can write one, but it's
   very unlikely to matter,
I realized. It's just going to trigger the exact same logic that's
   triggered when viewing
the review request for the first time, post-upgrade. If it got it
 wrong
   before, I don't
have much reason to believe it'll get it right the next time.
   
I'll have to fix the bug properly. For that, I'll probably need a
   before/after or a solid
repro case.
   
Christian
   
--
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
   
   
On September 23, 2014 at 4:21:23 PM, Christian Hammond (
   christ...@beanbaginc.com)
wrote:
 Do you happen to have a database backup prior to the upgrade? I'd
 love
   to try with a real
 before/after.

 Christian

 --
 Christian Hammond - christ...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com


 On September 22, 2014 at 4:15:20 PM, Christian Hammond (
   christ...@beanbaginc.com)
 wrote:
  Hi Alexey,
 
  That's something we can get in.
 
  As for the manage command, it's just an oversight.
 
  Christian
 
  --
  Christian Hammond - christ...@beanbaginc.com
  Review Board - https://www.reviewboard.org
  Beanbag, Inc. - https://www.beanbaginc.com
 
 
  On September 22, 2014 at 3:09:41 PM, Alexey Neyman (
   alexey.ney...@gmail.com) wrote:
   Christian,
  
   Meanwhile, is it possible to have a rb-site manage subcommand
 to
   recalculate these counters?
  
   Thanks,
   Alexey.
   On Sep 22, 2014 2:00 PM, Christian Hammond wrote:
   
I would love a repro case for this. I've seen a couple of
   reports, and
   have tried desperately to reproduce it, with no luck. The code
 is
   fairly
   straightforward in how it counts the initial values.
   
Christian
   
On Monday, September 22, 2014, Stephen Gallagher 
   step...@gallagherhome.com wrote:
   
On 09/22/2014 04:30 PM, Alexey Neyman wrote:
 Hi all,

 We have just upgraded our installation of RB to 2.0.7. One
   nice new
 feature is that the dashboard now displays the number of
 open
   issues in
 a review request.

 However, I have noticed that the counters don't seem to be
   accurate in
 some request. For example, one of the review requests has
 4

Re: Resetting open issue counters

Can you tell it's been a very long few days?

Fixed. New docs are building now.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org 
Beanbag, Inc. - https://www.beanbaginc.com


On September 24, 2014 at 12:47:39 PM, Alexey Neyman (alexey.ney...@gmail.com) 
wrote:
 Re release notes: you've fixed only one instance of the two where 'manage'
 was missing:
 
 A new rb-site reset-issue-counts management command has been
 added...
 
 On Wed, Sep 24, 2014 at 12:41 PM, Christian Hammond 
 christ...@beanbaginc.com wrote:
 
  Thanks, I'll fix the release notes.
 
  Make sure to put a -- before any --arguments, like:
 
  rb-site manage /var/www/reviewboard reset-issue-counts --
  --verbosity=2 --recalculate
 
  Not sure what you mean by the help output being wrong though?
 
  Christian
 
  --
  Christian Hammond - christ...@beanbaginc.com
  Review Board - https://www.reviewboard.org
  Beanbag, Inc. - https://www.beanbaginc.com
 
 
  On September 24, 2014 at 12:40:11 PM, Alexey Neyman (
  alexey.ney...@gmail.com) wrote:
   Hi Christian,
  
   Just upgraded to 2.0.8:
  
   [[[
   bash-4.1# rb-site manage /var/www.reviewboard reset-issue-counts
   --recalculate --verbosity=2 2050
   Usage: rb-site command [options] path
  
   rb-site: error: no such option: --recalculate
   bash-4.1# rb-site --version
   rb-site 2.0.8
   ]]]
  
   BTW, release notes for 2.0.8 seem to omit the 'manage' argument from the
   command line:
  
   rb-site reset-issue-counts --recalculate --verbosity=2
  
   Also, the usage in --help message is wrong: it suggests to use 'rb-site
   manage command' - while the correct order is 'rb-site manage
   command'.
  
   Regards,
   Alexey.
  
  
  
   On Wed, Sep 24, 2014 at 10:28 AM, Christian Hammond 
   christ...@beanbaginc.com wrote:
  
Hey,
   
2.0.8 contains a new reset-issue-counts management command that can be
used. I takes a list of IDs, or --all to reset all review requests.
  Issue
counts will be recalculated on next access.
   
It can also provide debug info about the calculations. Can you find
  one of
the miscalculated review requests and run:
   
rb-site manage /path/to/site reset-issue-counts -- -verbosity=2
--recalculate
   
See if the counts are right and then paste the debug output from that
command. It'll help me get a sense of what's going wrong (hopefully).
   
(Also, I added basic --help output to rb-site for the manage
  command.)
   
Christian
   
--
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
   
   
On September 23, 2014 at 4:29:54 PM, Christian Hammond (
christ...@beanbaginc.com) wrote:
 Oh, regarding the fix the counts script, I can write one, but it's
very unlikely to matter,
 I realized. It's just going to trigger the exact same logic that's
triggered when viewing
 the review request for the first time, post-upgrade. If it got it
  wrong
before, I don't
 have much reason to believe it'll get it right the next time.

 I'll have to fix the bug properly. For that, I'll probably need a
before/after or a solid
 repro case.

 Christian

 --
 Christian Hammond - christ...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com


 On September 23, 2014 at 4:21:23 PM, Christian Hammond (
christ...@beanbaginc.com)
 wrote:
  Do you happen to have a database backup prior to the upgrade? I'd
  love
to try with a real
  before/after.
 
  Christian
 
  --
  Christian Hammond - christ...@beanbaginc.com
  Review Board - https://www.reviewboard.org
  Beanbag, Inc. - https://www.beanbaginc.com
 
 
  On September 22, 2014 at 4:15:20 PM, Christian Hammond (
christ...@beanbaginc.com)
  wrote:
   Hi Alexey,
  
   That's something we can get in.
  
   As for the manage command, it's just an oversight.
  
   Christian
  
   --
   Christian Hammond - christ...@beanbaginc.com
   Review Board - https://www.reviewboard.org
   Beanbag, Inc. - https://www.beanbaginc.com
  
  
   On September 22, 2014 at 3:09:41 PM, Alexey Neyman (
alexey.ney...@gmail.com) wrote:
Christian,
   
Meanwhile, is it possible to have a rb-site manage subcommand
  to
recalculate these counters?
   
Thanks,
Alexey.
On Sep 22, 2014 2:00 PM, Christian Hammond wrote:

 I would love a repro case for this. I've seen a couple of
reports, and
have tried desperately to reproduce it, with no luck. The code
  is
fairly
straightforward in how it counts the initial values.

 Christian

 On Monday, September 22, 2014, Stephen Gallagher

Re: Resetting open issue counters

So according to that debug output, there is one comment that has an issue open. 
I want to do some probing into this.

Can you run this and provide the full output, commands included?

    $ rb-site manage /path/to/site shell
     from reviewboard.reviews.models import Comment, Review
     comment = Comment.objects.get(pk=8199)
     print comment.reply_to_id
     print comment.issue_opened
     print comment.issue_status
     review = comment.review.get()
     print review.pk
     print review.public
     print review.ship_it
     print review.review_request_id
     print review.base_reply_to_id
     print review.comments.values_list('pk', flat=True)

Christian

--  
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org  
Beanbag, Inc. - https://www.beanbaginc.com


On September 24, 2014 at 12:44:18 PM, Alexey Neyman (alexey.ney...@gmail.com) 
wrote:
 Figured it out, needs -- to have --recalculate argument applied to
 'reset-issue-counts' rather than rb-site itself.
  
 Here is the output:
  
 DEBUG:root:Calculated issue counts for review request ID 2050 across 5
 review(s): Resulting counts = {u'R': 0, u'D': 0, u'O': 1}; DB values =
 [{u'screenshot_comments__issue_status': None,
 u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
 u'comments__pk': None, u'comments__issue_status': None,
 u'file_attachment_comments__issue_status': None},
 {u'screenshot_comments__issue_status': None,
 u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
 u'comments__pk': 8194L, u'comments__issue_status': None,
 u'file_attachment_comments__issue_status': None},
 {u'screenshot_comments__issue_status': None,
 u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
 u'comments__pk': 8199L, u'comments__issue_status': u'O',
 u'file_attachment_comments__issue_status': None},
 {u'screenshot_comments__issue_status': None,
 u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
 u'comments__pk': None, u'comments__issue_status': None,
 u'file_attachment_comments__issue_status': None},
 {u'screenshot_comments__issue_status': None,
 u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
 u'comments__pk': None, u'comments__issue_status': None,
 u'file_attachment_comments__issue_status': None}]; Field IDs =
 {u'screenshot_comments': set([None]), u'comments': set([None, 8194L,
 8199L]), u'file_attachment_comments': set([None])}
 Issue counts for review request(s) 2050 reset.
  
 However, this review request still shows 1 open issue and there are no
 issues raised in any of the reviews - there is even no 'issue summary'
 block at the bottom of this request.
  
 Regards,
 Alexey.
  
 On Wed, Sep 24, 2014 at 12:40 PM, Alexey Neyman  
 wrote:
  
  Hi Christian,
 
  Just upgraded to 2.0.8:
 
  [[[
  bash-4.1# rb-site manage /var/www.reviewboard reset-issue-counts
  --recalculate --verbosity=2 2050
  Usage: rb-site command [options] path
 
  rb-site: error: no such option: --recalculate
  bash-4.1# rb-site --version
  rb-site 2.0.8
  ]]]
 
  BTW, release notes for 2.0.8 seem to omit the 'manage' argument from the
  command line:
 
  rb-site reset-issue-counts --recalculate --verbosity=2  
 
  Also, the usage in --help message is wrong: it suggests to use 'rb-site
  manage command' - while the correct order is 'rb-site manage  
  command'.
 
  Regards,
  Alexey.
 
 
 
  On Wed, Sep 24, 2014 at 10:28 AM, Christian Hammond 
  christ...@beanbaginc.com wrote:
 
  Hey,
 
  2.0.8 contains a new reset-issue-counts management command that can be
  used. I takes a list of IDs, or --all to reset all review requests. Issue
  counts will be recalculated on next access.
 
  It can also provide debug info about the calculations. Can you find one
  of the miscalculated review requests and run:
 
  rb-site manage /path/to/site reset-issue-counts -- -verbosity=2
  --recalculate  
 
  See if the counts are right and then paste the debug output from that
  command. It'll help me get a sense of what's going wrong (hopefully).
 
  (Also, I added basic --help output to rb-site for the manage command.)
 
  Christian
 
  --
  Christian Hammond - christ...@beanbaginc.com
  Review Board - https://www.reviewboard.org
  Beanbag, Inc. - https://www.beanbaginc.com
 
 
  On September 23, 2014 at 4:29:54 PM, Christian Hammond (
  christ...@beanbaginc.com) wrote:
   Oh, regarding the fix the counts script, I can write one, but it's
  very unlikely to matter,
   I realized. It's just going to trigger the exact same logic that's
  triggered when viewing
   the review request for the first time, post-upgrade. If it got it wrong
  before, I don't
   have much reason to believe it'll get it right the next time.
  
   I'll have to fix the bug properly. For that, I'll probably need a
  before/after or a solid
   repro case.
  
   Christian
  
   --
   Christian Hammond - christ...@beanbaginc.com
   Review Board - https://www.reviewboard.org
   Beanbag, Inc. -

Re: Review Board 2.0.8 is released!

2014-09-24 Thread Stephen Gallagher

On 09/24/2014 01:05 PM, Christian Hammond wrote:
 Hi everyone,
 
 Early this morning, we put out a release of Review Board 2.0.8. This
 fixes some of the major issues recently brought up on this list,
 including several issues in the New Review Request page, installation
 problems due to a new release of Python-Markdown, and more.
 
 Announcement:
 https://www.reviewboard.org/news/2014/09/24/review-board-2-0-8-released/

 
Release notes:
https://www.reviewboard.org/docs/releasenotes/reviewboard/2.0.8/
 
 As a reminder, we also announce new releases of Review Board, Power
 Pack, and soon some new free Review Board extensions on our mailing
 list at https://www.reviewboard.org/mailing-lists/
 
 You can also follow us on Twitter (https://twitter.com/reviewboard),
 Facebook (https://www.facebook.com/reviewboard.org), and Google+
 (https://plus.google.com/+reviewboardorg).
 


Fedora and EPEL 7 packages have been created and will appear in the
updates-testing repositories within 48 hours. You can download them
manually from:
https://admin.fedoraproject.org/updates/search/ReviewBoard


This version also fixes the bug noticed by David Carson in the automatic
upgrade script (unique to the Fedora packages)

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Resetting open issue counters

Here it is:

 from reviewboard.reviews.models import Comment, Review
 comment = Comment.objects.get(pk=8199)
 print comment.reply_to_id
None
 print comment.issue_opened
False
 print comment.issue_status
O
 review = comment.review.get()
 print review.pk
6722
 print review.public
True
 print review.ship_it
True
 print review.review_request_id
2050
 print review.base_reply_to_id
None
 print review.comments.values_list('pk', flat=True)
[8199L]


I guess, the issue is that the comment has issue opened flag set to
false, while the issue status is open?

On Wed, Sep 24, 2014 at 12:57 PM, Christian Hammond 
christ...@beanbaginc.com wrote:

 So according to that debug output, there is one comment that has an issue
 open. I want to do some probing into this.

 Can you run this and provide the full output, commands included?

 $ rb-site manage /path/to/site shell
  from reviewboard.reviews.models import Comment, Review
  comment = Comment.objects.get(pk=8199)
  print comment.reply_to_id
  print comment.issue_opened
  print comment.issue_status
  review = comment.review.get()
  print review.pk
  print review.public
  print review.ship_it
  print review.review_request_id
  print review.base_reply_to_id
  print review.comments.values_list('pk', flat=True)

 Christian

 --
 Christian Hammond - christ...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com


 On September 24, 2014 at 12:44:18 PM, Alexey Neyman (
 alexey.ney...@gmail.com) wrote:
  Figured it out, needs -- to have --recalculate argument applied to
  'reset-issue-counts' rather than rb-site itself.
 
  Here is the output:
 
  DEBUG:root:Calculated issue counts for review request ID 2050 across 5
  review(s): Resulting counts = {u'R': 0, u'D': 0, u'O': 1}; DB values =
  [{u'screenshot_comments__issue_status': None,
  u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
  u'comments__pk': None, u'comments__issue_status': None,
  u'file_attachment_comments__issue_status': None},
  {u'screenshot_comments__issue_status': None,
  u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
  u'comments__pk': 8194L, u'comments__issue_status': None,
  u'file_attachment_comments__issue_status': None},
  {u'screenshot_comments__issue_status': None,
  u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
  u'comments__pk': 8199L, u'comments__issue_status': u'O',
  u'file_attachment_comments__issue_status': None},
  {u'screenshot_comments__issue_status': None,
  u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
  u'comments__pk': None, u'comments__issue_status': None,
  u'file_attachment_comments__issue_status': None},
  {u'screenshot_comments__issue_status': None,
  u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None,
  u'comments__pk': None, u'comments__issue_status': None,
  u'file_attachment_comments__issue_status': None}]; Field IDs =
  {u'screenshot_comments': set([None]), u'comments': set([None, 8194L,
  8199L]), u'file_attachment_comments': set([None])}
  Issue counts for review request(s) 2050 reset.
 
  However, this review request still shows 1 open issue and there are no
  issues raised in any of the reviews - there is even no 'issue summary'
  block at the bottom of this request.
 
  Regards,
  Alexey.
 
  On Wed, Sep 24, 2014 at 12:40 PM, Alexey Neyman
  wrote:
 
   Hi Christian,
  
   Just upgraded to 2.0.8:
  
   [[[
   bash-4.1# rb-site manage /var/www.reviewboard reset-issue-counts
   --recalculate --verbosity=2 2050
   Usage: rb-site command [options] path
  
   rb-site: error: no such option: --recalculate
   bash-4.1# rb-site --version
   rb-site 2.0.8
   ]]]
  
   BTW, release notes for 2.0.8 seem to omit the 'manage' argument from
 the
   command line:
  
   rb-site reset-issue-counts --recalculate --verbosity=2
  
   Also, the usage in --help message is wrong: it suggests to use 'rb-site
   manage command' - while the correct order is 'rb-site manage
   command'.
  
   Regards,
   Alexey.
  
  
  
   On Wed, Sep 24, 2014 at 10:28 AM, Christian Hammond 
   christ...@beanbaginc.com wrote:
  
   Hey,
  
   2.0.8 contains a new reset-issue-counts management command that can be
   used. I takes a list of IDs, or --all to reset all review requests.
 Issue
   counts will be recalculated on next access.
  
   It can also provide debug info about the calculations. Can you find
 one
   of the miscalculated review requests and run:
  
   rb-site manage /path/to/site reset-issue-counts -- -verbosity=2
   --recalculate
  
   See if the counts are right and then paste the debug output from that
   command. It'll help me get a sense of what's going wrong (hopefully).
  
   (Also, I added basic --help output to rb-site for the manage
 command.)
  
   Christian
  
   --
   Christian Hammond - christ...@beanbaginc.com
   Review Board - https://www.reviewboard.org

Re: Resetting open issue counters

Hi Alexey,

Thanks, that helps a lot. I think I know what's going on then. I'll send a 
patch your way for testing once I have a fix.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org 
Beanbag, Inc. - https://www.beanbaginc.com


On September 24, 2014 at 3:06:38 PM, Alexey Neyman (alexey.ney...@gmail.com) 
wrote:
 Here it is:
 
  from reviewboard.reviews.models import Comment, Review
  comment = Comment.objects.get(pk=8199)
  print comment.reply_to_id
 None
  print comment.issue_opened
 False
  print comment.issue_status
 O
  review = comment.review.get()
  print review.pk
 6722
  print review.public
 True
  print review.ship_it
 True
  print review.review_request_id
 2050
  print review.base_reply_to_id
 None
  print review.comments.values_list('pk', flat=True)
 [8199L]
 
 
 I guess, the issue is that the comment has issue opened flag set to
 false, while the issue status is open?
 
 On Wed, Sep 24, 2014 at 12:57 PM, Christian Hammond 
 christ...@beanbaginc.com wrote:
 
  So according to that debug output, there is one comment that has an issue
  open. I want to do some probing into this.
 
  Can you run this and provide the full output, commands included?
 
  $ rb-site manage /path/to/site shell
   from reviewboard.reviews.models import Comment, Review
   comment = Comment.objects.get(pk=8199)
   print comment.reply_to_id
   print comment.issue_opened
   print comment.issue_status
   review = comment.review.get()
   print review.pk
   print review.public
   print review.ship_it
   print review.review_request_id
   print review.base_reply_to_id
   print review.comments.values_list('pk', flat=True)
 
  Christian
 
  --
  Christian Hammond - christ...@beanbaginc.com
  Review Board - https://www.reviewboard.org
  Beanbag, Inc. - https://www.beanbaginc.com
 
 
  On September 24, 2014 at 12:44:18 PM, Alexey Neyman (
  alexey.ney...@gmail.com) wrote:
   Figured it out, needs -- to have --recalculate argument applied to
   'reset-issue-counts' rather than rb-site itself.
  
   Here is the output:
  
   DEBUG:root:Calculated issue counts for review request ID 2050 across 5
   review(s): Resulting counts = {u'R': 0, u'D': 0, u'O': 1}; DB values =
   [{u'screenshot_comments__issue_status': None,
   u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None, 
   u'comments__pk': None, u'comments__issue_status': None,
   u'file_attachment_comments__issue_status': None},
   {u'screenshot_comments__issue_status': None,
   u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None, 
   u'comments__pk': 8194L, u'comments__issue_status': None,
   u'file_attachment_comments__issue_status': None},
   {u'screenshot_comments__issue_status': None,
   u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None, 
   u'comments__pk': 8199L, u'comments__issue_status': u'O',
   u'file_attachment_comments__issue_status': None},
   {u'screenshot_comments__issue_status': None,
   u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None, 
   u'comments__pk': None, u'comments__issue_status': None,
   u'file_attachment_comments__issue_status': None},
   {u'screenshot_comments__issue_status': None,
   u'file_attachment_comments__pk': None, u'screenshot_comments__pk': None, 
   u'comments__pk': None, u'comments__issue_status': None,
   u'file_attachment_comments__issue_status': None}]; Field IDs =
   {u'screenshot_comments': set([None]), u'comments': set([None, 8194L,
   8199L]), u'file_attachment_comments': set([None])}
   Issue counts for review request(s) 2050 reset.
  
   However, this review request still shows 1 open issue and there are no
   issues raised in any of the reviews - there is even no 'issue summary'
   block at the bottom of this request.
  
   Regards,
   Alexey.
  
   On Wed, Sep 24, 2014 at 12:40 PM, Alexey Neyman
   wrote:
  
Hi Christian,
   
Just upgraded to 2.0.8:
   
[[[
bash-4.1# rb-site manage /var/www.reviewboard reset-issue-counts
--recalculate --verbosity=2 2050
Usage: rb-site command [options] path
   
rb-site: error: no such option: --recalculate
bash-4.1# rb-site --version
rb-site 2.0.8
]]]
   
BTW, release notes for 2.0.8 seem to omit the 'manage' argument from
  the
command line:
   
rb-site reset-issue-counts --recalculate --verbosity=2
   
Also, the usage in --help message is wrong: it suggests to use 'rb-site
manage command' - while the correct order is 'rb-site manage
command'.
   
Regards,
Alexey.
   
   
   
On Wed, Sep 24, 2014 at 10:28 AM, Christian Hammond 
christ...@beanbaginc.com wrote:
   
Hey,
   
2.0.8 contains a new reset-issue-counts management command that can be
used. I takes a list of IDs, or --all to reset all review requests.
  Issue
counts will be recalculated on next access.
   
It can also provide debug info about the calculations. Can you find
  one
of the miscalculated

Re: Perl Syntax Highlighting working for .pm, but not .pl extensions

2014-09-24 Thread Steve

Upgrading Pygments to 1.6 fixed the problem.

--Steve

On Thursday, August 28, 2014 2:25:51 PM UTC-7, Steve wrote:

 Knowing it should work helps.  The .pl files I'm looking at are smaller 
 than the .pm files that work, so I'm going to rule out file size as the 
 cause.  I'll try to isolate the problem some more.

 Thanks

 --Steve


 On Thursday, August 28, 2014 2:01:21 PM UTC-7, David Trowbridge wrote:

 Steve,

 It should work. We apply syntax highlighting based only on the file 
 extension, but I'm sure that pygments thinks that '.pl' is a perl file. The 
 one thing that you might be hitting is that we disable syntax highlighting 
 for very large files, because it can take a very long time otherwise.

 -David


 On Thu, Aug 28, 2014 at 8:58 AM, Steve seide...@gmail.com wrote:

 When we post code with .pm extensions, we get nice perl syntax 
 highlighting, but we don't get syntax highlighting for files ending in .pl. 
  I've run the pygementize script from the command line and it recognizes 
 .pl files as perl out-of-the-box and highlights them, but this in not 
 working for some reason in RB. Is this a bug, or a configuration problem on 
 our end?  Any tips on how to troubleshoot this?

 Here's our version information:

 $ rb-site --version
 rb-site 1.7.14

 $ pygmentize -V
 Pygments version 1.5, (c) 2006-2011 by Georg Brandl.


 Thanks

 -- Steve

 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: httpd remains in 'starting' state when starting via systemctl

2014-09-24 Thread David Carson

Stephen,

Yep, removing the ...oneshot line fixed it for me.  Thanks a lot.

~David

On Wednesday, September 24, 2014 3:39:34 PM UTC-4, Stephen Gallagher wrote:

 On 09/24/2014 10:06 AM, David Carson wrote: 
  By the way, I can do the 'rb-site upgrade --all-sites' as a stand-alone 
  command, whether or not the hook is in place.  So, the problem has 
  something to do with the rb-site being called by the httpd restart (or 
  start). 
  
  
  On Wednesday, September 24, 2014 9:59:59 AM UTC-4, David Carson wrote: 
  
  Paul, 
  This is not the issue for me.  I am demonstrating below that (a) the 
  'restart httpd' succeeds when the hook is *not* in place, and (b) 
  that even if mariadb is running, the 'restart httpd' hangs when the 
  hook is in place.  The (0) at the beginning of my prompt is the 
  return code ($?). 
  
  (0)[root@pinehurst httpd.service.d] pwd 
  /usr/lib/systemd/system/httpd.service.d 
  (0)[root@pinehurst httpd.service.d] ls 
  reviewboard-sites.conf.*no.go* 
  (0)[root@pinehurst httpd.service.d] 
  (0)[root@pinehurst httpd.service.d] systemctl restart 
  httpd.service  *-- OK, no hang* 
  (0)[root@pinehurst httpd.service.d] 
  (0)[root@pinehurst httpd.service.d] 
  (0)[root@pinehurst httpd.service.d] *mv* 
  reviewboard-sites.conf.*no.go* reviewboard-sites.conf 
  (0)[root@pinehurst httpd.service.d] systemctl daemon-reload 
  (0)[root@pinehurst httpd.service.d] 
  (0)[root@pinehurst httpd.service.d] systemctl restart 
  mariadb.service  *-- make sure mariadb is running* 
  (0)[root@pinehurst httpd.service.d] 
  (0)[root@pinehurst httpd.service.d] systemctl restart 
  httpd.service *-- this one hangs (status 'activating')* 
  


 Yeah, I've been looking at it today and discovered that I was doing 
 something wrong. 

 tl;dr version: Delete the 'type=oneshot' line. 


 There were a couple of bugs here. The core problem is that I 
 misunderstood what the unit files in the drop directories did. I was 
 actually replacing the Type of httpd.service, not setting one just for 
 the add-on unit. The effect was that httpd.service was behaving as a 
 oneshot type and was not returning control until it exited. Oops. 

 However, because I typoed Type, systemd was just logging an error and 
 ignoring it. I hadn't noticed the logged error, but since things were 
 working (including upgrades) I never had cause to look in the log. 

 So I need to actually just remove that line entirely and the logged 
 error will go away and the upgrade script will run as expected. 

 I'm putting out updated packages for 2.0.8 in a few minutes which will 
 have the corrected unit file. 


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Issue 3581 in reviewboard: If a user exists in a local site they will not get emails from the normal site if they are part of a reveiw group in the normal site.


Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3581 by whyisyou...@gmail.com: If a user exists in a local site  
they will not get emails from the normal site if they are part of a reveiw  
group in the normal site.

https://code.google.com/p/reviewboard/issues/detail?id=3581

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
2.0.7

What's the URL of the page containing the problem?
broken email support

What steps will reproduce the problem?
1. have a user in a local site and the regular site
2. have same user in a review group on the normal site
3. create a review and add the review group to the review on the normal site
everyone in the review group will get the email except for the user that  
also exists in the local site.


What is the expected output? What do you see instead?
everyone in a review group should get the review email.

What operating system are you using? What browser?
centos 6.4 64 bit. firefox 32.02

Please provide any additional information below.
If I specifically add the user as an individual to the review then they get  
the email. The lack of email only occurs when they are included in a review  
group.


In our deployment because we do not actually have a local site in use and  
this appears to be one of our admins who created the localsite my solution  
was the following.

mysql use reviewboard;
Database changed
mysql delete from site_localsite_users where id='1';
Query OK, 1 row affected (0.00 sec)

mysql delete from site_localsite_admins where id='1';
Query OK, 1 row affected (0.00 sec)

It appears that the documentation link for local sites is returning a 404  
so I do not know how local site should normally be created or destroyed.



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Issue 421 in reviewboard: Enhancement request: nag owners about stale review requests



Comment #15 on issue 421 by da.s...@gmail.com: Enhancement request: nag  
owners about stale review requests

https://code.google.com/p/reviewboard/issues/detail?id=421

This is tangential/related, I'd like to be able to abstain or remove myself  
from a review request. I would do this regularly for stale reviews but  
would occationaly do so for reviews I'm unqualified for or unable to  
complete for various reasons (vacation, too busy, changed teams, etc).


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Issue 3484 in reviewboard: `rbt patch -c` fails for patches to public github repos with an RBCommons team when the patch if from a non-team member



Comment #4 on issue 3484 by john.sirois: `rbt patch -c` fails for patches  
to public github repos with an RBCommons team when the patch if from a  
non-team member

https://code.google.com/p/reviewboard/issues/detail?id=3484

Afaict there has been a regression.

I see currently for https://rbcommons.com/s/twitter/r/1072/:
jsirois@gill ~/dev/3rdparty/twitter-commons (master) $ rbt patch --debug -c  
1072

RBTools 0.6.2
Python 2.7.6 (default, Mar 22 2014, 22:59:56)

[GCC 4.8.2]

Running on Linux-3.13.0-36-generic-x86_64-with-Ubuntu-14.04-trusty
Home = /home/jsirois
Current directory = /home/jsirois/dev/3rdparty/twitter-commons
Checking for a Subversion repository...
Running: svn info --non-interactive
Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: E155007: '/home/jsirois/dev/3rdparty/twitter-commons' is not a working  
copy

---

Checking for a Git repository...
Running: git rev-parse --git-dir
Running: git config core.bare
Running: git rev-parse --show-toplevel
Running: git symbolic-ref -q HEAD
Running: git config --get branch.master.merge
Running: git config --get branch.master.remote
Running: git config --get remote.origin.url
repository info: Path: g...@github.com:twitter/commons.git, Base path: ,  
Supports changesets: False

Making HTTP GET request to https://rbcommons.com/s/twitter/api/
Making HTTP GET request to  
https://rbcommons.com/s/twitter/api/review-requests/1072/diffs/
Making HTTP GET request to  
https://rbcommons.com/s/twitter/api/review-requests/1072/diffs/1/
Making HTTP GET request to  
https://rbcommons.com/s/twitter/api/review-requests/1072/diffs/1/

Running: git status --porcelain --untracked-files=no

Patch is being applied from request 1072 with diff revision  1.

Running: git apply --index /tmp/tmpJEnO5t
Making HTTP GET request to  
https://rbcommons.com/s/twitter/api/review-requests/1072/?force-text-type=plain
Making HTTP GET request to  
https://rbcommons.com/s/twitter/api/users/Yasumoto/

Got API Error 100 (HTTP code 404): Object does not exist
Error data: {u'stat': u'fail', u'err': {u'msg': u'Object does not  
exist', u'code': 100}}

Traceback (most recent call last):
  File /home/jsirois/.pythons/venvs/rbt/bin/rbt, line 9, in module
load_entry_point('RBTools==0.6.2', 'console_scripts', 'rbt')()
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/commands/main.py,  
line 134, in main

command.run_from_argv([RB_MAIN, command_name] + args)
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/commands/__init__.py,  
line 416, in run_from_argv

exit_code = self.main(*args) or 0
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/commands/patch.py,  
line 154, in main

author = review_request.get_submitter()
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/api/resource.py,  
line 139, in lambda

self._get_url(url, **kwargs)))
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/api/decorators.py,  
line 24, in request_method

*args, **kwargs)
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/api/transport/sync.py,  
line 61, in execute_request_method

return self._execute_request(request)
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/api/transport/sync.py,  
line 70, in _execute_request

rsp = self.server.make_request(request)
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/api/request.py,  
line 484, in make_request

self.process_error(e.code, e.read())
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/api/request.py,  
line 457, in process_error

rsp['err']['msg'])
rbtools.api.errors.APIError: Object does not exist (HTTP 404, API Error 100)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Issue 3582 in reviewboard: `rbt patch -c` fails for patches to public github repos with an RBCommons team when the patch if from a non-team member


Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3582 by john.sirois: `rbt patch -c` fails for patches to public  
github repos with an RBCommons team when the patch if from a non-team member

https://code.google.com/p/reviewboard/issues/detail?id=3582

What version are you running?
=
client: 0.6.2
server: https://rbcommons.com as of today's date

What's the URL of the page containing the problem?
==
https://rbcommons.com/s/twitter/r/1072
https://rbcommons.com/s/twitter/api/users/Yasumoto/

What steps will reproduce the problem?
==
1. Create a review for a public github repo but as a user outside the  
RBCommons owning team (for this case Yasumoto is an RBCommons user _not_ in  
the twitter team).

2. rbt patch -c [the review]

What is the expected output? What do you see instead?
=
The patch should apply and be committed but it only applies and the commit  
fails, looks like so when failing:

$ rbt patch --debug -c 1072

RBTools 0.6.2
Python 2.7.6 (default, Mar 22 2014, 22:59:56)

[GCC 4.8.2]

Running on Linux-3.13.0-36-generic-x86_64-with-Ubuntu-14.04-trusty
Home = /home/jsirois
Current directory = /home/jsirois/dev/3rdparty/twitter-commons
Checking for a Subversion repository...
Running: svn info --non-interactive
Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: E155007: '/home/jsirois/dev/3rdparty/twitter-commons' is not a working  
copy

---

Checking for a Git repository...
Running: git rev-parse --git-dir
Running: git config core.bare
Running: git rev-parse --show-toplevel
Running: git symbolic-ref -q HEAD
Running: git config --get branch.master.merge
Running: git config --get branch.master.remote
Running: git config --get remote.origin.url
repository info: Path: g...@github.com:twitter/commons.git, Base path: ,  
Supports changesets: False

Making HTTP GET request to https://rbcommons.com/s/twitter/api/
Making HTTP GET request to  
https://rbcommons.com/s/twitter/api/review-requests/1072/diffs/
Making HTTP GET request to  
https://rbcommons.com/s/twitter/api/review-requests/1072/diffs/1/
Making HTTP GET request to  
https://rbcommons.com/s/twitter/api/review-requests/1072/diffs/1/

Running: git status --porcelain --untracked-files=no

Patch is being applied from request 1072 with diff revision  1.

Running: git apply --index /tmp/tmpazchr2
Making HTTP GET request to  
https://rbcommons.com/s/twitter/api/review-requests/1072/?force-text-type=plain
Making HTTP GET request to  
https://rbcommons.com/s/twitter/api/users/Yasumoto/

Got API Error 100 (HTTP code 404): Object does not exist
Error data: {u'stat': u'fail', u'err': {u'msg': u'Object does not  
exist', u'code': 100}}

Traceback (most recent call last):
  File /home/jsirois/.pythons/venvs/rbt/bin/rbt, line 9, in module
load_entry_point('RBTools==0.6.2', 'console_scripts', 'rbt')()
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/commands/main.py,  
line 134, in main

command.run_from_argv([RB_MAIN, command_name] + args)
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/commands/__init__.py,  
line 416, in run_from_argv

exit_code = self.main(*args) or 0
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/commands/patch.py,  
line 154, in main

author = review_request.get_submitter()
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/api/resource.py,  
line 139, in lambda

self._get_url(url, **kwargs)))
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/api/decorators.py,  
line 24, in request_method

*args, **kwargs)
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/api/transport/sync.py,  
line 61, in execute_request_method

return self._execute_request(request)
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/api/transport/sync.py,  
line 70, in _execute_request

rsp = self.server.make_request(request)
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/api/request.py,  
line 484, in make_request

self.process_error(e.code, e.read())
   
File /home/jsirois/.pythons/venvs/rbt/local/lib/python2.7/site-packages/rbtools/api/request.py,  
line 457, in process_error

rsp['err']['msg'])
rbtools.api.errors.APIError: Object does not exist (HTTP 404, API Error 100)

What operating system are you using? What browser?
==
Browser does not apply, but this is for:
$ uname -a
Linux gill 3.13.0-36-generic #63-Ubuntu SMP Wed Sep 3 21:30:07 UTC 2014  
x86_64 x86_64 x86_64 GNU/Linux

$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=14.04
DISTRIB_CODENAME=trusty
DISTRIB_DESCRIPTION=Ubuntu 14.04.1 LTS

Re: Issue 3484 in reviewboard: `rbt patch -c` fails for patches to public github repos with an RBCommons team when the patch if from a non-team member



Comment #5 on issue 3484 by john.sirois: `rbt patch -c` fails for patches  
to public github repos with an RBCommons team when the patch if from a  
non-team member

https://code.google.com/p/reviewboard/issues/detail?id=3484

Filed a new bug with the regression detail in case that works better for  
you folks: https://code.google.com/p/reviewboard/issues/detail?id=3582


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Issue 3452 in reviewboard: RR updated altough no changes made / warn when no changes are made


Updates:
Status: Fixed

Comment #4 on issue 3452 by trowb...@gmail.com: RR updated altough no  
changes made / warn when no changes are made

https://code.google.com/p/reviewboard/issues/detail?id=3452

Fixed in release-2.0.x (f29c57f). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Issue 3583 in reviewboard: RB2: No way to post patch with parent-diff in initial web pages


Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3583 by jared.gr...@gmail.com: RB2: No way to post patch with  
parent-diff in initial web pages

https://code.google.com/p/reviewboard/issues/detail?id=3583

What version are you running?
ReviewBoard 2.0.6

What's the URL of the page containing the problem?
Private.

What steps will reproduce the problem?
1. New Review Request
2. Select repository
3. Notice there is no longer an option to specify a diff + parent-diff.

What is the expected output? What do you see instead?
RB1 had a way to post a review using diff and parent-diff

What operating system are you using? What browser?
Mac OSX

Please provide any additional information below.
I would use 'rbt', but have been unable to get it to work, so I can't use  
it. (Seems that it doesn't like RB being on a non-80 port).


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Issue 3583 in reviewboard: RB2: No way to post patch with parent-diff in initial web pages



Comment #1 on issue 3583 by jared.gr...@gmail.com: RB2: No way to post  
patch with parent-diff in initial web pages

https://code.google.com/p/reviewboard/issues/detail?id=3583

Even having a post no patch option, where I could then use the UI in the  
review editor would be nice.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Issue 3583 in reviewboard: RB2: No way to post patch with parent-diff in initial web pages