Re: Feature request for review board

[Pratyush Khan]

Hi Christian,
thanks for getting back. For #1, if we refer the reviews generated for git 
server, we can see that with version 4.0.4 and multi-commit support, 
multiple commit entries are shown under the "Commits" section with two 
columns (i.e. Summary and Author). Each auto populated commit entry can be 
expanded with a click on the little '+' icon. After the expansion, it 
basically shows the git commit log in read only mode. I'm looking for an 
option (as a new feature request) to select a portion of this expanded 
commit log text (by mouse click and drag) and add a review comment there. 
The review comments can be shown similar to the current review comments 
given on the diff.

thanks,
Pratyush

On Tuesday, December 21, 2021 at 8:35:49 AM UTC+5:30 Christian Hammond 
wrote:

> Hi Pratyush,
>
> Thanks for the feature requests!
>
> For #1, are you wanting to just leave a comment attached to that commit 
> entry itself? Or to a line in the commit description? To help me understand 
> how we might design it, can you give me some use cases?
>
> For #2, we want to iterate on this UI a bit, bring a UI more similar to 
> revision selection, but have had other priorities since 4.0 launched. It's 
> on the roadmap, just not right away. I feel your pain on it though! I poke 
> at updating it from time to time.
>
> Christian
>
> On Thu, Dec 16, 2021 at 11:00 PM Pratyush Khan  wrote:
>
>> Hi review board community,
>> thank you for releasing the review board version 4.0.4, the multiple 
>> commit feature is very useful.
>>
>> While using the multiple commit I felt need of following two features:
>>
>> 1.  Ability to add review comments against the commit log which are auto 
>> generated from git commit logs. From the "Reviews" , in the "Commits" 
>> section where list of commits are shown, I can only expand and see the 
>> commit log in Summary, but unable to add any comments if needed. If there 
>> is a way to add review comments against commit logs, that would be really 
>> helpful.
>>
>> 2. Ability to select a single commit to see its diff with a single mouse 
>> click. From the "Diffs", in "Commits" section where list of commits are 
>> shown along with option to select a range (First and Last) of commits, 
>> today if I need to see a diff of a specified commit, I'll need to click and 
>> select both of the associated radio buttons (i.e. First and Last) of that 
>> commit. But if there would be another one-click way, e.g. select another 
>> button associated with commit, using which it would open the diff from only 
>> that single commit, that should be really helpful.
>>
>> thanks,
>> Pratyush
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/reviewboard/0aa4b126-741c-4886-93f6-50e6320b3bb7n%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/reviewboard/0aa4b126-741c-4886-93f6-50e6320b3bb7n%40googlegroups.com?utm_medium=email&utm_source=footer>
>> .
>>
>
>
> -- 
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/2d1d16ff-0884-420f-87c2-1ff8ac731aafn%40googlegroups.com.

Re: Feature request for review board

[Christian Hammond]

Hi Pratyush,

Thanks for the feature requests!

For #1, are you wanting to just leave a comment attached to that commit
entry itself? Or to a line in the commit description? To help me understand
how we might design it, can you give me some use cases?

For #2, we want to iterate on this UI a bit, bring a UI more similar to
revision selection, but have had other priorities since 4.0 launched. It's
on the roadmap, just not right away. I feel your pain on it though! I poke
at updating it from time to time.

Christian

On Thu, Dec 16, 2021 at 11:00 PM Pratyush Khan  wrote:

> Hi review board community,
> thank you for releasing the review board version 4.0.4, the multiple
> commit feature is very useful.
>
> While using the multiple commit I felt need of following two features:
>
> 1.  Ability to add review comments against the commit log which are auto
> generated from git commit logs. From the "Reviews" , in the "Commits"
> section where list of commits are shown, I can only expand and see the
> commit log in Summary, but unable to add any comments if needed. If there
> is a way to add review comments against commit logs, that would be really
> helpful.
>
> 2. Ability to select a single commit to see its diff with a single mouse
> click. From the "Diffs", in "Commits" section where list of commits are
> shown along with option to select a range (First and Last) of commits,
> today if I need to see a diff of a specified commit, I'll need to click and
> select both of the associated radio buttons (i.e. First and Last) of that
> commit. But if there would be another one-click way, e.g. select another
> button associated with commit, using which it would open the diff from only
> that single commit, that should be really helpful.
>
> thanks,
> Pratyush
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/0aa4b126-741c-4886-93f6-50e6320b3bb7n%40googlegroups.com
> 
> .
>


-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAE7VndmyRWLHkWam7hGuLbkgpQSTVFa9taLFcm05N0YMy6cU4Q%40mail.gmail.com.

Feature request for review board

[Pratyush Khan]

Hi review board community,
thank you for releasing the review board version 4.0.4, the multiple commit 
feature is very useful.

While using the multiple commit I felt need of following two features:

1.  Ability to add review comments against the commit log which are auto 
generated from git commit logs. From the "Reviews" , in the "Commits" 
section where list of commits are shown, I can only expand and see the 
commit log in Summary, but unable to add any comments if needed. If there 
is a way to add review comments against commit logs, that would be really 
helpful.

2. Ability to select a single commit to see its diff with a single mouse 
click. From the "Diffs", in "Commits" section where list of commits are 
shown along with option to select a range (First and Last) of commits, 
today if I need to see a diff of a specified commit, I'll need to click and 
select both of the associated radio buttons (i.e. First and Last) of that 
commit. But if there would be another one-click way, e.g. select another 
button associated with commit, using which it would open the diff from only 
that single commit, that should be really helpful.

thanks,
Pratyush

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/0aa4b126-741c-4886-93f6-50e6320b3bb7n%40googlegroups.com.

Re: Feature Request: Pick which revision or upload to diff against

[Christian Hammond]

Hi Gabriel,

I’m sorry, it did fall through the cracks.

I’m still not sure I’m getting it. So right now, in Review Board, say you
have this scenario:

1) Post a change for review (diff 1, based on #20)
2) Sync, make some further changes and post again (diff 2, now based on #21)

The revision slider would allow you to view:

1) Diff 1’s changes (against #20)
2) Diff 2’s changes (against #21)
3) Diff 2’s changes against Diff 1 (this is an interdiff)

Interdiffs do filter out upstream changes (new content synced in-between
the two diff uploads), but what the documentation is saying is that you may
still see some changes show up if they are woven into lines that diff 2 is
modifying, or in some cases directly around those lines. This all depends
on how the diff algorithm is seeing those changes, and whether our
heuristics determine that those changes can be filtered out or are best
shown.

I’m having trouble understanding what option #4 for the slider would be, in
your example. Diff 2 against #20?

Christian


On Fri, Jul 19, 2019 at 06:57 Gabriel Morin  wrote:

> Hi Christian,
>
> I guess this question feel through the cracks, would it be possible to
> have your take on whether this feature will be added to RB in the future?
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/2640d340-e49f-4295-8257-0b388c2957b0%40googlegroups.com
> .
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAE7Vndmim1E0pywHpUeSZox4v%3Dxteajynn0TDJyhK3AEcye3tA%40mail.gmail.com.

Re: Feature Request: Pick which revision or upload to diff against

[Gabriel Morin]

Hi Christian,

I guess this question feel through the cracks, would it be possible to have 
your take on whether this feature will be added to RB in the future?

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/2640d340-e49f-4295-8257-0b388c2957b0%40googlegroups.com.

Re: Feature Request: Pick which revision or upload to diff against

[Gabriel Morin]

Hi Christian,

No, I'm specifically referring to this ReviewBoard limitation (documented 
at 
https://www.reviewboard.org/docs/manual/3.0/users/reviews/reviewing-diffs/):

Note
> Due to the way that the diff viewer works,* if a newer diff is based on a 
> newer revision of a file, you may see other changes made to that file 
> between those revisions that has nothing to do with the review itself.*
> If you’re a developer posting code and you want to sync your source tree, 
> it’s best to try to keep as many revisions of your change based on the same 
> revision of the source tree as possible, in order to minimize the impact of 
> this on your reviewers.


Swarm and CodeCollab in recent editions don't have this limitation anymore, 
because in addition to doing the same thing as your revision slider, you 
can change the base revision for the comparison.

For instance in CodeCollab, if I:
- Upload a review when a file is at revision 20
- Sync the file to latest in Perforce (revision 21)
- Update the review

As a reviewer I can hide the changes between revision 20 and 21 from the 
diff and while still seeing all changes done by the review author, by 
selecting revision 21 as the base:

[image: 2019-07-05 11_00_19-Diff_ LiveConfig.cfg.png]

Every feature of the revision slider is still present, for instance I can 
do this to see the differences between two uploads:

[image: 2019-07-05 11_16_15-Diff_ LiveConfig.cfg.png]

With reviews lasting sometimes several months and mandatory daily merges, 
changing the base revision for the diff allows you to hide potentially 
hundreds of changes that don't come from you from the review - pretty much 
a killer feature.
It's pretty much the only thing missing from ReviewBoard to make it a 
serious contender to replace CodeCollab and Swarm for my team - really hope 
it can be added!

Thank you,
Gabriel

Le mardi 28 mai 2019 21:42:33 UTC-4, Christian Hammond a écrit :
>
> Hi Gabriel,
>
> I *think* the UI feature you're discussing is the same as our diff 
> revision slider. Every time you upload a new diff for review (after making 
> changes based on review feedback or otherwise iterating on the change), we 
> give it a new diff upload revision on that review request. The diff viewer 
> lets you change both the starting diff revision (upstream or any uploaded 
> diff) and the ending diff revision, showing the differences between those.
>
> This is documented here: 
> https://www.reviewboard.org/docs/manual/3.0/users/reviews/reviewing-diffs/#viewing-other-diff-revisions
>
> The same slider is used to change the diff range for file attachments as 
> well. This works for all text-based files, rendered Markdown files, image 
> files, and PDF files (when using Power Pack 
> ).
>
> Is that what you're referring to? It looks like it from the screenshots 
> and the linked documentation.
>
> Christian
>
> On Tue, May 28, 2019 at 4:18 PM Gabriel Morin  > wrote:
>
>> Hi!
>>
>> I'm looking into using ReviewBoard with Perforce, and being used to 
>> CodeCollab I find that your product holds up surprisingly well in some 
>> aspects, in addition to having a slicker UI.
>>
>> One major useful feature in Collab however is the ability to change what 
>> you are diffing against when viewing a file diff, namely any upload that 
>> was done to update the review, or any committed revision of the file if it 
>> was modified in source control since the start of the review. See 
>> attachment for a screenshot where the file wasn't updated externally, so 
>> only revision #3 shows. If I had to merge other people's changes, there 
>> would be a Version #4, Version #5 and so on, which correspond to the 
>> Perforce file revisions.
>>
>> Swarm added a similar functionality in recent versions: see first 
>> screenshot here: 
>> https://www.perforce.com/manuals/swarm/Content/Swarm/basics.diffs.html#Viewing_a_diff
>>  - 
>> it's becoming a pretty standard feature. (Direct link to screenshot: 
>> https://www.perforce.com/manuals/swarm/Content/Resources/Images/swarm-panel-diffs.png
>> )
>>
>> I was wondering if you're planning to add this to ReviewBoard, and 
>> whether there are major technical obstacles to implementing that. Honestly 
>> if it did have this feature it would become a credible CodeCollab 
>> replacement in my view, with the added benefit of being open-source.
>>
>> Thanks,
>> Gabriel
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to revie...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/review

Re: Feature Request: Pick which revision or upload to diff against

[Christian Hammond]

Hi Gabriel,

I *think* the UI feature you're discussing is the same as our diff revision
slider. Every time you upload a new diff for review (after making changes
based on review feedback or otherwise iterating on the change), we give it
a new diff upload revision on that review request. The diff viewer lets you
change both the starting diff revision (upstream or any uploaded diff) and
the ending diff revision, showing the differences between those.

This is documented here:
https://www.reviewboard.org/docs/manual/3.0/users/reviews/reviewing-diffs/#viewing-other-diff-revisions

The same slider is used to change the diff range for file attachments as
well. This works for all text-based files, rendered Markdown files, image
files, and PDF files (when using Power Pack
).

Is that what you're referring to? It looks like it from the screenshots and
the linked documentation.

Christian

On Tue, May 28, 2019 at 4:18 PM Gabriel Morin 
wrote:

> Hi!
>
> I'm looking into using ReviewBoard with Perforce, and being used to
> CodeCollab I find that your product holds up surprisingly well in some
> aspects, in addition to having a slicker UI.
>
> One major useful feature in Collab however is the ability to change what
> you are diffing against when viewing a file diff, namely any upload that
> was done to update the review, or any committed revision of the file if it
> was modified in source control since the start of the review. See
> attachment for a screenshot where the file wasn't updated externally, so
> only revision #3 shows. If I had to merge other people's changes, there
> would be a Version #4, Version #5 and so on, which correspond to the
> Perforce file revisions.
>
> Swarm added a similar functionality in recent versions: see first
> screenshot here:
> https://www.perforce.com/manuals/swarm/Content/Swarm/basics.diffs.html#Viewing_a_diff
>  -
> it's becoming a pretty standard feature. (Direct link to screenshot:
> https://www.perforce.com/manuals/swarm/Content/Resources/Images/swarm-panel-diffs.png
> )
>
> I was wondering if you're planning to add this to ReviewBoard, and whether
> there are major technical obstacles to implementing that. Honestly if it
> did have this feature it would become a credible CodeCollab replacement in
> my view, with the added benefit of being open-source.
>
> Thanks,
> Gabriel
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/7dee50f3-51c5-4fe6-8176-14b1e111773b%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAE7Vnd%3DTMxSUCC6FT7K4668dy-dohxDmNOoKVqpQcmWW%3DGrM5Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Feature Request: Pick which revision or upload to diff against

[Gabriel Morin]

Hi!

I'm looking into using ReviewBoard with Perforce, and being used to 
CodeCollab I find that your product holds up surprisingly well in some 
aspects, in addition to having a slicker UI.

One major useful feature in Collab however is the ability to change what 
you are diffing against when viewing a file diff, namely any upload that 
was done to update the review, or any committed revision of the file if it 
was modified in source control since the start of the review. See 
attachment for a screenshot where the file wasn't updated externally, so 
only revision #3 shows. If I had to merge other people's changes, there 
would be a Version #4, Version #5 and so on, which correspond to the 
Perforce file revisions.

Swarm added a similar functionality in recent versions: see first 
screenshot here: 
https://www.perforce.com/manuals/swarm/Content/Swarm/basics.diffs.html#Viewing_a_diff
 - 
it's becoming a pretty standard feature. (Direct link to screenshot: 
https://www.perforce.com/manuals/swarm/Content/Resources/Images/swarm-panel-diffs.png)

I was wondering if you're planning to add this to ReviewBoard, and whether 
there are major technical obstacles to implementing that. Honestly if it 
did have this feature it would become a credible CodeCollab replacement in 
my view, with the added benefit of being open-source.

Thanks,
Gabriel

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/7dee50f3-51c5-4fe6-8176-14b1e111773b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Feature Request: Review markdown docs in repositories

[Christian Hammond]

Hi Mark,

Thanks for recommending Review Board to others! It personally means a lot :)

We have plans (and actually about half the work in place) to render files
like this specially in the diff viewer. Markdown, images, PDFs. We’ve
pushed the feature back a bit due to some other priorities and a few
challenges, but it’s something I’ve badly wanted to finish up. When it’s
ready, you’ll be able to review Markdown files in both source and rendered
modes.

This wouldn’t be arriving until 5.0 at the *very* earliest (we’re trying to
wrap up features for 4.0 right now).

Christian


On Sat, Mar 16, 2019 at 08:23  wrote:

> Hi, we have used Reviewboard for several years and I recommend it to every
> developer group I speak to.
>
> Recently there is lots of activity storing Markdown documents in
> repositories. GitHub and GitLab create a Readme.md file, and the GitLab
> wiki (based on https://github.com/gollum/gollum/wiki) stored the wiki
> pages in a git repository. A lot of Microsofts documentation has also moved
> to markdown stored on github (e.g.
> https://github.com/MicrosoftDocs/azure-docs/)
>
> As far as I can tell Reviewboard lets you review markdown documents that
> you attach to a review request, but does not allow you to review (with
> markdown preview) documents that are in the diff itself. I think this would
> be really useful as we could move all of our user documentation into a
> repository for versioning and use rbtools to generate a review request for
> the documentation.
>
> If I am missing existing capability please let me know!
>
> Thanks and regards,
>
> Mark
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Feature Request: Review markdown docs in repositories

[mark . falconer]

Hi, we have used Reviewboard for several years and I recommend it to every 
developer group I speak to.

Recently there is lots of activity storing Markdown documents in 
repositories. GitHub and GitLab create a Readme.md file, and the GitLab 
wiki (based on https://github.com/gollum/gollum/wiki) stored the wiki pages 
in a git repository. A lot of Microsofts documentation has also moved to 
markdown stored on github (e.g. 
https://github.com/MicrosoftDocs/azure-docs/)

As far as I can tell Reviewboard lets you review markdown documents that 
you attach to a review request, but does not allow you to review (with 
markdown preview) documents that are in the diff itself. I think this would 
be really useful as we could move all of our user documentation into a 
repository for versioning and use rbtools to generate a review request for 
the documentation.

If I am missing existing capability please let me know!

Thanks and regards,

Mark

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: feature request: ability to suspend a review request

[James Carlson]

On Wednesday, August 29, 2018 at 6:29:43 PM UTC-4, Christian Hammond wrote:
>
> Hi James,
>
> I think this is an interesting idea. We'd need to talk about it more, see 
> how it'd fit into things, but it might be worth putting together. Either 
> natively or as an extension.
>
> A quicker option for now is to make use of the Note To Reviewers 
> extension, which gives you a text field below Testing Done that you can 
> populate with whatever information you want to communicate to reviewers. 
> The advantage of this is that the history of notes is recorded, just like 
> any other field, so people can see when the change was "suspended" and when 
> it was made available again for review.
>

Thanks for the quick reply.  Yes, that would do as a work-around.  It's 
pretty much equivalent to what I'm doing now.  The downside is that it 
doesn't show up in the dashboard for the affected review, so if reviewers 
look there (rather than just clicking on email links), then the status is 
less clear. 

-- 
James Carlson 42.703N 71.076W 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: feature request: ability to suspend a review request

[Christian Hammond]

Hi James,

I think this is an interesting idea. We'd need to talk about it more, see
how it'd fit into things, but it might be worth putting together. Either
natively or as an extension.

A quicker option for now is to make use of the Note To Reviewers extension,
which gives you a text field below Testing Done that you can populate with
whatever information you want to communicate to reviewers. The advantage of
this is that the history of notes is recorded, just like any other field,
so people can see when the change was "suspended" and when it was made
available again for review.

Christian

On Tue, Aug 28, 2018 at 7:45 AM James Carlson 
wrote:

> Every now and then, I need to tell my reviewers that there's a serious
> issue that makes their current review efforts moot.  Sometimes it's a large
> change in the source repository, and I'd like to merge (and possibly
> redesign) before continuing.  Sometimes it's due to someone's comment that
> sends me in a different direction.  Sometimes it's due to late test results
> that show an issue that wasn't caught by the initial tests.
>
> Whatever the cause, I'd like to be able to "suspend" a review.  I don't
> want to lose the existing review discussion, and I don't want to tell
> reviewers that I'm just going away, so Close->Discarded doesn't feel
> right.  And there's no good way to just add a comment to the top of the
> review.  Usually, I end up modifying the review "Description" or "Testing
> Done" field to indicate what's going on, but that seems less than adequate.
>
> Could we please have an "Update->Suspend" or something like that?  The
> work flow would be relatively simple: the request stays suspended until a
> new diff or file is added, and then it goes back to normal.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

feature request: ability to suspend a review request

[James Carlson]

Every now and then, I need to tell my reviewers that there's a serious 
issue that makes their current review efforts moot.  Sometimes it's a large 
change in the source repository, and I'd like to merge (and possibly 
redesign) before continuing.  Sometimes it's due to someone's comment that 
sends me in a different direction.  Sometimes it's due to late test results 
that show an issue that wasn't caught by the initial tests.

Whatever the cause, I'd like to be able to "suspend" a review.  I don't 
want to lose the existing review discussion, and I don't want to tell 
reviewers that I'm just going away, so Close->Discarded doesn't feel 
right.  And there's no good way to just add a comment to the top of the 
review.  Usually, I end up modifying the review "Description" or "Testing 
Done" field to indicate what's going on, but that seems less than adequate.

Could we please have an "Update->Suspend" or something like that?  The work 
flow would be relatively simple: the request stays suspended until a new 
diff or file is added, and then it goes back to normal.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Feature Request for rbt diff to support "--no-renames" argument for GIT repos

[Rick Liu]

Hi,

Could we add a new argument "--no-renames" to "rbt diff" for GIT repos?
"rbt diff" is running "git diff" at the backend.
"git diff" supports "--no-renames" option to generate DIFF file to avoid 
incorrect rename action.

But "rbt diff" doesn't take this argument right now.

Attach the ticket number here for reference:
https://hellosplat.com/s/beanbag/tickets/4551/


Thanks,
Rick

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Feature request - Hide inactive members when creating member groups

[Christian Hammond]

Hi Terry,

We have a new user selector coming that will be hiding inactive users and
helping with scalability issues for servers with thousands of users. Coming
soon to a release near you :)

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Fri, Aug 5, 2016 at 1:06 PM, Dunnigan, Terrence J <
terrence.j.dunni...@boeing.com> wrote:

> Our Review Board instance (2.5.6.1) has a number of inactive users. It
> would be nice to hide those users when adding members to Member Groups. The
> Users management feature has the ability to show all, active, or inactive
> users. Something like that for Member Groups would be great.
>
>
>
> I see that the Authentication Group has this feature already.
>
>
>
> Terry
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Feature request - Hide inactive members when creating member groups

[Dunnigan, Terrence J]

Our Review Board instance (2.5.6.1) has a number of inactive users. It would be 
nice to hide those users when adding members to Member Groups. The Users 
management feature has the ability to show all, active, or inactive users. 
Something like that for Member Groups would be great.

I see that the Authentication Group has this feature already.

Terry

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Feature request

[Eduardo Piombino]

Hi, would it be possible when showing the diffs between two files, to show 
any changes in encoding information, like for example, if one version 
didn't have an UTF-8 BOM mark and the new one does.
You would argue that the encoding is may not be important, but it actually 
can have some side effects on code.
The french character "é" for example, if encoded in ISO-8859-1 will return 
an strlen() of 1, while if it were encoded in UTF-8, it would return 2 to 
the same call. Basically what changes is that the string, byte-wise, is 
bigger in UTF-8 than in it's ISO counterpart. This little snippet can have 
consequences on already tested and stable code, and if someone during a 
patch, would change the encoding of a file, as per current state of 
reviewboard, reviewers won't even notice that such a change in encoding has 
occurred, would give their ok to ship it without even noticing the change 
in encoding.

Thanks.
Eduardo.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: ReviewBoard UI Feature Request

[jacob.j.rosales]

Thanks Christian, let me know if I can assist in any way!

On Friday, April 5, 2013 1:57:41 PM UTC-5, Christian Hammond wrote:
>
> Hi Jacob,
>
> These are all great ideas. The first and last are ones I've given some 
> thought to, but haven't been in a position to work on yet.
>
> We're working on modernizing our JavaScript codebase and doing some prep 
> work for 1.8, but sometime in there I'm hoping to do a revamp of the diff 
> viewer. I'll see if I can find a nice way to implement these features in 
> that.
>
> Christian
>
>
> On Apr 5, 2013, at 11:46, "jacob.j.rosales" 
> > 
> wrote:
>
> Hi Christian,
>
> Not sure if this is available or not, however I was wondering if the 
> following would be hard to add to the base RB code:
>
>- Ability to place a maker (Last point of review) in on a file in a 
>review request. We review large change sets and many times, we are
>multitasking and have to stop mid-review. Today we either have to 
>remember where we left off when we log back in or place a comment
>saying this is where we last stopped. 
>- Ability to have the file name with the function name as we have in 
>the current version. For instance, when the file is large, and there are 
>many
>changes across the file, we get the name of the function we are in, 
>but the filename is all the way at the top. 
>- Ability to mark files as reviewed/not-reviewed on a per reviewer 
>basis. This would allow files that have been marked as reviewed to not be 
>expanded
>in the DiffViewer. 
>
> I am sure I can riddle off many more, but wanted to put in some top UI 
> enhancement ideas out there.
> Thanks for the work on this great tool. It has already helped improve 
> quality in our software.
>
> -- 
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard...@googlegroups.com 
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard...@googlegroups.com .
> For more options, visit https://groups.google.com/groups/opt_out.
>  
>  
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: ReviewBoard UI Feature Request

[Christian Hammond]

Hi Jacob,

These are all great ideas. The first and last are ones I've given some thought 
to, but haven't been in a position to work on yet.

We're working on modernizing our JavaScript codebase and doing some prep work 
for 1.8, but sometime in there I'm hoping to do a revamp of the diff viewer. 
I'll see if I can find a nice way to implement these features in that.

Christian


On Apr 5, 2013, at 11:46, "jacob.j.rosales"  wrote:

> Hi Christian,
> 
> Not sure if this is available or not, however I was wondering if the 
> following would be hard to add to the base RB code:
> Ability to place a maker (Last point of review) in on a file in a review 
> request. We review large change sets and many times, we are
> multitasking and have to stop mid-review. Today we either have to remember 
> where we left off when we log back in or place a comment
> saying this is where we last stopped. 
> Ability to have the file name with the function name as we have in the 
> current version. For instance, when the file is large, and there are many
> changes across the file, we get the name of the function we are in, but the 
> filename is all the way at the top. 
> Ability to mark files as reviewed/not-reviewed on a per reviewer basis. This 
> would allow files that have been marked as reviewed to not be expanded
> in the DiffViewer. 
> I am sure I can riddle off many more, but wanted to put in some top UI 
> enhancement ideas out there.
> Thanks for the work on this great tool. It has already helped improve quality 
> in our software.
> -- 
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>  
>  

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

ReviewBoard UI Feature Request

[jacob.j.rosales]

Hi Christian,

Not sure if this is available or not, however I was wondering if the 
following would be hard to add to the base RB code:

   - Ability to place a maker (Last point of review) in on a file in a 
   review request. We review large change sets and many times, we are
   multitasking and have to stop mid-review. Today we either have to 
   remember where we left off when we log back in or place a comment
   saying this is where we last stopped. 
   - Ability to have the file name with the function name as we have in the 
   current version. For instance, when the file is large, and there are many
   changes across the file, we get the name of the function we are in, but 
   the filename is all the way at the top. 
   - Ability to mark files as reviewed/not-reviewed on a per reviewer 
   basis. This would allow files that have been marked as reviewed to not be 
   expanded
   in the DiffViewer. 

I am sure I can riddle off many more, but wanted to put in some top UI 
enhancement ideas out there.
Thanks for the work on this great tool. It has already helped improve 
quality in our software.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Feature request: Decline a review request

[Tomer]

I would like to suggest a new feature for RB: the ability to ignore a
review request.

The problem:
---
I've found that more often than not, my review requests will simply be
ignored by some of the reviewers.
The reason may vary (too busy, not familiar with the code base, plain
lazy), but it all comes down to the fact that not all reviewers will
actually review the code.

Possible solution:
--
Add a "Ignore request" option/button.
This can be something parallel to the "Ship it!" feature. This way, a
review resolution may be split into two:
1. Approved by reviewer.
2. Ignored by reviewer.
An ideal review request will be closed when all reviewers are either
approved or ignored it.

--Tomer

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Feature Request for Reviewboard

[Ashith]

I am not very well versed with SQL queries and MySQL. Can you forward
me some of the queries you use to get the statistics and how to run
them. Just some basic hand holding to get me up to speed?


On May 6, 6:28 pm, Leonel Togniolli  wrote:
> In the mean time, you can just log in the mysql db and query for the
> info. The schema is fairly straightforward.That's what I did when I
> needed similar info recently.
>
>
>
>
>
>
>
> On Fri, May 6, 2011 at 9:03 AM, Ashith  wrote:
> > We are planning to track the review requests and the reviewers
> > statistics in reviewboard. Right now the statistics is only for the
> > reviews and review requests. It would be helpful if the statistics
> > provided the following data,
>
> > 1. No of review requests logged by each user till date (can be broken
> > down as lst 7 days, last month, all days)
> > 2. No of review requests each user is linked to.
> > 3. No of reviews done by each user.
>
> > It would also be helpful to add a cool graphing tool to show the
> > statistics in a neat little graph.
>
> > I know I am asking for the moon, but I am so excited with the concept
> > of introducing reviewboard in our organization I guess I can be
> > pardoned for asking for the moon.
>
> > --
> > Want to help the Review Board project? Donate today 
> > athttp://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to 
> > reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group 
> > athttp://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Feature Request for Reviewboard

[Leonel Togniolli]

In the mean time, you can just log in the mysql db and query for the
info. The schema is fairly straightforward.That's what I did when I
needed similar info recently.

On Fri, May 6, 2011 at 9:03 AM, Ashith  wrote:
> We are planning to track the review requests and the reviewers
> statistics in reviewboard. Right now the statistics is only for the
> reviews and review requests. It would be helpful if the statistics
> provided the following data,
>
> 1. No of review requests logged by each user till date (can be broken
> down as lst 7 days, last month, all days)
> 2. No of review requests each user is linked to.
> 3. No of reviews done by each user.
>
> It would also be helpful to add a cool graphing tool to show the
> statistics in a neat little graph.
>
> I know I am asking for the moon, but I am so excited with the concept
> of introducing reviewboard in our organization I guess I can be
> pardoned for asking for the moon.
>
> --
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Feature Request for Reviewboard

[Ashith]

We are planning to track the review requests and the reviewers
statistics in reviewboard. Right now the statistics is only for the
reviews and review requests. It would be helpful if the statistics
provided the following data,

1. No of review requests logged by each user till date (can be broken
down as lst 7 days, last month, all days)
2. No of review requests each user is linked to.
3. No of reviews done by each user.

It would also be helpful to add a cool graphing tool to show the
statistics in a neat little graph.

I know I am asking for the moon, but I am so excited with the concept
of introducing reviewboard in our organization I guess I can be
pardoned for asking for the moon.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Feature Request: Include changed files with review

[Nathan Auch [Sybase]]

Our organization has a similar need. We handle it by running a locally 
modified version of post-review that includes a "--patch-client" option 
which downloads the diff from the server, grabs the base revisions of 
the files from SCM, opens the files for edit and applies the patch. It 
was actually pretty easy to get working. It only works for perforce and 
I don't really want to go through the work of submitting a patch against 
the trunk post-review but I'd be willing to post the relevant code here 
if it's useful to you.

Nathan Auch

Christian Hammond wrote:
> Hi Dana,
>
> I see two ways of doing this.
>
> 1) Make an actual view that returns a zip file (or something) that 
> contains all the files, basically using existing code that we have to 
> download each one, and assemble a zip file of those files. There's a 
> little bit of processing time, but it shouldn't be too bad, really.
>
> 2) Implement more general file attachment support.
>
> There's a long-standing feature request for attaching arbitrary files. 
> See http://code.google.com/p/reviewboard/issues/detail?id=239
>
> Uploading file attachments is something we want to have in, but just 
> haven't made a priority. If someone wants to work on this, though, 
> we'd be glad to discuss it and get a change in!
>
> It would work similarly to the screenshots. Attachments would have a 
> filename and a mimetype, and they'd be accessible through, say, 
> /r//attachments/.
>
> Maybe we really want both, long-term.
>
> What are your thoughts?
>
> Christian
>
>
> -- 
> Christian Hammond - chip...@chipx86.com <mailto:chip...@chipx86.com>
> Review Board - http://www.review-board.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Thu, Sep 10, 2009 at 4:17 PM, Lacoste, Dana (TSG Software San 
> Diego) mailto:dana.laco...@hp.com>> wrote:
>
> So, before we used Review Board we used an internal (python based,
> similar to how p4review works) tool to do the following:
>
>  
>
> 1 - Make a copy of the files in a changelist to a share
>
> 2 - Make a copy of the "baseline" version files to the same share
>
> 3 - Make a "wrapper" file specifying what the files were
>
> 4 - Send an email pointing at the files saying "I've proposed this
> change, can you review it?" to users specified by the code changer.
>
> 5 - Run Beyond Compare/Araxis Merge/etc. against the results (we
> had a python wrapper which would launch the tool for you)
>
>  
>
> With Review Board, 1-4 are working FAR better than we had before,
> and we also get :
>
> 6 - A website which records feedback on changes
>
>  
>
> BUT
>
>  
>
> We can't do #5.  With complicated changes and large number of
> files the Review Board page can be hard to navigate (not that I
> think there's anything Review Board can do about this: some
> changes are too complicated) and the diff might not show adequate
> info (now THIS is something I think we _/can/_ do something about.)
>
>  
>
> So I'd like to propose a feature Request: I'd like to be able to
> "attach" a .zip to a review request containing the entirety of the
> changed files.  This way I could click on "Download Diff" and get
> a .tar/.zip of the modified versions of the files which I could
> view in their entirety (instead of just the .diff files)
>
>  
>
> I realize this isn't trivial, but I thought I'd ask in case
> someone else thought it would be useful too J
>
>  
>
> Thanks,
>
>  
>
> Dana Lacoste
>
>
>
>
>
> >


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Feature Request: Include changed files with review

[Christian Hammond]

Hi Dana,

I see two ways of doing this.

1) Make an actual view that returns a zip file (or something) that contains
all the files, basically using existing code that we have to download each
one, and assemble a zip file of those files. There's a little bit of
processing time, but it shouldn't be too bad, really.

2) Implement more general file attachment support.

There's a long-standing feature request for attaching arbitrary files. See
http://code.google.com/p/reviewboard/issues/detail?id=239

Uploading file attachments is something we want to have in, but just haven't
made a priority. If someone wants to work on this, though, we'd be glad to
discuss it and get a change in!

It would work similarly to the screenshots. Attachments would have a
filename and a mimetype, and they'd be accessible through, say,
/r//attachments/.

Maybe we really want both, long-term.

What are your thoughts?

Christian


-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Thu, Sep 10, 2009 at 4:17 PM, Lacoste, Dana (TSG Software San Diego) <
dana.laco...@hp.com> wrote:

>  So, before we used Review Board we used an internal (python based,
> similar to how p4review works) tool to do the following:
>
>
>
> 1 - Make a copy of the files in a changelist to a share
>
> 2 - Make a copy of the "baseline" version files to the same share
>
> 3 - Make a "wrapper" file specifying what the files were
>
> 4 - Send an email pointing at the files saying "I've proposed this change,
> can you review it?" to users specified by the code changer.
>
> 5 - Run Beyond Compare/Araxis Merge/etc. against the results (we had a
> python wrapper which would launch the tool for you)
>
>
>
> With Review Board, 1-4 are working FAR better than we had before, and we
> also get :
>
> 6 - A website which records feedback on changes
>
>
>
> BUT
>
>
>
> We can't do #5.  With complicated changes and large number of files the
> Review Board page can be hard to navigate (not that I think there's anything
> Review Board can do about this: some changes are too complicated) and the
> diff might not show adequate info (now THIS is something I think we _*can*_
> do something about.)
>
>
>
> So I'd like to propose a feature Request: I'd like to be able to "attach" a
> .zip to a review request containing the entirety of the changed files.  This
> way I could click on "Download Diff" and get a .tar/.zip of the modified
> versions of the files which I could view in their entirety (instead of just
> the .diff files)
>
>
>
> I realize this isn't trivial, but I thought I'd ask in case someone else
> thought it would be useful too J
>
>
>
> Thanks,
>
>
>
> Dana Lacoste
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Feature Request: Include changed files with review

[Lacoste, Dana (TSG Software San Diego)]

So, before we used Review Board we used an internal (python based, similar to 
how p4review works) tool to do the following:

1 - Make a copy of the files in a changelist to a share
2 - Make a copy of the "baseline" version files to the same share
3 - Make a "wrapper" file specifying what the files were
4 - Send an email pointing at the files saying "I've proposed this change, can 
you review it?" to users specified by the code changer.
5 - Run Beyond Compare/Araxis Merge/etc. against the results (we had a python 
wrapper which would launch the tool for you)

With Review Board, 1-4 are working FAR better than we had before, and we also 
get :
6 - A website which records feedback on changes

BUT

We can't do #5.  With complicated changes and large number of files the Review 
Board page can be hard to navigate (not that I think there's anything Review 
Board can do about this: some changes are too complicated) and the diff might 
not show adequate info (now THIS is something I think we _can_ do something 
about.)

So I'd like to propose a feature Request: I'd like to be able to "attach" a 
.zip to a review request containing the entirety of the changed files.  This 
way I could click on "Download Diff" and get a .tar/.zip of the modified 
versions of the files which I could view in their entirety (instead of just the 
.diff files)

I realize this isn't trivial, but I thought I'd ask in case someone else 
thought it would be useful too :)

Thanks,

Dana Lacoste

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Small UI feature request: 2 new fields

[Sebastien Douche]

On Fri, Mar 20, 2009 at 19:53, Christian Hammond  wrote:
>  However, after 1.0, we're putting in
> support for extensions, and it should be possible at that time to add custom
> fields. It's a little ways down the line, as we need to finish 1.0 first,
> but that's getting much closer now.

Great, it's a major feature for us.

-- 
Sebastien Douche 

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Small UI feature request: 2 new fields

[Christian Hammond]

I missed this e-mail entirely. Sorry about that.

We have no plans to add additional fields to Review Board. Custom fields are
often very dependent on the company that wants them, and it's not easy to
just add them directly in the codebase. However, after 1.0, we're putting in
support for extensions, and it should be possible at that time to add custom
fields. It's a little ways down the line, as we need to finish 1.0 first,
but that's getting much closer now.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Mar 20, 2009 at 7:45 AM, Sebastien Douche  wrote:

>
> On Fri, Feb 20, 2009 at 16:57, Sebastien Douche  wrote:
> > 1. field "dependency"
> > 2. field "state"
>
> No success for my proposal ;(. Now I need 4 new fields, how adding them?
>
> --
> Sebastien Douche 
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Small UI feature request: 2 new fields

[Sebastien Douche]

On Fri, Feb 20, 2009 at 16:57, Sebastien Douche  wrote:
> 1. field "dependency"
> 2. field "state"

No success for my proposal ;(. Now I need 4 new fields, how adding them?

-- 
Sebastien Douche 

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Feature request

[Christian Hammond]

Is this something you'd be able to contribute to the project, make available
to other people?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Mar 2, 2009 at 7:29 PM, TP  wrote:

>
> I have a Perforce commit trigger to update the status to submit as
> well as updating the pending changelist number with the actual
> submitting changelist.
>
> On Mar 2, 1:57 pm, plumpy  wrote:
> > There is a post-commit hook for subversion that will automatically
> > close reviews. That's not at all what you asked for, but maybe it will
> > help. It's at contrib/tools/post-commit.
> >
> > On Mar 2, 1:22 pm, David Trowbridge  wrote:
> >
> > > We've been toying around with how best to do this for a while. Can you
> > > add your suggestions tohttp://
> code.google.com/p/reviewboard/issues/detail?id=294?This will
> > > help us keep track of them better.
> >
> > > Thanks!
> > > -David
> >
> > > On Mon, Mar 2, 2009 at 7:40 AM, Isaac Wagner 
> wrote:
> > > > My users have a real hard time going back to close a review once they
> have
> > > > submitted the code.  Instead of my periodically auditing the open
> reviews it
> > > > would be nice to have reminder emails sent out at a configurable
> period.
> > > > Or, even just a button that I could click on to send reminder emails
> to
> > > > anyone with a review that has been pending for more than x days
> (where x is
> > > > configurable).
> >
> > > > Thanks.
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Feature request

[TP]

I have a Perforce commit trigger to update the status to submit as
well as updating the pending changelist number with the actual
submitting changelist.

On Mar 2, 1:57 pm, plumpy  wrote:
> There is a post-commit hook for subversion that will automatically
> close reviews. That's not at all what you asked for, but maybe it will
> help. It's at contrib/tools/post-commit.
>
> On Mar 2, 1:22 pm, David Trowbridge  wrote:
>
> > We've been toying around with how best to do this for a while. Can you
> > add your suggestions 
> > tohttp://code.google.com/p/reviewboard/issues/detail?id=294?This will
> > help us keep track of them better.
>
> > Thanks!
> > -David
>
> > On Mon, Mar 2, 2009 at 7:40 AM, Isaac Wagner  wrote:
> > > My users have a real hard time going back to close a review once they have
> > > submitted the code.  Instead of my periodically auditing the open reviews 
> > > it
> > > would be nice to have reminder emails sent out at a configurable period.
> > > Or, even just a button that I could click on to send reminder emails to
> > > anyone with a review that has been pending for more than x days (where x 
> > > is
> > > configurable).
>
> > > Thanks.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Feature request

[plumpy]

There is a post-commit hook for subversion that will automatically
close reviews. That's not at all what you asked for, but maybe it will
help. It's at contrib/tools/post-commit.

On Mar 2, 1:22 pm, David Trowbridge  wrote:
> We've been toying around with how best to do this for a while. Can you
> add your suggestions 
> tohttp://code.google.com/p/reviewboard/issues/detail?id=294? This will
> help us keep track of them better.
>
> Thanks!
> -David
>
> On Mon, Mar 2, 2009 at 7:40 AM, Isaac Wagner  wrote:
> > My users have a real hard time going back to close a review once they have
> > submitted the code.  Instead of my periodically auditing the open reviews it
> > would be nice to have reminder emails sent out at a configurable period.
> > Or, even just a button that I could click on to send reminder emails to
> > anyone with a review that has been pending for more than x days (where x is
> > configurable).
>
> > Thanks.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Feature request

[David Trowbridge]

We've been toying around with how best to do this for a while. Can you
add your suggestions to
http://code.google.com/p/reviewboard/issues/detail?id=294 ? This will
help us keep track of them better.

Thanks!
-David

On Mon, Mar 2, 2009 at 7:40 AM, Isaac Wagner  wrote:
> My users have a real hard time going back to close a review once they have
> submitted the code.  Instead of my periodically auditing the open reviews it
> would be nice to have reminder emails sent out at a configurable period.
> Or, even just a button that I could click on to send reminder emails to
> anyone with a review that has been pending for more than x days (where x is
> configurable).
>
> Thanks.
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Feature request

[Isaac Wagner]

My users have a real hard time going back to close a review once they have
submitted the code.  Instead of my periodically auditing the open reviews it
would be nice to have reminder emails sent out at a configurable period.
Or, even just a button that I could click on to send reminder emails to
anyone with a review that has been pending for more than x days (where x is
configurable).

Thanks.

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Small UI feature request: 2 new fields

[Sebastien Douche]

Hi there,
We use intensively reviewboard, but we have 2 use caes where RB isn't efficient:

1. A request based on another request (revision is unknown on repository)
2. A request in progress (patch regularly updated)

I know it's not easy to develop, thus I propose small improvement: add
new field for each use cases:

1. field "dependency"
2. field "state"

What do you think? How implement this for our needs?


Cheers

-- 
Sebastien Douche 

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---