Re: View diff and collapse left or right side

Hi Jeff, There's no way to do this, I'm afraid. Something to consider for a future version, but it'll probably be a bit low on the priority list for now, relative to other projects we're working on. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org B

Re: "View Diff" cause "patch didn't apply cleanly" error when ReviewBoard is used with BitBucket repositories

Hi Olivia, I am able to set up git with review board and able to view diff. For this you need to have local git repository on same machine as review board or else if you want connect to remote repository u need to have gitweb installed in git server. Thanks Anand On Friday, January 6, 2012 at

Re: View Diff - show new changes on left side

Ok, I see. Thanks for the quick reply. On Thursday, March 27, 2014 4:14:41 PM UTC-4, Christian Hammond wrote: > > Hi Derek, > > No, there's no optional or ability to do this, nor would we want to spend > the time adding one. That's a very unusual design for a diff viewer, and > I'm a bit surpris

Re: View Diff - show new changes on left side

Hi Derek, No, there's no optional or ability to do this, nor would we want to spend the time adding one. That's a very unusual design for a diff viewer, and I'm a bit surprised that's what Eclipse uses. If you really must have this, you could fork the source and change the templates and all the J

Re: View-Diff misaligned on RB

I'm not sure what you're asking. Can you clarify? Screenshots would be nice. -David On Tue, Aug 13, 2013 at 4:01 AM, Varun Jain wrote: > Hi Team, > > View diff misalignment issue is being faced on RB 1.7.7.1. I don't know > how to reproduce this issue exactly but I've been a victim of diff > mi

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

That's great! Thanks! Tao On Mon, Jan 28, 2013 at 5:13 PM, Christian Hammond wrote: > Okay. It's not related to the issue manager, but I suspect I know what's > causing it. It was a change that fixed a security problem, but apparently > caused another bug when using \ in filenames. > > We just d

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

Okay. It's not related to the issue manager, but I suspect I know what's causing it. It was a change that fixed a security problem, but apparently caused another bug when using \ in filenames. We just did a 1.7.3 release, which didn't include a fix for this, but I'll try to get you a patch soon on

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

Below is the error I got from Chrome, if need any further information, plz tell me how to, Thanks! Uncaught SyntaxError: Unexpected token ILLEGAL 172.21.78.85:856 isshow:false loader.js:14 1. Uncaught SyntaxError: Unexpected token IL

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

New to reviewboard, I am not quite familiar with the system and bug fix process, I have submitted a codereview: http://reviews.reviewboard.org/r/3804/ Regards, Tao On Sunday, January 27, 2013 4:29:26 AM UTC+8, Christian Hammond wrote: > > Hi Tao, > > Can you post the fix up on http://reviews.re

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

I haven't been able to reproduce this. Can you get me a stack trace from the JavaScript console, showing what's calling what? I also need to know which page you're hitting this on, and a repro case. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org V

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

Hi Tao, Can you post the fix up on http://reviews.reviewboard.org? All patches must go through a review process there. Thanks! Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jan 26, 2013 at 5:41 AM,

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

Hi, Christian: Thanks for your update, I will have a test after the new release, and see if the issue being resolved. And if possible, could you plz also add the fix to avoid prompting many cleartool console window when doing post-review and viewing diff? (see https://groups.google.com/forum/?

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

Hi Tao, I'll look into this and see what I can do. We'll be putting out a new release this week. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Jan 25, 2013 at 12:33 AM, Tao Zhou wrote: > Hi, > > I

Re: view diff problem "patch didnt apply cleanly"

You'll have to look at the diff and debug files it mentions and see if you can see where things went wrong. I don't have enough information to answer this question. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com

Re: "View Diff" cause "patch didn't apply cleanly" error when ReviewBoard is used with BitBucket repositories

Hi, I have a similar setup of ReviewBoard with Mercurial repository being managed by RhodeCode with a username and password authentication. I'm able to do a 'hg postreview -o xxx' and when I click on 'View Diff' I'm getting the same error. Any pointers on the same would be really helpful. Than

Re: "View Diff" show that "patch didn't apply cleanly" when used with RhodeCode

Hi Everyone, I've currently moved from the basic hgweb.cgi to RhodeCode for my Mercurial repository. Since RhodeCode does a Username/Password authentication, I've added the Username and Password in the Repositories setting. When I did a 'hg postreview -o xxx', the review successfully appears o

Re: "View Diff" cause "patch didn't apply cleanly" error when ReviewBoard is used with BitBucket repositories

Hi Nikita, I met the same issue with Git repository. Do you have any suggestion to fix? Should I also change /usr/local/lib/python2.6/dist-packages/ ReviewBoard-1.6-py2.6.egg/reviewboard/scmtools/git.py and how? Best Regards, Olivia Yin On 2011年12月21日, 下午11时08分, Nikita Zhuk wrote: > Ok, I've d

Re: "View Diff" cause "patch didn't apply cleanly" error when ReviewBoard is used with BitBucket repositories

Ok, I've debugged this problem a bit and came to the conclusion that fetching raw files in hg.py from BitBucket with HTTPBasicAuthHandler seems to have some issues. I've created a workaround by tweaking the HgWebClient class a bit to use BitBucket API to fetch raw files. This patch solved my proble

Re: "View Diff" cause "patch didn't apply cleanly" error when ReviewBoard is used with BitBucket repositories

Hi Nikita, Can you show me what the configuration looks like, roughly? (Censor out sensitive parts, but the structure is important). It sounds like it's just some configuration error. It's not using a valid URL for fetching the raw files. Christian -- Christian Hammond - chip...@chipx86.com Re

Re: View Diff option in draft is sometimes unavailable

For #1, that's absolutely intentional. No diffs on graphics-only review requests. For #2, you should see an error during upload if it's not visible. The only time View Diff is not shown is if there's no diff stored in the database. Christian -- Christian Hammond - chip...@chipx86.com Review Boa

Re: View Diff option in draft is sometimes unavailable

I get this situation in 2 cases: - Creating a request for "None - Graphics Only" - Creating a request and uploading an invalid patch through the Web API -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard

Re: View Diff option in draft is sometimes unavailable

Hi Jan, I've never seen "View Diff" not available if there was a diff. It should always show up as long as you're the owner of the review request. Other users wouldn't see it, though (except for a superuser, which always sees draft information and diffs). Christian -- Christian Hammond - chip..

Re: 'view diff' (diffutils.py) in 1.5.4 can't work well on my Windows

Finally I setup it on a Linux server, windows is just not a suitable platform for server I feel. Still I describe my environment here in case someone met the same problem: GnuPatch and Python were installed normally by install package, download from official site. Windows XP SP3 -- Want to he

Re: view diff met "IOError: [Errno 22] Invalid argument"

Please ignore this. I just stop and start Apache (not restart), it's gone (weird Windows)... Maybe not gone totally, but it prompted errors on another place, so the runtime environment has been messed up I guess. -- Want to help the Review Board project? Donate today at http://www.reviewboard.

Re: 'view diff' (diffutils.py) in 1.5.4 can't work well on my Windows

Hi, While Windows is definitely a harder platform to support (depending on where you get your Python and various modules from, different compatibility problems may occur), many people do use it. This is the first time I've heard of this particular problem you're having. How did you install GNU pa

Re: "View Diff" shows blank screen

ailto:reviewbo...@googlegroups.com] > *On Behalf Of *Christian Hammond > *Sent:* 16 April 2010 21:29 > *To:* reviewboard@googlegroups.com > *Subject:* Re: "View Diff" shows blank screen > > > > Hi John, > > > Can you enable logging on your Review Boar

RE: "View Diff" shows blank screen

regards, John From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: 16 April 2010 21:29 To: reviewboard@googlegroups.com Subject: Re: "View Diff" shows blank screen Hi John, Can you enable logging on your Review Board server (you m

RE: "View Diff" shows blank screen

[Mon Apr 19 13:41:36 2010] [debug] mod_deflate.c(615): [client 192.168.0.103] Zlib: Compressed 284 to 219 : URL /favicon.ico From: John Barber [mailto:john.bar...@mobica.com] Sent: 19 April 2010 12:44 To: 'reviewboard@googlegroups.com' Subject: RE: "View Diff" shows blan

Re: "View Diff" shows blank screen

Hi John, Can you enable logging on your Review Board server (you may have to restart Apache) and see if anything comes up when you do this? I don't recall this exact problem and I'm not sure why it would happen. What version of PySVN do you have? Christian -- Christian Hammond - chip...@chipx8

Re: View Diff shows blank screen

Glad you got it working! Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Wed, Aug 12, 2009 at 5:23 AM, Geetanjali wrote: > > I could finally resolve the issue and get RB running :) > pysvn was crashing as

Re: View Diff shows blank screen

I could finally resolve the issue and get RB running :) pysvn was crashing as I was using an older version of subversion client. After upgrading it to 1.4.6 and rebuilding pysvn, I am able to work with reviewboard. Thanks for the quick responses. Regards, Geetanjali On Aug 11, 12:26 pm, Chris

Re: View Diff shows blank screen

Almost sounds like PySVN is crashing or something. Otherwise, some exception would be shown, and you'd see *something* on the screen. Which distro is this, and what method did you use for installing both libsvn and pysvn? Are you using http, https, svn://, or svn+ssh:// for the SVN repository? O

Re: View Diff shows blank screen

After some debugging I found that the execution does not continue after the following line in scmtools/svn.py - data = self.client.cat(normpath, normrev) The variables normpath and normrev contain correct values and if the same values are used in a test program to get the data using pysvn, I get

Re: View Diff shows blank screen

Hi Christian, Thanks for the response. I am using firefox with firebug plugin. There is no error displayed on the page. Also, the HTML source is blank. I guess there is some exception occurring at the Server and the HTML is not getting generated. However, I am not able to debug any further. Where

Re: View Diff shows blank screen

Does the JavaScript console show any errors for the page? Is this with Firefox? Installing the Firebug plugin may provide some more useful information. Also, is there any content on the page at all? If you view the source, is it empty? Christian -- Christian Hammond - chip...@chipx86.com Revie

Re: View diff is failing

Humm, i made it :) Basically the problem was the apache server not recognize the patch in the path. O i copied directly to the bin folder of apache and it started to work correclty. And i tried generating the diff file with tortoise and it worked fine too... Thanks guys for your help. On Fri, J

Re: View diff is failing

Tortoise SVN doesn't generate compatible diffs. Try svn diff. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Thu, Jul 2, 2009 at 3:48 PM, Henrike Coelho wrote: > Hi Roman, doesn't work for me. > > -I've c

Re: View diff is failing

Hi Henrike, I've created the diff with Eclipse (team/create patch). Try that or with some another tool. Bye. On Thu, Jul 2, 2009 at 7:48 PM, Henrike Coelho wrote: > Hi Roman, doesn't work for me. > > -I've created a patch with tortoise svn and created a new review request > -I've moved the di

Re: View diff is failing

Hi Roman, doesn't work for me. -I've created a patch with tortoise svn and created a new review request -I've moved the diff file to bin directory in apache folder (and restarted the server just in case) -The same error still happens. suggestions? I don't understand which is the really issue rela

Re: View diff is failing

Hi All, I'm having the same problme. patch.exe is included in the path but the error is still there. Any suggestions. Here is the stack trace: Traceback (most recent call last): File "c:\dev\python25\lib\site-packages\ReviewBoard-1.0alpha1- py2.5.egg\reviewboard\diffviewer\views.py", line 86,

Re: View diff is failing

Hi Guy, Inspite of having the patch included in my path, I had to copy the patch to the apache bin directory. This is not an elegant solutions, but it works :). On 30 jun, 19:32, Henrike Coelho wrote: > Hi Christian, > > humm I've tried to do that, however without success :( the error still

Re: View diff is failing

Hi Christian, humm I've tried to do that, however without success :( the error still happens. patch-2.5.9-7-setup I've installed this version, do you know any issue with this version (python 2.5)? Can you give me an idea how can i generate diff files compatible with review board? On Tue, Jun 30,

Re: View diff is failing

Yeah, TortoiseSVN definitely won't work. They generate slightly incompatible diffs. We might be able to work around it at some point, but someone would probably have to contribute a patch for that. However, the "the system cannot find the file specified" error is definitely Apache not finding patc

Re: View diff is failing

I should add that the diff file was generated with tortoisesvn, creating a patch... Is there any known issue creating the diff in this way? On 30 Jun, 00:37, Christian Hammond wrote: > GNU patch.exe must be in the path for this to work. It appears that it's not > able to find this. > > Christian

Re: View diff is failing

Thanks for the quick review :) In fact i had already the GNU patch.exe installed but not in the path. I've set the C:\Program Files\GnuWin32\bin\ in the path and the patch.exe is already defined in the environment vars, however the error still appears. I'm using apache, so after set in environmen

Re: View diff is failing

GNU patch.exe must be in the path for this to work. It appears that it's not able to find this. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, Jun 29, 2009 at 4:33 PM, henriquecoelho wrote: > > Hi al

Re: View Diff Not Working

It's generally best if you can use http for Review Board, otherwise some additional configuration is needed. In this case, you'll hvae to look up how to store an HTTPS certificate for that server and then put it in your Apache user's .subversion/auth. Off-hand, I don't know how to do this, but ther

Re: View Diff is broken: Diff currently unavailable.

gt; p = subprocess.Popen(cmdline, stdout=subprocess.PIPE, > stderr=subprocess.PIPE) > File "/usr/lib64/python2.4/subprocess.py", line 542, in __init__ > errread, errwrite) > File "/usr/lib64/python2.4/subprocess.py", line 975, in > _execute_chil

RE: View Diff is broken: Diff currently unavailable.

te) File "/usr/lib64/python2.4/subprocess.py", line 975, in _execute_child raise child_exception OSError: [Errno 2] No such file or directory From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian

Re: View Diff is broken: Diff currently unavailable.

That fixed it. Thanks. On Tue, Feb 3, 2009 at 2:53 PM, Christian Hammond wrote: > It wouldn't have with last night's build. I didn't update the dependency for > the new nightly. > > Do an upgrade of Djblets as well and it should work. > > Christian > > -- > Christian Hammond - chip...@chipx86.co

Re: View Diff is broken: Diff currently unavailable.

It wouldn't have with last night's build. I didn't update the dependency for the new nightly. Do an upgrade of Djblets as well and it should work. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Feb 3, 2009 at 2:43 PM, Matthew Von Bargen wrote: > > I don't know... >

Re: View Diff is broken: Diff currently unavailable.

I don't know... If running "sudo easy_install --upgrade ReviewBoard" upgrades Djblets then I upgraded it. If not, then I did not. On Tue, Feb 3, 2009 at 2:38 PM, Christian Hammond wrote: > Er, yeah, key.. I'm a bit out of it today. > > Did you upgrade Djblets as well? > > Christian > > -- > Chr

Re: View Diff is broken: Diff currently unavailable.

Er, yeah, key.. I'm a bit out of it today. Did you upgrade Djblets as well? Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Feb 3, 2009 at 2:35 PM, Matthew Von Bargen wrote: > > Okay. Thanks. > > Did you mean: > > key += "-%s" % settings.AJAX_SERIAL > > instead of :

Re: View Diff is broken: Diff currently unavailable.

Okay. Thanks. Did you mean: key += "-%s" % settings.AJAX_SERIAL instead of : str += "-%s" % settings.AJAX_SERIAL ? If I do what you say, but assign to +key+ instead of +str+, then things mostly work. But I am still seeing one "Diff currently unavailable." error: Diff currently unavailable.

Re: View Diff is broken: Diff currently unavailable.

Odd that I didn't hit that during testing... I've committed a fix to SVN, but you can edit /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py line 53 and change the line to: str += "-%s" % settings.AJAX_SERIAL I'm putting out the 1.0 al

Re: View Diff

Thanks i had p4 in my inverment but not in apache so using ln -s /usr/local/bin p4 p4 fixed it thanks. On Jan 30, 2:37 pm, David Trowbridge wrote: > Do you have the "p4" binary somewhere in the path on your server? > > -David > > On 1/30/09, 13Strider wrote: > > > > > I have everything setup an

Re: View Diff

Do you have the "p4" binary somewhere in the path on your server? -David On 1/30/09, 13Strider wrote: > > I have everything setup and working , i use post-review to submit and > it works fine, > when i go to the browser i see my review request, but when click on > view diff i get this error > >