Re: Review Board 1.5 RC 2 is released

2010-10-04 Thread Stephen Gallagher
On Sep 30, 3:50 am, Christian Hammond wrote: > I've tested this thoroughly with Django 1.1.2, and it absolutely works here. > We actually have unit tests for this functionality, ran by nightly builds > using both Django 1.1 and 1.2, so I was surprised to hear that there was a > breakage. > > Wha

Re: Review Board 1.5 RC 2 is released

2010-09-30 Thread Stephen Gallagher
On Sep 30, 3:50 am, Christian Hammond wrote: > Are there any custom modifications at all in your > $sitedir/conf/settings_local.py? This was the problem. Our infrastructure requires the use of a custom authentication mechanism (which requires added values in the INSTALLED_APPS and MIDDLEWARE_CL

Re: Review Board 1.5 RC 2 is released

2010-09-30 Thread Christian Hammond
Spent some time trying to look into these issues... I'm confident it's local to your server. On Mon, Sep 27, 2010 at 4:36 AM, Stephen Gallagher wrote: > On 09/24/2010 04:19 PM, Christian Hammond wrote: > > > Hi Stephen, > > > > > > I suspect that 1829 is due to an installation or packaging prob

Re: Review Board 1.5 RC 2 is released

2010-09-27 Thread Daryl
Hi, One more minor thing I noticed with shortcuts. After adding a new comment, the '[' and ']' shortcuts don't find it. They find comments that were already present. Refreshing the page fixes it where '[' and ']' do see it. Thanks, Daryl On Sep 27, 9:55 am, Daryl wrote: > (thread getting com

Re: Review Board 1.5 RC 2 is released

2010-09-27 Thread Daryl
(thread getting complicated, didn't mean to hijack). Thanks for quick reply Christian. I'll submit the 2 issues. One more thing I just noticed. I did a quick search of the issues mailing list and didn't see it. 1. Open file diff 2. Hide whitespace changes. 3rd file in to file list is just whi

Re: Review Board 1.5 RC 2 is released

2010-09-27 Thread Stephen Gallagher
On 09/24/2010 04:19 PM, Christian Hammond wrote: > > Hi Stephen, > > > > I suspect that 1829 is due to an installation or packaging problem > > with Djblets. I can't reproduce this on our install, which was > > installed using easy_install. The log.html template is there, and has > > been for a wh

Re: Review Board 1.5 RC 2 is released

2010-09-26 Thread Christian Hammond
On Sun, Sep 26, 2010 at 7:23 PM, Daryl wrote: > Hey guys, > > Now I'm trying to use screenshots (for the first time). First it > wouldn't take them, but I didn't have PIL installed. Some > observations - > > 1. Created a (None - Graphics Only) review. Attached a JPG > screenshot. I was able t

Re: Review Board 1.5 RC 2 is released

2010-09-26 Thread Daryl
Hey guys, Now I'm trying to use screenshots (for the first time). First it wouldn't take them, but I didn't have PIL installed. Some observations - 1. Created a (None - Graphics Only) review. Attached a JPG screenshot. I was able to click the picture and add a comment. But when I clicked the

Re: Review Board 1.5 RC 2 is released

2010-09-25 Thread Christian Hammond
Yeahhh I keep meaning to deal with that... I wanted to do more testing on it with existing setups so nothing broke. I think it's safe, but let's try for 1.6 :) Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com O

Re: Review Board 1.5 RC 2 is released

2010-09-25 Thread David Trowbridge
There's always http://reviews.reviewboard.org/r/686/ , which is almost 2 years old :) -David On Sat, Sep 25, 2010 at 8:56 PM, Christian Hammond wrote: > Thanks Daryl, > > I'm glad it's not a release-stopping bug, but we should do some validation > to make sure the path entered is absolute. > >

Re: Review Board 1.5 RC 2 is released

2010-09-25 Thread Christian Hammond
Thanks Daryl, I'm glad it's not a release-stopping bug, but we should do some validation to make sure the path entered is absolute. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Sep 25, 2010 at 9:51

Re: Review Board 1.5 RC 2 is released

2010-09-25 Thread Daryl
Hi, I've upgraded to 1.5 RC2 also without issue. I then decided to setup pylucene, which I had not done before. This is on RHEL 5.1 with python 2.4. The release notes mentioned compatibility with pylucene 3.x. My first attempt was with the latest version 3.0.2-1. I was able to build and insta

Re: Review Board 1.5 RC 2 is released

2010-09-24 Thread Christian Hammond
Hi Stephen, I suspect that 1829 is due to an installation or packaging problem with Djblets. I can't reproduce this on our install, which was installed using easy_install. The log.html template is there, and has been for a while. 1828 is a definite bug, which I'll fix for the release. 1827 again

Re: Review Board 1.5 RC 2 is released

2010-09-24 Thread Stephen Gallagher
Great work getting 1.5 RC 2 out. I upgraded the FedoraHosted deployment today, but I've stumbled across three new bugs. (I strongly suspect that two of them were present in RC1 as well, but I didn't notice them then) 1829 - Viewing the server log from the admin interface fails 1828 - 500 Error tr

Review Board 1.5 RC 2 is released

2010-09-19 Thread Christian Hammond
Hi everyone, Review Board 1.5 RC 2 is out the door. Details on the release, as well as further prodding about the release party, are up at: http://www.reviewboard.org/news/2010/09/19/review-board-15-rc-2-released/ On an unrelated note, some of you have asked how you can help with our expenses w