used in a
multi-collector environment? If so, is the value expected to be a
comma-separated list of collectors?
- Robert Nettleton
On June 7, 2016, 8:12 a.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e-mail.
> On June 7, 2016, 1:15 p.m., Robert Nettleton wrote:
> > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java,
> > line 38
> > <https://reviews.apache.org/r/48338/diff/1/?file=1408745#file1408745line38>
> >
> >
without my patch applied, so these failures are not caused by
this current patch.
Thanks,
Robert Nettleton
rified that these failures
occur on trunk without my patch applied, so these failures are not caused by
this current patch.
3. Ran "mvn clean test" with this morning's latest trunk src, with this patch
applied, and the full suite passed:
"Results :
Tests run: 4477, Failures: 0, Errors: 0, Skipped: 34"
Thanks,
Robert Nettleton
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48348/#review137013
---
Ship it!
Ship It!
- Robert Nettleton
On June 10, 2016, 3:08
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48555/#review137014
---
Ship it!
Ship It!
- Robert Nettleton
On June 10, 2016, 2:51
onitor the
state of the LogicalRequest as the deployment progresses.
I would recommend asking Sumit to review this as well, since it's not clear
to me that this is the approach that should be taken.
- Robert Nettleton
On June 11, 2016, 6:43 a.m., Daniel Gergely
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48650/#review137329
---
Ship it!
Ship It!
- Robert Nettleton
On June 13, 2016, 4:28
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48691/#review137520
---
Ship it!
Ship It!
- Robert Nettleton
On June 14, 2016, 2:51
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48732/#review137745
---
Ship it!
- Robert Nettleton
On June 15, 2016, 3:04 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48727/#review137746
---
Ship it!
Ship It!
- Robert Nettleton
On June 15, 2016, 12
> On June 13, 2016, 4:51 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java,
> > line 191
> > <https://reviews.apache.org/r/48266/diff/5/?file=1415529#file1415529line191>
> >
> > I'
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48173/#review135954
---
Ship it!
Ship It!
- Robert Nettleton
On June 2, 2016, 4:17
are we sure that there are no properties in
an HDP cluster that may consider trailing spaces to be a valid property value?
It's probably fine, but just wanted to make sure we double-check this.
Thanks.
- Robert Nettleton
On June 2, 2016, 4:38 p.m., Dmytro Sen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47886/#review134967
---
Ship it!
Ship It!
- Robert Nettleton
On May 26, 2016, 1:11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47586/#review135836
---
Ship it!
Ship It!
- Robert Nettleton
On June 1, 2016, 6:20
> On June 16, 2016, 2:56 p.m., Robert Nettleton wrote:
> > I believe this patch might have some issues that need clarification prior
> > to merging this.
> >
> > The review and bug don't specify why this change is necessary, so I'm a
> > little confused
will have to uptake this new
configuration option before the UI integration will work properly with HTTPS. I
can implement that during my next set of LogSearch Integration changes.
Thanks.
- Robert Nettleton
On June 21, 2016, 6:03 p.m., Miklos Gergely wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49033/#review138912
---
Ship it!
Ship It!
- Robert Nettleton
On June 21, 2016, 7:14
> On June 21, 2016, 7:28 p.m., Robert Nettleton wrote:
> > This looks fine to me.
> >
> > One question: Have you tested out the Ambari UI integration once HTTPS is
> > enabled? I would expect this to fail, since this configuration option did
> > no
somebody on the Ambari UI team review this
change as well.
- Robert Nettleton
On June 20, 2016, 2:35 p.m., Miklos Gergely wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
estigation, and some clarification
from the Metrics team.
- Robert Nettleton
On June 15, 2016, 1:35 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49268/#review139587
---
Ship it!
Ship It!
- Robert Nettleton
On June 27, 2016, 3:39
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45030/#review124190
---
Ship it!
Ship It!
- Robert Nettleton
On March 18, 2016, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45390/#review125719
---
Ship it!
Ship It!
- Robert Nettleton
On March 28, 2016, 5
w request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin
> Jetly, Jayush Luniya, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and
> Yusaku Sako.
>
>
> Bugs: AMBARI-15807
> https://issues.apache.org/jira/browse/AMBARI-15807
>
>
> Repository: ambar
ply, visit:
> https://reviews.apache.org/r/45979/
> ---
>
> (Updated April 11, 2016, 4:27 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin
> Jetly, Jayush Luniya, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46032/#review128128
---
Ship it!
Ship It!
- Robert Nettleton
On April 11, 2016, 2
t; This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45979/
> ---
>
> (Updated April 11, 2016, 4:27 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45978/#review128139
---
Ship it!
Ship It!
- Robert Nettleton
On April 9, 2016, 11
s://issues.apache.org/jira/browse/AMBARI-15807
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Logsearch support was splitted into 3 different commits:
> https://github.com/apache/ambari/tree/branch-dev-logsearch
> - integrate logsearch module
&
h support was splitted into 3 different commits:
> https://github.com/apache/ambari/tree/branch-dev-logsearch
> - integrate logsearch module
> - ambari server REST implementation for logsearch
> - stack definition
>
> This one is the REST implementation. (by Robert Nettlet
s, I'm happy to
resolve that in a future patch, but I think using the constant is sufficient
for now.
Thanks.
- Robert Nettleton
On April 11, 2016, 4:27 p.m., Oliver Szabo wrote:
>
> ---
> This is an automatically gener
-
On April 8, 2016, 6 p.m., Oliver Szabo wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45892/
> -------
>
> (Updated April 8, 2016, 6 p.m.)
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44725/#review124874
---
Ship it!
Ship It!
- Robert Nettleton
On March 22, 2016, 6
a unit test to the
BlueprintConfigurationProcessorTest, just to make sure this issue doesn't
regress in the future.
Thanks.
- Robert Nettleton
On March 31, 2016, 4:36 p.m., Andrew Onischuk wrote:
>
> ---
> This is a
seem to be
installed/started as expected.
2. Currently running ambari-server's "mvn clean test" suite, and will update
with results once that is completed.
Thanks,
Robert Nettleton
-----
On April 13, 2016, 2:28 p.m., Robert Nettleton wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46147/
>
[INFO] Final Memory: 38M/720M
[INFO] ————————
"
Thanks,
Robert Nettleton
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/#review130409
---
Ship it!
Ship It!
- Robert Nettleton
On April 22, 2016, 6
is too generic for me, can this be more specified ? (like
> > SomethingUtils.java, i know its in a specified package, but maybe it would
> > be easier to find with a less generic name)
>
> Robert Nettleton wrote:
> I'm not sure I agree that the name is too generic, si
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46639/#review130435
-------
On April 25, 2016, 3:28 p.m., Robert Nettleton wrote:
>
> ---
> This is
0, Skipped: 32
Thanks,
Robert Nettleton
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46544/#review130117
---
Ship it!
Ship It!
- Robert Nettleton
On April 21, 2016, 10
ce.
2. Deployed a 3-node vagrant cluster successfully without LogSearch enabled.
Verified that no LogSearch-related logging or errors appear in
ambari-server.log or ambari-server.out.
3. Ran the ambari-server "mvn clean test" suite with my changes applied, with
the suite passing completely.
Thanks,
Robert Nettleton
I think this should be "ignore_failures".
This seems like something the python unit tests should catch as well.
- Robert Nettleton
On April 28, 2016, 4:54 p.m., Oliver Szabo wrote:
>
> ---
> This i
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46702/#review130632
---
Ship it!
Ship It!
- Robert Nettleton
On April 26, 2016, 3
> On May 23, 2016, 2:59 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java,
> > line 2395
> > <https://reviews.apache.org/r/47726/diff/1/?file=1391619#file1391619line2395>
>
comment above, it's my opinion that passwords should be
excluded. The Blueprints processor already has checks to fail a deployment
attempt if a password is missing, and already has the support for the "default
password" feature in non-production environments.
- Robert Nettleton
On May 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47226/#review132657
---
Ship it!
Ship It!
- Robert Nettleton
On May 11, 2016, 9:32
java
(line 56)
<https://reviews.apache.org/r/47296/#comment197174>
Wouldn't it be simpler to just override the toString() methods for this
enumerated type?
- Robert Nettleton
On May 12, 2016, 11:31 a.m., Dharmesh Makwana wrote:
>
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47452/#review133578
---
Ship it!
Ship It!
- Robert Nettleton
On May 17, 2016, 1:29
> On May 12, 2016, 1:35 p.m., Robert Nettleton wrote:
> > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VList.java,
> > line 46
> > <https://reviews.apache.org/r/47296/diff/2/?file=1381276#file1381276line46>
> >
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47296/#review133099
---
Ship it!
Ship It!
- Robert Nettleton
On May 13, 2016, 6:48
> On May 3, 2016, 8:28 p.m., Sumit Mohanty wrote:
> > Ship It!
I've just pushed this patch to trunk.
Could the submitter please close out this ReviewBoard as "Submitted"?
Thanks.
- Robert
---
This is an automatically generated
r something like that. The name proposed in this patch will probably be a
little confusing for users, since "ambari_user" might appear to be a username
for logging into Ambari, when in fact this username is specifically for the
LogSearch server.
- Robert Nettleton
On May 5, 2016, 3:4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46999/#review131872
---
Ship it!
Ship It!
- Robert Nettleton
On May 5, 2016, 12:49
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46973/#review131696
---
Ship it!
Ship It!
- Robert Nettleton
On May 4, 2016, 3:11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46981/#review131698
---
Ship it!
Ship It!
- Robert Nettleton
On May 4, 2016, 3:30
> On May 5, 2016, 5:30 p.m., Robert Nettleton wrote:
> > The patch looks fine to me, just needs a minor fix listed below.
> >
> > Regarding the open question, I don't think there is much that can be done
> > in the short term on this one. The Ambari Integration co
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46999/#review132427
---
Ship it!
Ship It!
- Robert Nettleton
On May 10, 2016, 7:34
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47163/#review132425
---
Ship it!
Ship It!
- Robert Nettleton
On May 10, 2016, 7:58
loys
properly as well.
2. Ran the ambari-server "mvn clean test" suite, which passed completely with
this patch applied.
Thanks,
Robert Nettleton
. Deployed a single-node cluster with LogSearch included, verified that the
cluster deployed successfully, and that the REST APIs are functioning as
expected with respect to LogSearch.
3. I'm starting a local "mvn clean test" run now, and will post the results
when available.
Thanks,
Robert Nettleton
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/46387/#review129522
-------
On April 19, 2016, 1:27 p.m., Robert Nettleton wrote:
>
> ---
> This is an au
expected with respect to LogSearch.
3. I'm starting a local "mvn clean test" run now, and will post the results
when available.
Thanks,
Robert Nettleton
an expected failure on trunk, and is not caused by this current
patch.
Thanks,
Robert Nettleton
tay, perhaps in some modified form.
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
<https://reviews.apache.org/r/45507/#comment193051>
As above, I'd recommend re-introducing this test once the PasswordFilter
has been r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46317/#review129324
---
Ship it!
Ship It!
- Robert Nettleton
On April 18, 2016, 10
I'm not certain that the tests using the public property should be
modified. I'd recommend adding new unit tests to verify that the internal
property being added here is handled properly.
- Robert Nettleton
On April 18, 2016, 1:07 p.m.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46198/#review128886
---
Ship it!
Ship It!
- Robert Nettleton
On April 14, 2016, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46196/#review128894
---
Ship it!
Ship It!
- Robert Nettleton
On April 14, 2016, 11
> On April 18, 2016, 1:39 p.m., Robert Nettleton wrote:
> > Could we get some more background context as to why this change is
> > necessary? I've checked the associated Apache JIRA, and there isn't much
> > information there.
> >
> > In particular, can
rvices/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
(line 21)
<https://reviews.apache.org/r/47119/#comment196466>
Should this property ever be configured by a user, or should this value
always be "history"?
- Robert Nettleton
On May 9, 2016, 2 p.
> On May 9, 2016, 2:42 p.m., Robert Nettleton wrote:
> > Overal the patch looks fine to me, just with a few minor issues below that
> > need clarification.
> >
> > One additional question: How is the filter itself configured to a specific
> > log level?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50656/#review144335
---
Ship it!
Ship It!
- Robert Nettleton
On Aug. 1, 2016, 12:22
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50988/#review145519
---
Ship it!
Ship It!
- Robert Nettleton
On Aug. 11, 2016, 3:41
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50753/#review144618
---
Ship it!
Ship It!
- Robert Nettleton
On Aug. 3, 2016, 2:47
st be a separate breakage in trunk, unrelated to this change.
Thanks,
Robert Nettleton
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50241/#review142957
---
Ship it!
Ship It!
- Robert Nettleton
On July 20, 2016, 4:13
ari-server "mvn clean test" suite on trunk with this patch
applied, and the suite passes completely.
Thanks,
Robert Nettleton
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49972/#review142064
---
Ship it!
Ship It!
- Robert Nettleton
On July 12, 2016, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50822/#review144926
---
Ship it!
Ship It!
- Robert Nettleton
On Aug. 4, 2016, 11:04
e properties that are configured incorrectly.
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
(line 234)
<https://reviews.apache.org/r/50870/#comment211297>
Same as my comment above, regarding adding the property names here for
simpler debugging in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50865/#review144980
---
Ship it!
Ship It!
- Robert Nettleton
On Aug. 5, 2016, 8:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50577/#review143979
---
Ship it!
Ship It!
- Robert Nettleton
On July 28, 2016, 6:09
is not included in the cluster.
Thanks,
Robert Nettleton
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49505/#review140344
---
Ship it!
Ship It!
- Robert Nettleton
On July 1, 2016, 11:20
rly,
and that the Ambari REST "host_components" resource returns properly when
LogSearch is not included in the cluster.
Thanks,
Robert Nettleton
151
> > <https://reviews.apache.org/r/49474/diff/1/?file=1434487#file1434487line149>
> >
> > Maybe only enqueue requests if the same request isn't on the queue.
I agree with your suggestion, but would like to address this issue in a
separate patch.
I've filed the following J
the review with the manual testing you've done with this
patch applied? We'd probably need to make sure that the Blueprint cluster
deployment, and a Blueprint export, both function properly with this change
applied.
Thanks.
- Robert Nettleton
On Aug. 12, 2016, 11:48 p.m., Amruta Borkar wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56224/#review164012
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 2, 2017, 1 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56179/#review164011
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 2, 2017, 4:23
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56274/#review164145
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 3, 2017, 4:10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56123/#review163658
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 31, 2017, 1:39
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56114/#review163659
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 31, 2017, 9:19
views.apache.org/r/56418/
> ---
>
> (Updated Feb. 8, 2017, 12:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Robert
> Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19909
> https://issues.apache.org/jira/browse/AMBARI-19909
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56377/#review164570
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 7, 2017, 4:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56329/#review164380
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 6, 2017, 6:21
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56274/#review164354
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 6, 2017, 11:35
1 - 100 of 353 matches
Mail list logo
