---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55107/#review160593
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 5, 2017, 3:02
/upgrade/SchemaUpgradeUtil.java
(line 43)
<https://reviews.apache.org/r/55249/#comment232141>
Minor problem:
"some.varibale" should be spelled "some.variable"
I'm not opening on issue on this, since this could be fixed in a subsequent
patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55341/#review160996
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 9, 2017, 3:21
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55379/#review161087
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 10, 2017, 1:09
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55361/#review161088
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 9, 2017, 11:58
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55430/#review161254
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 11, 2017, 4:01
t;true" upon the first difference
encountered?
It appears as if the full set of collection items is checked, even if an
item early in the collection differs.
Is this intended?
- Robert Nettleton
On Jan. 11, 2017, 4:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55417/#review161379
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 11, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55433/#review161380
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 12, 2017, 3:27
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55429/#review161427
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 12, 2017, 7:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55485/#review161545
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 13, 2017, 9:51
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55493/#review161546
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 13, 2017, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55493/#review161547
---
Ship it!
- Robert Nettleton
On Jan. 13, 2017, 10:36 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55492/#review161784
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 13, 2017, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55622/#review162121
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 17, 2017, 2:44
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55668/#review162130
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 18, 2017, 9:57
ned as constants somewhere, since they
seem to be used in multiple filter implementations.
- Robert Nettleton
On Jan. 18, 2017, 1:14 p.m., Oliver Szabo wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55643/#review162192
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 17, 2017, 9:30
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55729/#review162345
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 19, 2017, 8:44
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55763/#review162419
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 20, 2017, 1:22
add Rob Levas to this review?
Thanks.
- Robert Nettleton
On Jan. 20, 2017, 10:42 a.m., Miklos Gergely wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55784/#review162501
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 20, 2017, 8:56
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55821/#review162668
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 22, 2017, 6:57
82, Failures: 0, Errors: 8, Skipped: 38
"
Note: These same unit tests are failing on trunk without this patch applied,
so it appears that this current patch does not cause these failures.
Thanks,
Robert Nettleton
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55935/#review163133
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 25, 2017, 8:58
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55986/#review163266
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 26, 2017, 5:48
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55981/#review163276
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 27, 2017, 3:24
> On Jan. 26, 2017, 4:25 p.m., Robert Nettleton wrote:
> > Ship It!
>
> Amruta Borkar wrote:
> Hello Robert,
> Could you help me push this to trunk?
> Thank you.
Hi Amruta,
Sure, I'll try to push this this mornin
> On Jan. 26, 2017, 4:25 p.m., Robert Nettleton wrote:
> > Ship It!
>
> Amruta Borkar wrote:
> Hello Robert,
> Could you help me push this to trunk?
> Thank you.
>
> Robert Nettleton wrote:
> Hi Amruta,
>
> S
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56123/#review163658
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 31, 2017, 1:39
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56114/#review163659
---
Ship it!
Ship It!
- Robert Nettleton
On Jan. 31, 2017, 9:19
I'm just trying to see if this can
be more flexible. If there's no benefit to abstracting out the operation, then
this code should stay as-is.
- Robert Nettleton
On Feb. 1, 2017, 5:16 p.m., Oliver Szabo wrote:
>
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56179/#review164011
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 2, 2017, 4:23
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56224/#review164012
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 2, 2017, 1 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56274/#review164145
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 3, 2017, 4:10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56274/#review164354
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 6, 2017, 11:35
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56329/#review164380
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 6, 2017, 6:21
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56179/#review164416
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 6, 2017, 8:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56377/#review164570
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 7, 2017, 4:12
://reviews.apache.org/r/56418/
> ---
>
> (Updated Feb. 8, 2017, 12:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Robert
> Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19909
> https://issues.apache.org/jira/browse/AMBARI-19909
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56656/#review165519
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 14, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165584
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 14, 2017, 7:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56418/#review165585
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 9, 2017, 11:14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56708/#review165707
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 15, 2017, 2:44
point.
Thanks.
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py (line
1032)
<https://reviews.apache.org/r/56706/#comment237570>
Should the number of shards be hard-coded here?
- Robert Nettleton
On Feb. 15, 2017, 1:09 p.m., Miklos Gergely
look as well to confirm.
- Robert Nettleton
On Feb. 14, 2017, 12:37 a.m., Amruta Borkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
> On Feb. 15, 2017, 3:08 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py,
> > line 1032
> > <https://reviews.apache.org/r/56706/diff/1/?file=1634453#file1634453line1032>
> >
> > Should
r simulator.
- Robert Nettleton
On Feb. 16, 2017, 9:54 a.m., Miklos Gergely wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56855/#review166172
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 20, 2017, 1:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56869/#review166173
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 21, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56883/#review166175
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 21, 2017, 1:23
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56997/#review166574
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 23, 2017, 8:49
DEBUG level, and also that the message not
includes the host and component names when DEBUG-level logging is turned on.
2. Currently running the ambari-server unit test suite, and will update the
review with the results.
Thanks,
Robert Nettleton
dated
log message is only available at the DEBUG level, and also that the message not
includes the host and component names when DEBUG-level logging is turned on.
2. The ambari-server "mvn clean test" run passed on both the trunk and
branch-2.5 branches with this patch applied.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57056/#review166796
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 25, 2017, 1:06
somebody with more
knowledge of Ranger and Atlas review the stack-level changes as well.
Thanks.
- Robert Nettleton
On Feb. 28, 2017, 6:47 p.m., Oliver Szabo wrote:
>
> ---
> This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57203/#review167284
---
Ship it!
Ship It!
- Robert Nettleton
On March 1, 2017, 3:33
's not clear to me why these would be moved from DEBUG.
- Robert Nettleton
On March 1, 2017, 8:51 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57250/#review167723
---
Ship it!
Ship It!
- Robert Nettleton
On March 2, 2017, 7:31
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57287/#review168033
---
Ship it!
Ship It!
- Robert Nettleton
On March 3, 2017, 9:23
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56930/#review168150
---
Ship it!
Ship It!
- Robert Nettleton
On Feb. 22, 2017, 4:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57383/#review168152
---
Ship it!
Ship It!
- Robert Nettleton
On March 7, 2017, 5:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57468/#review168495
---
Ship it!
Ship It!
- Robert Nettleton
On March 9, 2017, 6:39
873>
Should this feature be enabled by default?
- Robert Nettleton
On March 10, 2017, 11:16 a.m., Oliver Szabo wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
with Swagger and the Swagger APIs.
Thanks.
- Robert Nettleton
On March 14, 2017, 11:35 p.m., Jaimin Jetly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
roller/internal/BlueprintConfigurationProcessor.java
Lines 2492 (patched)
<https://reviews.apache.org/r/57672/#comment241483>
It would probably be a good idea to add a unit test to verify that this
property updater is registered as expected.
- Robert Nettleton
On March 16, 2017, 12:21 a.m., Madhuvanth
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57803/#review169569
---
Ship it!
Ship It!
- Robert Nettleton
On March 21, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57920/#review170206
---
Ship it!
Ship It!
- Robert Nettleton
On March 24, 2017, 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57921/#review170207
---
Ship it!
Ship It!
- Robert Nettleton
On March 24, 2017, 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/#review170446
---
Ship it!
Ship It!
- Robert Nettleton
On March 29, 2017, 5
I think it might be better to remove these assertions, if they are no
longer needed.
- Robert Nettleton
On March 29, 2017, 11:57 p.m., Madhuvanthi Radhakrishnan wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58045/#review170630
---
Ship it!
Ship It!
- Robert Nettleton
On March 29, 2017, 8
s mean that that LogSearchConfig interface might need to have a
shutdown hook method to handle things like resource cleanup?
- Robert Nettleton
On March 30, 2017, 11:31 a.m., Miklos Gergely wrote:
>
> ---
> This is an automatica
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58105/#review170716
---
Ship it!
Ship It!
- Robert Nettleton
On March 31, 2017, 11
pens up the
possibility of using this config object within a "try-with-resources" block,
which would simplify the cleanup, but again this is not required for the patch,
just a suggestion.
- Robert Nettleton
On March 31, 2017, 10:15 a.m.,
at the
exported Blueprint could be used more portably.
- Robert Nettleton
On April 3, 2017, 4:42 p.m., Amruta Borkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
> On April 3, 2017, 6:11 p.m., Robert Nettleton wrote:
> > Thanks for providing this patch, but I don't really think that this is the
> > correct way to solve this problem.
> >
> > The Blueprint export shouldn't really modify any configuration in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171035
---
Ship it!
- Robert Nettleton
On April 3, 2017, 10:42 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58322/#review171612
---
Ship it!
Ship It!
- Robert Nettleton
On April 10, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58387/#review171734
---
Ship it!
Ship It!
- Robert Nettleton
On April 12, 2017, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58389/#review171782
---
Ship it!
Ship It!
- Robert Nettleton
On April 12, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58401/#review171796
---
Ship it!
Ship It!
- Robert Nettleton
On April 12, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58417/#review171930
---
Ship it!
Ship It!
- Robert Nettleton
On April 13, 2017, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58444/#review172522
---
Ship it!
Ship It!
- Robert Nettleton
On April 14, 2017, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58562/#review172529
---
Ship it!
Ship It!
- Robert Nettleton
On April 20, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58579/#review172530
---
Ship it!
Ship It!
- Robert Nettleton
On April 20, 2017, 4
with this patch applied.
Thanks,
Robert Nettleton
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58578/#review172785
---
Ship it!
Ship It!
- Robert Nettleton
On April 20, 2017, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58679/#review172839
---
Ship it!
Ship It!
- Robert Nettleton
On April 24, 2017, 7
at the new
"clusters" query parameter is set as expected. Also verified that the LogSearch
Integration is working as expected with this change applied.
2. Ran the ambari-server unit tests (all passing).
Thanks,
Robert Nettleton
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58699/#review172942
---
Ship it!
Ship It!
- Robert Nettleton
On April 25, 2017, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58296/#review172943
---
Ship it!
Ship It!
- Robert Nettleton
On April 10, 2017, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58726/#review173046
---
Ship it!
Ship It!
- Robert Nettleton
On April 26, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58737/#review173047
---
Ship it!
Ship It!
- Robert Nettleton
On April 26, 2017, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/#review173495
---
Ship it!
Ship It!
- Robert Nettleton
On April 28, 2017, 4
bari-web/app/controllers/wizard/step8_controller.js
Lines 1925 (patched)
<https://reviews.apache.org/r/58864/#comment246611>
Similar to my last point, the default provision_action is always
"INSTALL_AND_START", so this might not need to be set in the Blueprint.
- Robert Nettleton
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59051/#review174182
---
Ship it!
Ship It!
- Robert Nettleton
On May 8, 2017, 3:40
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58990/#review174360
---
Ship it!
Ship It!
- Robert Nettleton
On May 9, 2017, 9:38
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59175/#review174716
---
Ship it!
Ship It!
- Robert Nettleton
On May 11, 2017, 1:30
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59228/#review174793
---
Ship it!
Ship It!
- Robert Nettleton
On May 12, 2017, 1:58
201 - 300 of 400 matches
Mail list logo