Re: Review Request 55107: LogSearch upgrade support 2.4 -> 2.5

2017-01-05 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55107/#review160593 --- Ship it! Ship It! - Robert Nettleton On Jan. 5, 2017, 3:02

Re: Review Request 55249: Infra Solr Upgrade support 2.4 -> 2.5

2017-01-09 Thread Robert Nettleton
/upgrade/SchemaUpgradeUtil.java (line 43) <https://reviews.apache.org/r/55249/#comment232141> Minor problem: "some.varibale" should be spelled "some.variable" I'm not opening on issue on this, since this could be fixed in a subsequent patch.

Re: Review Request 55341: Add secure znode command for ambari infra solr client

2017-01-09 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55341/#review160996 --- Ship it! Ship It! - Robert Nettleton On Jan. 9, 2017, 3:21

Re: Review Request 55379: Log Feeder should be restarted after configuration change

2017-01-10 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55379/#review161087 --- Ship it! Ship It! - Robert Nettleton On Jan. 10, 2017, 1:09

Re: Review Request 55361: LogSearch upgrade support 2.4 -> 2.5 addendum - add log4j properties

2017-01-10 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55361/#review161088 --- Ship it! Ship It! - Robert Nettleton On Jan. 9, 2017, 11:58

Re: Review Request 55430: Log Search: Calendar widget for setting the time range is confusing

2017-01-11 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55430/#review161254 --- Ship it! Ship It! - Robert Nettleton On Jan. 11, 2017, 4:01

Re: Review Request 55429: Logsearch should run zk/solr operations internally (instead of in ambari-agent code)

2017-01-11 Thread Robert Nettleton
t;true" upon the first difference encountered? It appears as if the full set of collection items is checked, even if an item early in the collection differs. Is this intended? - Robert Nettleton On Jan. 11, 2017, 4:16 p.m

Re: Review Request 55417: Log Search: default search ranges don't look right

2017-01-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55417/#review161379 --- Ship it! Ship It! - Robert Nettleton On Jan. 11, 2017, 11

Re: Review Request 55433: Add Downgrade request validation to avoid accidental double-upgrades

2017-01-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55433/#review161380 --- Ship it! Ship It! - Robert Nettleton On Jan. 12, 2017, 3:27

Re: Review Request 55429: Run ZK operations in logsearch internally and enable ACL security for LogSearch/Solr

2017-01-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55429/#review161427 --- Ship it! Ship It! - Robert Nettleton On Jan. 12, 2017, 7:55

Re: Review Request 55485: Log Search Troubleshooting tab should allow to multi select services

2017-01-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55485/#review161545 --- Ship it! Ship It! - Robert Nettleton On Jan. 13, 2017, 9:51

Re: Review Request 55493: Log Search Add 'last 24 hours' to the time picker buttons

2017-01-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55493/#review161546 --- Ship it! Ship It! - Robert Nettleton On Jan. 13, 2017, 10

Re: Review Request 55493: Log Search Add 'last 24 hours' to the time picker buttons

2017-01-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55493/#review161547 --- Ship it! - Robert Nettleton On Jan. 13, 2017, 10:36 a.m

Re: Review Request 55492: Log Feeder should store keystore / truststore passwords in files

2017-01-16 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55492/#review161784 --- Ship it! Ship It! - Robert Nettleton On Jan. 13, 2017, 10

Re: Review Request 55622: Log Feeder should be able to handle metrics with https

2017-01-18 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55622/#review162121 --- Ship it! Ship It! - Robert Nettleton On Jan. 17, 2017, 2:44

Re: Review Request 55668: Log Search support livy2 server logs

2017-01-18 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55668/#review162130 --- Ship it! Ship It! - Robert Nettleton On Jan. 18, 2017, 9:57

Re: Review Request 55429: Run ZK operations in logsearch internally and enable ACL security for LogSearch/Solr

2017-01-18 Thread Robert Nettleton
ned as constants somewhere, since they seem to be used in multiple filter implementations. - Robert Nettleton On Jan. 18, 2017, 1:14 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 55643: Blueprint installation should accept quick link profile

2017-01-18 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55643/#review162192 --- Ship it! Ship It! - Robert Nettleton On Jan. 17, 2017, 9:30

Re: Review Request 55729: Log Search: add snapshot feature to Tours

2017-01-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55729/#review162345 --- Ship it! Ship It! - Robert Nettleton On Jan. 19, 2017, 8:44

Re: Review Request 55763: Remove hard coded smartsense Log Feeder config from Log Search stack

2017-01-20 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55763/#review162419 --- Ship it! Ship It! - Robert Nettleton On Jan. 20, 2017, 1:22

Re: Review Request 55755: Log Search should use Credential Store API to store keystore/truststore passwords

2017-01-20 Thread Robert Nettleton
add Rob Levas to this review? Thanks. - Robert Nettleton On Jan. 20, 2017, 10:42 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 55784: Log Search should handle new services

2017-01-20 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55784/#review162501 --- Ship it! Ship It! - Robert Nettleton On Jan. 20, 2017, 8:56

Re: Review Request 55821: Log Search: support credential store api (part 1)

2017-01-23 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55821/#review162668 --- Ship it! Ship It! - Robert Nettleton On Jan. 22, 2017, 6:57

Review Request 55885: Add configuration option to Ambari LogSearch Integration data cache

2017-01-24 Thread Robert Nettleton
82, Failures: 0, Errors: 8, Skipped: 38 " Note: These same unit tests are failing on trunk without this patch applied, so it appears that this current patch does not cause these failures. Thanks, Robert Nettleton

Re: Review Request 55935: When hiveserver2 LDAP authentication is enabled hive.server2.authentication.ldap.url property gets exported with hardcoded hostname

2017-01-26 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55935/#review163133 --- Ship it! Ship It! - Robert Nettleton On Jan. 25, 2017, 8:58

Re: Review Request 55986: Extend security.json of Infra Solr as a configuration property in Ambari

2017-01-27 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55986/#review163266 --- Ship it! Ship It! - Robert Nettleton On Jan. 26, 2017, 5:48

Re: Review Request 55981: Log Search portal not working if only solr needs SSL connection

2017-01-27 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55981/#review163276 --- Ship it! Ship It! - Robert Nettleton On Jan. 27, 2017, 3:24

Re: Review Request 55935: When hiveserver2 LDAP authentication is enabled hive.server2.authentication.ldap.url property gets exported with hardcoded hostname

2017-01-27 Thread Robert Nettleton
> On Jan. 26, 2017, 4:25 p.m., Robert Nettleton wrote: > > Ship It! > > Amruta Borkar wrote: > Hello Robert, > Could you help me push this to trunk? > Thank you. Hi Amruta, Sure, I'll try to push this this mornin

Re: Review Request 55935: When hiveserver2 LDAP authentication is enabled hive.server2.authentication.ldap.url property gets exported with hardcoded hostname

2017-01-27 Thread Robert Nettleton
> On Jan. 26, 2017, 4:25 p.m., Robert Nettleton wrote: > > Ship It! > > Amruta Borkar wrote: > Hello Robert, > Could you help me push this to trunk? > Thank you. > > Robert Nettleton wrote: > Hi Amruta, > > S

Re: Review Request 56123: Log Search portal date range picker - fix minor issues

2017-01-31 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56123/#review163658 --- Ship it! Ship It! - Robert Nettleton On Jan. 31, 2017, 1:39

Re: Review Request 56114: Log Search "Preview" should have a "Select for Copy" button

2017-01-31 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56114/#review163659 --- Ship it! Ship It! - Robert Nettleton On Jan. 31, 2017, 9:19

Re: Review Request 56179: Add infra-solr-plugin for authorization (with Kerberos)

2017-02-01 Thread Robert Nettleton
I'm just trying to see if this can be more flexible. If there's no benefit to abstracting out the operation, then this code should stay as-is. - Robert Nettleton On Feb. 1, 2017, 5:16 p.m., Oliver Szabo wrote: > > --- >

Re: Review Request 56179: Add infra-solr-plugin for authorization (with Kerberos)

2017-02-02 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56179/#review164011 --- Ship it! Ship It! - Robert Nettleton On Feb. 2, 2017, 4:23

Re: Review Request 56224: Improve Log Feeder simulation to help scale testing

2017-02-02 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56224/#review164012 --- Ship it! Ship It! - Robert Nettleton On Feb. 2, 2017, 1 p.m

Re: Review Request 56274: Fix Log Search User Config bugs

2017-02-03 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56274/#review164145 --- Ship it! Ship It! - Robert Nettleton On Feb. 3, 2017, 4:10

Re: Review Request 56274: Fix Log Search User Config bugs

2017-02-06 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56274/#review164354 --- Ship it! Ship It! - Robert Nettleton On Feb. 6, 2017, 11:35

Re: Review Request 56329: Log Search Portal time zone selection bug

2017-02-06 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56329/#review164380 --- Ship it! Ship It! - Robert Nettleton On Feb. 6, 2017, 6:21

Re: Review Request 56179: Add infra-solr-plugin for authorization (with Kerberos)

2017-02-06 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56179/#review164416 --- Ship it! Ship It! - Robert Nettleton On Feb. 6, 2017, 8:32

Re: Review Request 56377: Log Search should use Credential Store API to store keystore/truststore passwords - ambari side

2017-02-07 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56377/#review164570 --- Ship it! Ship It! - Robert Nettleton On Feb. 7, 2017, 4:12

Re: Review Request 56418: Export Blueprints does not contain the settings object and hence the credential store values

2017-02-08 Thread Robert Nettleton
://reviews.apache.org/r/56418/ > --- > > (Updated Feb. 8, 2017, 12:52 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Robert > Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-19909 > https://issues.apache.org/jira/browse/AMBARI-19909 >

Re: Review Request 56656: Log Search should not hide external Solr button even if it's mandatory

2017-02-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56656/#review165519 --- Ship it! Ship It! - Robert Nettleton On Feb. 14, 2017, 11

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup

2017-02-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56671/#review165584 --- Ship it! Ship It! - Robert Nettleton On Feb. 14, 2017, 7:06

Re: Review Request 56418: Export Blueprints does not contain the settings object and hence the credential store values

2017-02-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56418/#review165585 --- Ship it! Ship It! - Robert Nettleton On Feb. 9, 2017, 11:14

Re: Review Request 56708: Add delete endpoint for logsearch (service + audit logs)

2017-02-15 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56708/#review165707 --- Ship it! Ship It! - Robert Nettleton On Feb. 15, 2017, 2:44

Re: Review Request 56706: Log Search allow installation without portal

2017-02-15 Thread Robert Nettleton
point. Thanks. ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py (line 1032) <https://reviews.apache.org/r/56706/#comment237570> Should the number of shards be hard-coded here? - Robert Nettleton On Feb. 15, 2017, 1:09 p.m., Miklos Gergely

Re: Review Request 56627: Cluster deployment fails if cluster template has fewer host_groups than that in blueprint

2017-02-15 Thread Robert Nettleton
look as well to confirm. - Robert Nettleton On Feb. 14, 2017, 12:37 a.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 56706: Log Search allow installation without portal

2017-02-15 Thread Robert Nettleton
> On Feb. 15, 2017, 3:08 p.m., Robert Nettleton wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py, > > line 1032 > > <https://reviews.apache.org/r/56706/diff/1/?file=1634453#file1634453line1032> > > > > Should

Re: Review Request 56743: LogFeeder Simulator Enhancements for 3000-node cluster testing

2017-02-16 Thread Robert Nettleton
r simulator. - Robert Nettleton On Feb. 16, 2017, 9:54 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 56855: Grafana Dashboard for Log Search

2017-02-21 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56855/#review166172 --- Ship it! Ship It! - Robert Nettleton On Feb. 20, 2017, 1:46

Re: Review Request 56869: Log Search should handle turned off Credential Store too

2017-02-21 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56869/#review166173 --- Ship it! Ship It! - Robert Nettleton On Feb. 21, 2017, 11

Re: Review Request 56883: Log Search: only update schema file for Solr if it has any new fields in the local file

2017-02-21 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56883/#review166175 --- Ship it! Ship It! - Robert Nettleton On Feb. 21, 2017, 1:23

Re: Review Request 56997: Use storm user principal instead of nimbus user principal for ranger audit

2017-02-23 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56997/#review166574 --- Ship it! Ship It! - Robert Nettleton On Feb. 23, 2017, 8:49

Review Request 57053: LogSearch Integration for HostComponent resource errors should be logged at the DEBUG level

2017-02-24 Thread Robert Nettleton
DEBUG level, and also that the message not includes the host and component names when DEBUG-level logging is turned on. 2. Currently running the ambari-server unit test suite, and will update the review with the results. Thanks, Robert Nettleton

Re: Review Request 57053: LogSearch Integration for HostComponent resource errors should be logged at the DEBUG level

2017-02-24 Thread Robert Nettleton
dated log message is only available at the DEBUG level, and also that the message not includes the host and component names when DEBUG-level logging is turned on. 2. The ambari-server "mvn clean test" run passed on both the trunk and branch-2.5 branches with this patch applied.

Re: Review Request 57056: Log Search Portal is not working with HTTPS with it's own created Key Store

2017-02-24 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57056/#review166796 --- Ship it! Ship It! - Robert Nettleton On Feb. 25, 2017, 1:06

Re: Review Request 57155: Increase Ranger/Atlas timeout (check znode)

2017-02-28 Thread Robert Nettleton
somebody with more knowledge of Ranger and Atlas review the stack-level changes as well. Thanks. - Robert Nettleton On Feb. 28, 2017, 6:47 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 57203: Log Search upgrade to 2.5 should handle renamed properties safely

2017-03-01 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57203/#review167284 --- Ship it! Ship It! - Robert Nettleton On March 1, 2017, 3:33

Re: Review Request 57215: Startup Annotation Scanning Takes Too Long

2017-03-01 Thread Robert Nettleton
's not clear to me why these would be moved from DEBUG. - Robert Nettleton On March 1, 2017, 8:51 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 57250: NPE thrown if downscale is performed before all hosts registered with cluster.

2017-03-02 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57250/#review167723 --- Ship it! Ship It! - Robert Nettleton On March 2, 2017, 7:31

Re: Review Request 57287: LogSearch Portal UI Fails on Last Page selection if logs were deleted in the meantime

2017-03-06 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57287/#review168033 --- Ship it! Ship It! - Robert Nettleton On March 3, 2017, 9:23

Re: Review Request 56930: Log Search: add global cluster filter for every query

2017-03-07 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56930/#review168150 --- Ship it! Ship It! - Robert Nettleton On Feb. 22, 2017, 4:06

Re: Review Request 57383: Log Search Upgrade should modify keystore / truststore path if it wasn't used

2017-03-07 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57383/#review168152 --- Ship it! Ship It! - Robert Nettleton On March 7, 2017, 5:12

Re: Review Request 57468: Log Search: Web UI Alert tries to use http protocol even if ssl is enabled

2017-03-09 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57468/#review168495 --- Ship it! Ship It! - Robert Nettleton On March 9, 2017, 6:39

Re: Review Request 57461: Logfeeder: add de-duplication support

2017-03-10 Thread Robert Nettleton
873> Should this feature be enabled by default? - Robert Nettleton On March 10, 2017, 11:16 a.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 57582: Create a prototype of ambari-server swagger integration

2017-03-15 Thread Robert Nettleton
with Swagger and the Swagger APIs. Thanks. - Robert Nettleton On March 14, 2017, 11:35 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 57672: Add a new property to yarn-site.xml yarn.log.server.web-service.url

2017-03-16 Thread Robert Nettleton
roller/internal/BlueprintConfigurationProcessor.java Lines 2492 (patched) <https://reviews.apache.org/r/57672/#comment241483> It would probably be a good idea to add a unit test to verify that this property updater is registered as expected. - Robert Nettleton On March 16, 2017, 12:21 a.m., Madhuvanth

Re: Review Request 57803: Link Log Feeder not working with Kerberos

2017-03-21 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57803/#review169569 --- Ship it! Ship It! - Robert Nettleton On March 21, 2017, 9

Re: Review Request 57920: Rename Log Search Portal module to Log Search Server

2017-03-27 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57920/#review170206 --- Ship it! Ship It! - Robert Nettleton On March 24, 2017, 8

Re: Review Request 57921: Rename ambari-logsearch-solr-client module to ambari-infra-solr-client

2017-03-27 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57921/#review170207 --- Ship it! Ship It! - Robert Nettleton On March 24, 2017, 8

Re: Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster

2017-03-29 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58031/#review170446 --- Ship it! Ship It! - Robert Nettleton On March 29, 2017, 5

Re: Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster

2017-03-30 Thread Robert Nettleton
I think it might be better to remove these assertions, if they are no longer needed. - Robert Nettleton On March 29, 2017, 11:57 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 58045: Cleanup swagger rest api doc for Log Search

2017-03-30 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58045/#review170630 --- Ship it! Ship It! - Robert Nettleton On March 29, 2017, 8

Re: Review Request 57945: Log Search Configuration API

2017-03-30 Thread Robert Nettleton
s mean that that LogSearchConfig interface might need to have a shutdown hook method to handle things like resource cleanup? - Robert Nettleton On March 30, 2017, 11:31 a.m., Miklos Gergely wrote: > > --- > This is an automatica

Re: Review Request 58105: Ambari Log Search Web - fix some build npm errors

2017-03-31 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58105/#review170716 --- Ship it! Ship It! - Robert Nettleton On March 31, 2017, 11

Re: Review Request 57945: Log Search Configuration API

2017-03-31 Thread Robert Nettleton
pens up the possibility of using this config object within a "try-with-resources" block, which would simplify the cleanup, but again this is not required for the patch, just a suggestion. - Robert Nettleton On March 31, 2017, 10:15 a.m.,

Re: Review Request 57563: Kerberos principal creation fails during blueprint install when kdc_hosts is not specified in blueprint

2017-04-03 Thread Robert Nettleton
at the exported Blueprint could be used more portably. - Robert Nettleton On April 3, 2017, 4:42 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 57563: Kerberos principal creation fails during blueprint install when kdc_hosts is not specified in blueprint

2017-04-03 Thread Robert Nettleton
> On April 3, 2017, 6:11 p.m., Robert Nettleton wrote: > > Thanks for providing this patch, but I don't really think that this is the > > correct way to solve this problem. > > > > The Blueprint export shouldn't really modify any configuration in the

Re: Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-04-04 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58122/#review171035 --- Ship it! - Robert Nettleton On April 3, 2017, 10:42 p.m

Re: Review Request 58322: Small fixes in Log Search

2017-04-11 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58322/#review171612 --- Ship it! Ship It! - Robert Nettleton On April 10, 2017, 9

Re: Review Request 58387: Log Search common properties

2017-04-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58387/#review171734 --- Ship it! Ship It! - Robert Nettleton On April 12, 2017, 12

Re: Review Request 58389: Log Search: Add get clusters endpoint for service and audit logs

2017-04-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58389/#review171782 --- Ship it! Ship It! - Robert Nettleton On April 12, 2017, 3

Re: Review Request 58401: Fix misleading solr-client output messages

2017-04-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58401/#review171796 --- Ship it! Ship It! - Robert Nettleton On April 12, 2017, 9

Re: Review Request 58417: Update docker volumes for Ambari logsearch integration test module

2017-04-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58417/#review171930 --- Ship it! Ship It! - Robert Nettleton On April 13, 2017, 12

Re: Review Request 58444: Log Feeder fill cluster name if it is not set

2017-04-20 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58444/#review172522 --- Ship it! Ship It! - Robert Nettleton On April 14, 2017, 1

Re: Review Request 58562: Do not run Log Search service check if there is no portal in the cluster.

2017-04-20 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58562/#review172529 --- Ship it! Ship It! - Robert Nettleton On April 20, 2017, 11

Re: Review Request 58579: Create schema requests to upgrade solr schema (do not change it externally)

2017-04-20 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58579/#review172530 --- Ship it! Ship It! - Robert Nettleton On April 20, 2017, 4

Review Request 58627: LogSearch Integration updated to limit requests to portal for missing components

2017-04-21 Thread Robert Nettleton
with this patch applied. Thanks, Robert Nettleton

Re: Review Request 58578: Log Search REST API calls for configuration should send proper error responses

2017-04-24 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58578/#review172785 --- Ship it! Ship It! - Robert Nettleton On April 20, 2017, 4

Re: Review Request 58679: Fix AmbariSolrCloudCLI package name in solr-client script

2017-04-24 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58679/#review172839 --- Ship it! Ship It! - Robert Nettleton On April 24, 2017, 7

Review Request 58710: Add clusters query parameter to LogSearch Integration requests to LogSearch Server

2017-04-25 Thread Robert Nettleton
at the new "clusters" query parameter is set as expected. Also verified that the LogSearch Integration is working as expected with this change applied. 2. Ran the ambari-server unit tests (all passing). Thanks, Robert Nettleton

Re: Review Request 58699: Remove docker java client from Log Search it framework

2017-04-25 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58699/#review172942 --- Ship it! Ship It! - Robert Nettleton On April 25, 2017, 12

Re: Review Request 58296: Create skeleton for Ambari Infra Manager

2017-04-25 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58296/#review172943 --- Ship it! Ship It! - Robert Nettleton On April 10, 2017, 1

Re: Review Request 58726: Changing Solr port in Ambari Infra fails

2017-04-26 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58726/#review173046 --- Ship it! Ship It! - Robert Nettleton On April 26, 2017, 11

Re: Review Request 58737: Reupload missing config files for Log Search collections

2017-04-26 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58737/#review173047 --- Ship it! Ship It! - Robert Nettleton On April 26, 2017, 1

Re: Review Request 58822: Add Log Level Filter to the Log Search config API

2017-05-01 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58822/#review173495 --- Ship it! Ship It! - Robert Nettleton On April 28, 2017, 4

Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI

2017-05-02 Thread Robert Nettleton
bari-web/app/controllers/wizard/step8_controller.js Lines 1925 (patched) <https://reviews.apache.org/r/58864/#comment246611> Similar to my last point, the default provision_action is always "INSTALL_AND_START", so this might not need to be set in the Blueprint. - Robert Nettleton

Re: Review Request 59051: Integrate Log Search integration test framework with Selenium

2017-05-08 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59051/#review174182 --- Ship it! Ship It! - Robert Nettleton On May 8, 2017, 3:40

Re: Review Request 58990: Required properties for services listed in the blueprint are validated when all the configuration is available

2017-05-09 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58990/#review174360 --- Ship it! Ship It! - Robert Nettleton On May 9, 2017, 9:38

Re: Review Request 59175: Ambari infra manager: add batch support

2017-05-11 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59175/#review174716 --- Ship it! Ship It! - Robert Nettleton On May 11, 2017, 1:30

Re: Review Request 59228: Supprt boot2docker & docker-machine in Log Search integration test module

2017-05-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59228/#review174793 --- Ship it! Ship It! - Robert Nettleton On May 12, 2017, 1:58

<    1   2   3   4   5   >