Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-09-30 Thread Sid Wagle
you add more comments on what this does and why it is needed? - Sid Wagle On Sept. 30, 2016, 9:24 a.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

2016-10-03 Thread Sid Wagle
t call. - Sid Wagle On Oct. 3, 2016, 6:22 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 52266: Ambari server does not come up after restart if cluster install fails

2016-09-27 Thread Sid Wagle
> On Sept. 26, 2016, 9:33 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java, > > line 97 > > <https://reviews.apache.org/r/52266/diff/1/?file=1510202#file1510202line97> > > > &

Re: Review Request 51814: Update sinks to read multiple collector hostnames from configs

2016-09-29 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51814/#review150963 --- Ship it! Ship It! - Sid Wagle On Sept. 29, 2016, 4:18 p.m

Re: Review Request 52583: Request/access log feature in Ambari-server

2016-10-10 Thread Sid Wagle
pache.org/r/52583/#comment220764> StringUtils is null safe no need for extra check. - Sid Wagle On Oct. 10, 2016, 7:27 p.m., Amarnath reddy pappu wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 53506: AMBARI-18761 NTP check fails even if chrony is working on CentOS7

2016-11-07 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53506/#review155179 --- Ship it! Ship It! - Sid Wagle On Nov. 6, 2016, 1:23 a.m

Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-08 Thread Sid Wagle
ambari-server]# cat ~/jstack_configured.out | grep "ambari-client.*Selector" | wc -l 2 [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep "ambari-agent.*Acceptor" | wc -l 2 [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep "ambari-client.*Acceptor" | wc -l 2 Thanks, Sid Wagle

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-08 Thread Sid Wagle
" | wc -l 2 [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep "ambari-client.*Acceptor" | wc -l 2 Thanks, Sid Wagle

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-08 Thread Sid Wagle
-secure port to download cert, so need to configure both connectors. - Sid Wagle On Nov. 8, 2016, 10:45 p.m., Sid Wagle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-09 Thread Sid Wagle
e these back? qtp doesn't mean anything. > > Sid Wagle wrote: > For some reason I thought the qtp was the new addition since it > threadpool is a QueuedThreadPool. > > Actually, I need to update the patch a little bit to enable both > connectors will update thes

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-09 Thread Sid Wagle
ot; | wc -l 2 [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep "ambari-client.*Selector" | wc -l 2 [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep "ambari-agent.*Acceptor" | wc -l 2 [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep "ambari-client.*Acceptor" | wc -l 2 Thanks, Sid Wagle

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-09 Thread Sid Wagle
rs will update these in a bit. - Sid --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/#review155437 ------- On Nov. 8, 2016, 10:45 p.m., Sid Wagle wrote: > > -

Re: Review Request 53602: Ambari can autoformat NameNode in a production cluster

2016-11-09 Thread Sid Wagle
-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py (lines 397 - 406) <https://reviews.apache.org/r/53602/#comment225436> +1 on removing the break. - Sid Wagle On Nov. 9, 2016, 12:08 p.m., Andrew Onischuk

Re: Review Request 53633: AMBARI-18841 : Grafana fails to start

2016-11-09 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53633/#review155533 --- Ship it! Ship It! - Sid Wagle On Nov. 9, 2016, 11:51 p.m

Re: Review Request 53633: AMBARI-18841 : Grafana fails to start

2016-11-09 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53633/#review155534 --- Ship it! Ship It! - Sid Wagle On Nov. 9, 2016, 11:51 p.m

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-10 Thread Sid Wagle
elector" | wc -l 2 [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep "ambari-agent.*Acceptor" | wc -l 2 [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep "ambari-client.*Acceptor" | wc -l 2 Thanks, Sid Wagle

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-10 Thread Sid Wagle
n we keep these the same name as before? > > Sid Wagle wrote: > Ok, currently (2.4.2.0-101) we name agent threads as: qtp-ambari-agent > and client as ambari-client-thread. Both used QueuedThreadPool, this make it > consistent. Let me know if you are ok with naming them qtp-a

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-10 Thread Sid Wagle
> > JavaDoc. Added. - Sid --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/#review155585 ------- On No

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-10 Thread Sid Wagle
gured.out | grep "ambari-client.*Selector" | wc -l 2 [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep "ambari-agent.*Acceptor" | wc -l 2 [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep "ambari-client.*Acceptor" | wc -l 2 Thanks, Sid Wagle

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-10 Thread Sid Wagle
ot;ambari-client.*Selector" | wc -l 2 [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep "ambari-agent.*Acceptor" | wc -l 2 [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep "ambari-client.*Acceptor" | wc -l 2 Thanks, Sid Wagle

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-10 Thread Sid Wagle
enerated e-mail. To reply, visit: https://reviews.apache.org/r/53588/#review155585 ------- On Nov. 9, 2016, 10:09 p.m., Sid Wagle wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 53506: AMBARI-18761 NTP check fails even if chrony is working on CentOS7

2016-11-04 Thread Sid Wagle
) <https://reviews.apache.org/r/53506/#comment224890> This should return a ('chronyd', 'ntp') since both are valid. Need to chnage the caller to do a OR. - Sid Wagle On Nov. 5, 2016, 1:13 a.m., Masahiro Tanaka

Re: Review Request 52842: AMBARI-18593 : Provide ability to use downsampling function on certain metrics like client side topN

2016-10-19 Thread Sid Wagle
n/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml (line 686) <https://reviews.apache.org/r/52842/#comment222633> 1. Why %.user=% vs op=% ? 2. I was expecting op=% vs op=_%, is that special syntx? - Sid Wagle On Oct. 18, 2016, 6:35 p.m.,

Re: Review Request 52758: When multiple requests are running, aborting any will incorrectly abort all requests instead the desired one

2016-10-12 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52758/#review152405 --- Ship it! Ship It! - Sid Wagle On Oct. 12, 2016, 9:04 p.m

Re: Review Request 52842: AMBARI-18593 : Provide ability to use downsampling function on certain metrics like client side topN

2016-10-20 Thread Sid Wagle
> On Oct. 20, 2016, 2:01 a.m., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml, > > line 686 > > <https://reviews.apache.org/r/52842/diff/2/?file=1540795#file1540795line686> > > > >

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-20 Thread Sid Wagle
/StatusCommandsExecutor.py (line 56) <https://reviews.apache.org/r/52420/#comment222721> This looks weird I would think you would need a self.statusCommandsExecutor reference to point to this new executor, would this not get lost after 1st re-spawn? - Sid Wagle On Oct. 20, 2016, 3:54 p.m., Andrew Onischuk

Re: Review Request 52989: HDFS goes down after installing cluster

2016-10-18 Thread Sid Wagle
are killing the thread. 2. Instead of cryptic way of kill is there a graceful way to stop using separate Stoppable Thread extension which can be called from the parent ? - Sid Wagle On Oct. 18, 2016, 3:09 p.m., Andrew Onischuk wrote

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Sid Wagle
unnign service check on a candidate host. No point maintaining local list of what hosts have running commands and throwing them away. - Sid Wagle On Oct. 18, 2016, 6:25 p.m., Alejandro Fernandez wrote: > > --- > This is a

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Sid Wagle
> On Oct. 18, 2016, 6:36 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java, > > line 612 > > <https://reviews.apache.org/r/52964/diff/2/?file=1540779#file1540779line612> > > >

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52964/#review153148 --- Ship it! Ship It! - Sid Wagle On Oct. 18, 2016, 6:25 p.m

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-20 Thread Sid Wagle
> On Oct. 20, 2016, 4:52 p.m., Sid Wagle wrote: > > ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py, line 56 > > <https://reviews.apache.org/r/52420/diff/5/?file=1542350#file1542350line56> > > > > This looks w

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-20 Thread Sid Wagle
for the impl. ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py (line 57) <https://reviews.apache.org/r/52420/#comment222770> Reference to the executor should not be lost. - Sid Wagle On Oct. 20, 2016, 3:54 p.m., Andrew Onischuk

Re: Review Request 52842: AMBARI-18593 : Provide ability to use downsampling function on certain metrics like client side topN

2016-10-20 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52842/#review153452 --- Ship it! Ship It! - Sid Wagle On Oct. 20, 2016, 8:41 p.m

Re: Review Request 52999: Incorporate database consistency check into main Ambari process

2016-10-20 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52999/#review153454 --- Ship it! Ship It! - Sid Wagle On Oct. 20, 2016, 8:42 p.m

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-19 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52964/#review153297 --- Ship it! Ship It! - Sid Wagle On Oct. 19, 2016, 1:35 a.m

Re: Review Request 52999: Incorporate database consistency check into main Ambari process

2016-10-18 Thread Sid Wagle
che.org/r/52999/#comment222480> formatting ambari-server/src/main/python/ambari_server_main.py (line 105) <https://reviews.apache.org/r/52999/#comment222481> This should be configurable if it isn't. - Sid Wagle On Oct. 18, 2016, 9:50 p.m.,

Re: Review Request 53597: Allow Ambari to manage Kafka's Custom JAAS Config.

2016-11-14 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53597/#review155881 --- Ship it! Ship It! - Sid Wagle On Nov. 15, 2016, 1:57 a.m

Re: Review Request 54140: Perf: Fix deploy-gce-perf-cluster.py to deploy separate server onto own cluster with different settings for more cores and MySQL DB

2016-11-28 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54140/#review157149 --- Ship it! Ship It! - Sid Wagle On Nov. 28, 2016, 9:55 p.m

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-16 Thread Sid Wagle
rs https://reviews.apache.org/media/uploaded/files/2016/11/16/62b35d83-882e-4a64-8459-c1ad3849a88f__AMBARI-18827-1.patch Thanks, Sid Wagle

Re: Review Request 53819: AMBARI-18911 : Storm start is failing due to metrics initialization error

2016-11-16 Thread Sid Wagle
/pom.xml (line 159) <https://reviews.apache.org/r/53819/#comment226252> Missing shade for this? Cannot add specific versions to hadoop classpath. - Sid Wagle On Nov. 16, 2016, 8:38 p.m., Aravindan Vijayan

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

2016-11-16 Thread Sid Wagle
/ConfigImpl.java (line 281) <https://reviews.apache.org/r/53809/#comment226251> Shouldn't the in-memory state be update after successful merge? unless rollback handling restores the state. - Sid Wagle On Nov. 16, 2016, 7:35 p.m., Jonathan Hurley

Re: Review Request 53824: Perf: Automate deployment of PERF stack on 2500+ Ambari Agents

2016-11-16 Thread Sid Wagle
gce API calls instead of expecting a controller that would have been a portable implementation that can take gce credentails and make gcloud calls. - Sid Wagle On Nov. 16, 2016, 10:12 p.m., Vitalyi Brodetskyi wrote

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

2016-11-16 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53809/#review156144 --- Ship it! Ship It! - Sid Wagle On Nov. 16, 2016, 11:17 p.m

Re: Review Request 53881: Remove Unnecessary Locks Inside Of ConfigGroup Business Object Implementations

2016-11-18 Thread Sid Wagle
<https://reviews.apache.org/r/53881/#comment226567> Similar issue here. - Sid Wagle On Nov. 18, 2016, 8:50 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 53914: Perf: Fix bugs in deploy-gce-perf-cluster.py to generate correct config file

2016-11-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53914/#review156373 --- Ship it! Ship It! - Sid Wagle On Nov. 19, 2016, 12:12 a.m

Re: Review Request 53868: AMBARI-18927: Unit test failure in ServiceComponentHostTest

2016-11-17 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53868/#review156273 --- Ship it! Ship It! - Sid Wagle On Nov. 18, 2016, 1:27 a.m

Re: Review Request 53881: Remove Unnecessary Locks Inside Of ConfigGroup Business Object Implementations

2016-11-19 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53881/#review156404 --- Ship it! Ship It! - Sid Wagle On Nov. 18, 2016, 11:37 p.m

Re: Review Request 53881: Remove Unnecessary Locks Inside Of ConfigGroup Business Object Implementations

2016-11-19 Thread Sid Wagle
> On Nov. 18, 2016, 11:21 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java, > > line 402 > > <https://reviews.apache.org/r/53881/diff/2/?file=1567042#file1567042line402> > > > > priv

Re: Review Request 53783: Suse11 deployment failures due to package issues

2016-11-15 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53783/#review155948 --- Ship it! Ship It! - Sid Wagle On Nov. 15, 2016, 2:23 p.m

Re: Review Request 53684: Fix for limiting the number of recommendations artifacts during stack advisor calls

2016-11-14 Thread Sid Wagle
than an integer. requestId is already an int so why the manual-boxing? - Sid Wagle On Nov. 14, 2016, 9:13 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 53678: AMBARI-18846 - Custom services should be able to easily specify their own dashboards

2016-11-14 Thread Sid Wagle
> On Nov. 14, 2016, 7:56 p.m., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/split_points.py, > > line 147 > > <https://reviews.apache.org/r/53678/diff/2/?file=1563364#file1563364line147> > > &

Re: Review Request 53684: Fix for limiting the number of recommendations artifacts during stack advisor calls

2016-11-14 Thread Sid Wagle
PE here, use StringUtils instead. - Sid Wagle On Nov. 14, 2016, 8:20 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 53314: Perf: Create PERF stack with mix of HDP core services and dummy services

2016-11-02 Thread Sid Wagle
/libraries/script/dummy.py (line 44) <https://reviews.apache.org/r/53314/#comment224263> This optimization actually is counter-intuitive to perf testing right? Normal command exectuions do hit this bottleneck. - Sid Wagle On Oct. 31, 2016, 8:09 p.m., Alejandro Fernandez

Re: Review Request 52758: When multiple requests are running, aborting any will incorrectly abort all requests instead the desired one

2016-10-11 Thread Sid Wagle
/entities/StageEntity.java (line 45) <https://reviews.apache.org/r/52758/#comment221146> Why is exists query appropiate here, instead of stageId IN ?? - Sid Wagle On Oct. 11, 2016, 11:48 p.m., Alejandro Fernandez

Re: Review Request 52646: Remove Unnecessary Locks Inside Of Service Business Object Implementations

2016-10-10 Thread Sid Wagle
> On Oct. 7, 2016, 8:13 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java, > > line 966 > > <https://reviews.apache.org/r/52646/diff/1/?file=1527134#file1527134line966> > > > > Shouldn't we tar

Re: Review Request 52893: Remove Unnecessary Locks Inside Of ServiceComponent Business Object Implementations

2016-10-15 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52893/#review152787 --- Ship it! Ship It! - Sid Wagle On Oct. 14, 2016, 7:09 p.m

Re: Review Request 54002: AMBARI-18966 Add check to ensure we do not have @Transactional annotations on private methods

2016-11-29 Thread Sid Wagle
tps://reviews.apache.org/r/54002/#comment227880> IMO we should fail compilation since this is important from developer point of view and can be easily corrected at development phase. - Sid Wagle On Nov. 23, 2016, 8:43 p.m., Attila Doroszlai

Re: Review Request 54709: Use released Helix 0.6.6 instead of 0.7.1 beta as AMS dependency

2016-12-13 Thread Sid Wagle
. Thanks. - Sid Wagle On Dec. 13, 2016, 4:47 p.m., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 54513: HDP 3.0 TP - move ZK, HFDS, YARN/MR into new common-services version

2016-12-07 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54513/#review158494 --- Ship it! Ship It! - Sid Wagle On Dec. 8, 2016, 12:39 a.m

Re: Review Request 54552: hadoop.proxyuser.HTTP.hosts should not be updated when Hive is installed unless WebHcat is installed

2016-12-09 Thread Sid Wagle
che.org/r/54552/#comment229508> Does order of items in source and data matter here ? Please ignore if this comment doesn't apply. But if source is unique but 2 data items have same value. ['a', 'b', 'c'] -> ['d', 'd', 'f'] - Sid Wagle On Dec. 8, 2016, 10:59 p.m., Rob

Re: Review Request 54552: hadoop.proxyuser.HTTP.hosts should not be updated when Hive is installed unless WebHcat is installed

2016-12-09 Thread Sid Wagle
> On Dec. 9, 2016, 7:43 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 315 > > <https://reviews.apache.org/r/54552/diff/1/?file=1579998#file1579998line315> > > > >

Re: Review Request 54609: AMBARI-19141 : Refinements for AMS whitelisting

2016-12-09 Thread Sid Wagle
hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricsFilter.java (line 141) <https://reviews.apache.org/r/54609/#comment229532> TRy to store compiled patterns in the cache for perf reasons. Matcher is lest costly then compile. - Sid Wagle On Dec. 9, 20

Re: Review Request 54609: AMBARI-19141 : Refinements for AMS whitelisting

2016-12-09 Thread Sid Wagle
-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricsFilter.java (line 19) <https://reviews.apache.org/r/54609/#comment229533> Maybe this does not belong to aggregator package and can be moved to parent. - Sid Wagle

Re: Review Request 55391: Role Command Order For HOU Is Different For Some Components

2017-01-11 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55391/#review161276 --- Ship it! Ship It! - Sid Wagle On Jan. 10, 2017, 9:24 p.m

Review Request 55469: Hive Metastore process cannot be determined to be up and listening on the network

2017-01-12 Thread Sid Wagle
passed except unlrelated RANGER_KMS/test_kms_server.py Thanks, Sid Wagle

Re: Review Request 55468: AMBARI-19390 : AMS Collector works in HTTP mode after setting ams-site/timeline.metrics.service.http.policy=HTTPS_ONLY to HTTPS_ONLY

2017-01-12 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55468/#review161415 --- Ship it! Ship It! - Sid Wagle On Jan. 12, 2017, 8:51 p.m

Re: Review Request 53977: Ambari attempts to commit transactions marked as rollback-only

2016-11-30 Thread Sid Wagle
/orm/AmbariJpaLocalTxnInterceptorTest.java (line 130) <https://reviews.apache.org/r/53977/#comment228058> Line length too long, generally Ambari codebase has too many violations to count but can you retrict to something like 200 chars for consistency? - Sid Wagle On Nov. 29, 2016

Re: Review Request 53977: Ambari attempts to commit transactions marked as rollback-only

2016-11-30 Thread Sid Wagle
> On Nov. 30, 2016, 9:25 p.m., Sid Wagle wrote: > > ambari-server/src/test/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptorTest.java, > > line 130 > > <https://reviews.apache.org/r/53977/diff/1/?file=1568455#file1568455line130> > > > >

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

2016-11-29 Thread Sid Wagle
--- On Nov. 29, 2016, 5:04 p.m., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54124/ > --- > > (Updated Nov. 29, 2016, 5:04 p.m.) > > > Review request for Amb

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

2016-11-29 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54124/#review157283 --- Ship it! Ship It! - Sid Wagle On Nov. 29, 2016, 5:04 p.m

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-29 Thread Sid Wagle
it: https://reviews.apache.org/r/53588/#review157270 --- On Nov. 16, 2016, 7:39 p.m., Sid Wagle wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 54390: AMBARI-19088 : Make sure AMS in embedded mode cannot have more than 1 deployed instance

2016-12-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54390/#review158067 --- Ship it! Ship It! - Sid Wagle On Dec. 5, 2016, 9:35 p.m

Re: Review Request 54009: AMBARI-18965 : Investigate and reduce AMS HA dependency on Zookeeper.

2016-12-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54009/#review158066 --- Ship it! - Sid Wagle On Dec. 5, 2016, 9:36 p.m., Aravindan

Re: Review Request 55213: PERF: disabling security fails

2017-01-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55213/#review160608 --- Ship it! Ship It! - Sid Wagle On Jan. 5, 2017, 3:32 p.m

Re: Review Request 55273: Warning by default by stack advisor

2017-01-06 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55273/#review160731 --- Ship it! Ship It! - Sid Wagle On Jan. 6, 2017, 4:57 p.m

Re: Review Request 55278: AMBARI-17596 : Collect & Publish AmbariServer database metrics

2017-01-06 Thread Sid Wagle
> On Jan. 6, 2017, 9:23 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java, > > line 124 > > <https://reviews.apache.org/r/55278/diff/1/?file=1598881#file1598881line124> > > >

Re: Review Request 55278: AMBARI-17596 : Collect & Publish AmbariServer database metrics

2017-01-06 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55278/#review160790 --- Ship it! Ship It! - Sid Wagle On Jan. 6, 2017, 10:44 p.m

Re: Review Request 55293: HDP 3.0 TP - create Service Advisor for ZK

2017-01-06 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55293/#review160805 --- Ship it! Ship It! - Sid Wagle On Jan. 7, 2017, 1:36 a.m

Re: Review Request 54958: Single API to download all client configs

2016-12-28 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/#review160256 --- Ship it! Ship It! - Sid Wagle On Dec. 27, 2016, 4:16 p.m

Re: Review Request 55136: AM sizing for LLAP - min container size changes

2017-01-03 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55136/#review160406 --- Ship it! Ship It! - Sid Wagle On Jan. 3, 2017, 12:13 p.m

Re: Review Request 55136: AM sizing for LLAP - min container size changes

2017-01-03 Thread Sid Wagle
/stack_advisor.py (line 129) <https://reviews.apache.org/r/55136/#comment231530> Does the stack have correct default of 1024? - Sid Wagle On Jan. 3, 2017, 12:13 p.m., Dmytro Sen wrote: > > --- > This is an automatically g

Re: Review Request 55178: Investigate Changing the Default Container Policy in JPA From Vector to ArrayList

2017-01-04 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55178/#review160509 --- Ship it! Ship It! - Sid Wagle On Jan. 4, 2017, 4:56 p.m

Re: Review Request 54935: ulimit override missing from upgrade catalogs

2016-12-21 Thread Sid Wagle
/upgrade/UpgradeCatalog250.java (line 150) <https://reviews.apache.org/r/54935/#comment230870> suggest rename to HadoopEnvConfigs. - Sid Wagle On Dec. 21, 2016, 4:55 p.m., Dmytro Sen wrote: > > --- > This is a

Re: Review Request 54958: Single API to download all client configs

2016-12-27 Thread Sid Wagle
/internal/ClientConfigResourceProvider.java (line 545) <https://reviews.apache.org/r/54958/#comment231237> Do you depend on order of execution for success? If yes, this looks non-reliable. - Sid Wagle On Dec. 27, 2016, 4:16 p.m., Jaimin Jetly

Re: Review Request 54958: Single API to download all client configs

2016-12-27 Thread Sid Wagle
mended - Sid Wagle On Dec. 27, 2016, 4:16 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 54609: AMBARI-19141 : Refinements for AMS whitelisting

2016-12-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54609/#review159921 --- Ship it! Ship It! - Sid Wagle On Dec. 22, 2016, 1:53 a.m

Re: Review Request 54958: Single API to download all client configs

2016-12-21 Thread Sid Wagle
298) <https://reviews.apache.org/r/54958/#comment230990> Isn't this the same as props.putAll(properties.values())? - Sid Wagle On Dec. 22, 2016, 12:28 a.m., Jaimin Jetly wrote: > > --- > This is an automatically genera

Re: Review Request 54944: AMBARI-19273 : Refine AmbariServer Metrics service and enable JVM metrics source by default.

2016-12-21 Thread Sid Wagle
/ambari/server/metrics/system/impl/MetricsServiceImpl.java (line 67) <https://reviews.apache.org/r/54944/#comment230940> Why is this hardcoded ? - Sid Wagle On Dec. 21, 2016, 9:23 p.m., Aravindan Vijayan

Re: Review Request 54609: AMBARI-19141 : Refinements for AMS whitelisting

2016-12-21 Thread Sid Wagle
hive metrics? - Sid Wagle On Dec. 15, 2016, 8:03 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 54932: Zeppelin fails to install when hive-site.xml does not exist in spark conf directory

2016-12-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54932/#review159931 --- Ship it! Ship It! - Sid Wagle On Dec. 21, 2016, 11:05 a.m

Re: Review Request 57902: AMBARI-20553 : Ambari script error for ams-hbase while writing to Amazon s3 on a cluster with no HDFS.

2017-03-28 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57902/#review170333 --- Ship it! Ship It! - Sid Wagle On None, Aravindan Vijayan

Re: Review Request 57918: Ambari Agent Alert to detect when "hdp-select versions" reports an error

2017-03-24 Thread Sid Wagle
g/r/57918/#comment242809> Proceed without stack-selector? - Sid Wagle On March 24, 2017, 7:27 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 58070: Integrate stomp client library into agent code

2017-03-30 Thread Sid Wagle
> On March 30, 2017, 4:53 p.m., Sid Wagle wrote: > > Is there apache hosted tarball option for STOMP? Including code is great > > but better option would be if the release tarball is hosted in Apache we > > could rev versions without additional work. > > Sid Wagl

Re: Review Request 58070: Integrate stomp client library into agent code

2017-03-30 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58070/#review170613 --- Ship it! Ship It! - Sid Wagle On March 30, 2017, 1:43 p.m

Re: Review Request 58070: Integrate stomp client library into agent code

2017-03-30 Thread Sid Wagle
> On March 30, 2017, 4:53 p.m., Sid Wagle wrote: > > Is there apache hosted tarball option for STOMP? Including code is great > > but better option would be if the release tarball is hosted in Apache we > > could rev versions without additional work. lso lets put bran

Re: Review Request 58070: Integrate stomp client library into agent code

2017-03-30 Thread Sid Wagle
is great but better option would be if the release tarball is hosted in Apache we could rev versions without additional work. - Sid Wagle On March 30, 2017, 1:43 p.m., Andrew Onischuk wrote: > > --- > This is an automatically ge

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-28 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58006/#review170345 --- Ship it! Ship It! - Sid Wagle On March 28, 2017, 10:03 p.m

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-28 Thread Sid Wagle
> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58006/ > --- > > (Updated March 28, 2017, 10:03 p.m.) > > > Review request for Ambari, Dmytro Sen, Robert Lev

Re: Review Request 57902: AMBARI-20553 : Ambari script error for ams-hbase while writing to Amazon s3 on a cluster with no HDFS.

2017-03-27 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57902/#review170231 --- Missing UpgradeCatalog changes. - Sid Wagle On None, Aravindan

Re: Review Request 57793: YARN Service Check failing due to incorrect jar name, Slider failing due to storm plugin conf not present at the moment

2017-03-20 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57793/#review169512 --- Ship it! Ship It! - Sid Wagle On March 20, 2017, 9:47 p.m

<    1   2   3   4   5   6   >