[Impala-ASF-CR] IMPALA-11631 Fix impala crashes in impala::TopNNode::Heap::Close()

2022-10-04 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/19087 ) Change subject: IMPALA-11631 Fix impala crashes in impala::TopNNode::Heap::Close() .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-10889: Allow extra 1MB for fragment cancellation

2022-10-04 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/19092 ) Change subject: IMPALA-10889: Allow extra 1MB for fragment cancellation .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11631 Fix impala crashes in impala::TopNNode::Heap::Close()

2022-10-04 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/19087 ) Change subject: IMPALA-11631 Fix impala crashes in impala::TopNNode::Heap::Close() .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11631 Fix impala crashes in impala::TopNNode::Heap::Close()

2022-09-30 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/19087 ) Change subject: IMPALA-11631 Fix impala crashes in impala::TopNNode::Heap::Close() .. Patch Set 1: (1 comment) The fix looks good.

[Impala-ASF-CR] IMPALA-9999: Switch to GCC 10.4

2022-09-16 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18134 ) Change subject: IMPALA-: Switch to GCC 10.4 .. Patch Set 14: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10791 Add batch reading for remote temporary files

2022-08-09 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17979 ) Change subject: IMPALA-10791 Add batch reading for remote temporary files .. Patch Set 15: (9 comments) Looks good to me. Some

[Impala-ASF-CR] IMPALA-9615: re2's max mem opt configurable via an Impala startup flag

2022-06-20 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18602 ) Change subject: IMPALA-9615: re2's max_mem opt configurable via an Impala startup flag .. Patch Set 9: (7 comments) Overall looks

[Impala-ASF-CR] IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause

2022-06-08 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has removed a vote on this change. Change subject: IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause .. Removed Code-Review+2 by Aman Sinha -- To view, visit

[Impala-ASF-CR] IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause

2022-06-08 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause

2022-06-06 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause

2022-06-06 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause .. IMPALA-11284: Enable

[Impala-ASF-CR] IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause

2022-06-02 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause .. IMPALA-11284: Enable

[Impala-ASF-CR] IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause

2022-06-01 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18581 Change subject: IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause .. IMPALA-11284: Enable

[Impala-ASF-CR] IMPALA-11332: Fix trailing whitespace for CSV output

2022-06-01 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18580 ) Change subject: IMPALA-11332: Fix trailing whitespace for CSV output .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] WIP: IMPALA-11301: Fix = and != selectivity for very low NDVs

2022-05-18 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18543 ) Change subject: WIP: IMPALA-11301: Fix = and != selectivity for very low NDVs .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client

2022-03-30 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/18336 ) Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client .. IMPALA-11126: impala-shell:

[Impala-ASF-CR] IMPALA-11196 Fix a ClientCacheTest flaky test

2022-03-29 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18363 ) Change subject: IMPALA-11196 Fix a ClientCacheTest flaky test .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client

2022-03-29 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 ) Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client .. Patch Set 10: Code-Review+1 Sure

[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client

2022-03-29 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 ) Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client .. Patch Set 10: Verified+1 -- To

[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client

2022-03-29 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 ) Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client .. Patch Set 9: Code-Review+2

[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client

2022-03-29 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/18336 ) Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client .. IMPALA-11126: impala-shell: Support

[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client

2022-03-25 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 ) Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client .. Patch Set 6: I'll try to

[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client

2022-03-25 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/18336 ) Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client .. IMPALA-11126: impala-shell: Support

[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client

2022-03-25 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18336 ) Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client .. IMPALA-11126: impala-shell: Support

[Impala-ASF-CR] IMPALA-11126: impala-shell: Set reasonable timeout for http client

2022-03-22 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 ) Change subject: IMPALA-11126: impala-shell: Set reasonable timeout for http client .. Patch Set 4: Thanks, let me create a new

[Impala-ASF-CR] IMPALA-11126: impala-shell: Set reasonable timeout for http client

2022-03-22 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18336 ) Change subject: IMPALA-11126: impala-shell: Set reasonable timeout for http client .. IMPALA-11126: impala-shell: Set reasonable

[Impala-ASF-CR] IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure

2022-03-22 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18342 ) Change subject: IMPALA-11196 Fix ClientCacheTest ASAN and TSAN build failure .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11126: impala-shell: Set reasonable timeout for http client

2022-03-21 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18336 Change subject: IMPALA-11126: impala-shell: Set reasonable timeout for http client .. IMPALA-11126: impala-shell: Set reasonable

[Impala-ASF-CR] IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS

2022-03-17 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18332 ) Change subject: IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-11193: Fix assertion fails of ClientCacheTest.MemLeak in CentOS

2022-03-17 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18332 ) Change subject: IMPALA-11193: Fix assertion fails of ClientCacheTest.MemLeak in CentOS .. Patch Set 1: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-11176: Fix Memory leak in ClientCacheHelper

2022-03-15 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18314 ) Change subject: IMPALA-11176: Fix Memory leak in ClientCacheHelper .. Patch Set 3: Code-Review+2 We can check offline why ASAN

[Impala-ASF-CR] IMPALA-11176: Fix Memory leak in ClientCacheHelper

2022-03-13 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18314 ) Change subject: IMPALA-11176: Fix Memory leak in ClientCacheHelper .. Patch Set 2: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive

2021-12-15 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. IMPALA-11035: Make x-forwarded-for http header

[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive

2021-12-15 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 5: Code-Review+2 Carrying forward +2

[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive

2021-11-29 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 4: Looks like the pre-commit test is

[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive

2021-11-23 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive

2021-11-23 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. IMPALA-11035: Make x-forwarded-for http header

[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive

2021-11-22 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18048 Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. IMPALA-11035: Make x-forwarded-for http header

[Impala-ASF-CR] IMPALA-11007: Replies to HTTP HEAD requests should contain no content.

2021-11-08 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18002 ) Change subject: IMPALA-11007: Replies to HTTP HEAD requests should contain no content. .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10973: Do not schedule empty scan nodes to coordinator

2021-10-19 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17954 ) Change subject: IMPALA-10973: Do not schedule empty scan nodes to coordinator .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10945: Fix S3 scratch path behavior

2021-10-07 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17901 ) Change subject: IMPALA-10945: Fix S3 scratch path behavior .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-10-04 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17891 ) Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. Patch Set 1: Code-Review+1 --

[Impala-ASF-CR] IMPALA-10862 Optimization of the code structure of TmpDir

2021-10-04 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17778 ) Change subject: IMPALA-10862 Optimization of the code structure of TmpDir .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10429 Add Support for Spilling to HDFS Path Parsing

2021-08-16 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17720 ) Change subject: IMPALA-10429 Add Support for Spilling to HDFS Path Parsing .. Patch Set 4: Code-Review+1 (4 comments)

[Impala-ASF-CR] IMPALA-10429 Add Support for Spilling to HDFS Path Parsing

2021-08-10 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17720 ) Change subject: IMPALA-10429 Add Support for Spilling to HDFS Path Parsing .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed

2021-07-26 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 ) Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed

2021-07-26 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 ) Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-10821 Fix TestTPCHJoinQueries.test outer joins failed

2021-07-22 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 ) Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

2021-07-20 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17700 ) Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

2021-07-19 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17700 ) Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9338 Fix impala crashing in impala::RowDescriptor::TupleIsNullable(int)

2021-06-25 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17610 ) Change subject: IMPALA-9338 Fix impala crashing in impala::RowDescriptor::TupleIsNullable(int) .. Patch Set 1: (4 comments) Added

[Impala-ASF-CR] IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem

2021-06-16 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17572 ) Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem .. Patch Set 3: Code-Review+2 --

[Impala-ASF-CR] IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem

2021-06-11 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17572 ) Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem .. Patch Set 1: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-10367: Impala-shell internal error - UnboundLocalError, local variable 'retry msg' referenced before assign

2021-03-10 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17172 Change subject: IMPALA-10367: Impala-shell internal error - UnboundLocalError, local variable 'retry_msg' referenced before assign ..

[Impala-ASF-CR] IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows

2020-11-12 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/16712 ) Change subject: IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows .. IMPALA-7876: COMPUTE STATS

[Impala-ASF-CR] IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows

2020-11-12 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16712 ) Change subject: IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows

2020-11-12 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16712 ) Change subject: IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows .. IMPALA-7876: COMPUTE STATS

[Impala-ASF-CR] IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows

2020-11-12 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16712 ) Change subject: IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows

2020-11-12 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16712 ) Change subject: IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows .. IMPALA-7876: COMPUTE STATS

[Impala-ASF-CR] IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows

2020-11-11 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16712 Change subject: IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows .. IMPALA-7876: COMPUTE STATS

[Impala-ASF-CR] IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell

2020-11-10 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16702 ) Change subject: IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2020-10-30 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 19: (7 comments)

[Impala-ASF-CR] IMPALA-10102 Fix Impalad crashes when writing a parquet file with large rows.

2020-10-23 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16638 ) Change subject: IMPALA-10102 Fix Impalad crashes when writing a parquet file with large rows. .. Patch Set 3: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-10102 Fix Impalad crashes when writing a parquet file with large rows.

2020-10-23 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16638 ) Change subject: IMPALA-10102 Fix Impalad crashes when writing a parquet file with large rows. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10102 Fix Impalad crashses when writting a parquet file with large rows.

2020-10-23 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16638 ) Change subject: IMPALA-10102 Fix Impalad crashses when writting a parquet file with large rows. .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2020-10-21 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 17: (11 comments)

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2020-10-19 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 17: (17 comments) Some basic comments...

[Impala-ASF-CR] IMPALA-10188: Remove unused WebDAV functions

2020-10-05 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16538 ) Change subject: IMPALA-10188: Remove unused WebDAV functions .. IMPALA-10188: Remove unused WebDAV functions Included the latest

[Impala-ASF-CR] IMPALA-10188: Remove unused WebDAV functions

2020-10-02 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16538 ) Change subject: IMPALA-10188: Remove unused WebDAV functions .. Patch Set 1: Sure. I will open a PR for the upstream squeasel and

[Impala-ASF-CR] IMPALA-10188: Remove unused WebDAV functions

2020-10-02 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16538 Change subject: IMPALA-10188: Remove unused WebDAV functions .. IMPALA-10188: Remove unused WebDAV functions Removed PROPFIND and

[Impala-ASF-CR] WIP: IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2020-09-11 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: WIP: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 10: (17 comments)

[Impala-ASF-CR] IMPALA-9697: Support priority based scratch directory selection

2020-06-24 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16091 ) Change subject: IMPALA-9697: Support priority based scratch directory selection .. IMPALA-9697: Support priority based scratch

[Impala-ASF-CR] IMPALA-9829: Add Write Metrics for Spilling

2020-06-24 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16083 ) Change subject: IMPALA-9829: Add Write Metrics for Spilling .. Patch Set 8: (10 comments) Some more style comment.

[Impala-ASF-CR] IMPALA-9829: Add Write Metrics for Spilling

2020-06-23 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16083 ) Change subject: IMPALA-9829: Add Write Metrics for Spilling .. Patch Set 7: (11 comments) A few more suggestions for improving the

[Impala-ASF-CR] IMPALA-9697: Support priority based scratch directory selection

2020-06-22 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16091 ) Change subject: IMPALA-9697: Support priority based scratch directory selection .. Patch Set 2: (11 comments)

[Impala-ASF-CR] IMPALA-9697: Support priority based scratch directory selection

2020-06-22 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16091 ) Change subject: IMPALA-9697: Support priority based scratch directory selection .. IMPALA-9697: Support priority based scratch

[Impala-ASF-CR] IMPALA-9829: Add metrics for Spilling to S3

2020-06-19 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16083 ) Change subject: IMPALA-9829: Add metrics for Spilling to S3 .. Patch Set 4: (9 comments) Overall looks good to me. Just some

[Impala-ASF-CR] IMPALA-9697: Support priority based scratch directory selection

2020-06-17 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16091 Change subject: IMPALA-9697: Support priority based scratch directory selection .. IMPALA-9697: Support priority based scratch

[Impala-ASF-CR] IMPALA-9644: Set core file size 0 in docker entrypoint script

2020-04-12 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15717 Change subject: IMPALA-9644: Set core file size 0 in docker entrypoint script .. IMPALA-9644: Set core file size 0 in docker

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-25 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. Patch Set 15: (4 comments)

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-25 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. IMPALA-9466: impala-shell client retry for hs2-http

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-24 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. IMPALA-9466: impala-shell client retry for hs2-http

[Impala-ASF-CR] IMPALA-9547: retry accept in test shell commandline

2020-03-24 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15541 ) Change subject: IMPALA-9547: retry accept in test_shell_commandline .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-23 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-23 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. IMPALA-9466: impala-shell client retry for hs2-http

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-23 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. Patch Set 11: (7 comments)

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-20 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. IMPALA-9466: impala-shell client retry for hs2-http

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-19 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. IMPALA-9466: impala-shell client retry for hs2-http

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-19 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. Patch Set 8: (10 comments) Responding to the latest

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-18 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. IMPALA-9466: impala-shell client retry for hs2-http

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-18 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. Patch Set 8: (9 comments) Addressed the comments so

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-17 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. IMPALA-9466: impala-shell client retry for hs2-http

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-17 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. Patch Set 7: (9 comments) Addressed the comments so

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-17 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-13 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. IMPALA-9466: impala-shell client retry for hs2-http

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-13 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. Patch Set 6: (1 comment) Added a test to simulate

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-11 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-11 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. Patch Set 6: (14 comments) Thanks for the review.

[Impala-ASF-CR] IMPALA-9446 Fix bug that impala failed to read zstd file on s3

2020-03-11 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15391 ) Change subject: IMPALA-9446 Fix bug that impala failed to read zstd file on s3 .. Patch Set 1: Code-Review+1 (4 comments)

[Impala-ASF-CR] IMPALA-9466: impala-shell client retry for hs2-http protocol

2020-03-10 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/15378 ) Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol .. IMPALA-9466: impala-shell client retry for hs2-http

<    1   2   3   4   >