[Impala-ASF-CR] IMPALA-10992 Planner changes for estimate peak memory

2022-03-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18178 ) Change subject: IMPALA-10992 Planner changes for estimate peak memory .. Patch Set 30: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10992 Planner changes for estimate peak memory

2022-03-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has removed a vote on this change. Change subject: IMPALA-10992 Planner changes for estimate peak memory .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/18178 To

[Impala-ASF-CR] IMPALA-10992 Planner changes for estimate peak memory

2022-03-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18178 ) Change subject: IMPALA-10992 Planner changes for estimate peak memory .. Patch Set 23: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10992 Planner changes for estimate peak memory

2022-03-08 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18178 ) Change subject: IMPALA-10992 Planner changes for estimate peak memory .. Patch Set 19: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10992 Planner changes for estimate peak memory

2022-03-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18178 ) Change subject: IMPALA-10992 Planner changes for estimate peak memory .. Patch Set 17: Code-Review+1 Looks good to me. Can you check

[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load

2022-03-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 ) Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10992 Planner changes for estimate peak memory

2022-03-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18178 ) Change subject: IMPALA-10992 Planner changes for estimate peak memory .. Patch Set 16: (6 comments) Just a few more nits,

[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load

2022-03-03 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 ) Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10992 Planner changes for estimate peak memory

2022-02-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18178 ) Change subject: IMPALA-10992 Planner changes for estimate peak memory .. Patch Set 13: (16 comments)

[Impala-ASF-CR] IMPALA-10992 Planner changes for estimate peak memory - v1

2022-02-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18143 ) Change subject: IMPALA-10992 Planner changes for estimate peak memory - v1 .. Patch Set 29: (20 comments)

[Impala-ASF-CR] IMPALA-11063: Add metrics to expose state of each executor group set

2022-01-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18142 ) Change subject: IMPALA-11063: Add metrics to expose state of each executor group set .. Patch Set 2: (8 comments)

[Impala-ASF-CR] IMPALA-11063: Add metrics to expose state of each executor group set

2022-01-12 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Qifan Chen, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18142 to look at the new patch set (#2). Change subject: IMPALA-11063: Add metrics to expose state of each executor group set

[Impala-ASF-CR] IMPALA-11063: Add metrics to expose state of each executor group set

2022-01-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18142 Change subject: IMPALA-11063: Add metrics to expose state of each executor group set .. IMPALA-11063: Add metrics to expose state of

[Impala-ASF-CR] IMPALA-11068: Add tuning flag to reduce scanner thread launch.

2022-01-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18126 ) Change subject: IMPALA-11068: Add tuning flag to reduce scanner thread launch. .. Patch Set 1: Should we look into making the

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2022-01-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18093 ) Change subject: IMPALA-11033: Add support for specifying multiple executor group sets .. Patch Set 9: Code-Review+2 Saw 3 tests

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2022-01-07 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Qifan Chen, Kurt Deschler, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18093 to look at the new patch set (#9). Change subject: IMPALA-11033: Add support for specifying multiple executor group

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2022-01-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18093 ) Change subject: IMPALA-11033: Add support for specifying multiple executor group sets .. Patch Set 8: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2021-12-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18093 ) Change subject: IMPALA-11033: Add support for specifying multiple executor group sets .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2021-12-22 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Qifan Chen, Kurt Deschler, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18093 to look at the new patch set (#7). Change subject: IMPALA-11033: Add support for specifying multiple executor group

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2021-12-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18093 ) Change subject: IMPALA-11033: Add support for specifying multiple executor group sets .. Patch Set 5: (10 comments)

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2021-12-21 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Qifan Chen, Kurt Deschler, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18093 to look at the new patch set (#6). Change subject: IMPALA-11033: Add support for specifying multiple executor group

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2021-12-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18093 ) Change subject: IMPALA-11033: Add support for specifying multiple executor group sets .. Patch Set 5: (14 comments)

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2021-12-17 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Qifan Chen, Kurt Deschler, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18093 to look at the new patch set (#5). Change subject: IMPALA-11033: Add support for specifying multiple executor group

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2021-12-17 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Qifan Chen, Kurt Deschler, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18093 to look at the new patch set (#4). Change subject: IMPALA-11033: Add support for specifying multiple executor group

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2021-12-15 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18093 ) Change subject: IMPALA-11033: Add support for specifying multiple executor group sets .. Patch Set 3: (14 comments)

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2021-12-15 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Qifan Chen, Kurt Deschler, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18093 to look at the new patch set (#3). Change subject: IMPALA-11033: Add support for specifying multiple executor group

[Impala-ASF-CR] IMPALA-11054: Support resource pool polling for frontend

2021-12-15 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18078 ) Change subject: IMPALA-11054: Support resource pool polling for frontend .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2021-12-13 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Qifan Chen, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18093 to look at the new patch set (#2). Change subject: IMPALA-11033: Add support for specifying multiple executor group sets

[Impala-ASF-CR] IMPALA-11054: Support resource pool polling for frontend

2021-12-13 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18078 ) Change subject: IMPALA-11054: Support resource pool polling for frontend .. Patch Set 3: Code-Review+1 Looks good to me, deferring

[Impala-ASF-CR] IMPALA-11054: Support resource pool polling for frontend

2021-12-13 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18078 ) Change subject: IMPALA-11054: Support resource pool polling for frontend .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2021-12-13 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18093 Change subject: IMPALA-11033: Add support for specifying multiple executor group sets .. IMPALA-11033: Add support for specifying

[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true

2021-12-01 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18062 ) Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true

2021-12-01 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18062 ) Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10970: Fix criterion for classifying coordinator only query

2021-11-30 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17937 ) Change subject: IMPALA-10970: Fix criterion for classifying coordinator only query .. IMPALA-10970: Fix criterion for

[Impala-ASF-CR] IMPALA-10970: Fix criterion for classifying coordinator only query

2021-11-30 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17937 ) Change subject: IMPALA-10970: Fix criterion for classifying coordinator only query .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive

2021-11-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11035: Make x-forwarded-for http header case-insensitive

2021-11-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18048 ) Change subject: IMPALA-11035: Make x-forwarded-for http header case-insensitive .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10970: Fix criterion for classifying coordinator only query

2021-11-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17937 ) Change subject: IMPALA-10970: Fix criterion for classifying coordinator only query .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-10970: Update coordinator only judgment logic to adapt separate join build execution

2021-11-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17937 ) Change subject: IMPALA-10970: Update coordinator only judgment logic to adapt separate join build execution .. Patch Set 1: Just

[Impala-ASF-CR] [WIP] IMPALA-10992 Planner changes for estimate peak memory

2021-11-16 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17994 ) Change subject: [WIP] IMPALA-10992 Planner changes for estimate peak memory .. Patch Set 11: > I was thinking that the default and

[Impala-ASF-CR] [WIP] IMPALA-10992 Planner changes for estimate peak memory

2021-11-15 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17994 ) Change subject: [WIP] IMPALA-10992 Planner changes for estimate peak memory .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-11-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has removed a vote on this change. Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-11-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17891 ) Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. Patch Set 4: Hit another flaky

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-11-08 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has removed a vote on this change. Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-10970: Update coordinator only judgment logic to adapt separate join build execution

2021-11-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17937 ) Change subject: IMPALA-10970: Update coordinator only judgment logic to adapt separate join build execution .. Patch Set 1: (4

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-11-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17891 ) Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. Patch Set 3: Hit another

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-11-01 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17891 ) Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. Patch Set 3: unrelated flaky

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-11-01 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has removed a vote on this change. Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-10-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17891 ) Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. Patch Set 2: Code-Review+2 (4

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-10-29 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Abhishek Rawat, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17891 to look at the new patch set (#2). Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor

[Impala-ASF-CR] IMPALA-10973: Do not schedule empty scan nodes to coordinator

2021-10-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17954 ) Change subject: IMPALA-10973: Do not schedule empty scan nodes to coordinator .. Patch Set 3: @Csaba It would good to have a test

[Impala-ASF-CR] IMPALA-10973: Do not schedule empty scan nodes to coordinator

2021-10-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17954 ) Change subject: IMPALA-10973: Do not schedule empty scan nodes to coordinator .. Patch Set 2: Had started GVO but then noticed that

[Impala-ASF-CR] IMPALA-10973: Do not schedule empty scan nodes to coordinator

2021-10-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17954 ) Change subject: IMPALA-10973: Do not schedule empty scan nodes to coordinator .. IMPALA-10973: Do not schedule empty scan

[Impala-ASF-CR] IMPALA-10973: Do not schedule empty scan nodes to coordinator

2021-10-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17954 ) Change subject: IMPALA-10973: Do not schedule empty scan nodes to coordinator .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-08 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17894 ) Change subject: IMPALA-10950: Update expr-benchmark.cc .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17894 ) Change subject: IMPALA-10950: Update expr-benchmark.cc .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17894 ) Change subject: IMPALA-10950: Update expr-benchmark.cc .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller

2021-10-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 ) Change subject: IMPALA-10942: Fix memory leak in admission controller .. Patch Set 4: GVO failed earlier due to flaky test.

[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller

2021-10-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has removed a vote on this change. Change subject: IMPALA-10942: Fix memory leak in admission controller .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/17893 To

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17894 ) Change subject: IMPALA-10950: Update expr-benchmark.cc .. Patch Set 3: (8 comments)

[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller

2021-10-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 ) Change subject: IMPALA-10942: Fix memory leak in admission controller .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller

2021-10-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 ) Change subject: IMPALA-10942: Fix memory leak in admission controller .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller

2021-10-04 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, abeltian, Riza Suminto, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17893 to look at the new patch set (#3). Change subject: IMPALA-10942: Fix memory leak in admission controller

[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller

2021-10-01 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17893 Change subject: IMPALA-10942: Fix memory leak in admission controller .. IMPALA-10942: Fix memory leak in admission controller This

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-09-30 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17891 Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. IMPALA-10943: Add test to verify

[Impala-ASF-CR] IMPALA-9930 (part 2): Introduce new admission control rpc service

2021-09-30 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16412 ) Change subject: IMPALA-9930 (part 2): Introduce new admission control rpc service .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-10784 (part 3): Prepare to publish impala-shell on PyPi

2021-09-15 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17826 ) Change subject: IMPALA-10784 (part 3): Prepare to publish impala-shell on PyPi .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9976 IMPALA-10866: Add recovery mechanism to admission service and fix consistency between coord failure detection and registration

2021-08-31 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17332 ) Change subject: IMPALA-9976 IMPALA-10866: Add recovery mechanism to admission service and fix consistency between coord failure detection and registration

[Impala-ASF-CR] IMPALA-9976 IMPALA-10866: Add recovery mechanism to admission service and fix consistency between coord failure detection and registration

2021-08-31 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17332 to look at the new patch set (#2). Change subject: IMPALA-9976 IMPALA-10866: Add recovery mechanism to admission service and fix consistency

[Impala-ASF-CR] IMPALA-10784 (part 2): Fix retaining cookies for impala-shell

2021-08-20 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17796 ) Change subject: IMPALA-10784 (part 2): Fix retaining cookies for impala-shell .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-10874: Upgrade impyla to the latest version

2021-08-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17795 ) Change subject: IMPALA-10874: Upgrade impyla to the latest version .. Patch Set 1: Code-Review+1 Looks good to me. @Attila will the

[Impala-ASF-CR] IMPALA-10720: Add versioning to admission heartbeats

2021-08-16 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17524 ) Change subject: IMPALA-10720: Add versioning to admission heartbeats .. Patch Set 3: Code-Review+2 Carrying forward +2 from Andrew

[Impala-ASF-CR] IMPALA-10720: Add versioning to admission heartbeats

2021-08-16 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17524 ) Change subject: IMPALA-10720: Add versioning to admission heartbeats .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-10720: Add versioning to admission heartbeats

2021-08-16 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17524 to look at the new patch set (#3). Change subject: IMPALA-10720: Add versioning to admission heartbeats

[Impala-ASF-CR] IMPALA-10783: Fixed flakiness in run and verify query cancellation test

2021-08-16 Thread Bikramjeet Vig (Code Review)
Hello Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17768 to look at the new patch set (#2). Change subject: IMPALA-10783: Fixed flakiness in run_and_verify_query_cancellation_test

[Impala-ASF-CR] IMPALA-10783: Fixed flakiness in run and verify query cancellation test

2021-08-16 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17768 ) Change subject: IMPALA-10783: Fixed flakiness in run_and_verify_query_cancellation_test .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10846: Skip Authentication for connection with trusted auth header

2021-08-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17759 ) Change subject: IMPALA-10846: Skip Authentication for connection with trusted auth header .. Patch Set 1: (1 comment) Looks good,

[Impala-ASF-CR] IMPALA-8762: Track host level admission stats across all coordinators

2021-07-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17683 ) Change subject: IMPALA-8762: Track host level admission stats across all coordinators .. Patch Set 3: Code-Review+2 Carrying over

[Impala-ASF-CR] IMPALA-8762: Track host level admission stats across all coordinators

2021-07-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17683 ) Change subject: IMPALA-8762: Track host level admission stats across all coordinators .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8762: Track host level admission stats across all coordinators

2021-07-27 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Joe McDonnell, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17683 to look at the new patch set (#3). Change subject: IMPALA-8762: Track host level admission stats across all coordinators

[Impala-ASF-CR] IMPALA-8762: Track host level admission stats across all coordinators

2021-07-20 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17683 ) Change subject: IMPALA-8762: Track host level admission stats across all coordinators .. Patch Set 2: (8 comments)

[Impala-ASF-CR] IMPALA-8762: Track host level admission stats across all coordinators

2021-07-20 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Joe McDonnell, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17683 to look at the new patch set (#2). Change subject: IMPALA-8762: Track host level admission stats across all coordinators

[Impala-ASF-CR] IMPALA-8762: Track host level admission stats across all cooridnators

2021-07-13 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17683 Change subject: IMPALA-8762: Track host level admission stats across all cooridnators .. IMPALA-8762: Track host level admission

[Impala-ASF-CR] IMPALA-10784: Add support for retaining cookies in impala-shell

2021-07-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17667 ) Change subject: IMPALA-10784: Add support for retaining cookies in impala-shell .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10784: Add support for retaining cookies in impala-shell

2021-07-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17667 ) Change subject: IMPALA-10784: Add support for retaining cookies in impala-shell .. Patch Set 3: (4 comments) Looks good, just a few

[Impala-ASF-CR] IMPALA-10557: Support Kudu's multi-row transaction

2021-06-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 ) Change subject: IMPALA-10557: Support Kudu's multi-row transaction .. Patch Set 21: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10557: Support Kudu's multi-row transaction

2021-06-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 ) Change subject: IMPALA-10557: Support Kudu's multi-row transaction .. Patch Set 20: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-10762: ASAN tests fail with use-after-poison in HdfsParquetScanner::FindSkipRangesForPagesWithMinMaxFilters

2021-06-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17630 ) Change subject: IMPALA-10762: ASAN tests fail with use-after-poison in HdfsParquetScanner::FindSkipRangesForPagesWithMinMaxFilters ..

[Impala-ASF-CR] IMPALA-10720: Add versioning to admission heartbeats

2021-06-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17524 ) Change subject: IMPALA-10720: Add versioning to admission heartbeats .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-10720: Add versioning to admission heartbeats

2021-06-21 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17524 to look at the new patch set (#2). Change subject: IMPALA-10720: Add versioning to admission heartbeats

[Impala-ASF-CR] WIP IMPALA-10557: Support Kudu's multi-row transaction

2021-06-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 ) Change subject: WIP IMPALA-10557: Support Kudu's multi-row transaction .. Patch Set 5: (9 comments) Looks good, just adding a few

[Impala-ASF-CR] IMPALA-10720: Add versioning to admission heartbeats

2021-05-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17524 Change subject: IMPALA-10720: Add versioning to admission heartbeats .. IMPALA-10720: Add versioning to admission heartbeats This

[Impala-ASF-CR] IMPALA-9155: Add recovery mechanism to admission service

2021-04-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17332 Change subject: IMPALA-9155: Add recovery mechanism to admission service .. IMPALA-9155: Add recovery mechanism to admission service

[Impala-ASF-CR] IMPALA-10596: De-flake TestAdmissionControllerStress

2021-04-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17272 Change subject: IMPALA-10596: De-flake TestAdmissionControllerStress .. IMPALA-10596: De-flake TestAdmissionControllerStress

[Impala-ASF-CR] IMPALA-10596: De-flake teardown in TestAdmissionControllerStress

2021-03-31 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17256 Change subject: IMPALA-10596: De-flake teardown in TestAdmissionControllerStress .. IMPALA-10596: De-flake teardown in

[Impala-ASF-CR] IMPALA-10397: De-flake test single workload

2021-03-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17239 Change subject: IMPALA-10397: De-flake test_single_workload .. IMPALA-10397: De-flake test_single_workload This patch removes a flaky

[Impala-ASF-CR] IMPALA-10397: Fix test single workload

2021-03-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17218 ) Change subject: IMPALA-10397: Fix test_single_workload .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10397: Fix test single workload

2021-03-24 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Abhishek Rawat, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17218 to look at the new patch set (#2). Change subject: IMPALA-10397: Fix test_single_workload

[Impala-ASF-CR] IMPALA-10397: Fix test single workload

2021-03-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17218 Change subject: IMPALA-10397: Fix test_single_workload .. IMPALA-10397: Fix test_single_workload The logs on failed runs indicated

[Impala-ASF-CR] IMPALA-10594: Handle failed coordinators in admissiond

2021-03-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17209 ) Change subject: IMPALA-10594: Handle failed coordinators in admissiond .. Patch Set 2: Code-Review+2 (1 comment)

  1   2   3   4   5   6   7   8   9   10   >