[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8669 ) Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names .. Patch Set 2: Code-Review+1 lgtm -- To view, visit

[Impala-ASF-CR] IMPALA-6222: Add details to error msg on failure to get min reservation

2017-12-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8781 ) Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation .. Patch Set 4: Code-Review+2 carrying over

[Impala-ASF-CR] IMPALA-6222: Add details to error msg on failure to get min reservation

2017-12-14 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8781 to look at the new patch set (#4). Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation

[Impala-ASF-CR] IMPALA-6222: Add details to error msg on failure to get min reservation

2017-12-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8781 ) Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-5929: Remove redundant explicit casts to string

2017-12-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8660 ) Change subject: IMPALA-5929: Remove redundant explicit casts to string .. Patch Set 3: (10 comments)

[Impala-ASF-CR] IMPALA-5929: Remove redundant explicit casts to string

2017-12-12 Thread Bikramjeet Vig (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8660 to look at the new patch set (#4). Change subject: IMPALA-5929: Remove redundant explicit casts to string

[Impala-ASF-CR] IMPALA-6297: Don't partition/sort for DML on unpartitioned Kudu table

2017-12-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8810 ) Change subject: IMPALA-6297: Don't partition/sort for DML on unpartitioned Kudu table .. Patch Set 2: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-5848: Account for TCMalloc overhead in MemTracker

2017-12-12 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8782 to look at the new patch set (#4). Change subject: IMPALA-5848: Account for TCMalloc overhead in MemTracker

[Impala-ASF-CR] IMPALA-5848: Account for TCMalloc overhead in MemTracker

2017-12-12 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8782 to look at the new patch set (#5). Change subject: IMPALA-5848: Account for TCMalloc overhead in MemTracker

[Impala-ASF-CR] IMPALA-5848: Account for TCMalloc overhead in MemTracker

2017-12-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8782 ) Change subject: IMPALA-5848: Account for TCMalloc overhead in MemTracker .. Patch Set 5: Code-Review+2 (1 comment) carrying over

[Impala-ASF-CR] IMPALA-6222: Add details to error msg on failure to get min reservation

2017-12-12 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8781 to look at the new patch set (#3). Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 8: (10 comments)

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-12 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8541 to look at the new patch set (#9). Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-12 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8541 to look at the new patch set (#10). Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

[Impala-ASF-CR] IMPALA-5929: Remove redundant explicit casts to string

2017-12-19 Thread Bikramjeet Vig (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8660 to look at the new patch set (#5). Change subject: IMPALA-5929: Remove redundant explicit casts to string

[Impala-ASF-CR] IMPALA-5929: Remove redundant explicit casts to string

2017-12-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8660 ) Change subject: IMPALA-5929: Remove redundant explicit casts to string .. Patch Set 4: (10 comments)

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8541 Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. IMPALA-6177: Cleanup incomplete

[Impala-ASF-CR] IMPALA-5929: Remove redundant explicit casts to string

2017-12-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8660 ) Change subject: IMPALA-5929: Remove redundant explicit casts to string .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5929: Remove redundant explicit casts to string

2017-12-11 Thread Bikramjeet Vig (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8660 to look at the new patch set (#3). Change subject: IMPALA-5929: Remove redundant explicit casts to string

[Impala-ASF-CR] IMPALA-6222: Add details to error msg on failure to get min reservation

2017-12-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8781 Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation .. IMPALA-6222: Add details to error msg on

[Impala-ASF-CR] IMPALA-5848: Account for TCMalloc overhead in MemTracker

2017-12-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8782 Change subject: IMPALA-5848: Account for TCMalloc overhead in MemTracker .. IMPALA-5848: Account for TCMalloc overhead in MemTracker

[Impala-ASF-CR] IMPALA-5929: Remove redundant explicit casts to string

2017-12-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8660 ) Change subject: IMPALA-5929: Remove redundant explicit casts to string .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5929: Remove redundant explicit casts to string

2017-12-06 Thread Bikramjeet Vig (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8660 to look at the new patch set (#2). Change subject: IMPALA-5929: Remove redundant explicit casts to string

[Impala-ASF-CR] IMPALA-6297: Don't partition/sort for DML on unpartitioned Kudu table

2017-12-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8810 ) Change subject: IMPALA-6297: Don't partition/sort for DML on unpartitioned Kudu table .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5848: Account for TCMalloc overhead in MemTracker

2017-12-11 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8782 to look at the new patch set (#2). Change subject: IMPALA-5848: Account for TCMalloc overhead in MemTracker ..

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10396 Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks .. IMPALA-3134: Support

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-14 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10396 to look at the new patch set (#2). Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks

[Impala-ASF-CR] IMPALA-6970: race with decreasing scanner reservation

2018-05-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10314 ) Change subject: IMPALA-6970: race with decreasing scanner reservation .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6227: reduce window of metric inconsistency

2018-05-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10330 ) Change subject: IMPALA-6227: reduce window of metric inconsistency .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10158 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 16: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10158 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 15: (11 comments)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 7: (40 comments)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-11 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#8). Change subject: IMPALA-5216: Make admission control queuing async ..

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-07 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#6). Change subject: IMPALA-5216: Make admission control queuing async ..

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 5: (6 comments)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-07 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#7). Change subject: IMPALA-5216: Make admission control queuing async ..

[Impala-ASF-CR] IMPALA-6227: reduce window of metric inconsistency

2018-05-08 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10330 ) Change subject: IMPALA-6227: reduce window of metric inconsistency .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-16 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 12: (3 comments)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-22 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#13). Change subject: IMPALA-5216: Make admission control queuing async

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-25 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#16). Change subject: IMPALA-5216: Make admission control queuing async

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 15: > Could you file a JIRA for that? We probably

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 14: (2 comments) > Do we have sufficient test

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-24 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#15). Change subject: IMPALA-5216: Make admission control queuing async

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 9: > > (2 comments) > > > > will rebase in next

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-17 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#10). Change subject: IMPALA-5216: Make admission control queuing async

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 10: > Uploaded patch set 10. No notable conflicts

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10396 ) Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks .. Patch Set 2: (11

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10396 ) Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks .. Patch Set 3: (1

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10440 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-17 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10396 to look at the new patch set (#3). Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks

[Impala-ASF-CR] IMPALA 7011: Simplify PlanRootSink control logic

2018-05-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10449 ) Change subject: IMPALA_7011: Simplify PlanRootSink control logic .. Patch Set 3: Code-Review+1 (5 comments)

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10440 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-18 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#11). Change subject: IMPALA-5216: Make admission control queuing async

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-6035: Add query options to limit thread reservation

2018-05-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10365 ) Change subject: IMPALA-6035: Add query options to limit thread reservation .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-16 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 1: (5 comments) just a few more cleanup asks

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-15 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 8: (3 comments) Just wanted to get the replay

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-22 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10396 to look at the new patch set (#4). Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10396 ) Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks .. Patch Set 5:

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-22 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10396 to look at the new patch set (#5). Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks

[Impala-ASF-CR] IMPALA-3134: Support different proc mem limits among impalads for admission control checks

2018-05-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10396 ) Change subject: IMPALA-3134: Support different proc mem limits among impalads for admission control checks .. Patch Set 4: (1

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 11: (30 comments)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-22 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#12). Change subject: IMPALA-5216: Make admission control queuing async

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-23 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#14). Change subject: IMPALA-5216: Make admission control queuing async

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 14: (1 comment) Just rebased in patchset 14, will

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 9: (2 comments) will rebase in next patch, please

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-17 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#9). Change subject: IMPALA-5216: Make admission control queuing async ..

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued cause to profile .. Patch Set 1: Code-Review+1 (3 comments) lgtm, just a few nits.

[Impala-ASF-CR] IMPALA-7046: introduce "global" debug actions

2018-06-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10690 ) Change subject: IMPALA-7046: introduce "global" debug_actions .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-6969: add AC last queued reason to profile

2018-06-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued reason to profile .. Patch Set 7: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 3: (21 comments)

[Impala-ASF-CR] IMPALA-6338: Disable more flaky bloom filter tests

2018-05-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10530 ) Change subject: IMPALA-6338: Disable more flaky bloom filter tests .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7190: Remove unsupported format writer support

2018-06-26 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10823 Change subject: IMPALA-7190: Remove unsupported format writer support .. IMPALA-7190: Remove unsupported format writer support This

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued cause to profile .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6352: Dump backtrace on failure of TestTableSample

2018-07-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10851 Change subject: IMPALA-6352: Dump backtrace on failure of TestTableSample .. IMPALA-6352: Dump backtrace on failure of TestTableSample

[Impala-ASF-CR] IMPALA-6352: Dump backtrace on failure of TestTableSample

2018-07-02 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10851 to look at the new patch set (#2). Change subject: IMPALA-6352: Dump backtrace on failure of TestTableSample ..

[Impala-ASF-CR] IMPALA-6352: Dump backtrace on failure of TestTableSample

2018-07-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10851 ) Change subject: IMPALA-6352: Dump backtrace on failure of TestTableSample .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-07-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 ) Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. Patch Set 12: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7190: Remove unsupported format writer support

2018-07-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10823 ) Change subject: IMPALA-7190: Remove unsupported format writer support .. Patch Set 2: Code-Review+1 Carrying over +1. Minor changes,

[Impala-ASF-CR] IMPALA-7190: Remove unsupported format writer support

2018-07-02 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10823 to look at the new patch set (#2). Change subject: IMPALA-7190: Remove unsupported format writer support

[Impala-ASF-CR] IMPALA-7190: Remove unsupported format writer support

2018-07-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10823 ) Change subject: IMPALA-7190: Remove unsupported format writer support .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-07-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 ) Change subject: IMPALA-1760: Implement shutdown command .. Patch Set 8: (13 comments) still need to review tests

[Impala-ASF-CR] IMPALA-7190: Remove unsupported format writer support

2018-07-02 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10823 to look at the new patch set (#3). Change subject: IMPALA-7190: Remove unsupported format writer support

[Impala-ASF-CR] IMPALA-7190: Remove unsupported format writer support

2018-07-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10823 ) Change subject: IMPALA-7190: Remove unsupported format writer support .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-01 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#5). Change subject: IMPALA-5216: Make admission control queuing async ..

[Impala-ASF-CR] [Preview]IMPALA-5216: Make admission control queuing async

2018-05-01 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: [Preview]IMPALA-5216: Make admission control queuing async .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 14: Code-Review+2 carrying

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

2018-01-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'

2017-12-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 ) Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf' .. Patch Set 2: (2 comments) looks pretty solid to me

[Impala-ASF-CR] IMPALA-5519: Allocate Runtime filter memory from Buffer pool

2018-01-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate Runtime filter memory from Buffer pool .. Patch Set 2: (21 comments)

[Impala-ASF-CR] IMPALA-5519: Allocate Runtime filter memory from Buffer pool

2018-01-17 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8971 to look at the new patch set (#3). Change subject: IMPALA-5519: Allocate Runtime filter memory from Buffer pool ..

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-01-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-01-18 Thread Bikramjeet Vig (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8971 to look at the new patch set (#5). Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

[Impala-ASF-CR] IMPALA-6382: Cap default and min spillable buffer size query options

2018-01-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9023 ) Change subject: IMPALA-6382: Cap default and min spillable buffer size query options .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6382: Cap spillable buffer size and max row size query options

2018-01-17 Thread Bikramjeet Vig (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9023 to look at the new patch set (#2). Change subject: IMPALA-6382: Cap spillable buffer size and max row size query options

  1   2   3   4   5   6   7   8   9   10   >