[Impala-ASF-CR] IMPALA-10282: Implement ds cpc sketch() and ds cpc estimate() functions

2021-02-09 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16656 ) Change subject: IMPALA-10282: Implement ds_cpc_sketch() and ds_cpc_estimate() functions .. Patch Set 4: Hey, This review has been

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 ) Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-04 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 ) Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. Patch Set 2: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-03 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 ) Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. Patch Set 2: (1 comment) I have checked the tests so

[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests

2021-02-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16985 ) Change subject: IMPALA-9588: Add extra logging to cancel tests .. Patch Set 2: (2 comments) Thanks for the review, Tamas!

[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests

2021-02-02 Thread Gabor Kaszab (Code Review)
Hello Tamas Mate, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16985 to look at the new patch set (#2). Change subject: IMPALA-9588: Add extra logging to cancel tests

[Impala-ASF-CR] IMPALA-9588: Add extra logging to cancel tests

2021-01-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16985 Change subject: IMPALA-9588: Add extra logging to cancel tests .. IMPALA-9588: Add extra logging to cancel tests There have been some

[Impala-ASF-CR] IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax

2021-01-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16979 ) Change subject: IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax

2021-01-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16979 ) Change subject: IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax .. Patch Set 1: Code-Review+1 (1 comment) I just

[Impala-ASF-CR] IMPALA-10440: Import Theta functionality from DataSketches

2021-01-21 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16959 ) Change subject: IMPALA-10440: Import Theta functionality from DataSketches .. Patch Set 3: Code-Review+2 Thanks for the changes! --

[Impala-ASF-CR] IMPALA-10440: Import Theta functionality from DataSketches

2021-01-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16959 ) Change subject: IMPALA-10440: Import Theta functionality from DataSketches .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-10432: INSERT INTO Iceberg tables with partition transforms

2021-01-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16939 ) Change subject: IMPALA-10432: INSERT INTO Iceberg tables with partition transforms .. Patch Set 5: (6 comments) Hey Zoltan, Great

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 17: Code-Review+2

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 17: carry +2 from

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-18 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16741 to look at the new patch set (#17). Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-17 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 15: Code-Review+2

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-17 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16741 to look at the new patch set (#15). Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 14: (3 comments)

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-16 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16741 to look at the new patch set (#14). Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

[Impala-ASF-CR] IMPALA-10398: Altering an Iceberg table might throw NullPointerException

2020-12-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16882 ) Change subject: IMPALA-10398: Altering an Iceberg table might throw NullPointerException .. Patch Set 1: Code-Review+2 Nice catch!

[Impala-ASF-CR] IMPALA-9922: A better approach to deal with date's sub-second fractions

2020-12-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16869 ) Change subject: IMPALA-9922: A better approach to deal with date's sub-second fractions .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16851 ) Change subject: IMPALA-10358: Correct Iceberg type mappings .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9922: A better approach to deal with date's sub-second fractions

2020-12-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16869 ) Change subject: IMPALA-9922: A better approach to deal with date's sub-second fractions .. Patch Set 3: (10 comments) Thanks for

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 13: (13 comments)

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-15 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16741 to look at the new patch set (#13). Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

[Impala-ASF-CR] IMPALA-10393: Iceberg field id-based column resolution fails in ASAN builds

2020-12-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16873 ) Change subject: IMPALA-10393: Iceberg field id-based column resolution fails in ASAN builds .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-10358: Correct Iceberg type mappings

2020-12-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16851 ) Change subject: IMPALA-10358: Correct Iceberg type mappings .. Patch Set 4: Code-Review+1 (1 comment) Nice change! I'll let others to

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

2020-12-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16846 ) Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-14 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16741 to look at the new patch set (#12). Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

[Impala-ASF-CR] IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-14 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16741 to look at the new patch set (#11). Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-14 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16741 to look at the new patch set (#10). Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

2020-12-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16846 ) Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 9: (1 comment)

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-11 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16741 to look at the new patch set (#9). Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 8: (1 comment)

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-11 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16741 to look at the new patch set (#8). Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command fails

2020-12-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has abandoned this change. ( http://gerrit.cloudera.org:8080/16322 ) Change subject: IMPALA-10066: Fix test_cancellation_mid_command fails .. Abandoned There is another patch to address this: 16847 -- To view,

[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command flakiness

2020-12-09 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 ) Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness .. Patch Set 1: Code-Review+1 (3 comments) Thanks for

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-03 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16741 to look at the new patch set (#6). Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

[Impala-ASF-CR] IMPALA-10364: Set the real location for external Iceberg tables stored in HadoopCatalog

2020-12-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16795 ) Change subject: IMPALA-10364: Set the real location for external Iceberg tables stored in HadoopCatalog .. Patch Set 3: Code-Review+2

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 5: (4

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-02 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16741 to look at the new patch set (#5). Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

[Impala-ASF-CR] IMPALA-10282: Implement ds cpc sketch() and ds cpc estimate() functions

2020-12-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16656 ) Change subject: IMPALA-10282: Implement ds_cpc_sketch() and ds_cpc_estimate() functions .. Patch Set 4: Code-Review+1 (1 comment)

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-12-01 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16741 to look at the new patch set (#4). Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-11-26 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16741 to look at the new patch set (#3). Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

[Impala-ASF-CR] IMPALA-10134: Implement ds hll union f() function.

2020-11-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16711 ) Change subject: IMPALA-10134: Implement ds_hll_union_f() function. .. Patch Set 5: Code-Review+2 Great work! -- To view, visit

[Impala-ASF-CR] IMPALA-10306: [DOCS] remove TZ offset texts from the list

2020-11-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 ) Change subject: IMPALA-10306: [DOCS] remove TZ offset texts from the list .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-23 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 9: (1 comment) PS9 is a rebase with master

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-23 Thread Gabor Kaszab (Code Review)
Hello Qifan Chen, Zoltan Borok-Nagy, wangsheng, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16599 to look at the new patch set (#9). Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-23 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 7: I created this test table by Impala

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-11-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16741 Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. WiP: IMPALA-10237: Support

[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command fails

2020-11-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has restored this change. ( http://gerrit.cloudera.org:8080/16322 ) Change subject: IMPALA-10066: Fix test_cancellation_mid_command fails .. Restored -- To view, visit http://gerrit.cloudera.org:8080/16322 To

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-17 Thread Gabor Kaszab (Code Review)
Hello Qifan Chen, Zoltan Borok-Nagy, wangsheng, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16599 to look at the new patch set (#7). Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

[Impala-ASF-CR] IMPALA-10134: Implement ds hll union f() function.

2020-11-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16711 ) Change subject: IMPALA-10134: Implement ds_hll_union_f() function. .. Patch Set 3: (9 comments) Great work! Thanks for taking care of

[Impala-ASF-CR] IMPALA-10323: use snprintf instead of lexical cast to cast to string

2020-11-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16719 ) Change subject: IMPALA-10323: use snprintf instead of lexical_cast to cast to string .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-16 Thread Gabor Kaszab (Code Review)
Hello Qifan Chen, Zoltan Borok-Nagy, wangsheng, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16599 to look at the new patch set (#6). Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

[Impala-ASF-CR] IMPALA-10279: Import CPC functionality from DataSketches

2020-11-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16645 ) Change subject: IMPALA-10279: Import CPC functionality from DataSketches .. Patch Set 10: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-10279: Import CPC functionality from DataSketches

2020-11-03 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16645 ) Change subject: IMPALA-10279: Import CPC functionality from DataSketches .. Patch Set 7: (3 comments)

[Impala-ASF-CR] IMPALA-10306: [DOCS] add note about TZ offset

2020-11-03 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 ) Change subject: IMPALA-10306: [DOCS] add note about TZ offset .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10306: [DOCS] add note about TZ offset

2020-11-03 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 ) Change subject: IMPALA-10306: [DOCS] add note about TZ offset .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-03 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-03 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16599 to look at the new patch set (#5). Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-03 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 4: I'm still working on not introducing a new

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 4: (2 comments) PS4 is a rebase with master

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-02 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16599 to look at the new patch set (#4). Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-10-30 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16599 to look at the new patch set (#3). Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-10-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-10-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 2: Changes the syntax from SHOW TABLE HISTORY

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-10-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 2: (12 comments) Sorry, I think I have also

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-10-30 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16599 to look at the new patch set (#2). Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

[Impala-ASF-CR] IMPALA-10166 (part 1): ALTER TABLE for Iceberg tables

2020-10-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16606 ) Change subject: IMPALA-10166 (part 1): ALTER TABLE for Iceberg tables .. Patch Set 10: Code-Review+2 Thanks for the changes! -- To

[Impala-ASF-CR] IMPALA-10166 (part 1): ALTER TABLE for Iceberg tables

2020-10-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16606 ) Change subject: IMPALA-10166 (part 1): ALTER TABLE for Iceberg tables .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-10166 (part 1): ALTER TABLE for Iceberg tables

2020-10-29 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16606 ) Change subject: IMPALA-10166 (part 1): ALTER TABLE for Iceberg tables .. Patch Set 8: Code-Review+1 (4 comments) Hey! I did a quick

[Impala-ASF-CR] IMPALA-10132: Implement ds hll estimate bounds as string() function.

2020-10-29 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16626 ) Change subject: IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() function. .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10279: Import CPC functionality from DataSketches

2020-10-29 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16645 ) Change subject: IMPALA-10279: Import CPC functionality from DataSketches .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-10132: Implement ds hll estimate bounds as string() function.

2020-10-29 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16626 ) Change subject: IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() function. .. Patch Set 4: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-10279: Import CPC functionality from DataSketches

2020-10-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16645 ) Change subject: IMPALA-10279: Import CPC functionality from DataSketches .. Patch Set 6: Hey, I'm just letting you know that I'm

[Impala-ASF-CR] IMPALA-10132 Implement ds hll estimate bounds as string() function.

2020-10-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16626 ) Change subject: IMPALA-10132 Implement ds_hll_estimate_bounds_as_string() function. .. Patch Set 2: (9 comments) Thanks for taking

[Impala-ASF-CR] IMPALA-10153: Implement SHOW TABLE HISTORY for Iceberg tables

2020-10-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10153: Implement SHOW TABLE HISTORY for Iceberg tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables

2020-10-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16551 ) Change subject: IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables .. Patch Set 9: Code-Review+2 --

[Impala-ASF-CR] IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables

2020-10-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16551 ) Change subject: IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables .. Patch Set 8: Carry +2 from

[Impala-ASF-CR] IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet)

2020-10-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16545 ) Change subject: IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet) .. Patch Set 1: (3 comments) So

[Impala-ASF-CR] IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables

2020-10-14 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16551 to look at the new patch set (#7). Change subject: IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables

[Impala-ASF-CR] IMPALA-10153: Implement SHOW TABLE HISTORY for Iceberg tables

2020-10-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16599 Change subject: IMPALA-10153: Implement SHOW TABLE HISTORY for Iceberg tables .. IMPALA-10153: Implement SHOW TABLE HISTORY for Iceberg

[Impala-ASF-CR] IMPALA-10152: part 1: refactor Iceberg catalog handling

2020-10-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16575 ) Change subject: IMPALA-10152: part 1: refactor Iceberg catalog handling .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-10152: part 1: refactor Iceberg catalog handling

2020-10-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16575 ) Change subject: IMPALA-10152: part 1: refactor Iceberg catalog handling .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10159: Supporting ORC file format for Iceberg table

2020-10-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16568 ) Change subject: IMPALA-10159: Supporting ORC file format for Iceberg table .. Patch Set 7: Code-Review+2 Thanks for the quick

[Impala-ASF-CR] IMPALA-10159: Supporting ORC file format for Iceberg table

2020-10-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16568 ) Change subject: IMPALA-10159: Supporting ORC file format for Iceberg table .. Patch Set 6: Code-Review+1 Thanks for taking care of

[Impala-ASF-CR] IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables

2020-10-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16551 ) Change subject: IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables

2020-10-12 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16551 to look at the new patch set (#5). Change subject: IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables

[Impala-ASF-CR] IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables

2020-10-09 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16551 to look at the new patch set (#4). Change subject: IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables

[Impala-ASF-CR] IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables

2020-10-09 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16551 ) Change subject: IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables .. Patch Set 4: (10 comments)

[Impala-ASF-CR] IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables

2020-10-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16551 ) Change subject: IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables

2020-10-06 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16551 to look at the new patch set (#2). Change subject: IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables

[Impala-ASF-CR] IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables

2020-10-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16551 Change subject: IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables .. IMPALA-10165: Implement Bucket

[Impala-ASF-CR] IMPALA-10184: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-10-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16512 ) Change subject: IMPALA-10184: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables .. Patch Set 7: (1 comment) I had to

[Impala-ASF-CR] IMPALA-10184: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-10-02 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16512 to look at the new patch set (#7). Change subject: IMPALA-10184: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

<    1   2   3   4   5   6   7   8   9   10   >