[Impala-ASF-CR] IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode

2024-09-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21718 ) Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode .. Patch Set 1: (2 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-13334: Fix test sort.py DCHECK hit when max sort run size>0

2024-09-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21777 ) Change subject: IMPALA-13334: Fix test_sort.py DCHECK hit when max_sort_run_size>0 .. Patch Set 3: (2 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode

2024-09-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21718 to look at the new patch set (#5). Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode ..

[Impala-ASF-CR] IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode

2024-09-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21718 ) Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode .. Patch Set 4: (5 comments) Thanks for the comments!

[Impala-ASF-CR] IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode

2024-09-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21718 to look at the new patch set (#4). Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode ..

[Impala-ASF-CR] IMPALA-11265: Part1: Clear GroupContentFiles once used

2024-09-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21847 ) Change subject: IMPALA-11265: Part1: Clear GroupContentFiles once used .. Patch Set 2: Code-Review+2 LGTM! -- To view, visit htt

[Impala-ASF-CR] IMPALA-12732: Docs for MERGE statement

2024-09-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21834 ) Change subject: IMPALA-12732: Docs for MERGE statement .. Patch Set 1: (1 comment) Thanks for starting work on the doc. Please al

[Impala-ASF-CR] IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode

2024-09-24 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21718 to look at the new patch set (#3). Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode .

[Impala-ASF-CR] IMPALA-11265: Part1: Clear GroupContentFiles once used

2024-09-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21847 ) Change subject: IMPALA-11265: Part1: Clear GroupContentFiles once used .. Patch Set 1: Code-Review+2 (1 comment) I proposed an al

[Impala-ASF-CR] IMPALA-13247: Support Reading Puffin files for the current snapshot

2024-09-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21605 ) Change subject: IMPALA-13247: Support Reading Puffin files for the current snapshot .. Patch Set 15: Code-Review+1 LGTM! -- To

[Impala-ASF-CR] IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode

2024-09-23 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21718 to look at the new patch set (#2). Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode .

[Impala-ASF-CR] IMPALA-13247: Support Reading Puffin files for the current snapshot

2024-09-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21605 ) Change subject: IMPALA-13247: Support Reading Puffin files for the current snapshot .. Patch Set 12: (2 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-13336: Fix syntax error in creating Iceberg test table on Apache Hive 3

2024-09-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21730 ) Change subject: IMPALA-13336: Fix syntax error in creating Iceberg test table on Apache Hive 3 .. Patch Set 1: Code-Review+2 Than

[Impala-ASF-CR] IMPALA-13286: Make stream row counters 64-bit

2024-09-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21741 ) Change subject: IMPALA-13286: Make stream row counters 64-bit .. Patch Set 2: Code-Review+1 Thanks for fixing this, LGTM! -- To

[Impala-ASF-CR] IMPALA-13364: Schema resolution doesn't work for migrated partitioned Iceberg tables that have complex types

2024-09-19 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Gabor Kaszab, Mihaly Szjatinya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21761 to look at the new patch set (#6). Change subject: IMPALA-13364: Schema resolution doesn't work for migrated partitioned Iceber

[Impala-ASF-CR] IMPALA-13364: Schema resolution doesn't work for migrated partitioned Iceberg tables that have complex types

2024-09-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21761 ) Change subject: IMPALA-13364: Schema resolution doesn't work for migrated partitioned Iceberg tables that have complex types .. Pa

[Impala-ASF-CR] IMPALA-13364: Schema resolution doesn't work for migrated partitioned Iceberg tables that have complex types

2024-09-13 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Gabor Kaszab, Mihaly Szjatinya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21761 to look at the new patch set (#5). Change subject: IMPALA-13364: Schema resolution doesn't work for migrated partitioned Iceber

[Impala-ASF-CR] IMPALA-13364: Schema resolution doesn't work for migrated partitioned Iceberg tables that have complex types

2024-09-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21761 to look at the new patch set (#4). Change subject: IMPALA-13364: Schema resolution doesn't work for migrated partitioned Iceberg tables that have complex types ..

[Impala-ASF-CR] IMPALA-13364: Schema resolution doesn't work for migrated partitioned Iceberg tables that have complex types

2024-09-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21761 to look at the new patch set (#3). Change subject: IMPALA-13364: Schema resolution doesn't work for migrated partitioned Iceberg tables that have complex types ..

[Impala-ASF-CR] IMPALA-13254: Optimize REFRESH for Iceberg tables

2024-08-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21608 ) Change subject: IMPALA-13254: Optimize REFRESH for Iceberg tables .. Patch Set 23: Code-Review+2 Thank you for your contribution,

[Impala-ASF-CR] IMPALA-12867: Filter files to OPTIMIZE based on file size

2024-08-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21388 ) Change subject: IMPALA-12867: Filter files to OPTIMIZE based on file size .. Patch Set 12: Code-Review+1 (1 comment) http://gerri

[Impala-ASF-CR] WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()

2024-08-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has abandoned this change. ( http://gerrit.cloudera.org:8080/21508 ) Change subject: WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy() .. Abandoned -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode

2024-08-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21718 Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode .. IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNo

[Impala-ASF-CR] IMPALA-12867: Filter files to OPTIMIZE based on file size

2024-08-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21388 ) Change subject: IMPALA-12867: Filter files to OPTIMIZE based on file size .. Patch Set 12: (1 comment) Nice work, Noemi! The code

[Impala-ASF-CR] IMPALA-13303: FileSystemUtil.listFiles() should handle non-recursive case

2024-08-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21680 ) Change subject: IMPALA-13303: FileSystemUtil.listFiles() should handle non-recursive case .. Patch Set 2: Code-Review+2 -- To vi

[Impala-ASF-CR] IMPALA-13247: Support Reading Puffin files for the current snapshot

2024-08-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21605 ) Change subject: IMPALA-13247: Support Reading Puffin files for the current snapshot .. Patch Set 8: Code-Review+1 (3 comments) h

[Impala-ASF-CR] IMPALA-13247: Support Reading Puffin files for the current snapshot

2024-08-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21605 ) Change subject: IMPALA-13247: Support Reading Puffin files for the current snapshot .. Patch Set 6: (11 comments) Good job, it w

[Impala-ASF-CR] IMPALA-12732: Add support for MERGE statements for Iceberg tables

2024-08-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21423 ) Change subject: IMPALA-12732: Add support for MERGE statements for Iceberg tables .. Patch Set 13: Code-Review+1 (9 comments) Le

[Impala-ASF-CR] IMPALA-13284: Loading test data on Apache Hive3

2024-08-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21657 ) Change subject: IMPALA-13284: Loading test data on Apache Hive3 .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-13254: Optimize REFRESH for Iceberg tables

2024-08-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21608 ) Change subject: IMPALA-13254: Optimize REFRESH for Iceberg tables .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-13296: Check column compatibility earlier for table migration

2024-08-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21675 ) Change subject: IMPALA-13296: Check column compatibility earlier for table migration .. Patch Set 1: Code-Review+2 -- To view, v

[Impala-ASF-CR] IMPALA-13246: Smallify strings during broadcast exchange

2024-08-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21597 ) Change subject: IMPALA-13246: Smallify strings during broadcast exchange .. Patch Set 9: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-13254: Optimize REFRESH for Iceberg tables

2024-08-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21608 ) Change subject: IMPALA-13254: Optimize REFRESH for Iceberg tables .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-13284: Loading test data on Apache Hive3

2024-08-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21657 ) Change subject: IMPALA-13284: Loading test data on Apache Hive3 .. Patch Set 1: (1 comment) Thanks for working on this! http://g

[Impala-ASF-CR] IMPALA-13293: Fix too long wait for initial catalog update

2024-08-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21655 ) Change subject: IMPALA-13293: Fix too long wait for initial catalog update .. Patch Set 4: Code-Review+1 (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-13246: Smallify strings during broadcast exchange

2024-08-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21597 ) Change subject: IMPALA-13246: Smallify strings during broadcast exchange .. Patch Set 6: Code-Review+2 (3 comments) http://gerrit

[Impala-ASF-CR] IMPALA-13293: Fix too long wait for initial catalog update

2024-08-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21655 ) Change subject: IMPALA-13293: Fix too long wait for initial catalog update .. Patch Set 3: Code-Review+1 (1 comment) Thanks for w

[Impala-ASF-CR] IMPALA-13246: Smallify strings during broadcast exchange

2024-08-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21597 ) Change subject: IMPALA-13246: Smallify strings during broadcast exchange .. Patch Set 4: (5 comments) Thanks for working on this!

[Impala-ASF-CR](asf-site) Add blog post for Impala talks at Community Over Code EU 2024

2024-08-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21618 ) Change subject: Add blog post for Impala talks at Community Over Code EU 2024 .. Patch Set 4: Code-Review+2 Thanks for working on

[Impala-ASF-CR] IMPALA-13272: Analyitic function of collections can lead to crash

2024-08-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21643 ) Change subject: IMPALA-13272: Analyitic function of collections can lead to crash .. Patch Set 4: (3 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-13272: Analyitic function of collections can lead to crash

2024-08-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21643 ) Change subject: IMPALA-13272: Analyitic function of collections can lead to crash .. Patch Set 2: (5 comments) Thanks for the qu

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

2024-07-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 ) Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write .. Patch Set 2: Co

[Impala-ASF-CR] IMPALA-13194: Fast-serialize position delete records

2024-07-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21563 ) Change subject: IMPALA-13194: Fast-serialize position delete records .. Patch Set 7: (1 comment) In PS6, conflict resolution was

[Impala-ASF-CR] IMPALA-13194: Fast-serialize position delete records

2024-07-17 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21563 to look at the new patch set (#7). Change subject: IMPALA-13194: Fast-serialize position delete records ...

[Impala-ASF-CR] IMPALA-13194: Fast-serialize position delete records

2024-07-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21563 ) Change subject: IMPALA-13194: Fast-serialize position delete records .. Patch Set 6: PS6 is a rebase to resolve merge conflicts. T

[Impala-ASF-CR] IMPALA-13194: Fast-serialize position delete records

2024-07-17 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21563 to look at the new patch set (#6). Change subject: IMPALA-13194: Fast-serialize position delete records ...

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

2024-07-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 ) Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write .. Patch Set 1: (

[Impala-ASF-CR] IMPALA-13194: Fast-serialize position delete records

2024-07-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21563 to look at the new patch set (#4). Change subject: IMPALA-13194: Fast-serialize position delete records ...

[Impala-ASF-CR] IMPALA-13194: Fast-serialize position delete records

2024-07-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21563 ) Change subject: IMPALA-13194: Fast-serialize position delete records .. Patch Set 3: (8 comments) Thanks for the comments! http:

[Impala-ASF-CR] IMPALA-13194: Fast-serialize position delete records

2024-07-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21563 to look at the new patch set (#3). Change subject: IMPALA-13194: Fast-serialize position delete records ...

[Impala-ASF-CR] IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode

2024-07-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21571 ) Change subject: IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode .. Patch Set 5: Code-Review+2 Thanks for this optimizai

[Impala-ASF-CR] IMPALA-13227: test spilling hash join should be marked for serial execution

2024-07-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21589 Change subject: IMPALA-13227: test_spilling_hash_join should be marked for serial execution .. IMPALA-13227: test_spilling_hash_joi

[Impala-ASF-CR] IMPALA-13194: Fast-serialize position delete records

2024-07-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21563 ) Change subject: IMPALA-13194: Fast-serialize position delete records .. Patch Set 2: (16 comments) Thanks for the comments! http

[Impala-ASF-CR] IMPALA-13194: Fast-serialize position delete records

2024-07-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21563 to look at the new patch set (#2). Change subject: IMPALA-13194: Fast-serialize position delete records ...

[Impala-ASF-CR] IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode

2024-07-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21571 ) Change subject: IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode .. Patch Set 4: Code-Review+1 (3 comments) Only found

[Impala-ASF-CR] IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s

2024-07-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 ) Change subject: IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s .. Patch Set 10: (4 comments) T

[Impala-ASF-CR] IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s

2024-07-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Kurt Deschler, Michael Smith, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21557 to look at the new patch set (#10). Change subject: IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sor

[Impala-ASF-CR] IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s

2024-07-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 ) Change subject: IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s .. Patch Set 9: (3 comments) Th

[Impala-ASF-CR] IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s

2024-07-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Kurt Deschler, Michael Smith, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21557 to look at the new patch set (#9). Change subject: IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sort

[Impala-ASF-CR] IMPALA-12732: Add support for MERGE statements for Iceberg tables

2024-07-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21423 ) Change subject: IMPALA-12732: Add support for MERGE statements for Iceberg tables .. Patch Set 11: (20 comments) A concurrent te

[Impala-ASF-CR] IMPALA-12732: Add support for MERGE statements for Iceberg tables

2024-07-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21423 ) Change subject: IMPALA-12732: Add support for MERGE statements for Iceberg tables .. Patch Set 11: (22 comments) Took a look at

[Impala-ASF-CR] IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s

2024-07-03 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Kurt Deschler, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21557 to look at the new patch set (#8). Change subject: IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int6

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-07-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21435 ) Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder .. Patch Set 9: (1 comment) http:/

[native-toolchain-CR] IMPALA-13190: Allow passing const Atomic(T)* to LOAD operations

2024-07-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21562 ) Change subject: IMPALA-13190: Allow passing const _Atomic(T)* to LOAD operations .. IMPALA-13190: Allow passing const _Atom

[native-toolchain-CR] IMPALA-13190: Allow passing const Atomic(T)* to LOAD operations

2024-07-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21562 ) Change subject: IMPALA-13190: Allow passing const _Atomic(T)* to LOAD operations .. Patch Set 1: Verified+1 Toolchain build passed

[Impala-ASF-CR] IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s

2024-07-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Kurt Deschler, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21557 to look at the new patch set (#7). Change subject: IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int6

[Impala-ASF-CR] IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s

2024-07-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 ) Change subject: IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s .. Patch Set 6: FYI the toolchai

[Impala-ASF-CR] IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s

2024-07-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 ) Change subject: IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s .. Patch Set 5: (1 comment) htt

[Impala-ASF-CR] IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s

2024-07-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Kurt Deschler, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21557 to look at the new patch set (#6). Change subject: IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int6

[Impala-ASF-CR] IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s

2024-07-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Kurt Deschler, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21557 to look at the new patch set (#5). Change subject: IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int6

[Impala-ASF-CR] IMPALA-13194: Fast-serialize position delete records

2024-07-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21563 Change subject: IMPALA-13194: Fast-serialize position delete records .. IMPALA-13194: Fast-serialize position delete records Curren

[native-toolchain-CR] IMPALA-13190: Allow passing const Atomic(T)* to LOAD operations

2024-07-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21562 Change subject: IMPALA-13190: Allow passing const _Atomic(T)* to LOAD operations .. IMPALA-13190: Allow passing const _Atomic(T)* to

[Impala-ASF-CR] IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s

2024-07-01 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 ) Change subject: IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s .. Patch Set 4: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s

2024-07-01 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 ) Change subject: IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s .. Patch Set 3: (1 comment) PS3 is squashed w

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-07-01 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21435 ) Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder .. Patch Set 9: (1 comment) > Patc

[Impala-ASF-CR] IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s

2024-07-01 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Kurt Deschler, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21557 to look at the new patch set (#4). Change subject: IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s ...

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-07-01 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has abandoned this change. ( http://gerrit.cloudera.org:8080/21435 ) Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder .. Abandoned Abandoning in favor of https://

[Impala-ASF-CR] IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s

2024-07-01 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Kurt Deschler, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21557 to look at the new patch set (#3). Change subject: IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s ...

[Impala-ASF-CR] IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s

2024-06-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 ) Change subject: IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s .. Patch Set 2: (8 comments) Clang-tidy faile

[Impala-ASF-CR] IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s

2024-06-28 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Kurt Deschler, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21557 to look at the new patch set (#2). Change subject: IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s ...

[Impala-ASF-CR] IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s

2024-06-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21557 Change subject: IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s .. IMPALA-13088: Use RoaringBitmap instead of so

[Impala-ASF-CR] IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder

2024-06-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has abandoned this change. ( http://gerrit.cloudera.org:8080/21452 ) Change subject: IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder .. Abandoned Abandoning this change as with Roaring

[Impala-ASF-CR] IMPALA-13168: Add README file for setting up Trino

2024-06-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21538 ) Change subject: IMPALA-13168: Add README file for setting up Trino .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR](asf-site) Update download links for release 3.4.2

2024-06-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21534 ) Change subject: Update download links for release 3.4.2 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-13168: Add README file for setting up Trino

2024-06-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21538 ) Change subject: IMPALA-13168: Add README file for setting up Trino .. Patch Set 2: Code-Review+2 Thanks for adding this README -

[Impala-ASF-CR](asf-site) Add 3.4.2 change log

2024-06-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21535 ) Change subject: Add 3.4.2 change log .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21535 To uns

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-06-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21435 ) Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder .. Patch Set 9: (2 comments) http:

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-06-19 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21435 to look at the new patch set (#9). Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

[Impala-ASF-CR] IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder

2024-06-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21452 to look at the new patch set (#9). Change subject: IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder ...

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-06-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21435 to look at the new patch set (#8). Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

[Impala-ASF-CR] IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder

2024-06-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21452 to look at the new patch set (#8). Change subject: IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder ...

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-06-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21435 to look at the new patch set (#7). Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

[Impala-ASF-CR] IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder

2024-06-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21452 ) Change subject: IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder .. Patch Set 5: (2 comments) http://gerri

[Impala-ASF-CR] IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder

2024-06-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21452 to look at the new patch set (#7). Change subject: IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder ...

[Impala-ASF-CR] IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder

2024-06-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21452 ) Change subject: IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder .. Patch Set 6: (6 comments) Thanks for t

[Impala-ASF-CR] IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder

2024-06-17 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21452 to look at the new patch set (#6). Change subject: IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder ...

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-06-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21435 ) Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder .. Patch Set 6: (3 comments) Thank

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-06-17 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21435 to look at the new patch set (#6). Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-06-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21435 ) Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder .. Patch Set 5: (9 comments) Thank

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-06-17 Thread Zoltan Borok-Nagy (Code Review)
Hello Daniel Becker, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21435 to look at the new patch set (#5). Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

  1   2   3   4   5   6   7   8   9   10   >