[Impala-ASF-CR] IMPALA-5428: update external hadoop ecosystem versions

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5428: update external hadoop ecosystem versions .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7076 To

[Impala-ASF-CR] IMPALA-5316: Adds last day() function

2017-06-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5316: Adds last_day() function .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6991/4/be/src/exprs/timestamp-functions.h File

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-05 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7063/4/be/src/rpc/thrift-util.cc

[Impala-ASF-CR] IMPALA-4107: [DOCS] APPX MEDIAN cuts string to 10 chars

2017-06-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4107: [DOCS] APPX_MEDIAN cuts string to 10 chars .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7094/2/docs/topics/impala_appx_median.xml

[Impala-ASF-CR] IMPALA-4107: [DOCS] APPX MEDIAN cuts string to 10 chars

2017-06-05 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-4107: [DOCS] APPX_MEDIAN cuts string to 10 chars .. IMPALA-4107: [DOCS] APPX_MEDIAN cuts string to 10 chars In the "Restrictions" section of the "APPX_MEDIAN

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-05 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7063/4/be/src/rpc/thrift-util.cc

[Impala-ASF-CR] Bump Kudu version for 1.4.0-RC1

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version for 1.4.0-RC1 .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/687/ -- To view, visit

[Impala-ASF-CR] IMPALA-4107 [DOCS] APPX MEDIAN cuts string to 10 chars

2017-06-05 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars .. Patch Set 1: The reporter (Peter Brejcak) does not come up as an option to add as a reviewer. -- To

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7063/4/be/src/rpc/thrift-util.cc File

[Impala-ASF-CR] IMPALA-4107 [DOCS] APPX MEDIAN cuts string to 10 chars

2017-06-05 Thread Laurel Hale (Code Review)
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/7094 Change subject: IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars .. IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars In the

[Impala-ASF-CR] IMPALA-5031: Remove undefined behavior "reference binding to null"

2017-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5031: Remove undefined behavior "reference binding to null" .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-1575: Yield admission control resources at query end

2017-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1575: Yield admission control resources at query end .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7079/1/be/src/runtime/coordinator.cc

[Impala-ASF-CR] IMPALA-5355: Fix the order of Sentry roles and privileges

2017-06-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5355: Fix the order of Sentry roles and privileges .. Patch Set 4: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5357: Fix unixtime to UTC TimestampValue perf

2017-06-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5357: Fix unixtime to UTC TimestampValue perf .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7082 To unsubscribe,

[Impala-ASF-CR] IMPALA-5357: Fix unixtime to UTC TimestampValue perf

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5357: Fix unixtime to UTC TimestampValue perf .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/686/ -- To

[Impala-ASF-CR] IMPALA-5357: Fix unixtime to UTC TimestampValue perf

2017-06-05 Thread Matthew Jacobs (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7082 to look at the new patch set (#2). Change subject: IMPALA-5357: Fix unixtime to UTC TimestampValue perf ..

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7063/4//COMMIT_MSG Commit Message:

[Impala-ASF-CR] Bump toolchain patch versions: boost, crcutil, breakpad

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Bump toolchain patch versions: boost, crcutil, breakpad .. Bump toolchain patch versions: boost, crcutil, breakpad Several toolchain commits

[Impala-ASF-CR] Bump toolchain patch versions: boost, crcutil, breakpad

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump toolchain patch versions: boost, crcutil, breakpad .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7085 To

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-05 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 4: (8 comments) Thanks for the tests, I think this looks a lot better.

[Impala-ASF-CR] IMPALA-5420: Skip ACL fetch if the acl bit is not set.

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5420: Skip ACL fetch if the acl bit is not set. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7071 To

[Impala-ASF-CR] IMPALA-5420: Skip ACL fetch if the acl bit is not set.

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5420: Skip ACL fetch if the acl bit is not set. .. IMPALA-5420: Skip ACL fetch if the acl bit is not set. Helps avoiding an RPC to NN

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 4: Added some EE tests for the exception cases in PS4. -- To view, visit

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-05 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. IMPALA-5388: Only retry RPC on lost connection in send call Previously, DoRpc() blacklists only a

[Impala-ASF-CR] IMPALA-1575: Yield admission control resources at query end

2017-06-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1575: Yield admission control resources at query end .. Patch Set 1: (7 comments) I think there were going to be some functional tests?

[Impala-ASF-CR] IMPALA-5137: [DOCS] Document TIMESTAMP for Kudu tables

2017-06-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: [DOCS] Document TIMESTAMP for Kudu tables .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7035/2/docs/shared/impala_common.xml

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit .. IMPALA-5433: Mark single-argument Status c'tors as explicit Avoid unexpected

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7077 To

[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.

2017-06-05 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. IMPALA-5438: Always eval union const exprs in subplan. The bug was that the constant exprs of a union were

[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.

2017-06-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5428: update external hadoop ecosystem versions

2017-06-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5428: update external hadoop ecosystem versions .. Patch Set 2: Code-Review+2 gvo failed because it needed to be rebased -- To view, visit

[Impala-ASF-CR] IMPALA-5428: update external hadoop ecosystem versions

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5428: update external hadoop ecosystem versions .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/685/ --

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7081 To

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. IMPALA-5347: reduce codegen overhead of timestamp trunc() Trunc has many

[Impala-ASF-CR] IMPALA-5363: Reset probe batch after reaching limit

2017-06-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5363: Reset probe_batch_ after reaching limit .. Patch Set 6: Code-Review+2 Carrying the +2 from Dan. -- To view, visit

[Impala-ASF-CR] IMPALA-5363: Reset probe batch after reaching limit

2017-06-05 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. Change subject: IMPALA-5363: Reset probe_batch_ after reaching limit .. IMPALA-5363: Reset probe_batch_ after reaching limit For every new iteration of a subplan there

[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.

2017-06-05 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 3: (2 comments) Will update the patch with new tests.

[Impala-ASF-CR] IMPALA-5428: update external hadoop ecosystem versions

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5428: update external hadoop ecosystem versions .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5355: Fix the order of Sentry roles and privileges

2017-06-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5355: Fix the order of Sentry roles and privileges .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7004 To unsubscribe,

[Impala-ASF-CR] IMPALA-5355: Fix the order of Sentry roles and privileges

2017-06-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5355: Fix the order of Sentry roles and privileges .. IMPALA-5355: Fix the order of Sentry roles and privileges After a single Impalad is restarted, it

[Impala-ASF-CR] IMPALA-5355: Fix the order of Sentry roles and privileges

2017-06-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5355: Fix the order of Sentry roles and privileges .. IMPALA-5355: Fix the order of Sentry roles and privileges After a single Impalad is restarted, it

[Impala-ASF-CR] IMPALA-5355: Fix the order of Sentry roles and privileges

2017-06-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5355: Fix the order of Sentry roles and privileges .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.

2017-06-05 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/7091 Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. IMPALA-5438: Always eval union const exprs in subplan. The bug

[Impala-ASF-CR] IMPALA-5357: Fix unixtime to UTC TimestampValue perf

2017-06-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5357: Fix unixtime to UTC TimestampValue perf .. Patch Set 1: (2 comments) thanks for the review. I'll get this in once the boost version bump makes it

[Impala-ASF-CR] Bump toolchain patch versions: boost, crcutil, breakpad

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump toolchain patch versions: boost, crcutil, breakpad .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/684/ --

[Impala-ASF-CR] IMPALA-5282: Handle overflows in computeResourceProfile().

2017-06-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Bump toolchain patch versions: boost, crcutil, breakpad

2017-06-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Bump toolchain patch versions: boost, crcutil, breakpad .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7085 To unsubscribe,

[Impala-ASF-CR] IMPALA-5394: Set socket timeouts while opening TSaslTransport

2017-06-05 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. IMPALA-4965: Authorize access to runtime profile and exec summary Bug: When

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. IMPALA-4965: Authorize access to runtime profile and exec summary Bug: When

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 1: (12 comments)

[Impala-ASF-CR] IMPALA-5394: Set socket timeouts while opening TSaslTransport

2017-06-05 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5394: Set socket timeouts while opening TSaslTransport

2017-06-05 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5282: Handle overflows in computeResourceProfile().

2017-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). .. Patch Set 1: (1 comment)

[native-toolchain-CR] Bump Kudu version to 1.4.0-RC1

2017-06-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 1.4.0-RC1 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7087 To unsubscribe, visit

[native-toolchain-CR] Bump Kudu version to 1.4.0-RC1

2017-06-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: Bump Kudu version to 1.4.0-RC1 .. Bump Kudu version to 1.4.0-RC1 Change-Id: I0c1f07147a600610526fd870b04d7ff1faa0fbaf --- M buildall.sh 1 file

[native-toolchain-CR] Bump Kudu version to 1.4.0-RC1

2017-06-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Bump Kudu version to 1.4.0-RC1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7087 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5394: Set socket timeouts while opening TSaslTransport

2017-06-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5355: Fix the order of Sentry roles and privileges

2017-06-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5355: Fix the order of Sentry roles and privileges .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-5394: Set socket timeouts while opening TSaslTransport

2017-06-05 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5420: Skip ACL fetch if the acl bit is not set.

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5420: Skip ACL fetch if the acl bit is not set. .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/683/ --

[Impala-ASF-CR] IMPALA-5420: Skip ACL fetch if the acl bit is not set.

2017-06-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5420: Skip ACL fetch if the acl bit is not set. .. Patch Set 2: Code-Review+2 Carrying +2. -- To view, visit

[Impala-ASF-CR] IMPALA-4850 [DOCS] Create table "comment comes after "partioned by"

2017-06-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4850 [DOCS] Create table "comment comes after "partioned by" .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5420: Skip ACL fetch if the acl bit is not set.

2017-06-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5420: Skip ACL fetch if the acl bit is not set. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7071 To

[Impala-ASF-CR] IMPALA-5363: Reset probe batch after reaching limit

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5363: Reset probe_batch_ after reaching limit .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7014 To unsubscribe,

[Impala-ASF-CR] IMPALA-5282: Handle overflows in computeResourceProfile().

2017-06-05 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). .. IMPALA-5282: Handle overflows in computeResourceProfile(). An overflow in computeResourceProfile() could

[Impala-ASF-CR] IMPALA-3267 [DOCS] Docs about nan/inf are incorrect

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3267 [DOCS] Docs about nan/inf are incorrect .. IMPALA-3267 [DOCS] Docs about nan/inf are incorrect Switched the example for Infinity

[Impala-ASF-CR] IMPALA-3267 [DOCS] Docs about nan/inf are incorrect

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3267 [DOCS] Docs about nan/inf are incorrect .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7083 To unsubscribe,

[Impala-ASF-CR] IMPALA-5282: Handle overflows in computeResourceProfile().

2017-06-05 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). .. IMPALA-5282: Handle overflows in computeResourceProfile(). An overflow in computeResourceProfile() could

[Impala-ASF-CR] IMPALA-5282: Handle overflows in computeResourceProfile().

2017-06-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-3267 [DOCS] Docs about nan/inf are incorrect

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3267 [DOCS] Docs about nan/inf are incorrect .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/126/ -- To

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-06-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/5483/18/be/src/exec/partitioned-aggregation-node.cc

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/682/

[native-toolchain-CR] Bump Kudu version to 1.4.0-RC1

2017-06-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7087 Change subject: Bump Kudu version to 1.4.0-RC1 .. Bump Kudu version to 1.4.0-RC1 Change-Id: I0c1f07147a600610526fd870b04d7ff1faa0fbaf

[Impala-ASF-CR] IMPALA-5282: Handle overflows in computeResourceProfile().

2017-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). .. Patch Set 1: (2 comments)

[Impala-ASF-CR] Bump toolchain patch versions: boost, crcutil, breakpad

2017-06-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7085 Change subject: Bump toolchain patch versions: boost, crcutil, breakpad .. Bump toolchain patch versions: boost, crcutil, breakpad

[Impala-ASF-CR] IMPALA-5355: Fix the order of Sentry roles and privileges

2017-06-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5355: Fix the order of Sentry roles and privileges .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-5355: Fix the order of Sentry roles and privileges

2017-06-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5355: Fix the order of Sentry roles and privileges .. IMPALA-5355: Fix the order of Sentry roles and privileges After a single Impalad is restarted, it

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5355: Fix the order of Sentry roles and privileges

2017-06-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5355: Fix the order of Sentry roles and privileges .. IMPALA-5355: Fix the order of Sentry roles and privileges After a single Impalad is restarted, it

[Impala-ASF-CR] IMPALA-3267 [DOCS] Docs about nan/inf are incorrect

2017-06-05 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3267 [DOCS] Docs about nan/inf are incorrect .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7083 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5282: Handle overflows in computeResourceProfile().

2017-06-05 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/7084 Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). .. IMPALA-5282: Handle overflows in computeResourceProfile().

[Impala-ASF-CR] IMPALA-3267 [DOCS] Docs about nan/inf are incorrect

2017-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: IMPALA-3267 [DOCS] Docs about nan/inf are incorrect .. Patch Set 1: Code-Review+1 lgtm, but I'm not a committer, so you'll need a +2 from someone else -- To

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-05 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7063/3/be/src/rpc/thrift-util.cc File

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#5). Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 This change fixes the frontend tests to make them run on Java 8,

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-05 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 3: Right - my reading of the Thrift code is that if there's a partial write followed

[Impala-ASF-CR] IMPALA-5428: update external hadoop ecosystem versions

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5428: update external hadoop ecosystem versions .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/681/ --

[Impala-ASF-CR] IMPALA-5426: Update Hive schema script to 1.1.0

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5426: Update Hive schema script to 1.1.0 .. IMPALA-5426: Update Hive schema script to 1.1.0 A recent update to Hive changed its schema,

[Impala-ASF-CR] IMPALA-5426: Update Hive schema script to 1.1.0

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5426: Update Hive schema script to 1.1.0 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7072 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5394: Set socket timeouts while opening TSaslTransport

2017-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport .. Patch Set 2: Code-Review+1 Thanks John! This LGTM. I would still like someone else to have a

[Impala-ASF-CR] PREVIEW: IMPALA-4674: port backend exec to use buffer pool

2017-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#15). Change subject: PREVIEW: IMPALA-4674: port backend exec to use buffer pool .. PREVIEW: IMPALA-4674: port backend exec to use buffer pool Always create global BufferPool at

[Impala-ASF-CR] PREVIEW: IMPALA-4674: port backend exec to use buffer pool

2017-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#14). Change subject: PREVIEW: IMPALA-4674: port backend exec to use buffer pool .. PREVIEW: IMPALA-4674: port backend exec to use buffer pool Always create global BufferPool at

[Impala-ASF-CR] IMPALA-5085: large rows in BufferedTupleStreamV2

2017-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2 .. IMPALA-5085: large rows in BufferedTupleStreamV2 The stream defaults to pages of default_page_len_. If a row

[Impala-ASF-CR] IMPALA-5394: Set socket timeouts while opening TSaslTransport

2017-06-05 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport .. Patch Set 2: I was able to get my test environment properly setup for running the run-all.sh

[Impala-ASF-CR] IMPALA-3267 [DOCS] Docs about nan/inf are incorrect

2017-06-05 Thread Laurel Hale (Code Review)
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/7083 Change subject: IMPALA-3267 [DOCS] Docs about nan/inf are incorrect .. IMPALA-3267 [DOCS] Docs about nan/inf are incorrect Switched the

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-06-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 16: (61 comments) http://gerrit.cloudera.org:8080/#/c/5483/16/be/src/exec/aggregation-node.cc File

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/680/ --

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/7081 To

  1   2   >