Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4039: Increase width of Operator column in runtime
profile
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7691
To
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4039: Increase width of Operator column in runtime
profile
..
IMPALA-4039: Increase width of Operator column in runtime profile
This
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 15:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1084/
--
To view,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 15: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7253
To unsubscribe,
Taras Bobrovytsky has uploaded a new patch set (#5).
Change subject: MPALA-5776: Write partial tuple to the correct mempool
..
MPALA-5776: Write partial tuple to the correct mempool
In the text scanner, we were writing the
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7639
to look at the new patch set (#5).
Change subject: MPALA-5776: Write partial tuple to the correct mempool
..
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-5776: Write partial tuple to the correct mempool
..
Patch Set 4:
(5 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5681: release reservation from blocking operators
..
Patch Set 8: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7619
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5681: release reservation from blocking operators
..
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1083/
--
To
Hello Thomas Tauber-Marshall, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7619
to look at the new patch set (#8).
Change subject: IMPALA-5681: release reservation from blocking operators
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4669: [KRPC] Import RPC library from kudu@314c9d8
..
IMPALA-4669: [KRPC] Import RPC library from kudu@314c9d8
Change-Id:
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4669: [KRPC] Import RPC library from kudu@314c9d8
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5718
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types
..
Patch Set 17: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/7526
To
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types
..
IMPALA-3931: arbitrary fixed-size uda intermediate types
Make many builtin aggregate
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types
..
Patch Set 17: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7526
To
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
IMPALA-5327: Handle return of JNI GetStringUTFChar
GetStringUTFChars may return NULL or
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7642
To unsubscribe,
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
IMPALA-5800: Configure Squeasel's cipher suite and TLS version
* Import
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7679
To
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5573: Add decimal codegen in text scanner
..
Patch Set 8:
After these code re-spawning and inconsistency I decide to run a full test
first.
--
To view,
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4039: Increase width of Operator column in runtime
profile
..
Patch Set 3:
Build started:
Lars Volker has posted comments on this change.
Change subject: IMPALA-4039: Increase width of Operator column in runtime
profile
..
Patch Set 3: Code-Review+2
Thank you for fixing this!
--
To view, visit
Tianyi Wang has uploaded a new patch set (#3).
Change subject: IMPALA-4039: Increase width of Operator column in runtime
profile
..
IMPALA-4039: Increase width of Operator column in runtime profile
This patch changes the
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5573: Add decimal codegen in text scanner
..
Patch Set 8: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1081/
--
anujphadke has posted comments on this change.
Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and
compression codec
..
Patch Set 6:
(3 comments)
Thomas Tauber-Marshall has posted comments on this change.
Change subject: Bump Kudu version to b198ed8
..
Patch Set 1:
> corresponding Impala change?
This was included in the toolchain bump Lars did:
Bikramjeet Vig has uploaded a new patch set (#4).
Change subject: IMPALA-5602: Fix query optimization for kudu and datasource
tables
..
IMPALA-5602: Fix query optimization for kudu and datasource tables
Fix a bug where the
anujphadke has uploaded a new patch set (#6).
Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and
compression codec
..
IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec
If
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to b198ed8
..
Patch Set 1:
corresponding Impala change?
--
To view, visit http://gerrit.cloudera.org:8080/7665
To unsubscribe, visit
Michael Ho has posted comments on this change.
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
Patch Set 12: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5719/12//COMMIT_MSG
Commit
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5644: Reject queries if min reservation is too large
..
Patch Set 4: Code-Review+1
Carrying Tim's +1
--
To view, visit
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7678
to look at the new patch set (#4).
Change subject: IMPALA-5644: Reject queries if min reservation is too large
..
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5644: Reject queries if min reservation is too large
..
Patch Set 2:
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5644: Reject queries if min reservation is too large
..
Patch Set 3:
(2 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
..
Patch Set 6:
FWIW (and this is veering away from an Apache discussion), I thought
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
..
Patch Set 6:
Right, I think if I was starting from scratch I'd do something closer to
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7253/14/be/src/runtime/exec-env.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
..
Patch Set 6:
> So just to recap, does it work as the immediate solution if I:
> * Convert
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-4039: Increase width of Operator column in runtime
profile
..
Patch Set 2:
> > > Did you have a look at this comment in the JIRA?
> > >
> > > > Whoever
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
..
Patch Set 6:
(2 comments)
> So just to recap, does it work as the immediate solution
Tianyi Wang has uploaded a new patch set (#2).
Change subject: IMPALA-4039: Increase width of Operator column in runtime
profile
..
IMPALA-4039: Increase width of Operator column in runtime profile
This patch changes the
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5644: Reject queries if min reservation is too large
..
Patch Set 3: Code-Review+1
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
..
Patch Set 6:
So just to recap, does it work as the immediate solution if I:
* Convert
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5573: Add decimal codegen in text scanner
..
Patch Set 8: Code-Review+2
No problem
--
To view, visit http://gerrit.cloudera.org:8080/7683
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5573: Add decimal codegen in text scanner
..
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1081/
--
To view,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5677: limit clean page memory consumption
..
Patch Set 4: Code-Review+2
carry
--
To view, visit http://gerrit.cloudera.org:8080/7653
To unsubscribe,
Lars Volker has posted comments on this change.
Change subject: IMPALA-4039: Increase width of Operator column in runtime
profile
..
Patch Set 1:
> > Did you have a look at this comment in the JIRA?
> >
> > > Whoever
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7653
to look at the new patch set (#4).
Change subject: IMPALA-5677: limit clean page memory consumption
..
IMPALA-5677:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5677: limit clean page memory consumption
..
Patch Set 3:
(1 comment)
expanded the unit test to test different limits on clean pages.
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5573: Add decimal codegen in text scanner
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7683/7/be/src/runtime/decimal-value.h
File
Hello Impala Public Jenkins, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7683
to look at the new patch set (#8).
Change subject: IMPALA-5573: Add decimal codegen in text scanner
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5573: Add decimal codegen in text scanner
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7683/7/be/src/runtime/decimal-value.h
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7253/14/be/src/runtime/exec-env.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7253/14/be/src/runtime/exec-env.cc
File
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-4039: Increase width of Operator column in runtime
profile
..
Patch Set 1:
> Did you have a look at this comment in the JIRA?
>
> > Whoever implements
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 14: Code-Review+2
(1 comment)
Seems okay to me, though maybe we could improve the name of
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5573: Add decimal codegen in text scanner
..
Patch Set 7:
GCC implicitly converted nullptr to string then to Status.
--
To view, visit
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew
..
IMPALA-4794: Grouping distinct agg plan robust to data skew
This patch changes
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7643
To
Hello Impala Public Jenkins, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7683
to look at the new patch set (#7).
Change subject: IMPALA-5573: Add decimal codegen in text scanner
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4669: [KRPC] Import RPC library from kudu@314c9d8
..
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1080/
--
Matthew Jacobs has uploaded a new patch set (#3).
Change subject: IMPALA-5644: Reject queries if min reservation is too large
..
IMPALA-5644: Reject queries if min reservation is too large
Rejects queries during admission
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5644: Reject queries if min reservation is too large
..
Patch Set 2:
(4 comments)
Lars Volker has posted comments on this change.
Change subject: IMPALA-4039: Increase width of Operator column in runtime
profile
..
Patch Set 1:
Did you have a look at this comment in the JIRA?
> Whoever implements this
Michael Ho has posted comments on this change.
Change subject: IMPALA-4669: [KRPC] Import RPC library from kudu@314c9d8
..
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5718
To unsubscribe,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
..
Patch Set 6:
I think this change is a bit of a wart, but I also think I've come around to
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5677: limit clean page memory consumption
..
Patch Set 3: Code-Review+2
(1 comment)
Looks good, please decide whether the explicit edge case test is
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5573: Add decimal codegen in text scanner
..
Patch Set 6: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1075/
--
Tianyi Wang has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7691
Change subject: IMPALA-4039: Increase width of Operator column in runtime
profile
..
IMPALA-4039: Increase width of Operator column in
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
..
Patch Set 6:
(2 comments)
We could rework the MemTracker so that more of the logic was
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
..
Patch Set 3: Code-Review+1
(3 comments)
Thanks - this seems a lot better to me.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 14:
It would be good if someone could take a quick look at the PS13->14 delta to
make sure that the
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 13:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1073/
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5644: Reject queries if min reservation is too large
..
Patch Set 1:
(5 comments)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
..
Patch Set 6:
(1 comment)
The more I think about this, the more I think it's a shame
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types
..
Patch Set 17:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1078/
--
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types
..
Patch Set 16: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7526
To unsubscribe,
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1077/
--
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
Patch Set 12: Code-Review+2
(1 comment)
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
Patch Set 11:
> (1 comment)
web browser
--
To view, visit http://gerrit.cloudera.org:8080/7642
To
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7642/11/be/src/util/logging-support.cc
File
Hello Impala Public Jenkins, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7642
to look at the new patch set (#12).
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
Patch Set 12:
This patch builds on all platforms we test on here at Cloudera.
--
To view, visit
Henry Robinson has uploaded a new patch set (#12).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
IMPALA-4669: [KRPC] Add kudu_rpc library to build
Import FindKRPC.cmake from Apache Kudu.
One minor
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7642/11/be/src/util/logging-support.cc
File
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
..
Patch Set 11:
> This failed in
>
Hello Impala Public Jenkins, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7642
to look at the new patch set (#11).
Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5677: limit clean page memory consumption
..
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/7653/1//COMMIT_MSG
Commit Message:
Line 34:
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-5677: limit clean page memory consumption
..
IMPALA-5677: limit clean page memory consumption
Adds the following flag:
-buffer_pool_clean_pages_limit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
Patch Set 3: Code-Review+2
I feel pretty ok giving this a +2 myself, as the Impala-side
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1076/
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
Patch Set 3: Code-Review+1
(2 comments)
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
IMPALA-5800: Configure Squeasel's cipher suite and TLS version
* Import Squeasel as of
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7679/1//COMMIT_MSG
Commit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5573: Add decimal codegen in text scanner
..
Patch Set 6:
Also, for reference, I think the existing test coverage for this code path is
adequate - we
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3208: max_row_size option
..
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7629/8//COMMIT_MSG
Commit Message:
Line 9: This is a preview
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3208: max_row_size option
..
Patch Set 8:
(1 comment)
I wasn't planning to add extra tests at this stage. I will try to tweak the
current tests so they
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5573: Add decimal codegen in text scanner
..
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1075/
--
To view,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3208: max_row_size option
..
Patch Set 8:
Does this one have all the tests yet, or do you plan to add more still?
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5573: Add decimal codegen in text scanner
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7683
To unsubscribe, visit
1 - 100 of 163 matches
Mail list logo
