Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 19: Code-Review+2
(9 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-1575: Yield admission control resources at query end
..
Patch Set 1:
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-1575: Yield admission control resources at query end
..
Patch Set 1:
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc()
..
Patch Set 2: Code-Review+2
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5357: Fix unixtime to UTC TimestampValue perf
..
Patch Set 1: Code-Review+2
(2 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4965: Authorize access to runtime profile and exec
summary
..
Patch Set 1:
> The description in the JIRA asks for a redacted profile. I pinged
> the
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 17:
please fix the pervasive non-const vector& or switch to vector* and explain why
it can get
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 17:
(62 comments)
http://gerrit.cloudera.org:8080/#/c/5483/16/be/src/exec/aggregation-node.cc
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4965: Authorize access to runtime profile and exec
summary
..
Patch Set 1:
Alex and I just discussed this: the simplest approach would be to refuse
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5384: Simplify coordinator locking protocol
..
Patch Set 2:
This passes the pre-commit tests.
--
To view, visit http://gerrit.cloudera.org:8080/7065
Marcel Kornacker has uploaded a new patch set (#2).
Change subject: IMPALA-5384: Simplify coordinator locking protocol
..
IMPALA-5384: Simplify coordinator locking protocol
This changes the locking behavior of the coordinator
Marcel Kornacker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7065
Change subject: IMPALA-5384: Simplify coordinator locking protocol
..
IMPALA-5384: Simplify coordinator locking protocol
This
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5381: Adds DEFAULT_JOIN_STRATEGY query option.
..
Patch Set 1: Code-Review+2
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5338: Fix Kudu timestamp column default values
..
Patch Set 4: Code-Review+2
(2 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7033
To unsubscribe,
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS
..
Patch Set 1:
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS
..
Patch Set 1:
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS
..
Patch Set 1:
> (2 comments)
>
> > (2 comments)
> >
> > questions:
> > - what about insert
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS
..
Patch Set 1:
(2 comments)
questions:
- what about insert staging for adls (in coordinator.cc?
-
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5164: Fix flaky benchmarks
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6935/5/be/src/benchmarks/free-lists-benchmark.cc
File
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5338: Fix Kudu timestamp column default values
..
Patch Set 2:
(9 comments)
could you also add tosql tests?
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 4:
> (1 comment)
>
> I think there would be some benefit in having ReleaseResources()
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6897
To unsubscribe,
Hello Henry Robinson, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6897
to look at the new patch set (#3).
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables.
..
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6840
To unsubscribe,
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 2:
> Will wait for final patch before signing off.
>
> What was the reason behind
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4623: Enable file handle cache
..
Patch Set 17:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6478/17/be/src/runtime/disk-io-mgr.h
File
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4623: Enable file handle cache
..
Patch Set 17: Code-Review+2
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6897/1/be/src/runtime/coordinator.h
Marcel Kornacker has uploaded a new patch set (#2).
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
IMPALA-4890/5143: Coordinator race involving TearDown()
TearDown() releases resources and destroys
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6897/1/be/src/runtime/coordinator.cc
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 1:
(1 comment)
> (2 comments)
>
> Where does ReleaseResources() get called for DML
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4623: Enable file handle cache
..
Patch Set 15:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/6478/15/be/src/runtime/disk-io-mgr-scan-range.cc
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables.
..
Patch Set 9:
(3 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5338: Fix Kudu timestamp column default values
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/6936/1//COMMIT_MSG
Commit Message:
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5347: Parquet scanner microoptimizations
..
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6950/8/be/src/exec/hdfs-parquet-scanner.cc
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs.
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6868
To
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4623: Enable file handle cache
..
Patch Set 11:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/6478/11/be/src/runtime/disk-io-mgr-scan-range.cc
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5144: Remove sortby() hint
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6885
To unsubscribe, visit
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5167: Reduce the number of Kudu clients created (BE)
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6792
To
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6897/1/be/src/runtime/coordinator.cc
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5167: Reduce the number of Kudu clients created (FE)
..
Patch Set 1:
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4623: Enable file handle cache
..
Patch Set 10:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/6478/8/be/src/runtime/disk-io-mgr-handle-cache.h
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs.
..
Patch Set 4:
(3 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 1:
This passed tests in both debug and release mode. I haven't run the stress test
yet.
Marcel Kornacker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6897
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
IMPALA-4890/5143: Coordinator race involving TearDown()
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs.
..
Patch Set 3:
(7 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4623: Enable file handle cache
..
Patch Set 8:
(16 comments)
http://gerrit.cloudera.org:8080/#/c/6478/8/be/src/runtime/disk-io-mgr-handle-cache.h
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables.
..
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/6840/1/common/thrift/JniCatalog.thrift
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu
..
Patch Set 4: Code-Review+2
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs.
..
Patch Set 1:
(14 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL
..
Patch Set 4: Code-Review+2
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5167: Reduce the number of Kudu clients created
..
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6792/5/be/src/runtime/exec-env.cc
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL
..
Patch Set 2:
(2 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL
..
Patch Set 2:
(2 comments)
preliminary comments
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu
..
Patch Set 3:
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4166: Add SORT BY sql clause
..
Patch Set 25: Code-Review+2
(4 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4623: Enable file handle cache
..
Patch Set 6:
(6 comments)
quick comments
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5036: Parquet count star optimization
..
Patch Set 1:
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4166: Add SORT BY sql clause
..
Patch Set 22:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/6495/22/common/thrift/JniCatalog.thrift
File
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5167: Reduce the number of Kudu clients created
..
Patch Set 3:
How about a rebase?
--
To view, visit http://gerrit.cloudera.org:8080/6792
To
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5294: Kudu INSERT partitioning fails with constants
..
Patch Set 2: Code-Review+2
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5294: Kudu INSERT partitioning fails with constants
..
Patch Set 1:
(2 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5036: Parquet count star optimization
..
Patch Set 1:
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP
..
Patch Set 7: Code-Review+2
(2 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 9:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5483/9/be/src/exec/aggregation-node.cc
File
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
Patch Set 14: Code-Review+2
fixing some 'unused results' warnings.
--
To view, visit
Hello Impala Public Jenkins, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6535
to look at the new patch set (#14).
Change subject: IMPALA-2550: Switch to per-query exec rpc
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 9:
(45 comments)
first half
http://gerrit.cloudera.org:8080/#/c/5483/7/be/src/exec/exec-node.h
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
Patch Set 13: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/6535
To unsubscribe,
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6535
to look at the new patch set (#13).
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
IMPALA-2550: Switch
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4623: Enable file handle cache
..
Patch Set 4:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/6478/4/be/src/runtime/disk-io-mgr.cc
File
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet
Statistics for remaining types
..
Patch Set 8:
(2 comments)
Marcel Kornacker has uploaded a new patch set (#12).
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
IMPALA-2550: Switch to per-query exec rpc
Coordinator:
- FragmentInstanceState -> BackendState, which in turn
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
Patch Set 11:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/6535/10/be/src/runtime/coordinator.cc
File
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4029: Reduce memory requirements for storing file
metadata
..
Patch Set 5:
(10 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4623: Enable file handle cache
..
Patch Set 4:
(18 comments)
looking good.
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP
..
Patch Set 6:
(9 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet
Statistics for remaining types
..
Patch Set 6:
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5120: Default to partitioned join when stats are missing
..
Patch Set 1: Code-Review+2
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet
Statistics for remaining types
..
Patch Set 6:
(10 comments)
getting close
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu
..
Patch Set 1:
(6 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu
..
Patch Set 1:
i'll take this.
--
To view, visit http://gerrit.cloudera.org:8080/6789
To
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP
..
Patch Set 5:
(2 comments)
done with the comments.
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP
..
Patch Set 5:
(4 comments)
quick feedback just for the tests.
Marcel Kornacker has uploaded a new patch set (#11).
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
IMPALA-2550: Switch to per-query exec rpc
Coordinator:
- FragmentInstanceState -> BackendState, which in turn
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
Patch Set 10:
(72 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables
..
Patch Set 7: Code-Review+2
(2 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables
..
Patch Set 5:
(22 comments)
http://gerrit.cloudera.org:8080/#/c/6559/5/be/src/exec/kudu-util.h
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet
Statistics for remaining types
..
Patch Set 4:
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC
..
Patch Set 5:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5888/3/be/src/runtime/data-stream-mgr.h
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet
Statistics for remaining types
..
Patch Set 4:
(21 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables
..
Patch Set 4:
(24 comments)
only looked at thrift and fe changes so far. let's discuss this in
Marcel Kornacker has uploaded a new patch set (#10).
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
IMPALA-2550: Switch to per-query exec rpc
Coordinator:
- FragmentInstanceState -> BackendState, which in turn
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
Patch Set 9:
(26 comments)
Marcel Kornacker has uploaded a new patch set (#9).
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
IMPALA-2550: Switch to per-query exec rpc
Coordinator:
- FragmentInstanceState -> BackendState, which in turn
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
Patch Set 8:
(22 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 7:
(25 comments)
some more comments. i haven't looked at the exec nodes in detail yet.
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5888/3/be/src/runtime/data-stream-mgr.h
File
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 7:
(31 comments)
initial comments
1 - 100 of 423 matches
Mail list logo
