[Impala-ASF-CR] IMPALA-4365: Enabling end-to-end tests on a remote cluster

2016-11-03 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#11). Change subject: IMPALA-4365: Enabling end-to-end tests on a remote cluster .. IMPALA-4365: Enabling end-to-end tests on a remote cluster This patch lays the groundwork for loading

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 5: +2 for FE, +1 for BE -- To view, visit http://gerrit.cloudera.org:8080/4849 To

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 5: Code-Review+1 Thanks. The timeout is clearer now. -- To view, visit

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2016-11-03 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/4944 Change subject: Initial commit of the blog section of the Impala ASF website. .. Initial commit of the blog section of the Impala ASF

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-03 Thread Matthew Jacobs (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4849 to look at the new patch set (#5). Change subject: IMPALA-3771: Expose kudu client timeout and set default ..

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4849/4/be/src/catalog/catalog.cc File

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 5: (1 comment) agreed w/ bharath. Types.thrift is not good place for

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4941 Change subject: IMPALA-4266: Java udf returning string can give incorrect results .. IMPALA-4266: Java udf returning string can give

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 5: Alex, I think we need to find a better place to add TBackendConfig.

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 5: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-4365: Enabling end-to-end tests on a remote cluster

2016-11-03 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4365: Enabling end-to-end tests on a remote cluster .. Patch Set 9: (8 comments) Addressed comments. Also removed another place in remote_data_load.py

[Impala-ASF-CR] IMPALA-4423: Correct but conservative implementation of Subquery.equals().

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4423: Correct but conservative implementation of Subquery.equals(). .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3676: Use clang as a static analysis tool .. IMPALA-3676: Use clang as a static analysis tool This patch adds a script to run clang-tidy over

[Impala-ASF-CR] IMPALA-4423: Correct but conservative implementation of Subquery.equals().

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4423: Correct but conservative implementation of Subquery.equals(). .. IMPALA-4423: Correct but conservative implementation of

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has uploaded a new patch set (#5). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. IMPALA-3552: Make incremental stats max serialized size configurable The fix

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4758 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4617 To

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. IMPALA-3983/IMPALA-3974: Delete function jar resources after load The Catalog

[Impala-ASF-CR] Add cryptography export control notice

2016-11-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: Add cryptography export control notice .. Add cryptography export control notice The ASF guidelines on crypto requires projects that use any form of asymmetric

[Impala-ASF-CR] Add cryptography export control notice

2016-11-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/4940 Change subject: Add cryptography export control notice .. Add cryptography export control notice The ASF guidelines on crypto requires

[Impala-ASF-CR] IMPALA-4412: Per operator timing in profile summary is incorrect when mt dop > 0

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4412: Per operator timing in profile summary is incorrect when mt_dop > 0 .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4342: Use sync ddl=1 for test udf errors

2016-11-03 Thread Alex Behm (Code Review)
Alex Behm has abandoned this change. Change subject: IMPALA-4342: Use sync_ddl=1 for test_udf_errors .. Abandoned Does not seem like the right fix. The underlying issue looks like http://issues.cloudera.org/browse/IMPALA-3888

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has uploaded a new patch set (#4). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. IMPALA-3552: Make incremental stats max serialized size configurable The fix

[Impala-ASF-CR] IMPALA-3838: Codegen EvalRuntimeFilters().

2016-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3838: Codegen EvalRuntimeFilters(). .. Patch Set 1: (13 comments) Did another more detailed pass.

[Impala-ASF-CR] IMPALA-3882: Simplify some query exec state locking

2016-11-03 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#4). Change subject: IMPALA-3882: Simplify some query exec state locking .. IMPALA-3882: Simplify some query exec state locking query_exec_state_map_lock_ is implicated in many

[Impala-ASF-CR] IMPALA-3882: Simplify some query exec state locking

2016-11-03 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4935 Change subject: IMPALA-3882: Simplify some query exec state locking .. IMPALA-3882: Simplify some query exec state locking

[Impala-ASF-CR] IMPALA-3853: More RAT cleaning.

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3853: More RAT cleaning. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4904 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3853: More RAT cleaning.

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3853: More RAT cleaning. .. IMPALA-3853: More RAT cleaning. Apache RAT is a tool to audit code repositories for the ASF copyright rules. Our

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts by default

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3710: Kudu DML should ignore conflicts by default .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4911/2/fe/src/main/cup/sql-parser.cup

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-03 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4047 to look at the new patch set (#17). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts by default

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-3710: Kudu DML should ignore conflicts by default .. IMPALA-3710: Kudu DML should ignore conflicts by default Removes the non-standard IGNORE syntax that

[Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking, follow up

2016-11-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4379: Fix and test Kudu table type checking, follow up .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4849/4/be/src/catalog/catalog.cc File

[Impala-ASF-CR] IMPALA-4384: NPE when cols list has trailing comma

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4384: NPE when cols list has trailing comma .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4869 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-03 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4936/3//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 8: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock .. IMPALA-4411: Kudu inserts violate lock ordering and could deadlock This fixes

[Impala-ASF-CR] Fix TPCH and TPCDS Kudu loading templates

2016-11-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has submitted this change and it was merged. Change subject: Fix TPCH and TPCDS Kudu loading templates .. Fix TPCH and TPCDS Kudu loading templates The templates (used by the stress test) for loading the TCPH

[Impala-ASF-CR] Fix TPCH and TPCDS Kudu loading templates

2016-11-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: Fix TPCH and TPCDS Kudu loading templates .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4939 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 4: Code-Review+1 Thanks. -- To view, visit http://gerrit.cloudera.org:8080/4849 To

[Impala-ASF-CR] Fix TPCH and TPCDS Kudu loading templates

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Fix TPCH and TPCDS Kudu loading templates .. Patch Set 1: Code-Review+2 Thanks! -- To view, visit http://gerrit.cloudera.org:8080/4939 To unsubscribe,

[Impala-ASF-CR] IMPALA-4365: Enabling end-to-end tests on a remote cluster

2016-11-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4365: Enabling end-to-end tests on a remote cluster .. Patch Set 9: (8 comments) http://gerrit.cloudera.org:8080/#/c/4769/9/bin/remote_data_load.py

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4936/3//COMMIT_MSG Commit Message: Line 20:

[Impala-ASF-CR] Fix TPCH and TPCDS Kudu loading templates

2016-11-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/4939 Change subject: Fix TPCH and TPCDS Kudu loading templates .. Fix TPCH and TPCDS Kudu loading templates The templates (used by the

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 4: I made the changes to address Lars' comments but I'll update the review after I get

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-4391: fix dropped statuses in scanners

2016-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4938 Change subject: IMPALA-4391: fix dropped statuses in scanners .. IMPALA-4391: fix dropped statuses in scanners As far as I'm aware we

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 16: (2 comments) The build is unblocked so you can try to get this in, but I think you'll have to

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4936 To unsubscribe,

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 2: (16 comments) http://gerrit.cloudera.org:8080/#/c/4867/2//COMMIT_MSG

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-03 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has uploaded a new patch set (#3). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. IMPALA-3552: Make incremental stats max serialized size configurable The fix

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-03 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 3: (2 comments) See patch set 3. http://gerrit.cloudera.org:8080/#/c/4936/2//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4409: respect lock order in QueryExecState::CancelInternal()

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4409: respect lock order in QueryExecState::CancelInternal() .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4896 To

[Impala-ASF-CR] IMPALA-4409: respect lock order in QueryExecState::CancelInternal()

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4409: respect lock order in QueryExecState::CancelInternal() .. IMPALA-4409: respect lock order in QueryExecState::CancelInternal() The code

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. IMPALA-4309: Introduce Expr rewrite phase and supporting classes. Introduces a

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4746 To

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4936/2//COMMIT_MSG Commit Message: What

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-03 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 2: (2 comments) Thanks. See patch set 2.

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-03 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#2). Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required This patch now requires users of the Leopard

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 8: Code-Review+2 Fix test issue. Rebase and carry Alex's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-03 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/4936 Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required This

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: Code-Review+2 I see, thanks. (Maybe the second case is easier to reproduce by writing

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-03 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: > Please see https://issues.cloudera.org/browse/IMPALA-4371 It seems that Gerrit

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-03 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: > Oh, oops, I wasn't noticing this was the writier. In that case, > why are these

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-03 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: > Do you have access to the file to repro'ed this in the wild? And > given that

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-11-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 10: Code-Review+2 Giving GVO another shot. -- To view, visit

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-11-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool .. Patch Set 12: Code-Review+2 Carry Dan's +2 on this rebase -- To view, visit

[Impala-ASF-CR] IMPALA-4412: Per operator timing in profile summary is incorrect when mt dop > 0

2016-11-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: IMPALA-4412: Per operator timing in profile summary is incorrect when mt_dop > 0 .. Abandoned Messed up change-id's. New patch at: https://gerrit.cloudera.org/#/c/4933/

[Impala-ASF-CR] IMPALA-4412: Per operator timing in profile summary is incorrect when mt dop > 0

2016-11-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4412: Per operator timing in profile summary is incorrect when mt_dop > 0 .. Patch Set 1: Code-Review+2 Carry +2 from

[Impala-ASF-CR] IMPALA-4423: Correct but conservative implementation of Subquery.equals().

2016-11-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4423: Correct but conservative implementation of Subquery.equals(). .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4423: Correct but conservative implementation of Subquery.equals().

2016-11-03 Thread Alex Behm (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4923 to look at the new patch set (#3). Change subject: IMPALA-4423: Correct but conservative implementation of Subquery.equals().

[Impala-ASF-CR] IMPALA-4423: Correct but conservative implementation of Subquery.equals().

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4423: Correct but conservative implementation of Subquery.equals(). .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-03 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Abandoned Yeah that's weird - the Change-Id's in the wrong place. -- To view, visit

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4856 to look at the new patch set (#7). Change subject: IMPALA-3724: Support Kudu non-covering range partitions

[Impala-ASF-CR] IMPALA-4423: Correct but conservative implementation of Subquery.equals().

2016-11-03 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-4423: Correct but conservative implementation of Subquery.equals(). .. IMPALA-4423: Correct but conservative implementation of Subquery.equals(). The

[Impala-ASF-CR] IMPALA-4423: Correct but conservative implementation of Subquery.equals().

2016-11-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4423: Correct but conservative implementation of Subquery.equals(). .. Patch Set 1: (3 comments) Thanks for the quick CR!

[Impala-ASF-CR] IMPALA-4412: Per operator timing in profile summary is incorrect when mt dop > 0

2016-11-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4412: Per operator timing in profile summary is incorrect when mt_dop > 0 .. Patch Set 2: Code-Review+2 Carry +2. -- To view, visit

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 7: Code-Review+2 Fix minor data loading issue and rebase. Carry Alex's +2 -- To

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 1: Dup of https://gerrit.cloudera.org/#/c/4893/ ? -- To view, visit http://gerrit.cloudera.org:8080/4910

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/4863/6/be/src/exec/hdfs-table-sink.cc

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: Code-Review+2 > > Is it reasonably possible to create a file that demonstrates this >

[Impala-ASF-CR] IMPALA-4421: Send custom cluster & process failure test results to logs/

2016-11-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4421: Send custom cluster & process failure test results to logs/ .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 7: (1 comment) Thanks Tim, for the review. I pushed PS7, removing a DCHECK I had added -

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-03 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4863 to look at the new patch set (#7). Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input ..

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-03 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: > Is it reasonably possible to create a file that demonstrates this > and can be

[Impala-ASF-CR] IMPALA-3853: More RAT cleaning.

2016-11-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3853: More RAT cleaning. .. Patch Set 2: Code-Review+2 rebased, carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4904 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4384: NPE when cols list has trailing comma

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4384: NPE when cols list has trailing comma .. Patch Set 2: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4869 To

[Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock .. Patch Set 3: Code-Review+2 rebase -- To view, visit

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-03 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 5: Code-Review+1 rebase -- To view, visit

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 6: LGTM but I think it's a big enough change that we should have another pair of eyes on

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4863 To unsubscribe,

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3853: More RAT cleaning.

2016-11-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3853: More RAT cleaning. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4904 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 5: (4 comments) Thanks for the review, please see PS6.

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-03 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#6). Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. IMPALA-2523: Make HdfsTableSink aware of clustered input IMPALA-2521 introduced clustering for insert

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4849/4/be/src/exec/kudu-util.cc File

[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.

2016-11-03 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Add functional tests for compute stats with mt_dop > 0. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4879 To unsubscribe,

[Impala-ASF-CR] IMPALA-3853: More RAT cleaning.

2016-11-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3853: More RAT cleaning. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4904 To unsubscribe, visit

  1   2   >