[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-19 Thread Jun He (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5723 to look at the new patch set (#2). Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-19 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#6). Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc File

[kudu-CR] env util: Factor out helper DeleteExcessFilesByPattern()

2017-01-19 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5740 to look at the new patch set (#3). Change subject: env_util: Factor out helper DeleteExcessFilesByPattern() ..

[kudu-CR] env util: Factor out helper DeleteExcessFilesByPattern()

2017-01-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: env_util: Factor out helper DeleteExcessFilesByPattern() .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5740/2/src/kudu/util/env_util-test.cc

[kudu-CR] thirdparty: patch glog for better breakpad support

2017-01-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: thirdparty: patch glog for better breakpad support .. Patch Set 2: > Right, but for which signals? Just SIGABRT? AFAICT, glog handles > SIGSEGV, SIGILL, SIGFPE,

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc File

[kudu-CR] [util] fixed env-test on OS X

2017-01-19 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [util] fixed env-test on OS X .. [util] fixed env-test on OS X Prior to the fix, in some cases the uninitialized portion of 64-bit variable was non-zero

[kudu-CR] [util] fixed env-test on OS X

2017-01-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5738 To unsubscribe, visit

[kudu-CR] thirdparty: patch glog for better breakpad support

2017-01-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: thirdparty: patch glog for better breakpad support .. Patch Set 2: > > Still trying to wrap my head around who among breakpad and glog is > > responsible for

[kudu-CR] [util] fixed env-test on OS X

2017-01-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5738 to look at the new patch set (#5). Change subject: [util] fixed env-test on OS X .. [util] fixed env-test on OS X

[kudu-CR] thirdparty: patch glog for better breakpad support

2017-01-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: thirdparty: patch glog for better breakpad support .. Patch Set 2: > Still trying to wrap my head around who among breakpad and glog is > responsible for which

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

2017-01-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5741/2//COMMIT_MSG Commit Message: PS2,

[kudu-CR] [util] fixed env-test on OS X

2017-01-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5738 to look at the new patch set (#4). Change subject: [util] fixed env-test on OS X .. [util] fixed env-test on OS X

[kudu-CR] [util] fixed env-test on OS X

2017-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File

[kudu-CR] [util] fixed env-test on OS X

2017-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (2 comments) Thank you for the review. http://gerrit.cloudera.org:8080/#/c/5738/2//COMMIT_MSG Commit Message:

[kudu-CR] thirdparty: patch glog for better breakpad support

2017-01-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: thirdparty: patch glog for better breakpad support .. Patch Set 2: Code-Review+2 Still trying to wrap my head around who among breakpad and glog is responsible

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

2017-01-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5741/2//COMMIT_MSG Commit Message: PS2,

[kudu-CR] [util] fixed env-test on OS X

2017-01-19 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (2 comments) I am not seeing radio buttons on gerrit, perhaps some browser plugin issue I am facing at the moment,

[kudu-CR] env util: Factor out helper DeleteExcessFilesByPattern()

2017-01-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: env_util: Factor out helper DeleteExcessFilesByPattern() .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5740/2/src/kudu/util/env_util-test.cc

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5737/1/src/kudu/tablet/deltafile.cc

[kudu-CR] EMC: Don't reuse data dir for log dir

2017-01-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: EMC: Don't reuse data dir for log dir .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5619 To unsubscribe, visit

[kudu-CR] [security] interface for certificate signing service

2017-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] interface for certificate signing service .. Patch Set 3: Verified+1 Unrelevant test breakage: RaftConsensusITest.TestConfigChangeUnderLoad -- To

[kudu-CR] [util] fixed env-test on OS X

2017-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

2017-01-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Patch Set 2: Verified+1 Overriding flaky java test. -- To view, visit

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5737/1//COMMIT_MSG Commit Message: PS1, Line 10:

[kudu-CR] KUDU-1836. Enable compression of DeltaFiles

2017-01-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1836. Enable compression of DeltaFiles .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5737/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-19 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#5). Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad

[kudu-CR] EMC: Don't reuse data dir for log dir

2017-01-19 Thread Mike Percy (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5619 to look at the new patch set (#5). Change subject: EMC: Don't reuse data dir for log dir .. EMC:

[kudu-CR] EMC: Don't reuse data dir for log dir

2017-01-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: EMC: Don't reuse data dir for log dir .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5619/4//COMMIT_MSG Commit Message: PS4, Line 29: initialing

[kudu-CR] Add some path / env related helper functions

2017-01-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add some path / env related helper functions .. Patch Set 4: Verified+1 Yeah, spurious failure. -- To view, visit http://gerrit.cloudera.org:8080/5618 To

[kudu-CR] [util] fixed env-test on OS X

2017-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File

[kudu-CR] [util] fixed env-test on OS X

2017-01-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5738 to look at the new patch set (#3). Change subject: [util] fixed env-test on OS X .. [util] fixed env-test on OS X

[kudu-CR] [util] fixed env-test on OS X

2017-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File

[kudu-CR] [util] fixed env-test on OS X

2017-01-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc:

[kudu-CR] Add some path / env related helper functions

2017-01-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add some path / env related helper functions .. Patch Set 4: Code-Review+2 Test failure looks spurious. -- To view, visit http://gerrit.cloudera.org:8080/5618 To

[kudu-CR] docs: add notes for multi master migration

2017-01-19 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: docs: add notes for multi master migration .. docs: add notes for multi master migration Change-Id: I7e469bc23b650f3b99c785311acc665ac20f33ea Reviewed-on:

[kudu-CR] docs: add notes for multi master migration

2017-01-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: add notes for multi master migration .. Patch Set 4: Code-Review+2 Thanks for being patient. -- To view, visit http://gerrit.cloudera.org:8080/5728 To

[kudu-CR] docs: add notes for multi master migration

2017-01-19 Thread zhen.zhang (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5728 to look at the new patch set (#4). Change subject: docs: add notes for multi master migration .. docs: add notes

[kudu-CR] docs: add notes for multi master migration

2017-01-19 Thread zhen.zhang (Code Review)
zhen.zhang has posted comments on this change. Change subject: docs: add notes for multi master migration .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5728/3/docs/administration.adoc File

[kudu-CR] docs: add notes for multi master migration

2017-01-19 Thread zhen.zhang (Code Review)
zhen.zhang has posted comments on this change. Change subject: docs: add notes for multi master migration .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5728/3/docs/administration.adoc File

[kudu-CR] docs: add notes for multi master migration

2017-01-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: add notes for multi master migration .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5728/3/docs/administration.adoc File

[kudu-CR] docs: add notes for multi master migration

2017-01-19 Thread zhen.zhang (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5728 to look at the new patch set (#3). Change subject: docs: add notes for multi master migration .. docs: add notes

[kudu-CR] docs: add notes for multi master migration

2017-01-19 Thread zhen.zhang (Code Review)
zhen.zhang has posted comments on this change. Change subject: docs: add notes for multi master migration .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5728/2/docs/administration.adoc File

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-19 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: Based on

[kudu-CR] EMC: Don't reuse data dir for log dir

2017-01-19 Thread Mike Percy (Code Review)
Hello Dinesh Bhat, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5619 to look at the new patch set (#4). Change subject: EMC: Don't reuse data dir for log dir

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-19 Thread Mike Percy (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#4). Change subject: Add Google Breakpad support to Kudu .. Add Google

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

2017-01-19 Thread Mike Percy (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5741 to review the following change. Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Control

[kudu-CR] env util: Factor out helper DeleteExcessFilesByPattern()

2017-01-19 Thread Mike Percy (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5740 to review the following change. Change subject: env_util: Factor out helper DeleteExcessFilesByPattern() .. env_util:

[kudu-CR] Add some path / env related helper functions

2017-01-19 Thread Mike Percy (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5618 to look at the new patch set (#4). Change subject: Add some path / env related helper functions .. Add

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 3: (46 comments) http://gerrit.cloudera.org:8080/#/c/5620/3//COMMIT_MSG Commit Message: Line 7: Add Google

[kudu-CR] EMC: Don't reuse data dir for log dir

2017-01-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: EMC: Don't reuse data dir for log dir .. Patch Set 3: (13 comments) http://gerrit.cloudera.org:8080/#/c/5619/3//COMMIT_MSG Commit Message: PS3, Line 11: . > It

[kudu-CR] Add some path / env related helper functions

2017-01-19 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add some path / env related helper functions .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/5618/3/src/kudu/util/env_util-test.cc File

[kudu-CR] docs: add notes for multi master migration

2017-01-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: add notes for multi master migration .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5728/1/docs/administration.adoc File

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-19 Thread Jun He (Code Review)
Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: > It seems like in the context of a projection, we don't want to