[kudu-CR] util: helper class for working with bitsets

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12866 ) Change subject: util: helper class for working with bitsets .. Patch Set 5: Code-Review+1 -- To view, visit

[kudu-CR] util: helper class for working with bitsets

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12866 ) Change subject: util: helper class for working with bitsets .. Patch Set 5: (8 comments)

[kudu-CR] util: helper class for working with bitsets

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12866 to look at the new patch set (#5). Change subject: util: helper class for working with bitsets

[kudu-CR] authz: verify tokens on writes

Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11754 To

[kudu-CR] authz: verify tokens on writes

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/11754 To

[kudu-CR] util: helper class for working with bitsets

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12866 ) Change subject: util: helper class for working with bitsets .. Patch Set 4: (8 comments) > Patch Set 3: > > (1 comment)

[kudu-CR] authz: verify tokens on writes

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 6: (2 comments)

[kudu-CR] authz: verify tokens on writes

Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11754 to look at the new patch set (#6). Change subject: authz: verify tokens on writes

[kudu-CR] authz: verify tokens on writes

Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 5: Code-Review+1 (2 comments) LGTM, just minor nits.

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 2: (11 comments) Could you provide a rendering of the

[kudu-CR] authz: verify tokens on writes

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/11754 To

[kudu-CR] util: helper class for working with bitsets

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12866 ) Change subject: util: helper class for working with bitsets .. Patch Set 4: Code-Review+2 (1 comment)

[kudu-CR] authz: verify tokens on writes

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 5: (2 comments)

[kudu-CR] authz: verify tokens on writes

Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11754 to look at the new patch set (#5). Change subject: authz: verify tokens on writes

[kudu-CR] util: helper class for working with bitsets

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12866 ) Change subject: util: helper class for working with bitsets .. Patch Set 4: Verified+1 Unrelated failure of mt-tablet-test, which is

[kudu-CR] util: helper class for working with bitsets

Andrew Wong has removed a vote on this change. Change subject: util: helper class for working with bitsets .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12866 To unsubscribe,

[kudu-CR] authz: verify tokens on writes

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 4: (2 comments) a couple of nits

[kudu-CR] util: helper class for working with bitsets

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12866 ) Change subject: util: helper class for working with bitsets .. Patch Set 4: (1 comment)

[kudu-CR] util: helper class for working with bitsets

Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12866 to look at the new patch set (#4). Change subject: util: helper class for working with bitsets

[kudu-CR] util: helper class for working with bitsets

Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12866 to look at the new patch set (#3). Change subject: util: helper class for working with bitsets

[kudu-CR] RELEASING: add instructions to create binary test JARs

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12868 ) Change subject: RELEASING: add instructions to create binary test JARs .. Patch Set 1: (2 comments) Looks good! A couple clarifying

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

Hello Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12847 to look at the new patch set (#2). Change subject: [KUDU-1344] Part 1: cmake install for executables

[kudu-CR] util: helper class for working with bitsets

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12866 ) Change subject: util: helper class for working with bitsets .. Patch Set 2: (1 comment)

[kudu-CR] authz: verify tokens on writes

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11754 To

[kudu-CR] util: helper class for working with bitsets

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12866 ) Change subject: util: helper class for working with bitsets .. Patch Set 2: (1 comment)

[kudu-CR] util: helper class for working with bitsets

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12866 ) Change subject: util: helper class for working with bitsets .. Patch Set 2: (10 comments)

[kudu-CR] util: helper class for working with bitsets

Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12866 to look at the new patch set (#2). Change subject: util: helper class for working with bitsets

[kudu-CR] authz: verify tokens on writes

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 4: (5 comments)

[kudu-CR] authz: verify tokens on writes

Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11754 to look at the new patch set (#4). Change subject: authz: verify tokens on writes

[kudu-CR] RELEASING: add instructions to create binary test JARs

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12868 ) Change subject: RELEASING: add instructions to create binary test JARs .. Patch Set 1: Rendered version here:

[kudu-CR] RELEASING: add instructions to create binary test JARs

Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12868 to review the following change. Change subject: RELEASING: add instructions to create binary test JARs .. RELEASING:

[kudu-CR] java: Disable flaky test reporting on the RetryRule unit test

Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/12044 ) Change subject: java: Disable flaky test reporting on the RetryRule unit test .. Abandoned I'm going to merge this into the flaky test reporting

[kudu-CR] gradle: upgrade gradle-animalsniffer-plugin

Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12867 to review the following change. Change subject: gradle: upgrade gradle-animalsniffer-plugin .. gradle: upgrade

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2744: Expose RPC interface for diff scan

Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12592 ) Change subject: KUDU-2744: Expose RPC interface for diff scan .. KUDU-2744: Expose RPC interface for diff scan This patch

[kudu-CR] tablet service: improve error handling specificity

Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12840 ) Change subject: tablet_service: improve error handling specificity .. tablet_service: improve error handling specificity The

[kudu-CR] dist-test: improve error message when no tests run

Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12865 ) Change subject: dist-test: improve error message when no tests run .. dist-test: improve error message when no tests run This

[kudu-CR] dist-test: improve error message when no tests run

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12865 ) Change subject: dist-test: improve error message when no tests run .. Patch Set 1: > Could also move the check and exception into

[kudu-CR] authz: verify tokens on writes

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 3: (3 comments)

[kudu-CR] authz: verify tokens on writes

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11754 ) Change subject: authz: verify tokens on writes .. Patch Set 3: (16 comments) http://gerrit.cloudera.org:8080/#/c/11754/2//COMMIT_MSG

[kudu-CR] util: helper class for working with bitsets

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12866 ) Change subject: util: helper class for working with bitsets .. Patch Set 1: (7 comments)

[kudu-CR] dist-test: improve error message when no tests run

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12865 ) Change subject: dist-test: improve error message when no tests run .. Patch Set 1: Code-Review+2 Could also move the check and exception

[kudu-CR] util: helper class for working with bitsets

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12866 Change subject: util: helper class for working with bitsets .. util: helper class for working with bitsets Adds a templatized helper

[kudu-CR] authz: verify tokens on writes

Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11754 to look at the new patch set (#3). Change subject: authz: verify tokens on writes

[kudu-CR] KUDU-2744: Expose RPC interface for diff scan

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12592 ) Change subject: KUDU-2744: Expose RPC interface for diff scan .. Patch Set 11: Code-Review+2 -- To view, visit

[kudu-CR] tablet service: improve error handling specificity

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12840 ) Change subject: tablet_service: improve error handling specificity .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] tablet service: improve error handling specificity

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12840 ) Change subject: tablet_service: improve error handling specificity .. Patch Set 4: Staggeringly, these are all flakes: * KUDU-2621:

[kudu-CR] tablet service: improve error handling specificity

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12840 ) Change subject: tablet_service: improve error handling specificity .. Patch Set 4: > Staggeringly, these are all flakes: Oops, meant to

[kudu-CR] KUDU-2744: Expose RPC interface for diff scan

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12592 ) Change subject: KUDU-2744: Expose RPC interface for diff scan .. Patch Set 11: Verified+1 Staggeringly, these are all flakes:

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12847 ) Change subject: [KUDU-1344] Part 1: cmake install for executables .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2744: Expose RPC interface for diff scan

Mike Percy has removed a vote on this change. Change subject: KUDU-2744: Expose RPC interface for diff scan .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12592 To unsubscribe,

[kudu-CR] dist-test: improve error message when no tests run

Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12865 Change subject: dist-test: improve error message when no tests run .. dist-test: improve error message when no tests run This patch

[kudu-CR] ksck remote-test: deflake some more

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12853 ) Change subject: ksck_remote-test: deflake some more .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2744: Expose RPC interface for diff scan

Hello Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12592 to look at the new patch set (#11). Change subject: KUDU-2744: Expose RPC interface for diff scan

[kudu-CR] tablet service: improve error handling specificity

Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12840 to look at the new patch set (#4). Change subject: tablet_service: improve error handling specificity

[kudu-CR] ksck remote-test: deflake some more

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12853 ) Change subject: ksck_remote-test: deflake some more .. Patch Set 1: (4 comments)

[kudu-CR] ksck remote-test: deflake some more

Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12853 to look at the new patch set (#2). Change subject: ksck_remote-test: deflake some more

[kudu-CR] ksck remote-test: deflake some more

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12853 ) Change subject: ksck_remote-test: deflake some more .. Patch Set 1: (4 comments)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 3: (9 comments) > @adar,the table will be created

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 3: BTW, if you want Impala to pick up support for

[kudu-CR] mini hms: move derby.log into test data directory

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12855 ) Change subject: mini_hms: move derby.log into test data directory .. mini_hms: move derby.log into test data directory This is

[kudu-CR] java: normalize test log4j.properties with INFO logging

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12856 ) Change subject: java: normalize test log4j.properties with INFO logging .. Patch Set 1: > I'm assuming you did a clean build first?

[kudu-CR] java: normalize test log4j.properties with INFO logging

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12856 ) Change subject: java: normalize test log4j.properties with INFO logging .. java: normalize test log4j.properties with INFO

[kudu-CR] test result server: better error when AWS variables aren't set

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12854 ) Change subject: test_result_server: better error when AWS variables aren't set .. test_result_server: better error when AWS

[kudu-CR] java: normalize test log4j.properties with INFO logging

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12856 ) Change subject: java: normalize test log4j.properties with INFO logging .. Patch Set 1: Code-Review+1 I'm assuming you did a clean build

[kudu-CR](gh-pages) [blog] a blogpost about location awareness in Kudu

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12119 ) Change subject: [blog] a blogpost about location awareness in Kudu .. Patch Set 9: (1 comment)

[kudu-CR](gh-pages) [blog] a blogpost about location awareness in Kudu

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12119 ) Change subject: [blog] a blogpost about location awareness in Kudu .. Patch Set 8: (28 comments) Thank you for the thorough review.

[kudu-CR](gh-pages) [blog] a blogpost about location awareness in Kudu

Hello Will Berkeley, Greg Solovyev, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12119 to look at the new patch set (#9). Change subject: [blog] a blogpost about location awareness in Kudu

[kudu-CR] WIP [util] introduce TTL cache

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12825 ) Change subject: WIP [util] introduce TTL cache .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12825/3//COMMIT_MSG

[kudu-CR] mini hms: move derby.log into test data directory

Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12855 ) Change subject: mini_hms: move derby.log into test data directory .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] mini hms: move derby.log into test data directory

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12855 ) Change subject: mini_hms: move derby.log into test data directory .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] test result server: better error when AWS variables aren't set

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12854 ) Change subject: test_result_server: better error when AWS variables aren't set .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] java: normalize test log4j.properties with INFO logging

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12856 ) Change subject: java: normalize test log4j.properties with INFO logging .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#3). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 2: (1 comment) ok, let me try again.

[kudu-CR] [maintenance] Add privilege maintenance thread pool for privilege tables and tablets

Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12852 ) Change subject: [maintenance] Add privilege maintenance thread pool for privilege tables and tablets .. Patch Set 1: The purpose of

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

Hello Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#2). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 1: (10 comments) @adar,the table will be created

[kudu-CR] java: normalize test log4j.properties with INFO logging

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12856 ) Change subject: java: normalize test log4j.properties with INFO logging .. Patch Set 1: This was originally attempted by Mike in

[kudu-CR] java: normalize test log4j.properties with INFO logging

Hello Mike Percy, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12856 to review the following change. Change subject: java: normalize test log4j.properties with INFO logging

[kudu-CR] mini hms: move derby.log into test data directory

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12855 ) Change subject: mini_hms: move derby.log into test data directory .. Patch Set 1: Verified+1 Overriding Jenkins for an unrelated failure

[kudu-CR] mini hms: move derby.log into test data directory

Adar Dembo has removed a vote on this change. Change subject: mini_hms: move derby.log into test data directory .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12855 To unsubscribe,

[kudu-CR] mini hms: move derby.log into test data directory

Hello Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12855 to review the following change. Change subject: mini_hms: move derby.log into test data directory .. mini_hms: move

[kudu-CR] tablet server-test-base: make types match schema

Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12839 ) Change subject: tablet_server-test-base: make types match schema .. tablet_server-test-base: make types match schema This patch

[kudu-CR] More Jenkins testing

Mike Percy has abandoned this change. ( http://gerrit.cloudera.org:8080/12851 ) Change subject: More Jenkins testing .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/12851 To unsubscribe, visit

[kudu-CR] Jenkins test

Mike Percy has abandoned this change. ( http://gerrit.cloudera.org:8080/12850 ) Change subject: Jenkins test .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/12850 To unsubscribe, visit

[kudu-CR] test result server: better error when AWS variables aren't set

Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12854 to review the following change. Change subject: test_result_server: better error when AWS variables aren't set ..

[kudu-CR] ksck remote-test: deflake some more

Hello Will Berkeley, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12853 to review the following change. Change subject: ksck_remote-test: deflake some more ..