[kudu-CR] Example shell scripts to start and stop Kudu cluster

2019-09-12 Thread Volodymyr Verovkin (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14192 to look at the new patch set (#7). Change subject: Example shell scripts to start and stop Kudu cluster

[kudu-CR] KUDU-2069 p4: stop replication from failed servers in maintenance mode

2019-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14222 ) Change subject: KUDU-2069 p4: stop replication from failed servers in maintenance mode .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-2920 Block cache capacity validator houldn't run on an NVM block cache

2019-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14212 ) Change subject: KUDU-2920 Block cache capacity validator houldn't run on an NVM block cache .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2920 Block cache capacity validator houldn't run on an NVM block cache

2019-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14212 ) Change subject: KUDU-2920 Block cache capacity validator houldn't run on an NVM block cache .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-1561 Implemented operator->() in KuduScanBatch::const iterator

2019-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14219 ) Change subject: KUDU-1561 Implemented operator->() in KuduScanBatch::const_iterator .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2069 p5: recheck tablet health when exiting maintenance mode

2019-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14223 ) Change subject: KUDU-2069 p5: recheck tablet health when exiting maintenance mode .. Patch Set 2: (5 comments)

[kudu-CR] KUDU-2069 p4: stop replication from failed servers in maintenance mode

2019-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14222 ) Change subject: KUDU-2069 p4: stop replication from failed servers in maintenance mode .. Patch Set 2: (5 comments)

[kudu-CR] KUDU-2920 Block cache capacity validator houldn't run on an NVM block cache

2019-09-12 Thread Volodymyr Verovkin (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14212 to look at the new patch set (#3). Change subject: KUDU-2920 Block cache capacity validator houldn't run on an NVM block cache

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 2: Code-Review+1 (3 comments)

[kudu-CR] KUDU-2069 p2: stop placement on servers in maintenance mode

2019-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14220 ) Change subject: KUDU-2069 p2: stop placement on servers in maintenance mode .. Patch Set 2: Code-Review+1 (2 comments)

[kudu-CR] KUDU-1561 Implemented operator->() in KuduScanBatch::const iterator

2019-09-12 Thread Volodymyr Verovkin (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14219 to look at the new patch set (#2). Change subject: KUDU-1561 Implemented operator->() in KuduScanBatch::const_iterator

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 2: (8 comments) overall looks good, just a few nits

[kudu-CR] [clock] add a built-in NTP client implementation

2019-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7477 ) Change subject: [clock] add a built-in NTP client implementation .. Patch Set 13: Verified+1 Unrelated failures in the following tests

[kudu-CR] [clock] add a built-in NTP client implementation

2019-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [clock] add a built-in NTP client implementation .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/7477 To

[kudu-CR] [macos] add .DS Store entry into .gitignore

2019-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14226 ) Change subject: [macos] add .DS_Store entry into .gitignore .. [macos] add .DS_Store entry into .gitignore Change-Id:

[kudu-CR] [mini cluster] introduce 'builtin' clock source

2019-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14227 Change subject: [mini_cluster] introduce 'builtin' clock source .. [mini_cluster] introduce 'builtin' clock source This patch

[kudu-CR] [macos] add .DS Store entry into .gitignore

2019-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14226 ) Change subject: [macos] add .DS_Store entry into .gitignore .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [macos] add .DS Store entry into .gitignore

2019-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14226 Change subject: [macos] add .DS_Store entry into .gitignore .. [macos] add .DS_Store entry into .gitignore Change-Id:

[kudu-CR] KUDU-2069 p1: add persistent tserver maintenance mode

2019-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14217 ) Change subject: KUDU-2069 p1: add persistent tserver maintenance mode .. Patch Set 4: (16 comments)

[kudu-CR] [clock] add a built-in NTP client implementation

2019-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#13) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/7477 ) Change subject: [clock] add a built-in NTP client implementation .. [clock] add a

[kudu-CR] [clock] add a built-in NTP client implementation

2019-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#12) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/7477 ) Change subject: [clock] add a built-in NTP client implementation .. [clock] add a

[kudu-CR] KUDU-2069 p5: recheck tablet health when exiting maintenance mode

2019-09-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14223 ) Change subject: KUDU-2069 p5: recheck tablet health when exiting maintenance mode .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-2069 p4: stop replication from failed servers in maintenance mode

2019-09-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14222 ) Change subject: KUDU-2069 p4: stop replication from failed servers in maintenance mode .. Patch Set 2: (6 comments)

[kudu-CR] KUDU-2069 p1: add persistent tserver maintenance mode

2019-09-12 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/14217 ) Change subject: KUDU-2069 p1: add persistent tserver maintenance mode .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2069 p2: stop placement on servers in maintenance mode

2019-09-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14220 ) Change subject: KUDU-2069 p2: stop placement on servers in maintenance mode .. Patch Set 2: (2 comments)

[kudu-CR] [java] Disable install of unpublished jars

2019-09-12 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14224 ) Change subject: [java] Disable install of unpublished jars .. [java] Disable install of unpublished jars We don’t publish the

[kudu-CR] [java] Disable install of unpublished jars

2019-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14224 ) Change subject: [java] Disable install of unpublished jars .. Patch Set 1: Code-Review+2 > I think matching our release

[kudu-CR] [java] Disable install of unpublished jars

2019-09-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14224 ) Change subject: [java] Disable install of unpublished jars .. Patch Set 1: I think matching our release publishing/deployment is the

[kudu-CR] KUDU-2069 p2: stop placement on servers in maintenance mode

2019-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14220 ) Change subject: KUDU-2069 p2: stop placement on servers in maintenance mode .. Patch Set 2: (5 comments)

[kudu-CR] [java] Disable install of unpublished jars

2019-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14224 ) Change subject: [java] Disable install of unpublished jars .. Patch Set 1: Isn't this a little unusual though? I'm no Maven expert but I

[kudu-CR] KUDU-1561 Implemented operator->() in KuduScanBatch::const iterator

2019-09-12 Thread Volodymyr Verovkin (Code Review)
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14219 ) Change subject: KUDU-1561 Implemented operator->() in KuduScanBatch::const_iterator .. Patch Set 1: > What happens to existing

[kudu-CR] Add get table statistics interface for cpp client

2019-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14218 ) Change subject: Add get table statistics interface for cpp client .. Patch Set 1: (2 comments) Just a few doc nits.

[kudu-CR] KUDU-1561 Implemented operator->() in KuduScanBatch::const iterator

2019-09-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14219 ) Change subject: KUDU-1561 Implemented operator->() in KuduScanBatch::const_iterator .. Patch Set 1: What happens to existing

[kudu-CR] KUDU-2920: Block cache capacity validator shouldn't run on an NVM block cache

2019-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14212 ) Change subject: KUDU-2920: Block cache capacity validator shouldn't run on an NVM block cache .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2069 p2: stop placement on servers in maintenance mode

2019-09-12 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/14220 ) Change subject: KUDU-2069 p2: stop placement on servers in maintenance mode .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2069 p2: stop placement on servers in maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14220 ) Change subject: KUDU-2069 p2: stop placement on servers in maintenance mode .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2069 p1: add persistent tserver maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14217 ) Change subject: KUDU-2069 p1: add persistent tserver maintenance mode .. Patch Set 4: (5 comments)

[kudu-CR] KUDU-2069 pt 1: add a maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/14111 ) Change subject: KUDU-2069 pt 1: add a maintenance mode .. Abandoned I split this into smaller patches. -- To view, visit

[kudu-CR] KUDU-2069 pt 1: add a maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14111 ) Change subject: KUDU-2069 pt 1: add a maintenance mode .. Patch Set 6: (4 comments)

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 2: Verified+1 Failed test was KUDU-1736 -- To view,

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14221 To

[kudu-CR] Add get table statistics interface for cpp client

2019-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14218 ) Change subject: Add get table statistics interface for cpp client .. Patch Set 1: Code-Review+1 (3 comments) LGTM, just a few nits.

[kudu-CR] KUDU-1561 Implemented operator->() in KuduScanBatch::const iterator

2019-09-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14219 ) Change subject: KUDU-1561 Implemented operator->() in KuduScanBatch::const_iterator .. Patch Set 1: (5 comments)

[kudu-CR] KUDU-2069 p4: stop replication from failed servers in maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14222 to look at the new patch set (#2). Change subject: KUDU-2069 p4: stop replication from failed servers in maintenance mode

[kudu-CR] KUDU-2069 p2: stop placement on servers in maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14220 to look at the new patch set (#2). Change subject: KUDU-2069 p2: stop placement on servers in maintenance mode

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14221 to look at the new patch set (#2). Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode ..

[kudu-CR] [java] Disable install of unpublished jars

2019-09-12 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14224 Change subject: [java] Disable install of unpublished jars .. [java] Disable install of unpublished jars We don’t publish the

[kudu-CR] KUDU-2069 p5: recheck tablet health when exiting maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14223 Change subject: KUDU-2069 p5: recheck tablet health when exiting maintenance mode .. KUDU-2069 p5: recheck tablet health when exiting

[kudu-CR] KUDU-2069 p4: stop replication from failed servers in maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14222 Change subject: KUDU-2069 p4: stop replication from failed servers in maintenance mode .. KUDU-2069 p4: stop replication from failed

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14221 Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. KUDU-2069 p3: add RPC endpoint for maintenance mode This patch

[kudu-CR] KUDU-2069 p2: stop placement on servers in maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14220 Change subject: KUDU-2069 p2: stop placement on servers in maintenance mode .. KUDU-2069 p2: stop placement on servers in maintenance

[kudu-CR] KUDU-2069 p1: add persistent tserver maintenance mode

2019-09-12 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14217 to look at the new patch set (#4). Change subject: KUDU-2069 p1: add persistent tserver maintenance mode

[kudu-CR] KUDU-1561 Implemented operator->() in KuduScanBatch::const iterator

2019-09-12 Thread Volodymyr Verovkin (Code Review)
Volodymyr Verovkin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14219 Change subject: KUDU-1561 Implemented operator->() in KuduScanBatch::const_iterator .. KUDU-1561 Implemented operator->() in

[kudu-CR] Add get table statistics interface for cpp client

2019-09-12 Thread ZhangYao (Code Review)
ZhangYao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14218 Change subject: Add get table statistics interface for cpp client .. Add get table statistics interface for cpp client Change-Id: