[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-21 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-21 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose stats about scan filters This patch adds the

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 16: Verified+1 > The release jenkins build failed for

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-21 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 16: > Patch Set 16: Verified-1 > > Build Failed > >

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 16: Code-Review+2 (1 comment) Thank you for persevering and your

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-21 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded a new patch set (#16) to the change originally created by Will Berkeley. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-21 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 16: > Patch Set 15: > > (3 comments) Updated the patch to

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 15: (3 comments)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-20 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 15: (3 comments)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-20 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded a new patch set (#15) to the change originally created by Will Berkeley. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 14: (3 comments)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-18 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 14: > Patch Set 12: > > I owe you an apology. I should

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-18 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded a new patch set (#14) to the change originally created by Will Berkeley. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-18 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded a new patch set (#13) to the change originally created by Will Berkeley. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 12: I owe you an apology. I should have looked at the existing C++

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-18 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 12: > Patch Set 11: > > Patch looks good but you've got

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-18 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded a new patch set (#12) to the change originally created by Will Berkeley. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 11: Patch looks good but you've got some IWYU failures to address:

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-16 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 11: (1 comment)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-16 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 11: (2 comments)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-16 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded a new patch set (#11) to the change originally created by Will Berkeley. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 10: (3 comments)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-14 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 10: (7 comments)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-14 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded a new patch set (#10) to the change originally created by Will Berkeley. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-14 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded a new patch set (#9) to the change originally created by Will Berkeley. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 8: (14 comments) C++ code looks good, just a few style nits left.

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-13 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 8: (5 comments)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-13 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded a new patch set (#8) to the change originally created by Will Berkeley. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 7: (5 comments)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-12 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 7: (8 comments) > Patch Set 6: > > (9 comments) Fixed.

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-12 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded a new patch set (#7) to the change originally created by Will Berkeley. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-11 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 6: > Patch Set 5: > > (8 comments) I missed these

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-11 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded a new patch set (#6) to the change originally created by Will Berkeley. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 5: (8 comments)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-11 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 5: > Patch Set 4: > > (4 comments) Fixed. -- To view,

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-11 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded a new patch set (#5) to the change originally created by Will Berkeley. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-11 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has abandoned this change. ( http://gerrit.cloudera.org:8080/14652 ) Change subject: KUDU-2162 Expose stats about scan filters .. Abandoned Review moved to https://gerrit.cloudera.org/c/8375/ -- To view,

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-11 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 4: (7 comments)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-11 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded a new patch set (#4) to the change originally created by Will Berkeley. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 3: (4 comments) The test failures still need to be addressed.

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-10 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded a new patch set (#3) to the change originally created by Will Berkeley. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-10 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 3: > Patch Set 2: > > (1 comment) Fixed -- To view,

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-09 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14652 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 4: (5 comments) I pushed a patch with the latest changes

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-09 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-09 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded a new patch set (#2) to the change originally created by Will Berkeley. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14652 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 4: (5 comments)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14652 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 4: > > Just realized that this is a continuation of Will's patch

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-09 Thread Adar Dembo (Code Review)
Adar Dembo has restored this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Restored -- To view, visit http://gerrit.cloudera.org:8080/8375 To unsubscribe, visit

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-09 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14652 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 4: > Uploaded patch set 4. Sorry for the churn, my local

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-09 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14652 to look at the new patch set (#4). Change subject: KUDU-2162 Expose stats about scan filters ..

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-08 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14652 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 3: (4 comments)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-08 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14652 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 3: > Just realized that this is a continuation of Will's

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-08 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14652 to look at the new patch set (#3). Change subject: KUDU-2162 Expose stats about scan filters ..

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14652 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 2: Just realized that this is a continuation of Will's patch from

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14652 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 2: (4 comments) I haven't reviewed the client-side stuff yet.

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-07 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14652 to look at the new patch set (#2). Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose

[kudu-CR] KUDU-2162 Expose stats about scan filters

2019-11-06 Thread Anonymous Coward (Code Review)
tdsi...@twilio.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14652 Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose stats about scan filters This patch adds the

[kudu-CR] KUDU-2162 Expose stats about scan filters

2018-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has abandoned this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Abandoned I'm sorry I never got anywhere with this but it looks like Impala is

[kudu-CR] KUDU-2162 Expose stats about scan filters

2017-10-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 ) Change subject: KUDU-2162 Expose stats about scan filters .. Patch Set 1: (8 comments)

[kudu-CR] KUDU-2162 Expose stats about scan filters

2017-10-24 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8375 Change subject: KUDU-2162 Expose stats about scan filters .. KUDU-2162 Expose stats about scan filters This patch adds a couple of