[kudu-CR] txns: syntactically sweeten some tuple-like variables

2021-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17046 ) Change subject: txns: syntactically sweeten some tuple-like variables .. Patch Set 1: (1 comment) Thank you for updating the code to

[kudu-CR] txns: syntactically sweeten some tuple-like variables

2021-02-09 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17046 to look at the new patch set (#2). Change subject: txns: syntactically sweeten some tuple-like variables

[kudu-CR] KUDU-2612: add background task to abort transaction participants

2021-02-09 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17017 to look at the new patch set (#7). Change subject: KUDU-2612: add background task to abort transaction participants

[kudu-CR] [tool] KUDU-2181 CLI to add master

2021-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16530 ) Change subject: [tool] KUDU-2181 CLI to add master .. Patch Set 2: (2 comments)

[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode

2021-02-09 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17051 Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode .. [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in

[kudu-CR] txns: syntactically sweeten some tuple-like variables

2021-02-09 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17046 to look at the new patch set (#3). Change subject: txns: syntactically sweeten some tuple-like variables

[kudu-CR] txns: syntactically sweeten some tuple-like variables

2021-02-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17046 ) Change subject: txns: syntactically sweeten some tuple-like variables .. Patch Set 2: (1 comment)

[kudu-CR] [transactions] add TxnSystemClient::CheckOpenTxnSystemTable()

2021-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17044 Change subject: [transactions] add TxnSystemClient::CheckOpenTxnSystemTable() .. [transactions] add

[kudu-CR] txns: syntactically sweeten some tuple-like variables

2021-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17046 ) Change subject: txns: syntactically sweeten some tuple-like variables .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] txns: syntactically sweeten some tuple-like variables

2021-02-09 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17046 ) Change subject: txns: syntactically sweeten some tuple-like variables .. txns: syntactically sweeten some tuple-like variables

[kudu-CR] [tool] KUDU-2181 CLI to add master

2021-02-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16530 ) Change subject: [tool] KUDU-2181 CLI to add master .. Patch Set 7: (1 comment)

[kudu-CR] [tool] KUDU-2181 CLI to add master

2021-02-09 Thread Bankim Bhavsar (Code Review)
Hello Mahesh Reddy, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16530 to look at the new patch set (#8). Change subject: [tool] KUDU-2181 CLI to add master

[kudu-CR] [tool] KUDU-2181 CLI to remove master

2021-02-09 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17010 to look at the new patch set (#7). Change subject: [tool] KUDU-2181 CLI to remove master .. [tool]

[kudu-CR] KUDU-2612: add background task to abort transaction participants

2021-02-09 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2612: add background task to abort transaction participants .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17017

[kudu-CR] KUDU-2612: add background task to abort transaction participants

2021-02-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17017 ) Change subject: KUDU-2612: add background task to abort transaction participants .. Patch Set 8: Verified+1 Test failure is unrelated.

[kudu-CR] [test] Fix InstanceDetectorTest.Timeout when run on AWS

2021-02-09 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17052 Change subject: [test] Fix InstanceDetectorTest.Timeout when run on AWS .. [test] Fix InstanceDetectorTest.Timeout when run on AWS When

[kudu-CR] [test] Fix InstanceDetectorTest.Timeout when run on AWS

2021-02-09 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17052 to look at the new patch set (#2). Change subject: [test] Fix InstanceDetectorTest.Timeout when run on AWS

[kudu-CR] [test] Fix PasswdWebserverTest.TestCrashInFIPSMode test

2021-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17041 ) Change subject: [test] Fix PasswdWebserverTest.TestCrashInFIPSMode test .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2612: add background task to abort transaction participants

2021-02-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17017 ) Change subject: KUDU-2612: add background task to abort transaction participants .. Patch Set 8: Code-Review+2 (2 comments)

[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode

2021-02-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17051 ) Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode .. Patch Set 2: (1 comment)

[kudu-CR] [tool] KUDU-2181 CLI to remove master

2021-02-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17010 ) Change subject: [tool] KUDU-2181 CLI to remove master .. Patch Set 7: (1 comment)

[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode

2021-02-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17051 ) Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode .. Patch Set 2: (1 comment)

[kudu-CR] [test] Fix InstanceDetectorTest.Timeout when run on AWS

2021-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17052 ) Change subject: [test] Fix InstanceDetectorTest.Timeout when run on AWS .. Patch Set 3: (3 comments)

[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode

2021-02-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17051 ) Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode .. Patch Set 2: (1 comment)

[kudu-CR] [tool] KUDU-2181 CLI to remove master

2021-02-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has removed a vote on this change. Change subject: [tool] KUDU-2181 CLI to remove master .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17010 To unsubscribe, visit

[kudu-CR] [tool] KUDU-2181 CLI to remove master

2021-02-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17010 ) Change subject: [tool] KUDU-2181 CLI to remove master .. Patch Set 7: Verified+1 Unrelated test failure in ASAN

[kudu-CR] [test] Fix InstanceDetectorTest.Timeout when run on AWS

2021-02-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17052 ) Change subject: [test] Fix InstanceDetectorTest.Timeout when run on AWS .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] [test] Fix InstanceDetectorTest.Timeout when run on AWS

2021-02-09 Thread Grant Henke (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17052 to look at the new patch set (#4). Change subject: [test] Fix InstanceDetectorTest.Timeout when run on AWS

[kudu-CR] [test] Fix InstanceDetectorTest.Timeout when run on AWS

2021-02-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17052 ) Change subject: [test] Fix InstanceDetectorTest.Timeout when run on AWS .. Patch Set 4: (3 comments)

[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode

2021-02-09 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17051 to look at the new patch set (#2). Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode

[kudu-CR] [transactions] add TxnSystemClient::CheckOpenTxnSystemTable()

2021-02-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17044 ) Change subject: [transactions] add TxnSystemClient::CheckOpenTxnSystemTable() .. Patch Set 4: (3 comments)

[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode

2021-02-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17051 ) Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode .. Patch Set 2: (1 comment)

[kudu-CR] [test] Fix InstanceDetectorTest.Timeout when run on AWS

2021-02-09 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17052 ) Change subject: [test] Fix InstanceDetectorTest.Timeout when run on AWS .. [test] Fix InstanceDetectorTest.Timeout when run on

[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode

2021-02-09 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17051 ) Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode .. [test] Skip

[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode

2021-02-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17051 ) Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode .. Patch Set 2: (1 comment)

[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode

2021-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17051 ) Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode .. Patch Set 2: (2 comments)

[kudu-CR] [test] Fix InstanceDetectorTest.Timeout when run on AWS

2021-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17052 ) Change subject: [test] Fix InstanceDetectorTest.Timeout when run on AWS .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [test] Fix PasswdWebserverTest.TestCrashInFIPSMode test

2021-02-09 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17041 ) Change subject: [test] Fix PasswdWebserverTest.TestCrashInFIPSMode test .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tool] KUDU-2181 CLI to add master

2021-02-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16530 ) Change subject: [tool] KUDU-2181 CLI to add master .. Patch Set 8: Code-Review+1 (2 comments)

[kudu-CR] [test] Fix PasswdWebserverTest.TestCrashInFIPSMode test

2021-02-09 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17041 ) Change subject: [test] Fix PasswdWebserverTest.TestCrashInFIPSMode test .. [test] Fix PasswdWebserverTest.TestCrashInFIPSMode

[kudu-CR] [master] turn off client location assignment by default

2021-02-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 ) Change subject: [master] turn off client location assignment by default .. Patch Set 2: (1 comment)

[kudu-CR] [master] turn off client location assignment by default

2021-02-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 ) Change subject: [master] turn off client location assignment by default .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode

2021-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17051 ) Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [transactions] add TxnSystemClient::CheckOpenTxnSystemTable()

2021-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17044 ) Change subject: [transactions] add TxnSystemClient::CheckOpenTxnSystemTable() .. Patch Set 4: (3 comments)

[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode

2021-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17051 ) Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode .. Patch Set 2: (1 comment)

[kudu-CR] [master] turn off client location assignment by default

2021-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17024 ) Change subject: [master] turn off client location assignment by default .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2612: add background task to abort transaction participants

2021-02-09 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17017 ) Change subject: KUDU-2612: add background task to abort transaction participants .. KUDU-2612: add background task to abort

[kudu-CR] [master] turn off client location assignment by default

2021-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17024 ) Change subject: [master] turn off client location assignment by default .. [master] turn off client location assignment by

[kudu-CR] [transactions] add TxnSystemClient::CheckOpenTxnSystemTable()

2021-02-09 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17044 to look at the new patch set (#6). Change subject: [transactions] add TxnSystemClient::CheckOpenTxnSystemTable()

[kudu-CR] [thirdparty] use system curl for cmake

2021-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17053 Change subject: [thirdparty] use system curl for cmake .. [thirdparty] use system curl for cmake Since building Kudu from source

[kudu-CR] [transactions] add TxnSystemClient::CheckOpenTxnSystemTable()

2021-02-09 Thread Alexey Serbin (Code Review)
Hello Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17044 to look at the new patch set (#5). Change subject: [transactions] add TxnSystemClient::CheckOpenTxnSystemTable()