[kudu-CR] Add script to run clang-tidy against a patch

2017-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add script to run clang-tidy against a patch .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4381/3/build-support/compile_flags.py File

[kudu-CR] tool: add a 'pbc edit' command

2017-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tool: add a 'pbc edit' command .. tool: add a 'pbc edit' command This adds a new command 'kudu pbc edit' which can be used to edit any PBC file. It dumps

[kudu-CR] consensus: consolidate Raft thread pools

2017-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: consolidate Raft thread pools .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6946/7/src/kudu/consensus/consensus_peers.cc File

[kudu-CR] [ExternalDaemon] return non-OK if no process to pause/resume

2017-06-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [ExternalDaemon] return non-OK if no process to pause/resume .. Patch Set 2: Verified+1 Unrelated flake in SparkSQL StringStartsWith

[kudu-CR] [ExternalDaemon] return non-OK if no process to pause/resume

2017-06-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [ExternalDaemon] return non-OK if no process to pause/resume .. [ExternalDaemon] return non-OK if no process to pause/resume Prior to this patch,

[kudu-CR] tool: add a 'pbc edit' command

2017-06-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tool: add a 'pbc edit' command .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/7048/1/src/kudu/tools/tool_action_pbc.cc File

[kudu-CR] [ExternalDaemon] return non-OK if no process to pause/resume

2017-06-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7092 Change subject: [ExternalDaemon] return non-OK if no process to pause/resume .. [ExternalDaemon] return non-OK if no process to

[kudu-CR] util: add fault injection of EIOs

2017-06-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: util: add fault injection of EIOs .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/6881/8/src/kudu/util/fault_injection.h File

[kudu-CR] util: add fault injection of EIOs

2017-06-05 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6881 to look at the new patch set (#14). Change subject: util: add fault injection of EIOs .. util: add fault injection

[kudu-CR] tool: add a 'local-replica cmeta set-term' tool

2017-06-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tool: add a 'local-replica cmeta set-term' tool .. Patch Set 2: Code-Review+1 (3 comments)

[kudu-CR] external minicluster: expand EMC dir usage

2017-06-05 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: external minicluster: expand EMC dir usage .. external minicluster: expand EMC dir usage In order to test different disk configurations, it is becoming

[kudu-CR] external minicluster: expand EMC dir usage

2017-06-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 24: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6845 To unsubscribe, visit

[kudu-CR](branch-1.3.x) KUDU-2020: tserver failure causes multiple tablet copy operations per under-replicated tablet

2017-06-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2020: tserver failure causes multiple tablet copy operations per under-replicated tablet .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] util: add fault injection of EIOs

2017-06-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: util: add fault injection of EIOs .. Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/6881/12//COMMIT_MSG Commit Message: Line 10: a

[kudu-CR] util: add fault injection of EIOs

2017-06-05 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6881 to look at the new patch set (#13). Change subject: util: add fault injection of EIOs .. util: add fault injection

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

2017-06-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2027 retry scan RPC if negotiation times out .. Patch Set 8: Verified+1 Unrelated flake in org.apache.kudu.spark.kudu.DefaultSourceTest.Test -- To view,

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

2017-06-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-2027 retry scan RPC if negotiation times out .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7037/4/src/kudu/client/scanner-internal.cc File

[kudu-CR] consensus: consolidate Raft thread pools

2017-06-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: consensus: consolidate Raft thread pools .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6946/7/src/kudu/consensus/consensus_peers.cc File

[kudu-CR] tool: add a 'local-replica cmeta set-term' tool

2017-06-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tool: add a 'local-replica cmeta set-term' tool .. Patch Set 2: (3 comments)

[kudu-CR] Bump googletest

2017-06-05 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Bump googletest .. Bump googletest The new clang tidy is issuing warnings about gtest macros, the new version seems to fix the issue. Change-Id:

[kudu-CR] consensus: consolidate Raft thread pools

2017-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: consolidate Raft thread pools .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6946/7/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] Add script to run clang-tidy against a patch

2017-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add script to run clang-tidy against a patch .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4381 To unsubscribe, visit

[kudu-CR] Add script to run clang-tidy against a patch

2017-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add script to run clang-tidy against a patch .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4381/3/build-support/compile_flags.py File

[kudu-CR] Add script to run clang-tidy against a patch

2017-06-05 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4381 to look at the new patch set (#4). Change subject: Add script to run clang-tidy against a patch .. Add script to

[kudu-CR](branch-1.4.x) [tools] Use PrintTable to format ksck's consensus matrix

2017-06-05 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: [tools] Use PrintTable to format ksck's consensus matrix .. [tools] Use PrintTable to format ksck's consensus matrix The first version of ksck's

[kudu-CR] consensus: consolidate Raft thread pools

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: consolidate Raft thread pools .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6946/7/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] Add script to run clang-tidy against a patch

2017-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add script to run clang-tidy against a patch .. Patch Set 3: (6 comments) > Forgot to ask: how is clang_tidy_gerrit.py invoked? There's a jenkins job here:

[kudu-CR] external minicluster: expand EMC dir usage

2017-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 24: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6845 To unsubscribe, visit

[kudu-CR] Bump googletest

2017-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Bump googletest .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7089 To unsubscribe, visit

[kudu-CR] build-and-test.sh: only rerun Spark tests if Java build passes

2017-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#2). Change subject: build-and-test.sh: only rerun Spark tests if Java build passes .. build-and-test.sh: only rerun Spark tests if Java build passes Otherwise, the output of a failing

[kudu-CR] build-and-test.sh: only rerun Spark tests if Java build passes

2017-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: build-and-test.sh: only rerun Spark tests if Java build passes .. Patch Set 1: (1 comment)

[kudu-CR] external minicluster: expand EMC dir usage

2017-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 24: Code-Review+1 Deferring to Mike. -- To view, visit http://gerrit.cloudera.org:8080/6845 To

[kudu-CR] Add fault injection of EIOs

2017-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add fault injection of EIOs .. Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/6881/12//COMMIT_MSG Commit Message: Line 10: a flag-specified glob

[kudu-CR] build-and-test.sh: only rerun Spark tests if Java build passes

2017-06-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: build-and-test.sh: only rerun Spark tests if Java build passes .. Patch Set 1: (2 comments)

[kudu-CR] tool: add a 'local-replica cmeta set-term' tool

2017-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: add a 'local-replica cmeta set-term' tool .. Patch Set 2: Code-Review+1 Deferring to Mike. -- To view, visit http://gerrit.cloudera.org:8080/7049 To

[kudu-CR] tool: add a 'pbc edit' command

2017-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: add a 'pbc edit' command .. Patch Set 2: Code-Review+1 Deferring to Mike. -- To view, visit http://gerrit.cloudera.org:8080/7048 To unsubscribe, visit

[kudu-CR] tool: add a 'local-replica cmeta set-term' tool

2017-06-05 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7049 to look at the new patch set (#2). Change subject: tool: add a 'local-replica cmeta set-term' tool .. tool: add a

[kudu-CR] tool: add a 'pbc edit' command

2017-06-05 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7048 to look at the new patch set (#2). Change subject: tool: add a 'pbc edit' command .. tool: add a 'pbc edit'

[kudu-CR] tool: add a 'local-replica cmeta set-term' tool

2017-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: add a 'local-replica cmeta set-term' tool .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/7049/1/src/kudu/tools/kudu-tool-test.cc File

[kudu-CR] tool: add a 'pbc edit' command

2017-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: add a 'pbc edit' command .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/7048/1/src/kudu/tools/kudu-tool-test.cc File

[kudu-CR] tool: add a 'pbc edit' command

2017-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: add a 'pbc edit' command .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7048/1/src/kudu/tools/tool_action_pbc.cc File

[kudu-CR] Bump googletest

2017-06-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Bump googletest .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7089/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh:

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

2017-06-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2027 retry scan RPC if negotiation times out .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/7037/4/src/kudu/client/scanner-internal.cc

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

2017-06-05 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7037 to look at the new patch set (#8). Change subject: KUDU-2027 retry scan RPC if negotiation times out .. KUDU-2027

[kudu-CR] Bump googletest

2017-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Bump googletest .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7089/2/thirdparty/build-definitions.sh File

[kudu-CR] consensus: consolidate Raft thread pools

2017-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: consolidate Raft thread pools .. Patch Set 7: (4 comments) I filed KUDU-2029 for the unrelated build failure.

[kudu-CR] WIP: Add basic Hive MetaStore client

2017-06-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: WIP: Add basic Hive MetaStore client .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/7053/2/src/kudu/hms/hive_metastore-test.cc File

[kudu-CR] WIP: Add basic Hive MetaStore client

2017-06-05 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7053 to look at the new patch set (#3). Change subject: WIP: Add basic Hive MetaStore client .. WIP: Add basic Hive

[kudu-CR] Bump googletest

2017-06-05 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7089 to look at the new patch set (#2). Change subject: Bump googletest .. Bump googletest The new clang

[kudu-CR] [python] Fix undefined TimeoutError in tests

2017-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [python] Fix undefined TimeoutError in tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7078 To unsubscribe, visit

[kudu-CR] WIP: Bump googletest

2017-06-05 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/7089 Change subject: WIP: Bump googletest .. WIP: Bump googletest WIP because the change to client-test is just to see if this fixes the clang

[kudu-CR] external minicluster: expand EMC dir usage

2017-06-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 24: (1 comment)

[kudu-CR] external minicluster: expand EMC dir usage

2017-06-05 Thread Andrew Wong (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6845 to look at the new patch set (#24). Change subject: external minicluster: expand EMC dir usage ..

[kudu-CR] external minicluster: expand EMC dir usage

2017-06-05 Thread Andrew Wong (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6845 to look at the new patch set (#23). Change subject: external minicluster: expand EMC dir usage ..

[kudu-CR] block placement: test DataDirGroups on old servers

2017-06-05 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7088 Change subject: block placement: test DataDirGroups on old servers .. block placement: test DataDirGroups on old servers This patch adds

[kudu-CR] Add fault injection of EIOs

2017-06-05 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6881 to look at the new patch set (#12). Change subject: Add fault injection of EIOs .. Add fault injection of EIOs

[kudu-CR](branch-1.4.x) [tools] Use PrintTable to format ksck's consensus matrix

2017-06-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [tools] Use PrintTable to format ksck's consensus matrix .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7086 To unsubscribe,

[kudu-CR](branch-1.4.x) [tools] Use PrintTable to format ksck's consensus matrix

2017-06-05 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7086 Change subject: [tools] Use PrintTable to format ksck's consensus matrix .. [tools] Use PrintTable to format ksck's consensus matrix

[kudu-CR] threadpool: token-based task sequencing

2017-06-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: threadpool: token-based task sequencing .. Patch Set 8: -Code-Review (14 comments) http://gerrit.cloudera.org:8080/#/c/6874/8/src/kudu/util/debug-util.h File

[kudu-CR](branch-1.3.x) KUDU-2020: tserver failure causes multiple tablet copy operations per under-replicated tablet

2017-06-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2020: tserver failure causes multiple tablet copy operations per under-replicated tablet .. Patch Set 2: Was this a clean cherry-pick backport? -- To view,

[kudu-CR] Add a workaround for LSAN bug #757

2017-06-05 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Add a workaround for LSAN bug #757 .. Add a workaround for LSAN bug #757 This adds a workaround for an LSAN bug[1] which causes some tests to report false

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/6/src/kudu/consensus/consensus_meta.cc

[kudu-CR] external minicluster: expand EMC dir usage

2017-06-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 21: (1 comment)

[kudu-CR] threadpool: new test for pools with no max threads

2017-06-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: threadpool: new test for pools with no max_threads .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6945 To unsubscribe, visit

[kudu-CR] [python] Fix undefined TimeoutError in tests

2017-06-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [python] Fix undefined TimeoutError in tests .. Patch Set 1: Build failure cause: web ui was bound to a master RPC port (ephemeral ports) and messed up a

[kudu-CR](branch-1.3.x) [java-client] update protoc maven plugin

2017-06-05 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [java-client] update protoc maven plugin .. [java-client] update protoc maven plugin The current protoc maven plugin is not hosted on maven central and

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 Remove round-robin for block placement This is the first of a multi-patch patchset

[kudu-CR](branch-1.3.x) [java-client] update protoc maven plugin

2017-06-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] update protoc maven plugin .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7070 To unsubscribe, visit

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 8: Build failure looks like a random timeout in Python tests, which incidentally exposed a

[kudu-CR] [python] Fix undefined TimeoutError in tests

2017-06-05 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7078 Change subject: [python] Fix undefined TimeoutError in tests .. [python] Fix undefined TimeoutError in tests The tests use

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

2017-06-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2027 retry scan RPC if negotiation times out .. Patch Set 5: (2 comments)

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

2017-06-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-2027 retry scan RPC if negotiation times out .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/7037/4/src/kudu/client/scanner-internal.cc

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

2017-06-05 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7037 to look at the new patch set (#7). Change subject: KUDU-2027 retry scan RPC if negotiation times out .. KUDU-2027

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 47: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6636 To unsubscribe,

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

2017-06-05 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7037 to look at the new patch set (#6). Change subject: KUDU-2027 retry scan RPC if negotiation times out .. KUDU-2027

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 47: (3 comments) @dralves: this patch doesn't have that sort of test. Will add in a follow-up

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-05 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#47). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2027 retry scan RPC if negotiation times out .. Patch Set 5: (2 comments)

[kudu-CR] WIP Don't suicide on EIO

2017-06-05 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. Change subject: WIP Don't suicide on EIO .. Abandoned The contents of this patch have been split across gerrit/c/[7028, 7031] -- To view, visit http://gerrit.cloudera.org:8080/6773 To

[kudu-CR] WIP Don't suicide on EIO

2017-06-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: WIP Don't suicide on EIO .. Patch Set 11: (17 comments) This patch has been split into a few smaller ones! Will abandon this one.

[kudu-CR] WIP Don't suicide on EIO

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP Don't suicide on EIO .. Patch Set 11: (2 comments) had some old comments, feel free to ignore if no longer relevant. did the contents of this patch

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 46: last q: do you have a test that makes sure a ts boots from an old superblock (with no

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 40: (3 comments) looks, just nits.

[kudu-CR](branch-1.3.x) [java-client] update protoc maven plugin

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java-client] update protoc maven plugin .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7070 To unsubscribe, visit

[kudu-CR] threadpool: new test for pools with no max threads

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: threadpool: new test for pools with no max_threads .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6945 To unsubscribe,

[kudu-CR] server: move apply pool into ServerBase

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: server: move apply_pool into ServerBase .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6984 To unsubscribe, visit

[kudu-CR] consensus: consolidate Raft thread pools

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: consolidate Raft thread pools .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/6946/7/src/kudu/consensus/consensus_peers.cc

[kudu-CR] threadpool: token-based task sequencing

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: threadpool: token-based task sequencing .. Patch Set 8: (11 comments) http://gerrit.cloudera.org:8080/#/c/6874/8/src/kudu/util/debug-util.h File

[kudu-CR] Add a workaround for LSAN bug #757

2017-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a workaround for LSAN bug #757 .. Patch Set 1: Code-Review+2 agreed -- To view, visit http://gerrit.cloudera.org:8080/7052 To unsubscribe, visit