[kudu-CR] [iwyu] update std::move

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8088 to look at the new patch set (#2). Change subject: [iwyu] update std::move .. [iwyu] update std::move Updated

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8109 to review the following change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

[kudu-CR] KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

Hao Hao has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks .. Patch Set 7: (1 comment)

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 6: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8107 to look at the new patch set (#2). Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics

[kudu-CR] Allow tablet shutdown without completing txs

Andrew Wong has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/7439/11/src/kudu/tablet/mvcc.h File

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 6: Verified+1 Overriding Jenkins, unrelated test failures. -- To view, visit

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/8089/5/src/kudu/master/catalog_manager.cc

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#6). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic ..

[kudu-CR] KUDU-2149: avoid election stacking by restoring failure monitor semantics

Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8107 to review the following change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 5: Code-Review+1 (4 comments) Spotted a few nits (sorry -- I didn't see them in prior

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 5: Verified+1 Overriding Jenkins, failure was KUDU-2059. -- To view, visit

[kudu-CR] KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

Adar Dembo has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7656 to look at the new patch set (#7). Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

[kudu-CR] KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

Hao Hao has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/7656/6//COMMIT_MSG Commit

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#5). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic ..

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File

[kudu-CR] master: fix TSAN data race on ToString()

Adar Dembo has submitted this change and it was merged. Change subject: master: fix TSAN data race on ToString() .. master: fix TSAN data race on ToString() WARNING: ThreadSanitizer: data race (pid=14563) Read of size 4 at

[kudu-CR] master: fix TSAN data race on ToString()

David Ribeiro Alves has posted comments on this change. Change subject: master: fix TSAN data race on ToString() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8092 To unsubscribe, visit

[kudu-CR] docs: add a blurb about faststring usage

David Ribeiro Alves has posted comments on this change. Change subject: docs: add a blurb about faststring usage .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8106/1/docs/contributing.adoc File

[kudu-CR] docs: add a blurb about faststring usage

Adar Dembo has posted comments on this change. Change subject: docs: add a blurb about faststring usage .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8106/1/docs/contributing.adoc File

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File

[kudu-CR] docs: add a blurb about faststring usage

Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8106 to review the following change. Change subject: docs: add a blurb about faststring usage .. docs: add a blurb about

[kudu-CR] Avoid a few allocations while reading PBC files

Todd Lipcon has submitted this change and it was merged. Change subject: Avoid a few allocations while reading PBC files .. Avoid a few allocations while reading PBC files This reduces extra short-lived allocations while

[kudu-CR] Avoid a few allocations while reading PBC files

Todd Lipcon has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc File

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8089 to look at the new patch set (#4). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic ..

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File

[kudu-CR] Fix tablet state metrics race

Todd Lipcon has posted comments on this change. Change subject: Fix tablet state metrics race .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8082 To unsubscribe, visit

[kudu-CR] Avoid a few allocations while reading PBC files

Adar Dembo has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc File

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File

[kudu-CR] Avoid a few allocations while reading PBC files

Todd Lipcon has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc File

[kudu-CR] Fix tablet state metrics race

David Ribeiro Alves has posted comments on this change. Change subject: Fix tablet state metrics race .. Patch Set 4: lgtm, but is there a test you can reuse/easily add to? -- To view, visit

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 23: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6968 To

[kudu-CR] Fix tablet state metrics race

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8082 to look at the new patch set (#4). Change subject: Fix tablet state metrics race .. Fix tablet state metrics race

[kudu-CR] Fix tablet state metrics race

Will Berkeley has posted comments on this change. Change subject: Fix tablet state metrics race .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8082/3/src/kudu/tserver/ts_tablet_manager.cc File

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#23). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] Avoid a few allocations while reading PBC files

Todd Lipcon has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc File

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File

[kudu-CR] Avoid a few allocations while reading PBC files

Adar Dembo has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc File

[kudu-CR] Rename BlockTransaction to BlockCreationTransaction

Adar Dembo has posted comments on this change. Change subject: Rename BlockTransaction to BlockCreationTransaction .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8101 To unsubscribe, visit

[kudu-CR] KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

Adar Dembo has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks .. Patch Set 6: (1 comment)

[kudu-CR] Rename BlockTransaction to BlockCreationTransaction

Hao Hao has posted comments on this change. Change subject: Rename BlockTransaction to BlockCreationTransaction .. Patch Set 2: The failed test CatalogManagerTskITest.LeadershipChangeOnTskGeneration is not related to the

[kudu-CR] Rename BlockTransaction to BlockCreationTransaction

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8101 to look at the new patch set (#2). Change subject: Rename BlockTransaction to BlockCreationTransaction

[kudu-CR] KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks

Hao Hao has posted comments on this change. Change subject: KUDU-2055 [part 1]: Coalesce hole punching when deleting groups of blocks .. Patch Set 3: (3 comments)

[kudu-CR] Avoid unnecessary vector allocations for ReadV/WriteV-like APIs

Todd Lipcon has submitted this change and it was merged. Change subject: Avoid unnecessary vector allocations for ReadV/WriteV-like APIs .. Avoid unnecessary vector allocations for ReadV/WriteV-like APIs This reduces extra

[kudu-CR] Avoid unnecessary vector allocations for ReadV/WriteV-like APIs

Todd Lipcon has posted comments on this change. Change subject: Avoid unnecessary vector allocations for ReadV/WriteV-like APIs .. Patch Set 4: I'm going to go ahead and push this rather than wait for the LEGAL jira to be

[kudu-CR] Avoid a few allocations while reading PBC files

Todd Lipcon has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files .. Patch Set 5: Verified+1 Some python flake -- To view, visit http://gerrit.cloudera.org:8080/8009 To

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Adar Dembo has uploaded a new patch set (#3). Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. catalog_manager: make ScopedTabletInfoCommitter generic I want to use it for TableInfo mutations, and to

[kudu-CR] KUDU-1125: issue one catalog write per tablet report

Adar Dembo has uploaded a new patch set (#3). Change subject: KUDU-1125: issue one catalog write per tablet report .. KUDU-1125: issue one catalog write per tablet report This commit addresses a long-standing issue in the

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 22: (10 comments)

[kudu-CR] Rename BlockTransaction to BlockCreationTransaction

Adar Dembo has posted comments on this change. Change subject: Rename BlockTransaction to BlockCreationTransaction .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8101 To unsubscribe, visit

[kudu-CR] Avoid unnecessary vector allocations for ReadV/WriteV-like APIs

Adar Dembo has posted comments on this change. Change subject: Avoid unnecessary vector allocations for ReadV/WriteV-like APIs .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8077 To

[kudu-CR] Fix tablet state metrics race

Will Berkeley has posted comments on this change. Change subject: Fix tablet state metrics race .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8082/2/src/kudu/tserver/ts_tablet_manager.cc File

[kudu-CR] Fix tablet state metrics race

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8082 to look at the new patch set (#3). Change subject: Fix tablet state metrics race .. Fix tablet state metrics race

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 22: (10 comments)

[kudu-CR] Rename BlockTransaction to BlockCreationTransaction

Hao Hao has uploaded a new change for review. http://gerrit.cloudera.org:8080/8101 Change subject: Rename BlockTransaction to BlockCreationTransaction .. Rename BlockTransaction to BlockCreationTransaction This patch renames

[kudu-CR] Avoid unnecessary vector allocations for ReadV/WriteV-like APIs

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8077 to look at the new patch set (#4). Change subject: Avoid unnecessary vector allocations for ReadV/WriteV-like APIs

[kudu-CR] Avoid unnecessary vector allocations for ReadV/WriteV-like APIs

Todd Lipcon has posted comments on this change. Change subject: Avoid unnecessary vector allocations for ReadV/WriteV-like APIs .. Patch Set 3: (7 comments)

[kudu-CR] Allow tablet shutdown without completing txs

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#12). Change subject: Allow tablet shutdown without completing txs .. Allow tablet

[kudu-CR] Allow tablet shutdown without completing txs

Andrew Wong has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 11: (12 comments) Not yet ready for review. http://gerrit.cloudera.org:8080/#/c/7439/11//COMMIT_MSG

[kudu-CR] Link to troubleshooting docs for two common problems

Adar Dembo has posted comments on this change. Change subject: Link to troubleshooting docs for two common problems .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8093 To unsubscribe, visit

[kudu-CR] Link to troubleshooting docs for two common problems

Adar Dembo has submitted this change and it was merged. Change subject: Link to troubleshooting docs for two common problems .. Link to troubleshooting docs for two common problems >From experience, users don't know what to do

[kudu-CR] Link to troubleshooting docs for two common problems

David Ribeiro Alves has posted comments on this change. Change subject: Link to troubleshooting docs for two common problems .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8093 To unsubscribe,

[kudu-CR] standard notation for fixed-size integer type names

Alexey Serbin has submitted this change and it was merged. Change subject: standard notation for fixed-size integer type names .. standard notation for fixed-size integer type names Prefer the standard notation for fixed-size

[kudu-CR] standard notation for fixed-size integer type names

Todd Lipcon has posted comments on this change. Change subject: standard notation for fixed-size integer type names .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8099 To unsubscribe, visit

[kudu-CR] Fix tablet state metrics race

Todd Lipcon has posted comments on this change. Change subject: Fix tablet state metrics race .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8082/2/src/kudu/tserver/ts_tablet_manager.cc File

[kudu-CR] kudu-spark: change default master address to local fqdn

Attila Bukor has posted comments on this change. Change subject: kudu-spark: change default master address to local fqdn .. Patch Set 2: Code-Review+1 (1 comment)

[kudu-CR] kudu-spark: change default master address to local fqdn

Attila Bukor has posted comments on this change. Change subject: kudu-spark: change default master address to local fqdn .. Patch Set 2: -Code-Review (2 comments)

[kudu-CR] Link to troubleshooting docs for two common problems

Will Berkeley has posted comments on this change. Change subject: Link to troubleshooting docs for two common problems .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/8093/2/docs/troubleshooting.adoc File

[kudu-CR] Link to troubleshooting docs for two common problems

Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8093 to look at the new patch set (#4). Change subject: Link to troubleshooting docs for two common problems

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

Hao Hao has posted comments on this change. Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8041 to look at the new patch set (#4). Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

Hao Hao has posted comments on this change. Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

Hao Hao has posted comments on this change. Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 3: (5 comments) The failed test cases

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8041 to look at the new patch set (#3). Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/19/src/kudu/tablet/diskrowset.h File

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#22). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric