[kudu-CR] [sentry] add AuthzProvider

2018-10-31 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 7: (4 comments)

[kudu-CR] [sentry] add AuthzProvider

2018-10-31 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11659 to look at the new patch set (#7). Change subject: [sentry] add AuthzProvider

[kudu-CR] [util] Add ParseStringsWithScheme in net util

2018-10-31 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11843 to look at the new patch set (#2). Change subject: [util] Add ParseStringsWithScheme in net_util

[kudu-CR] [util] Add ParseStringsWithScheme in net util

2018-10-31 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11843 ) Change subject: [util] Add ParseStringsWithScheme in net_util .. Patch Set 1: (11 comments)

[kudu-CR] [docs] WARN AS ERROR requires doxygen >= 1.8.11

2018-10-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11832 ) Change subject: [docs] WARN_AS_ERROR requires doxygen >= 1.8.11 .. Patch Set 4: > So this means you can't run make_site.sh on el7

[kudu-CR] [util] Add ParseStringsWithScheme in net util

2018-10-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11843 ) Change subject: [util] Add ParseStringsWithScheme in net_util .. Patch Set 1: (4 comments)

[kudu-CR] [sentry] add AuthzProvider

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/11659 To

[kudu-CR] [util] Add ParseStringsWithScheme in net util

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11843 ) Change subject: [util] Add ParseStringsWithScheme in net_util .. Patch Set 1: (7 comments)

[kudu-CR] [sentry] add AuthzProvider

2018-10-31 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 6: (27 comments) http://gerrit.cloudera.org:8080/#/c/11659/5//COMMIT_MSG Commit

[kudu-CR] [sentry] add AuthzProvider

2018-10-31 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11659 to look at the new patch set (#6). Change subject: [sentry] add AuthzProvider

[kudu-CR] [util] Add ParseStringsWithScheme in net util

2018-10-31 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11843 Change subject: [util] Add ParseStringsWithScheme in net_util .. [util] Add ParseStringsWithScheme in net_util This commit adds a new util

[kudu-CR] [rebalancer] location-aware rebalancer (part 7/n)

2018-10-31 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11748 ) Change subject: [rebalancer] location-aware rebalancer (part 7/n) .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)

2018-10-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11761 ) Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. [rebalancer] location-aware rebalancer (part 8/n)

[kudu-CR] [rebalancer] location-aware rebalancer (part 7/n)

2018-10-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11748 ) Change subject: [rebalancer] location-aware rebalancer (part 7/n) .. [rebalancer] location-aware rebalancer (part 7/n) Added

[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)

2018-10-31 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11761 ) Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] [rebalancer] location-aware rebalancer (part 7/n)

2018-10-31 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11748 to look at the new patch set (#7). Change subject: [rebalancer] location-aware rebalancer (part 7/n)

[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)

2018-10-31 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11761 ) Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [rebalancer] location-aware rebalancer (part 7/n)

2018-10-31 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11748 ) Change subject: [rebalancer] location-aware rebalancer (part 7/n) .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] [rebalancer] location-aware rebalancer (part 7/n)

2018-10-31 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11748 to look at the new patch set (#6). Change subject: [rebalancer] location-aware rebalancer (part 7/n)

[kudu-CR] [cmake] place all DATA FILES under bin/testdata

2018-10-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11841 ) Change subject: [cmake] place all DATA_FILES under bin/testdata .. [cmake] place all DATA_FILES under bin/testdata Updated

[kudu-CR] [cmake] place all DATA FILES under bin/testdata

2018-10-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11841 ) Change subject: [cmake] place all DATA_FILES under bin/testdata .. Patch Set 2: Verified+1 Unrelated fluke in TSAN build -- To

[kudu-CR] [cmake] place all DATA FILES under bin/testdata

2018-10-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11841 ) Change subject: [cmake] place all DATA_FILES under bin/testdata .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR](refs/meta/config) Change e-mail notification recipient to reviews@kudu.apache.org

2018-10-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11840 ) Change subject: Change e-mail notification recipient to reviews@kudu.apache.org .. Patch Set 2: Verified+1 -- To view, visit

[kudu-CR] KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11394 ) Change subject: KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer .. Patch Set 12: Code-Review+2 Carrying forward

[kudu-CR] KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11395 ) Change subject: KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator .. KUDU-686 (part 2/2): use DeltaPreparer in

[kudu-CR] deltas: fuzz tests for delta file and dms

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11140 ) Change subject: deltas: fuzz tests for delta file and dms .. deltas: fuzz tests for delta file and dms Here are new fuzz tests

[kudu-CR] KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11394 ) Change subject: KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer .. KUDU-686 (part 1/2): decompose guts of

[kudu-CR] deltas: fuzz tests for delta file and dms

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11140 ) Change subject: deltas: fuzz tests for delta file and dms .. Patch Set 17: Code-Review+2 Carrying forward Mike's +2. -- To view, visit

[kudu-CR] [cmake] place all DATA FILES under bin/testdata

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11841 ) Change subject: [cmake] place all DATA_FILES under bin/testdata .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [cmake] place all DATA FILES under bin/testdata

2018-10-31 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11841 to look at the new patch set (#2). Change subject: [cmake] place all DATA_FILES under bin/testdata ..

[kudu-CR] [cmake] place all DATA FILES under bin/testdata

2018-10-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11841 ) Change subject: [cmake] place all DATA_FILES under bin/testdata .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11395 ) Change subject: KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator .. Patch Set 12: Code-Review+2 Carrying forward David's +2

[kudu-CR] KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11394 ) Change subject: KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer .. Patch Set 11: Code-Review+2 Carrying forward

[kudu-CR] common: add equality methods to ColumnBlock and SelectionVector

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11267 ) Change subject: common: add equality methods to ColumnBlock and SelectionVector .. common: add equality methods to ColumnBlock

[kudu-CR] common: add equality methods to ColumnBlock and SelectionVector

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11267 ) Change subject: common: add equality methods to ColumnBlock and SelectionVector .. Patch Set 11: Code-Review+2 Carrying forward Mike's

[kudu-CR] [cmake] place all DATA FILE under bin/testdata

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11841 ) Change subject: [cmake] place all DATA_FILE under bin/testdata .. Patch Set 1: (2 comments)

[kudu-CR] [cmake] place all DATA FILE under bin/testdata

2018-10-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11841 Change subject: [cmake] place all DATA_FILE under bin/testdata .. [cmake] place all DATA_FILE under bin/testdata Updated the

[kudu-CR](refs/meta/config) Change e-mail notification recipient to reviews@kudu.apache.org

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11840 ) Change subject: Change e-mail notification recipient to reviews@kudu.apache.org .. Patch Set 2: (1 comment)

[kudu-CR](refs/meta/config) Change e-mail notification recipient to reviews@kudu.apache.org

2018-10-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11840 ) Change subject: Change e-mail notification recipient to reviews@kudu.apache.org .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR](refs/meta/config) Change e-mail notification recipient to reviews@kudu.apache.org

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11840 Change subject: Change e-mail notification recipient to reviews@kudu.apache.org .. Change e-mail notification recipient to

[kudu-CR] [examples] Add basic Spark example (scala)

2018-10-31 Thread Mitch Barnett (Code Review)
Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 10: (6 comments)

[kudu-CR] revert change to exactly once writes-itest

2018-10-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11836 ) Change subject: revert change to exactly_once_writes-itest .. Patch Set 2: (1 comment)

[kudu-CR] [examples] Add basic Spark example (scala)

2018-10-31 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 10: (6 comments)

[kudu-CR] [build] Centralize project version to version.txt

2018-10-31 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11735 ) Change subject: [build] Centralize project version to version.txt .. [build] Centralize project version to version.txt This

[kudu-CR] [build] Centralize project version to version.txt

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11735 ) Change subject: [build] Centralize project version to version.txt .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] [build] Centralize project version to version.txt

2018-10-31 Thread Anonymous Coward (Code Review)
a...@phdata.io has posted comments on this change. ( http://gerrit.cloudera.org:8080/11735 ) Change subject: [build] Centralize project version to version.txt .. Patch Set 7: Code-Review+1 Looks good to me. -- To view,

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-10-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11827 ) Change subject: [compaction] Cleanup of compaction policy code .. Patch Set 3: (6 comments) Some nits, I didn't really looked at the

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-10-31 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11827 to look at the new patch set (#3). Change subject: [compaction] Cleanup of compaction policy code

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-10-31 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11827 to look at the new patch set (#2). Change subject: [compaction] Cleanup of compaction policy code

[kudu-CR] thirdparty: work around an upstream LLVM build race

2018-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11834 ) Change subject: thirdparty: work around an upstream LLVM build race .. Patch Set 2: Works for me. Thanks. -- To view, visit

[kudu-CR] thirdparty: work around an upstream LLVM build race

2018-10-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11834 ) Change subject: thirdparty: work around an upstream LLVM build race .. Patch Set 2: (2 comments) > Have you observed this succeed with

[kudu-CR] thirdparty: work around an upstream LLVM build race

2018-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11834 ) Change subject: thirdparty: work around an upstream LLVM build race .. Patch Set 2: (2 comments) Looks good to me. Bash

[kudu-CR] KUDU-2566: Enhance rowset tree pruning and stop copying strings

2018-10-31 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/11381 ) Change subject: KUDU-2566: Enhance rowset tree pruning and stop copying strings .. Patch Set 9: (47 comments) thanks to Adar and Will.

[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".

2018-10-31 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/11360 ) Change subject: KUDU-2529: Add a "-tables=" flag to the "kudu table list". .. Patch Set 9: (17 comments) sorry for the late reply, i

[kudu-CR] KUDU-2038: Support bitmap indexing

2018-10-31 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/11722 ) Change subject: KUDU-2038: Support bitmap indexing .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/11722/1//COMMIT_MSG

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-10-31 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11827 ) Change subject: [compaction] Cleanup of compaction policy code .. Patch Set 1: Code-Review+1 (3 comments)

[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)

2018-10-31 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11761 to look at the new patch set (#4). Change subject: [rebalancer] location-aware rebalancer (part 8/n)

[kudu-CR] [rebalancer] location-aware rebalancer (part 7/n)

2018-10-31 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11748 to look at the new patch set (#5). Change subject: [rebalancer] location-aware rebalancer (part 7/n)