[kudu-CR] KUDU-3079 Add MiniRanger

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 ) Change subject: KUDU-3079 Add MiniRanger .. Patch Set 22: (12 comments) http://gerrit.cloudera.org:8080/#/c/15483/16/src/kudu/mini-clust

[kudu-CR] KUDU-3079 Add MiniPostgres

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 ) Change subject: KUDU-3079 Add MiniPostgres .. Patch Set 21: (14 comments) http://gerrit.cloudera.org:8080/#/c/15374/21/src/kudu/postgres

[kudu-CR] [util] GetBindIpForDaemon() consumes PID wider than 18 bit

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15519 ) Change subject: [util] GetBindIpForDaemon() consumes PID wider than 18 bit .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#

[kudu-CR] server: make FS layout creation message less agressive

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15521 ) Change subject: server: make FS layout creation message less agressive .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clo

[kudu-CR] test: add some buffer in timing metrics

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15518 ) Change subject: test: add some buffer in timing metrics .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 ) Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets .. Patch Set 9: Code-Review+2 -- To view, visit http://ger

[kudu-CR] tablet: cache delta stats when flushing a DMS

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15460 ) Change subject: tablet: cache delta stats when flushing a DMS .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] tablet: plumb delta stats into delta compaction outputs

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15506 ) Change subject: tablet: plumb delta stats into delta compaction outputs .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] KUDU-3079 Add MiniRanger

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 ) Change subject: KUDU-3079 Add MiniRanger .. Patch Set 16: (43 comments) http://gerrit.cloudera.org:8080/#/c/15483/16//COMMIT_MSG Commit

[kudu-CR] KUDU-3079 Add MiniPostgres

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 ) Change subject: KUDU-3079 Add MiniPostgres .. Patch Set 15: (20 comments) http://gerrit.cloudera.org:8080/#/c/15374/15/src/kudu/ranger/C

[kudu-CR] [mini kdc] MiniKdc::Kinit() atomically replaces ccache

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15516 ) Change subject: [mini_kdc] MiniKdc::Kinit() atomically replaces ccache .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clo

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 8: (1 comment) http://gerrit.cloudera.or

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 ) Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:80

[kudu-CR] tablet: plumb delta stats into delta compaction outputs

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15506 ) Change subject: tablet: plumb delta stats into delta compaction outputs .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] tell IWYU to keep all inclusions of kudu/client/shared ptr.h

Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15490 ) Change subject: tell IWYU to keep all inclusions of kudu/client/shared_ptr.h .. Removed reviewer Kudu Jenkins with the following v

[kudu-CR] tell IWYU to keep all inclusions of kudu/client/shared ptr.h

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15490 ) Change subject: tell IWYU to keep all inclusions of kudu/client/shared_ptr.h .. Patch Set 2: Verified+1 Overriding Jenkins, dist-test bui

[kudu-CR] tell IWYU to keep all inclusions of kudu/client/shared ptr.h

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15490 ) Change subject: tell IWYU to keep all inclusions of kudu/client/shared_ptr.h .. tell IWYU to keep all inclusions of kudu/client/sh

[kudu-CR] tserver: avoid spinlock in scanners hot path

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15502 ) Change subject: tserver: avoid spinlock in scanners hot path .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] [thirdparty] python3 is good for building LLVM

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 ) Change subject: [thirdparty] python3 is good for building LLVM .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[kudu-CR] tablet: plumb delta stats into delta compaction outputs

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15506 ) Change subject: tablet: plumb delta stats into delta compaction outputs .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] tablet: cache delta stats when flushing a DMS

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15460 ) Change subject: tablet: cache delta stats when flushing a DMS .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 ) Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets .. Patch Set 7: (8 comments) http://gerrit.cloudera.org:80

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] [thirdparty] python3 is good for building LLVM

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 ) Change subject: [thirdparty] python3 is good for building LLVM .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15504/5/t

[kudu-CR] client: micro-optimize getters by outlining cold path

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15503 ) Change subject: client: micro-optimize getters by outlining cold path .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.o

[kudu-CR] tserver: avoid spinlock in scanners hot path

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15502 ) Change subject: tserver: avoid spinlock in scanners hot path .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] client: avoid an extra construction of ColumnSchema

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15501 ) Change subject: client: avoid an extra construction of ColumnSchema .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloude

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 3: Nothing to add to Andrew's comments. -- To vi

[kudu-CR] util: stop using namespaces

Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15491 ) Change subject: util: stop using namespaces .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenki

[kudu-CR] util: stop using namespaces

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15491 ) Change subject: util: stop using namespaces .. util: stop using namespaces There were a few holdouts of this, most likely from im

[kudu-CR] util: stop using namespaces

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15491 ) Change subject: util: stop using namespaces .. Patch Set 2: Verified+1 Overriding Jenkins, failure was in the dist-test build directory.

[kudu-CR] [ranger] pass 'principal' and 'keytab' to the subprocess

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15416 ) Change subject: [ranger] pass 'principal' and 'keytab' to the subprocess .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] tell IWYU to keep all inclusions of kudu/client/shared ptr.h

Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15490 to look at the new patch set (#2). Change subject: tell IWYU to keep all inclusions of kudu/client/shared_ptr.h ...

[kudu-CR] util: stop using namespaces

Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15491 to look at the new patch set (#2). Change subject: util: stop using namespaces

[kudu-CR] WIP: iwyu: standardize on libc++

Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15492 to look at the new patch set (#3). Change subject: WIP: iwyu: standardize on libc++ ...

[kudu-CR] tell IWYU to keep all inclusions of kudu/client/shared ptr.h

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15490 ) Change subject: tell IWYU to keep all inclusions of kudu/client/shared_ptr.h .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] WIP: iwyu: standardize on libc++

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: WIP: iwyu: standardize on libc++ .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15492/2//COMMIT_MSG Com

[kudu-CR] WIP: iwyu: standardize on libc++

Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15492 to look at the new patch set (#2). Change subject: WIP: iwyu: standardize on libc++ ...

[kudu-CR] WIP: iwyu: standardize on libc++

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: WIP: iwyu: standardize on libc++ .. Patch Set 1: You can see the output of iwyu.py --all here: https://pastebin.com/FXM7P

[kudu-CR] util: stop using namespaces

Hello Alexey Serbin, Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15491 to review the following change. Change subject: util: stop using namespaces .. util: stop

[kudu-CR] tell IWYU to keep all inclusions of kudu/client/shared ptr.h

Hello Alexey Serbin, Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15490 to review the following change. Change subject: tell IWYU to keep all inclusions of kudu/client/shared_ptr.h .

[kudu-CR] WIP: iwyu: standardize on libc++

Hello Alexey Serbin, Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15492 to review the following change. Change subject: WIP: iwyu: standardize on libc++ .. WIP:

[kudu-CR] metrics: replace kudu::Bind usage with lambdas in FunctionGauge

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15474 ) Change subject: metrics: replace kudu::Bind usage with lambdas in FunctionGauge .. metrics: replace kudu::Bind usage with lambdas

[kudu-CR] [util] KUDU-3067 add OpenStack metadata detector

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15488 ) Change subject: [util] KUDU-3067 add OpenStack metadata detector .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:80

[kudu-CR] [ranger] validate the JAR file path of the subprocess

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 ) Change subject: [ranger] validate the JAR file path of the subprocess .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] [ranger] pass 'principal' and 'keytab' to the subprocess

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15416 ) Change subject: [ranger] pass 'principal' and 'keytab' to the subprocess .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#

[kudu-CR] [client] Mark the Bloom filter predicate method as experimental

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15486 ) Change subject: [client] Mark the Bloom filter predicate method as experimental .. Patch Set 1: Code-Review+2 -- To view, visit http://g

[kudu-CR] metrics: replace kudu::Bind usage with lambdas in FunctionGauge

Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15474 ) Change subject: metrics: replace kudu::Bind usage with lambdas in FunctionGauge .. Removed reviewer Kudu Jenkins with the followin

[kudu-CR] metrics: replace kudu::Bind usage with lambdas in FunctionGauge

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15474 ) Change subject: metrics: replace kudu::Bind usage with lambdas in FunctionGauge .. Patch Set 2: Verified+1 Overriding Jenkins, known mt-t

[kudu-CR] metrics: replace kudu::Bind usage with lambdas in FunctionGauge

Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15474 to look at the new patch set (#2). Change subject: metrics: replace kudu::Bind usage with lambdas in FunctionGauge .

[kudu-CR] [build] Skip builds with no functional changes

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15481 ) Change subject: [build] Skip builds with no functional changes .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[kudu-CR] block bloom filter: quell warning in release build

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15478 ) Change subject: block_bloom_filter: quell warning in release build .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR] linked list-test-util: quelch warning

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15479 ) Change subject: linked_list-test-util: quelch warning .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15

[kudu-CR] [build] Skip builds with no functional changes

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15481 ) Change subject: [build] Skip builds with no functional changes .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/15481/4/

[kudu-CR] metrics: replace kudu::Bind usage with lambdas in FunctionGauge

Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15474 to review the following change. Change subject: metrics: replace kudu::Bind usage with lambdas in FunctionGauge ...

[kudu-CR] KUDU-1625: background op to GC ancient, fully deleted rowsets

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 ) Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets .. Patch Set 4: (20 comments) http://gerrit.cloudera.org:8

[kudu-CR] thread: simplify Thread::Create API

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15448 ) Change subject: thread: simplify Thread::Create API .. thread: simplify Thread::Create API I set out to remove boost::bind from t

[kudu-CR] remove kudu::Thread from tests

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15447 ) Change subject: remove kudu::Thread from tests .. remove kudu::Thread from tests std::thread is much more ergonomic, evidenced in

[kudu-CR] remove kudu::Thread from tests

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15447 ) Change subject: remove kudu::Thread from tests .. Patch Set 3: (13 comments) http://gerrit.cloudera.org:8080/#/c/15447/3/src/kudu/fs/blo

[kudu-CR] remove kudu::Thread from tests

Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15447 to look at the new patch set (#4). Change subject: remove kudu::Thread from tests .. re

[kudu-CR] [build] Fix buildSrc lock timeout

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15470 ) Change subject: [build] Fix buildSrc lock timeout .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15470/1/CMakeLists.txt

[kudu-CR] tablet: cache delta stats when flushing a DMS

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15460 ) Change subject: tablet: cache delta stats when flushing a DMS .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[kudu-CR] [tools] add test coverage for flags categories in ksck

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15458 ) Change subject: [tools] add test coverage for flags categories in ksck .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clo

[kudu-CR] build: fix linker error in BloomFileTestBase

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15459 ) Change subject: build: fix linker error in BloomFileTestBase .. build: fix linker error in BloomFileTestBase I saw this when buil

[kudu-CR] build: fix linker error in BloomFileTestBase

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15459 ) Change subject: build: fix linker error in BloomFileTestBase .. Patch Set 1: Code-Review+2 Sorry about that. -- To view, visit http://g

[kudu-CR] WIP [release notes] supported NTP servers and time source

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15456 ) Change subject: WIP [release notes] supported NTP servers and time source .. Patch Set 2: Code-Review+2 Seems good to me. -- To view, v

[kudu-CR] KUDU-3068 Add atomic operations for aarch64

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15455 ) Change subject: KUDU-3068 Add atomic operations for aarch64 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15455/1/src/

[kudu-CR] remove kudu::Thread from tests

Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15447 to look at the new patch set (#3). Change subject: remove kudu::Thread from tests .. re

[kudu-CR] thread: simplify Thread::Create API

Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15448 to look at the new patch set (#3). Change subject: thread: simplify Thread::Create API .

[kudu-CR] BloomFileTestBase: refactor test fixture

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15446 ) Change subject: BloomFileTestBase: refactor test fixture .. BloomFileTestBase: refactor test fixture clang-tidy flags the gflag d

[kudu-CR] WIP [release notes] supported NTP servers and new time source

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15456 ) Change subject: WIP [release notes] supported NTP servers and new time source .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:80

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 ) Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] KUDU-3068 Add atomic operations for aarch64

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15455 ) Change subject: KUDU-3068 Add atomic operations for aarch64 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15455/1/src/

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15450 ) Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. Patch Set 2: Code-Review+2 -- To view, visit http://gerr

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15450 ) Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. Removed reviewer Kudu Jenkins with the following v

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15450 ) Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. Patch Set 2: Verified+1 (1 comment) Overriding Jenkins,

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15450 ) Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. [util] Minor changes in BlockBloomFilter requested

[kudu-CR] build-and-test.sh: address follow-up feedback from Andrew

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15452 ) Change subject: build-and-test.sh: address follow-up feedback from Andrew .. Patch Set 1: Verified+1 Overriding Jenkins, unrelated test f

[kudu-CR] build-and-test.sh: address follow-up feedback from Andrew

Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15452 ) Change subject: build-and-test.sh: address follow-up feedback from Andrew .. Removed reviewer Kudu Jenkins with the following vote

[kudu-CR] build-and-test.sh: address follow-up feedback from Andrew

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15452 ) Change subject: build-and-test.sh: address follow-up feedback from Andrew .. build-and-test.sh: address follow-up feedback from An

[kudu-CR] [build] Disable parallel Gradle builds in pre-commit.

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15453 ) Change subject: [build] Disable parallel Gradle builds in pre-commit. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] BloomFileTestBase: refactor test fixture

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15446 ) Change subject: BloomFileTestBase: refactor test fixture .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15446/1//COMMIT

[kudu-CR] BloomFileTestBase: refactor test fixture

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15446 ) Change subject: BloomFileTestBase: refactor test fixture .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15446/1/src/kud

[kudu-CR] BloomFileTestBase: refactor test fixture

Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15446 to look at the new patch set (#2). Change subject: BloomFileTestBase: refactor test fixture

[kudu-CR] remove kudu::Thread from tests

Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15447 to look at the new patch set (#2). Change subject: remove kudu::Thread from tests .. re

[kudu-CR] build-and-test.sh: address follow-up feedback from Andrew

Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15452 to review the following change. Change subject: build-and-test.sh: address follow-up feedback from Andrew .. build-an

[kudu-CR] build-and-test.sh: fix TIDY build

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15445 ) Change subject: build-and-test.sh: fix TIDY build .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15445/2/build-support/

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15424 ) Change subject: [client] Add C++ API to accept BlockBloomFilter directly .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.c

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15450 ) Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:808

[kudu-CR] [build] address compilation warnings from GCC 8.3.1

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15437 ) Change subject: [build] address compilation warnings from GCC 8.3.1 .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org

[kudu-CR] [subprocess] copy subprocess JAR to be next to the master binary

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 ) Change subject: [subprocess] copy subprocess JAR to be next to the master binary .. Patch Set 3: (2 comments) http://gerrit.cloudera.org

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15420 ) Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64 .. Patch Set 2: Verified+1 Code-Review+2 > @Grant Henke > I ha

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15424 ) Change subject: [client] Add C++ API to accept BlockBloomFilter directly .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15450 ) Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:808

[kudu-CR] thread: simplify Thread::Create API

Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15448 to review the following change. Change subject: thread: simplify Thread::Create API .. thread: simplif

[kudu-CR] BloomFileTestBase: refactor test fixture

Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15446 to review the following change. Change subject: BloomFileTestBase: refactor test fixture .. BloomFileT

[kudu-CR] remove kudu::Thread from tests

Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15447 to review the following change. Change subject: remove kudu::Thread from tests .. remove kudu::Thread

[kudu-CR] build-and-test.sh: fix TIDY build

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15445 ) Change subject: build-and-test.sh: fix TIDY build .. build-and-test.sh: fix TIDY build The Jenkins job that runs the TIDY build d

<    1   2   3   4   5   6   7   8   9   10   >