Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 1): master should accept heartbeat even if
follower
..
Patch Set 12:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/3609/12//COMMIT_MSG
Commit
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3645
to look at the new patch set (#8).
Change subject: master: do not delete unknown tablets
..
master:
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3645
to look at the new patch set (#7).
Change subject: master: do not delete unknown tablets
Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3718
to review the following change.
Change subject: c++ client: use operation timeout as deadline for finding new
leader master
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3611
to look at the new patch set (#11).
Change subject: KUDU-1358 (part 3): new multi-master stress test
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3643
to look at the new patch set (#7).
Change subject: KUDU-1374: send full tablet report when new leader master is
detected
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3609
to look at the new patch set (#11).
Change subject: KUDU-1358 (part 1): master should accept heartbeat even if
follower
Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 3): new multi-master stress test
..
Patch Set 10:
(3 comments)
Adar Dembo has posted comments on this change.
Change subject: KUDU-1311 [master] support adding and dropping range partitions
..
Patch Set 11:
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: KUDU-1311 [master] support adding and dropping range partitions
..
Patch Set 9:
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: KUDU-1311 [master] support adding and dropping range partitions
..
Patch Set 9:
(2 comments)
Adar Dembo has posted comments on this change.
Change subject: client/sample.cc: fixed a couple of crashes
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3685/1//COMMIT_MSG
Commit Message:
Line 11: while
Adar Dembo has uploaded a new patch set (#10).
Change subject: KUDU-1358 (part 3): new multi-master stress test
..
KUDU-1358 (part 3): new multi-master stress test
This commit adds a stress test for multiple masters. The idea
Adar Dembo has uploaded a new patch set (#6).
Change subject: master: do not delete unknown tablets
..
master: do not delete unknown tablets
Quoting from docs/design-docs/multi-master-1.0.md:
"The master and/or tserver must
Hello Dan Burkert,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3609
to look at the new patch set (#10).
Change subject: KUDU-1358 (part 1): master should accept heartbeat even if
follower
Adar Dembo has uploaded a new patch set (#6).
Change subject: KUDU-1374: send full tablet report when new leader master is
detected
..
KUDU-1374: send full tablet report when new leader master is detected
This should help
Adar Dembo has posted comments on this change.
Change subject: KUDU-1374: send full tablet report when new leader master is
detected
..
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3643/5//COMMIT_MSG
Commit
Adar Dembo has posted comments on this change.
Change subject: [java-client] Re-enable multi-master tests
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3654
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: master: do not delete unknown tablets
..
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3645/5//COMMIT_MSG
Commit Message:
Line 7: master: do not
Adar Dembo has posted comments on this change.
Change subject: Doxygen for C++ client API
..
Patch Set 11:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/3619/9/src/kudu/client/client.h
File src/kudu/client/client.h:
> 1.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 3): new multi-master stress test
..
Patch Set 9:
(4 comments)
Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 2): heartbeat to every master
..
Patch Set 9:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/3610/9/src/kudu/tserver/heartbeater.cc
File
Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 1): master should accept heartbeat even if
follower
..
Patch Set 9:
(1 comment)
> (1 comment)
>
> Any way to system test this, like calling
Adar Dembo has posted comments on this change.
Change subject: [java-client] fix soundness hole in flushing async kudu session
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3676
To
Adar Dembo has posted comments on this change.
Change subject: KUDU-1311 [master] support adding and dropping range partitions
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3648
To
Adar Dembo has posted comments on this change.
Change subject: [java-client] Re-enable multi-master tests
..
Patch Set 3:
(6 comments)
Adar Dembo has posted comments on this change.
Change subject: KUDU-1311 [master] support adding and dropping range partitions
..
Patch Set 6:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/3648/6/src/kudu/client/client.cc
Adar Dembo has posted comments on this change.
Change subject: async background flush provision for C++ client
..
Patch Set 1:
What was the rationale behind using a dedicated thread to manage background
flushing? I think
Adar Dembo has posted comments on this change.
Change subject: doxygen for C++ client API
..
Patch Set 9:
(65 comments)
http://gerrit.cloudera.org:8080/#/c/3619/9/src/kudu/client/client.h
File src/kudu/client/client.h:
High
Adar Dembo has submitted this change and it was merged.
Change subject: master: add assert checks for leader_lock
..
master: add assert checks for leader_lock
A side effect of recursive checking in RWMutex is that we can now
Adar Dembo has submitted this change and it was merged.
Change subject: rw_mutex: prevent recursive use
..
rw_mutex: prevent recursive use
Todd provided an example[1] of deadlocked rwlocks due to a fairness policy.
In the
Adar Dembo has posted comments on this change.
Change subject: Memory tracking for result tracker
..
Patch Set 18:
(1 comment)
I don't have any more comments except on the tests.
Adar Dembo has posted comments on this change.
Change subject: Memory tracking for result tracker
..
Patch Set 13:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/3627/13/src/kudu/rpc/result_tracker.cc
File
Adar Dembo has posted comments on this change.
Change subject: doxygen for C++ client API
..
Patch Set 8:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3619/8/CMakeLists.txt
File CMakeLists.txt:
Line 989:
Adar Dembo has posted comments on this change.
Change subject: doxygen for C++ client API
..
Patch Set 8:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/3619/8/CMakeLists.txt
File CMakeLists.txt:
Line 983:
Adar Dembo has posted comments on this change.
Change subject: Memory tracking for result tracker
..
Patch Set 9:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/3627/9/src/kudu/rpc/result_tracker.cc
File
Hello Dan Burkert,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3641
to look at the new patch set (#6).
Change subject: rw_mutex: prevent recursive use
..
rw_mutex: prevent recursive
Adar Dembo has posted comments on this change.
Change subject: KUDU-1530: Update docs about OS X build dependency on Xcode
package
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3653
To
Adar Dembo has posted comments on this change.
Change subject: Move the maintenance manager to util
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3656/3/src/kudu/util/maintenance_manager.h
File
Adar Dembo has posted comments on this change.
Change subject: KUDU-1311 [master] support adding and dropping range partitions
..
Patch Set 4:
(37 comments)
http://gerrit.cloudera.org:8080/#/c/3648/4/src/kudu/client/client.cc
Adar Dembo has posted comments on this change.
Change subject: Move the maintenance manager to util
..
Patch Set 1:
(15 comments)
What's the motivation for this move?
http://gerrit.cloudera.org:8080/#/c/3656/1//COMMIT_MSG
Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 3): new multi-master stress test
..
Patch Set 9: Verified+1
chrpath() failures.
--
To view, visit http://gerrit.cloudera.org:8080/3611
To
Adar Dembo has posted comments on this change.
Change subject: rw_mutex: prevent recursive use
..
Patch Set 5: Verified+1
KUDU-1527 and isolate failures.
--
To view, visit http://gerrit.cloudera.org:8080/3641
To unsubscribe,
Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 2): heartbeat to every master
..
Patch Set 9: Verified+1
Isolate failed.
--
To view, visit http://gerrit.cloudera.org:8080/3610
To unsubscribe,
Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 1): master should accept heartbeat even if
follower
..
Patch Set 9: Verified+1
chrpath() failed.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: master: do not delete unknown tablets
..
Patch Set 5: Verified+1
More isolate and chrpath() failures.
--
To view, visit http://gerrit.cloudera.org:8080/3645
To
Adar Dembo has posted comments on this change.
Change subject: KUDU-1374: send full tablet report when new leader master is
detected
..
Patch Set 5: Verified+1
More chrpath() and isolate failures.
--
To view, visit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3610
to look at the new patch set (#9).
Change subject: KUDU-1358 (part 2): heartbeat to every master
..
KUDU-1358
Adar Dembo has submitted this change and it was merged.
Change subject: master: add read-write lock to serialize operations around
elections
..
master: add read-write lock to serialize operations around elections
This
Adar Dembo has submitted this change and it was merged.
Change subject: master: fix corruption when AlterTable() races with
CreateTable()
..
master: fix corruption when AlterTable() races with CreateTable()
Admittedly, this
Adar Dembo has posted comments on this change.
Change subject: master: fix corruption when AlterTable() races with
CreateTable()
..
Patch Set 7: Verified+1
Isolate crashed.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 3): new multi-master stress test
..
Patch Set 8: Verified+1
Another instance of KUDU-1527.
--
To view, visit http://gerrit.cloudera.org:8080/3611
Adar Dembo has posted comments on this change.
Change subject: c++ client: various fixes to DDL operations
..
Patch Set 8: Verified+1
A whole slew of chrpath() failures in dist-test.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: master: add assert checks for leader_lock
..
Patch Set 4: Verified+1
Another chrpath() failure in dist-test.
--
To view, visit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3641
to look at the new patch set (#4).
Change subject: rw_mutex: prevent recursive use
..
rw_mutex: prevent recursive
Adar Dembo has posted comments on this change.
Change subject: rw_mutex: prevent recursive use
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3641/1/src/kudu/util/rw_mutex.h
File src/kudu/util/rw_mutex.h:
Adar Dembo has posted comments on this change.
Change subject: WIP [java-client] Re-enable multi-master tests
..
Patch Set 1:
(2 comments)
Adar Dembo has posted comments on this change.
Change subject: [c++-client]: cache non-covering ranges in meta cache
..
Patch Set 5:
(17 comments)
http://gerrit.cloudera.org:8080/#/c/3581/5/src/kudu/client/client-test.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3641
to look at the new patch set (#3).
Change subject: rw_mutex: prevent recursive use
..
rw_mutex: prevent recursive
Adar Dembo has posted comments on this change.
Change subject: rw_mutex: add configurable priority
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3603/4/src/kudu/util/rw_mutex.h
File src/kudu/util/rw_mutex.h:
Adar Dembo has posted comments on this change.
Change subject: env: add GetFileSizeOnDiskRecursively
..
Patch Set 2: Verified+1
Unrelated flake in ClientStressTest.StartScans.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 1): master should accept heartbeat even if
follower
..
Patch Set 6: Verified+1
Two isolate failures and one chrpath failure.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: master: do not delete unknown tablets
..
Patch Set 2: Verified+1
One run failed from the same dist-failure as
http://gerrit.cloudera.org:8080/3610/6. Another
Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 2): heartbeat to every master
..
Patch Set 6: Verified+1
Looks like I got hit by some sort of sporadic dist-test failure:
open: Text file busy
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3550
to look at the new patch set (#8).
Change subject: master: add read-write lock to serialize operations around
elections
Adar Dembo has posted comments on this change.
Change subject: [java client] Redo how we manage exceptions
..
Patch Set 8: Code-Review+1
Will leave the +2ing for Dan, since he had some comments originally.
--
To view, visit
Hello Dan Burkert, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3550
to look at the new patch set (#7).
Change subject: master: add read-write lock to serialize operations around
elections
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3610
to look at the new patch set (#5).
Change subject: KUDU-1358 (part 2): heartbeat to every master
..
KUDU-1358
Adar Dembo has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3641
Change subject: rw_mutex: prevent recursive use
..
rw_mutex: prevent recursive use
Todd provided an example[1] of deadlocked rwlocks due
Adar Dembo has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3643
Change subject: KUDU-1374: send full tablet report when new leader master is
detected
..
KUDU-1374: send full tablet report when new
Adar Dembo has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3642
Change subject: master: add assert checks for leader_lock
..
master: add assert checks for leader_lock
A side effect of recursive checking
Adar Dembo has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3645
Change subject: master: do not delete unknown tablets
..
master: do not delete unknown tablets
Quoting from the multi-master design doc:
Adar Dembo has posted comments on this change.
Change subject: [java client] Redo how we manage exceptions
..
Patch Set 7:
(3 comments)
Only a few nits left.
When you're done, could you make a pass over the client-consuming
Adar Dembo has posted comments on this change.
Change subject: rw_mutex: add configurable priority
..
Patch Set 3:
> I have experienced in the past an issue where the fairness policy
> causes a deadlock. See
>
Adar Dembo has posted comments on this change.
Change subject: [java client] Redo how we manage exceptions
..
Patch Set 5:
(2 comments)
Adar Dembo has posted comments on this change.
Change subject: [java client] Redo how we manage exceptions
..
Patch Set 5:
(16 comments)
Definitely make a pass over the Javadoc for:
1. Adding @throws where necessary, and
2.
Adar Dembo has posted comments on this change.
Change subject: [c++-client]: cache non-covering ranges in meta cache
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3581/1/src/kudu/client/meta_cache.h
File
Adar Dembo has posted comments on this change.
Change subject: master: reduce timeout for master to tserver rpcs
..
Patch Set 3:
> I do recall seeing a once-in-a-blue-moon AlterTable() timeout that
> I traced back to this 30s
Adar Dembo has abandoned this change.
Change subject: master: reduce timeout for master to tserver rpcs
..
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/3606
To unsubscribe, visit
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3608
to look at the new patch set (#4).
Change subject: c++ client: various fixes to DDL operations
..
c++
Adar Dembo has posted comments on this change.
Change subject: Update docs on how to run gcovr
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3508
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: Add weekly update for 07/11
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3616
To unsubscribe, visit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3610
to look at the new patch set (#3).
Change subject: KUDU-1358 (part 2): heartbeat to every master
..
KUDU-1358
Adar Dembo has submitted this change and it was merged.
Change subject: rw_mutex: add try lock methods
..
rw_mutex: add try lock methods
I found these to be useful, so I'm exposing them in our wrapper, and beefing
up
Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 2): heartbeat to every master
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3610/2/src/kudu/tserver/heartbeater.cc
File
Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 1): master should accept heartbeat even if
follower
..
Patch Set 2:
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: master: reduce timeout for master to tserver rpcs
..
Patch Set 2:
Filed KUDU-1526 for the test failure (which appears to be an unrelated flake).
> I think we
Adar Dembo has posted comments on this change.
Change subject: master: reduce timeout for master to tserver rpcs
..
Patch Set 2:
> I think we bumped this to be pretty high because we found that
> creating a new tablet can
Adar Dembo has posted comments on this change.
Change subject: rw_mutex: add configurable priority
..
Patch Set 2:
> Is there any possibility that the different priorities could create
> a case where OSX would deadlock but
Adar Dembo has posted comments on this change.
Change subject: c++ client: various fixes to DDL operations
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3608/1/src/kudu/client/client-internal.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3604
to look at the new patch set (#2).
Change subject: rw_mutex: add try lock methods
..
rw_mutex: add try lock
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3550
to look at the new patch set (#5).
Change subject: master: add read-write lock to serialize operations around
elections
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3603
to look at the new patch set (#2).
Change subject: rw_mutex: add configurable priority
..
rw_mutex: add
Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 1): master should accept heartbeat even if
follower
..
Patch Set 1:
Filed KUDU-1521 for the Java test failure.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: master: fix corruption when AlterTable() races with
CreateTable()
..
Patch Set 1:
(2 comments)
The test failure was in the initial write to ITScannerMultiTablet.
Adar Dembo has posted comments on this change.
Change subject: master: add read-write lock to serialize operations around
elections
..
Patch Set 4:
(2 comments)
Adar Dembo has submitted this change and it was merged.
Change subject: master-test: rewrite to use std::thread instead of kudu::Thread
..
master-test: rewrite to use std::thread instead of kudu::Thread
It's more terse than
Adar Dembo has posted comments on this change.
Change subject: rw_mutex: add configurable priority
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3603/1/src/kudu/util/rw_mutex.h
File
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3608
to review the following change.
Change subject: c++ client: various fixes to DDL operations
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3607
to review the following change.
Change subject: master: fix corruption when AlterTable() races with
CreateTable()
1 - 100 of 308 matches
Mail list logo
