Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41187/#review110924 --- Thanks! A few wording suggestions, and a clarification of

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review110922 --- This review depends on 41189, but 41189 is somehow marked as

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

> On Dec. 10, 2015, 2:40 a.m., Adam B wrote: > > include/mesos/master/allocator.proto, line 19 > > > > > > Shouldn't this file have `java_package` and `java_outer_classname` just > > like the other protos? > >

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/ --- (Updated Dec. 17, 2015, 1:18 a.m.) Review request for mesos, Artem

Re: Review Request 41490: Provisioner: Added test case for docker v1 manifest serialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41490/ --- (Updated Dec. 17, 2015, 1:18 a.m.) Review request for mesos, Artem

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/ --- (Updated Dec. 17, 2015, 10:26 a.m.) Review request for mesos, Alexander

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 17, 2015, 9:33 a.m.) Review request for mesos, Adam B and Anand

Review Request 41503: [WIP] evict executor in slaves

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41503/ --- Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van

Review Request 41502: [WIP] offer allocation slack in allocator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41502/ --- Review request for mesos and Guangya Liu. Repository: mesos Description

Re: Review Request 41407: Unified Container: Save all docker image information on disk instead of rootfs only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41407/ --- (Updated Dec. 17, 2015, 1:16 a.m.) Review request for mesos, Artem

Re: Review Request 41333: Added helper functions to filter usage slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- (Updated Dec. 17, 2015, 9:37 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41334: Added helper functions to filter allocation slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41334/ --- (Updated Dec. 17, 2015, 9:43 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41337: WIP: Set task as TASK_LOST if not enough allocation slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41337/ --- (Updated Dec. 17, 2015, 9:22 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

> On Dec. 17, 2015, 8:37 a.m., Kevin Klues wrote: > > This review depends on 41189, but 41189 is somehow marked as "Invite-only", > > so it is not viewable by the public. This is causing the jenkins > > review-bot to fail with: > > > > Verifying review 41381 > > Dependent review:

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/#review110925 --- Ship it! include/mesos/authorizer/authorizer.proto (line 127)

Review Request 41501: [WIP] Add flatten & allocationSlack into resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41501/ --- Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/#review110928 --- Ship it! include/mesos/authorizer/authorizer.hpp (lines 177 -

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

> On Dec. 17, 2015, 10:20 a.m., Joerg Schad wrote: > > include/mesos/authorizer/authorizer.hpp, lines 177-180 > > > > > > , otherwise ... (Consistent with the other comments) - Joerg

Re: Review Request 41334: Added helper functions to filter allocation slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41334/#review110931 --- @Guangya, there's some my comments: - add a role parameter for

Re: Review Request 41475: Updated docker build script for centos 7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41475/#review110952 --- Ship it! I confirmed that the original script failed as described

Review Request 41514: Accepted a single JSON object for quota set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41514/ --- Review request for mesos, Anand Mazumdar, Bernd Mathiske, Joerg Schad, and

Review Request 41515: Refactored error messages to reduce jaggedness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41515/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere,

Review Request 41509: [libprocess] Cleaned up STL I/O includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41509/ --- Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael

Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41511/ --- Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael

Review Request 41512: Cleaned up STL I/O includes in public headers which are not part of v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41512/ --- Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael

Review Request 41510: Cleaned up STL I/O includes in external containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41510/ --- Review request for mesos, Michael Park and Till Toenshoff. Bugs: MESOS-4183

Review Request 41513: Cleaned up STL I/O includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41513/ --- Review request for mesos. Bugs: MESOS-4183

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

> On Dec. 17, 2015, 11:21 a.m., Adam B wrote: > > src/tests/slave_tests.cpp, line 2240 > > > > > > Do you want to verify that the vips are set as expected too? The vips are part of the DiscoveryInfo and we are

Re: Review Request 41420: Added ContainerInfo to internal Task protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41420/ --- (Updated Dec. 17, 2015, 9:39 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41421/ --- (Updated Dec. 17, 2015, 9:39 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41510: Cleaned up STL I/O includes in external containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41510/#review110977 --- Ship it! Ship It! - Gilbert Song On Dec. 17, 2015, 6:37 a.m.,

Re: Review Request 41422: Removed manual construction of Task in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41422/ --- (Updated Dec. 17, 2015, 9:40 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41509: [libprocess] Cleaned up STL I/O includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41509/#review110975 --- Ship it! Ship It! - Gilbert Song On Dec. 17, 2015, 6:37 a.m.,

Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41421/ --- (Updated Dec. 17, 2015, 10:26 a.m.) Review request for mesos, Artem

Re: Review Request 40553: Enable mesos tests installation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Dec. 17, 2015, 5:43 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/#review111024 --- Since you're on it. Can you rename docker::DockerImageManifest to

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 17, 2015, 11:57 a.m.) Review request for mesos, Artem

Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41421/ --- (Updated Dec. 17, 2015, 11:59 a.m.) Review request for mesos, Artem

Re: Review Request 41422: Removed manual construction of Task in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41422/ --- (Updated Dec. 17, 2015, 11:58 a.m.) Review request for mesos, Artem

Re: Review Request 41002: Logger Module: Introduce the ContainerLogger interface for logging the stdout/stderr of executors and tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41002/#review110826 --- Ship it! Only high-level comment is that the _container_ logger

Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/ --- (Updated Dec. 17, 2015, 7:51 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41489: Provisioner: Implemented docker v1 parse serialization method in spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41489/#review111031 --- Ship it!

Re: Review Request 41361: Wrote cmd to create WANdiscoSVN file for centos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41361/#review111025 --- Ship it! Ship It! - Joseph Wu On Dec. 16, 2015, 3:09 p.m.,

Re: Review Request 41488: Provisioner: Added docker v1 manifest protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41488/#review111026 --- src/slave/containerizer/mesos/provisioner/docker/message.proto

Re: Review Request 41515: Refactored error messages to reduce jaggedness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41515/#review111036 --- Ship it! Ship It! - Neil Conway On Dec. 17, 2015, 2:52 p.m.,

Re: Review Request 41475: Updated docker build script for centos 7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41475/#review111050 --- Patch looks great! Reviews applied: [41475] Passed command:

Re: Review Request 41532: Fixed formatting of C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41532/ --- (Updated Dec. 17, 2015, 9:16 p.m.) Review request for mesos and Jan Schlicht.

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41187/ --- (Updated Dec. 17, 2015, 10:35 p.m.) Review request for mesos, Adam B and Anand

Review Request 41532: Fixed formatting of C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41532/ --- Review request for mesos. Repository: mesos Description --- Fixed

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39888/#review110829 --- Ship it!

Re: Review Request 39852: Windows: Replaced global `GetMessage` macro with inline function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39852/#review110823 --- Ship it!

Re: Review Request 40553: Enable mesos tests installation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review111076 --- Patch looks great! Reviews applied: [39780, 39781, 39782, 40553]

Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

> On Dec. 17, 2015, 12:12 a.m., Anand Mazumdar wrote: > > src/tests/common/http_tests.cpp, lines 130-140 > > > > > > Can you confirm that other objects that have labels that are exposed > > via `/state` endpoint

Re: Review Request 40167: [2/7] Added ACL protobuf messages 'CreateVolume' and 'DestroyVolume'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40167/#review111052 --- Ship it! Ship It! - Jie Yu On Dec. 17, 2015, 6:58 a.m., Greg

Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40168/#review111059 --- Ship it! Ship It! - Jie Yu On Dec. 17, 2015, 12:20 a.m., Greg

Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy, Create}Volume' to create/destroy persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40169/#review111064 --- Ship it! Ship It! - Jie Yu On Dec. 17, 2015, 12:29 a.m., Greg

Re: Review Request 39889: Windows: Added support for `files/files.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39889/#review111070 --- Ship it! - Joris Van Remoortere On Nov. 16, 2015, 9:15 a.m.,

Re: Review Request 39889: Windows: Added support for `files/files.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39889/ --- (Updated Dec. 17, 2015, 10:11 p.m.) Review request for mesos, Artem

Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/ --- (Updated Dec. 17, 2015, 10:40 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 17, 2015, 10:41 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41532: Fixed formatting of C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41532/#review111081 --- Ship it! Ship It! - Adam B On Dec. 17, 2015, 1:16 p.m., Neil

Re: Review Request 41539: Enabled agent do not kill exeucutor for some error cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41539/#review19 --- Ship it! Ship It! - Klaus Ma On Dec. 18, 2015, 1:38 p.m.,

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

> On Dec. 16, 2015, 5:17 p.m., Michael Park wrote: > > src/master/http.cpp, lines 1000-1006 > > > > > > Hm, should this be added to `validation::operation::validate` instead? > > That way if/when we have

Re: Review Request 41075: Added support for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review21 --- src/master/master.cpp (line 588)

Re: Review Request 41225: Added test cases for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41225/#review27 --- Looks good. Just some minor changes and it'll be good to go.

Review Request 41539: Enabled agent do not kill exeucutor for some error cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41539/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere,

Re: Review Request 41408: Updated documentation for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41408/#review22 --- Looks good, but please also update the CHANGELOG and

Re: Review Request 41539: Enabled agent do not kill exeucutor for some error cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41539/#review33 --- Patch looks great! Reviews applied: [41539] Passed command:

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41472/#review41 --- Ship it! Looks good to me. Address MPark's concern and let's

Re: Review Request 41475: Updated docker build script for centos 7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41475/#review111084 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 16, 2015,

Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

> On Dec. 17, 2015, 10:47 a.m., Adam B wrote: > > src/tests/slave_tests.cpp, lines -2224 > > > > > > Doesn't this all fit on one 80-char line? > > > > Also, it looks like we have a

Re: Review Request 41002: Logger Module: Introduce the ContainerLogger interface for logging the stdout/stderr of executors and tasks.

> On Dec. 17, 2015, 12:56 p.m., Benjamin Hindman wrote: > > Only high-level comment is that the _container_ logger talks a lot about > > executor's and tasks, I need to look into some of the upcoming reviews, but > > why isn't it sufficient to only talk about containers? I wanted to be

Re: Review Request 41514: Accepted a single JSON object for quota set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41514/#review111086 --- LGTM.. Just some nits around: - using `const` for test strings. -

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/ --- (Updated Dec. 17, 2015, 10:43 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/ --- (Updated Dec. 17, 2015, 11:15 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41002: Logger Module: Introduce the ContainerLogger interface for logging the stdout/stderr of executors and tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41002/ --- (Updated Dec. 17, 2015, 3:46 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/#review11 --- Patch looks great! Reviews applied: [41187, 41188] Passed

Re: Review Request 41076: Added tests for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41076/ --- (Updated Dec. 17, 2015, 7:59 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 41119: Cleaned up DRF allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41119/ --- (Updated Dec. 17, 2015, 8:01 p.m.) Review request for mesos. Repository:

Re: Review Request 41250: Enabled slave get ALLOCATION_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41250/#review110934 --- src/slave/slave.cpp (line 5194)

Re: Review Request 41244: Using 'git rev-parse --git-dir' in post-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41244/#review110936 --- Patch looks great! Reviews applied: [41243, 41244] Passed

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

> On Dec. 16, 2015, 4:12 p.m., Anand Mazumdar wrote: > > src/tests/common/http_tests.cpp, lines 130-140 > > > > > > Can you confirm that other objects that have labels that are exposed > > via `/state` endpoint

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/#review110930 --- Ship it! src/master/quota_handler.cpp (line 348)

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/ --- (Updated Dec. 17, 2015, 12:16 p.m.) Review request for mesos, Alexander

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

> On Dec. 14, 2015, 4:57 p.m., Alexander Rukletsov wrote: > > docs/authorization.md, line 7 > > > > > > I think this can be a bit misleading: these features are not added in > > 0.20.0. > > > > Moreover, it

Re: Review Request 41337: WIP: Set task as TASK_LOST if not enough allocation slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41337/#review110935 --- src/slave/slave.cpp (line 4860)

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/#review110927 --- Looks great! Barring the nested labels discussion, I just had a

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40348/#review110938 --- docs/authorization.md (line 7)

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review110939 --- Please explain (the intended use of) instance_port better.

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review110932 --- docs/fetcher.md (line 224)

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/ --- (Updated Dec. 17, 2015, 12:15 p.m.) Review request for mesos, Alexander

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/#review110940 --- Errors in one of the tests, but only minor suggestions otherwise.

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review110732 --- Patch looks great! Reviews applied: [41438] Passed command:

Re: Review Request 41061: Logger Module: Add container_logger flag to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41061/ --- (Updated Dec. 17, 2015, 11:32 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 17, 2015, 11:58 a.m.) Review request for mesos, Artem

Re: Review Request 41111: Logger Module: Add test for default executor/task stdout/stderr logging behavior (to sandbox).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/ --- (Updated Dec. 17, 2015, 12:14 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/ --- (Updated Dec. 17, 2015, 12:14 p.m.) Review request for mesos, Benjamin

Re: Review Request 41004: Logger Module: Introduce the ContainerLogger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41004/ --- (Updated Dec. 17, 2015, 12:14 p.m.) Review request for mesos, Benjamin

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

> On Dec. 16, 2015, 5:23 p.m., Benjamin Hindman wrote: > > src/slave/container_loggers/sandbox.cpp, line 55 > > > > > > Is this comment useful? Is there something else here you want to > > capture? Removed this

Re: Review Request 40995: Added test cases for role behavior.

> On Dec. 18, 2015, 12:57 a.m., Adam B wrote: > > src/tests/role_tests.cpp, lines 79-83 > > > > > > `AWAIT_EXPECT_RESPONSE_HEADER_EQ(APPLICATION_JSON, "Content-Type", > > response);` all fits on one line, and does

  1   2   >