Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

> On 一月 10, 2017, 7:34 a.m., Guangya Liu wrote: > > Ship It! I have committed this already, but seems do not have permission to close this review, will close this when got permission. commit 653fe55b3f2e6cd76567945dbbec4a84c03f13c2 Author: Jay Guo Date: Tue Jan 10

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54365/#review161040 --- Ship it! Ship It! - Guangya Liu On 十二月 9, 2016, 9:38 a.m.,

Re: Review Request 55362: Support asynchronous fetching of URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55362/#review161031 --- Patch looks great! Reviews applied: [55362] Passed command:

Re: Review Request 54603: Replaced `int` with `int_fd` in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54603/ --- (Updated Jan. 9, 2017, 6:50 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54602: Replaced `int` with `int_fd` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54602/ --- (Updated Jan. 9, 2017, 6:50 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54601: Replaced `int` with `int_fd` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54601/ --- (Updated Jan. 9, 2017, 6:49 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54762: Introduced an `os::pipe` abstraction to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54762/ --- (Updated Jan. 9, 2017, 6:49 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/ --- (Updated Jan. 9, 2017, 6:47 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/ --- (Updated Jan. 9, 2017, 6:47 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54590: Removed unused `peek` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54590/ --- (Updated Jan. 9, 2017, 6:47 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54595: Introduced an `os::dup` abstraction in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54595/ --- (Updated Jan. 9, 2017, 6:47 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/ --- (Updated Jan. 10, 2017, 2:29 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 55362: Support asynchronous fetching of URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55362/ --- (Updated Jan. 10, 2017, 12:53 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 55296: Used `jsonify` in `operator<<` for `JSON::*` to reduce duplicate code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55296/ --- (Updated Jan. 9, 2017, 4:36 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 55355: Fixed an FD leak in the IO switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55355/#review161007 --- Ship it! LGTM! - Jie Yu On Jan. 10, 2017, 12:02 a.m., Greg

Re: Review Request 55355: Fixed an FD leak in the IO switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55355/ --- (Updated Jan. 10, 2017, 12:02 a.m.) Review request for mesos, Benjamin

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

> On Jan. 8, 2017, 3:22 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/libevent_ssl_socket.hpp, line 143 > > > > > > I don't see any win in the name change from `recv_callback` to > >

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

> On Jan. 9, 2017, 11:54 p.m., Greg Mann wrote: > > Whoops :) - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53802/#review160896

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53802/#review160896 --- 3rdparty/libprocess/src/libevent_ssl_socket.hpp (line 143)

Re: Review Request 55339: Removed unsupported 'friend' declaration.

> On Jan. 9, 2017, 2:09 p.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/loop.hpp, lines 216-219 > > > > > > I think we can keep the constructor private, and just do: > > > > ``` > >

Re: Review Request 55355: Fixed an FD leak in the IO switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55355/#review161000 --- Patch looks great! Reviews applied: [55355] Passed command:

Re: Review Request 55355: Fixed an FD leak in the IO switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55355/#review160992 --- I'd run this change my @jie.

Re: Review Request 54183: Improved management of unreachable and completed tasks in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54183/ --- (Updated Jan. 9, 2017, 10:39 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54183: Improved management of unreachable and completed tasks in master.

> On Jan. 3, 2017, 10:25 p.m., Vinod Kone wrote: > > src/master/master.hpp, lines 2634-2641 > > > > > > this reads like `unreachableTasks` are completed tasks of PA > > frameworks. can you split this comment up

Review Request 55359: Consolidate update of allocations in `updateAllocation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55359/ --- Review request for mesos, Benjamin Mahler and Jiang Yan Xu. Bugs: MESOS-6444

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Jan. 9, 2017, 10:37 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53096/ --- (Updated Jan. 9, 2017, 10:37 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Jan. 9, 2017, 10:37 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 55224: Removed unused namespace alias declarations in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55224/#review160989 --- Ship it! Ship It! - Michael Park On Jan. 5, 2017, 12:07

Re: Review Request 55222: Avoided unnecessary copies in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55222/#review160987 --- Ship it! Ship It! - Michael Park On Jan. 5, 2017, 12:05

Re: Review Request 55223: Removed unused namespace alias declarations in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55223/#review160988 --- Ship it! Ship It! - Michael Park On Jan. 5, 2017, 11:07

Re: Review Request 55220: Cleaned up std::string usage in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55220/#review160985 --- Ship it! Ship It! - Michael Park On Jan. 5, 2017, 12:04

Re: Review Request 55226: Cleaned up std::string usage in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55226/#review160984 --- Ship it! Ship It! - Michael Park On Jan. 5, 2017, 12:04

Re: Review Request 55221: Avoided needless copies in log tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55221/#review160986 --- Ship it! Ship It! - Michael Park On Jan. 5, 2017, 11:06

Re: Review Request 55219: Cleaned up std::string usage in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55219/#review160983 --- Ship it! Ship It! - Michael Park On Jan. 5, 2017, 11:06

Re: Review Request 55218: Removed redundant `return` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55218/#review160982 --- Ship it! Ship It! - Michael Park On Jan. 5, 2017, 11:05

Re: Review Request 55339: Removed unsupported 'friend' declaration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55339/#review160980 --- Fix it, then Ship it!

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

> On Jan. 9, 2017, 8:24 p.m., Kevin Klues wrote: > > What is the reason for this change? It seems much more intuitive for me to > > have a simple build directive that we simply remove once of the rename is > > complete, compared to a custom install-hook that creates a symlink. > > James Peach

Re: Review Request 55296: Used `jsonify` in `operator<<` for `JSON::*` to reduce duplicate code.

> On Jan. 9, 2017, 8:52 a.m., Alexander Rojas wrote: > > 3rdparty/stout/include/stout/json.hpp, line 703 > > > > > > This needs either UNREACHABLE() or to return stream to avoid warnings. There seems to be some

Re: Review Request 54573: Updated metrics counter during scheduler api calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54573/#review160973 --- Anand will shepherd these patches, can you add him as a reviewer?

Re: Review Request 55324: Included decoder error strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55324/#review160964 --- Any reason not to expose the error via the API so that the caller

Re: Review Request 55157: Fixed a bug in the default executor around not committing suicide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55157/#review160967 --- Patch looks great! Reviews applied: [55157] Passed command:

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

> On Jan. 9, 2017, 8:24 p.m., Kevin Klues wrote: > > What is the reason for this change? It seems much more intuitive for me to > > have a simple build directive that we simply remove once of the rename is > > complete, compared to a custom install-hook that creates a symlink. The rationale

Review Request 55355: Fixed an FD leak in the IO switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55355/ --- Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler,

Re: Review Request 55355: Fixed an FD leak in the IO switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55355/ --- (Updated Jan. 9, 2017, 8:35 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54613/#review160958 --- What is the reason for this change? It seems much more intuitive

Re: Review Request 55354: Cleaned up master logging code slightly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55354/#review160956 --- Ship it! Ship It! - Vinod Kone On Jan. 9, 2017, 7:44 p.m.,

Re: Review Request 55307: Improved handling of agents that restart but never re-register.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55307/#review160955 --- Ship it! Ship It! - Vinod Kone On Jan. 9, 2017, 7:44 p.m.,

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54613/ --- (Updated Jan. 9, 2017, 8:02 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

> On Dec. 20, 2016, 1:54 p.m., Benjamin Bannier wrote: > > src/Makefile.am, line 2453 > > > > > > Not yours, but since you touch this it would be great if you could make > > these independent commands (i.e.,

Re: Review Request 55157: Fixed a bug in the default executor around not committing suicide.

> On Jan. 9, 2017, 7:47 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, lines 672-679 > > > > > > shouldn't these be re-ordered? i'm assuming we don't need to call > > `__shutdown()` if a shutdown

Re: Review Request 55157: Fixed a bug in the default executor around not committing suicide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55157/#review160946 --- src/launcher/default_executor.cpp (lines 665 - 672)

Review Request 55354: Cleaned up master logging code slightly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55354/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6286

Re: Review Request 55307: Improved handling of agents that restart but never re-register.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55307/ --- (Updated Jan. 9, 2017, 7:44 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 55307: Improved handling of agents that restart but never re-register.

> On Jan. 9, 2017, 3:17 a.m., Vinod Kone wrote: > > src/master/master.cpp, lines 1368-1370 > > > > > > just like "health check time out", can this be succinct? maybe > > "re-registration time out"? I think being

Re: Review Request 55157: Fixed a bug in the default executor around not committing suicide.

> On Jan. 9, 2017, 2:10 a.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, lines 663-683 > > > > > > How about > > > > ``` > > // Check to see if the executor needs to shutdown. > > > >

Re: Review Request 55157: Fixed a bug in the default executor around not committing suicide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55157/ --- (Updated Jan. 9, 2017, 7:37 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160937 --- Patch looks great! Reviews applied: [54996] Passed command:

Re: Review Request 55327: Windows: Fixed hanging symlink bug in `os::rmdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55327/#review160930 --- 3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 97)

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54613/#review160927 --- Ship it! Ship It! - Michael Park On Dec. 19, 2016, 4:11

Re: Review Request 55302: Improved OneWayPartitionTest.MasterToSlave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55302/ --- (Updated Jan. 9, 2017, 6:24 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/ --- (Updated Jan. 9, 2017, 5:59 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55296: Used `jsonify` in `operator<<` for `JSON::*` to reduce duplicate code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55296/#review160902 --- 3rdparty/stout/include/stout/json.hpp (line 679)

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/ --- (Updated Jan. 9, 2017, 4:42 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 7, 2017, 6:42 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 72 > > > > > > Please use errno error so that errno are in the error string. > > > > `return ErrnoError("Memory

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/ --- (Updated Jan. 9, 2017, 4:19 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

> On Jan. 7, 2017, 6:42 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 72 > > > > > > Please use errno error so that errno are in the error string. > > > > `return ErrnoError("Memory

Re: Review Request 55339: Removed unsupported 'friend' declaration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55339/#review160895 --- Patch looks great! Reviews applied: [55339] Passed command:

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Jan. 9, 2017, 3:29 p.m.) Review request for mesos, Adam B, Benjamin

Review Request 55339: Removed unsupported 'friend' declaration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55339/ --- Review request for mesos, Benjamin Bannier and Michael Park. Bugs: MESOS-6895

Re: Review Request 55319: Future::after memory leak fix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55319/#review160889 --- Ship it! Ship It! - Alexander Rojas On Jan. 8, 2017, 8:45

Re: Review Request 54825: Made sure process::Loop instances can only be created as shared_ptrs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54825/#review160888 --- Patch looks great! Reviews applied: [54825] Passed command:

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/#review160885 --- Patch looks great! Reviews applied: [55334, 55335] Passed

Re: Review Request 54825: Made sure process::Loop instances can only be created as shared_ptrs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54825/ --- (Updated Jan. 9, 2017, 12:06 p.m.) Review request for mesos and Benjamin

Re: Review Request 52382: Added stubs for OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52382/#review160878 --- Ship it! Ship It! - Gilbert Song On Jan. 8, 2017, 11:32

Re: Review Request 55332: Added 'message.proto' for OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55332/#review160877 --- Ship it! Ship It! - Gilbert Song On Jan. 8, 2017, 11:35

Re: Review Request 55331: Added 'OCI' message into 'Image' message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55331/#review160876 --- Ship it! Ship It! - Gilbert Song On Jan. 8, 2017, 11:33

Re: Review Request 55333: Implemented the 'get()' method of OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55333/#review160875 --- Patch looks great! Reviews applied: [52349, 55139, 55140, 52379,

Re: Review Request 54638: Added agent flags '--oci_discovery' and '--oci_discovery_prefix'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54638/#review160874 --- src/slave/flags.hpp (lines 60 - 61)

Re: Review Request 52379: Added agent flag '--oci_store_dir'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52379/#review160873 --- src/slave/flags.cpp (line 174)

Re: Review Request 52349: Add protobuf messages for OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52349/#review160872 --- Ship it! Ship It! - Gilbert Song On Jan. 8, 2017, 11:21

Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/ --- Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. Bugs:

Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/ --- Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. Bugs: