Re: Review Request 67597: Fixed an issue where agent may fail to recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67597/ --- (Updated 六月 20, 2018, 8:17 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66875/#review205121 --- PASS: Mesos patch 66875 was successfully built and tested.

Re: Review Request 67670: Added a unit test for disappeared profiles.

> On June 20, 2018, 1:14 p.m., Benjamin Bannier wrote: > > > > Benjamin Bannier wrote: > Does it make sense to combine this patch with e.g., > https://reviews.apache.org/r/67663/? This is an end-to-end test involving not just the module but other modifications, such as r65976, r67664 and

Re: Review Request 67663: Made `UriDiskProfileAdaptor` be able to handle disappeared profiles.

> On June 20, 2018, 1:54 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/uri_disk_profile_adaptor.hpp > > Lines 242 (patched) > > > > > > Is this field needed for a later change? It looks like it

Re: Review Request 67677: Added doc for new pull latency metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67677/#review205129 --- PASS: Mesos patch 67677 was successfully built and tested.

Re: Review Request 67673: Removed an unused member variable `hierarchies` from cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67673/#review205092 --- PASS: Mesos patch 67673 was successfully built and tested.

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66875/ --- (Updated June 20, 2018, 11:26 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 53105: Added an hourly timer for `containerizer/docker/image_pull`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53105/ --- (Updated June 20, 2018, 11:25 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 67663: Made `UriDiskProfileAdaptor` be able to handle disappeared profiles.

> On June 20, 2018, 1:54 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/uri_disk_profile_adaptor.hpp > > Lines 242 (patched) > > > > > > Is this field needed for a later change? It looks like it

Re: Review Request 67517: Added a test to verify `min_allocatable_resources` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67517/#review205115 --- PASS: Mesos patch 67517 was successfully built and tested.

Review Request 67677: Added doc for new pull latency metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67677/ --- Review request for mesos, Jason Lai and Qian Zhang. Bugs: MESOS-6451

Re: Review Request 67667: Renamed the `NewProfile` SLRP test and made it based on offers.

> On June 20, 2018, 12:43 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Line 529 (original), 534 (patched) > > > > > > Just wondering what actually requires `ROOT` in this

Re: Review Request 67517: Added a test to verify `min_allocatable_resources` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67517/ --- (Updated June 20, 2018, 1:40 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 67597: Fixed an issue where agent may fail to recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67597/#review205128 --- PASS: Mesos patch 67597 was successfully built and tested.

Re: Review Request 65875: Improved logging for offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65875/#review205120 --- Ship it! Ship It! - Greg Mann On June 20, 2018, 5:37 a.m.,

Re: Review Request 67517: Added a test to verify `min_allocatable_resources` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67517/#review205123 --- Fix it, then Ship it! src/tests/master_allocator_tests.cpp

Re: Review Request 67673: Removed an unused member variable `hierarchies` from cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67673/#review205125 --- Patch looks great! Reviews applied: [67662, 67526, 67564, 67565,

Re: Review Request 67517: Added a test to verify `min_allocatable_resources` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67517/ --- (Updated June 20, 2018, 3:22 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 67389: Windows: Implemented Windows IOCP async backend.

> On June 8, 2018, 2:28 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/libprocess/src/libwinio_impl.cpp > > Lines 91-119 (patched) > > > > > > Would this be cleaner with a templated struct? > > > > ``` > >

Re: Review Request 53105: Added an hourly timer for `slave/docker_containerizer/pull`.

> On June 20, 2018, 12:58 a.m., Qian Zhang wrote: > > src/slave/containerizer/docker.hpp > > Lines 140 (patched) > > > > > > It seems the convention in Mesos is to implement a `struct Metrics` for > > all the

Re: Review Request 65875: Improved logging for offers and inverse offers.

> On June 20, 2018, 2:35 p.m., Benjamin Bannier wrote: > > Would it make sense to add these log lines only for some higher log level > > (which one)? I am mostly worried about the amount of additional log output > > this could generate in huge clusters, we might e.g., log tens of thousands >

Re: Review Request 65875: Improved logging for offers and inverse offers.

> On June 20, 2018, 4:35 p.m., Benjamin Bannier wrote: > > Would it make sense to add these log lines only for some higher log level > > (which one)? I am mostly worried about the amount of additional log output > > this could generate in huge clusters, we might e.g., log tens of thousands >

Re: Review Request 65875: Improved logging for offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65875/#review205117 --- Ship it! Ship It! - Benjamin Bannier On June 20, 2018, 7:37

Re: Review Request 67391: Windows: Added CMake `ENABLE_LIBWINIO` flag for Windows IOCP backend.

> On June 8, 2018, 3:58 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/libprocess/include/process/io.hpp > > Lines 29-39 (original), 29-41 (patched) > > > > > > Should we re-use the header guard like this, or add a

Re: Review Request 67390: Windows: Integrated libwinio with libprocess code.

> On June 8, 2018, 3:46 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/libprocess/src/libwinio_io.cpp > > Lines 78-101 (patched) > > > > > > Wait... doesn't this belong in the `prepare_async` from earlier? Did > >

Re: Review Request 67517: Added a test to verify `min_allocatable_resources` flag.

> On June 19, 2018, 4:08 p.m., Greg Mann wrote: > > src/tests/master_allocator_tests.cpp > > Lines 1270 (patched) > > > > > > Is there a reason you don't do > > > > ``` > > flags.resources =

Re: Review Request 67513: Added a master flag to configure minimum allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67513/ --- (Updated June 20, 2018, 10:52 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 67666: Added a `TestDiskProfileServer` helper.

> On June 20, 2018, 11:01 a.m., Benjamin Bannier wrote: > > src/tests/disk_profile_server.hpp > > Lines 34-35 (patched) > > > > > > Nit: This class doesn't really fetch, but instead provides a mock > > remote. It's

Re: Review Request 67670: Added a unit test for disappeared profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67670/#review205048 --- PASS: Mesos patch 67670 was successfully built and tested.

Re: Review Request 67680: Fixed archiver failure to extract hardlinks to another directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67680/#review205141 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66881: Added benchmark test for master metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66881/ --- (Updated June 20, 2018, 5:08 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67597: Fixed an issue where agent may fail to recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67597/#review205138 --- Patch looks great! Reviews applied: [67597] Passed command:

Re: Review Request 67517: Added a test to verify `min_allocatable_resources` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67517/#review205139 --- src/tests/master_allocator_tests.cpp Lines 86 (patched)

Re: Review Request 66881: Added benchmark test for master metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66881/#review205145 --- PASS: Mesos patch 66881 was successfully built and tested.

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66875/#review205144 --- Fix it, then Ship it!

Re: Review Request 67680: Fixed archiver failure to extract hardlinks to another directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67680/#review205134 --- 3rdparty/stout/tests/archiver_tests.cpp Lines 388-389 (patched)

Re: Review Request 67680: Fixed archiver failure to extract hardlinks to another directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67680/#review205135 --- Ship it! Looks good module a minor comment. Feel free to drop

Re: Review Request 67513: Added a master flag to configure minimum allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67513/#review205137 --- src/master/master.cpp Lines 774-786 (patched)

Re: Review Request 53105: Added an hourly timer for `containerizer/docker/image_pull`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53105/#review205143 --- Fix it, then Ship it! src/slave/containerizer/docker.hpp

Review Request 67680: Fixed archiver failure to extract hardlinks to another directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67680/ --- Review request for mesos, Andrew Schwartzmeyer and Kapil Arya. Bugs:

Re: Review Request 67663: Made `UriDiskProfileAdaptor` be able to handle disappeared profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67663/ --- (Updated June 21, 2018, 4:27 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67664: Fixed a race between `UPDATE_STATE` and `UPDATE_OPERATION_STATUS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67664/ --- (Updated June 21, 2018, 4:29 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67667: Renamed the `NewProfile` SLRP test and made it based on offers.

> On June 20, 2018, 12:43 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Line 529 (original), 534 (patched) > > > > > > Just wondering what actually requires `ROOT` in this

Re: Review Request 67677: Added doc for new pull latency metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67677/#review205149 --- Patch looks great! Reviews applied: [53105, 66875, 67677]

Re: Review Request 67666: Added a `TestDiskProfileServer` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67666/ --- (Updated June 21, 2018, 4:33 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67667: Renamed the `NewProfile` SLRP test and made it based on offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67667/ --- (Updated June 21, 2018, 4:35 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67668: Fixed a bug in `TestCSIPlugin::DeleteVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67668/ --- (Updated June 21, 2018, 4:35 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 53105: Added an hourly timer for `containerizer/docker/image_pull`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53105/ --- (Updated June 20, 2018, 9:49 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 67669: Allowed allocation quantities to be changed when updating the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67669/ --- (Updated June 21, 2018, 4:52 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67669: Removed an invariant check when updating the hierarchical allocator.

> On June 20, 2018, 2:20 p.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 921 (original) > > > > > > While this might not be required by the allocator, generally an > >

Re: Review Request 67615: Modified `createStrippedScalarQuantity()` to clear all metadata fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67615/ --- (Updated June 20, 2018, 9:56 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67561: Refactored `struct Slave` in the allocator for better performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67561/ --- (Updated June 20, 2018, 9:56 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 67670: Added a unit test for disappeared profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67670/ --- (Updated June 21, 2018, 5:02 a.m.) Review request for mesos, Benjamin Bannier,

Review Request 67681: Fixed flaky test `MasterAPITest.SubscribersReceiveHealthUpdates`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67681/ --- Review request for mesos and Greg Mann. Bugs: MESOS-9014

Re: Review Request 67664: Fixed a race between `UPDATE_STATE` and `UPDATE_OPERATION_STATUS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67664/#review205054 --- src/slave/slave.cpp Lines 7750 (patched)

Re: Review Request 53105: Added an hourly timer for `slave/docker_containerizer/pull`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53105/#review205049 --- src/slave/containerizer/docker.hpp Lines 27-28 (original), 27-30

Re: Review Request 66875: Added an hourly timer for docker store pull latency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66875/#review205053 --- src/slave/containerizer/mesos/provisioner/docker/store.cpp Lines

Re: Review Request 67664: Fixed a race between `UPDATE_STATE` and `UPDATE_OPERATION_STATUS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67664/#review205052 --- Fix it, then Ship it! src/slave/slave.cpp Lines 7738-7746

Re: Review Request 67670: Added a unit test for disappeared profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67670/#review205061 --- src/tests/storage_local_resource_provider_tests.cpp Lines 1047

Re: Review Request 67670: Added a unit test for disappeared profiles.

> On June 20, 2018, 3:14 p.m., Benjamin Bannier wrote: > > Does it make sense to combine this patch with e.g., https://reviews.apache.org/r/67663/? - Benjamin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 67501: Added authorization for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67501/#review205066 --- Patch looks great! Reviews applied: [67501] Passed command:

Re: Review Request 67663: Made `UriDiskProfileAdaptor` be able to handle disappeared profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67663/#review205073 --- src/resource_provider/storage/uri_disk_profile_adaptor.hpp Lines

Re: Review Request 67665: Made the `UriDiskProfileAdaptor` module configurable in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67665/#review205081 --- Ship it! src/tests/storage_local_resource_provider_tests.cpp

Re: Review Request 67673: Removed an unused member variable `hierarchies` from cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67673/ --- (Updated June 20, 2018, 10:33 p.m.) Review request for mesos, Gilbert Song and

Review Request 67673: Removed an unused member variable `hierarchies` from cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67673/ --- Review request for mesos, Gilbert Song and Jason Lai. Bugs: MESOS-8327

Re: Review Request 67671: Prevented resource providers from changing their name or type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67671/#review205089 --- Patch looks great! Reviews applied: [67671] Passed command:

Re: Review Request 67501: Added authorization for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67501/#review205083 --- Fix it, then Ship it! docs/authorization.md Lines 334-365

Review Request 67671: Prevented resource providers from changing their name or type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67671/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-8838

Re: Review Request 67669: Removed an invariant check when updating the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67669/#review205079 --- src/master/allocator/mesos/hierarchical.cpp Line 921 (original)

Re: Review Request 67667: Renamed the `NewProfile` SLRP test and made it based on offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67667/#review205059 --- Fix it, then Ship it!

Re: Review Request 67671: Prevented resource providers from changing their name or type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67671/#review205076 --- PASS: Mesos patch 67671 was successfully built and tested.

Re: Review Request 65875: Improved logging for offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65875/#review205082 --- Would it make sense to add these log lines only for some higher

Re: Review Request 67668: Fixed a bug in `TestCSIPlugin::DeleteVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67668/#review205058 --- Ship it! src/examples/test_csi_plugin.cpp Line 364

Re: Review Request 67666: Added a `TestDiskProfileServer` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67666/#review205056 --- Fix it, then Ship it! src/tests/disk_profile_server.hpp Lines

Re: Review Request 67501: Added authorization for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67501/ --- (Updated June 20, 2018, 12:44 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 67501: Added authorization for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67501/#review205060 --- PASS: Mesos patch 67501 was successfully built and tested.