Re: Review Request 51880: Added unit tests to determine disk size for MOUNT disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51880/#review149027 --- Patch looks great! Reviews applied: [51879, 51880] Passed

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 14, 2016, 8:55 p.m., Vinod Kone wrote: > > any update on this? Yeah...working on it..will post patch shortly. - Abhishek --- This is an automatically generated e-mail. To reply, visit:

Review Request 51904: Ensured that queued task groups killed before launch are cleaned up.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51904/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6154

Review Request 51905: Added logging when sending a queued task group to the executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51905/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 51891: Added test case for registry GC race condition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51891/#review149023 --- Bad patch! Reviews applied: [51891, 51845, 51805, 51707, 51653,

Re: Review Request 51886: Added tests for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51886/#review149020 --- Patch looks great! Reviews applied: [51884, 51885, 51886]

Re: Review Request 51780: Changed isolator recover interface using 'ContainerRecoverInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51780/#review149016 --- src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp

Re: Review Request 51882: Reverted "Added a test case `ROOT_CGROUPS_CFS_BigQuotaDecimal`.".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51882/#review149015 --- Ship it! Ship It! - Jie Yu On Sept. 14, 2016, 3:54 a.m.,

Re: Review Request 51881: Fixed failed cgroups isolator test cases in CentOS 6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51881/#review149014 --- Ship it! Ship It! - Jie Yu On Sept. 14, 2016, 2:54 a.m.,

Re: Review Request 51902: Added protobuf definition for SANDBOX_PATH volume source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51902/#review149011 --- Fix it, then Ship it! LGTM! Just a bit of language

Re: Review Request 51902: Added protobuf definition for SANDBOX_PATH volume source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51902/ --- (Updated Sept. 15, 2016, 1:35 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51715: Added a parallel gtest runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/#review149005 --- support/mesos-gtest-runner.py (line 13)

Re: Review Request 51797: Fixed comments closing namespaces in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51797/#review149010 --- Ship it! Ship It! - Michael Park On Sept. 14, 2016, 1:32

Re: Review Request 51798: Fixed comments closing namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51798/#review149009 --- Ship it! Ship It! - Michael Park On Sept. 14, 2016, 1:32

Re: Review Request 51673: Update mesos containerizer launch for sub-container support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51673/ --- (Updated Sept. 14, 2016, 5:38 p.m.) Review request for mesos, Benjamin

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51871/#review149008 --- Patch looks great! Reviews applied: [51857, 51871] Passed

Re: Review Request 51517: Added MOUNT or PATH disk type in logging resources.

> On Sept. 14, 2016, 1:59 p.m., Benjamin Bannier wrote: > > src/common/resources.cpp, line 1745 > > > > > > It would be great if you could avoid using `default` when switching > > over enum values. See

Re: Review Request 51885: Added a basic default executor implementation.

> On 九月 14, 2016, 1:08 p.m., Guangya Liu wrote: > > How about rename this file as `default_pod_executor.cpp`? > > Vinod Kone wrote: > we are calling it "pod executor" because this executor will be able to > launch pod and non-pods in the future. command executor will be deprecated in >

Re: Review Request 51869: Export "reserved_resources" in the agent HTTP endpoint.

> On Sept. 15, 2016, 12:10 a.m., Anindya Sinha wrote: > > Small type in description: s/resource/resources - Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51869/#review149001

Review Request 51902: Added protobuf definition for ParentContainerSandboxPath volume source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51902/ --- Review request for mesos, Gilbert Song, Joseph Wu, and Vinod Kone. Bugs:

Re: Review Request 51869: Export "reserved_resources" in the agent HTTP endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51869/#review149001 --- src/slave/http.cpp (line 985)

Re: Review Request 51868: Expose full reservation info in the agent's http endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51868/#review148999 --- src/slave/http.cpp (line 986)

Re: Review Request 51867: Add a member variable for the agent's total resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51867/#review149000 --- Fix it, then Ship it! Ship It! src/slave/slave.hpp (line

Re: Review Request 51866: Made the agent verify resource compatibility in checkpointResources().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51866/#review148997 --- src/slave/slave.cpp (line 5064)

Re: Review Request 51517: Added MOUNT or PATH disk type in logging resources.

> On Sept. 14, 2016, 10:59 p.m., Benjamin Bannier wrote: > > src/common/resources.cpp, line 1745 > > > > > > It would be great if you could avoid using `default` when switching > > over enum values. See

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51880/ --- (Updated Sept. 14, 2016, 10:57 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 51517: Added MOUNT or PATH disk type in logging resources.

> On Sept. 14, 2016, 8:59 p.m., Benjamin Bannier wrote: > > src/common/resources.cpp, line 1745 > > > > > > It would be great if you could avoid using `default` when switching > > over enum values. See

Re: Review Request 51517: Added MOUNT or PATH disk type in logging resources.

> On Sept. 14, 2016, 1:59 p.m., Benjamin Bannier wrote: > > src/common/resources.cpp, line 1745 > > > > > > It would be great if you could avoid using `default` when switching > > over enum values. See

Re: Review Request 51517: Added MOUNT or PATH disk type in logging resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51517/ --- (Updated Sept. 14, 2016, 10:32 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 51798: Fixed comments closing namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51798/#review148983 --- Patch looks great! Reviews applied: [51798] Passed command:

Re: Review Request 51517: Added MOUNT or PATH disk type in logging resources.

> On Sept. 14, 2016, 10:59 p.m., Benjamin Bannier wrote: > > src/common/resources.cpp, line 1745 > > > > > > It would be great if you could avoid using `default` when switching > > over enum values. See

Re: Review Request 51517: Added MOUNT or PATH disk type in logging resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51517/ --- (Updated Sept. 14, 2016, 9:42 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51517: Added MOUNT or PATH disk type in logging resources.

> On Sept. 14, 2016, 8:59 p.m., Benjamin Bannier wrote: > > src/common/resources.cpp, line 1745 > > > > > > It would be great if you could avoid using `default` when switching > > over enum values. See

Re: Review Request 51517: Added MOUNT or PATH disk type in logging resources.

> On Sept. 14, 2016, 1:59 p.m., Benjamin Bannier wrote: > > OK makes sense. Wasn't aware of this. I'll refrain from committing. Anindya could you update the review? - Jiang Yan --- This is an automatically generated e-mail. To reply,

Re: Review Request 51517: Added MOUNT or PATH disk type in logging resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51517/#review148967 --- src/common/resources.cpp (line 1745)

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review148966 --- any update on this? - Vinod Kone On Sept. 3, 2016, 8:36 p.m.,

Re: Review Request 51517: Added MOUNT or PATH disk type in logging resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51517/#review148965 --- Ship it! Will commit with the following edits.

Re: Review Request 51797: Fixed comments closing namespaces in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51797/#review148961 --- Patch looks great! Reviews applied: [51797] Passed command:

Re: Review Request 51375: Introduced MockRegistrar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51375/#review148960 --- Fix it, then Ship it! src/tests/cluster.hpp (line 131)

Re: Review Request 51891: Added test case for registry GC race condition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51891/#review148959 --- Ship it! Ship It! - Vinod Kone On Sept. 14, 2016, 3:04

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

> On Sept. 6, 2016, 11:33 a.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Re: Review Request 51864: Added logs for container state transitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/#review148953 --- Patch looks great! Reviews applied: [51865, 51864] Passed

Re: Review Request 51886: Added tests for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51886/#review148952 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp

Re: Review Request 51885: Added a basic default executor implementation.

> On Sept. 14, 2016, 6:04 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 212 > > > > > > why capture the task group as a member variable when you already have > > `tasks`? > > Anand Mazumdar

Re: Review Request 51885: Added a basic default executor implementation.

> On Sept. 14, 2016, 6:04 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 212 > > > > > > why capture the task group as a member variable when you already have > > `tasks`? `tasks` are a list

Re: Review Request 51885: Added a basic default executor implementation.

> On Sept. 14, 2016, 1:08 p.m., Guangya Liu wrote: > > src/launcher/default_executor.cpp, line 203 > > > > > > s/multiple task groups /multiple tasks in task group what anand reads correct to me. - Vinod

Re: Review Request 51885: Added a basic default executor implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51885/#review148944 --- Fix it, then Ship it! src/launcher/default_executor.cpp

Re: Review Request 51877: Updated comments for += and -= `Resource_` object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51877/#review148940 --- I didn't add additional comments because the conversion is

Re: Review Request 51885: Added a basic default executor implementation.

> On Sept. 14, 2016, 1:08 p.m., Guangya Liu wrote: > > How about rename this file as `default_pod_executor.cpp`? we are calling it "pod executor" because this executor will be able to launch pod and non-pods in the future. command executor will be deprecated in favor of this. - Vinod

Re: Review Request 51884: Removed tasks belonging to a task group from queued tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51884/#review148942 --- Fix it, then Ship it! src/slave/slave.cpp (line 2212)

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51880/ --- (Updated Sept. 14, 2016, 5:34 p.m.) Review request for mesos and Jiang Yan Xu.

Review Request 51870: Added a test for reservation info in the agent's endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51870/ --- Review request for mesos, Anindya Sinha and Neil Conway. Bugs: MESOS-6085

Review Request 51869: Export "reserved_resources" in the agent HTTP endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51869/ --- Review request for mesos, Anindya Sinha and Neil Conway. Bugs: MESOS-6085

Re: Review Request 51683: Avoided resource validation when flatten resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/#review148926 --- Patch looks great! Reviews applied: [51683] Passed command:

Review Request 51868: Expose full reservation info in the agent's http endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51868/ --- Review request for mesos, Anindya Sinha and Neil Conway. Bugs: MESOS-4668

Re: Review Request 51867: Add a member variable for the agent's total resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51867/ --- (Updated Sept. 14, 2016, 9:34 a.m.) Review request for mesos, Anindya Sinha

Review Request 51867: Add a member variable for the agent's total resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51867/ --- Review request for mesos, Anindya Sinha and Neil Conway. Repository: mesos

Review Request 51866: Made the agent verify resource compatibility in checkpointResources().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51866/ --- Review request for mesos, Anindya Sinha and Neil Conway. Bugs: MESOS-4668

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51871/ --- (Updated Sept. 14, 2016, 4:25 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51857: Modified the `prepare` method to be aware of nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/ --- (Updated Sept. 14, 2016, 4:23 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51675: Fixed mesos containerizer recover leak on provisioner orphan destroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51675/#review148917 --- I think we should call 'destroy' on orphans as well. - Jie Yu

Re: Review Request 51673: Update mesos containerizer launch for sub-container support.

> On Sept. 7, 2016, 5:12 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1152-1160 > > > > > > why we need to do that? > > Gilbert Song wrote: > for the pod case, we have

Re: Review Request 51673: Update mesos containerizer launch for sub-container support.

> On Sept. 7, 2016, 5:12 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1152-1160 > > > > > > why we need to do that? > > Gilbert Song wrote: > for the pod case, we have

Re: Review Request 51621: WIP: Made recovered resource allocated as soon as possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51621/#review148904 --- Patch looks great! Reviews applied: [51028, 51027, 51621]

Review Request 51891: Added test case for registry GC race condition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51891/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 51625: Refactored `GET_CONTAINERS` Call in v1 Agent API.

> On Sept. 12, 2016, 8:19 p.m., Vinod Kone wrote: > > Can you separate out filtering of containers and the refactor into separate > > commits? Ideally do filtering first. > > > > Also, what's the motivation for including containers in GetState? I > > couldn't get the motivation from the

Re: Review Request 51886: Added tests for default executor.

> On 九月 14, 2016, 1:41 p.m., Guangya Liu wrote: > > src/tests/default_executor_tests.cpp, lines 119-123 > > > > > > How about adding another task to the task group? ``` v1::TaskInfo taskInfo1 =

Re: Review Request 51886: Added tests for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51886/#review148899 --- src/tests/default_executor_tests.cpp (lines 119 - 123)

Review Request 51797: Fixed comments closing namespaces in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51797/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 51798: Fixed comments closing namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51798/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 51885: Added a basic default executor implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51885/#review148886 --- How about rename this file as `default_pod_executor.cpp`?

Re: Review Request 51882: Reverted "Added a test case `ROOT_CGROUPS_CFS_BigQuotaDecimal`.".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51882/#review148898 --- Patch looks great! Reviews applied: [51878, 51881, 51882]

Re: Review Request 51864: Added logs for container state transitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/ --- (Updated Sept. 14, 2016, 11:53 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 51865: Added validation for `ContainerInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51865/ --- (Updated Sept. 14, 2016, 11:52 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 51865: Added validation for `ContainerInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51865/ --- (Updated Sept. 14, 2016, 11:34 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 51865: Added validation for `ContainerInfo`.

> On Sept. 13, 2016, 11:30 p.m., Gilbert Song wrote: > > src/master/validation.cpp, lines 61-63 > > > > > > This is not necessary, because it is a required field. That's correct, however, due to

Re: Review Request 51864: Added logs for container state transitions.

> On Sept. 13, 2016, 10:54 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 903-904 > > > > > > We already have such `LOG(INFO)` in provisioner::_provisioner(). > > > >

Re: Review Request 51501: Exposed metrics in scheduler library.

> On Sept. 14, 2016, 12:26 a.m., Anand Mazumdar wrote: > > src/scheduler/scheduler.cpp, line 744 > > > > > > hmm, this won't quite work for the scheduler library i.e. the messages > > metric would always be 0. > >

Re: Review Request 51375: Introduced MockRegistrar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51375/#review14 --- More detail on the recent fix: the bug arose because I reordered

Re: Review Request 51375: Introduced MockRegistrar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51375/ --- (Updated Sept. 14, 2016, 10:35 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51856: Updated agent to correctly populate `CommandInfo` for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51856/#review148881 --- Fix it, then Ship it! Ship It! src/slave/slave.hpp (line

Review Request 51884: Removed tasks belonging to a task group from queued tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51884/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 51886: Added tests for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51886/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6077

Review Request 51885: Added a basic default executor implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51885/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6077

Re: Review Request 46028: Improved comments in SocketManager::next().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46028/#review148884 --- Closing this review due to inactivity. Please see our

Re: Review Request 51877: Updated comments for += and -= `Resource_` object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51877/#review148883 --- Patch looks great! Reviews applied: [51877] Passed command:

Re: Review Request 45673: PoC: Docker Volume Isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45673/#review148882 --- Closing this review due to inactivity. Please see our

Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40545/#review148880 --- @Ian can you please re-open if this is still an issue? I could

Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40545/ --- (Updated Sept. 14, 2016, 9:16 a.m.) Review request for mesos. Bugs:

Re: Review Request 46799: Added capabilities support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46799/#review148879 --- Closing this review as Benjamin has followed up with separate

Re: Review Request 46370: Introduced linux capabilities API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/#review148878 --- Closing this review as Benjamin has followed up with separate

Re: Review Request 46371: Added basic tests for capabilities API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/#review148877 --- Closing this review as Benjamin has followed up with separate

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review148876 --- Closing this review as Benjamin has followed up with separate

Re: Review Request 46798: Introduced linux capabilities support for mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46798/#review148875 --- Closing this review as Benjamin has follow up with separate

Re: Review Request 49617: Add benchmark for failover of many frameworks.

> On 八月 24, 2016, 9:12 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 4091-4099 > > > > > > Can we make sure all of the `allocations` are available when > > `recoverResources`? Do

Re: Review Request 51683: Avoided resource validation when flatten resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/ --- (Updated 九月 14, 2016, 6:09 a.m.) Review request for mesos, Benjamin Mahler and