/ Create the global HTTP authentication router.
authentication_router = new AuthenticationRouter();
```
3rdparty/libprocess/src/process_reference.hpp (line 52)
<https://reviews.apache.org/r/37999/#comment165882>
This should be in a separate patch, much like we did for the promise
setting
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40539/#review107364
---
Ship it!
- Ben Mahler
On Nov. 20, 2015, 12:34 p.m., Alexander
rfaces (we don't expect these interfaces to
change further for the MVP).
I will update the description in the commit to reflect that this no longer
includes the ProcessManager integration.
- Ben Mahler
On Nov. 20, 2015, 12:53 p.m., Alexan
> On Nov. 20, 2015, 2 p.m., Ben Mahler wrote:
> > For transparency we pulled out the libprocess integration because we
> > realized that requests sent to the authentication router need to have
> > authentication results satisfied in the same order in which the requests
committing 40225 since they
looked independent.
- Ben Mahler
On Nov. 14, 2015, 5:07 p.m., Artem Harutyunyan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
tps://reviews.apache.org/r/40767/#comment167759>
Do you know about Option's getOrElse? You can avoid these ternary
expressions.
Also the ? needs a space in the second line here.
- Ben Mahler
On Nov. 27, 2015, 1:44 p.m., Bernd Mat
f a process pointer.
- Ben Mahler
On Nov. 23, 2015, 5:37 a.m., Jian Qiu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
/signals_tests.cpp (line 44)
<https://reviews.apache.org/r/39938/#comment168182>
One r in triggering.
- Ben Mahler
On Nov. 4, 2015, 5:15 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail.
, would you mind sharing a screenshot before I
commit this so that I know you've actually checked how this looks?
- Ben Mahler
On Nov. 20, 2015, 5 p.m., Ian Babrou wrote:
>
> ---
> This is an automatically generated e-mail. T
)
<https://reviews.apache.org/r/39941/#comment168385>
No longer needed?
src/tests/main.cpp (line 32)
<https://reviews.apache.org/r/39941/#comment168386>
No longer needed?
- Ben Mahler
On Nov. 4, 2015, 5:16 p.m., James
e a TODO for restoring the previous handler
upon finalization of libprocess.
- Ben Mahler
On Nov. 4, 2015, 5:16 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-m
tps://reviews.apache.org/r/40501/#comment168391>
This makes spawning and termination asymmetric! :(
Please follow the approach done here:
https://github.com/apache/mesos/blob/0.26.0-rc3/3rdparty/libprocess/src/tests/http_tests.cpp#L64-L117
- Ben Mahler
On Nov. 19, 2015, 9:51 p.m.,
agent <-> executor
protocol is such that we don't need to in order to fix the issue.
- Ben Mahler
On Nov. 24, 2015, 6:25 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To r
rather than introducing another Process here?
There is already a handler for 'auth', so we can add one called
'/authenticated' and document why '/auth' is still there (looks like it is
going to be obv
.
Let's try to avoid the sleep here if possible.
3rdparty/libprocess/src/tests/http_tests.cpp (lines 1381 - 1387)
<https://reviews.apache.org/r/38000/#comment168943>
Can you use the other macro I mentioned earlier here
the flakiness. After this patch it is no longer flaky in this setup.
Thanks,
Ben Mahler
Thanks for catching this!
- Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41178/#review109664
---
On Dec. 10,
.apache.org/r/41178/#review109667
---
On Dec. 10, 2015, 2:01 a.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
, thanks!
src/tests/health_check_tests.cpp (line 278)
<https://reviews.apache.org/r/41182/#comment169268>
Do we need this comment given you have the ones above these blocks?
- Ben Mahler
On Dec. 10, 2015, 2:50 a.m., Artem Harutyunyan
t169716>
Hm.. it would be great to print the status using WSTRINGIFY on the status
as we do throughout the rest of the code, any reason not to?
- Ben Mahler
On Dec. 11, 2015, 1:35 a.m., Jie Yu wrote:
>
> ---
> This is a
ike both styles are ok here, so I assume you're going for
consistency with the code in this area.
- Ben Mahler
On Dec. 11, 2015, 2:01 a.m., Jie Yu wrote:
>
> ---
> This is an automatically
69833>
Ditto here about not bothering with this, and leaving a comment:
```
// Note that we don't bother pretending to specify a valid
// 'Authorization' header since we force authentication su
evious patch
3rdparty/libprocess/src/tests/http_tests.cpp (line 1398)
<https://reviews.apache.org/r/38094/#comment169846>
How about: s/testpassword/password/
3rdparty/libprocess/src/tests/http_tests.cpp (line 1416)
<https://reviews.apache.org/r/38094/#comment169850>
What
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41114/#review110062
---
Ship it!
Long overdue, thanks!
- Ben Mahler
On Dec. 9, 2015, 1
_tests.cpp
3970dd83aa4ddd2cbe3664c157fc15943ab1182d
Diff: https://reviews.apache.org/r/41318/diff/
Testing
---
Ran with many iterations.
Thanks,
Ben Mahler
/41320/diff/
Testing
---
make check
Thanks,
Ben Mahler
- Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41318/#review110106
---
On Dec. 12, 2015, 11:11 p.m., Ben Mahler wrote:
>
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41326/#review110235
---
Ship it!
Ship It!
- Ben Mahler
On Dec. 13, 2015, 4:28 p.m
: mesos
Description
---
See summary.
Diffs
-
src/files/files.cpp ec036ecc786bce3c7e64ad64e4f4205eea4a9d84
Diff: https://reviews.apache.org/r/41753/diff/
Testing
---
make check
Thanks,
Ben Mahler
h.hpp
0b986f0898da95c4cffd8bde1adfd9994d567096
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp
821dbb185f09e2f279d95fd354ce2168cddf1bac
Diff: https://reviews.apache.org/r/41751/diff/
Testing
---
Added tests.
Thanks,
Ben Mahler
: mesos
Description
---
See summary.
Diffs
-
3rdparty/libprocess/src/process.cpp cff635e74d22185de7ae767bc268ef4d56ad89f8
Diff: https://reviews.apache.org/r/41752/diff/
Testing
---
make check
Thanks,
Ben Mahler
tps://reviews.apache.org/r/40975/#comment172546>
Hm.. since this document is about programming, do we need to say
'programming notes'? Or is 'notes' enough?
It would be nice to also explain why we do this.
- Ben Mahler
On Dec. 4, 2015, 5:
arty/libprocess/src/tests/http_tests.cpp (line 1389)
<https://reviews.apache.org/r/38094/#comment172601>
One more newline here
3rdparty/libprocess/src/tests/http_tests.cpp (lines 1390 - 1446)
<https://reviews.apache.org/r/38094/#comment172602>
Very nic
Seems a bit odd to put a body here, but not in the other cases, no?
- Ben Mahler
On Jan. 4, 2016, 11:26 a.m., Alexander Rojas wrote:
>
> ---
> This is an auto
!
- Ben Mahler
On Jan. 4, 2016, 10:25 a.m., Jocelyn De La Rosa wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41945/#review112952
---
Ship it!
Ship It!
- Ben Mahler
On Jan. 5, 2016, 9:23 p.m
27;ll get this committed
shortly.
support/docker_build.sh (line 70)
<https://reviews.apache.org/r/42011/#comment174274>
I'll add a period here.
- Ben Mahler
On Jan. 7, 2016, 1:55 p.m., Shuai Lin wrote:
>
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42154/#review113893
---
Ship it!
Thank you!
- Ben Mahler
On Jan. 11, 2016, 9:41 p.m
hat you don't need to set the optional str here, can we omit it?
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp (lines 386 - 387)
<https://reviews.apache.org/r/41943/#comment174659>
This can be an EXPECT and no need to store the 'parse' variable:
```
" \"str\": 1.0" // Error due to int for string type.
```
- Ben Mahler
On Jan. 11, 2016, 11:40 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically gene
g 'IsInitialized'.
```
- Ben Mahler
On Jan. 11, 2016, 11:38 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
bles after the if condition? How about
'parse' for both of these?
- Ben Mahler
On Jan. 11, 2016, 11:39 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-ma
--
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42167/
> -----------
>
> (Updated Jan. 11, 2016, 11:39 p.m.)
>
>
> Review request
"Maximum number of completed frameworks to store in memory."
Thoughts?
src/master/master.hpp (line 1352)
<https://reviews.apache.org/r/42053/#comment174682>
2 space indent :)
- Ben Mahler
On Jan. 1
> On None, Ben Mahler wrote:
> > Ship It!
Sorry, I didn't mean to send a ship it, there is no diff here?
- Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42320
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42320/#review114592
---
Ship it!
Ship It!
- Ben Mahler
On Jan. 14, 2016, 10:06 p.m
tps://reviews.apache.org/r/42053/#comment175435>
Could you avoid the tab character here?
- Ben Mahler
On Jan. 13, 2016, 10:43 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
e`, this delayed
resume will crash the master due to the `CHECK(paused)` that currently resides
in `resume`.
Something I'm missing?
src/master/allocator/mesos/hierarchical.cpp (line 468)
<https://reviews.apache.org/r/
12/#comment175535>
whoops: s/{ /{/
src/tests/master_tests.cpp (line 4085)
<https://reviews.apache.org/r/42212/#comment175537>
Perhaps:
```
// There should be only 1 completed framework.
```
Specifically, not sure if we need to describe that we "co
(lines 125 - 135)
<https://reviews.apache.org/r/42100/#comment175735>
Are you sure that this doesn't over-write the period trap?
http://stackoverflow.com/questions/3338030/multiple-bash-traps-for-the-same-signal
- Ben Mahler
On Jan. 9, 2016, 2:38 a.m., Shua
ld be great to consistently refer to
"batch allocation", otherwise readers may be confused as to whether there is a
distinction between a "periodic allocation" and a "batch allocation".
- Ben Mahler
On Jan. 19, 2016, 11:32 p.m., Alexander Rukletsov wrote:
>
> --
;https://reviews.apache.org/r/42519/#comment176851>
Ok, so we don't need to, but how about we lock it just to keep all access
to `status` synchronized? This seems pretty subtle to explain?
- Ben Mahler
On Jan. 19, 2016, 10:58 p.m., Kevin Klues wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42633/#review115807
---
Why did you make this change?
- Ben Mahler
On Jan. 22, 2016, 1
ot so sure.
- Ben Mahler
On Jan. 22, 2016, 1:24 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
s.apache.org/r/42629/#comment176857>
This change actually belongs in the previous patch, since your last change
breaks this test on its own.
- Ben Mahler
On Jan. 22, 2016, 1:24 a.m., Alexander Rukletsov wrote:
>
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41648/#review115805
---
Ship it!
- Ben Mahler
On Jan. 22, 2016, 1:24 a.m., Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42632/#review115806
---
Ship it!
- Ben Mahler
On Jan. 22, 2016, 1:24 a.m., Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42355/#review115797
---
Ship it!
- Ben Mahler
On Jan. 22, 2016, 1:24 a.m., Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42634/#review115811
---
Ship it!
Ship It!
- Ben Mahler
On Jan. 22, 2016, 1:24 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42631/#review115803
---
Ship it!
- Ben Mahler
On Jan. 22, 2016, 1:24 a.m., Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42635/#review115812
---
Ship it!
Ship It!
- Ben Mahler
On Jan. 22, 2016, 1:24 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42630/#review115810
---
Ship it!
- Ben Mahler
On Jan. 22, 2016, 1:24 a.m., Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42637/#review115814
---
Ship it!
Ship It!
- Ben Mahler
On Jan. 22, 2016, 1:24 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42636/#review115813
---
Ship it!
Ship It!
- Ben Mahler
On Jan. 22, 2016, 1:24 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42518/#review116000
---
Ship it!
Thanks Kapil!
- Ben Mahler
On Jan. 23, 2016, 3:59
ever want to run benchmarks in CI.
Diffs
-
docs/release-guide.md 7c9ee140b394d61581f736f2413969d650f18fa4
Diff: https://reviews.apache.org/r/42881/diff/
Testing
---
N/A
Thanks,
Ben Mahler
ter_tests.cpp (line 4038)
<https://reviews.apache.org/r/42921/#comment177935>
Usually the type is omitted from the name, e.g. schedRegistered instead of
schedRegisteredFuture.
So the following would be more consistent with our naming style:
```
s/offersQueue/offers/
```
- Be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42921/#review117018
---
Ship it!
Ship It!
- Ben Mahler
On Jan. 28, 2016, 10:56 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42787/#review117017
---
Ship it!
Ship It!
- Ben Mahler
On Jan. 26, 2016, 7:41 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42788/#review117019
---
Ship it!
Ship It!
- Ben Mahler
On Jan. 26, 2016, 7:41 a.m
g/r/42955/#comment178090>
This looks ok to me, but could you ping mpark to see if he has any feedback
on this?
3rdparty/libprocess/include/process/collect.hpp (line 223)
<https://reviews.apache.org/r/42955/#comment178089>
s/func/f/
- Ben Mahler
On Jan. 29, 2016, 9:18 p.m.,
/configuration.md 2f0628a71539ad66fbd96c6a7ff2c7c8eb518e32
src/master/flags.cpp 4a0e21092bfad8baee0279d473e6056842139be7
Diff: https://reviews.apache.org/r/42980/diff/
Testing
---
N/A
Thanks,
Ben Mahler
/include/process/collect.hpp (lines 249 - 250)
<https://reviews.apache.org/r/42956/#comment178126>
Ditto from last review here, newline and .then on newline (since we treat
it like a statement).
- Ben Mahler
On Jan. 30, 2016, 1:43 a.m., Kevin Klues
ct(wrappers)
.then(std::bind(f, futures...));
```
- Ben Mahler
On Jan. 30, 2016, 1:43 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
Then the consumption code looks like this:
```
for process in processes:
for endpoint in process.endpoints:
process.id, endpoint.name, endpoint.text
```
We might want a comment that shows the format to help th
--
>
> (Updated Feb. 4, 2016, 8:39 p.m.)
>
>
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
>
>
> Bugs: MESOS-3831
> https://issues.apache.org/jira/browse/MESOS-3831
>
>
> Repository: m
a browser it is difficult to change
// the 'Accept' header.
```
- Ben Mahler
On Feb. 4, 2016, 8:39 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
of steps to perform the replacement? That will be way easier
to reason about, this regex has become nasty.
- Ben Mahler
On Feb. 4, 2016, 8:38 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42957/#review117958
---
Ship it!
Ship It!
- Ben Mahler
On Feb. 5, 2016, 3:20 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43215/#review117959
---
Ship it!
Ship It!
- Ben Mahler
On Feb. 5, 2016, 3:21 a.m
"endpoints": [ { "name" : name, "text" : text }, ... ]
// },
// ...
// ]
// }
```
- Ben Mahler
On Feb. 5, 2016, 3:22 a.m., Kevin Klues wrote:
>
> ---
> Th
-
>
> (Updated Feb. 5, 2016, 3:23 a.m.)
>
>
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
>
>
> Bugs: MESOS-3831
> https://issues.apache.org/jira/browse/MESOS-3831
>
>
> Repository: mesos
>
>
> Description
> -
since the test can proceed if these fail.
- Ben Mahler
On Feb. 5, 2016, 3:24 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42790/#review117969
---
Ship it!
Ship It!
- Ben Mahler
On Feb. 5, 2016, 3:26 a.m
tps://reviews.apache.org/r/43221/#comment179264>
Some whitespace and typo touchups needed here.
- Ben Mahler
On Feb. 5, 2016, 3:27 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review117971
---
Ship it!
Ship It!
- Ben Mahler
On Feb. 5, 2016, 3:28 a.m
ese?
support/generate-endpoint-help.py (lines 366 - 383)
<https://reviews.apache.org/r/43220/#comment179284>
I wonder if we need these? Sounds like master and agent should be
parameters rather than different function names?
- Ben Mahler
On Feb. 5, 2016, 3:30 a.m., Kevin
aller as that might be a bit tougher to follow.
Curious to see if we can make this easier for dummies like me :)
support/generate-endpoint-help.py (line 304)
<https://reviews.apache.org/r/43220/#comment179364>
relative_path
- Ben Mahler
On Feb. 5, 2016, 11:17 p.m., Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43121/#review118119
---
Ship it!
Ship It!
- Ben Mahler
On Feb. 3, 2016, 12:15 a.m
elaborating in the
description?
- Ben Mahler
On Feb. 5, 2016, 9:19 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
<https://reviews.apache.org/r/43263/#comment179366>
Would be great to include exact commands to run so that folks doing this
don't have to think as hard, would that be do-able here?
- Ben Mahler
On Feb. 6, 2016, 12:13 a.m., Kapil Arya wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43122/#review118185
---
Ship it!
Ship It!
- Ben Mahler
On Feb. 6, 2016, 11:30 p.m
tory, or? How does one
check this?
site/README.md (lines 86 - 87)
<https://reviews.apache.org/r/43263/#comment179416>
Could you include a "-m " here so that people are including
messages when they make commits?
- Ben Mahl
<https://reviews.apache.org/r/43220/#comment179431>
Seems simpler to just append \n here and use a regular string literal?
support/generate-endpoint-help.py (lines 77 - 93)
<https://reviews.apache.org/r/43220/#comment179458>
Could we make the line wrapping formatting consistent here?
tps://reviews.apache.org/r/43324/#comment179429>
A pointer to support/generate-endpoint-help.py might help contributors
figure out how this works. I'll make this change in the script in the previous
review.
- Ben Mahler
On Feb. 8, 2016, 7:07 a.m., Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43318/#review118241
---
Ship it!
Ship It!
- Ben Mahler
On Feb. 8, 2016, 12:41 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42657/#review118417
---
Ship it!
Ship It!
- Ben Mahler
On Jan. 28, 2016, 1:08 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42633/#review118416
---
Ship it!
Ship It!
- Ben Mahler
On Feb. 2, 2016, 10:28 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42658/#review118418
---
Ship it!
Ship It!
- Ben Mahler
On Jan. 28, 2016, 1:11 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42672/#review118420
---
Ship it!
Ship It!
- Ben Mahler
On Jan. 28, 2016, 1:22 p.m
801 - 900 of 964 matches
Mail list logo
