d `waited()` to handle this.
- Gaston
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65551/#review197314
---
On Feb. 9,
he same comment in the previous review :)
Boolean removed in https://reviews.apache.org/r/65616
- Gaston
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65551/#review197298
-------
/Linux
Thanks,
Gaston Kleiman
mail. To reply, visit:
https://reviews.apache.org/r/65550/#review197304
-------
On Feb. 12, 2018, 3:13 p.m., Gaston Kleiman wrote:
>
> ---
> This is an automatically generated e
--gtest_repeat=650 --gtest_break_on_failure` on GNU/Linux
Thanks,
Gaston Kleiman
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65552/#review197312
-----------
On Feb. 12, 2018, 3:24 p.m., Gaston Kleiman wrote:
>
> -
` on GNU/Linux
Thanks,
Gaston Kleiman
---
`sudo make check` on GNU/Linux
Thanks,
Gaston Kleiman
---
`sudo make check` on GNU/Linux
Regression test on https://reviews.apache.org/r/65552/
Thanks,
Gaston Kleiman
/Linux
Thanks,
Gaston Kleiman
4a619859095cc2d30f4806813f64a2e48c83b3ea
Diff: https://reviews.apache.org/r/65549/diff/2/
Changes: https://reviews.apache.org/r/65549/diff/1-2/
Testing
---
None, this patch doesn't contain functional changes.
Thanks,
Gaston Kleiman
ll).
- Gaston
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65549/#review197215
---
On Feb. 7, 2018, 10:59 a.m., Gasto
y generated e-mail. To reply, visit:
https://reviews.apache.org/r/65550/#review197217
---
On Feb. 7, 2018, 11 a.m., Gaston Kleiman wrote:
>
> ---
> This is an aut
he.org/jira/browse/MESOS-8537.
- Gaston Kleiman
On Feb. 7, 2018, 11 a.m., Gaston Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
`sudo make check` on GNU/Linux
Regression test on https://reviews.apache.org/r/65552/
Thanks,
Gaston Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65518/#review197141
---
Ship it!
Ship It!
- Gaston Kleiman
On Feb. 8, 2018, 5:03
tps://reviews.apache.org/r/64387/#comment277255>
Can you add a comment explaining why we need a custom image?
src/tests/health_check_tests.cpp
Lines 132 (patched)
<https://reviews.apache.org/r/64387/#comment277256>
s/img/image/
or
s/image/pull/
- Gaston Kleiman
<https://reviews.apache.org/r/65127/#comment277252>
Add a period at the end of the line.
s/health check/check/
- Gaston Kleiman
On Feb. 8, 2018, 9:51 a.m., Akash Gupta wrote:
>
> ---
> This is an automatically gener
^
2 errors generated.
```
- Gaston Kleiman
On Feb. 8, 2018, 9:49 a.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
ue(),
Subprocess::PATH(os::DEV_NULL),
Subprocess::FD(STDERR_FILENO),
Subprocess::FD(STDERR_FILENO),
environment,
genCloneFunc(plain));
```
src/checks/checker_process.cpp
Lines 978-979 (patched)
<https://reviews.apache.org/r/6539
.
Repository: mesos
Description
---
Removed redundant comment from the command executor.
Diffs
-
src/launcher/executor.cpp 050f5a057f360873e2b4738b126289bcd1bd0c7f
Diff: https://reviews.apache.org/r/65575/diff/1/
Testing
---
Not a functional change.
Thanks,
Gaston
cc2685a6bc14103c639ce776cf1c912361e93381
src/master/metrics.hpp f701efec0a82d6ba72b2414f739fcd1cd7ee2491
src/master/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba
Diff: https://reviews.apache.org/r/65362/diff/3/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
a task group.
Diffs
-
src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
Diff: https://reviews.apache.org/r/65556/diff/1/
Testing
---
`sudo make check` on GNU/Linux
Thanks,
Gaston Kleiman
/1/
Testing
---
`GLOG_v=1 sudo bin/mesos-tests.sh --gtest_filter='*ROOT_LaunchGroupFailure*'
--verbose --gtest_repeat=650 --gtest_break_on_failure` on GNU/Linux
Thanks,
Gaston Kleiman
task groups.
Diffs
-
src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
Diff: https://reviews.apache.org/r/65551/diff/1/
Testing
---
`sudo make check` on GNU/Linux
Regression test on https://reviews.apache.org/r/65552/
Thanks,
Gaston Kleiman
/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
Diff: https://reviews.apache.org/r/65550/diff/1/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
---
None, this patch doesn't contain functional changes.
Thanks,
Gaston Kleiman
(task status update state eq TASK_ERROR)
Actual: TASK_STARTING (Status UUID:
f379eb50-1163-442a-8e30-a0c2f5247575) for task 'sleepTask1'
```
Thanks,
Gaston Kleiman
> On Feb. 6, 2018, 10:29 a.m., Gaston Kleiman wrote:
> > src/slave/slave.cpp
> > Line 9530 (original), 9529 (patched)
> > <https://reviews.apache.org/r/65522/diff/1/?file=1953214#file1953214line9530>
> >
> > I noticed that if a single task is passed, w
, 9529 (patched)
<https://reviews.apache.org/r/65522/#comment276899>
I noticed that if a single task is passed, we surround its ID in single
quotes, but we don't do that if a task groups is passed.
We might want to do this consistently.
- Gaston Kleiman
On Feb. 5, 2018, 8:1
cc2685a6bc14103c639ce776cf1c912361e93381
Diff: https://reviews.apache.org/r/64618/diff/5/
Changes: https://reviews.apache.org/r/64618/diff/4-5/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
f0b86775b7919ba6aa4a73038edb78a0adca68f4
Diff: https://reviews.apache.org/r/65363/diff/2/
Changes: https://reviews.apache.org/r/65363/diff/1-2/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
/master/metrics.hpp f701efec0a82d6ba72b2414f739fcd1cd7ee2491
src/master/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba
Diff: https://reviews.apache.org/r/65300/diff/4/
Changes: https://reviews.apache.org/r/65300/diff/3-4/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston
-3/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65427/#review196618
---
Ship it!
Ship It!
- Gaston Kleiman
On Jan. 30, 2018, 5 p.m
---
Fixed `contributors.yaml`.
Diffs
-
docs/contributors.yaml e368372fdc3715f1e755a502bf0ecc9d1d1bc880
Diff: https://reviews.apache.org/r/65451/diff/1/
Testing
---
Used a python script to load the yaml.
Thanks,
Gaston Kleiman
://issues.apache.org/jira/browse/MESOS-8184
Repository: mesos
Description
---
Improved task status acknowledgement logging messages.
Diffs
-
src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
Diff: https://reviews.apache.org/r/65424/diff/1/
Testing
---
Thanks,
Gaston
c489b6f525f157811549b2cc84addd9d85e87990
src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
Diff: https://reviews.apache.org/r/64618/diff/4/
Changes: https://reviews.apache.org/r/64618/diff/3-4/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
/diff/1-2/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
/devolve.cpp 1cfbdf2ab58cf64ca0947c2dbc8e7f244c912fbe
Diff: https://reviews.apache.org/r/65361/diff/2/
Changes: https://reviews.apache.org/r/65361/diff/1-2/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65409/#review196472
---
Ship it!
Ship It!
- Gaston Kleiman
On Jan. 29, 2018, 12:41
tps://reviews.apache.org/r/65315/#comment276009>
Would `PermissiveObjectApprover` be a better name?
- Gaston Kleiman
On Jan. 24, 2018, 10:05 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
(patched)
<https://reviews.apache.org/r/65316/#comment276008>
Remove this blank line.
- Gaston Kleiman
On Jan. 24, 2018, 12:04 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
Diff: https://reviews.apache.org/r/64618/diff/3/
Changes: https://reviews.apache.org/r/64618/diff/2-3/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
check` on GNU/Linux
Thanks,
Gaston Kleiman
iffs
-
src/internal/devolve.cpp 1cfbdf2ab58cf64ca0947c2dbc8e7f244c912fbe
Diff: https://reviews.apache.org/r/65357/diff/1/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
Diff: https://reviews.apache.org/r/65360/diff/1/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
/metrics.hpp f701efec0a82d6ba72b2414f739fcd1cd7ee2491
src/master/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba
Diff: https://reviews.apache.org/r/65362/diff/1/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
Diff: https://reviews.apache.org/r/65358/diff/1/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
f701efec0a82d6ba72b2414f739fcd1cd7ee2491
src/master/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba
Diff: https://reviews.apache.org/r/65300/diff/3/
Changes: https://reviews.apache.org/r/65300/diff/2-3/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
paths.
Diffs
-
src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
Diff: https://reviews.apache.org/r/65359/diff/1/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
,
Gaston Kleiman
w accessing the
web UI via a reverse proxy"? I'd probably also rename the flag.
- Gaston Kleiman
On Jan. 24, 2018, 1:40 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
send(
v1::createCallAccept(
frameworkId,
offer,
{v1::LAUNCH({taskInfo}));
```
- Gaston Kleiman
On Jan. 24, 2018, 11:38 a.m., Greg Mann wrote:
>
> ---
> This is an aut
Shouldn't we add a similar method: `Master:Http:OPERATIONS_HELP()`?
src/master/validation.cpp
Lines 133-134 (patched)
<https://reviews.apache.org/r/65044/#comment275666>
Ditto, move this above `GET_TASKS`.
- Gaston Kleiman
On Jan. 24, 2018, 1:36 a.m.,
/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba
Diff: https://reviews.apache.org/r/65300/diff/1/
Testing
---
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
tps://reviews.apache.org/r/65044/#comment275582>
This test doesn't use more than one offer, so we don't need this filter.
- Gaston Kleiman
On Jan. 23, 2018, 4:14 a.m., Jan Schlicht wrote:
>
> ---
> This is an automatically g
es 1048-1049 (original)
<https://reviews.apache.org/r/65127/#comment275576>
I think this should stay here, it's weird for `createTcpCheckCmd` to log
this.
- Gaston Kleiman
On Jan. 16, 2018, 4:09 p.m.,
tps://reviews.apache.org/r/64387/#comment275572>
Why can't we use an official image that Microsoft will keep up-to-date?
- Gaston Kleiman
On Jan. 17, 2018, 4:12 a.m., Akash Gupta wrote:
>
> ---
> This is an automatically g
(original), 2470 (patched)
<https://reviews.apache.org/r/65252/#comment275388>
Thanks for the cleanup!
I did a diff, and in the v0 proto there's only one space after the period
in this line.
So I'd say we should: `s/meta-data. /meta-data. /`
- Gaston Kleiman
On J
8fc6d2bafaa8bef9ea6957e6d352de371e358f1d
Diff: https://reviews.apache.org/r/65197/diff/3/
Changes: https://reviews.apache.org/r/65197/diff/2-3/
Testing
---
Thanks,
Gaston Kleiman
ster received a terminal operation
status update before doing the `GET_OPERATIONS` call?
We probably want to drop all `UpdateOperationStatusMessage` protobufs from
the agent to the salve.
- Gaston Kleiman
On Jan. 22, 2018, 6:02
='StorageLocalResourceProviderTest.ROOT_RetryOperationStatusUpdateAfterRecovery'
--verbose --gtest_repeat=1000 --gtest_break_on_failure` on GNU/Linux
Thanks,
Gaston Kleiman
/65057/diff/6/
Changes: https://reviews.apache.org/r/65057/diff/5-6/
Testing
---
`sudo bin/mesos-tests.sh
--gtest_filter='StorageLocalResourceProviderTest.ROOT_RetryOperationStatusUpdate'
--gtest_repeat=100 --gtest_break_on_failure` on GNU/Linux
Thanks,
Gaston Kleiman
/diff/5/
Changes: https://reviews.apache.org/r/65057/diff/4-5/
Testing
---
`sudo bin/mesos-tests.sh
--gtest_filter='StorageLocalResourceProviderTest.ROOT_RetryOperationStatusUpdate'
--gtest_repeat=100 --gtest_break_on_failure` on GNU/Linux
Thanks,
Gaston Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65232/#review195760
---
Ship it!
Ship It!
- Gaston Kleiman
On Jan. 18, 2018, 4:40
from the patch.
- Gaston
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65197/#review195670
---
On Jan. 17, 2018, 4:16
addresses to the contributors list.
Diffs (updated)
-
docs/contributors.yaml 8bfeb89a9dea3de424b454dc0958515bb855f455
Diff: https://reviews.apache.org/r/65197/diff/2/
Changes: https://reviews.apache.org/r/65197/diff/1-2/
Testing
---
Thanks,
Gaston Kleiman
---
Updated Gaston Kleiman's entry in contributors.yaml.
Diffs
-
docs/contributors.yaml 8bfeb89a9dea3de424b454dc0958515bb855f455
Diff: https://reviews.apache.org/r/65197/diff/1/
Testing
---
Thanks,
Gaston Kleiman
nstead of powershell inside a huge container?
- Gaston Kleiman
On Jan. 16, 2018, 8:41 a.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
bin/mesos-tests.sh
--gtest_filter='StorageLocalResourceProviderTest.ROOT_RetryOperationStatusUpdateAfterRecovery'
--verbose --gtest_repeat=1000 --gtest_break_on_failure` on GNU/Linux
Thanks,
Gaston Kleiman
-8441.
Diffs (updated)
-
src/master/master.cpp c96cd7090875fbf1b11b1708390e88182c77655b
Diff: https://reviews.apache.org/r/65137/diff/4/
Changes: https://reviews.apache.org/r/65137/diff/3-4/
Testing
---
`sudo bin/mesos-tests.sh` on GNU/Linux.
Thanks,
Gaston Kleiman
c96cd7090875fbf1b11b1708390e88182c77655b
Diff: https://reviews.apache.org/r/65137/diff/1/
Testing
---
`sudo bin/mesos-tests.sh` on GNU/Linux.
Thanks,
Gaston Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65093/#review195273
---
Ship it!
Thanks for the cleanup!
- Gaston Kleiman
On Jan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64846/#review195258
---
Ship it!
Ship It!
- Gaston Kleiman
On Dec. 27, 2017, 6:06
)
<https://reviews.apache.org/r/65072/#comment274368>
Shouldn't we skip this if the operation was already in a terminal state?
- Gaston Kleiman
On Jan. 10, 2018, 7:17 a.m., Benjamin Bannier wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65056/#review195195
---
Ship it!
Ship It!
- Gaston Kleiman
On Jan. 10, 2018, 3:11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65042/#review195183
---
Ship it!
Ship It!
- Gaston Kleiman
On Jan. 10, 2018, 1:16
tps://reviews.apache.org/r/65056/#comment274326>
s/slaves/agents/g =).
- Gaston Kleiman
On Jan. 9, 2018, 3:57 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/
Testing
---
Thanks,
Gaston Kleiman
bbfe95e9818f25fdd5405db3ad2fe355e023f743
Diff: https://reviews.apache.org/r/65057/diff/1/
Testing
---
`sudo bin/mesos-tests.sh
--gtest_filter='StorageLocalResourceProviderTest.ROOT_RetryOperationStatusUpdate'
--gtest_repeat=100 --gtest_break_on_failure` on GNU/Linux
Thanks,
Gaston
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65034/#review195080
---
Ship it!
Ship It!
- Gaston Kleiman
On Jan. 9, 2018, 1:34
-
>
> (Updated Jan. 9, 2018, 10:02 a.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> This patch introduces an example HTTP framework which transforms
> 'RAW'
AUTHENTICATORS` so that the scheduler driver knows how to
authenticate with the local master?
Why do we set `MESOS_ACLS`? The scheduler driver doesn't seem to use it.
- Gaston Kleiman
On Jan. 9, 2018, 10:01 a.m., Benj
(patched)
<https://reviews.apache.org/r/64992/#comment274103>
Nit: s/periodiaclly/periodically/
- Gaston Kleiman
On Jan. 8, 2018, 2:18 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64604/#review195001
---
Ship it!
Ship It!
- Gaston Kleiman
On Jan. 4, 2018, 4:32
rg/r/64387/#comment274094>
Just curious, are 60 not enough on Windows?
src/tests/health_check_tests.cpp
Line 2242 (original)
<https://reviews.apache.org/r/64387/#comment274098>
Keep the blank line.
- Gaston Kleiman
On Jan. 4, 2018, 4:33 p.m., Akash Gupta wrote:
>
>
ched)
<https://reviews.apache.org/r/64386/#comment274085>
Nit: s/healthcheck/health check/
- Gaston Kleiman
On Jan. 4, 2018, 4:31 p.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
> On Jan. 8, 2018, 2:54 p.m., Gaston Kleiman wrote:
> >
I can't review the powershell commands, but the rest looks sane.
- Gaston
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.or
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64570/#review194991
---
Ship it!
Ship It!
- Gaston Kleiman
On Jan. 4, 2018, 4:32
/the default the default network/the default mode/
- Gaston Kleiman
On Jan. 5, 2018, 10:32 a.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
58-759 (patched)
<https://reviews.apache.org/r/63860/#comment274078>
Fits in one line.
- Gaston Kleiman
On Jan. 5, 2018, 2:25 p.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To
> On Jan. 4, 2018, 12:49 p.m., Gaston Kleiman wrote:
> > src/examples/test_csi_user_framework.cpp
> > Lines 444-447 (patched)
> > <https://reviews.apache.org/r/64932/diff/1/?file=1930012#file1930012line444>
> >
> > Shouldn't this be a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64932/#review194983
---
Ship it!
- Gaston Kleiman
On Jan. 8, 2018, 2:06 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65016/#review194981
---
Ship it!
Thanks a lot for the cleanup!
- Gaston Kleiman
> On Jan. 4, 2018, 12:49 p.m., Gaston Kleiman wrote:
> > src/examples/test_csi_user_framework.cpp
> > Lines 399 (patched)
> > <https://reviews.apache.org/r/64932/diff/1/?file=1930012#file1930012line399>
> >
> > Why don't we mak
> On Jan. 4, 2018, 12:49 p.m., Gaston Kleiman wrote:
> > src/examples/test_csi_user_framework.cpp
> > Lines 165-184 (patched)
> > <https://reviews.apache.org/r/64932/diff/1/?file=1930012#file1930012line165>
> >
> > This framework will never launch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64879/#review194806
---
Ship it!
Ship It!
- Gaston Kleiman
On Dec. 30, 2017, 12:06
: mesos
Description
---
Fixed typos in SRLP tests.
Diffs
-
src/tests/storage_local_resource_provider_tests.cpp
b522b406205ab4a8cb430bedd18ec00c9f437e8a
Diff: https://reviews.apache.org/r/64963/diff/1/
Testing
---
Thanks,
Gaston Kleiman
201 - 300 of 444 matches
Mail list logo
