/foreach.hpp
7fb0044790ee249b69e07b81a26851bd5bfb110f
Diff: https://reviews.apache.org/r/46165/diff/
Testing
---
`make check`
Thanks,
Michael Park
/libprocess/3rdparty/stout/include/stout/foreach.hpp
7fb0044790ee249b69e07b81a26851bd5bfb110f
Diff: https://reviews.apache.org/r/46165/diff/
Testing
---
`make check`
Thanks,
Michael Park
askResources =
Resources::parse("cpus:1;mem:128;disk(" + DEFAULT_ROLE +
"):32").get() +
volume;
```
src/tests/persistent_volume_tests.cpp (lines 682 - 684)
<https://reviews.apache.org/r/41613/#comment195577>
Same as above.
- Michael Park
On Ja
7fb0044790ee249b69e07b81a26851bd5bfb110f
Diff: https://reviews.apache.org/r/46165/diff/
Testing
---
`make check`
Thanks,
Michael Park
/
Testing
---
`make check` on Ubuntu 14.04 with GCC 4.8
Thanks,
Michael Park
/stout/include/stout/json.hpp
d1f4ae6a1d1e6ccfe55f9f8f78390826dc97d894
Diff: https://reviews.apache.org/r/46945/diff/
Testing
---
`make check` on Ubuntu 14.04 with GCC 4.8
Thanks,
Michael Park
pp
auto iter = aliases.count(flag_name) ? flags_.find(aliases[flag_name])
: flags_.find(flag_name);
```
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 841)
<https://reviews.apache.org/r/46621/#comment195995>
e().onAny([fd]() { os::close(fd); });
```
Here and below.
- Michael Park
On May 5, 2016, 3:12 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vis
> On May 2, 2016, 9:14 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/subprocess_windows.cpp, line 414
> > <https://reviews.apache.org/r/46608/diff/1/?file=1358649#file1358649line414>
> >
> > Remove newline.
>
> Alex Clemmer wrote:
> I wa
(line 583)
<https://reviews.apache.org/r/46608/#comment195303>
`s/stdoutfds.read/stderrfds.read/`
3rdparty/libprocess/src/subprocess_windows.cpp (line 590)
<https://reviews.apache.org/r/46608/#comment195306>
Why not use a `unique_ptr` or
;
} else {
body += "'" + *it + "', ";
}
}
}
body += ", received '" + requestMethod + "'";
return body;
}
```
In eit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46814/#review131948
---
Ship it!
Ship It!
- Michael Park
On April 30, 2016, 1:59
y/libprocess/3rdparty/stout/include/stout/flags/flag.hpp (line 40)
<https://reviews.apache.org/r/46620/#comment195987>
(1) Can we make this `private` and add a `const std::string& get() const {
return value; }`
(2) `s/value/value_/`
- Michael Park
On April 30, 2016, 1:56
> On May 4, 2016, 10:53 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 2240-2270
> > <https://reviews.apache.org/r/46395/diff/2/?file=1358642#file1358642line2240>
> >
> > Consider this if you would to preserve the guarantee:
> &g
e processing threads.
for (long i = 0; i < num_worker_threads; i++) {
// Retain the thread handles so that we can join when shutting down.
threads.emplace_back(new std::thread(worker));
}
```
- Michael Park
well, in which case we should just define this in `os.hpp`.
- Michael Park
On April 14, 2016, 8:28 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To
about this similar to below?
```
// NOTE: `getsid` does not have a meaningful interpretation on Windows.
```
- Michael Park
On April 14, 2016, 2:06 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically genera
stout/os.hpp (line 214)
<https://reviews.apache.org/r/46013/#comment192441>
`s/> >/>>/`
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 217)
<https://reviews.apache.org/r/46013/#comment192442>
Remove newline.
- Michael P
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46015/#review128995
---
Ship it!
Ship It!
- Michael Park
On April 11, 2016, 9:02
would be better, or maybe:
```
EXPECT_FALSE(info.get().release.empty());
```
- Michael Park
On April 14, 2016, 8:28 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46193/#review129007
---
Ship it!
Ship It!
- Michael Park
On April 14, 2016, 8:28
> On April 14, 2016, 9:55 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, lines
> > 355-360
> > <https://reviews.apache.org/r/46191/diff/1/?file=1343998#file1343998line355>
> >
> > If we pull out `inter
result in 0 by the division.
What do you think?
- Michael Park
On April 15, 2016, 7:50 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
me/`
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 349)
<https://reviews.apache.org/r/46191/#comment192658>
`s/name/nodename/`
- Michael Park
On April 15, 2016, 8:42 a.m., Alex Clemmer wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46192/#review129197
---
Ship it!
Ship It!
- Michael Park
On April 15, 2016, 8:51
> On April 14, 2016, 9:10 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 173-183
> > <https://reviews.apache.org/r/46013/diff/6/?file=1344018#file1344018line173>
> >
> > (1) It seems like this should l
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46013/#review129192
---
Ship it!
Ship It!
- Michael Park
On April 15, 2016, 7:50
> On April 14, 2016, 9:55 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 310
> > <https://reviews.apache.org/r/46191/diff/1/?file=1343998#file1343998line310>
> >
> > Please use a C++ cast.
>
> Alex C
.
VLOG(1) << length.error().message;
return Failure(length.error());
}
```
- Michael Park
On April 16, 2016, 12:20 a.m., Daniel Pravat wrote:
>
> ---
> This is an automatically generated e-mail. To repl
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46013/#review129642
---
Ship it!
Ship It!
- Michael Park
On April 18, 2016, 7:09
37ef33257830e32875500537df7af38757c6efac
Diff: https://reviews.apache.org/r/46418/diff/
Testing
---
`make check`
Thanks,
Michael Park
still).
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp (line
39)
<https://reviews.apache.org/r/43985/#comment193098>
Should return `SocketError` here (I know they're the same, but still).
- Michael Park
On April 16, 2016, 1:10 a.m., Daniel Pravat wrote:
mment193111>
We should be looking at `result.error().code`. Here and below.
- Michael Park
On April 16, 2016, 12:20 a.m., Daniel Pravat wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
> On April 14, 2016, 9:19 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp, lines 43-61
> > <https://reviews.apache.org/r/46014/diff/3/?file=1343687#file1343687line43>
> >
> > Do we have plans to implement this
arty/stout/include/stout/os/windows/sendfile.hpp (line
43)
<https://reviews.apache.org/r/43985/#comment193366>
I requested to return `SocketError` here, it's marked as resolved but it
doesn't seem so.
3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (lines 119 -
121)
&l
`
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/#review132242
---
Ship it!
Ship It!
- Michael Park
On May 5, 2016, 3:35 p.m
/include/stout/windows/os.hpp
71a8c61335e2bce340447e94e855a6bd79c49dec
Diff: https://reviews.apache.org/r/46418/diff/
Testing
---
`make check`
Thanks,
Michael Park
`s/& subject/& subject/`
- Michael Park
On May 25, 2016, 5:19 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
--
>
> (Updated May 24, 2016, 9:44 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Michael Park.
>
>
> Bugs: MESOS-5169
> https://issues.apache.org/jira/browse/MESOS-5169
>
>
> Repository: mesos
>
>
> De
---
`data` is initialized with `new char[size]`. It should be `delete`d with
`delete[]`.
Diffs
-
3rdparty/libprocess/src/tests/test_linkee.cpp
b7bd64c866cfe392b36a0105a5720b115c08623d
Diff: https://reviews.apache.org/r/49994/diff/
Testing
---
`make check`
Thanks,
Michael Park
. Thanks!
- Michael Park
On April 19, 2016, 4:01 a.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45698/#review145525
---
Ship it!
Ship It!
- Michael Park
On Aug. 11, 2016, 5:21 p.m
> On Aug. 11, 2016, 10:16 a.m., Michael Park wrote:
> > Hi Klaus, could you explain what the motivation is for this patch?
> > Currently, your analysis seems correct that reserved resources are always
> > non-revocable.
> > However, the current code seems that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50887/#review145370
---
Ship it!
Ship It!
- Michael Park
On Aug. 8, 2016, 4:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50899/#review145371
---
Ship it!
Ship It!
- Michael Park
On Aug. 8, 2016, 4:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50900/#review145372
---
Ship it!
Ship It!
- Michael Park
On Aug. 8, 2016, 4:19 p.m
)
<https://reviews.apache.org/r/49707/#comment211715>
Formatting:
```
if (!strings::startsWith(uri, FILE_URI_PREFIX) &&
strings::contains(uri, "://")) {
```
- Michael Park
On July 6, 2016, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49314/#review139772
---
Ship it!
Ship It!
- Michael Park
On June 28, 2016, 12:45
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49631/#review140760
---
Ship it!
Ship It!
- Michael Park
On July 5, 2016, 12:04 p.m
0a921347586808863e615ca3dcc23fae92b629f5
Diff: https://reviews.apache.org/r/49003/diff/
Testing
---
Thanks,
Michael Park
PRE-CREATION
site/source/assets/img/blog/contributing_to_mesos_contributor_diversity.png
PRE-CREATION
site/source/blog/2016-06-20-contributing-to-mesos.md PRE-CREATION
Diff: https://reviews.apache.org/r/49003/diff/
Testing
---
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49377/#review140656
---
Ship it!
Ship It!
- Michael Park
On July 4, 2016, 8:53 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49246/#review140661
---
Ship it!
Ship It!
- Michael Park
On July 4, 2016, 1:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49323/#review140655
---
Ship it!
Ship It!
- Michael Park
On July 4, 2016, 8:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50774/#review145110
---
Ship it!
Ship It!
- Michael Park
On Aug. 3, 2016, 11:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49315/#review140168
---
Ship it!
Ship It!
- Michael Park
On June 28, 2016, 6:49 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49442/#review140557
---
Ship it!
Ship It!
- Michael Park
On June 30, 2016, 1 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49503/#review140556
---
Ship it!
Ship It!
- Michael Park
On July 1, 2016, 10:12 a.m
below. In the test below, the last check is:
```
AWAIT_READY(offers);
ASSERT_EQ(1u, offers.get().size());
offer = offers.get()[0];
EXPECT_TRUE(Resources(offer.resources()).contains(unreserved));
```
- Michael Park
On July 1, 2016, 9:47 a.m., Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49140/#review140555
---
Ship it!
Ship It!
- Michael Park
On June 26, 2016, 9:46 a.m
gs.hpp (lines 386 - 390)
<https://reviews.apache.org/r/49246/#comment205973>
```
return s.size() >= suffix.size() &&
std::equal(suffix.rbegin(), suffix.rend(), s.rbegin());
```
- Michael Park
On June 2
R`,
and can only operate on resources to make them transition between `*` and `R`.
I don't see what we would be missing here.
- Michael Park
On July 1, 2016, 9:47 a.m., Neil Conway wrote:
>
> ---
> This is an automatically gener
15ff61ff54d72c951edbd591058ad04f8d1efb58
Diff: https://reviews.apache.org/r/49582/diff/
Testing
---
`make check`
Thanks,
Michael Park
://issues.apache.org/jira/browse/MESOS-5692
Repository: mesos
Description
---
See summary.
Diffs
-
3rdparty/stout/include/stout/path.hpp
3d06ca29ce9d4d133c3ec014aa99a51aa5289bc9
Diff: https://reviews.apache.org/r/49581/diff/
Testing
---
`make check`
Thanks,
Michael Park
> (Updated July 4, 2016, 8:05 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Used startsWith char version for role validation.
>
>
> Diffs
> -
>
> src/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49376/#review140579
---
Ship it!
Ship It!
- Michael Park
On July 3, 2016, 8:36 a.m
(lines 5646 - 5647)
<https://reviews.apache.org/r/55972/#comment235415>
Let's use `foreach` here.
- Michael Park
On Jan. 26, 2017, 4:29 p.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated
() > 0) {
info.mutable_roles()->CopyFrom(source.roles());
} else {
info.clear_roles();
}
```
- Michael Park
On Jan. 26, 2017, 4:30 p.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To
?
support/apply-reviews.py (line 326)
<https://reviews.apache.org/r/55732/#comment235560>
Let's add the `-3` short option as well.
- Michael Park
On Feb. 1, 2017, 10:45 a.m., Zhitao Li wrote:
>
> ---
> This is an aut
edResources2.get()));
EXPECT_EQ(agentResources, unallocated(recoveredResources3.get()));
```
src/tests/resource_offers_tests.cpp (line 266)
<https://reviews.apache.org/r/55973/#comment235467>
Was this for debugging?
- Michael Park
On Jan. 26, 2017, 4:34 p.m., Ben
/sorter.cpp (line 390)
<https://reviews.apache.org/r/56249/#comment235857>
Do you not want to just go all the way to this?
```cpp
foreach (const Client& client, clients) {
// ...
}
```
Here and below.
- Michael Park
On Feb. 2, 2017, 2:59 p.m., Neil Co
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56245/#review164198
---
Ship it!
Ship It!
- Michael Park
On Feb. 2, 2017, 2:58 p.m
used `AllocatedResources` here?
src/tests/hierarchical_allocator_tests.cpp (line 4180)
<https://reviews.apache.org/r/55967/#comment235106>
`{` on the newline.
- Michael Park
On Jan. 25, 2017, 4:46 p.m., Benjamin Mahler wrote:
>
> ---
>
---
>
> (Updated Jan. 25, 2017, 5:08 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael
> Park.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> With the addition of MULTI_ROLE framework support,
. If you did, this
could be:
```cpp
foreach (Offer::Operation& operation, *accept.mutable_operations()) {
protobuf::adjustOfferOperation(operation, allocationInfo.get());
}
```
- Michael Park
On Jan. 25, 2017, 5:05 p.m., Benja
a32d20e47f67d88bbe5928e0ddc129745c5f42e0
3rdparty/libprocess/src/tests/subprocess_tests.cpp
59c17692012ddfb540ecdd48560c73c42a15f061
Diff: https://reviews.apache.org/r/54602/diff/
Testing
---
Thanks,
Michael Park
9263d8c2763cb30c93fd94be5344f83a6ce3e3b1
Diff: https://reviews.apache.org/r/54603/diff/
Testing
---
Thanks,
Michael Park
ed6fec3ac1c1f9dfb0585178401f4b552822a0a1
3rdparty/stout/include/stout/os/dup.hpp PRE-CREATION
3rdparty/stout/include/stout/os/posix/dup.hpp PRE-CREATION
3rdparty/stout/include/stout/os/windows/dup.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/54595/diff/
Testing
---
Thanks,
Michael Park
ed6fec3ac1c1f9dfb0585178401f4b552822a0a1
3rdparty/stout/include/stout/os/lseek.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/54592/diff/
Testing
---
Thanks,
Michael Park
3rdparty/stout/include/stout/windows/os.hpp
c123772ab018d327b02dacfb314b835b9f373cfc
Diff: https://reviews.apache.org/r/54762/diff/
Testing
---
Thanks,
Michael Park
Diff: https://reviews.apache.org/r/54601/diff/
Testing
---
Thanks,
Michael Park
ed6fec3ac1c1f9dfb0585178401f4b552822a0a1
3rdparty/stout/include/stout/os/int_fd.hpp PRE-CREATION
3rdparty/stout/include/stout/os/windows/fd.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/54591/diff/
Testing
---
Thanks,
Michael Park
y generated e-mail. To reply, visit:
https://reviews.apache.org/r/54601/#review164009
-------
On Feb. 4, 2017, 5:39 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail. To
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54602/#review164008
---
On Feb. 4, 2017, 5:39 p.m., Michael Park wrote:
>
&g
-
3rdparty/stout/include/stout/os/windows/fd.hpp
24d3661aad72817d8b9e3cd88fe6178ab60832bd
Diff: https://reviews.apache.org/r/56354/diff/
Testing
---
Thanks,
Michael Park
` or `HANDLE`, for example.
Diffs
-
3rdparty/stout/include/stout/os/windows/fd.hpp
24d3661aad72817d8b9e3cd88fe6178ab60832bd
Diff: https://reviews.apache.org/r/56354/diff/
Testing (updated)
---
Ran `.\support\windows-build.bat` on a Windows VM.
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56350/#review164603
---
Ship it!
Ship It!
- Michael Park
On Feb. 7, 2017, 2:58 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56351/#review164604
---
Ship it!
Ship It!
- Michael Park
On Feb. 6, 2017, 3:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56349/#review164602
---
Ship it!
Ship It!
- Michael Park
On Feb. 6, 2017, 3:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56247/#review164595
---
Ship it!
Ship It!
- Michael Park
On Feb. 2, 2017, 2:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56423/#review164804
---
Ship it!
Ship It!
- Michael Park
On Feb. 7, 2017, 6:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56424/#review164805
---
Ship it!
Ship It!
- Michael Park
On Feb. 7, 2017, 6:54 p.m
p (lines 4603 - 4604)
<https://reviews.apache.org/r/56422/#comment236594>
Indent 4 spaces.
- Michael Park
On Feb. 7, 2017, 6:53 p.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56421/#review164795
---
Ship it!
Ship It!
- Michael Park
On Feb. 7, 2017, 6:38 p.m
if the # of allocations is the same?
- Michael Park
On Feb. 7, 2017, 7:40 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
)
<https://reviews.apache.org/r/56370/#comment236606>
Not sure why you need the `this->` here?
- Michael Park
On Feb. 6, 2017, 11:29 p.m., Jay Guo wrote:
>
> ---
> This is an automatically generated e-mail. To rep
then let `protobuf::slave::Capabilities` keep track of
`std::set capabilities`.
and just do:
```cpp
writer->field("capabilities", slave.capabilities.capabilities);
```
- Michael Park
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56360/#review164813
---
Ship it!
Ship It!
- Michael Park
On Feb. 6, 2017, 11:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56375/#review164812
---
Ship it!
Ship It!
- Michael Park
On Feb. 6, 2017, 11:34 p.m
901 - 1000 of 1831 matches
Mail list logo
