[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11563 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11563 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. Patch Set 1: Code-Review+1 (3 comments) I would

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11563 to look at the new patch set (#2). Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11563 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11563 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11563 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5031: null ptr errors in C calls in BE tests

2018-10-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11545 ) Change subject: IMPALA-5031: null ptr errors in C calls in BE tests .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11563 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. Patch Set 2: (5 comments) Thanks for the

[Impala-ASF-CR] WIP IMPALA-7626: Throttle partial RPC requests

2018-10-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: WIP IMPALA-7626: Throttle partial RPC requests .. Patch Set 2: (1 comment) It seems like this change limits the

[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests

2018-10-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 ) Change subject: IMPALA-7648 part 1: add expected out-of-memory tests .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests

2018-10-02 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11564 to look at the new patch set (#2). Change subject: IMPALA-7648 part 1: add expected out-of-memory tests

[Impala-ASF-CR] IMPALA-7585: Always set user credentials after creating RPC proxy

2018-10-02 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11477 ) Change subject: IMPALA-7585: Always set user credentials after creating RPC proxy .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11563 Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. IMPALA-7644: Hide Parquet page index writing with

[Impala-ASF-CR] IMPALA-2063 Remove newline characters in query status.

2018-10-02 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11425 ) Change subject: IMPALA-2063 Remove newline characters in query status. .. Patch Set 8: (3 comments)

[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 ) Change subject: IMPALA-7648 part 1: add expected out-of-memory tests .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests

2018-10-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11564 Change subject: IMPALA-7648 part 1: add expected out-of-memory tests .. IMPALA-7648 part 1: add expected out-of-memory tests This adds

[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 ) Change subject: IMPALA-7648 part 1: add expected out-of-memory tests .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 ) Change subject: IMPALA-7648 part 1: add expected out-of-memory tests .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-5031: null ptr errors in C calls in BE tests

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11545 ) Change subject: IMPALA-5031: null ptr errors in C calls in BE tests .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5031: null ptr errors in C calls in BE tests

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11545 ) Change subject: IMPALA-5031: null ptr errors in C calls in BE tests .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7644: Hide Parquet page index writing with feature flag

2018-10-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11563 ) Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5031: null ptr errors in C calls in BE tests

2018-10-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11545 ) Change subject: IMPALA-5031: null ptr errors in C calls in BE tests .. Patch Set 1: Code-Review+2 I think probably only in certain

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 3: > Patch Set 3: > > (1 comment) > > Did

[Impala-ASF-CR] IMPALA-2063 Remove newline characters in query status.

2018-10-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11425 ) Change subject: IMPALA-2063 Remove newline characters in query status. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] WIP IMPALA-7626: Throttle partial RPC requests

2018-10-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: WIP IMPALA-7626: Throttle partial RPC requests .. Patch Set 2: Thanks for the review. Semaphore could probably

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#4). Change subject: IMPALA-6661 Make NaN values equal for grouping purposes.

[Impala-ASF-CR] Use NDV=1 for a Column with all nulls

2018-10-02 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: Use NDV=1 for a Column with all nulls .. Patch Set 10: (3 comments) Thanks for the continued reviews. Cleaned up a few

[Impala-ASF-CR] IMPALA-7543: Enhance scan ranges to support sub-ranges

2018-10-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11520 ) Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges .. Patch Set 3: (1 comment) Thanks Tim! I just don't know

[Impala-ASF-CR] IMPALA-7585: Always set user credentials after creating RPC proxy

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11477 ) Change subject: IMPALA-7585: Always set user credentials after creating RPC proxy .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7585: Always set user credentials after creating RPC proxy

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11477 ) Change subject: IMPALA-7585: Always set user credentials after creating RPC proxy .. Patch Set 3: Build started:

[Impala-ASF-CR] Use NDV=1 for a Column with all nulls

2018-10-02 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11528 to look at the new patch set (#10). Change subject: Use NDV=1 for a Column with all nulls

[Impala-ASF-CR] IMPALA-7310: All-null columns give wrong estimates in planner

2018-10-02 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/11544 ) Change subject: IMPALA-7310: All-null columns give wrong estimates in planner .. Abandoned Duplicate of 11528 -- To view, visit

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#5). Change subject: IMPALA-6661 Make NaN values equal for grouping purposes.

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-2063 Remove newline characters in query status.

2018-10-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11425 ) Change subject: IMPALA-2063 Remove newline characters in query status. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 3: (1 comment) Did you mean to push out PS4?

[Impala-ASF-CR] IMPALA-2063 Remove newline characters in query status.

2018-10-02 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11425 ) Change subject: IMPALA-2063 Remove newline characters in query status. .. Patch Set 8: (1 comment) > Patch Set 5: > > (1 comment)

[Impala-ASF-CR] IMPALA-6249: Expose several build flags via web UI

2018-10-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11410 ) Change subject: IMPALA-6249: Expose several build flags via web UI .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion

2018-10-02 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11567 Change subject: IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion .. IMPALA-6634: [DOCS] Whitespace behavior in

[Impala-ASF-CR] IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11567 ) Change subject: IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-7484: setIsStraightJoin is wrapped in an else clause.

2018-10-02 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11568 Change subject: IMPALA-7484: setIsStraightJoin is wrapped in an else clause. .. IMPALA-7484: setIsStraightJoin is wrapped in an

[Impala-ASF-CR] IMPALA-7484: setIsStraightJoin is wrapped in an else clause.

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 ) Change subject: IMPALA-7484: setIsStraightJoin is wrapped in an else clause. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5031: null ptr errors in C calls in BE tests

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11545 ) Change subject: IMPALA-5031: null ptr errors in C calls in BE tests .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] [WIP] IMPALA-7555: Set socket timeout in impala-shell

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11540 ) Change subject: [WIP] IMPALA-7555: Set socket timeout in impala-shell .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-10-02 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11569 Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile .. IMPALA-7527: add fetch-from-catalogd cache info to

[Impala-ASF-CR] IMPALA-5031: null ptr errors in C calls in BE tests

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11545 ) Change subject: IMPALA-5031: null ptr errors in C calls in BE tests .. IMPALA-5031: null ptr errors in C calls in BE

[Impala-ASF-CR] IMPALA-6249: Expose several build flags via web UI

2018-10-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11410 ) Change subject: IMPALA-6249: Expose several build flags via web UI .. Patch Set 5: (24 comments)

[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests

2018-10-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 ) Change subject: IMPALA-7648 part 1: add expected out-of-memory tests .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Use NDV=1 for a Column with all nulls

2018-10-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: Use NDV=1 for a Column with all nulls .. Patch Set 10: Code-Review+1 (3 comments) Looks great to me; thanks for

[Impala-ASF-CR] Optimize expression to collect NULLs count

2018-10-02 Thread Anonymous Coward (Code Review)
piotr.findei...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11565 Change subject: Optimize expression to collect NULLs count .. Optimize expression to collect NULLs count Simpler

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-02 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 13: (6 comments)

[Impala-ASF-CR] WIP IMPALA-7626: Throttle catalog partial RPC requests

2018-10-02 Thread Bharath Vissapragada (Code Review)
Hello Tianyi Wang, Philip Zeyliger, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11561 to look at the new patch set (#3). Change subject: WIP IMPALA-7626: Throttle catalog partial RPC requests

[Impala-ASF-CR] WIP IMPALA-7626: Throttle catalog partial RPC requests

2018-10-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: WIP IMPALA-7626: Throttle catalog partial RPC requests .. Patch Set 4: Still thinking about tests, but sending

[Impala-ASF-CR] Use NDV=1 for a Column with all nulls

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: Use NDV=1 for a Column with all nulls .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-6249: Expose several build flags via web UI

2018-10-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/11410 ) Change subject: IMPALA-6249: Expose several build flags via web UI .. IMPALA-6249: Expose several build flags via web UI Exposes a list

[Impala-ASF-CR] [WIP] IMPALA-7555: Set socket timeout in impala-shell

2018-10-02 Thread Anuj Phadke (Code Review)
Anuj Phadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11540 ) Change subject: [WIP] IMPALA-7555: Set socket timeout in impala-shell .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-6249: Expose several build flags via web UI

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11410 ) Change subject: IMPALA-6249: Expose several build flags via web UI .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-7585: Always set user credentials after creating RPC proxy

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11477 ) Change subject: IMPALA-7585: Always set user credentials after creating RPC proxy .. Patch Set 3: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7585: Always set user credentials after creating RPC proxy

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11477 ) Change subject: IMPALA-7585: Always set user credentials after creating RPC proxy .. IMPALA-7585: Always set user

[Impala-ASF-CR] IMPALA-6249: Expose several build flags via web UI

2018-10-02 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11410 ) Change subject: IMPALA-6249: Expose several build flags via web UI .. Patch Set 6: (1 comment)

[Impala-ASF-CR] WIP IMPALA-7626: Throttle catalog partial RPC requests

2018-10-02 Thread Bharath Vissapragada (Code Review)
Hello Tianyi Wang, Philip Zeyliger, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11561 to look at the new patch set (#4). Change subject: WIP IMPALA-7626: Throttle catalog partial RPC requests

[Impala-ASF-CR] IMPALA-7647: Add HS2/Impyla dimension to TestQueries

2018-10-02 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11546 ) Change subject: IMPALA-7647: Add HS2/Impyla dimension to TestQueries .. Patch Set 6: (3 comments) A few preliminary comments to start

[Impala-ASF-CR] [WIP] IMPALA-7555: Set socket timeout in impala-shell

2018-10-02 Thread Anuj Phadke (Code Review)
Hello Michael Ho, Thomas Marshall, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11540 to look at the new patch set (#4). Change subject: [WIP] IMPALA-7555: Set socket timeout in impala-shell

[Impala-ASF-CR] Optimize expression to collect NULLs count

2018-10-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: Optimize expression to collect NULLs count .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Optimize expression to collect NULLs count

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: Optimize expression to collect NULLs count .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7484: setIsStraightJoin is wrapped in an else clause.

2018-10-02 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11568 ) Change subject: IMPALA-7484: setIsStraightJoin is wrapped in an else clause. .. IMPALA-7484: setIsStraightJoin is wrapped in an

[Impala-ASF-CR] IMPALA-7484: Unrecognized hints are interpreted as straight join Call to setIsStraightJoin() is outside else clause in SelectList.java causing even unrecognized hints to be interpreted

2018-10-02 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 ) Change subject: IMPALA-7484: Unrecognized hints are interpreted as straight_join Call to setIsStraightJoin() is outside else clause in SelectList.java causing even unrecognized hints to be

[Impala-ASF-CR] IMPALA-7484: Unrecognized hints are interpreted as straight join Call to setIsStraightJoin() is outside else clause in SelectList.java causing even unrecognized hints to be interpreted

2018-10-02 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11568 ) Change subject: IMPALA-7484: Unrecognized hints are interpreted as straight_join Call to setIsStraightJoin() is outside else clause in SelectList.java causing even unrecognized hints to be

[Impala-ASF-CR] IMPALA-7484: Unrecognized hints are interpreted as straight join Call to setIsStraightJoin() is outside else clause in SelectList.java causing even unrecognized hints to be interpreted

2018-10-02 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 ) Change subject: IMPALA-7484: Unrecognized hints are interpreted as straight_join Call to setIsStraightJoin() is outside else clause in SelectList.java causing even unrecognized hints to be interpreted

[Impala-ASF-CR] WIP IMPALA-7626: Throttle catalog partial RPC requests

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: WIP IMPALA-7626: Throttle catalog partial RPC requests .. Patch Set 3: Build Failed

[Impala-ASF-CR] WIP IMPALA-7626: Throttle catalog partial RPC requests

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: WIP IMPALA-7626: Throttle catalog partial RPC requests .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7484: setIsStraightJoin is wrapped in an else clause.

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 ) Change subject: IMPALA-7484: setIsStraightJoin is wrapped in an else clause. .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7647: Add HS2/Impyla dimension to TestQueries

2018-10-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11546 ) Change subject: IMPALA-7647: Add HS2/Impyla dimension to TestQueries .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-7647: Add HS2/Impyla dimension to TestQueries

2018-10-02 Thread Tim Armstrong (Code Review)
Hello Michael Brown, Nithya Janarthanan, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11546 to look at the new patch set (#7). Change subject: IMPALA-7647: Add HS2/Impyla dimension to TestQueries

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-10-02 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11569 ) Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 1: (1 comment) The change is to put these

[Impala-ASF-CR] WIP IMPALA-7626: Throttle catalog partial RPC requests

2018-10-02 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: WIP IMPALA-7626: Throttle catalog partial RPC requests .. Patch Set 4: (7 comments) for testing, depending on that

[Impala-ASF-CR] IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion

2018-10-02 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11567 ) Change subject: IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion .. IMPALA-6634: [DOCS] Whitespace

[Impala-ASF-CR] IMPALA-7647: Add HS2/Impyla dimension to TestQueries

2018-10-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11546 ) Change subject: IMPALA-7647: Add HS2/Impyla dimension to TestQueries .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11569 ) Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7484: setIsStraightJoin is wrapped in an else clause.

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 ) Change subject: IMPALA-7484: setIsStraightJoin is wrapped in an else clause. .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-6249: Expose several build flags via web UI

2018-10-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11410 ) Change subject: IMPALA-6249: Expose several build flags via web UI .. Patch Set 6: (1 comment)

[Impala-ASF-CR] [WIP] IMPALA-7555: Set socket timeout in impala-shell

2018-10-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11540 ) Change subject: [WIP] IMPALA-7555: Set socket timeout in impala-shell .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#6). Change subject: IMPALA-6661 Make NaN values equal for grouping purposes.

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-2063 Remove newline characters in query status.

2018-10-02 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11425 to look at the new patch set (#9). Change subject: IMPALA-2063 Remove newline characters in query status.

[Impala-ASF-CR] IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11567 ) Change subject: IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion .. Patch Set 1: Verified+1 Build

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 5: Code-Review+1 (1 comment) Did anyone else

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 5: (2 comments) I plan to take a look.

[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests

2018-10-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 ) Change subject: IMPALA-7648 part 1: add expected out-of-memory tests .. Patch Set 2: Code-Review+1 (4 comments)

[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests

2018-10-02 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11564 to look at the new patch set (#3). Change subject: IMPALA-7648 part 1: add expected out-of-memory tests

[Impala-ASF-CR] IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion

2018-10-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11567 ) Change subject: IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-10-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11569 ) Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 1: (1 comment) Can you highlight the

[Impala-ASF-CR] IMPALA-6249: Expose several build flags via web UI

2018-10-02 Thread Sahil Takiar (Code Review)
Hello Thomas Marshall, Lars Volker, Michael Brown, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11410 to look at the new patch set (#8). Change subject: IMPALA-6249: Expose several build flags via web UI

[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests

2018-10-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 ) Change subject: IMPALA-7648 part 1: add expected out-of-memory tests .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-7581: timeout backend tests after 2 hours

2018-10-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11533 ) Change subject: IMPALA-7581: timeout backend tests after 2 hours .. Patch Set 1: Ping -- To view, visit

[Impala-ASF-CR] IMPALA-7484: setIsStraightJoin is wrapped in an else clause.

2018-10-02 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 ) Change subject: IMPALA-7484: setIsStraightJoin is wrapped in an else clause. .. Patch Set 2: (5 comments)

[Impala-ASF-CR] Revert "IMPALA-7527: add fetch-from-catalogd cache info to profile"

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11560 ) Change subject: Revert "IMPALA-7527: add fetch-from-catalogd cache info to profile" .. Revert "IMPALA-7527: add

[Impala-ASF-CR] Revert "IMPALA-7527: add fetch-from-catalogd cache info to profile"

2018-10-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11560 ) Change subject: Revert "IMPALA-7527: add fetch-from-catalogd cache info to profile" .. Patch Set 5: Verified+1 -- To view,

  1   2   >