[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 5: (8 comments) Reworked the git commit message, and fixed all the issues.

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-12 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#6). Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh We used to incl

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/4348/6/testdata/bin/che

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-13 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#7). Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh We used to incl

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-13 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#8). Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh We used to incl

[Impala-ASF-CR] IMPALA-3491: Use unique db in test scanners.py and test aggregation.py

2016-09-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-3491: Use unique db in test_scanners.py and test_aggregation.py .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4339 To un

[Impala-ASF-CR] IMPALA-4122: qgen: fix bitrotted cluster unit tests

2016-09-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4122: qgen: fix bitrotted cluster unit tests .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4404/4/tests/comparison/tests/te

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4348/8/testdata/bin/chec

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-14 Thread David Knupp (Code Review)
Hello Michael Brown, Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4348 to look at the new patch set (#9). Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 9: Harrison very astutely pointed out in an out-of-band message that I had

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 9: Harrison and I looked at that too, but the hdfs lib binds to the WebHDFS/

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5877/7/tests/conftest.py File tests

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-08 Thread David Knupp (Code Review)
Hello Michael Brown, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5877 to look at the new patch set (#8). Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 8: Pre-review build: http://jenkins.impala.io:8080/view/Utility/job/pre-review-test/18

[Impala-ASF-CR] IMPALA-4920: custom cluster tests: remove unnecessary escaped quote chars

2017-02-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4920: custom cluster tests: remove unnecessary escaped quote chars .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5978 To

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5995/1//COMMIT_MSG Commit Message: PS1, Line 7: A blog post about

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md Fil

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md File

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md File

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests

2017-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6002/1/bin/ru

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 3: (1 comment) So, I believe that all of the pages still point to the old blog site. This patch doesn't seem to addres

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md File

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: A blog post about IMPALA-4916 .. Patch Set 3: Code-Review+1 Agreed. -- To view, visit http://gerrit.cloudera.org:8080/5995 To unsubscribe, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests

2017-02-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] Three misc webpage changes

2017-02-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Three misc webpage changes .. Patch Set 1: The changes here seem reasonable. Is there a plan to migrate other HTML tables to DataTables? (E.g., Queries, Query Loc

[Impala-ASF-CR] Add .pep8rc for Impala's Python style

2017-02-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Add .pep8rc for Impala's Python style .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5829/1/.pep8rc File .pep8rc: PS1, Line 2: # E101 - Reinden

[Impala-ASF-CR] IMPALA-4987: Skip test rows availability when testing over a network.

2017-02-24 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/6144 Change subject: IMPALA-4987: Skip test_rows_availability when testing over a network. .. IMPALA-4987: Skip test_rows_availability when tes

[Impala-ASF-CR] Fix parameter order in test mt dop.py

2017-03-02 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Fix parameter order in test_mt_dop.py .. Patch Set 1: With pytest fixtures, I don't think order matters. -- To view, visit http://gerrit.cloudera.org:8080/6228 T

[Impala-ASF-CR] Fix parameter order in test mt dop.py

2017-03-02 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Fix parameter order in test_mt_dop.py .. Patch Set 1: Sure, for the sake of consistency, I'm OK with this change. There are actually two places where this occurs.

[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations

2017-03-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: Code-Review+1 I agree -- I don't see any downsides to scoping the connection fixture at test leve

[Impala-ASF-CR] IMPALA-5181: Extract PYPI metadata from a webpage

2017-04-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5181: Extract PYPI metadata from a webpage .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6579/1/infra/python/deps/pip_download.py File in

[Impala-ASF-CR] IMPALA-5181: Extract PYPI metadata from a webpage

2017-04-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5181: Extract PYPI metadata from a webpage .. Patch Set 1: I have to confess, I've long felt like there's lot of over engineering in the way that we set up

[Impala-ASF-CR] IMPALA-5181: Extract PYPI metadata from a webpage

2017-04-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5181: Extract PYPI metadata from a webpage .. Patch Set 1: There may well be some historical context that I'm missing here, or just some complication that I

[Impala-ASF-CR] IMPALA-5181: Extract PYPI metadata from a webpage

2017-04-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5181: Extract PYPI metadata from a webpage .. Patch Set 1: Again, just wanted to reiterate that I think if this is the quickest path to unlocking the repo

[Impala-ASF-CR] IMPALA-5181: Extract PYPI metadata from a webpage

2017-04-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5181: Extract PYPI metadata from a webpage .. Patch Set 1: I'm totally in agreement. -- To view, visit http://gerrit.cloudera.org:8080/6579 To unsubscribe

[Impala-ASF-CR] IMPALA-5189: Pin version of setuptools scm

2017-04-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5189: Pin version of setuptools_scm .. Patch Set 1: > Do we still want to pin this dependency, or should we abandon this change? My opinion is that pinning

[Impala-ASF-CR] IMPALA-5189: Pin version of setuptools scm

2017-04-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5189: Pin version of setuptools_scm .. Patch Set 1: > unless we feel we should pin the package to 1.15.0 anyways We could pin to 1.15.4 as our known workin

[Impala-ASF-CR] IMPALA-5189: Pin version of setuptools-scm

2017-04-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5189: Pin version of setuptools-scm .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6599 To unsubscribe, visit http://gerri

[Impala-ASF-CR] IMPALA-5287: Test skip.header.line.count on gzip

2017-05-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6817/1/tests/query_test/test_scanners.py File tes

[Impala-ASF-CR] Add a script to test performance on a developer machine

2017-05-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Add a script to test performance on a developer machine .. Patch Set 2: (1 comment) Jim, this is mainly just to confirm that this review request has been noted.

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-18 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6910/2/tests/common/impala_test_suite.py Fi

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-18 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/6910/2/tests/util/adls_util.py File tests/u

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-18 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6910/2/tests/util/adls_util.py File tests/ut

[Impala-ASF-CR] IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"

2017-05-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6894/6/tests/data_errors/test_dat

[Impala-ASF-CR] IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"

2017-05-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" .. Patch Set 7: Code-Review+1 Python test code looks OK to me. -- To view, visit http://gerrit.c

[Impala-ASF-CR] Add a script to test performance on a developer machine

2017-05-23 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Add a script to test performance on a developer machine .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6818/4/bin/single_node_perf_run.py File b

[Impala-ASF-CR] IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04

2017-05-24 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04 .. Patch Set 1: So, I'm a little concerned about this. The datetime being installed here isn't the st

[Impala-ASF-CR] IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04

2017-05-24 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04 .. Patch Set 1: s/for that file/for that module/ -- To view, visit http://gerrit.cloudera.org:8080/6

[Impala-ASF-CR] IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04

2017-05-24 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5366: datetime missing when upgrading to Ubuntu 16.04 .. Patch Set 1: Code-Review-1 -- To view, visit http://gerrit.cloudera.org:8080/6989 To unsubscribe,

[Impala-ASF-CR] Add a script to test performance on a developer machine

2017-05-30 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Add a script to test performance on a developer machine .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6818 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5413: Skip test seq writer hive compatibility on remote clusters.

2017-06-01 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/7046 Change subject: IMPALA-5413: Skip test_seq_writer_hive_compatibility on remote clusters. .. IMPALA-5413: Skip test_seq_writer_hive_compati

[Impala-ASF-CR] IMPALA-4482, IMPALA-4838: RECOVER PARTITIONS with tpcds.store sales

2017-06-05 Thread David Knupp (Code Review)
David Knupp has abandoned this change. Change subject: IMPALA-4482, IMPALA-4838: RECOVER PARTITIONS with tpcds.store_sales .. Abandoned Abandoning. Part of this change is not relevant anymore. I'll open a new review for the p

[Impala-ASF-CR] IMPALA-5413: Skip test seq writer hive compatibility on remote clusters.

2017-06-06 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5413: Skip test_seq_writer_hive_compatibility on remote clusters. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7046/1/tests/query_test

[Impala-ASF-CR] IMPALA-5455: test infra: propagate --cm-port, add --use-tls

2017-06-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5455: test infra: propagate --cm-port, add --use-tls .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7107 To unsubscribe, v

[Impala-ASF-CR] IMPALA-5413: Skip test seq writer hive compatibility on remote clusters.

2017-06-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5413: Skip test_seq_writer_hive_compatibility on remote clusters. .. Patch Set 1: It might be a bug in Hive or beeline? Beeline is throwing a WRITE access

[Impala-ASF-CR] IMPALA-5413: Add a hive user for test seq writer hive compatibility.

2017-06-09 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#2). Change subject: IMPALA-5413: Add a hive user for test_seq_writer_hive_compatibility. .. IMPALA-5413: Add a hive user for test_seq_writer_hive_compatibility. This patch includes a c

[Impala-ASF-CR] IMPALA-5413: Add a hive user for test seq writer hive compatibility.

2017-06-09 Thread David Knupp (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7046 to look at the new patch set (#3). Change subject: IMPALA-5413: Add a hive user for test_seq_writer_hive_compatibility. ..

[Impala-ASF-CR] IMPALA-5413: Add a hive user for test seq writer hive compatibility.

2017-06-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5413: Add a hive user for test_seq_writer_hive_compatibility. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7046/2/tests/query_test/test

[Impala-ASF-CR] IMPALA-5413: Add a hive user for test seq writer hive compatibility.

2017-06-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5413: Add a hive user for test_seq_writer_hive_compatibility. .. Patch Set 3: Code-Review+2 Removed one blank # comment. Carrying +2 from Alex. -- To vie

[Impala-ASF-CR] IMPALA-5263: test infra: support CA bundles with secure clusters

2017-06-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5263: test infra: support CA bundles with secure clusters .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7152/2/tests/compar

[Impala-ASF-CR] IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop

2017-06-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7159 To unsubscri

[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds

2017-06-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7115 To uns

[Impala-ASF-CR] IMPALA-5517: Allow default IMPALA LOGS DIR to be explicity overridden

2017-06-15 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/7197 Change subject: IMPALA-5517: Allow default IMPALA_LOGS_DIR to be explicity overridden .. IMPALA-5517: Allow default IMPALA_LOGS_DIR to be

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 1: Code-Review+1 It looks like this job: http://sandbox.jenkins.cloude

[Impala-ASF-CR] IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment

2016-10-10 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4674/2/bin/bootstrap_development.sh

[Impala-ASF-CR] IMPALA-4259: build Impala without any test cluster setup.

2016-10-11 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4259: build Impala without any test cluster setup. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4685/1/buildall.sh File buildall.sh: P

[Impala-ASF-CR] IMPALA-4259: build Impala without any test cluster setup.

2016-10-11 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4259: build Impala without any test cluster setup. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4685/1/buildall.sh File buildall.sh: P

[Impala-ASF-CR] IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment

2016-10-11 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4674/3/bin/bootstrap_d

[Impala-ASF-CR] IMPALA-4259: build Impala without any test cluster setup.

2016-10-11 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4259: build Impala without any test cluster setup. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4685/1/buildall.sh File buildall.sh: PS

[Impala-ASF-CR] IMPALA-4259: build Impala without any test cluster setup.

2016-10-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4259: build Impala without any test cluster setup. .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4685 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4678/4/tests/comparison/leopard/impala_dock

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/4678/5//COMMIT_MSG Commit Message: PS5, Li

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4678 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-4294: Execute data load steps from within git repo.

2016-10-14 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/4726 Change subject: IMPALA-4294: Execute data load steps from within git repo. .. IMPALA-4294: Execute data load steps from within git repo. F

[Impala-ASF-CR] IMPALA-4294: Execute data load steps from within git repo.

2016-10-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4294: Execute data load steps from within git repo. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4726/2/buildall.sh File buildall.sh: P

[Impala-ASF-CR] IMPALA-4294: Execute data load steps from within git repo.

2016-10-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4294: Execute data load steps from within git repo. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4726/2/buildall.sh File buildall.sh: P

[Impala-ASF-CR] IMPALA-4294: Make check-schema-diff.sh executable from anywhere.

2016-10-14 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#3). Change subject: IMPALA-4294: Make check-schema-diff.sh executable from anywhere. .. IMPALA-4294: Make check-schema-diff.sh executable from anywhere. Fixes a regression in the data l

[Impala-ASF-CR] IMPALA-4294: Make check-schema-diff.sh executable from anywhere.

2016-10-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4294: Make check-schema-diff.sh executable from anywhere. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4726/2/buildall.sh File buildall.

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-21 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#2). Change subject: Enabling end-to-end tests on a remote cluster .. Enabling end-to-end tests on a remote cluster This patch enables data loading and running end-to-end tests on a remo

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-21 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/4769 Change subject: Enabling end-to-end tests on a remote cluster .. Enabling end-to-end tests on a remote cluster This patch enables data loa

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Enabling end-to-end tests on a remote cluster .. Patch Set 2: (11 comments) Harrison, I'm addressing the comments on all the files other than remote_data_load.py

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-21 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#3). Change subject: Enabling end-to-end tests on a remote cluster .. Enabling end-to-end tests on a remote cluster This patch enables data loading and running end-to-end tests on a remo

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-24 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#4). Change subject: Enabling end-to-end tests on a remote cluster .. Enabling end-to-end tests on a remote cluster This patch enables data loading and running end-to-end tests on a remo

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-24 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#4). Change subject: Enabling end-to-end tests on a remote cluster .. Enabling end-to-end tests on a remote cluster This patch enables data loading and running end-to-end tests on a remo

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-25 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Enabling end-to-end tests on a remote cluster .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4769/1/bin/remote_data_load.py File bin/remote_data

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-26 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Enabling end-to-end tests on a remote cluster .. Patch Set 1: (16 comments) http://gerrit.cloudera.org:8080/#/c/4769/1/bin/remote_data_load.py File bin/remote_dat

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-26 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#5). Change subject: Enabling end-to-end tests on a remote cluster .. Enabling end-to-end tests on a remote cluster This patch enables data loading and running end-to-end tests on a remo

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-26 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Enabling end-to-end tests on a remote cluster .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4769/1/bin/remote_data_load.py File bin/remote_data_

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-26 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#6). Change subject: Enabling end-to-end tests on a remote cluster .. Enabling end-to-end tests on a remote cluster This patch enables data loading and running end-to-end tests on a remo

[Impala-ASF-CR] IMPALA-4365: Enabling end-to-end tests on a remote cluster

2016-10-30 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#7). Change subject: IMPALA-4365: Enabling end-to-end tests on a remote cluster .. IMPALA-4365: Enabling end-to-end tests on a remote cluster This patch lays the groundwork for loading d

[Impala-ASF-CR] IMPALA-4365: Enabling end-to-end tests on a remote cluster

2016-10-31 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#7). Change subject: IMPALA-4365: Enabling end-to-end tests on a remote cluster .. IMPALA-4365: Enabling end-to-end tests on a remote cluster This patch lays the groundwork for loading d

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-10-31 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4873/1/tests/comparison/

[Impala-ASF-CR] IMPALA-4229: Download auxiliary test data if Impala-auxiliary-tests is available.

2016-11-01 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/4900 Change subject: IMPALA-4229: Download auxiliary test data if Impala-auxiliary-tests is available. .. IMPALA-4229: Download auxiliary test

[Impala-ASF-CR] IMPALA-4229: Download auxiliary test data if Impala-auxiliary-tests is available.

2016-11-01 Thread David Knupp (Code Review)
David Knupp has abandoned this change. Change subject: IMPALA-4229: Download auxiliary test data if Impala-auxiliary-tests is available. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4900 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-4229: Download aux test data if Impala-aux repo is available.

2016-11-01 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/4901 Change subject: IMPALA-4229: Download aux test data if Impala-aux repo is available. .. IMPALA-4229: Download aux test data if Impala-aux

[Impala-ASF-CR] IMPALA-4229: Download aux test data if Impala-aux repo is available.

2016-11-01 Thread David Knupp (Code Review)
David Knupp has abandoned this change. Change subject: IMPALA-4229: Download aux test data if Impala-aux repo is available. .. Abandoned After a further discussion with Jim, it was decided that we need fewer (read: zero) refe

[Impala-ASF-CR] IMPALA-4365: Enabling end-to-end tests on a remote cluster

2016-11-01 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#8). Change subject: IMPALA-4365: Enabling end-to-end tests on a remote cluster .. IMPALA-4365: Enabling end-to-end tests on a remote cluster This patch lays the groundwork for loading d

[Impala-ASF-CR] IMPALA-4365: Enabling end-to-end tests on a remote cluster

2016-11-01 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4365: Enabling end-to-end tests on a remote cluster .. Patch Set 7: (18 comments) http://gerrit.cloudera.org:8080/#/c/4769/7/bin/remote_data_load.py File b

[Impala-ASF-CR] IMPALA-4365: Enabling end-to-end tests on a remote cluster

2016-11-01 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#9). Change subject: IMPALA-4365: Enabling end-to-end tests on a remote cluster .. IMPALA-4365: Enabling end-to-end tests on a remote cluster This patch lays the groundwork for loading d

[Impala-ASF-CR] IMPALA-4365: Enabling end-to-end tests on a remote cluster

2016-11-01 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4365: Enabling end-to-end tests on a remote cluster .. Patch Set 9: Ignore remote_load_data.py in patch set 8. I accidentally pushed an interim in-progress

  1   2   3   >