[kudu-CR] WIP [master] no half-baked responses on ConnectoToMaster

2018-01-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9052 to look at the new patch set (#2). Change subject: WIP [master] no half-baked responses on ConnectoToMaster

[kudu-CR] Enable vptr UBSAN checker

2018-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9051 ) Change subject: Enable vptr UBSAN checker .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9051 To

[kudu-CR] Add unsigned-integer overflow checking to UBSAN

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/6637 ) Change subject: Add unsigned-integer overflow checking to UBSAN .. Patch Set 3: (1 comment)

[kudu-CR](branch-1.5.x) rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9056 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 1: This had to be done manually due to a

[kudu-CR] Add unsigned-integer overflow checking to UBSAN

2018-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/6637 ) Change subject: Add unsigned-integer overflow checking to UBSAN .. Patch Set 3: (1 comment)

[kudu-CR](branch-1.6.x) rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9055 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR](branch-1.6.x) rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9055 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 1: This had to be done manually due to a

[kudu-CR] Add unsigned-integer overflow checking to UBSAN

2018-01-18 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6637 to look at the new patch set (#4). Change subject: Add unsigned-integer overflow checking to UBSAN

[kudu-CR] Add unsigned-integer overflow checking to UBSAN

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/6637 ) Change subject: Add unsigned-integer overflow checking to UBSAN .. Patch Set 4: (1 comment)

[kudu-CR] fs: defer failure from metadata load to bootstrap when data dir is missing

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8376 ) Change subject: fs: defer failure from metadata load to bootstrap when data dir is missing .. Patch Set 8: (5 comments)

[kudu-CR](branch-1.5.x) rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9056 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 1: (1 comment)

[kudu-CR] Enable vptr UBSAN checker

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9051 ) Change subject: Enable vptr UBSAN checker .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9051 To

[kudu-CR](branch-1.5.x) rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-18 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Jean-Daniel Cryans, Kudu Jenkins, Sailesh Mukil, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9056 to review the following change. Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions

[kudu-CR](branch-1.6.x) rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-18 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Jean-Daniel Cryans, Kudu Jenkins, Sailesh Mukil, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9055 to review the following change. Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions

[kudu-CR] WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration

2018-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9050 ) Change subject: WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration .. Patch Set 1: (7 comments)

[kudu-CR](branch-1.5.x) rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/9056 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.5.x) rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9056 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2202: support for removing data directories (take two)

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8978 ) Change subject: KUDU-2202: support for removing data directories (take two) .. Patch Set 7: (4 comments)

[kudu-CR] Fix typo in TLS support status message

2018-01-18 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9061 to review the following change. Change subject: Fix typo in TLS support status message .. Fix typo in TLS support

[kudu-CR](branch-1.5.x) rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-18 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Jean-Daniel Cryans, Kudu Jenkins, Sailesh Mukil, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9056 to look at the new patch set (#2). Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions

[kudu-CR](branch-1.6.x) rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-18 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Jean-Daniel Cryans, Kudu Jenkins, Sailesh Mukil, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9055 to look at the new patch set (#2). Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions

[kudu-CR] Add unsigned-integer overflow checking to UBSAN

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/6637 ) Change subject: Add unsigned-integer overflow checking to UBSAN .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9050 ) Change subject: WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration .. Patch Set 1:

[kudu-CR] WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration

2018-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9050 ) Change subject: WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration .. Patch Set 1: Would there

[kudu-CR] Add unsigned-integer overflow checking to UBSAN

2018-01-18 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6637 to look at the new patch set (#5). Change subject: Add unsigned-integer overflow checking to UBSAN

[kudu-CR] Add unsigned-integer overflow checking to UBSAN

2018-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/6637 ) Change subject: Add unsigned-integer overflow checking to UBSAN .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9027 ) Change subject: KUDU-1489: allow configuration of metadata dir .. Patch Set 12: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.6.x) rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/9055 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.5.x) rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/9056 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Fix typo in TLS support status message

2018-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9061 ) Change subject: Fix typo in TLS support status message .. Fix typo in TLS support status message Introduced in recently in

[kudu-CR] WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9050 ) Change subject: WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration .. Patch Set 1: Thanks for

[kudu-CR] Fix typo in TLS support status message

2018-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9061 ) Change subject: Fix typo in TLS support status message .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9050 ) Change subject: WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration .. Patch Set 1: I'm not

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9027 ) Change subject: KUDU-1489: allow configuration of metadata dir .. KUDU-1489: allow configuration of metadata dir Metadata files

[kudu-CR] Add unsigned-integer overflow checking to UBSAN

2018-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/6637 ) Change subject: Add unsigned-integer overflow checking to UBSAN .. Add unsigned-integer overflow checking to UBSAN Background:

[kudu-CR] WIP [master] no half-baked responses on ConnectoToMaster

2018-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9052 ) Change subject: WIP [master] no half-baked responses on ConnectoToMaster .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] WIP [master] no half-baked responses on ConnectoToMaster

2018-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 ) Change subject: WIP [master] no half-baked responses on ConnectoToMaster .. Patch Set 2: Verified+1 Unrelated flaek in

[kudu-CR] fs: defer failure from metadata load to bootstrap when data dir is missing

2018-01-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8376 ) Change subject: fs: defer failure from metadata load to bootstrap when data dir is missing .. Patch Set 8: (5 comments)

[kudu-CR] [docs] Added a section for Kudu clients connecting to secure clusters

2018-01-18 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/8953 ) Change subject: [docs] Added a section for Kudu clients connecting to secure clusters .. Patch Set 8: -Code-Review This is ready for

[kudu-CR] [docs] Added steps to update HMS after migrating to multiple Kudu masters

2018-01-18 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/8948 ) Change subject: [docs] Added steps to update HMS after migrating to multiple Kudu masters .. Patch Set 15: -Code-Review This is ready

[kudu-CR] [docs] Added steps to update HMS after migrating to multiple Kudu masters

2018-01-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has removed a vote on this change. Change subject: [docs] Added steps to update HMS after migrating to multiple Kudu masters .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] [docs] Added steps to update HMS after migrating to multiple Kudu masters

2018-01-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8948 ) Change subject: [docs] Added steps to update HMS after migrating to multiple Kudu masters .. [docs] Added steps to update

[kudu-CR] [docs] Added a section for Kudu clients connecting to secure clusters

2018-01-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8953 ) Change subject: [docs] Added a section for Kudu clients connecting to secure clusters .. Patch Set 8: Code-Review+2 -- To view,

[kudu-CR] [docs] Added a section for Kudu clients connecting to secure clusters

2018-01-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8953 ) Change subject: [docs] Added a section for Kudu clients connecting to secure clusters .. [docs] Added a section for Kudu

[kudu-CR] [docs] Added steps to update HMS after migrating to multiple Kudu masters

2018-01-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8948 ) Change subject: [docs] Added steps to update HMS after migrating to multiple Kudu masters .. Patch Set 15: Verified+1

[kudu-CR] [docs] Removed the note about KUDU-1626

2018-01-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/9020 ) Change subject: [docs] Removed the note about KUDU-1626 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [docs] Removed the note about KUDU-1626

2018-01-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9020 ) Change subject: [docs] Removed the note about KUDU-1626 .. [docs] Removed the note about KUDU-1626 Change-Id:

[kudu-CR] docs: update docs for metadata dir

2018-01-18 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9068 Change subject: docs: update docs for metadata dir .. docs: update docs for metadata dir Commit 64926335fe263b43f1493c03a91ea999759dfc71

[kudu-CR] Kudu-2126: Add conditional check to prevent unnecessary fsyncs

2018-01-18 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9069 Change subject: Kudu-2126: Add conditional check to prevent unnecessary fsyncs .. Kudu-2126: Add conditional check to prevent

[kudu-CR] WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9050 ) Change subject: WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration .. Patch Set 1: (8 comments)

[kudu-CR] docs: update docs for metadata dir

2018-01-18 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9068 ) Change subject: docs: update docs for metadata dir .. Patch Set 1: (2 comments)

[kudu-CR] java: improve error messages when tokens are not used

2018-01-18 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Anonymous Coward #314, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9070 to review the following change. Change subject: java: improve error messages when tokens are not used

[kudu-CR](branch-1.5.x) rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9056 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. rpc: allow setting --rpc_tls_min_protocol on

[kudu-CR] WIP [master] no half-baked responses on ConnectoToMaster

2018-01-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 ) Change subject: WIP [master] no half-baked responses on ConnectoToMaster .. Patch Set 2: (2 comments)

[kudu-CR] Enable vptr UBSAN checker

2018-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9051 ) Change subject: Enable vptr UBSAN checker .. Patch Set 2: Carrying over the +2 from Todd and Alexey. -- To view, visit

[kudu-CR] Enable vptr UBSAN checker

2018-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9051 ) Change subject: Enable vptr UBSAN checker .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9051 To

[kudu-CR] Enable vptr UBSAN checker

2018-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9051 ) Change subject: Enable vptr UBSAN checker .. Enable vptr UBSAN checker The issue with boost intrusive list no longer appears to

[kudu-CR] De-flake heavy-update-compaction-itest

2018-01-18 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9067 to look at the new patch set (#2). Change subject: De-flake heavy-update-compaction-itest .. De-flake

[kudu-CR] De-flake heacy-update-compaction-itest

2018-01-18 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9067 to review the following change. Change subject: De-flake heacy-update-compaction-itest .. De-flake

[kudu-CR] KUDU-2202: support for removing data directories (take two)

2018-01-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8978 ) Change subject: KUDU-2202: support for removing data directories (take two) .. Patch Set 7: (1 comment) With the metadata dir patch in,

[kudu-CR] De-flake heavy-update-compaction-itest

2018-01-18 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9067 to look at the new patch set (#3). Change subject: De-flake heavy-update-compaction-itest .. De-flake

[kudu-CR] [docs] Removed the note about KUDU-1626

2018-01-18 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9020 ) Change subject: [docs] Removed the note about KUDU-1626 .. Patch Set 1: -Code-Review This is ready for review. -- To view, visit

[kudu-CR] java: improve error messages when tokens are not used

2018-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9070 ) Change subject: java: improve error messages when tokens are not used .. Patch Set 1: (2 comments)

[kudu-CR] java: improve error messages when tokens are not used

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9070 ) Change subject: java: improve error messages when tokens are not used .. Patch Set 1: (1 comment)

[kudu-CR] De-flake heavy-update-compaction-itest

2018-01-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9067 ) Change subject: De-flake heavy-update-compaction-itest .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration

2018-01-18 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Anonymous Coward #314, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9050 to look at the new patch set (#2). Change subject: WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos

[kudu-CR] KUDU-2254: Detect and warn about misusage of KuduContext

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. ( http://gerrit.cloudera.org:8080/9004 ) Change subject: KUDU-2254: Detect and warn about misusage of KuduContext .. Abandoned Per above discussion, this no longer seems relevant -- To

[kudu-CR] KUDU-2261: The order of the responses after flush should match the order we call apply

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9029 ) Change subject: KUDU-2261: The order of the responses after flush should match the order we call apply .. Patch Set 2: Code-Review+2

[kudu-CR] KUDU-2261: The order of the responses after flush should match the order we call apply

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9029 ) Change subject: KUDU-2261: The order of the responses after flush should match the order we call apply .. KUDU-2261: The order

[kudu-CR] KUDU-2238. DMS not flush under memory pressure.

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8904 ) Change subject: KUDU-2238. DMS not flush under memory pressure. .. KUDU-2238. DMS not flush under memory pressure. When we

[kudu-CR] [java] add test to reproduce KUDU-2267

2018-01-18 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9071 Change subject: [java] add test to reproduce KUDU-2267 .. [java] add test to reproduce KUDU-2267 Currently, if a master has never been a

[kudu-CR] WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed Anonymous Coward #314 from this change. ( http://gerrit.cloudera.org:8080/9050 ) Change subject: WIP: KUDU-2264. Automatically attempt to re-acquire Kerberos credentials before expiration .. Removed

[kudu-CR] Kudu-2126: Add conditional check to prevent unnecessary fsyncs

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9069 ) Change subject: Kudu-2126: Add conditional check to prevent unnecessary fsyncs .. Patch Set 1: (6 comments)

[kudu-CR] java: improve error messages when tokens are not used

2018-01-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9070 ) Change subject: java: improve error messages when tokens are not used .. Patch Set 1: (2 comments)

[kudu-CR] java: improve error messages when tokens are not used

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9070 ) Change subject: java: improve error messages when tokens are not used .. Patch Set 1: (1 comment)

[kudu-CR] java: improve error messages when tokens are not used

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9070 ) Change subject: java: improve error messages when tokens are not used .. Patch Set 1: (1 comment)

[kudu-CR] docs: update docs for metadata dir

2018-01-18 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: docs: update docs for metadata dir .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9068 To unsubscribe, visit

[kudu-CR] docs: update docs for metadata dir

2018-01-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9068 ) Change subject: docs: update docs for metadata dir .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9068 To

[kudu-CR] java: improve error messages when tokens are not used

2018-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9070 ) Change subject: java: improve error messages when tokens are not used .. Patch Set 1: (2 comments)

[kudu-CR] java: improve error messages when tokens are not used

2018-01-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9070 ) Change subject: java: improve error messages when tokens are not used .. Patch Set 1: (1 comment)

[kudu-CR] docs: update docs for metadata dir

2018-01-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9068 ) Change subject: docs: update docs for metadata dir .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/9068

[kudu-CR] docs: update docs for metadata dir

2018-01-18 Thread Andrew Wong (Code Review)
Hello Alex Rodoni, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9068 to look at the new patch set (#2). Change subject: docs: update docs for metadata dir ..

[kudu-CR] docs: update docs for metadata dir

2018-01-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9068 ) Change subject: docs: update docs for metadata dir .. Patch Set 2: (2 comments)

[kudu-CR] java: improve error messages when tokens are not used

2018-01-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed Anonymous Coward #314 from this change. ( http://gerrit.cloudera.org:8080/9070 ) Change subject: java: improve error messages when tokens are not used .. Removed reviewer null. -- To view, visit

[kudu-CR] java: improve error messages when tokens are not used

2018-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9070 ) Change subject: java: improve error messages when tokens are not used .. Patch Set 1: (1 comment)

[kudu-CR] Kudu-2126: Add conditional check to prevent unnecessary fsyncs

2018-01-18 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has posted comments on this change. ( http://gerrit.cloudera.org:8080/9069 ) Change subject: Kudu-2126: Add conditional check to prevent unnecessary fsyncs .. Patch Set 1: (5 comments)

[kudu-CR] docs: update docs for metadata dir

2018-01-18 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9068 ) Change subject: docs: update docs for metadata dir .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/9068

[kudu-CR] KUDU-2126: Add conditional check to prevent unnecessary fsyncs

2018-01-18 Thread Jeffrey F. Lukman (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9069 to look at the new patch set (#2). Change subject: KUDU-2126: Add conditional check to prevent unnecessary fsyncs

[kudu-CR] Kudu-2126: Add conditional check to prevent unnecessary fsyncs

2018-01-18 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has posted comments on this change. ( http://gerrit.cloudera.org:8080/9069 ) Change subject: Kudu-2126: Add conditional check to prevent unnecessary fsyncs .. Patch Set 1: (1 comment)