[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-2291 (part 3): use futex to speed up stack collection

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9254 ) Change subject: KUDU-2291 (part 3): use futex to speed up stack collection .. Patch Set 5: (2 comments)

[kudu-CR] KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9262 ) Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection .. Patch Set 5: Code-Review+2 (1 comment)

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 ) Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode .. Patch Set 17: (1 comment)

[kudu-CR] Simplify OpId/Timestamp assignment and make it atomic

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7221 ) Change subject: Simplify OpId/Timestamp assignment and make it atomic .. Patch Set 17: (10 comments)

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9343 to look at the new patch set (#7). Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level

[kudu-CR] KUDU-721: Support range partitions on decimal columns

2018-02-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9363 ) Change subject: KUDU-721: Support range partitions on decimal columns .. Patch Set 1: (4 comments)

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

2018-02-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 ) Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode .. Patch Set 16: (10 comments)

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

2018-02-20 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Mike Percy, Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8804 to look at the new patch set (#17). Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode

[kudu-CR] KUDU-2291 (part 2): Add a /stacks page

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9253 ) Change subject: KUDU-2291 (part 2): Add a /stacks page .. KUDU-2291 (part 2): Add a /stacks page This adds a simple /stacks web

[kudu-CR] KUDU-2297 (part 4): periodically dump stacks to diagnostics log

2018-02-20 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9330 to look at the new patch set (#5). Change subject: KUDU-2297 (part 4): periodically dump stacks to diagnostics log

[kudu-CR] KUDU-2291 (part 6) stacks: use libunwind directly for stack tracing

2018-02-20 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9319 to look at the new patch set (#5). Change subject: KUDU-2291 (part 6) stacks: use libunwind directly for stack tracing

[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks

2018-02-20 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9329 to look at the new patch set (#4). Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks

[kudu-CR] KUDU-2297 (part 2). Convert diagnostics log to a format closer to glog

2018-02-20 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9327 to look at the new patch set (#4). Change subject: KUDU-2297 (part 2). Convert diagnostics log to a format closer to glog

[kudu-CR] KUDU-2297 (part 1): refactor metrics log out of ServerBase

2018-02-20 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9326 to look at the new patch set (#4). Change subject: KUDU-2297 (part 1): refactor metrics log out of ServerBase

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-02-20 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9372 Change subject: rowset_metadata: cache min/max encoded keys .. rowset_metadata: cache min/max encoded keys This patch adds a new flag

[kudu-CR] [catalog manager] check re-replication scheme upon table creation

2018-02-20 Thread Alexey Serbin (Code Review)
Hello Mike Percy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9321 to look at the new patch set (#2). Change subject: [catalog_manager] check re-replication scheme upon table creation

[kudu-CR] [catalog manager] check re-replication scheme upon table creation

2018-02-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9321 ) Change subject: [catalog_manager] check re-replication scheme upon table creation .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2274 [itest] stress test for replica replacement

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9255 ) Change subject: KUDU-2274 [itest] stress test for replica replacement .. Patch Set 5: Code-Review+1 (3 comments)

[kudu-CR] KUDU-2274 [itest] stress test for replica replacement

2018-02-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9255 ) Change subject: KUDU-2274 [itest] stress test for replica replacement .. Patch Set 6: (3 comments)

[kudu-CR] KUDU-2274 [itest] stress test for replica replacement

2018-02-20 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Mike Percy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9255 to look at the new patch set (#6). Change subject: KUDU-2274 [itest] stress test for replica replacement ..

[kudu-CR] internal mini cluster: support Cluster/LogVerifier

2018-02-20 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9137 ) Change subject: internal_mini_cluster: support Cluster/LogVerifier .. internal_mini_cluster: support Cluster/LogVerifier This

[kudu-CR] KUDU-2291 (part 3): use futex to speed up stack collection

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9254 ) Change subject: KUDU-2291 (part 3): use futex to speed up stack collection .. Patch Set 5: (2 comments)

[kudu-CR] [catalog manager] check re-replication scheme upon table creation

2018-02-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9321 ) Change subject: [catalog_manager] check re-replication scheme upon table creation .. [catalog_manager] check re-replication

[kudu-CR] KUDU-2291 (part 2): Add a /stacks page

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9253 ) Change subject: KUDU-2291 (part 2): Add a /stacks page .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9262 ) Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection .. Patch Set 5: (2 comments) Nice. How the

[kudu-CR] gutil: properly hook up ANNOTATE HAPPENS BEFORE/AFTER

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9325 ) Change subject: gutil: properly hook up ANNOTATE_HAPPENS_BEFORE/AFTER .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] WIP follower masters cannot verify tokens

2018-02-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9373 Change subject: WIP follower masters cannot verify tokens .. WIP follower masters cannot verify tokens This small test explains that

[kudu-CR] KUDU-721: Support range partitions on decimal columns

2018-02-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9363 ) Change subject: KUDU-721: Support range partitions on decimal columns .. Patch Set 1: LGTM with Alexey's points addressed -- To view,

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

2018-02-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 ) Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode .. Patch Set 16: (1 comment)

[kudu-CR] WIP [tests] scenario to repro off-by-one error in TestWorkload

2018-02-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9277 ) Change subject: WIP [tests] scenario to repro off-by-one error in TestWorkload .. Patch Set 1: I briefly tried this with my WIP

[kudu-CR] gutil: properly hook up ANNOTATE HAPPENS BEFORE/AFTER

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9325 ) Change subject: gutil: properly hook up ANNOTATE_HAPPENS_BEFORE/AFTER .. gutil: properly hook up ANNOTATE_HAPPENS_BEFORE/AFTER

[kudu-CR] KUDU-2297 (part 1): refactor metrics log out of ServerBase

2018-02-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9326 ) Change subject: KUDU-2297 (part 1): refactor metrics log out of ServerBase .. Patch Set 3: (2 comments) SGTM except nits. Release

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 7: (1 comment)

[kudu-CR] [catalog manager] check re-replication scheme upon table creation

2018-02-20 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9321 to look at the new patch set (#3). Change subject: [catalog_manager] check re-replication scheme upon table creation

[kudu-CR] KUDU-2259: add real user to AuthenticationCredentialsPB

2018-02-20 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9374 to review the following change. Change subject: KUDU-2259: add real user to AuthenticationCredentialsPB .. KUDU-2259:

[kudu-CR] KUDU-2274 [itest] stress test for replica replacement

2018-02-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9255 ) Change subject: KUDU-2274 [itest] stress test for replica replacement .. KUDU-2274 [itest] stress test for replica replacement

[kudu-CR] [TestWorkload] an option to retry on read timeouts

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9295 ) Change subject: [TestWorkload] an option to retry on read timeouts .. Patch Set 4: Code-Review+2 agreed w/ Todd use of this may be

[kudu-CR] KUDU-1704: add java client support for READ YOUR WRITES mode

2018-02-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8847 ) Change subject: KUDU-1704: add java client support for READ_YOUR_WRITES mode .. Patch Set 4: I'm slacking on this review a bit

[kudu-CR] KUDU-2291 (part 5): allow collecting stack traces asynchronously

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9318 ) Change subject: KUDU-2291 (part 5): allow collecting stack traces asynchronously .. Patch Set 5: (12 comments)

[kudu-CR] KUDU-2291 (part 3): use futex to speed up stack collection

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9254 ) Change subject: KUDU-2291 (part 3): use futex to speed up stack collection .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9355 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Patch Set 3: Code-Review+1 (1 comment) Would be good for

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9343 to look at the new patch set (#8). Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level

[kudu-CR] KUDU-2297 (part 1): refactor metrics log out of ServerBase

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9326 ) Change subject: KUDU-2297 (part 1): refactor metrics log out of ServerBase .. Patch Set 3: (3 comments)

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 8: (1 comment)

[kudu-CR] WIP KUDU-2319 follower masters cannot verify tokens

2018-02-20 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9373 to look at the new patch set (#2). Change subject: WIP KUDU-2319 follower masters cannot verify tokens .. WIP

[kudu-CR] WIP: KUDU-2297 (part 5): dump stacks into diagnostics log on service queue overflow

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9375 Change subject: WIP: KUDU-2297 (part 5): dump stacks into diagnostics log on service queue overflow .. WIP: KUDU-2297 (part 5): dump

[kudu-CR] KUDU-2297 (part 1): refactor metrics log out of ServerBase

2018-02-20 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9326 to look at the new patch set (#5). Change subject: KUDU-2297 (part 1): refactor metrics log out of ServerBase

[kudu-CR] KUDU-2291 (part 3): use futex to speed up stack collection

2018-02-20 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9254 to look at the new patch set (#6). Change subject: KUDU-2291 (part 3): use futex to speed up stack collection

[kudu-CR] KUDU-2297 (part 4): periodically dump stacks to diagnostics log

2018-02-20 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9330 to look at the new patch set (#6). Change subject: KUDU-2297 (part 4): periodically dump stacks to diagnostics log

[kudu-CR] [TestWorkload] an option to retry on read timeouts

2018-02-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9295 ) Change subject: [TestWorkload] an option to retry on read timeouts .. Patch Set 4: Thanks you Todd and Mike for the reviews. Yes, I

[kudu-CR] [catalog manager] check re-replication scheme upon table creation

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9321 ) Change subject: [catalog_manager] check re-replication scheme upon table creation .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 9: (1 comment)

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Tidy Bot, Lars Volker, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9343 to look at the new patch set (#9). Change subject: KUDU-2301: (Part-1) Add instrumentation on a per

[kudu-CR] docs: improvements to transaction semantics

2018-02-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9235 ) Change subject: docs: improvements to transaction semantics .. Patch Set 1: (4 comments)

[kudu-CR] KUDU-2274 [itest] stress test for replica replacement

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9255 ) Change subject: KUDU-2274 [itest] stress test for replica replacement .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2291 (part 3): use futex to speed up stack collection

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9254 ) Change subject: KUDU-2291 (part 3): use futex to speed up stack collection .. KUDU-2291 (part 3): use futex to speed up stack

[kudu-CR] docs: improvements to transaction semantics

2018-02-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9235 ) Change subject: docs: improvements to transaction semantics .. Patch Set 1: (4 comments)

[kudu-CR] KUDU-721: Support range partitions on decimal columns

2018-02-20 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9363 ) Change subject: KUDU-721: Support range partitions on decimal columns .. Patch Set 2: (4 comments)

[kudu-CR] KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9262 ) Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection .. Patch Set 6: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9262 ) Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection .. KUDU-2291 (part 4): avoid

[kudu-CR] KUDU-2291 (part 5): allow collecting stack traces asynchronously

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9318 ) Change subject: KUDU-2291 (part 5): allow collecting stack traces asynchronously .. Patch Set 4: (10 comments)

[kudu-CR] KUDU-2297 (part 4): periodically dump stacks to diagnostics log

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9330 ) Change subject: KUDU-2297 (part 4): periodically dump stacks to diagnostics log .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-2291 (part 5): allow collecting stack traces asynchronously

2018-02-20 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9318 to look at the new patch set (#6). Change subject: KUDU-2291 (part 5): allow collecting stack traces asynchronously

[kudu-CR] KUDU-2291 (part 6) stacks: use libunwind directly for stack tracing

2018-02-20 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9319 to look at the new patch set (#7). Change subject: KUDU-2291 (part 6) stacks: use libunwind directly for stack tracing

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

2018-02-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 ) Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode .. Patch Set 18: (2 comments)

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

2018-02-20 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Mike Percy, Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8804 to look at the new patch set (#18). Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode

[kudu-CR] KUDU-1704: add c++ client support for READ YOUR WRITES mode

2018-02-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8823 ) Change subject: KUDU-1704: add c++ client support for READ_YOUR_WRITES mode .. Patch Set 10: (8 comments)

[kudu-CR] KUDU-1704: add c++ client support for READ YOUR WRITES mode

2018-02-20 Thread Hao Hao (Code Review)
Hello Alex Rodoni, Mike Percy, Dan Burkert, David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8823 to look at the new patch set (#10). Change subject: KUDU-1704: add c++ client support for READ_YOUR_WRITES mode

[kudu-CR] KUDU-1704: add java client support for READ YOUR WRITES mode

2018-02-20 Thread Hao Hao (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8847 to look at the new patch set (#5). Change subject: KUDU-1704: add java client support for READ_YOUR_WRITES mode

[kudu-CR] docs: improvements to transaction semantics

2018-02-20 Thread Hao Hao (Code Review)
Hello Alex Rodoni, David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9235 to look at the new patch set (#2). Change subject: docs: improvements to transaction semantics

[kudu-CR] KUDU-721: Support range partitions on decimal columns

2018-02-20 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9363 to look at the new patch set (#2). Change subject: KUDU-721: Support range partitions on decimal columns

[kudu-CR] KUDU-721: [Flume] Add DECIMAL type support

2018-02-20 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9365 Change subject: KUDU-721: [Flume] Add DECIMAL type support .. KUDU-721: [Flume] Add DECIMAL type support Adds decimal column support to

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9343 to look at the new patch set (#5). Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level

[kudu-CR] Support decimal columns in load generation tool

2018-02-20 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9362 to look at the new patch set (#2). Change subject: Support decimal columns in load generation tool

[kudu-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9355 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-721: [Flume] Add DECIMAL type support

2018-02-20 Thread Grant Henke (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9365 to look at the new patch set (#2). Change subject: KUDU-721: [Flume] Add DECIMAL type support ..

[kudu-CR] Support decimal columns in load generation tool

2018-02-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9362 ) Change subject: Support decimal columns in load generation tool .. Patch Set 1: (2 comments)

[kudu-CR] Support decimal columns in load generation tool

2018-02-20 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9362 ) Change subject: Support decimal columns in load generation tool .. Patch Set 1: (2 comments)

[kudu-CR] Support decimal columns in load generation tool

2018-02-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9362 ) Change subject: Support decimal columns in load generation tool .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-2275. Upgrade libunwind to 1.3-rc1

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9335 ) Change subject: KUDU-2275. Upgrade libunwind to 1.3-rc1 .. KUDU-2275. Upgrade libunwind to 1.3-rc1 Per KUDU-2275, the version of

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 6: > Build Failed > >

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 ) Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode .. Patch Set 16: (4 comments) lgtm, just a nit and one last question

[kudu-CR] KUDU-1704: add c++ client support for READ YOUR WRITES mode

2018-02-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8823 ) Change subject: KUDU-1704: add c++ client support for READ_YOUR_WRITES mode .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-1704: add c++ client support for READ YOUR WRITES mode

2018-02-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8823 ) Change subject: KUDU-1704: add c++ client support for READ_YOUR_WRITES mode .. Patch Set 9: (2 comments)

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9343 to look at the new patch set (#6). Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level

[kudu-CR] internal mini cluster: support Cluster/LogVerifier

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9137 ) Change subject: internal_mini_cluster: support Cluster/LogVerifier .. Patch Set 12: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2291 (part 2): Add a /stacks page

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9253 ) Change subject: KUDU-2291 (part 2): Add a /stacks page .. Patch Set 5: Verified+1 unrelated consensus test flke -- To view, visit

[kudu-CR] KUDU-2291 (part 2): Add a /stacks page

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9253 ) Change subject: KUDU-2291 (part 2): Add a /stacks page .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1

[kudu-CR] KUDU-1704: add c++ client support for READ YOUR WRITES mode

2018-02-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8823 ) Change subject: KUDU-1704: add c++ client support for READ_YOUR_WRITES mode .. Patch Set 9: (6 comments)

[kudu-CR] Support decimal columns in load generation tool

2018-02-20 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9362 ) Change subject: Support decimal columns in load generation tool .. Support decimal columns in load generation tool Change-Id:

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-2275. Upgrade libunwind to 1.3-rc1

2018-02-20 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9335 ) Change subject: KUDU-2275. Upgrade libunwind to 1.3-rc1 .. Patch Set 2: Code-Review+2 -- To view, visit