Review Request 38844: Added unit tests for Call validation in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Re: Review Request 38577: Added synchronous validation for Call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Sept. 29, 2015, 8 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 38468: docs: Added discussion of finding a shepherd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38468/#review100934 --- Ship it! This looks great! Thanks for the clarifications. I have

Re: Review Request 38844: Added unit tests for Call validation in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- (Updated Sept. 29, 2015, 8:08 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/#review100953 --- 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/#review100962 --- 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/#review100961 --- src/master/http.cpp (lines 261 - 262)

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/#review100964 --- One high level suggestion. After looking at our http code, I

Re: Review Request 38577: Added synchronous validation for Call in Agent

> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote: > > src/Makefile.am, line 501 > > > > > > I think you'll make Alex happy if you also update the corresponding > > CMake file(s). > > Isabel Jimenez wrote: > We

Re: Review Request 38837: CMake: Disable agent build on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38837/ --- (Updated Sept. 29, 2015, 4:49 p.m.) Review request for mesos, Artem

Re: Review Request 38837: CMake: Disable agent build on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38837/#review100974 --- Can you explain why you're disabling this part? (Is it simply not

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38828/#review100966 --- Ship it! Ship It! - Timothy Chen On Sept. 29, 2015, 12:50

Re: Review Request 38827: CMake: Expanded support for compiling much of the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38827/#review100972 --- Ship it! Tested on OSX + Clang 7.0. Confirmed that some of the

Re: Review Request 38577: Added synchronous validation for Call in Agent

> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote: > > src/Makefile.am, line 501 > > > > > > I think you'll make Alex happy if you also update the corresponding > > CMake file(s). > > Isabel Jimenez wrote: > We

Re: Review Request 38826: CMake: Added support for libevent for Unix builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38826/#review100975 --- Ship it! Ship It! - Joseph Wu On Sept. 28, 2015, 3:58 p.m.,

Re: Review Request 38855: Added support for getting shared and slave mount peer group ID.

> On Sept. 29, 2015, 8:46 p.m., Ian Downes wrote: > > src/tests/containerizer/fs_tests.cpp, line 203 > > > > > > So the mount won't get cleaned up if the test asserts early? We have a universal cleanup code here:

Re: Review Request 38452: Updated C++ style guide for namespace usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/ --- (Updated 九月 29, 2015, 11:04 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38855: Added support for getting shared and slave mount peer group ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38855/#review101009 --- Ship it! src/tests/containerizer/fs_tests.cpp (line 198)

Re: Review Request 38855: Added support for getting shared and slave mount peer group ID.

> On Sept. 29, 2015, 9:20 p.m., Jiang Yan Xu wrote: > > src/linux/fs.hpp, line 174 > > > > > > s/resides/resides in/ 'in which' (in is already there). - Jie

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38858/#review101024 --- Ship it! Modulo Ian's comments.

Re: Review Request 38860: Linked more doc pages from home.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38860/#review101040 --- Patch looks great! Reviews applied: [38860] All tests passed. -

Re: Review Request 38452: Updated C++ style guide for namespace usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/#review101044 --- Ship it! Thanks! I'll get this committed shortly.

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38858/#review101011 --- src/slave/containerizer/isolators/filesystem/linux.cpp (lines 88

Re: Review Request 38577: Added synchronous validation for Call in Agent

> On Sept. 29, 2015, 8:29 p.m., Anand Mazumdar wrote: > > src/slave/validation.cpp, line 57 > > > > > > Sorry for the ping pong iterations on this but noticed another missing > > validation check for `Call::UPDATE`

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38809/#review101028 --- 3rdparty/libprocess/src/socket.cpp (lines 79 - 81)

Review Request 38867: Added drop message method in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38867/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.

Re: Review Request 37540: Add perf event API

> On Sept. 25, 2015, 9:53 p.m., Vinod Kone wrote: > > src/linux/perf.cpp, line 792 > > > > > > so the semantics of this read() are a bit confusing. > > > > if the caller calls the read() back to back, they

Re: Review Request 38855: Added support for getting shared and slave mount peer group ID.

> On Sept. 29, 2015, 9:09 p.m., Timothy Chen wrote: > > src/linux/fs.cpp, line 156 > > > > > > Do you know in what situations will the conversion fail? Also for > > master: as well. > > I wonder if we should

Re: Review Request 38577: Added synchronous validation for Call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Sept. 29, 2015, 9:25 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

> On Sept. 29, 2015, 9:42 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/socket.cpp, lines 79-81 > > > > > > We're using `s.get()` above here, so `owned` should never be `true`? owned is determined

Re: Review Request 38452: Updated C++ style guide for namespace usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/#review101041 --- Ship it! Thanks for your patience! Just a couple of cleanups and

Re: Review Request 38452: Updated C++ style guide for namespace usage

> On 九月 29, 2015, 11:30 p.m., Ben Mahler wrote: > > docs/mesos-c++-style-guide.md, lines 41-45 > > > > > > To mirror the google style guide, can we place this before 'Naming'? Done > On 九月 29, 2015, 11:30 p.m.,

Re: Review Request 38452: Updated C++ style guide for namespace usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/ --- (Updated 九月 29, 2015, 11:43 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38844: Added unit tests for Call validation in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/#review101048 --- Patch looks great! Reviews applied: [38618, 38577, 38844] All

Re: Review Request 37540: Add perf event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/ --- (Updated Sept. 30, 2015, 12:12 a.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 38855: Added support for getting shared and slave mount peer group ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38855/ --- (Updated Sept. 29, 2015, 11:12 p.m.) Review request for mesos, Ian Downes,

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38858/ --- (Updated Sept. 29, 2015, 11:13 p.m.) Review request for mesos, Timothy Chen

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38858/#review101017 --- Patch looks great! Reviews applied: [38855, 38858] All tests

Re: Review Request 38844: Added unit tests for Call validation in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- (Updated Sept. 29, 2015, 9:27 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 38747: Adding digest utilities

> On Sept. 29, 2015, 9:35 p.m., Ben Mahler wrote: > > Tim, could you also get a libprocess maintainer to review this? Volunteered you :) - Timothy --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 38074: Calculate schedule latency with trace events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/ --- (Updated Sept. 30, 2015, 12:15 a.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 37541: Add trace event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Sept. 30, 2015, 12:14 a.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 38855: Added support for getting shared and slave mount peer group ID.

> On Sept. 29, 2015, 2:09 p.m., Timothy Chen wrote: > > src/linux/fs.cpp, line 156 > > > > > > Do you know in what situations will the conversion fail? Also for > > master: as well. > > I wonder if we should

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

> On Sept. 29, 2015, 9:42 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/socket.cpp, lines 79-81 > > > > > > We're using `s.get()` above here, so `owned` should never be `true`? > > Chi Zhang wrote: >

Review Request 38869: Added static->dynamic transformation to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38869/ --- Review request for mesos, Ben Mahler, Cody Maloney, Artem Harutyunyan, and

Re: Review Request 38855: Added support for getting shared and slave mount peer group ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38855/#review101014 --- src/linux/fs.cpp (line 156)

Re: Review Request 38855: Added support for getting shared and slave mount peer group ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38855/#review101016 --- Ship it! Modulo src/linux/fs.hpp (line 174)

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review101026 --- Tim, could you also get a libprocess maintainer to review this? -

Re: Review Request 38837: CMake: Disable agent build on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38837/#review101033 --- Patch looks great! Reviews applied: [38825, 38826, 38827, 38837]

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

> On Sept. 29, 2015, 9:04 p.m., Ian Downes wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 126 > > > > > > If it's already mounted (so it's in /etc/mtab) there's no reason to > > shell out;

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

> On Sept. 29, 2015, 9:04 p.m., Ian Downes wrote: > > src/tests/containerizer/filesystem_isolator_tests.cpp, lines 926-930 > > > > > > This doesn't verify the work_dir *is* bind mounted, just that *if* it > > is

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

> On Sept. 29, 2015, 9:04 p.m., Ian Downes wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, lines 88-94 > > > > > > This has appeared in multiple places, perhaps refactor this into a > > helper?

Re: Review Request 38855: Added support for getting shared and slave mount peer group ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38855/#review101047 --- Ship it! Ship It! - Timothy Chen On Sept. 29, 2015, 11:12

Re: Review Request 38870: Fixed a bug related to reviewboard_url option in post-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38870/ --- (Updated Sept. 30, 2015, 12:36 a.m.) Review request for mesos and Vinod Kone.

Review Request 38870: Fixed a bug related to reviewboard_url option in post-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38870/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/#review101082 --- Ship it! Ship It! - Guangya Liu On 九月 30, 2015, 3:40 a.m.,

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

> On Sept. 25, 2015, 9:55 p.m., Joris Van Remoortere wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1397 > > > > > > This causes a race that can corrupt the allocator: > > - The calls to

Re: Review Request 38452: Updated C++ style guide for namespace usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/#review101038 --- docs/mesos-c++-style-guide.md (lines 41 - 43)

Re: Review Request 38869: Added static->dynamic transformation to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38869/ --- (Updated Sept. 30, 2015, 1:08 a.m.) Review request for mesos, Ben Mahler, Cody

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

> On Sept. 29, 2015, 10:43 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h, line 40 > > > > > > Just to confirm: this file is generated using bundled protobuf, right?

Re: Review Request 38869: Added static->dynamic transformation to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38869/#review101053 --- src/Makefile.am (line 489)

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38875/#review101074 --- src/slave/http.cpp (line 292)

Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs:

Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs:

Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38875/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs:

Review Request 38876: Added functionality to store a marker file to denote HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38876/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs:

Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38874/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs:

Re: Review Request 38870: Fixed a bug related to reviewboard_url option in post-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38870/#review101052 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2015, 12:36 a.m.,

Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38873/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs:

Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38873/#review101069 --- src/internal/evolve.hpp (line 46)

Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38874/#review101071 --- src/slave/slave.cpp (line 5325)

Re: Review Request 38074: Calculate schedule latency with trace events

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/#review101063 --- Patch looks great! Reviews applied: [37540, 37541, 38074] All

Re: Review Request 38860: Linked more doc pages from home.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38860/#review101042 --- Ship it! It took a while to track down some of these 2-character

Re: Review Request 38468: docs: Added discussion of finding a shepherd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38468/#review101057 --- Ship it! Still looks good. I'll commit this now.

Re: Review Request 38870: Fixed a bug related to reviewboard_url option in post-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38870/#review101068 --- Bad patch! Reviews applied: [38870] Failed command:

Re: Review Request 38844: Added unit tests for Call validation in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/#review101073 --- LGTM ! Just some minor comments to clean up the tests around

Re: Review Request 38869: Added static->dynamic transformation to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38869/#review101055 --- Patch looks great! Reviews applied: [38869] All tests passed. -

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/#review101075 --- Patch looks great! Reviews applied: [38873, 38874, 38875, 38876,

Re: Review Request 38876: Added functionality to store a marker file to denote HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38876/#review101076 --- Ship it! Ship It! - Guangya Liu On 九月 30, 2015, 3:39 a.m.,

Re: Review Request 38577: Added synchronous validation for Call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review101078 --- Thanks Isabel, this looks pretty neat now. Just some minor cleanup

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review101077 --- src/slave/slave.hpp (line 169)

Re: Review Request 38837: CMake: Disable agent build on Windows.

> On Sept. 29, 2015, 5:06 p.m., Joseph Wu wrote: > > Can you explain why you're disabling this part? (Is it simply not > > implemented yet, so you're temporarily skipping it?) Mainly because the agent doesn't actually compile on Windows. I meant to put this up for review awhile ago but

Re: Review Request 38827: CMake: Expanded support for compiling much of the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38827/ --- (Updated Sept. 29, 2015, 5:17 p.m.) Review request for mesos, Artem

Re: Review Request 38837: CMake: Disable agent build on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38837/ --- (Updated Sept. 29, 2015, 5:17 p.m.) Review request for mesos, Artem

Review Request 38855: Added support for getting shared and slave mount peer group ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38855/ --- Review request for mesos, Ian Downes, Timothy Chen, and Jiang Yan Xu. Bugs:

Re: Review Request 38468: docs: Added discussion of finding a shepherd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38468/ --- (Updated Sept. 29, 2015, 6:19 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38825/ --- (Updated Sept. 29, 2015, 5:16 p.m.) Review request for mesos, Artem

Re: Review Request 38826: CMake: Added support for libevent for Unix builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38826/ --- (Updated Sept. 29, 2015, 5:16 p.m.) Review request for mesos, Artem

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38809/ --- (Updated Sept. 29, 2015, 6:11 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 29, 2015, 6:41 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38855: Added support for getting shared and slave mount peer group ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38855/ --- (Updated Sept. 29, 2015, 7:09 p.m.) Review request for mesos, Ian Downes,

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

> On Sept. 29, 2015, 1:17 a.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, lines 926-928 > > > > > > Hey I think we should be doing the same behavior as MesosContainerizer > > since the executor

Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38858/ --- Review request for mesos, Timothy Chen and Jiang Yan Xu. Bugs: MESOS-3539

Re: Review Request 38328: Added a helper to get stat.st_dev in stout.

> On Sept. 29, 2015, 6:32 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/stat.hpp, line 134 > > > > > > Hm.. looks like this file needs a pass to phrase the errors as "Failed

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

> On Sept. 29, 2015, 12:47 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/socket.cpp, lines 42-44 > > > > > > Just as an aside, it's unfortunate the caller has to do this, we should > > consider doing the same

Re: Review Request 38844: Added unit tests for Call validation in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- (Updated Sept. 29, 2015, 8:05 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 38577: Added synchronous validation for Call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Sept. 29, 2015, 8:15 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38826: CMake: Added support for libevent for Unix builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38826/ --- (Updated Sept. 29, 2015, 8:21 p.m.) Review request for mesos, Artem

Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38825/ --- (Updated Sept. 29, 2015, 8:21 p.m.) Review request for mesos, Artem

Re: Review Request 38844: Added unit tests for Call validation in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- (Updated Sept. 29, 2015, 8:25 p.m.) Review request for mesos, Anand Mazumdar

  1   2   >