Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/#review124499 --- It would be great to have a unit test that verifies that when a

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review124509 --- Could you write a test where one framework hoards its share of

Re: Review Request 44511: Add registry tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review124511 --- Need to get rid of the unnecessary stringify/atof translation,

Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44089/#review124516 --- I think this needs to be rebased on your changes in stout. -

Re: Review Request 44747: Stout: Added implementation of `write` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44747/#review124514 ---

Re: Review Request 44512: Support to get weights info by /weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44512/#review124512 --- Good start, but you're missing a few things. Are these coming in

Re: Review Request 44672: Added normalize method to registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/ --- (Updated March 20, 2016, 11:44 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 44673: Added test for registry puller normalize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44673/ --- (Updated March 20, 2016, 11:44 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 45093: Added mesos containerizer test DestroyWhileProvisioning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45093/#review124506 --- Patch looks great! Reviews applied: [45092, 45093] Passed

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

> On March 18, 2016, 11:36 a.m., Jiang Yan Xu wrote: > > configure.ac, line 923 > > > > > > Sorry this should have been a continued discussion on > > https://reviews.apache.org/r/44342/#comment184051 but anyways: >

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/#review124122 ---

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/#review124515 --- Can you consider the feedback frmo the `write` review and rebase

Re: Review Request 44139: Windows:[2/2] Lifted socket API into Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44139/#review124513 --- 3rdparty/libprocess/include/process/network.hpp (line 27)

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/ --- (Updated March 21, 2016, 6:14 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44672: Added normalize method to registry puller.

> On March 19, 2016, 10:45 a.m., Jie Yu wrote: > > Please add a test to test if we can properly handle images like 'alpine' > > directly without the 'library/' prefix. Test was in patch #44673. - Gilbert --- This is an automatically

Re: Review Request 44672: Added normalize method to registry puller.

> On March 18, 2016, 11:54 p.m., Shuai Lin wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 182 > > > > > > I would suggest to add a new test for the `normalize` function. >

Re: Review Request 44379: Correctly parse perf stat format for non-vanilla 3.10 kernel.

> On 三月 17, 2016, 1:02 a.m., Ben Mahler wrote: > > src/linux/perf.cpp, lines 435-437 > > > > > > Hm.. this comment is really hard for me to understand, if OS vendors > > enhance the format, how did you know that

Re: Review Request 44974: Added device support in cgroups abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/ --- (Updated March 21, 2016, 6:06 a.m.) Review request for mesos, Ben Mahler,

Review Request 45097: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45097/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-4981

Re: Review Request 45073: Restructured authentication.md to group common flags.

> On March 20, 2016, 5:44 p.m., Greg Mann wrote: > > Personally, I'm not convinced that this is a useful way to format our flag > > documentation. I've been meaning to propose eliminating it from > > 'configuration.md'. I think it's more confusing to have the lists of flags > > broken up into

Review Request 45095: Introduce 'minus' operator for class Counter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45095/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-4981

Re: Review Request 44229: Added upgrade testing script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44229/ --- (Updated March 21, 2016, 9:20 p.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 44229: Added upgrade testing script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44229/#review124677 --- Fix it, then Ship it! support/test-upgrade.py (line 188)

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

> On March 16, 2016, 12:46 a.m., Vinod Kone wrote: > > Can you explain what testing you have done in the "Testing done" section? > > > > According to MESOS-4312, we agreed to do the following tests: > > > > -- Verify SSL, perf and docker related test cases work as expected on all > >

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review124679 --- Can you also explain the testing you have done?

Re: Review Request 44948: Add XFS disk resource isolator.

> On March 21, 2016, 3:51 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, line 320 > > > > > > I am wondering if it's possible to distinguish the Error case from the > > case where

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 21, 2016, 9:47 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44229: Added upgrade testing script.

> On March 16, 2016, 12:43 a.m., Vinod Kone wrote: > > support/test-upgrade.py, line 42 > > > > > > credfile is unused? In switching to the `test-framework`, I also enabled authentication, so the credential file is

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated March 21, 2016, 9:46 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated March 21, 2016, 9:46 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45039: Updated the scheduler `launchTasks()` comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/ --- (Updated March 21, 2016, 9:24 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44993: Updated `TestContainerizer` to support default actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44993/ --- (Updated March 21, 2016, 9:23 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45123/#review124672 --- Patch looks great! Reviews applied: [42470, 42471, 42472, 42473,

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 21, 2016, 10:53 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44139: Windows:[2/2] Lifted socket API into Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44139/ --- (Updated March 21, 2016, 10:54 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44760: Windows: Fixed non-blocking connect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/ --- (Updated March 21, 2016, 10:54 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44089/ --- (Updated March 21, 2016, 10:54 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44090/ --- (Updated March 21, 2016, 10:54 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44992: Reordered function declarations in `TestContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44992/ --- (Updated March 21, 2016, 9:22 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated March 21, 2016, 9:46 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 21, 2016, 9:46 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44949: Add XFS disk isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated March 21, 2016, 9:46 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45126: Cleaned up nested health checker launch code in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45126/#review124683 --- Patch looks great! Reviews applied: [45126] Passed command:

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

> On March 4, 2016, 7:37 a.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, line 68 > > > > > > ditto. > > Zhiwei Chen wrote: > In the real file, there is a table bracket and backslash. I

Re: Review Request 45018: MESOS-3481 Add const accessor to Master flags.

> On March 21, 2016, 7:04 p.m., Benjamin Bannier wrote: > > src/master/master.hpp, line 546 > > > > > > Two things: > > > > (1) I think a more fitting name here might be `flags()` (cf `info()` > > just

Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45134/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4993

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated March 22, 2016, 1:20 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated March 22, 2016, 1:20 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 22, 2016, 1:21 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated March 22, 2016, 1:20 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 22, 2016, 1:20 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated March 22, 2016, 11:44 a.m.) Review request for mesos, Greg Mann,

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review124717 --- Hi, zhiwei. Thank you for your patch. But seems it still doesn't

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- (Updated March 22, 2016, 9:38 a.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45134/#review124710 --- src/tests/fetcher_tests.cpp (lines 647 - 651)

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

> On March 22, 2016, 10:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > >

Re: Review Request 43935: Allow setting role in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- (Updated 三月 22, 2016, 2:57 a.m.) Review request for mesos, Greg Mann, Shuai

Re: Review Request 45126: Cleaned up nested health checker launch code in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45126/#review124681 --- Ship it! Ship It! - Timothy Chen On March 21, 2016, 8:31

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/ --- (Updated March 22, 2016, 10:22 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

> On March 16, 2016, 12:46 a.m., Vinod Kone wrote: > > Can you explain what testing you have done in the "Testing done" section? > > > > According to MESOS-4312, we agreed to do the following tests: > > > > -- Verify SSL, perf and docker related test cases work as expected on all > >

Re: Review Request 45018: MESOS-3481 Add const accessor to Master flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45018/ --- (Updated March 22, 2016, 3:34 a.m.) Review request for mesos, Joris Van

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

> On March 16, 2016, 8:46 a.m., Vinod Kone wrote: > > Can you explain what testing you have done in the "Testing done" section? > > > > According to MESOS-4312, we agreed to do the following tests: > > > > -- Verify SSL, perf and docker related test cases work as expected on all > >

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

> On March 21, 2016, 10:21 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto, line 17 > > > > > > Can we put this under cni::spec namespace instead? > > Qian Zhang wrote: >

Re: Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45011/#review124740 --- Patch looks great! Reviews applied: [45011] Passed command:

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/#review124730 --- Patch looks great! Reviews applied: [44945, 44946, 44947, 44948,

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/ --- (Updated March 22, 2016, 5:50 a.m.) Review request for mesos, Adam B and

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/ --- (Updated March 22, 2016, 12:13 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/#review124540 ---

Re: Review Request 44854: Added validation for executor's shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/ --- (Updated March 21, 2016, 2:28 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

> On March 21, 2016, 1:20 p.m., haosdent huang wrote: > > Thanks for reviewing haosdent! > On March 21, 2016, 1:20 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp, line 31 > >

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review124545 --- src/common/values.cpp (line 612)

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

> On March 21, 2016, 2:21 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto, line 17 > > > > > > Can we put this under cni::spec namespace instead? > > Qian Zhang wrote: >

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/ --- (Updated March 21, 2016, 1:42 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44994: Added a test for executor shutdown grace period.

> On March 21, 2016, 1 p.m., haosdent huang wrote: > > src/tests/slave_tests.cpp, line 3214 > > > > > > I notice in http://search-hadoop.com/m/0Vlr6J38NSZOXgd2 said we should > > not use negative durations. So

Re: Review Request 44846: Deprecated the plain text credential format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review124550 --- Patch looks great! Reviews applied: [44846] Passed command:

Re: Review Request 44515: Added agent flags for HTTP authentication.

> On March 19, 2016, 3:03 a.m., Joerg Schad wrote: > > src/slave/slave.cpp, line 373 > > > > > > Do we actually have to get the authenticator above if this flag is not > > set? > > Greg Mann wrote: > The code

Re: Review Request 44515: Added agent flags for HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124519 --- Maybe all the http auth flag validation code should just go

Re: Review Request 45038: Fixed email address in Python build file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45038/#review124521 --- Ship it! Ship It! - Joris Van Remoortere On March 18, 2016,

Review Request 45098: Used correct path to authorization protobuf file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45098/ --- Review request for mesos, Alexander Rojas and Till Toenshoff. Bugs: MESOS-2950

Re: Review Request 45036: Added authentication information to agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45036/#review124539 --- src/slave/http.cpp (line 212)

Re: Review Request 45088: Edited master's flag help strings to match the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45088/#review124530 --- Ship it! Ship It! - Till Toenshoff On March 20, 2016, 7:01

Re: Review Request 44554: Added agent HTTP authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/#review124523 --- Ship it! Ship It! - Adam B On March 20, 2016, 11:58 a.m.,

Re: Review Request 44994: Added a test for executor shutdown grace period.

> On March 18, 2016, 11:24 p.m., Ben Mahler wrote: > > src/tests/slave_tests.cpp, line 3264 > > > > > > You don't need a settle here, AWAIT_READY will settle if the clock is > > paused. I feel that this is not

Re: Review Request 44994: Added a test for executor shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/#review124532 --- src/tests/slave_tests.cpp (line 3214)

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review124518 --- Patch looks great! Reviews applied: [44974, 44975] Passed

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated March 21, 2016, 12:08 p.m.) Review request for mesos, Alexander

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated March 21, 2016, 12:08 p.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated March 21, 2016, 12:08 p.m.) Review request for mesos, Alexander

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated March 21, 2016, 12:08 p.m.) Review request for mesos, Alexander

Re: Review Request 44846: Deprecated the plain text credential format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review124528 --- I know we leave deprecated flags in and document them as

Re: Review Request 45098: Used correct path to authorization protobuf file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45098/#review124533 --- Ship it! Ship It! - Till Toenshoff On March 21, 2016, 11:19

Re: Review Request 44511: Add registry tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review124531 --- Bad patch! Reviews applied: [44511, 41790, 44512, 43863, 41681]

Re: Review Request 44673: Added test for registry puller normalize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44673/#review124570 --- Ship it! Ship It! - Jie Yu On March 21, 2016, 6:44 a.m.,

Re: Review Request 44672: Added normalize method to registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review124567 ---

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/ --- (Updated March 21, 2016, 10:37 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

> On March 17, 2016, 11:31 p.m., Neil Conway wrote: > > Thanks for the review! > On March 17, 2016, 11:31 p.m., Neil Conway wrote: > > src/tests/persistent_volume_tests.cpp, line 152 > > > > > > Personally I

Re: Review Request 45098: Used correct path to authorization protobuf file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45098/ --- (Updated March 21, 2016, 12:24 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

> On March 21, 2016, 10:21 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto, line 17 > > > > > > Can we put this under cni::spec namespace instead? Jie, did you mean putting it

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review124554 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

> On March 21, 2016, 1:20 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp, line 46 > > > > > > Should it add > > ``` > > NOLINT(whitespace/line_length) > >

  1   2   >