Re: [webkit-dev] Git Familiarity (was ChangeLog)

2009-07-05 Thread Maciej Stachowiak
On Jul 5, 2009, at 5:00 PM, Benjamin Meyer wrote: However, not everyone on the project is comfortable with git (or is willing to give up svn), so I don't see a near-term solution at the moment other than improving the existing tools (prepare-ChangeLog, resolve-ChangeLogs, etc.). I have h

Re: [webkit-dev] Iterating SunSpider

2009-07-06 Thread Maciej Stachowiak
On Jul 6, 2009, at 10:11 AM, Geoffrey Garen wrote: So, what you end up with is after a couple of years, the slowest test in the suite is the most significant part of the score. Further, I'll predict that the slowest test will most likely be the least relevant test, because the truly impor

Re: [webkit-dev] EXPORT_JS changeset

2009-07-06 Thread Maciej Stachowiak
I see Darin already answered. But for future reference, questions like this that are requests for help, rather than about the development of WebKit itself, should be posted on webkit-help rather than webkit-div. On Jul 1, 2009, at 6:23 AM, Jack Wootton wrote: Hello, I'm interested in usi

Re: [webkit-dev] Isolated world tests

2009-07-06 Thread Maciej Stachowiak
-eric On Wed, Jul 1, 2009 at 11:07 PM, Oliver Hunt wrote: On Jul 1, 2009, at 10:59 PM, Adam Barth wrote: On Wed, Jul 1, 2009 at 7:50 PM, Maciej Stachowiak wrote: We generally wouldn't accept WebKit features that only work with V8, even if other ports may not immediately plan to

Re: [webkit-dev] Isolated world tests

2009-07-06 Thread Maciej Stachowiak
10:59 PM, Adam Barth wrote: On Wed, Jul 1, 2009 at 7:50 PM, Maciej Stachowiak wrote: We generally wouldn't accept WebKit features that only work with V8, even if other ports may not immediately plan to use them. I support this principle. I haven't thought through whether this pa

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Maciej Stachowiak
On Jul 7, 2009, at 4:01 PM, Mike Belshe wrote: I'd like benchmarks to: a) have meaning even as browsers change over time b) evolve. as new areas of JS (or whatever) become important, the benchmark should have facilities to include that. Fair? Good? Bad? I think we can't rule ou

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Maciej Stachowiak
On Jul 7, 2009, at 4:28 PM, Mike Belshe wrote: When SunSpider was first created, regexps were a small proportion of the total execution in what were the fastest publicly available at the time. Eventually, everything else got much faster. So at some point, SunSpider said "it might be a go

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Maciej Stachowiak
On Jul 7, 2009, at 4:19 PM, Peter Kasting wrote: For example, the framework could compute both sums _and_ geomeans, if people thought both were valuable. That's a plausible thing to do, but I think there's a downside: if you make a change that moves the two scores in opposite directions, t

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Maciej Stachowiak
On Jul 7, 2009, at 6:43 PM, Mike Belshe wrote: (There are other benchmarks that use summation, for example iBench, though I am not sure these are examples of excellent benchmarks. Any benchmark that consists of a single test also implicitly uses summation. I'm not sure what other benchma

Re: [webkit-dev] Iterating SunSpider

2009-07-07 Thread Maciej Stachowiak
On Jul 7, 2009, at 7:02 PM, Mike Belshe wrote: On Tue, Jul 7, 2009 at 5:08 PM, Maciej Stachowiak wrote: - property access, involving at least some polymorphic access patterns - method calls - object-oriented programming patterns - GC load - programming in a style that makes significant use

Re: [webkit-dev] Iterating SunSpider

2009-07-08 Thread Maciej Stachowiak
On Jul 7, 2009, at 8:50 PM, Geoffrey Garen wrote: I also don't buy your conclusion -- that if regular expressions account for 1% of JavaScript time on the Internet overall, they need not be optimized. I never said that. You said the regular expression test was "most likely... the least

Re: [webkit-dev] Detecting a finished paint via JavaScript

2009-07-08 Thread Maciej Stachowiak
On Jul 8, 2009, at 10:45 AM, RDC wrote: Would you be willing elaborate on why you want this? Of course; I would like it for benchmarking page rendering times-- something I believe would be possible with Web Inspector, but I'm after a cross-browser way of achieving it. At the moment I hav

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-08 Thread Maciej Stachowiak
I didn't solve every possible problem with prepare-ChangeLog, but I tried to make it a bit less shouty. If you don't provide the --bug argument, it includes text like this: - 2009-07-08 Maciej Stachowiak Reviewed by NOBODY (OOPS!). Need a short descr

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-09 Thread Maciej Stachowiak
Now that my attention has been called to it, it's starting to bug me that everyone formats their ChangeLog entries slightly differently. How about this as the canonical format (with prepare-ChangeLog encouraging it)? 2009-07-08 Maciej Stachowiak Make prepare-ChangeLog

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-09 Thread Maciej Stachowiak
I discussed with Mark Rowe on IRC a bit and it seems like it would be nice if the bug URL could be short enough to just go on one line with the summary. Which turns out to be totally doable. Thus the latest format proposal (the /b/ URL is a redirect): 2009-07-08 Maciej Stachowiak

Re: [webkit-dev] Webkit based HTML to PDF converter

2009-07-09 Thread Maciej Stachowiak
This mailing list is for discussing the development of WebKit. For help in using WebKit, please post to . On Jul 9, 2009, at 2:45 AM, Sharma, Ashish wrote: Hello, I have a requirement to create a MarkUp(HTML) to PDF generator. The mentioned component is to be deployed as a java class API

Re: [webkit-dev] how to understand the grammar implemention of js script "var a=9; "?

2009-07-09 Thread Maciej Stachowiak
This mailing list is for discussing the development of WebKit. For help in using WebKit, please post to . On Jul 9, 2009, at 2:55 AM, Suk Zhong wrote: Hi All: I want to understand the javascript grammar from Grammar.y in JavascriptCore,for the script "var a=9;",we find the following co

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-09 Thread Maciej Stachowiak
On Jul 9, 2009, at 4:33 AM, David Kilzer wrote: 2009-07-08 Maciej Stachowiak - <http://webkit.org/b/27098> Make prepare-ChangeLog less shouty Reviewed by Mark Rowe. Hypothetical long description goes here. Yeah. Very long and detailed it is. * Scripts/p

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-09 Thread Maciej Stachowiak
On Jul 9, 2009, at 8:52 AM, Darin Adler wrote: On Jul 9, 2009, at 1:47 AM, Maciej Stachowiak wrote: (the /b/ URL is a redirect): I'm like most everything suggested in this thread. But I'm a little sad that these new shorter URLs are redirects. I really like to copy URLs

Re: [webkit-dev] Coding convention of constants

2009-07-09 Thread Maciej Stachowiak
On Jul 9, 2009, at 8:55 PM, Darin Fisher wrote: Ditto. The last time I wondered about this, I grepped through the code and found [1] to be the most prevalent. So, in code reviews I have been recommending people do [1]. I think that's the nicest style (just like a variable, no special p

Re: [webkit-dev] Please welcome GYP to the our dysfunctional build family

2009-07-10 Thread Maciej Stachowiak
I think our number of different build systems is getting out of hand. Since gyp is being successfully used to build across platforms, and maintained by people who also work on some WebKit ports (and can thus likely be adapted to our needs), I'd like to consider whether we can use it for A

[webkit-dev] Patch process - let's make it better

2009-07-10 Thread Maciej Stachowiak
Hi everyone, One common topic for discussion has been how to make our process around patch submission better. As the project grows, it's becoming more important for this process to work really smoothly, and we are seeing some breakdowns. I've been doing a lot of thinking about this, and d

Re: [webkit-dev] Patch process - let's make it better

2009-07-10 Thread Maciej Stachowiak
On Jul 10, 2009, at 4:17 PM, Chris Marrin wrote: On Jul 10, 2009, at 3:55 PM, Maciej Stachowiak wrote: Hi everyone, One common topic for discussion has been how to make our process around patch submission better. As the project grows, it's becoming more important for this proce

Re: [webkit-dev] Patch process - let's make it better

2009-07-10 Thread Maciej Stachowiak
On Jul 10, 2009, at 4:41 PM, Jan Michael Alonzo wrote: Hi Maciej === Action Plan === * Phase 1 * C) Improve the way we get attention from reviewers. I think we should do three things here: C.1) Split review queues, based on our emerging [Bracket] convention for patches needing spec

Re: [webkit-dev] ExecState::thisObject()

2009-07-10 Thread Maciej Stachowiak
On Jul 10, 2009, at 5:55 PM, Adam Barth wrote: Eric and I spent some more time this afternoon looking at this. We don't think the ExecState::thisValue() approach is going to work. We implemented hacky version to experiment with, but the problem is with cases like this: document.body In eval

Re: [webkit-dev] ExecState::thisObject()

2009-07-10 Thread Maciej Stachowiak
(Trimming Cc's since the relevant people are on webkit-dev anyway.) On Jul 10, 2009, at 6:10 PM, Adam Barth wrote: On Fri, Jul 10, 2009 at 6:04 PM, Maciej Stachowiak wrote: Is it definitely right for document.body to make a wrapper using prototypes from the document's host wind

Re: [webkit-dev] Patch process - let's make it better

2009-07-11 Thread Maciej Stachowiak
On Jul 11, 2009, at 9:39 AM, Darin Adler wrote: On Jul 10, 2009, at 4:23 PM, Maciej Stachowiak wrote: Perhaps we should make update-webkit (or some new wrapper type tool) run resolve-ChangeLogs automatically. Dave Kilzer had the same idea when he created resolve-ChangeLogs, so update

[webkit-dev] XSSAuditor regressions

2009-07-12 Thread Maciej Stachowiak
Hi everyone, Recently Adam Barth turned on an exciting new feature, the XSS Auditor, by default. This provides a browser-side defense against sites that are vulnerable to reflexive XSS attacks. Because this feature operates by blocking script execution, it has the potential to break legi

Re: [webkit-dev] Patch process - let's make it better

2009-07-13 Thread Maciej Stachowiak
Hi Luke, I think your webkit-dev emails are becoming disruptive. Sending profanity-laced walls of text is not an appropriate use of this list. Please find a way to communicate without annoying the rest of the list, or I will ask the list administrators to "censor" you from the mailing lis

Re: [webkit-dev] Build File Maintenance (was Re: Please welcome GYP to the our dysfunctional build family)

2009-07-13 Thread Maciej Stachowiak
One belated comment on this topic. It would be neat if some port agreed to be the guinea pig to see if gyp could plausibly work for more than Google's ports. The Wx port probably has the lowest resources of any complete port in the tree, so they might not be the best choice of experimenta

Re: [webkit-dev] Build File Maintenance (was Re: Please welcome GYP to the our dysfunctional build family)

2009-07-13 Thread Maciej Stachowiak
On Jul 13, 2009, at 2:03 PM, Peter Kasting wrote: On Mon, Jul 13, 2009 at 1:56 PM, Maciej Stachowiak wrote: One belated comment on this topic. It would be neat if some port agreed to be the guinea pig to see if gyp could plausibly work for more than Google's ports. The Wx port pro

Re: [webkit-dev] ExecState::thisObject()

2009-07-13 Thread Maciej Stachowiak
On Jul 13, 2009, at 2:18 PM, Sam Weinig wrote: I discussed this a bit with Darin and Geoff, and we came to the conclusion that the correct fix is to have each JS DOMObject store a JSGlobalObject pointer and augment the toJS methods to pass a global object instead of an ExecState (close t

Re: [webkit-dev] ExecState::thisObject()

2009-07-13 Thread Maciej Stachowiak
On Jul 13, 2009, at 2:28 PM, Geoffrey Garen wrote: I discussed this a bit with Darin and Geoff, and we came to the conclusion that the correct fix is to have each JS DOMObject store a JSGlobalObject pointer and augment the toJS methods to pass a global object instead of an ExecState (close

Re: [webkit-dev] ENABLE_FORM_VALIDATION

2009-07-13 Thread Maciej Stachowiak
On Jul 13, 2009, at 11:57 AM, David Hyatt wrote: On Jul 13, 2009, at 1:52 PM, Jeremy Orlow wrote: On Mon, Jul 13, 2009 at 11:40 AM, David Hyatt wrote: On Jul 13, 2009, at 12:52 PM, Peter Kasting wrote: On Mon, Jul 13, 2009 at 10:47 AM, David Hyatt wrote: I agree. We should formalize t

Re: [webkit-dev] ExecState::thisObject()

2009-07-13 Thread Maciej Stachowiak
On Jul 13, 2009, at 3:36 PM, Geoffrey Garen wrote: I discussed this a bit with Darin and Geoff, and we came to the conclusion that the correct fix is to have each JS DOMObject store a JSGlobalObject pointer and augment the toJS methods to pass a global object instead of an ExecState (close

Re: [webkit-dev] ExecState::thisObject()

2009-07-13 Thread Maciej Stachowiak
On Jul 13, 2009, at 3:40 PM, Adam Barth wrote: On Mon, Jul 13, 2009 at 3:29 PM, Geoffrey Garen wrote: Our current behavior is buggy, unpredictable, and out of spec. This has led to security bugs in the past and will lead to security bugs in the future. I don't disagree with you, but I'm

Re: [webkit-dev] ExecState::thisObject()

2009-07-13 Thread Maciej Stachowiak
On Jul 13, 2009, at 4:12 PM, Adam Barth wrote: On Mon, Jul 13, 2009 at 4:08 PM, Maciej Stachowiak wrote: Built-in classes work somewhat differently. I believe they use the calling function's global object ("lexical global object") rather than having some notion of hom

Re: [webkit-dev] ExecState::thisObject()

2009-07-13 Thread Maciej Stachowiak
On Jul 13, 2009, at 4:11 PM, Adam Barth wrote: On Mon, Jul 13, 2009 at 4:01 PM, Geoffrey Garen wrote: That's correct. Other browser's get this case right. Here are a couple test cases you might find interesting: http://webblaze.org/abarth/tests/protoconfused/test1.html http://webblaze.org/

Re: [webkit-dev] ExecState::thisObject()

2009-07-13 Thread Maciej Stachowiak
On Jul 13, 2009, at 4:34 PM, Adam Barth wrote: CVE-2009-1702 is an example of such as security hole. I'm sure that I can find more if I look for them. I think objects attached to the global object and accessible cross- origin are a special case here. (The advisory cited is about Location

Re: [webkit-dev] ExecState::thisObject()

2009-07-13 Thread Maciej Stachowiak
On Jul 13, 2009, at 5:34 PM, Adam Barth wrote: On Mon, Jul 13, 2009 at 4:59 PM, Maciej Stachowiak wrote: If security is one motivation for this work, then I'd like us to understand the pattern we want to use for cross-origin-accessible objects. Should they use the "home glo

Re: [webkit-dev] Development Tools on Safari

2009-07-13 Thread Maciej Stachowiak
On Jul 13, 2009, at 7:28 PM, Juan Madrigal wrote: Any chance HTMLTidy will be integrated into Safari? http://zappatic.net/safaritidy/ Firebug is also a must: http://getfirebug.com/ Those are the only things keeping me from ditching Firefox, well aside from the Web Developer Toolbar: http:/

Re: [webkit-dev] How to port webkit on PXA270

2009-07-13 Thread Maciej Stachowiak
For help with porting or similar questions, please direct your queries to . - Maciej On Jul 13, 2009, at 11:25 PM, Naveen Pal wrote: Hello All, I have created webkitgtk browser on OpenSuse. Now I want to port this on PXA270 board. Following are the h/w and s/w details. - Hardware sp

Re: [webkit-dev] Patch process - let's make it better

2009-07-15 Thread Maciej Stachowiak
I'll try to get bugs filed for any part of the plan that isn't done by tomorrow, and I'll tag them with a keyword so we can track progress. On Jul 15, 2009, at 1:14 PM, Adam Treat wrote: On Friday 10 July 2009 06:55:59 pm Maciej Stachowiak wrote: * Phase 1 * A) Make it

Re: [webkit-dev] Patch process - let's make it better

2009-07-15 Thread Maciej Stachowiak
On Jul 15, 2009, at 4:13 PM, David Kilzer wrote: On Saturday, July 11, 2009 11:55:36 AM, Maciej Stachowiak wrote: On Jul 11, 2009, at 9:39 AM, Darin Adler wrote: On Jul 10, 2009, at 4:23 PM, Maciej Stachowiak wrote: Perhaps we should make update-webkit (or some new wrapper type tool

Re: [webkit-dev] Build File Maintenance (was Re: Please welcome GYP to the our dysfunctional build family)

2009-07-15 Thread Maciej Stachowiak
If you're willing to give it a shot, then that sounds like a fine idea. - Maciej On Jul 15, 2009, at 10:51 PM, Ryan Leavengood wrote: On Mon, Jul 13, 2009 at 4:56 PM, Maciej Stachowiak wrote: One belated comment on this topic. It would be neat if some port agreed to be the guine

Re: [webkit-dev] Setting event handlers on the global context

2009-07-19 Thread Maciej Stachowiak
On Jul 19, 2009, at 11:10 AM, Adam Barth wrote: I think we should do what Firefox does in the window.onload case. :) I'm not familiar with the history through. Is there some particular reason we have our current behavior? The current behavior is an accident of implementation, but I think t

Re: [webkit-dev] Coding Style: Clarify some cases with spacing

2009-07-21 Thread Maciej Stachowiak
On Jul 21, 2009, at 6:56 PM, Sam Weinig wrote: I believe it is quite well established that a space should not be allowed before a ; or , in such circumstances. (I have r-ed for it even ;) ). I think we should definitely explicitly call this out in the guidelines if it is not already. T

Re: [webkit-dev] exposing the value of Accept-Language via window.navigation.acceptLanguage ?

2009-07-22 Thread Maciej Stachowiak
On Jul 22, 2009, at 4:41 PM, Jungshik Shin (신정식, 申政湜) wrote: Hi, I proposed exposing the values of the Accept-Langauge list via window.navigation.acceptLanguages at https://bugs.webkit.org/show_bug.cgi?id=27555 This email is to get opinions (for and against) on that in case the bug is

Re: [webkit-dev] JS: Getter/Setter callbacks at Property level

2009-07-22 Thread Maciej Stachowiak
Jumping in late here, but a couple of points: 1) Instead of JSClassSetPropertyGetterSetter, it might be more in line with the class design to be able to define getters and setters in the class struct, just as functions are. In addition to being more convenient, this API may also provide fu

Re: [webkit-dev] exposing the value of Accept-Language via window.navigation.acceptLanguage ?

2009-07-23 Thread Maciej Stachowiak
On Jul 22, 2009, at 11:24 PM, Darin Fisher wrote: On Wed, Jul 22, 2009 at 10:52 PM, Alexey Proskuryakov wrote: 22.07.2009, в 22:36, Darin Fisher написал(а): Firefox and Chrome send very similar A-L headers. Given FF's marketshare, I'm surprised you observed compat problems with doing

Re: [webkit-dev] incompatibility between DOM spec (IDL) and c-based (gobject) language bindings

2009-07-23 Thread Maciej Stachowiak
Responding to review comments should be done in the relevant bugzilla bug, not on the mailing list. It's ok to post here if you think an issue needs wider input from the community, but that doesn't seem to be the case with this issue. Regards, Maciej On Jul 23, 2009, at 5:18 AM, Luke Ken

Re: [webkit-dev] document()->frame()->script()->globalObject()

2009-07-23 Thread Maciej Stachowiak
On Jul 23, 2009, at 5:23 PM, Eric Seidel wrote: It seems all lookups of the current globalObject go through the frame. document()->frame()->script()->globalObject() is one example. Another: JSValue toJS(ExecState*, DOMWindow* domWindow) { if (!domWindow) return jsNull(); Frame* fr

Re: [webkit-dev] document()->frame()->script()->globalObject()

2009-07-23 Thread Maciej Stachowiak
Maciej -eric On Thu, Jul 23, 2009 at 5:33 PM, Maciej Stachowiak wrote: On Jul 23, 2009, at 5:23 PM, Eric Seidel wrote: It seems all lookups of the current globalObject go through the frame. document()->frame()->script()->globalObject() is one example. Another: JSValue toJS(Exe

Re: [webkit-dev] JS: Getter/Setter callbacks at Property level

2009-07-24 Thread Maciej Stachowiak
On Jul 24, 2009, at 7:23 AM, Brian Barnes wrote: This: " 2) There's not currently a performance penalty for re-checking the property name in the catchall getter that you currently have available, because it gets called without JavaScriptCore doing a property lookup first. " Pretty much

Re: [webkit-dev] document()->frame()->script()->globalObject()

2009-07-24 Thread Maciej Stachowiak
On Jul 24, 2009, at 2:18 PM, Darin Adler wrote: On Jul 24, 2009, at 11:05 AM, Adam Barth wrote: Do you have specific areas you're concerned about that we can be on the lookout for? I tried to think this through, but only had a few minutes free: A minor concern is that Frame has a constell

Re: [webkit-dev] Proposal about integer types used in WebKit

2009-07-24 Thread Maciej Stachowiak
On Jul 24, 2009, at 4:18 PM, Geoffrey Garen wrote: In JavaScriptCore, some structures have integer members that must be 32bits in size, regardless of processor type. In those places, int32_t and uint32_t are useful. Less clear to me is whether clients of such structures should also use i

Re: [webkit-dev] Reformatting-only patches being applied to trunk

2009-07-25 Thread Maciej Stachowiak
On Jul 25, 2009, at 2:08 AM, Oliver Hunt wrote: I've just noticed that there have been a few purely style related patches being landed in the tree recently, I don't believe these are a good idea and that any further reformatting only patches be rejected. Historically we have avoided pure

Re: [webkit-dev] status update: webkit gobject bindings [svn r46395]

2009-07-26 Thread Maciej Stachowiak
Let me put it even more strongly. Luke, you need to stop sending long, rambling emails to the list. Many people have complained about both the form and content of your messages, and no one but you has spoken up that they find these emails useful. If you don't have the judgment to determine

Re: [webkit-dev] Calling gc::collect() before the program exits

2009-07-27 Thread Maciej Stachowiak
On Jul 27, 2009, at 12:06 PM, Zoltan Herczeg wrote: Hi, by default, gc::collect() is triggered by a timer at regular intervals. In QtLauncher, gc::collect() is not called in any other way, so the remaining JS objects cause memory leaks when QtLauncher exits. Although this approach may not

Re: [webkit-dev] NeverNull

2009-07-28 Thread Maciej Stachowiak
On Jul 28, 2009, at 3:59 PM, Peter Kasting wrote: On Tue, Jul 28, 2009 at 3:55 PM, Oliver Hunt wrote: Personally i like the idea of having type system/compiler enforced null checking. Note that eseidel's proposal is still a runtime check. One could use template specialization to write a

Re: [webkit-dev] parallel layout research

2009-07-31 Thread Maciej Stachowiak
I think parallel layout is an interesting topic to explore, in light of where CPUs are going. We probably can't use code in Cilk++ directly, but there might be useful ideas. It also seems to me from their paper that they are only handling some of the more basic aspects of CSS layout so fa

Re: [webkit-dev] LayoutTests take too long to run

2009-07-31 Thread Maciej Stachowiak
On Jul 31, 2009, at 10:25 PM, Eric Seidel wrote: 681.70s total testing time That's 11.5 minutes for every patch I want to land. (because I run the layout tests before landing anything, as part of bugzilla-tool). I'm very interested in any suggestions folks have to make that number small

Re: [webkit-dev] JavaScript bindings changed to call scriptExecutionContext virtual function?

2009-08-02 Thread Maciej Stachowiak
On Aug 2, 2009, at 2:44 AM, Adam Barth wrote: On Sun, Aug 2, 2009 at 2:09 AM, Darin Adler wrote: On Aug 2, 2009, at 2:05 AM, Adam Barth wrote: In any case: https://bugs.webkit.org/show_bug.cgi?id=27931 I'll have a patch shortly. Please let me know if there are other call sites you'd

Re: [webkit-dev] Towards a commit-queue

2009-08-03 Thread Maciej Stachowiak
On Aug 1, 2009, at 8:41 PM, Adam Barth wrote: On Sat, Aug 1, 2009 at 1:13 PM, David Kilzer wrote: Either we should change the review process to only set the review+ flag if the patch is ready to go with zero modifications, or we should use the commit+ flag to signify that. I could go eit

Re: [webkit-dev] checking style for patches automatically [was: Calling All Reviewers]

2009-08-07 Thread Maciej Stachowiak
On Aug 7, 2009, at 4:03 PM, David Levin wrote: Running check-webkit-style automatically as an fyi -- maybe during prepare-ChangeLog -- would be cool. Personally, I thought it would be good to let it have a little more time to bake before doing this. Seems like a good idea to run it in an

Re: [webkit-dev] WebKit and Khronos Group

2009-08-08 Thread Maciej Stachowiak
On Aug 8, 2009, at 11:39 AM, Harry Underwood wrote: Thanks for the link. Didn't even know that WebGL is being considered by WebKit. What Oliver showed you is patches to pretty much fully implement it, done by an Apple employee. So we're doing more than considering it. I expect there will

Re: [webkit-dev] WebKit and Khronos Group

2009-08-08 Thread Maciej Stachowiak
09 at 10:02 PM, Jeremy Orlow wrote: On Sat, Aug 8, 2009 at 2:02 PM, Maciej Stachowiak wrote: On Aug 8, 2009, at 11:39 AM, Harry Underwood wrote: Thanks for the link. Didn't even know that WebGL is being considered by WebKit. What Oliver showed you is patches to pretty much fully i

Re: [webkit-dev] WebKit and Khronos Group

2009-08-08 Thread Maciej Stachowiak
Hi Jeremy, On Aug 8, 2009, at 7:02 PM, Jeremy Orlow wrote: I'm not personally involved in the WebGL or O3D efforts, but I can speak to some of this. I agree that O3D and WebGL are more similar to each other than the CSS 3D transforms. Both are fairly low level, though they take fairl

Re: [webkit-dev] Fwd: WebKit and Khronos Group

2009-08-09 Thread Maciej Stachowiak
On Aug 8, 2009, at 11:58 PM, Harry Underwood wrote: Thanks very much for the explanations, everyone. Sorry about the long chain of questions, but I wanted to form a FAQ-type basis for future questions regarding the difference between what Apple and WebKit are doing with SVG+CSS and what Go

Re: [webkit-dev] Documenting common null pointer errors

2009-08-11 Thread Maciej Stachowiak
On Aug 11, 2009, at 3:03 PM, Adam Barth wrote: In reviewing patches, I feel like I'm commonly pointing out DOMWindow::frame and Document::frame, etc, can be null in some circumstances. Would it be useful to have a diagram of the major objects (Page, Frame, DOMWindow, Document, etc) somewhere o

Re: [webkit-dev] No more build breaks.

2009-08-17 Thread Maciej Stachowiak
Hi Mark, I think this was a needlessly rude way to address the issue. Please try to keep things courteous on webkit-dev. Your most important point, i.e. that 'bugzilla-tool land-diff' is really at "early adopter" maturity and not at "everyone should use it" maturity, was much more clear i

Re: [webkit-dev] About events in WebCore

2009-08-18 Thread Maciej Stachowiak
On Aug 18, 2009, at 5:46 PM, Michelangelo De Simone wrote: Hi, I've been working to add support for the checkValidity() method on (#27452); in order to complete that check I need to understand whether or not a specific event (invalid), previously fired from an element, has been canceled. Now,

Re: [webkit-dev] svn-* scripts

2009-08-21 Thread Maciej Stachowiak
On Aug 21, 2009, at 6:15 PM, Jeremy Orlow wrote: On Fri, Aug 21, 2009 at 5:57 PM, Joseph Pecoraro wrote: On Aug 21, 2009, at 8: 32PM, Darin Adler wrote: I’m a little irritated that we’re changing our Subversion scripts, svn-create-patch, svn-apply, and svn-unapply into WebKit-specific sc

Re: [webkit-dev] Security advice for linux browsers based on WebKit

2009-08-24 Thread Maciej Stachowiak
Hi Adam, I think it's probably possible to change the default on all platforms other than Mac. I do not believe the compatibility issues we're concerned about for Mac affect any other port. I think this would be a good choice. For what it's worth, NFS/AFS automounting also affects many Ma

[webkit-dev] Implementation thoughts on HTML5 elements

2009-08-25 Thread Maciej Stachowiak
Hi everyone, Recently at Apple we've been considering our plans to implement new HTML elements from HTML5. I'd like to share our thoughts with the WebKit community and see if we are in sync before passing this on to the HTML Working Group. Does anyone have thoughts to add to the below: --

Re: [webkit-dev] Implementation thoughts on HTML5 elements

2009-08-25 Thread Maciej Stachowiak
On Aug 25, 2009, at 11:29 PM, Peter Kasting wrote: On Tue, Aug 25, 2009 at 11:21 PM, Maciej Stachowiak wrote: - new element types These seem generally useful, and we already have some implemented to various extents (search, range, email, url tel). The only concern is the sheer number

Re: [webkit-dev] Implementation thoughts on HTML5 elements

2009-08-25 Thread Maciej Stachowiak
On Aug 25, 2009, at 11:21 PM, Maciej Stachowiak wrote: Hi everyone, Recently at Apple we've been considering our plans to implement new HTML elements from HTML5. I'd like to share our thoughts with the WebKit community and see if we are in sync before passing this on to the HT

Re: [webkit-dev] How to handle Array types in IDL files?

2009-08-25 Thread Maciej Stachowiak
On Aug 25, 2009, at 11:43 PM, Drew Wilson wrote: I'm trying to update MessageEvent to match the current HTML5 spec. Currently, MessageEvent has two references to MessagePort: readonly attribute MessagePort messagePort; void initMessageEvent(in DOMString typeArg, in boolean

Re: [webkit-dev] Implementation thoughts on HTML5 elements

2009-08-26 Thread Maciej Stachowiak
gards, Maciej - Leo Maciej Stachowiak wrote: On Aug 25, 2009, at 11:21 PM, Maciej Stachowiak wrote: Hi everyone, Recently at Apple we've been considering our plans to implement new HTML elements from HTML5. I'd like to share our thoughts with the WebKit community and see if

Re: [webkit-dev] Implementation thoughts on HTML5 elements

2009-08-26 Thread Maciej Stachowiak
Web, and align with ARIA landmark roles. So I don't entirely agree with your feedback, but I think you should bring it up in the appropriate forum. - Maciej - Leo Maciej Stachowiak wrote: On Aug 26, 2009, at 12:04 AM, Leo Meyerovich wrote: These are unnecessary features wrt

Re: [webkit-dev] Implementation thoughts on HTML5 elements

2009-08-26 Thread Maciej Stachowiak
On Aug 26, 2009, at 10:47 AM, Ojan Vafai wrote: On Tue, Aug 25, 2009 at 11:45 PM, Maciej Stachowiak wrote: On Aug 25, 2009, at 11:21 PM, Maciej Stachowiak wrote: Hi everyone, Recently at Apple we've been considering our plans to implement new HTML elements from HTML5. I'd lik

Re: [webkit-dev] How to handle Array types in IDL files?

2009-08-26 Thread Maciej Stachowiak
? Sam? -atw On Wed, Aug 26, 2009 at 12:34 AM, Cameron McCormack wrote: Maciej Stachowiak: > We probably need special support for Web IDL array types in the > bindings generator. Sam can probably comment n more detail. As a > stopgap, we could make the relevant IDL attributes be JS o

Re: [webkit-dev] Implementation thoughts on HTML5 elements

2009-08-26 Thread Maciej Stachowiak
On Aug 26, 2009, at 3:07 PM, Peter Kasting wrote: On Wed, Aug 26, 2009 at 3:04 PM, Michelangelo De Simone > wrote: speaking about type=email a UI element which fetches email addresses from user's address book seems a happy choice to me. Consider that if the user uses a web mail app (e.g. Gmail

Re: [webkit-dev] I *HATE* CHANGELOGS!!!

2009-08-26 Thread Maciej Stachowiak
On Aug 26, 2009, at 3:37 PM, David Hyatt wrote: If the files could just merge properly, I would not be so annoyed, but the fact that you basically have to re-resolve conflicts every time anyone beats you to a checkin is just horrible. Surely other people run into this. It wastes time for

Re: [webkit-dev] Implementation thoughts on HTML5 elements

2009-08-26 Thread Maciej Stachowiak
On Aug 26, 2009, at 3:36 PM, Peter Kasting wrote: On Wed, Aug 26, 2009 at 3:34 PM, Maciej Stachowiak wrote: I'd like to see the Mac port of WebKit offer completion based on the system address book. I think a lot of the times when you enter an email address on the Web, it's o

Re: [webkit-dev] I *HATE* CHANGELOGS!!!

2009-08-26 Thread Maciej Stachowiak
On Aug 26, 2009, at 5:38 PM, Geoffrey Garen wrote: Detailed descriptions, bug links, test instructions, and a link back to the entire original review history are all part of Chromium commits, yet we don't use ChangeLogs. I think discipline about what to include + tooling to support it are

Re: [webkit-dev] GlobalScript API.

2009-08-31 Thread Maciej Stachowiak
On Aug 31, 2009, at 6:09 PM, Dmitry Titov wrote: Hi WebKit-dev, I'm hoping to get your advice on Global Script proposal and how to start implementing it as an 'experimental API' since it's not standardized yet. As part of work on Workers in WebKit and Chromium, we discussed them with o

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-09-01 Thread Maciej Stachowiak
On Sep 1, 2009, at 12:59 PM, Adam Roben wrote: On Jul 9, 2009, at 4:32 AM, Maciej Stachowiak wrote: How about this as the canonical format (with prepare-ChangeLog encouraging it)? 2009-07-08 Maciej Stachowiak Make prepare-ChangeLog less shouty https://bugs.webkit.org

Re: [webkit-dev] GlobalScript API.

2009-09-01 Thread Maciej Stachowiak
On Mon, Aug 31, 2009 at 7:18 PM, Maciej Stachowiak wrote: On Aug 31, 2009, at 6:09 PM, Dmitry Titov wrote: Hi WebKit-dev, I'm hoping to get your advice on Global Script proposal and how to start implementing it as an 'experimental API' since it's not standardized

Re: [webkit-dev] Qtish API for JavaScriptCore

2009-09-02 Thread Maciej Stachowiak
On Sep 1, 2009, at 10:40 AM, Oliver Hunt wrote: The debugger is not API, and should not be depended upon. If you are interacting with the debugger you are not using the JSC API, and so you will not be able to rely on JSC not changing and breaking your API. That's perfectly understanda

Re: [webkit-dev] Qtish API for JavaScriptCore

2009-09-02 Thread Maciej Stachowiak
On Aug 27, 2009, at 4:44 PM, Geoffrey Garen wrote: I think it's very hard to know, a priori, what will and will not be efficiently supportable going forward. Personally, I've been very surprised more than once. The advantage of the C API is that we've already signed up to support it. So,

Re: [webkit-dev] mod_pywebsocket for testing Web Socket implementation

2009-09-07 Thread Maciej Stachowiak
On Sep 7, 2009, at 10:00 PM, Mark Rowe wrote: Python starting with v2.6 has reasonable built-in support for SSL servers. This is the version that ships with Mac OS X 10.6. Mac OS X 10.5 ships with Python 2.5 (predating this built-in support) but includes pyOpenSSL. Mac OS X 10.4 ship

Re: [webkit-dev] mod_pywebsocket for testing Web Socket implementation

2009-09-07 Thread Maciej Stachowiak
On Sep 7, 2009, at 10:41 PM, Yuzo Fujishima wrote: Building and installing some Apache modules doesn't seem like that big a deal to me, if it would really make testing more practical. However, it seems like using a premade websocket server implementation would make some forms of testin

Re: [webkit-dev] Support sending multiple files via XMLHttpRequest.send()

2009-09-08 Thread Maciej Stachowiak
On Sep 8, 2009, at 6:16 PM, Jian Li wrote: In WebKit, XMLHttpRequest.send() supports sending single file. It would be better if we can support sending multiple files, like FileList (see bug 25923). In addition, XMLHttpRequest.send() only sends the raw content of the file, without includi

Re: [webkit-dev] Support sending multiple files via XMLHttpRequest.send()

2009-09-08 Thread Maciej Stachowiak
On Sep 8, 2009, at 10:49 PM, Darin Fisher wrote: On Tue, Sep 8, 2009 at 6:22 PM, Maciej Stachowiak wrote: On Sep 8, 2009, at 6:16 PM, Jian Li wrote: In WebKit, XMLHttpRequest.send() supports sending single file. It would be better if we can support sending multiple files, like

Re: [webkit-dev] Back/forward cache for pages with unload handlers

2009-09-09 Thread Maciej Stachowiak
On Sep 9, 2009, at 4:07 PM, Brady Eidson wrote: -Many are designed to do the same work in the pagehide handler under Firefox. Does Firefox apply back/forward caching to pages with an "unload" listener? Regards, Maciej ___ webkit-dev mailing

Re: [webkit-dev] Back/forward cache for pages with unload handlers

2009-09-09 Thread Maciej Stachowiak
On Sep 9, 2009, at 7:11 PM, Brady Eidson wrote: On Sep 9, 2009, at 6:51 PM, Maciej Stachowiak wrote: On Sep 9, 2009, at 4:07 PM, Brady Eidson wrote: -Many are designed to do the same work in the pagehide handler under Firefox. Does Firefox apply back/forward caching to pages with an

Re: [webkit-dev] Passing data structures through postMessage()

2009-09-10 Thread Maciej Stachowiak
On Sep 10, 2009, at 3:12 PM, Chris Campbell wrote: Hi All, I had it in mind to implement support for passing data structures through postMessage() using the "structured clone" algorithm laid out in the HTML5 spec: http://dev.w3.org/html5/spec/Overview.html#posting-messages http://dev.w3.org/h

Re: [webkit-dev] Attaching Additional Semantics to Markup

2009-09-16 Thread Maciej Stachowiak
On Sep 15, 2009, at 10:55 PM, Alex Milowski wrote: I'm curious to see if there is someway an "plugin" or "extension" can be added to a WebKit-based browser to add additional semantics for certain content without going over to the "browser host" side of things? For example, I'd like users t

[webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-16 Thread Maciej Stachowiak
On Sep 16, 2009, at 11:23 AM, Geoffrey Garen wrote: Given some of our (Chromium-team) recent investigation into the contents of unload handlers, I'm not sure how much this move will help users, even if you don't revert it. Lots of unload handlers busy-wait while doing async XHR in order t

<    3   4   5   6   7   8   9   10   11   12   >