Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/explain-logs into lp:zeitgeist

2010-09-14 Thread Markus Korn
Review: Approve Looks good, and it does not have to be perfect as it is for internal use only, but I'd like to avoid the 'print' statement and put it in a logging statement. This way it would be possible to redirect logging output of the 'zeitgeist.sql' domain to some file etc. Proposed diff:

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/explain-logs into lp:zeitgeist

2010-09-14 Thread Markus Korn
I'm not sure, but maybe the queries are more readable if we replace '?' by the actual values: === modified file '_zeitgeist/engine/sql.py' --- _zeitgeist/engine/sql.py2010-09-13 20:55:00 + +++ _zeitgeist/engine/sql.py2010-09-14 07:40:46 + @@ -38,9 +38,11 @@ def explain_query(c

[Zeitgeist] [Merge] lp:~thekorn/zeitgeist/handle-SIGHUP into lp:zeitgeist

2010-09-15 Thread Markus Korn
Markus Korn has proposed merging lp:~thekorn/zeitgeist/handle-SIGHUP into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) Added a way to shutdown the zeitgeist-daemon in a clean way by sending a SIGHUP signal to the process (as described in [0]) [0] http

[Zeitgeist] [Bug 640277] [NEW] Bad documentation of zeitgeist.datamodel.Symbol

2010-09-16 Thread Markus Korn
Public bug reported: The documentation of the Symbol class is in a bad state. It is so bad that it is currently not shown in our public API docs. This class has not docstring, and has a few (important) undocumented method, we should fix this. Also we should remove the __doc__ property. This ugly

[Zeitgeist] [Bug 634055] Re: documentation of our ontology is hardly readable

2010-09-16 Thread Markus Korn
revno: 1581 [merge] fixes bug(s): https://launchpad.net/bugs/634055 committer: Markus Korn branch nick: trunk timestamp: Thu 2010-09-16 10:19:58 +0200 message: Out ontology is now documented in a table format, which is a bit less

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/sqlite-insert-improvements into lp:zeitgeist

2010-09-16 Thread Markus Korn
Review: Disapprove Seif, before experimenting with some weird PRAGMA settings I would like to discuss this more with the whole team, let's move discussions to the bugreport. -- https://code.launchpad.net/~zeitgeist/zeitgeist/sqlite-insert-improvements/+merge/35701 Your team Zeitgeist Framework Te

[Zeitgeist] [Bug 639737] Re: Improve insertion times

2010-09-16 Thread Markus Korn
Seif, before making inserts faster I would like to understand why they are so slow right now. The last step should be to actually add some PRAGMA optimizations, which have, as you already mentioned some downsides. In order to get a better picture of what's going on, can you please try to get some

Re: [Zeitgeist] [Merge] lp:~seif/zeitgeist/improve-big-inserts into lp:zeitgeist

2010-09-16 Thread Markus Korn
Seif, I agree with you, reducing .commit() calls is a good idea, and as far as I can see it's safe to remove the .commit() calls in _insert_event, given that we never call _insert_event directly, .insert_events() is the way to go. And it is always guaranteed that the single .commit() in insert_e

[Zeitgeist] [Bug 641100] Re: ZeitgeistEngine.__init__(): statement to get last row id is not using the index

2010-09-17 Thread Markus Korn
** Attachment added: "min-max-test.py" https://bugs.edge.launchpad.net/bugs/641100/+attachment/1597228/+files/min-max-test.py -- ZeitgeistEngine.__init__(): statement to get last row id is not using the index https://bugs.launchpad.net/bugs/641100 You received this bug notification because y

[Zeitgeist] [Bug 641100] [NEW] ZeitgeistEngine.__init__(): statement to get last row id is not using the index

2010-09-17 Thread Markus Korn
Public bug reported: The attached script is creating a log with ~49k events. In the constructor of ZeitgeistEngine we need to search for the minimum and maximum event id. In the script I'm doing two different ways of getting these values: Our current query: SELECT MIN(id), MAX(id) FROM event -

[Zeitgeist] [Merge] lp:~thekorn/zeitgeist/fix-641100-min-max-use-index into lp:zeitgeist

2010-09-17 Thread Markus Korn
Markus Korn has proposed merging lp:~thekorn/zeitgeist/fix-641100-min-max-use-index into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) Related bugs: #641100 ZeitgeistEngine.__init__(): statement to get last row id is not using the index https://bugs.launchpad.net

[Zeitgeist] [Bug 641100] Re: ZeitgeistEngine.__init__(): statement to get last row id is not using the index

2010-09-17 Thread Markus Korn
** Changed in: zeitgeist Assignee: (unassigned) => Markus Korn (thekorn) ** Changed in: zeitgeist Status: New => In Progress -- ZeitgeistEngine.__init__(): statement to get last row id is not using the index https://bugs.launchpad.net/bugs/641100 You received this bug notifi

[Zeitgeist] [Bug 641198] Re: Prefix search is not using an index

2010-09-17 Thread Markus Korn
** Attachment added: "glob-index-test.py" https://bugs.edge.launchpad.net/bugs/641198/+attachment/1597664/+files/glob-index-test.py ** Changed in: zeitgeist Status: New => In Progress ** Changed in: zeitgeist Assignee: (unassigned) => Markus Korn (thekorn) --

[Zeitgeist] [Bug 641198] [NEW] Prefix search is not using an index

2010-09-17 Thread Markus Korn
for ascii chars, but as we support unicode esp. testing seems to be a bit tricky ** Affects: zeitgeist Importance: Undecided Assignee: Markus Korn (thekorn) Status: In Progress -- Prefix search is not using an index https://bugs.launchpad.net/bugs/641198 You received this bug noti

Re: [Zeitgeist] [Merge] lp:~thekorn/zeitgeist/fix-641100-min-max-use-index into lp:zeitgeist

2010-09-17 Thread Markus Korn
Mikkel, thanks for doing the review, yes, the case of an empty db is covered by our unittests and everything works just fine. ( MIN/MAX always return sth. even if the table it's operating on is empty In [7]: con = sqlite3.connect(":memory:") In [8]: con.execute("CREATE TABLE boo(x)") Out[8]:

[Zeitgeist] [Bug 641100] Re: ZeitgeistEngine.__init__(): statement to get last row id is not using the index

2010-09-17 Thread Markus Korn
** Changed in: zeitgeist Status: In Progress => Fix Committed -- ZeitgeistEngine.__init__(): statement to get last row id is not using the index https://bugs.launchpad.net/bugs/641100 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscrib

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/pragma-settings into lp:zeitgeist

2010-09-18 Thread Markus Korn
I've another question: doesn't this change justify a boost of our db scheme version? -- https://code.launchpad.net/~zeitgeist/zeitgeist/pragma-settings/+merge/35833 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~zeitgeist/zeitgeist/pragma-settings into lp:zei

[Zeitgeist] [Bug 641621] Re: Add event_id to the debug verbose output at command line

2010-09-18 Thread Markus Korn
Hi Manish, I don't think this is a good idea. Take your second scenario as an example, in this case the output would contain 13 ids, which makes the logging output hard to read. If you want to get notified if (and which events) get inserted you can always write a tiny Monitor you can connect to

[Zeitgeist] [Bug 641968] [NEW] querying on LeastRecentActor for a certain subject_uri is not working

2010-09-18 Thread Markus Korn
Public bug reported: Scenario: I would like to know which actor touched a file with uri="home/boo" least recently. This query should do the job: >>> template = Event.new_for_values(subject_uri="home/boo") >>> ids = engine.find_eventids(TimeRange.always(), [template, ], >>> StorageState.Any, 0, R

[Zeitgeist] [Bug 641968] Re: querying on LeastRecentActor for a certain subject_uri is not working

2010-09-18 Thread Markus Korn
** Attachment added: "reproducer.py" https://bugs.edge.launchpad.net/bugs/641968/+attachment/1601980/+files/reproducer.py -- querying on LeastRecentActor for a certain subject_uri is not working https://bugs.launchpad.net/bugs/641968 You received this bug notification because you are a membe

[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/pragma-settings into lp:zeitgeist

2010-09-19 Thread Markus Korn
The proposal to merge lp:~zeitgeist/zeitgeist/pragma-settings into lp:zeitgeist has been updated. Status: Needs review => Merged -- https://code.launchpad.net/~zeitgeist/zeitgeist/pragma-settings/+merge/35833 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist

[Zeitgeist] [Bug 642686] [NEW] Add subj_uri_id and subj_origin_id columns to event_view

2010-09-19 Thread Markus Korn
Public bug reported: If we add subj_uri_id and subj_origin_id columns to the event_view we could make the prefix searches about 10% faster. Combined with the upcoming optimization of the GLOB statement it will be possible to reduce the avg. time for this kind of queries from ~0.20s to ~0.12s. As

[Zeitgeist] [Bug 642686] Re: Add subj_uri_id and subj_origin_id columns to event_view

2010-09-19 Thread Markus Korn
** Attachment added: "test_new_event_view.py" https://bugs.edge.launchpad.net/bugs/642686/+attachment/1607450/+files/test_new_event_view.py -- Add subj_uri_id and subj_origin_id columns to event_view https://bugs.launchpad.net/bugs/642686 You received this bug notification because you are a

[Zeitgeist] [Bug 642686] Re: Add subj_uri_id and subj_origin_id columns to event_view

2010-09-19 Thread Markus Korn
** Changed in: zeitgeist Assignee: (unassigned) => Markus Korn (thekorn) ** Changed in: zeitgeist Status: New => In Progress -- Add subj_uri_id and subj_origin_id columns to event_view https://bugs.launchpad.net/bugs/642686 You received this bug notification because you are a

[Zeitgeist] [Merge] lp:~thekorn/zeitgeist/fix-642686-eventview-add-origin-and-uri-id into lp:zeitgeist

2010-09-19 Thread Markus Korn
Markus Korn has proposed merging lp:~thekorn/zeitgeist/fix-642686-eventview-add-origin-and-uri-id into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) Related bugs: #642686 Add subj_uri_id and subj_origin_id columns to event_view https://bugs.launchpad.net/bugs

[Zeitgeist] [Bug 642686] Re: Add subj_uri_id and subj_origin_id columns to event_view

2010-09-19 Thread Markus Korn
** Changed in: zeitgeist Status: In Progress => Fix Committed -- Add subj_uri_id and subj_origin_id columns to event_view https://bugs.launchpad.net/bugs/642686 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framewo

[Zeitgeist] [Bug 642803] [NEW] Today's updates to lp:zeitgeist broke event_view

2010-09-19 Thread Markus Korn
st/../_zeitgeist/engine/sql.py", line 59, in execute return super(UnicodeCursor, self).execute(statement, parameters) OperationalError: no such column: subj_uri_id ** Affects: zeitgeist Importance: Critical Assignee: Markus Korn (thekorn) Status: In Progress *

[Zeitgeist] [Bug 642772] Re: WAL and event_view changes requires schema upgrade

2010-09-19 Thread Markus Korn
Hi Mikkel, I'm sorry, number two on your list is definitely my bad. I did not know that this "DROP VIEW [...]" line has no effect, and I also did not test my changes on an already existing database. My changes are indeed not working as I expect them to work. I'll work on fixing the issue in bug

[Zeitgeist] [Bug 642803] Re: Today's updates to lp:zeitgeist broke event_view

2010-09-19 Thread Markus Korn
** Changed in: zeitgeist Status: In Progress => Fix Committed -- Today's updates to lp:zeitgeist broke event_view https://bugs.launchpad.net/bugs/642803 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Sta

[Zeitgeist] [Bug 642898] [NEW] Upgrading database scheme is broken for newly created databases

2010-09-19 Thread Markus Korn
for upgrades) ** Affects: zeitgeist Importance: Critical Assignee: Markus Korn (thekorn) Status: In Progress ** Changed in: zeitgeist Status: New => In Progress ** Changed in: zeitgeist Importance: Undecided => Critical ** Changed in: zeitgeist

[Zeitgeist] [Bug 642898] Re: Upgrading database scheme is broken for newly created databases

2010-09-19 Thread Markus Korn
There are two possible solutions for this issue: 1.) check if we are operating on an empty database 2.) change our upgrade function in a way that if a upgrade script is not found for X -> Z it tries to run X -> Y -> Z For 1.) there are two possible ways: 1.a.) check if file already exists before

[Zeitgeist] [Bug 642898] Re: Upgrading database scheme is broken for newly created databases

2010-09-20 Thread Markus Korn
revno: 1595 fixes bug(s): https://launchpad.net/bugs/642898 committer: Markus Korn branch nick: trunk timestamp: Mon 2010-09-20 09:29:32 +0200 message: always create core schema for new databases (LP: #642898

[Zeitgeist] [Bug 643303] [NEW] Upgrade of the db schema strategy for version jumps

2010-09-20 Thread Markus Korn
Public bug reported: We have to discuss how to support versions jump in the upgrade path of our db schema, like from ("core", 0) to ("core", 2). This becomes even more important when we reach the next version. For me there are two solution: 1.) write 'dummy' upgrade scripts, like core_0_2.py, whi

[Zeitgeist] [Bug 397715] Re: I18N of zeitgeist

2010-09-20 Thread Markus Korn
I discussed this issue with Siegfried yesterday, and I would like to bring the overall translation workflow to everybody's attention again: * We want to make our ontology 'symbols' translatable * logging output should not be translated * we might need translation support for tools in tools/ *

[Zeitgeist] [Bug 634740] Re: explicitly define on a per testcase basis which extension needs to be loaded

2010-09-20 Thread Markus Korn
In fact we should make sure that no non-core extension ever influence our testsuite, testing of 3rd party extensions should be done on their side. ** Changed in: zeitgeist Assignee: (unassigned) => Markus Korn (thekorn) ** Changed in: zeitgeist Status: New => In Pr

[Zeitgeist] [Merge] lp:~thekorn/zeitgeist/fix-641198-glob-use-index into lp:zeitgeist

2010-09-21 Thread Markus Korn
Markus Korn has proposed merging lp:~thekorn/zeitgeist/fix-641198-glob-use-index into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) Related bugs: #641198 Prefix search is not using an index https://bugs.launchpad.net/bugs/641198 This branch is speed optimizing the

[Zeitgeist] [Bug 634744] Re: test suite fails if zeitgeist is installed on the system

2010-09-21 Thread Markus Korn
** Branch linked: lp:~thekorn/zeitgeist/fix-634740-634744-testrunner- improvements ** Changed in: zeitgeist Status: New => In Progress ** Changed in: zeitgeist Assignee: (unassigned) => Markus Korn (thekorn) -- test suite fails if zeitgeist is installed on the system

[Zeitgeist] [Bug 634740] Re: explicitly define on a per testcase basis which extension needs to be loaded

2010-09-21 Thread Markus Korn
** Branch linked: lp:~thekorn/zeitgeist/fix-634740-634744-testrunner- improvements -- explicitly define on a per testcase basis which extension needs to be loaded https://bugs.launchpad.net/bugs/634740 You received this bug notification because you are a member of Zeitgeist Framework Team, which

[Zeitgeist] [Merge] lp:~thekorn/zeitgeist/fix-634740-634744-testrunner-improvements into lp:zeitgeist

2010-09-21 Thread Markus Korn
Markus Korn has proposed merging lp:~thekorn/zeitgeist/fix-634740-634744-testrunner-improvements into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) Related bugs: #634740 explicitly define on a per testcase basis which extension needs to be loaded https

[Zeitgeist] [Bug 641198] Re: Prefix search is not using an index

2010-09-22 Thread Markus Korn
New version of the test script, run this script in lp:zeitgeist and in the attached branch, compare the last line of the output, the attached branch should be about 8-10% faster ** Attachment added: "glob-index-test_v2.py" https://bugs.edge.launchpad.net/zeitgeist/+bug/641198/+attachment/16216

[Zeitgeist] [Bug 641968] Re: querying on LeastRecentActor and MostRecentActor for a certain subject_uri is not working

2010-09-23 Thread Markus Korn
I'm removing the attached branch, since the initial issue is not fixed by this changes (maybe indirectly= ** Branch unlinked: lp:~seif/zeitgeist/fix-641968 ** Changed in: zeitgeist Status: In Progress => Confirmed -- querying on LeastRecentActor and MostRecentActor for a certain subject_

[Zeitgeist] [Bug 646124] Re: Wrong understanding of the LeastRecentActors

2010-09-24 Thread Markus Korn
Seif, can you please give tow different usecases, one for the old definition of LeastRecentActors and one for your new one. Please also try to explain how changing the definition will influence real world usecases. -- Wrong understanding of the LeastRecentActors https://bugs.launchpad.net/bugs/64

[Zeitgeist] [Bug 646124] Re: Wrong understanding of the LeastRecentActors

2010-09-24 Thread Markus Korn
Ok, maybe there were some misunderstandings, I was looking for some real life questions... Let's assume this one: "What were the first three actors accessing '/home/markus/seif.txt'" With the current definition of LeastRecentActors the query would look like >>> template = Event.new_for_values(

[Zeitgeist] [Bug 646124] Re: Wrong understanding of the LeastRecentActors

2010-09-24 Thread Markus Korn
We discussed this issue on IRC, a summary: * the current definition of LeastRecentActors is wrong, it should be "application I have not used for the longest time" * we need a new ResultType for the old definition ("The first event of each different actor"), something like OldestActor The plan

[Zeitgeist] [Merge] lp:~thekorn/zeitgeist/fix-650930-opt-complete-timerange into lp:zeitgeist

2010-09-29 Thread Markus Korn
Markus Korn has proposed merging lp:~thekorn/zeitgeist/fix-650930-opt-complete-timerange into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) Related bugs: #650930 Make timestamp related queries faster https://bugs.launchpad.net/bugs/650930 If FindEvents-queries are

[Zeitgeist] [Bug 650930] [NEW] Make timestamp related queries faster

2010-09-29 Thread Markus Korn
this time to ---> MostPopularActor: get len(ids)=6 using .find_eventids() in 0.069161s ** Affects: zeitgeist Importance: Undecided Assignee: Markus Korn (thekorn) Status: In Progress -- Make timestamp related queries faster https://bugs.launchpad.net/bugs/650930 You received this

[Zeitgeist] [Bug 650930] Re: Make timestamp related queries faster

2010-09-29 Thread Markus Korn
** Attachment added: "search_application_test.py" https://bugs.edge.launchpad.net/bugs/650930/+attachment/1652420/+files/search_application_test.py ** Changed in: zeitgeist Status: New => In Progress ** Changed in: zeitgeist Assignee: (unassigned) => Mark

[Zeitgeist] [Bug 650930] Re: Make timestamp related queries faster

2010-09-29 Thread Markus Korn
Once this fix has landed, I see even ways to improve time based queries if they are not using the cornercase "complete TimeRange", but we shouldn't take the second step before the first one... -- Make timestamp related queries faster https://bugs.launchpad.net/bugs/650930 You received this bug no

[Zeitgeist] [Bug 650930] Re: Make timestamp related queries faster

2010-09-29 Thread Markus Korn
** Changed in: zeitgeist Status: In Progress => Fix Committed -- Make timestamp related queries faster https://bugs.launchpad.net/bugs/650930 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeit

[Zeitgeist] [Bug 624310] Re: Large requests increase memory usage considerably

2010-10-02 Thread Markus Korn
As far as I remember, the main reason why we dropped this iterator thing being part of our API redisign efforts a year ago was that there is no easy (and performant) way to do batched database queries. The problem is: we don't have a 'stable' order of events, just think of a query which returns

[Zeitgeist] [Bug 624310] Re: Large requests increase memory usage considerably

2010-10-05 Thread Markus Korn
I've made some tests tonight, on an activitylog with 18k random web history events. The in memory size of the daemon is about 7MiB on startup. After running FindEvents(TimeRange.until_now(), [],StorageState.Any, 0,1) (same query is used by sezen *over and over again*) the daemon's memory consump

[Zeitgeist] [Bug 655164] Re: Support more ResultType

2010-10-06 Thread Markus Korn
** Description changed: I am in discussion with the Software Center team and it seems like they are growing fond of Zeitgeist. There is a feature in their queue that they would like to implement and where Zeitgeist can make it happen: - Software Center wants to suggest applications to be i

[Zeitgeist] [Bug 655164] Re: Support more ResultType

2010-10-06 Thread Markus Korn
Having such ResultTypes sounds reasonable to me, but let's ignore the implementation details for now, and think about the `Support more ResultType` topic a bit more: This bugreport made me realize that the ResultType system as we have it right now does not scale very well. Right now we have 15 d

[Zeitgeist] [Bug 655164] Re: Support more ResultType

2010-10-06 Thread Markus Korn
One way which just came into my mind to make things easier to understand is to use a flag system, like MostRecent = 0x01 LeastRecent = 0x02 MostPopular = 0x04 LeastPopular = 0x08 [...] Events = 0x0100 Subjects = 0x0200 Actor = 0x0400 [...] This way the ResultTypes we have right now can be written

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fix-655164 into lp:zeitgeist

2010-10-11 Thread Markus Korn
I did not have time yet to check if the tests make sense, but let me give you a few comments first: > === modified file '_zeitgeist/engine/main.py' > --- _zeitgeist/engine/main.py   2010-09-29 08:39:32 + > +++ _zeitgeist/engine/main.py   2010-10-10 14:57:44 + > @@ -370,7 +370,15 @@ >    

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/fix-655164 into lp:zeitgeist

2010-10-12 Thread Markus Korn
Review: Approve code, unittests Hi Seif, thanks for working on this. It's looking good and all tests are working fine. Feel free to do the merge. Markus -- https://code.launchpad.net/~zeitgeist/zeitgeist/fix-655164/+merge/38077 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeit

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/remove-datahub into lp:zeitgeist

2010-10-14 Thread Markus Korn
Hi Seif, thanks for working on this. But why are you proposing branch to be merged into lp:zeitgeist although they are obviously not working. A simple "./zeitgeist-daemon" and a close look to zeitgeist-daemon.py will show you at least two *very* obvious errors. I personally don't find it motiva

[Zeitgeist] [Bug 660415] [NEW] zeitgeist-daemon has a bad code structure

2010-10-14 Thread Markus Korn
Public bug reported: The code of zeitgeist-daemon is very hard to read, let's restructure the code! (This is more like a reminder for myself to work on it, but I would like to fix it after bug #655164 has been fixed) ** Affects: zeitgeist Importance: Undecided Assignee: Markus

[Zeitgeist] [Bug 660423] [NEW] add `make run` targets to rootlevel Makefile

2010-10-14 Thread Markus Korn
Public bug reported: While working on some changes in zeitgeist-daemon.py I realized that testing changes to the actual zeitgeist-daemon is hard, I always have to remember to run make && ./zeitgeist-daemon The `make run` target should do the right thing and simply wrap the command above. **

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/remove-datahub into lp:zeitgeist

2010-10-14 Thread Markus Korn
Seif, that's looking much better ;) I could not find you on irc, so I did a few changes to zeitgeist-daemon.py which came into my mind while reading the code, please contact me if you think they don't make sense... -- https://code.launchpad.net/~zeitgeist/zeitgeist/remove-datahub/+merge/38339 Yo

[Zeitgeist] [Bug 660415] Re: zeitgeist-daemon has a bad code structure

2010-10-14 Thread Markus Korn
small note to self: check if using glib.spawn_async() instead of subprocess.Popen() to launch the datahub makes sense (is it consuming less memory? is it easier to react on datahub failures?) -- zeitgeist-daemon has a bad code structure https://bugs.launchpad.net/bugs/660415 You received this bug

[Zeitgeist] [Bug 660440] [NEW] Using logging output for debugging purposes

2010-10-14 Thread Markus Korn
Public bug reported: Right now, whenever we get a bugreport from a user who is zeitgeist `indirectly` (via unity, gnome-activity-journal, ...) we have to ask the reporter to "open a terminal, run zeitgeist-daemon, do your usual stuff, get us the logging output" This is not optimal, as we a requ

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/remove-datahub into lp:zeitgeist

2010-10-15 Thread Markus Korn
Review: Approve All tests are running fine, zeitgeist-daemon is looking good, and it seems to me that you managed to remove everything related to the old datahub, Good work. -- https://code.launchpad.net/~zeitgeist/zeitgeist/remove-datahub/+merge/38339 Your team Zeitgeist Framework Team is subscr

[Zeitgeist] [Merge] lp:~thekorn/zeitgeist/fix-660423-make-run into lp:zeitgeist

2010-10-15 Thread Markus Korn
Markus Korn has proposed merging lp:~thekorn/zeitgeist/fix-660423-make-run into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) Related bugs: #660423 add `make run` targets to rootlevel Makefile https://bugs.launchpad.net/bugs/660423 Added `make run` target to the

[Zeitgeist] [Bug 660423] Re: add `make run` targets to rootlevel Makefile

2010-10-15 Thread Markus Korn
** Changed in: zeitgeist Status: New => Fix Committed -- add `make run` targets to rootlevel Makefile https://bugs.launchpad.net/bugs/660423 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitg

[Zeitgeist] [Bug 660423] Re: add `make run` targets to rootlevel Makefile

2010-10-15 Thread Markus Korn
revno: 1618 fixes bug(s): https://launchpad.net/bugs/660423 committer: Markus Korn branch nick: trunk timestamp: Fri 2010-10-15 17:36:02 +0200 message: Added `make run` target to the rootlevel Makefile (LP: #660423

[Zeitgeist] [Merge] lp:~thekorn/zeitgeist/fix-660415-improve-zeitgeist-daemon into lp:zeitgeist

2010-10-20 Thread Markus Korn
Markus Korn has proposed merging lp:~thekorn/zeitgeist/fix-660415-improve-zeitgeist-daemon into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) Related bugs: #660415 zeitgeist-daemon.py has a bad code structure https://bugs.launchpad.net/bugs/660415 zeitgeist

[Zeitgeist] [Bug 660440] Re: Using logging output for debugging purposes

2010-10-20 Thread Markus Korn
whatever namingconventions we use, we should make sure to use some kind of log rotate, to not spam the user with tons of log files. I think keeping the last 3 log files is enough. For our avg. user this means we have the logs of 3 sessions. -- Using logging output for debugging purposes https://

[Zeitgeist] [Bug 660415] Re: zeitgeist-daemon.py has a bad code structure

2010-10-20 Thread Markus Korn
** Branch linked: lp:~thekorn/zeitgeist/fix-660415-improve-zeitgeist- daemon ** Changed in: zeitgeist Status: Confirmed => In Progress -- zeitgeist-daemon.py has a bad code structure https://bugs.launchpad.net/bugs/660415 You received this bug notification because you are a member of Zeit

Re: [Zeitgeist] [Merge] lp:~thekorn/zeitgeist/fix-660415-improve-zeitgeist-daemon into lp:zeitgeist

2010-10-20 Thread Markus Korn
Ok, I've removed the logging statements you both mentioned. > review approve > > I second Siegfrieds comment though. And please make sure the man page is > clear on the subject of debug logging. man zeitgeist-daemon says: --log-level=LOG_LEVEL Specifies how much information

[Zeitgeist] [Bug 663552] Re: can't disable recently used documents

2010-10-20 Thread Markus Korn
Hey art alexion, I'm not sure if I completely understand the purpose of this bugreport, is it about not logging actions on files, or are you fine with logging them, but they should just not show up in unity. Markus ** Changed in: zeitgeist Status: New => Incomplete -- can't disable rec

[Zeitgeist] [Bug 660415] Re: zeitgeist-daemon.py has a bad code structure

2010-10-25 Thread Markus Korn
** Changed in: zeitgeist Status: In Progress => Fix Committed -- zeitgeist-daemon.py has a bad code structure https://bugs.launchpad.net/bugs/660415 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status

[Zeitgeist] [Bug 660415] Re: zeitgeist-daemon.py has a bad code structure

2010-10-25 Thread Markus Korn
revno: 1623 [merge] committer: Markus Korn branch nick: trunk timestamp: Mon 2010-10-25 11:48:49 +0200 message: zeitgeist-daemon.py has now a much more readable code structure (LP:#660415) Also fixed the `--log-level` option, by

Re: [Zeitgeist] [Merge] lp:~seif/zeitgeist/fix-643303 into lp:zeitgeist

2010-10-25 Thread Markus Korn
okidoki, my take on this: I would like to have some kind of tests for the upgrade pathes, but please let's not do it like Seif tried in rev 1625. Therefor I suggest the following, let's merge this branch without rev 1625 into lp:zeitgeist, and then put some work into writing a testing framework f

[Zeitgeist] [Blueprint get-state] Get state of User Activity

2010-10-28 Thread Markus Korn
Blueprint changed by Markus Korn: Whiteboard changed: + --- seif --- Lets discuss this idea. Do we want it as a supported extension or do we want to have in the engine. Or do we want it as a community extension? How relevant is that to our current work? How could it help Unity and others

[Zeitgeist] [Blueprint get-state] Get state of User Activity

2010-10-28 Thread Markus Korn
Blueprint changed by Markus Korn: Whiteboard changed: - --- seif --- + --- seif 2010-10-27 10:28pm --- Lets discuss this idea. Do we want it as a supported extension or do we want to have in the engine. Or do we want it as a community extension? How relevant is that to our current work? How

[Zeitgeist] [Dev] ANNOUNCE: Zeitgeist 0.6

2010-11-01 Thread markus korn
Added `make run` target to the rootlevel Makefile (LP: #660423) [0] https://launchpad.net/zeitgeist-datahub Have a nice day, Markus Korn (thekorn) ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsub

[Zeitgeist] [Bug 665607] Re: DB upgrades not backwards compatible (even when their are)

2010-11-01 Thread Markus Korn
** Changed in: zeitgeist Status: Fix Committed => Fix Released -- DB upgrades not backwards compatible (even when their are) https://bugs.launchpad.net/bugs/665607 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Fram

[Zeitgeist] [Bug 643303] Re: Upgrade of the db schema strategy for version jumps

2010-11-01 Thread Markus Korn
** Changed in: zeitgeist Status: Fix Committed => Fix Released -- Upgrade of the db schema strategy for version jumps https://bugs.launchpad.net/bugs/643303 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework.

[Zeitgeist] [Bug 630593] Re: Replace old datahub with vala port

2010-11-01 Thread Markus Korn
** Changed in: zeitgeist Status: Fix Committed => Fix Released -- Replace old datahub with vala port https://bugs.launchpad.net/bugs/630593 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitge

[Zeitgeist] [Bug 655164] Re: Support more ResultType

2010-11-01 Thread Markus Korn
** Changed in: zeitgeist Status: Fix Committed => Fix Released -- Support more ResultType https://bugs.launchpad.net/bugs/655164 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framewo

[Zeitgeist] [Bug 650930] Re: Make timestamp related queries faster

2010-11-01 Thread Markus Korn
** Changed in: zeitgeist Status: Fix Committed => Fix Released -- Make timestamp related queries faster https://bugs.launchpad.net/bugs/650930 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zei

[Zeitgeist] [Bug 634744] Re: test suite fails if zeitgeist is installed on the system

2010-11-01 Thread Markus Korn
** Changed in: zeitgeist Status: Fix Committed => Fix Released -- test suite fails if zeitgeist is installed on the system https://bugs.launchpad.net/bugs/634744 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framew

[Zeitgeist] [Bug 660440] Re: Using logging output for debugging purposes

2010-11-01 Thread Markus Korn
** Changed in: zeitgeist Milestone: 0.6 => 0.7 -- Using logging output for debugging purposes https://bugs.launchpad.net/bugs/660440 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framew

[Zeitgeist] [Bug 642772] Re: event_view changes requires schema upgrade

2010-11-01 Thread Markus Korn
** Changed in: zeitgeist Status: Fix Committed => Fix Released -- event_view changes requires schema upgrade https://bugs.launchpad.net/bugs/642772 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status i

[Zeitgeist] [Bug 660415] Re: zeitgeist-daemon.py has a bad code structure

2010-11-01 Thread Markus Korn
** Changed in: zeitgeist Status: Fix Committed => Fix Released -- zeitgeist-daemon.py has a bad code structure https://bugs.launchpad.net/bugs/660415 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status

[Zeitgeist] [Bug 642686] Re: Add subj_uri_id and subj_origin_id columns to event_view

2010-11-01 Thread Markus Korn
** Changed in: zeitgeist Status: Fix Committed => Fix Released -- Add subj_uri_id and subj_origin_id columns to event_view https://bugs.launchpad.net/bugs/642686 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framew

[Zeitgeist] [Bug 641198] Re: Prefix search is not using an index

2010-11-01 Thread Markus Korn
** Changed in: zeitgeist Status: Fix Committed => Fix Released -- Prefix search is not using an index https://bugs.launchpad.net/bugs/641198 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitg

[Zeitgeist] [Bug 634740] Re: explicitly define on a per testcase basis which extension needs to be loaded

2010-11-01 Thread Markus Korn
** Changed in: zeitgeist Status: Fix Committed => Fix Released -- explicitly define on a per testcase basis which extension needs to be loaded https://bugs.launchpad.net/bugs/634740 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed

[Zeitgeist] [Bug 598666] Re: Error when trying to fetch items

2010-11-01 Thread Markus Korn
** Changed in: zeitgeist Milestone: 0.6 => None -- Error when trying to fetch items https://bugs.launchpad.net/bugs/598666 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framework: Incom

[Zeitgeist] [Bug 397715] Re: I18N of zeitgeist

2010-11-01 Thread Markus Korn
One part of this bug, not using lp:zeitgeist as target branch for translations, has been fixed, but there are still some issues with i18n in zeitgeist, as mentioned in the description and in one of my last comments. ** Changed in: zeitgeist Milestone: 0.6 => 0.7 -- I18N of zeitgeist https://

[Zeitgeist] [Bug 660423] Re: add `make run` targets to rootlevel Makefile

2010-11-01 Thread Markus Korn
** Changed in: zeitgeist Status: Fix Committed => Fix Released -- add `make run` targets to rootlevel Makefile https://bugs.launchpad.net/bugs/660423 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status

[Zeitgeist] [Bug 663552] Re: can't disable recently used documents

2010-11-01 Thread Markus Korn
Changing target back to 'unity-place-files' because this bug is about a missing toggle in the UI ** Project changed: zeitgeist => unity-place-files -- can't disable recently used documents https://bugs.launchpad.net/bugs/663552 You received this bug notification because you are a member of Zeitg

[Zeitgeist] [Bug 668771] Re: `make distcheck` fails badly

2010-11-02 Thread Markus Korn
** Changed in: zeitgeist-dataproviders Assignee: (unassigned) => Markus Korn (thekorn) ** Changed in: zeitgeist-dataproviders Status: New => Fix Committed -- `make distcheck` fails badly https://bugs.launchpad.net/bugs/668771 You received this bug notification because you

[Zeitgeist] [Bug 670355] Re: dynamic loading of extensions

2010-11-03 Thread Markus Korn
The fact that all monitors are gone when restarting zeitgeist is not an argument, because there is not guarantee that the zeitgeist daemon will run forever, so if you connect a monitor to the daemon, you have to handle the case of a daemon restart/shutdown, aka reconnecting the monitors after th

[Zeitgeist] [Bug 670358] Re: Add new aggregate API

2010-11-04 Thread Markus Korn
I suggest something like: def find_events_and_data(*find_event_arguments, datatype_const): ... return result result = [events, data] datatype_const: DATATYPE_COUNT -> result of COUNT() from within the sql-query DATATYPE_RELATIVE_COUNT -> result of COUNT() from within the sql-

[Zeitgeist] [Bug 670355] Re: dynamic loading of extensions

2010-11-05 Thread Markus Korn
Restarting of zeitgeist after installation the GAJ package requires no user action, because GAJ does the right thing (tm), in its package install process a SIGHUB signal is send to zeitgeist, which shuts the daemon down. - If this is not the case right now, it's a bug in the packaging of GAJ. And

[Zeitgeist] [Bug 670355] Re: dynamic loading of extensions

2010-11-05 Thread Markus Korn
ups, pressed 'post comment' to early, from my POV this bug is 'won't fix' -- dynamic loading of extensions https://bugs.launchpad.net/bugs/670355 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgei

[Zeitgeist] [Bug 672965] [NEW] find_event() queries with timerange other than TimeRange.always() are slow

2010-11-09 Thread Markus Korn
Public bug reported: When running the attached script you can see that when giving a timerange which does not start at 0 and end at maxint the queries get 400% slower. python sample_timerange_query.py DEBUG:zeitgeist.sql:Got query: QUERY: SELECT DISTINCT id FROM event_view GROUP BY actor ORDER B

[Zeitgeist] [Bug 672965] Re: find_event() queries with timerange other than TimeRange.always() are slow

2010-11-09 Thread Markus Korn
** Attachment added: "sample_timerange_query.py" https://bugs.launchpad.net/bugs/672965/+attachment/1727743/+files/sample_timerange_query.py -- find_event() queries with timerange other than TimeRange.always() are slow https://bugs.launchpad.net/bugs/672965 You received this bug notification

  1   2   3   4   5   >