Re: Lets axe 'core' module and make a flat mvn project of no modules

2010-05-19 Thread Jonathan Gray
+1 Simplicity is key On May 18, 2010, at 11:20 PM, "Paul Smith" wrote: > > On 19/05/2010, at 3:15 PM, Ryan Rawson wrote: > >> One option to handle the client issue would be to publish a minimal >> dependency set is it possible to publish 2 dependency sets? One >> for clients, one for exten

RE: Hudson build is back to normal : HBase-TRUNK #1254

2010-05-20 Thread Jonathan Gray
Yy > -Original Message- > From: Apache Hudson Server [mailto:hud...@hudson.zones.apache.org] > Sent: Thursday, May 20, 2010 9:14 AM > To: hbase-...@hadoop.apache.org > Subject: Hudson build is back to normal : HBase-TRUNK #1254 > > See

RE: Version number of next release

2010-05-20 Thread Jonathan Gray
Agreed on confusion regardless what we pick. But not sure I see what the value is in sticking to 0.21? Hadoop is also releasing a "development 0.21" release and people will think these two things are tied together, though they are not. I'm a big +1 on 0.90 for the next release. For the develo

RE: Development release series?

2010-05-20 Thread Jonathan Gray
But our development release won't be targeted at Hadoop 0.21, so isn't this the confusion we want to avoid? > -Original Message- > From: Andrew Purtell [mailto:apurt...@apache.org] > Sent: Thursday, May 20, 2010 10:47 AM > To: dev@hbase.apache.org > Subject: Re: Development release series

RE: Development release series?

2010-05-20 Thread Jonathan Gray
In principle I'm +1 on doing a development release. I'd like to see it happen in early June, basically at the same time we do a feature freeze on trunk for the real release. So any big changes that we want to get in to the next big release should be committed to trunk at the time we cut the de

RE: Development release series?

2010-05-20 Thread Jonathan Gray
ions, dupe assignment, WrongRegionExceptions, etc... > -Original Message- > From: Todd Lipcon [mailto:t...@cloudera.com] > Sent: Thursday, May 20, 2010 11:20 AM > To: dev@hbase.apache.org > Subject: Re: Development release series? > > On Thu, May 20, 2010 at 1

RE: Review board for all/most JIRAs patches

2010-05-25 Thread Jonathan Gray
Is any of this on the wiki? > -Original Message- > From: Ryan Rawson [mailto:ryano...@gmail.com] > Sent: Tuesday, May 25, 2010 10:11 PM > To: dev@hbase.apache.org > Subject: Re: Review board for all/most JIRAs patches > > Everyone... > > This is working out great so far. > > Some clarif

RE: Review board for all/most JIRAs patches

2010-05-26 Thread Jonathan Gray
of this. I can update the HowToContribute page as I haven't > closed out the Jira item for that task yet. > > Sent from my iPhone > > On 26/05/2010, at 4:44 PM, Jonathan Gray wrote: > > > Is any of this on the wiki? > > > >> -Original Message-

[DISCUSS] Change package names to org.apache.hbase

2010-05-28 Thread Jonathan Gray
One of the last disruptive changes that has been discussed for the next release is changing our package names from org.apache.hadoop.hbase to org.apache.hbase since we are now a TLP. I'd like to see this done, and the sooner the better. I propose we do it early next week. There is an existing

RE: [DISCUSS] Change package names to org.apache.hbase

2010-05-28 Thread Jonathan Gray
overs. Few clients should depend on it. > > On May 28, 2010 3:16 PM, "Jonathan Gray" wrote: > > One of the last disruptive changes that has been discussed for the > next > release is changing our package names from org.apache.hadoop.hbase to > org.apache.hbase since we

FW: Review Request: HBASE-2001 RegionObserver

2010-06-03 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/96/#review124 --- src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java

Re: Review Request: HBASE-2001 RegionObserver

2010-06-03 Thread Jonathan Gray
This is awesome stuff Andrew! Great work! I agree with Todd, this would probably benefit from baking in a branch somewhere for a while. Start working up some solid examples to iron out the API. There are also a number of master changes as well as compact/flush/split changes that are going in

RE: Working towards a dev release

2010-06-05 Thread Jonathan Gray
The dates sound good, at least on master side of things. I've got a bunch of half-done stuff on the compaction/flush/split side of things that I've been holding off on until the master stuff pushes through. I suspect 6/22 is enough time to finish my stuff, but I may not have all patches up by

Review Request: HBASE-2618 Don't inherit from HConstants.

2010-06-06 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/132/#review135 --- This patch changes a bunch of tabbing patterns to be different from what is

RE: Working towards a dev release

2010-06-06 Thread Jonathan Gray
to be more concentrated. JG > -Original Message- > From: Todd Lipcon [mailto:t...@cloudera.com] > Sent: Saturday, June 05, 2010 10:40 AM > To: dev@hbase.apache.org > Subject: Re: Working towards a dev release > > On Sat, Jun 5, 2010 at 12:46 PM, Jonathan Gray >

Review Request: HBASE-2400: new connector for Avro RPC access to HBase cluster

2010-06-06 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/128/#review137 --- This looks great Hammer. No major comments. trunk/src/main/java/org/apach

Review Request: HBASE-2618 Don't inherit from HConstants.

2010-06-06 Thread Jonathan Gray
> On 2010-06-06 09:08:19, Jonathan Gray wrote: > > This patch changes a bunch of tabbing patterns to be different from what is > > currently done in the codebase. Primarily the full indenting of arguments > > to align with each other. > > > > As far as I know,

Review Request: HBASE-2618 Don't inherit from HConstants.

2010-06-06 Thread Jonathan Gray
> On 2010-06-06 09:08:19, Jonathan Gray wrote: > > This patch changes a bunch of tabbing patterns to be different from what is > > currently done in the codebase. Primarily the full indenting of arguments > > to align with each other. > > > > As far as I know,

Re: Review Request: HBASE-2618 Don't inherit from HConstants.

2010-06-08 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/132/#review155 --- Ship it! Looks good, Benoit. Only issue is in LocalHBaseCluster where def

Re: Review Request: HBASE-2618 Don't inherit from HConstants.

2010-06-10 Thread Jonathan Gray
> On 2010-06-09 23:29:32, Benoit Sigoure wrote: > > Can we apply this patch now? Yes, can you just post your final patch into the JIRA and I will commit? Last I checked there were no patches in jira. - Jonathan --- This is an automati

Re: Review Request: HBASE-2468: Improvements to prewarm META cache on clients.

2010-06-10 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/98/#review176 --- This looks great! I think we should think more about where to expose this,

Re: Review Request: Cached region location that went stale won't recover if asking for first row

2010-06-11 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/170/#review189 --- /branches/0.20/src/java/org/apache/hadoop/hbase/client/HConnectionManager.

Re: Review Request: Cached region location that went stale won't recover if asking for first row

2010-06-11 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/170/#review193 --- Ship it! looks good to me - Jonathan On 2010-06-11 12:14:26, Jean-Danie

Re: Review Request: HBASE-2468: Improvements to prewarm META cache on clients.

2010-06-11 Thread Jonathan Gray
> On 2010-06-10 08:53:41, Jonathan Gray wrote: > > src/main/java/org/apache/hadoop/hbase/client/HTable.java, line 1079 > > <http://review.hbase.org/r/98/diff/5/?file=943#file943line1079> > > > > I guess these are static because of how HTables all share

Re: Review Request: HBASE-2468: Improvements to prewarm META cache on clients.

2010-06-11 Thread Jonathan Gray
> On 2010-06-10 08:53:41, Jonathan Gray wrote: > > src/main/java/org/apache/hadoop/hbase/client/HTable.java, line 1079 > > <http://review.hbase.org/r/98/diff/5/?file=943#file943line1079> > > > > I guess these are static because of how HTables all share

Re: Review Request: HBASE-2694 Move RS to Master region open/close messaging into ZooKeeper

2010-06-11 Thread Jonathan Gray
> On 2010-06-11 17:35:09, Todd Lipcon wrote: > > Skimmed it reasonably quickly, looks good. > > Major concern is how often we catch and just log exceptions. In most cases > > I think these are errors we can't recover from and it's best to throw RTE > > and shut down the whole server. > > > > S

Re: Review Request: HBASE-2733 fix broken replacement of LATEST_TIMESTAMP in HRegion

2010-06-15 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/183/#review232 --- Ship it! lgtm src/main/java/org/apache/hadoop/hbase/regionserver/HRegion

RE: Development release next week

2010-06-18 Thread Jonathan Gray
So then is the plan to branch and then cherry-pick fixes until the first release of it? Following the release, would we continue to cherry-pick bug fixes and possibly have a second dev release? I'm thinking cutting a branch soon and cherry-picking fixes between now and the summit might make se

RE: Development release next week

2010-06-18 Thread Jonathan Gray
release of the Hadoop 0.20-append branch cut along with it? At the least I suppose we'd ship with jars and maven config to pull from a 0.20-append hadoop? > -Original Message- > From: Jonathan Gray [mailto:jg...@facebook.com] > Sent: Friday, June 18, 2010 6:11 PM > To: dev

RE: [VOTE] Shall we release hbase-0.20.5 Release Candidate 5 as hbase-0.20.5?

2010-06-22 Thread Jonathan Gray
+1 Ran unit tests, spun up cluster and ran some read/write tests, all looks good. JG > -Original Message- > From: saint@gmail.com [mailto:saint@gmail.com] On Behalf Of > Stack > Sent: Saturday, June 19, 2010 12:42 PM > To: HBase Dev List > Subject: [VOTE] Shall we release hbase-0

RE: 0.89.20100621 development branch status

2010-06-22 Thread Jonathan Gray
+1 Works for me > -Original Message- > From: Todd Lipcon [mailto:t...@cloudera.com] > Sent: Tuesday, June 22, 2010 10:21 PM > To: dev@hbase.apache.org > Subject: Re: 0.89.20100621 development branch status > > On Tue, Jun 22, 2010 at 9:05 PM, Stack wrote: > > > On Tue, Jun 22, 2010 at

RE: Build failed in Hudson: HBase-TRUNK #1361

2010-06-24 Thread Jonathan Gray
FYI I tripped over this twice in the past week on TestHLog running test locally but have not dug in yet. So, not only happening on Hudson. > -Original Message- > From: saint@gmail.com [mailto:saint@gmail.com] On Behalf Of > Stack > Sent: Thursday, June 24, 2010 8:43 AM > To: dev@

Feature branch for master rewrite

2010-06-24 Thread Jonathan Gray
Hey guys, So it's been a clunky and slow-moving process with HBASE-2694 and related JIRAs. The most recent HBASE-2697 patch is supposed to be non-controversial but is in fact controversial because there's really not much context to the changes. Instead of trying to make smallish patches that ar

RE: Feature branch for master rewrite

2010-06-24 Thread Jonathan Gray
ed that > it > > was a good model for HBase too). > > > > J-D > > > > On Thu, Jun 24, 2010 at 5:17 PM, Jonathan Gray > wrote: > > > Hey guys, > > > > > > So it's been a clunky and slow-moving process with HBASE-2694 and > relate

FW: [jira] Commented: (HBASE-2692) Master rewrite and cleanup for 0.90

2010-06-28 Thread Jonathan Gray
FYI Jonathan Gray commented on HBASE-2692: -- Created a feature branch for work related to this JIRA. https://svn.apache.org/repos/asf/hbase/branches/0.90_master_rewrite As part of that branch, I added a BRANCH_CHANGES.txt for changes just in the branch

Review Request: First cut at a working load balancer

2010-07-07 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/282/ --- Review request for hbase. Summary --- Just putting this up to show people. It'

HBase Hackathon IV Wrap-up

2010-07-12 Thread Jonathan Gray
HBase Developers, In conjunction with the recent HUG11 (http://hbaseblog.com/2010/07/04/hug11-hbase-0-90-preview-wrap-up/) we also held the fourth HBase Hackathon at Facebook. At this hackathon, we spent a bit of time at the end in a discussion of ways to improve HBase outside of normal featur

Re: Review Request: HBASE-2832: Priorities and multi-threading for MemStore flushing

2010-07-12 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/301/ --- (Updated 2010-07-12 20:39:44.545617) Review request for hbase, stack, Karthik Rangan

Re: Review Request: HBASE-2832: Priorities and multi-threading for MemStore flushing

2010-07-12 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/301/ --- (Updated 2010-07-12 21:41:44.943871) Review request for hbase, stack, Karthik Rangan

Re: Review Request: HBASE-2832: Priorities and multi-threading for MemStore flushing

2010-07-12 Thread Jonathan Gray
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/FlushHandler.java, > > line 220 > > <http://review.hbase.org/r/301/diff/2/?file=2557#file2557line220> > > > > Low and high priority do same thing? yup. i had/have bigger plans to get rid of MemStoreFl

Re: Review Request: HBASE-2832: Priorities and multi-threading for MemStore flushing

2010-07-12 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/301/ --- (Updated 2010-07-12 22:43:42.753269) Review request for hbase, stack, Karthik Rangan

Re: Review Request: HBASE-2832: Priorities and multi-threading for MemStore flushing

2010-07-12 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/301/ --- (Updated 2010-07-12 22:44:39.027666) Review request for hbase, stack, Karthik Rangan

Re: Review Request: HBASE-2794 Multi Column Bloom Filter Check

2010-07-13 Thread Jonathan Gray
> On 2010-07-13 18:09:13, Nicolas wrote: > > /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java, > > line 958 > > > > > > red = using tabs instead of spaces or trailing spaces. quick fix might > > be ni

RE: What for a Documentation Tool (WAS -> Re: HBase Hackathon IV Wrap-up)

2010-07-14 Thread Jonathan Gray
Simple and effective. I think now is not the time to adopt something that does any big sweeping change like change our wiki, website, etc... Let's just add something to our current basket of tricks that allows us to write clean and effective "books" of versioned documentation that can be packa

Review Request: HBASE-2696: ZK cleanup. Finish RS and fix client, move to ZKWatcher

2010-07-15 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/324/ --- Review request for hbase, stack, Jean-Daniel Cryans, and Karthik Ranganathan. Summar

Re: Review Request: ScanQueryMatcher provides more specific return codes for early exit.

2010-07-15 Thread Jonathan Gray
10-07-15 01:38:38) > > > Review request for hbase, Jonathan Gray, Karthik Ranganathan, and Kannan > Muthukkaruppan. > > > Summary > --- > > This patch addresses the following issues: > > 1. After it is done with reading the required timestamps, the QueryM

Re: Review Request: HBASE-2696: ZK cleanup. Finish RS and fix client, move to ZKWatcher

2010-07-15 Thread Jonathan Gray
t; > line 54 > > <http://review.hbase.org/r/324/diff/2/?file=2830#file2830line54> > > > > Do you mean ensemble? I used previous naming convention (all the existing ZK methods are about getting the quorum string). You are probably right, it's the ensemble but wo

Re: Review Request: HBASE-1511: Pseudo distributed mode for HBase

2010-07-16 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/328/#review417 --- trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java

Re: Review Request: distributed log splitting now with better testing and configurable splitting

2010-07-23 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/370/#review467 --- Hey Alex, this is looking good. The master rewrite branch has a refactorin

Review Request: ZKAssign. New zookeeper assignment methods.

2010-07-23 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/382/ --- Review request for hbase, stack, Jean-Daniel Cryans, Karthik Ranganathan, and Kannan

Re: Review Request: ZKAssign. New zookeeper assignment methods.

2010-07-23 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/382/ --- (Updated 2010-07-23 16:26:26.834022) Review request for hbase, stack, Jean-Daniel Cr

Re: Review Request: ZKAssign. New zookeeper assignment methods.

2010-07-23 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/382/ --- (Updated 2010-07-23 16:28:15.057431) Review request for hbase, stack, Jean-Daniel Cr

Re: Review Request: ZKAssign. New zookeeper assignment methods.

2010-07-23 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/382/ --- (Updated 2010-07-23 16:29:43.251978) Review request for hbase, stack, Jean-Daniel Cr

Re: Review Request: ZKAssign. New zookeeper assignment methods.

2010-07-23 Thread Jonathan Gray
to OFFLINE it's still in the previously seen OFFLINE version, otherwise a server may have started OPENING in between our check and set. - Jonathan On 2010-07-23 16:29:43, Jonathan Gray wrote: > > --- > This is an automatical

Re: Review Request: ZKAssign. New zookeeper assignment methods.

2010-07-23 Thread Jonathan Gray
> On 2010-07-23 16:35:42, Jonathan Gray wrote: > > Thinking on it, I will probably need to not just blindly force something to > > OFFLINE in the masters force to OFFLINE. Though any state will be able to > > be transitioned to OFFLINE (during recovery, we ma

RE: [VOTE] Shall we release hbase-0.20.6 Release Candidate 1 as hbase-0.20.6?

2010-07-25 Thread Jonathan Gray
HBASE-2473 is a new feature. 0.21 is equivalent to 0.89 and 0.90 (trunk). 0.89 are dev releases off trunk which will be release as 0.90. 0.20 branch is an old branch that will not have new features added to it, just bug fixes. All new features should be done against trunk only. http://hbaseb

RE: Review Request: First cut at a working load balancer

2010-07-26 Thread Jonathan Gray
uster) > > is gathered ? > > > > Map> serverInfo > > > > Considering the implication from HBASE-2473, some (pre-created) > regions may > > stay empty for some time. Would those regions be i

RE: [VOTE] Shall we release hbase-0.20.6 Release Candidate 1 as hbase-0.20.6?

2010-07-26 Thread Jonathan Gray
t; release ? > > Thanks > > On Sun, Jul 25, 2010 at 8:01 AM, Jonathan Gray > wrote: > > > HBASE-2473 is a new feature. 0.21 is equivalent to 0.89 and 0.90 > (trunk). > > 0.89 are dev releases off trunk which will be release as 0.90. > > > > 0.20 br

Re: Review Request: Bloom filter NPE

2010-07-26 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/336/#review492 --- Ship it! Just a simple null check and added test. LGTM - Jonathan On 2

Re: Review Request: Bloom filter NPE

2010-07-26 Thread Jonathan Gray
> On 2010-07-26 18:25:37, Jonathan Gray wrote: > > Just a simple null check and added test. LGTM and all of ryan's comments have been addressed. thanks pranav. - Jonathan --- This is an automatically generated e-mail. T

Review Request: HBASE-2695/HBASE-2696 The rest of it. Master fully on new ZK stuff.

2010-07-26 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/387/ --- Review request for hbase, stack and Karthik Ranganathan. Summary --- This is th

Re: Review Request: HBASE-2695/HBASE-2696 The rest of it. Master fully on new ZK stuff.

2010-07-27 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/387/ --- (Updated 2010-07-27 09:31:00.269382) Review request for hbase, stack and Karthik Ran

RE: minor bug in ServerManager.ServerMonitor.chore()

2010-08-01 Thread Jonathan Gray
Can you file a jira and put a patch up? > -Original Message- > From: Ted Yu [mailto:yuzhih...@gmail.com] > Sent: Saturday, July 31, 2010 3:13 PM > To: dev@hbase.apache.org > Subject: minor bug in ServerManager.ServerMonitor.chore() > > Hi, > I see a minor issue in ServerManager.ServerMoni

Review Request:

2010-08-03 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/484/ --- Review request for hbase, stack and Karthik Ranganathan. Summary --- This is

Re: Review Request: HBASE-2697 The master rewrite

2010-08-03 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/484/ --- (Updated 2010-08-03 05:02:49.124462) Review request for hbase, stack and Karthik

Re: Review Request: HBASE-2697 The master rewrite

2010-08-03 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/484/ --- (Updated 2010-08-03 17:13:11.559426) Review request for hbase, stack and Karthik

Re: Review Request: HBASE-2697 The master rewrite

2010-08-03 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/484/ --- (Updated 2010-08-03 21:55:46.272720) Review request for hbase, stack and Karthik

Re: Review Request: HBASE-2697 The master rewrite

2010-08-04 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/484/ --- (Updated 2010-08-04 10:37:33.110269) Review request for hbase, stack and Karthik

Re: Review Request: HBASE-2697 The master rewrite

2010-08-05 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/484/ --- (Updated 2010-08-05 00:19:37.074497) Review request for hbase, stack and Karthik

Re: Review Request: Fault in logic in BinaryPrefixComparator leads to ArrayIndexOutOfBoundsException

2010-08-18 Thread Jonathan Gray
gt; > > Review request for hbase and Jonathan Gray. > > > Summary > --- > > Following statement makes an incorrect assumption that value.length >= > this.value.length. > > return Bytes.compareTo(this.value, 0, this.value.length, value, 0, > this.v

RE: HBase: project ideas

2010-08-19 Thread Jonathan Gray
Himanshu, Seems like you might have an interest in using Coprocessors to do stuff like low-latency aggregates. This is a big area of interest for some of us but not a lot of concerted effort in this direction yet. There is plenty to do here for a research project. Check out: https://issues.

RE: How row delete works

2010-08-20 Thread Jonathan Gray
There is also explanation of deletes in the BigTable paper. http://labs.google.com/papers/bigtable-osdi06.pdf > -Original Message- > From: Ted Yu [mailto:yuzhih...@gmail.com] > Sent: Friday, August 20, 2010 8:42 AM > To: dev@hbase.apache.org > Subject: Re: How row delete works > > Please

RE: 0.90 release date estimate

2010-08-22 Thread Jonathan Gray
That sounds about right. Hopefully early October, right around Hadoop World. Good place for announcements. Maybe we could do a meetup or something the night before, October 11? Anyone interested in speeding up the process, take a look at the outstanding JIRAs and get ready to start testing.

RE: Heads-up: big commit in next day or so; "HBASE-2692 Master rewrite and cleanup for 0.90"

2010-08-31 Thread Jonathan Gray
Though I'm sure my vote is clear, I'm +1 on this. The plan at fb is to update our internal branch to (almost) the current head of trunk, before the commit of the master branch. Ongoing testing will continue on this branch. In parallel, testing will also begin here on the new master following t

RE: Heads-up: big commit in next day or so; "HBASE-2692 Master rewrite and cleanup for 0.90"

2010-08-31 Thread Jonathan Gray
pared with current trunk) from > > cluster running the new master ? > > > > Thanks > > > > On Tue, Aug 31, 2010 at 10:20 AM, Jonathan Gray > wrote: > > > >> Though I'm sure my vote is clear, I'm +1 on this. > >> > >> The pl

RE: hfile - Storefile

2010-09-01 Thread Jonathan Gray
Himanshu, Don't be afraid to check-out the HBase codebase from SVN and scope out HFile and StoreFile classes for yourself! HBase has a fairly easy to follow codebase despite being rather large. JG > -Original Message- > From: jdcry...@gmail.com [mailto:jdcry...@gmail.com] On Behalf Of

Re: Review Request: Eliminate duplicates, stale versions. Have determined behaviour and storefile ordering

2010-09-06 Thread Jonathan Gray
> This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/780/ > --- > > (Updated 2010-09-06 15:44:17) > > > Review request for hbase, stack, Jonathan Gray, Rya

Re: Review Request: Eliminate duplicates, stale versions. Have determined behaviour and storefile ordering

2010-09-07 Thread Jonathan Gray
http://review.cloudera.org/r/780/ > --- > > (Updated 2010-09-07 13:47:20) > > > Review request for hbase, stack, Jonathan Gray, Ryan Rawson, Karthik > Ranganathan, and Kannan Muthukkaruppan. > > > Summary > --- > > Goodbye duplicates, hello consiste

Re: Review Request: Refactor master and RS to conform to Guava service lifecycle interface

2010-09-13 Thread Jonathan Gray
29, Todd Lipcon wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/829/ > --- > > (Updated 2010-09-13 18:36:29) > > > Review request for hbase, stack and

old master to 0.90 and new master to 0.92? (was RE: Millions of photos into Hbase)

2010-09-21 Thread Jonathan Gray
Deep within my soul I do not want to do this. But it might be practical. FB is going into prod w/ the old master and we've been doing work stabilizing it in ways that do not apply at all to the new one (especially around zk). That'll make having two different active branches a bit of a nightma

RE: old master to 0.90 and new master to 0.92? (was RE: Millions of photos into Hbase)

2010-09-22 Thread Jonathan Gray
> > We also confuse the 0.90 'message' given we've been talking about new > > master at HUGs and here on the lists with a good while now. > > This might be a little naïve but what about calling the "SU"-build > 0.88 and release it (with a small disclaimer). It would make sense in > that the 0.89-d

RE: old master to 0.90 and new master to 0.92? (was RE: Millions of photos into Hbase)

2010-09-23 Thread Jonathan Gray
Yes, there are way more changes/improvements made beyond the initial scope of working master failover / zk-based region transitions. Lots of cleanup, removal of many of the nasty bits we've always hated, and the groundwork is laid for a lot of future improvements. I'm not apprehensive. I thin

Review Request: HBASE-3047: If new master crashes, restart is messy

2010-09-28 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/915/ --- Review request for hbase, stack and Jonathan Gray. Summary --- This is

Re: Review Request: HBASE-3047: If new master crashes, restart is messy

2010-09-28 Thread Jonathan Gray
failover? trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <http://review.cloudera.org/r/915/#comment4487> looks good - Jonathan On 2010-09-28 15:52:46, Jonathan Gray wrote: > >

Re: Review Request: HBASE-3047: If new master crashes, restart is messy

2010-09-29 Thread Jonathan Gray
on commit as discussed. - Jonathan On 2010-09-29 15:12:30, Jonathan Gray wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://review.cloude

Review Request: Add ability to have multiple Masters in LocalHBaseCluster for test writing

2010-09-29 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/925/ --- Review request for hbase, stack, Karthik Ranganathan, and Kannan Muthukkaruppan.

Re: Review Request: Add ability to have multiple Masters in LocalHBaseCluster for test writing

2010-09-29 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/925/ --- (Updated 2010-09-29 17:39:07.962079) Review request for hbase, stack, Karthik Ran

Re: Review Request: Add ability to have multiple Masters in LocalHBaseCluster for test writing

2010-09-29 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/925/ --- (Updated 2010-09-29 19:40:41.579973) Review request for hbase, stack, Karthik Ran

Re: Review Request: Add ability to have multiple Masters in LocalHBaseCluster for test writing

2010-09-29 Thread Jonathan Gray
just sticks on the first master which blocks in the constructor. Could we move everything from the constructor into run()? At least the stuff that blocks / after the blocking (which is almost everything)? - Jonathan On 2010-09-29 19:40:41, Jonathan Gray wrote

Re: Review Request: Add ability to have multiple Masters in LocalHBaseCluster for test writing

2010-09-29 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/925/ --- (Updated 2010-09-29 19:56:56.581133) Review request for hbase, stack, Karthik Ran

Re: Review Request: HBase-2001: Coprocessors: Colocate user code with regions

2010-09-30 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/876/#review1366 --- src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

Review Request: Fix REST tests on trunk

2010-09-30 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/927/ --- Review request for hbase, stack and Andrew Purtell. Summary --- This method

Re: Review Request: Fix REST tests on trunk

2010-09-30 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/927/ --- (Updated 2010-09-30 13:50:57.922028) Review request for hbase, stack and Andrew P

Re: Review Request: hbase-3019 Make bulk assignment on cluster startup run faster

2010-09-30 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/926/#review1368 --- Just a few comments/questions, but looks good to me. trunk/src/main/j

Re: Review Request: Add ability to have multiple Masters in LocalHBaseCluster for test writing

2010-10-01 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/925/ --- (Updated 2010-10-01 10:00:03.133377) Review request for hbase, stack, Karthik Ran

RE: Please review HBASE-3073 - API addition!

2010-10-01 Thread Jonathan Gray
+1 from me. Happy to do a code review and give more specific comments, can you put it up on review board? > -Original Message- > From: Ryan Rawson [mailto:ryano...@gmail.com] > Sent: Friday, October 01, 2010 5:04 PM > To: hbase > Subject: Please review HBASE-3073 - API addition! > > I h

RE: Feature freeze for 0.90 on Wednesday, October 5th, with branch soon after?

2010-10-03 Thread Jonathan Gray
Stack and I spent a good deal of last week fixing unit tests. Almost everything is now passing, so I expect a clean Hudson build early this coming week. Some unit tests, like those for replication, still need to be fixed but are currently disabled on trunk so should not impact Hudson. +1 on g

RE: Feature freeze for 0.90 on Wednesday, October 5th, with branch soon after?

2010-10-03 Thread Jonathan Gray
+1 on all. I've also been doing lots of testing on TRUNK this past week and things look good to me as well. This coming week I will be finalizing HBASE-3053 (multiple masters in unit tests) and building out some new unit tests based on it so we can officially close out some of the master/failo

RE: [VOTE] Release 'development release' HBase 0.89.2010924 rc1?

2010-10-04 Thread Jonathan Gray
+1 I took it for a test drive today and tested all the basic stuff. No performance stuff but I think enough for my vote. JG > -Original Message- > From: jdcry...@gmail.com [mailto:jdcry...@gmail.com] On Behalf Of Jean- > Daniel Cryans > Sent: Monday, October 04, 2010 10:56 AM > To: dev

Re: Review Request: HBASE-3073 New APIs for Result, faster implementation for some calls

2010-10-05 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/963/#review1427 --- Just javadoc cleanup, otherwise this looks great. As noted in comments

  1   2   3   >