[Toolchain-CR] IMPALA-4549: consistently enforce that boost gregorian year <= 9999

2016-11-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4549: consistently enforce that boost gregorian year <= .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5264

[Toolchain-CR] IMPALA-4549: consistently enforce that boost gregorian year <= 9999

2016-11-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4549: consistently enforce that boost gregorian year <= .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3864: qgen: reduce likelihood of create query() exceptions

2016-07-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3864: qgen: reduce likelihood of create_query() exceptions .. Patch Set 7: Code-Review+2 Looks good to me. -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-3864: qgen: reduce likelihood of create query() exceptions

2016-07-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3864: qgen: reduce likelihood of create_query() exceptions .. Patch Set 4: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3864: qgen: reduce likelihood of create query() exceptions

2016-07-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3864: qgen: reduce likelihood of create_query() exceptions .. Patch Set 3: (4 comments)

[Impala-CR](cdh5-trunk) IMPALA-3892: qgen: always run Impala with -convert legacy hive parquet utc timestamps=true

2016-07-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3892: qgen: always run Impala with -convert_legacy_hive_parquet_utc_timestamps=true .. Patch Set 1: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3336: qgen: do not randomly generate query options (workaround)

2016-07-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3336: qgen: do not randomly generate query options (workaround) .. Patch Set 2: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3729: batch size=1 coverage for avro scanner

2016-07-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner .. Patch Set 5: Code-Review+1 (1 comment) The Python changes look good to me.

[Impala-CR](cdh5-trunk) Clean up Python test import statements

2016-07-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: Clean up Python test import statements .. Patch Set 3: I used pyflakes for this. Then I ran the following command in $IMPALA_HOME/tests: find . -name

[Impala-CR](cdh5-trunk) Clean up Python test import statements

2016-07-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: Clean up Python test import statements .. Patch Set 3: I removed the query generator changes from this patch, so the third test you suggested is not

[Impala-CR](cdh5-trunk) Clean up Python test import statements

2016-07-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: Clean up Python test import statements .. Patch Set 3: This was tested on S3 and exhaustive and the builds passed:

[Impala-CR](cdh5-trunk) Clean up Python test import statements

2016-07-15 Thread Taras Bobrovytsky (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3444 to look at the new patch set (#3). Change subject: Clean up Python test import statements .. Clean up Python test

[Impala-CR](cdh5-trunk) IMPALA-3778: Fix ASF packaging build

2016-07-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has submitted this change and it was merged. Change subject: IMPALA-3778: Fix ASF packaging build .. IMPALA-3778: Fix ASF packaging build The tarballs in IMPALA_HOME/infra/python/deps and the thirdparty

[Impala-CR](cdh5-trunk) IMPALA-3778: Fix ASF packaging build

2016-07-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3778: Fix ASF packaging build .. Patch Set 1: The ASF build becomes consistent with the non-ASF build after we run download_requrements in the ASF

[Impala-CR](cdh5-trunk) IMPALA-3778: Fix ASF packaging build

2016-07-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-3778: Fix ASF packaging build .. IMPALA-3778: Fix ASF packaging build The tarballs in IMPALA_HOME/infra/python/deps and the thirdparty directory have

[Impala-CR](cdh5-trunk) IMPALA-3778: Fix ASF packaging build

2016-07-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3778: Fix ASF packaging build .. Patch Set 1: (2 comments) Yes, I ran the private build and test and the packaging job which passed. I will do so

[Impala-CR] IMPALA-3778: Fix ASF packaging build

2016-07-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has abandoned this change. Change subject: IMPALA-3778: Fix ASF packaging build .. Abandoned This is the wrong branch. Switched this review to cdh5-trunk instead of master. -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-3778: Fix ASF packaging build

2016-07-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/3647 Change subject: IMPALA-3778: Fix ASF packaging build .. IMPALA-3778: Fix ASF packaging build The tarballs in

[Impala-CR] IMPALA-3778: Fix ASF packaging build

2016-07-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3778: Fix ASF packaging build .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3626/1/bin/impala-config.sh File

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3800: Python 2.6 support for collect minidumps.py

2016-06-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3800: Python 2.6 support for collect_minidumps.py .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3525 To

[Impala-CR](cdh5-trunk) Clean up Python test import statements

2016-06-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: Clean up Python test import statements .. Patch Set 2: This change was built successfully and all tests passed:

[Impala-CR](cdh5-trunk) Clean up Python test import statements

2016-06-25 Thread Taras Bobrovytsky (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3444 to look at the new patch set (#2). Change subject: Clean up Python test import statements .. Clean up Python test

[Impala-CR](cdh5-trunk) IMPALA-3729: batch size=1 coverage for avro scanner

2016-06-24 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner .. Patch Set 5: (1 comment)

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3698: Fix Isilon permissions test

2016-06-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has submitted this change and it was merged. Change subject: IMPALA-3698: Fix Isilon permissions test .. IMPALA-3698: Fix Isilon permissions test Isilon OneFS 8.0 introduces a regression where a

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3698: Fix Isilon permissions test

2016-06-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3698: Fix Isilon permissions test .. Patch Set 1: Code-Review+2 Verified+1 Cherry picked to 5.8.0 branch, forwarding the +2 and verified. -- To

[Impala-CR](cdh5-2.6.0 5.8.x) IMPALA-3698: Fix Isilon permissions test

2016-06-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3698: Fix Isilon permissions test .. Patch Set 1: Code-Review+2 Verified+1 Cherry picked to 5.8.x branch, forwarding the +2 and verified. -- To

[Impala-CR](cdh5-2.6.0 5.8.x) IMPALA-3698: Fix Isilon permissions test

2016-06-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has submitted this change and it was merged. Change subject: IMPALA-3698: Fix Isilon permissions test .. IMPALA-3698: Fix Isilon permissions test Isilon OneFS 8.0 introduces a regression where a

[Impala-CR](cdh5-2.6.0 5.8.x) IMPALA-3698: Fix Isilon permissions test

2016-06-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/3472 Change subject: IMPALA-3698: Fix Isilon permissions test .. IMPALA-3698: Fix Isilon permissions test Isilon OneFS 8.0 introduces a

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3698: Fix Isilon permissions test

2016-06-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/3471 Change subject: IMPALA-3698: Fix Isilon permissions test .. IMPALA-3698: Fix Isilon permissions test Isilon OneFS 8.0 introduces a

[Impala-CR](cdh5-trunk) IMPALA-3698: Fix Isilon permissions test

2016-06-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3698: Fix Isilon permissions test .. Patch Set 2: David, it's not necessary to wait for a successful jenkins verification before giving a +2. We

[Impala-CR](cdh5-trunk) IMPALA-3698: Fix Isilon permissions test

2016-06-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3698: Fix Isilon permissions test .. Patch Set 1: All tests passed in: http://sandbox.jenkins.cloudera.com/job/impala-private-build-and-test/3496/

[Impala-CR](cdh5-trunk) IMPALA-3698: Fix Isilon permissions test

2016-06-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has submitted this change and it was merged. Change subject: IMPALA-3698: Fix Isilon permissions test .. IMPALA-3698: Fix Isilon permissions test Isilon OneFS 8.0 introduces a regression where a

[Impala-CR](cdh5-trunk) IMPALA-3698: Fix Isilon permissions test

2016-06-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3698: Fix Isilon permissions test .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3433 To unsubscribe, visit

[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins

2016-06-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3753: Disable create table test for old aggs and joins .. Patch Set 3: All tests passed in this private build:

[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins

2016-06-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has submitted this change and it was merged. Change subject: IMPALA-3753: Disable create table test for old aggs and joins .. IMPALA-3753: Disable create table test for old aggs and joins The "IMPALA-3530:

[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins

2016-06-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3753: Disable create table test for old aggs and joins .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3430 To

[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins

2016-06-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3753: Disable create table test for old aggs and joins .. Patch Set 3: Code-Review+2 Forwarding the +2. -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins

2016-06-23 Thread Taras Bobrovytsky (Code Review)
Hello Michael Brown, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3430 to look at the new patch set (#3). Change subject: IMPALA-3753: Disable create table test for old aggs and joins

[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins

2016-06-22 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3430 to look at the new patch set (#2). Change subject: IMPALA-3753: Disable create table test for old aggs and joins

[Impala-CR](cdh5-trunk) IMPALA-3729: batch size=1 coverage for avro scanner

2016-06-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner .. Patch Set 4: (3 comments) In this patch, we are not differentiating between the result when

[Impala-CR](cdh5-trunk) IMPALA-3729: batch size=1 coverage for avro scanner

2016-06-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner .. Patch Set 2: (1 comment)

[Impala-CR](cdh5-trunk) Cleanup Python test import statements

2016-06-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/3444 Change subject: Cleanup Python test import statements .. Cleanup Python test import statements Many of our test scripts have import

[Impala-CR](cdh5-trunk) IMPALA-3698: Fix Isilon permissions test

2016-06-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/3433 Change subject: IMPALA-3698: Fix Isilon permissions test .. IMPALA-3698: Fix Isilon permissions test Isilon OneFS 8.0 introduces a

[Impala-CR](cdh5-trunk) IMPALA-3729: batch size=1 coverage for avro scanner

2016-06-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3413/1//COMMIT_MSG Commit Message:

[Impala-CR](cdh5-trunk) Add kill cluster marker to KMS

2016-06-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has submitted this change and it was merged. Change subject: Add kill cluster marker to KMS .. Add kill cluster marker to KMS If PID files of each process in the mini cluster get deleted for some reason, it

[Impala-CR](cdh5-trunk) Add kill cluster marker to KMS

2016-06-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: Add kill cluster marker to KMS .. Patch Set 2: Verified in

[Impala-CR](cdh5-trunk) Add kill cluster marker to KMS

2016-06-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: Add kill cluster marker to KMS .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3354 To unsubscribe, visit

[Impala-CR](cdh5-trunk) Add kill cluster marker to KMS

2016-06-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: Add kill cluster marker to KMS .. Patch Set 2: Code-Review+2 Carrying the +2. -- To view, visit http://gerrit.cloudera.org:8080/3354 To unsubscribe, visit

[Impala-CR](cdh5-trunk) Add kill cluster marker to KMS

2016-06-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: Add kill cluster marker to KMS .. Patch Set 1: (1 comment)

[Impala-CR](cdh5-trunk) Add kill cluster marker to KMS

2016-06-09 Thread Taras Bobrovytsky (Code Review)
Hello Casey Ching, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3354 to look at the new patch set (#2). Change subject: Add kill cluster marker to KMS .. Add kill cluster marker to KMS

[Impala-CR](cdh5-trunk) Add kill cluster marker to KMS

2016-06-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/3354 Change subject: Add kill cluster marker to KMS .. Add kill cluster marker to KMS If PID files of each process in the mini cluster

[Impala-CR](cdh5-trunk) IMPALA-3335: enable single-node optimizaion with joins

2016-06-01 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3335: enable single-node optimizaion with joins .. Patch Set 5: Code-Review+2 Rebased, forwarding +2 -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-3335: enable single-node optimizaion with joins

2016-06-01 Thread Taras Bobrovytsky (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3161 to look at the new patch set (#5). Change subject: IMPALA-3335: enable single-node optimizaion with joins

[Impala-CR](cdh5-trunk) IMPALA-3335: enable single-node optimizaion with joins

2016-05-26 Thread Taras Bobrovytsky (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3161 to look at the new patch set (#4). Change subject: IMPALA-3335: enable single-node optimizaion with joins

[Impala-CR](cdh5-trunk) IMPALA-3335: enable single-node optimizaion with joins

2016-05-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3335: enable single-node optimizaion with joins .. Patch Set 4: Code-Review+2 Rebased, forwarding the +2. -- To view, visit

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-25 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Patch Set 7: Thanks for the review, Dan! -- To view, visit http://gerrit.cloudera.org:8080/3154 To

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-25 Thread Taras Bobrovytsky (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3154 to look at the new patch set (#7). Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. IMPALA-3163: Fix

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-25 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/3154/6//COMMIT_MSG Commit Message: Line 14:

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-25 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3154/5/be/src/exprs/decimal-operators-ir.cc

[Impala-CR](cdh5-trunk) IMPALA-3335: enable single-node optimizaion with joins

2016-05-24 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-3335: enable single-node optimizaion with joins .. IMPALA-3335: enable single-node optimizaion with joins Before this patch, if a query contained

[Impala-CR](cdh5-trunk) IMPALA-3335: enable single-node optimizaion with joins

2016-05-24 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3335: enable single-node optimizaion with joins .. Patch Set 2: (3 comments)

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-24 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. IMPALA-3163: Fix Decimal to Timestamp casting Before this patch, we would first convert the Decimal to

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-24 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3154/3/be/src/exprs/decimal-operators-ir.cc

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3581: Change location of minidump folders to log_dir .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3171 To

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3581: Change location of minidump folders to log_dir .. Patch Set 5: (3 comments)

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-24 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. IMPALA-3163: Fix Decimal to Timestamp casting Before this patch, we would first convert the Decimal to

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3581: Change location of minidump folders to log_dir .. Patch Set 4: (6 comments)

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3581: Change location of minidump folders to log_dir

2016-05-24 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3581: Change location of minidump folders to log_dir .. Patch Set 3: Code-Review+2 LGTM -- To view, visit http://gerrit.cloudera.org:8080/3171 To

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. IMPALA-3163: Fix Decimal to Timestamp casting Before this patch, we would first convert the Decimal to

[Impala-CR](cdh5-trunk) IMPALA-3335: enable single-node optimizaion with joins

2016-05-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-3335: enable single-node optimizaion with joins .. IMPALA-3335: enable single-node optimizaion with joins Before this patch, if a query contained

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3335: enable single-node optimizaion with joins

2016-05-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has abandoned this change. Change subject: IMPALA-3335: enable single-node optimizaion with joins .. Abandoned wrong branch -- To view, visit http://gerrit.cloudera.org:8080/3180 To unsubscribe, visit

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3335: enable single-node optimizaion with joins

2016-05-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/3180 Change subject: IMPALA-3335: enable single-node optimizaion with joins .. IMPALA-3335: enable single-node optimizaion with joins

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. IMPALA-3163: Fix Decimal to Timestamp casting Before this patch, we would first convert the Decimal to

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3154/1/be/src/exprs/decimal-operators-ir.cc

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3154/1/be/src/exprs/decimal-operators-ir.cc

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3154/1//COMMIT_MSG Commit Message: Line 14:

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Patch Set 1: -Code-Review (3 comments)

[Impala-CR](cdh5-2.6.0_5.8.0) CDH-39818 ADDENDUM: Change time format in minidump collection script

2016-05-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has submitted this change and it was merged. Change subject: CDH-39818 ADDENDUM: Change time format in minidump collection script .. CDH-39818 ADDENDUM: Change time format in minidump collection script

[Impala-CR](cdh5-2.6.0_5.8.0) CDH-39818 ADDENDUM: Change time format in minidump collection script

2016-05-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: CDH-39818 ADDENDUM: Change time format in minidump collection script .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3163 To

[Impala-CR](cdh5-2.6.0_5.8.0) CDH-39818 ADDENDUM: Change time format in minidump collection script

2016-05-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/3163 Change subject: CDH-39818 ADDENDUM: Change time format in minidump collection script .. CDH-39818 ADDENDUM: Change time format in

[Impala-CR](cdh5-trunk) CDH-39818 ADDENDUM: Change time format in minidump collection script

2016-05-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has abandoned this change. Change subject: CDH-39818 ADDENDUM: Change time format in minidump collection script .. Abandoned This should be on the release branch, cherry picked to

[Impala-CR](cdh5-trunk) CDH-39818 ADDENDUM: Change time format in minidump collection script

2016-05-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/3162 Change subject: CDH-39818 ADDENDUM: Change time format in minidump collection script .. CDH-39818 ADDENDUM: Change time format in

[Impala-CR](cdh5-trunk) IMPALA-3335: enable single-node optimizaion with joins

2016-05-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/3161 Change subject: IMPALA-3335: enable single-node optimizaion with joins .. IMPALA-3335: enable single-node optimizaion with joins

[Impala-CR](cdh5-trunk) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has abandoned this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Abandoned Cherry picked to the release branch -- To view, visit http://gerrit.cloudera.org:8080/2791 To

[Impala-CR](cdh5-trunk) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/2791/8/be/src/exprs/decimal-operators-ir.cc

[Impala-CR](cdh5-trunk) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Patch Set 9: Code-Review+1 Carrying the +1. -- To view, visit http://gerrit.cloudera.org:8080/2791 To

[Impala-CR](cdh5-trunk) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-18 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2791 to look at the new patch set (#9). Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. IMPALA-3163: Fix

[Impala-CR](cdh5-trunk) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/2791/7//COMMIT_MSG Commit Message: Line 12:

[Impala-CR](cdh5-trunk) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#8). Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. IMPALA-3163: Fix Decimal to Timestamp casting Before this patch, we would first convert the Decimal to

[Impala-CR](cdh5-trunk) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Patch Set 5: (11 comments) http://gerrit.cloudera.org:8080/#/c/2791/5/be/src/exprs/decimal-operators-ir.cc

[Impala-CR](cdh5-trunk) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. IMPALA-3163: Fix Decimal to Timestamp casting Before this patch, we would first convert the Decimal to

[Impala-CR](cdh5-trunk) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. IMPALA-3163: Fix Decimal to Timestamp casting Before this patch, we would first convert the Decimal to

[Impala-CR](cdh5-trunk) IMPALA-3491: Use unique_database fixture in test_data_errors.py.

2016-05-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3491: Use unique_database fixture in test_data_errors.py. .. Patch Set 1: (1 comment)

[Impala-CR](cdh5-trunk) Preview: IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: Preview: IMPALA-3163: Fix Decimal to Timestamp casting .. Preview: IMPALA-3163: Fix Decimal to Timestamp casting Change-Id:

[Impala-CR](cdh5-trunk) Preview: IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: Preview: IMPALA-3163: Fix Decimal to Timestamp casting .. Preview: IMPALA-3163: Fix Decimal to Timestamp casting Change-Id:

[Impala-CR](cdh5-trunk) IMPALA-3489: Add script to extract breakpad symbols from binaries

2016-05-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3489: Add script to extract breakpad symbols from binaries .. Patch Set 6: Code-Review+1 lgtm, not sure who should give the final +2. -- To view,

[Impala-CR](cdh5-trunk) CDH-39818: Add Breakpad minidump collection script

2016-05-12 Thread Taras Bobrovytsky (Code Review)
Hello Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2997 to look at the new patch set (#7). Change subject: CDH-39818: Add Breakpad minidump collection script ..

[Impala-CR](cdh5-trunk) CDH-39818: Add Breakpad minidump collection script

2016-05-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: CDH-39818: Add Breakpad minidump collection script .. Patch Set 7: Code-Review+1 Carrying the +1 -- To view, visit http://gerrit.cloudera.org:8080/2997 To

[Impala-CR](cdh5-trunk) IMPALA-3232: Allow not-exists uncorrelated subqueries

2016-05-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3232: Allow not-exists uncorrelated subqueries .. Patch Set 5: Code-Review+2 Minor change, carrying the +2. -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-3232: Allow not-exists uncorrelated subqueries

2016-05-12 Thread Taras Bobrovytsky (Code Review)
Hello Internal Jenkins, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2792 to look at the new patch set (#5). Change subject: IMPALA-3232: Allow not-exists uncorrelated subqueries

  1   2   >