Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Ha, English, my favorite part. When I was 10, I learned my first 2 sentences of English: 1. Long life Chairman Mao! 2. Good morning comrade ... Gray We are a worldwide community, please keep communication as simple as possible. Good morning comrade everybody, Shi Jinghai -邮件原件- 发件人:

Re: Use ecomseo on demo rather than ecommerce

Well for me it's a -1 until I hear some positive reviews from other users (and ideally committers). I don't like having two ecommerce webapps and my preference would be to merge the two into one, but I can't promote that idea without any group consensus that the SEO approach is good and well

Re: svn commit: r1761687 - /ofbiz/trunk/specialpurpose/myportal/widget/PortalAdmForms.xml

Thanks a lot Jacques for this sentence Nicolas Le 22/09/2016 à 17:55, Jacques Le Roux a écrit : Now I'm thinking: there is a reason why people think <>. So I will add a small sentence saying to look before for a possible

Re: getNextSeqId and multiple sequence on entity

It seems this has never be implement, any reasons? Thanks Jacques Le 01/04/2010 à 15:52, Brett Palmer a écrit : Nicolas, Thanks I'll take a look at it. Brett On Thu, Apr 1, 2010 at 6:48 AM, Nicolas Malin

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Hi Jinghai, Yes you are right, something we should remember. I'll try... Jacques Le 23/09/2016 à 03:04, Shi Jinghai a écrit : Ha, English, my favorite part. When I was 10, I learned my first 2 sentences of English: 1. Long life Chairman Mao! 2. Good morning comrade ... Gray We are a

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Le 22/09/2016 à 18:06, Michael Brohl a écrit : Hi Rupert, Jacques, all, if I search Google for it, I find many different opinions. For example, here is a viarant from the Git documentation

Groovy Style guide

Hi, I suggest we include the "Groovy Style guide" http://www.groovy-lang.org/style-guide.html at https://cwiki.apache.org/confluence/display/OFBADMIN/Coding+Conventions It's not about formatting, I did not find anything on Groovy formatting in a quick research, but is still interesting.

Re: Formatting in *.gradle files

This seems basically done with r1761998, not much was actually needed Jacques Le 22/09/2016 à 19:04, Jacques Le Roux a écrit : Hi, This is mostly for Taher but concern all of us. I noticed several times that we don't always format *.gradle files following the Java Code Conventions we follow

Re: Put "Reverts" in the commit template?

Hi Jacopo, What is the logical behind this? It's not the first time I ask and I'd really like to have a clarification. We have "Fix for" and "Documentation". Why not "Fixed" and "Documented"? Thanks Jacques Le 21/09/2016 à 19:09, Jacopo Cappellato a écrit : I have changed it to "Reverted"

Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Jacopo, I saw you answered on Confluence where I 1st asked https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+commit+message+template?focusedCommentId=65871637#comment-65871637 Now, I understand that we need to pick a word, but why not being more flexible, similarly at what does

Re: Permission service not on the same transaction

Hi Rishi, in line Le 19/09/2016 à 16:20, Rishi Solanki a écrit : Nicolas, "If you are dealing with money, or precision is a must, use BigDecimal. Otherwise Doubles tend to be good enough." That means, for quantity fields double should be fine. But within OFBiz, I see entities like OrderItem,

Re: Put "Reverts" in the commit template?

I have answered you in the Wiki but quoting here for everyone's convenience: "Jacques, for me it is a done deal! As you suggests we could change: - Documentation --> Documented - Fix for --> Fixed And the final list of verbs will be:

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

On Thu, Sep 22, 2016 at 9:36 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Jacopo, > > I saw you answered on Confluence where I 1st asked > https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+ > commit+message+template?focusedCommentId=65871637#comment-65871637 > > Now, I

Re: Use ecomseo on demo rather than ecommerce

OK forget it for now. I just realised that ecomseo starts with R15. So you can still get to it in trunk demo using https://ofbiz-vm.apache.org:8443/ecomseo but it will available to users from official site main page only when we will roll out R16 But mmm, I vaguely remember having proposed to

Re: Use ecomseo on demo rather than ecommerce

By the way, is there any technical or user documentation for it? I haven't looked at it and don't have time to review the actual implementation right now. The link you provided doesn't offer much more than a sales pitch. Regards Scott On 22 September 2016 at 23:22, Scott Gray

Re: svn commit: r1761687 - /ofbiz/trunk/specialpurpose/myportal/widget/PortalAdmForms.xml

I see no improvement to use a dedicate title as same the FormFieldTitle. More a form is light, more is readable and maintainable. Yes I'm lazy, and it's good for my healthy :) If we change or improve the engine for the label, all specific use would be manage direclty. On the other way, if

Re: svn commit: r1761111 - /ofbiz/trunk/specialpurpose/scrum/widget/

Hi Amardeep, thank you very much for reporting! Would you mind creating a Jira, I'll fix it this evening. Thanks, Michael Am 22.09.16 um 13:24 schrieb Amardeep Singh Jhajj: Hi Michael, Scrum main page is not working. Getting error: org.xml.sax.SAXParseException; systemId:

Re: Use ecomseo on demo rather than ecommerce

> > This mostly to somehow battle test it, even if I know it works well So does it need battle testing or does it work well? Have you deployed it to any production instances? Has anyone else? Regards Scott On 19 September 2016 at 01:27, Jacques Le Roux wrote:

Re: svn commit: r1761687 - /ofbiz/trunk/specialpurpose/myportal/widget/PortalAdmForms.xml

Thanks for the reminder Nicolas, since nobody opposes I reverted at revision: 1761923 Jacques Le 22/09/2016 à 13:36, Nicolas Malin a écrit : I see no improvement to use a dedicate title as same the FormFieldTitle. More a form is light, more is readable and maintainable. Yes I'm lazy, and

Re: svn commit: r1761111 - /ofbiz/trunk/specialpurpose/scrum/widget/

Hi Michael, Scrum main page is not working. Getting error: org.xml.sax.SAXParseException; systemId: file:/sandbox/ofbiz/specialpur pose/scrum/widget/scrumScreens.xml; lineNumber: 2342; columnNumber: 107; Open quote is expected for attribute "name" associated with an element type "include-form".

Re: Use ecomseo on demo rather than ecommerce

Le 22/09/2016 à 13:22, Scott Gray a écrit : This mostly to somehow battle test it, even if I know it works well So does it need battle testing or does it work well? It works well for me. Have you deployed it to any production instances? Not directly, that's why I want it as default OFBiz

Re: svn commit: r1761111 - /ofbiz/trunk/specialpurpose/scrum/widget/

Here is the jira ticket- https://issues.apache.org/jira/browse/OFBIZ-8318 Thanks, -- Amardeep Singh Jhajj On Thu, Sep 22, 2016 at 5:22 PM, Michael Brohl wrote: > Hi Amardeep, > > thank you very much for reporting! > > Would you mind creating a Jira, I'll fix it this

Re: Use ecomseo on demo rather than ecommerce

https://issues.apache.org/jira/browse/OFBIZ-5312 More at https://issues.apache.org/jira/browse/OFBIZ-2214?jql=project%20%3D%20OFBIZ%20AND%20text%20~%20%22seo%22 Jacques Le 22/09/2016 à 13:25, Scott Gray a écrit : By the way, is there any technical or user documentation for it? I haven't

Re: Apache POI 3.15 released

+1, the only one reason to don't update a extern lib is le testIntegration failure Nicolas Le 22/09/2016 à 06:42, Taher Alkhateeb a écrit : +1 always to update to stable new releases On Thu, Sep 22, 2016 at 2:22 AM, Michael Brohl wrote: Hi everyone, Apache POI

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

I can't believe you're being so stubborn about something so minor Jacques, it seems like very strange behavior to me. For what it's worth as a native English speaker, reading a commit message written in present-tense feels very strange to me. I'm looking at a history and reading something as

Re: svn commit: r1761687 - /ofbiz/trunk/specialpurpose/myportal/widget/PortalAdmForms.xml

Now I'm thinking: there is a reason why people think <>. So I will add a small sentence saying to look before for a possible FormFieldTitle_ in the autocompletion help (widget-form.xsd) Jacques Le 22/09/2016 à 14:22, Jacques Le Roux a

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Hi Rupert, Jacques, all, if I search Google for it, I find many different opinions. For example, here is a viarant from the Git documentation http://git.kernel.org/?p=git/git.git;a=blob;f=Documentation/SubmittingPatches;h=ece3c77482b3ff006b973f1ed90b708e26556862;hb=HEAD "the body should

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Scott, Reading your message I guess you did not read my previous explanation on why I prefer to use present instead of past. You may find more details in digging in previous emails. But long story short, I'm French so I can't compete in English with someone like you for who English is the

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Hi yes, reading with interest, I agree with Jacques. Commit messages should be Present Tense Imperative, Imperative Style. There's plenty of links on Google as to why this is the widely adopted industry standard. On 22 September 2016 at 16:06, Jacques Le Roux

About our LICENSE and NOTICE requirements

Hi all, after carefully reading the Apache licensing howto [*], my understanding is that our LICENSE and NOTICE files must be drastically simplified because, since we are no more bundling the external dependencies, these shall not be included in them. Please read the document referenced below (it

Re: About our LICENSE and NOTICE requirements

Jacopo, I agree, seems to be clearly stated: "LICENSE and NOTICE must always be tailored to the content of the specific distribution they reside within. Dependencies which are not included in the distribution MUST NOT be added to LICENSE and NOTICE. As far as LICENSE and NOTICE are

Re: About our LICENSE and NOTICE requirements

+1 .. thank you for the research On Sep 22, 2016 10:35 PM, "Michael Brohl" wrote: > Jacopo, > > I agree, seems to be clearly stated: > > "LICENSE and NOTICE must always be tailored to the content of the specific > distribution they reside within. Dependencies which are

Re: About our LICENSE and NOTICE requirements

After reading this page and what it tells about "/only bundled bits matter."/ I trust we can remove all the lines which concern *.jar files Then it will easier to think about the other bits and we will need to keep lines like framework/images/webapp/images/date/timezones/*

Re: Formatting in *.gradle files

In Eclipse, after checking the Minimalist Gradle Editor, The Gradle Build Script editor and the Groovy Editor have no formatting options, I tried to automatically format common.gradle (which is actually well formatted) using the Java editor and the result is worse (less legible) Index:

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Michael, Thanks for calling the conversation stupid, you could have refrained on this :/ For the rest I'm done, I tried to put a bit more of flexibility in this template, but since nobody cares (apart Rupert, thanks!), let it be. Now you ALL must comply... -0 (minus zero) Jacques Le

Formatting in *.gradle files

Hi, This is mostly for Taher but concern all of us. I noticed several times that we don't always format *.gradle files following the Java Code Conventions we follow for the rest (ie *.java and *.groovy) https://cwiki.apache.org/confluence/display/OFBADMIN/Coding+Conventions We should use the

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

On Thu, Sep 22, 2016 at 5:21 PM, Rupert Howell wrote: > Hi yes, reading with interest, I agree with Jacques. > Commit messages should be Present Tense Imperative, Imperative Style. > well, now I am a bit confused because Jacques is using Present Tense in Third Person