Re: Review Request 55616: The SYNC_SOURCE atribute only supports unix and ldap for ranger usersync at present, it's default value should be unix. Current the installation process directly exited becau

2017-01-19 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55616/#review162261 --- Ship it! Ship It! - Colm O hEigeartaigh On Jan. 19, 2017, 8

Re: Review Request 55166: There was a logical error in parsing the configuration file when executing the database script.

2017-01-19 Thread Colm O hEigeartaigh
ine = each_line.strip() It's probably better to create a new variable here, instead of assigning the value to the variable defined in the for loop. - Colm O hEigeartaigh On Jan. 19, 2017, 6:37 a.m., Qiang Zhang wrote: > > --- > This is

Re: Review Request 55702: There are two defects in install scripts for ranger usersync process

2017-01-19 Thread Colm O hEigeartaigh
se_dir = /opt/ranger Shouldn't this be /etc/ranger? - Colm O hEigeartaigh On Jan. 19, 2017, 3:41 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

0.6.3 release?

2017-01-24 Thread Colm O hEigeartaigh
Hi all, What is the status of the 0.6.3 release? I was under the impression the vote had already taken place, but I don't see the released artifacts in the distribution. Colm. -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: 0.6.3 release?

2017-01-24 Thread Colm O hEigeartaigh
ought up during IPMC vote. I see that > you have raised https://issues.apache.org/jira/browse/RANGER-1326 for > that. > > From: Colm O hEigeartaigh > Reply-To: "dev@ranger.apache.org" , " > cohei...@apache.org" > Date: Tuesday, January 24, 2017 at 4:24 A

Re: [VOTE] Release Apache Ranger 0.6.3 - release candidate 1 (dev group vote)

2017-01-27 Thread Colm O hEigeartaigh
tar.gz.asc > MD5/SHA Hash: > https://dist.apache.org/repos/dist/dev/ranger/0.6.3-rc1/ > apache-ranger-0.6.3.tar.gz.mds > > Keys to verify the signature of the release artifact are available at: > https://people.apache.org/keys/group/ranger.asc > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: [VOTE] Release Apache Ranger 0.6.3 - release candidate 1 (dev group vote)

2017-01-27 Thread Colm O hEigeartaigh
e. +1 on the release btw. Colm. On Fri, Jan 27, 2017 at 11:18 AM, Velmurugan Periasamy wrote: > Hi Colm - provided this vote is successful, I am assuming RC1 can be > released as 0.6.3. Is there a separate process that needs to be followed? > > > On Jan 27, 2017, at 6:08 AM, Colm

Fwd: svn commit: r1781018 - in /incubator/ranger/site/trunk: download.html faq.html index.html issue-tracking.html license.html mail-lists.html project-info.html project-summary.html quick_start_guide

2017-01-31 Thread Colm O hEigeartaigh
team-list.html?rev=1781018&r1=1781017&r2=1781018&view=diff ==== == --- incubator/ranger/site/trunk/team-list.html (original) +++ incubator/ranger/site/trunk/team-list.html Tue Jan 31 04:49:16 2017 @@ -193,6 +193,13 @@ 0.6.2 + + + + https://cwiki.apache. org/confluence/display/RANGER/Apache+Ranger+0.6.3+-+Release+Notes" class="externalLink" title="0.6.3"> + +0.6.3 + -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Review Request 55669: RANGER-1318 - Consolidate XML configuration parsing

2017-02-01 Thread Colm O hEigeartaigh
/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 4b56936 Diff: https://reviews.apache.org/r/55669/diff/ Testing --- Thanks, Colm O hEigeartaigh

Re: svn commit: r1781018 - in /incubator/ranger/site/trunk: download.html faq.html index.html issue-tracking.html license.html mail-lists.html project-info.html project-summary.html quick_start_guide.

2017-02-03 Thread Colm O hEigeartaigh
incubator/ranger/site/trunk: > download.html faq.html index.html issue-tracking.html license.html > mail-lists.html project-info.html project-summary.html > quick_start_guide.html team-list.html > > Thanks Colm, I will file an INFRA jira to get this fixed. > > Selva- > > > On

Re: Code-style

2017-02-03 Thread Colm O hEigeartaigh
se(x) > > Again, please submit a patch for this. Colm. > What do you think, is it worth working on these? > > Best regards, > Zsombor > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Review Request 56280: RANGER-1347 - The AtlasClient should fall back to the plain password if the password decryption fails

2017-02-03 Thread Colm O hEigeartaigh
- plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java 4f90469 Diff: https://reviews.apache.org/r/56280/diff/ Testing --- Thanks, Colm O hEigeartaigh

Re: Review Request 55166: There was a logical error in parsing the configuration file when executing the database script.

2017-02-06 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55166/#review164325 --- Ship it! Ship It! - Colm O hEigeartaigh On Jan. 19, 2017, 3

Re: Review Request 56303: Code block was iterated four times, in fact it should only be executed once during initializing InitD for ranger usersync process

2017-02-06 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56303/#review164329 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 4, 2017, 8

Re: Review Request 56309: [RANGER-1351] Fix loggers to be final static fields

2017-02-06 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56309/#review164330 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 4, 2017, 10

Review Board requests

2017-02-06 Thread Colm O hEigeartaigh
? Colm. -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Review Request 55709: There were logic errors in create_rangerdb_user and grant_xa_db_user function.

2017-02-07 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55709/#review164479 --- Ship it! Ship It! - Colm O hEigeartaigh On Jan. 19, 2017, 7

Re: Review Request 56320: NameRules should be set to the default value in Kerberized Environment

2017-02-07 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56320/#review164483 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 7, 2017, 1

Re: Review Request 56372: The installer does not filter out comments lines for the configuration file when installing the Ranger UserSync Process

2017-02-07 Thread Colm O hEigeartaigh
could fix that as well as part of this patch? - Colm O hEigeartaigh On Feb. 7, 2017, 3:59 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 56306: RANGER-1350: Fix generic type usage, removing SuppressWarning annotations

2017-02-07 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56306/#review164486 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 4, 2017, 1

Re: Review Request 55669: RANGER-1318 - Consolidate XML configuration parsing

2017-02-08 Thread Colm O hEigeartaigh
unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 4b56936 Diff: https://reviews.apache.org/r/55669/diff/ Testing --- Thanks, Colm O hEigeartaigh

Re: Review Request 56432: RANGER-1363:BadCredentialsException when login

2017-02-08 Thread Colm O hEigeartaigh
-256 failure. Something along the lines of "Authentiation with SHA-256 failed. Now trying with MD5". - Colm O hEigeartaigh On Feb. 8, 2017, 7:30 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 56372: The installer does not filter out comments lines for the configuration file when installing the Ranger UserSync Process and tagsync

2017-02-08 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56372/#review164655 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 7, 2017, 1

Re: Review Request 56431: The installer of the usersync and unixauthservice can be executed when JAVA_HOME environment variable was set empty. The result is that there are many errors when installing

2017-02-08 Thread Colm O hEigeartaigh
is a directory, rather than just checking to see if it's empty (in both scripts) - Colm O hEigeartaigh On Feb. 8, 2017, 7:01 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 56382: RANGER-1359:Remove unnecessary spring dependency

2017-02-08 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56382/#review164659 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 7, 2017, 11

Re: Prep for ranger-0.7 release ...

2017-02-08 Thread Colm O hEigeartaigh
e. > > I am Volunteering to be the release manager for ranger 0.7 release. > > Please let me know if any of you have any concerns and/or suggestions on > the release process. > > Thanks, > Selva- > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Review Request 56431: The installer of the usersync and unixauthservice can be executed when JAVA_HOME environment variable was set empty. The result is that there are many errors when installing

2017-02-09 Thread Colm O hEigeartaigh
> On Feb. 8, 2017, 9:53 a.m., Colm O hEigeartaigh wrote: > > We should go further, and check to see if the JAVA_HOME variable is a > > directory, rather than just checking to see if it's empty (in both scripts) > > Qiang Zhang wrote: > Ok. I agree with your

Re: Review Request 56432: RANGER-1363:BadCredentialsException when login

2017-02-09 Thread Colm O hEigeartaigh
#x27;t appear in the logs. And keep the new "info" log that says it's falling back to MD5. - Colm O hEigeartaigh On Feb. 8, 2017, 11:12 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 56477: No log was logged when some errors occurred in classes for the Unix Authentication Service.

2017-02-09 Thread Colm O hEigeartaigh
ght error level here. Perhaps DEBUG would be better. - Colm O hEigeartaigh On Feb. 9, 2017, 3:39 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Review Request 56489: RANGER-1354 - "Error on Atlas plugin install"

2017-02-09 Thread Colm O hEigeartaigh
d to create the "libext" directory in the Atlas distribution if it doesn't already exist. Diffs - agents-common/scripts/enable-agent.sh b8b79a9 Diff: https://reviews.apache.org/r/56489/diff/ Testing --- I tested the changed script with an Atlas distribution. Thanks, Colm O hEigeartaigh

Re: Review Request 56432: RANGER-1363:BadCredentialsException when login

2017-02-09 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56432/#review164900 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 9, 2017, 11

Re: Review Request 56431: The installer of the usersync and unixauthservice can be executed when JAVA_HOME environment variable was set empty. The result is that there are many errors when installing

2017-02-09 Thread Colm O hEigeartaigh
> On Feb. 8, 2017, 9:53 a.m., Colm O hEigeartaigh wrote: > > We should go further, and check to see if the JAVA_HOME variable is a > > directory, rather than just checking to see if it's empty (in both scripts) > > Qiang Zhang wrote: > Ok. I agree with your

Re: Review Request 56431: The installer of the usersync and unixauthservice can be executed when JAVA_HOME environment variable was set empty. The result is that there are many errors when installing

2017-02-09 Thread Colm O hEigeartaigh
> On Feb. 8, 2017, 9:53 a.m., Colm O hEigeartaigh wrote: > > We should go further, and check to see if the JAVA_HOME variable is a > > directory, rather than just checking to see if it's empty (in both scripts) > > Qiang Zhang wrote: > Ok. I agree with your

Re: Review Request 56477: No log was logged when some errors occurred in classes for the Unix Authentication Service.

2017-02-09 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56477/#review164911 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 9, 2017, 12

Re: Review Request 56431: The installer of the usersync and unixauthservice can be executed when JAVA_HOME environment variable was set empty. The result is that there are many errors when installing

2017-02-09 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56431/#review164914 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 9, 2017, 12

Re: Prep for ranger-0.7 release ...

2017-02-09 Thread Colm O hEigeartaigh
icked into ranger-0.7 release. > > > > I am Volunteering to be the release manager for ranger 0.7 release. > > > > Please let me know if any of you have any concerns and/or > suggestions on > > the release process. > > > > Thanks, > > Selva- > > > > > > > > > -- > Colm O hEigeartaigh > > Talend Community Coder > http://coders.talend.com > > > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Prep for ranger-0.7 release ...

2017-02-09 Thread Colm O hEigeartaigh
Great, thanks. I'll update master to 1.0.0-SNAPSHOT. Colm. On Thu, Feb 9, 2017 at 2:42 PM, Selvamohan Neethiraj wrote: > Sorry, I missed the ‘git push’ … It should be available now. > > Thanks, > Selva- > > From: Colm O hEigeartaigh > Reply-To: "dev

Re: Review Request 56528: There are some errors when I used 'sudo ranger-usersync start' command to run the Ranger UserSync Process in ubuntu 16.04.

2017-02-10 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56528/#review165091 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 10, 2017, 4

Re: Review Request 56536: When exceptions occur during using ChangePasswordUtil tool to update admin password, the program doesn't record error messages.

2017-02-10 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56536/#review165092 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 10, 2017, 9

Re: Review Request 55256: RANGER-1289:Error occured in Ranger KMS function

2017-02-10 Thread Colm O hEigeartaigh
4.5.3 for consistency. Also, the httpcore dependency should be changed to 4.4.6, as this is the version that is associated with httpclient 4.5.3. - Colm O hEigeartaigh On Feb. 10, 2017, 8:19 a.m., Qiang Zhang wrote: > > --- > T

Re: Review Request 56496: RANGER-1370 : fix the createdByUserId to be a private final instance variable, and improve the PropertiesUtil

2017-02-10 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56496/#review165098 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 9, 2017, 1

Re: Review Request 56497: RANGER-1371 : reduce the verboseness

2017-02-10 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56497/#review165121 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 9, 2017, 1

Re: Review Request 56579: [RANGER-1377] - code cleanup in agents-common module

2017-02-13 Thread Colm O hEigeartaigh
of (removing Integer.toString() in RangerDefaultAuditHandler) - Colm O hEigeartaigh On Feb. 12, 2017, 2:36 p.m., Zsombor Gegesy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 56579: [RANGER-1377] - code cleanup in agents-common module

2017-02-13 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56579/#review165315 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 12, 2017, 2

Re: Review Request 55256: RANGER-1289:Error occured in Ranger KMS function

2017-02-13 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55256/#review165316 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 13, 2017, 2

Fwd: ranger git commit: RANGER-1289:Error occured in Ranger KMS function

2017-02-13 Thread Colm O hEigeartaigh
...@ranger.apache.org Repository: ranger Updated Branches: refs/heads/master 4e414fd89 -> bc61f4bac RANGER-1289:Error occured in Ranger KMS function Signed-off-by: Colm O hEigeartaigh Project: http://git-wip-us.apache.org/repos/asf/ranger/repo Commit: http://git-wip-us.apache.org/repos/

Re: Review Request 56578: [RANGER-1376] Upgrade jersey to 1.19.3 and trying to remove version duplication

2017-02-13 Thread Colm O hEigeartaigh
? No need to create a new review request, just attach two separate patches to the JIRA. Also, the patch doesn't apply due to some changes on master since the patch was submitted. - Colm O hEigeartaigh On Feb. 12, 2017, 1:29 p.m., Zsombor Gegesy

Re: Review Request 55669: RANGER-1318 - Consolidate XML configuration parsing

2017-02-13 Thread Colm O hEigeartaigh
/jaas/RemoteUnixLoginModule.java 178eb53 unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 175307f Diff: https://reviews.apache.org/r/55669/diff/ Testing --- Thanks, Colm O hEigeartaigh

Re: Review Request 56578: [RANGER-1376] Upgrade jersey to 1.19.3 and trying to remove version duplication

2017-02-14 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56578/#review165484 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 12, 2017, 1

Review Request 56658: RANGER-1384 - Replace old asm version

2017-02-14 Thread Colm O hEigeartaigh
atch and the Jersey patch for RANGER-1376. Thanks, Colm O hEigeartaigh

Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly

2017-02-15 Thread Colm O hEigeartaigh
as it's difficult to see what the changes are in some of the files (e.g. are there changes in RangerServiceAtlas.java)? - Colm O hEigeartaigh On Feb. 14, 2017, 11:23 a.m., Qiang Zhang wrote: > > --- > This is an automatical

Re: Review Request 56580: [RANGER-1377] - code cleanup in security-admin module

2017-02-15 Thread Colm O hEigeartaigh
0.7 out before applying this to master. - Colm O hEigeartaigh On Feb. 13, 2017, 3:44 p.m., Zsombor Gegesy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 56736: RANGER-1385:UnixAuthenticationService may fails in Widows as the "/" is different from "\"

2017-02-16 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56736/#review165819 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 16, 2017

Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly

2017-02-16 Thread Colm O hEigeartaigh
> On Feb. 15, 2017, 10:53 a.m., Colm O hEigeartaigh wrote: > > Thanks for the patch! Could you strip out the indentation changes as it's > > difficult to see what the changes are in some of the files (e.g. are there > > changes in RangerServiceAtlas.java)? >

Re: Review Board requests

2017-02-16 Thread Colm O hEigeartaigh
tted" if the patches have been applied. In particular, kulkabhay and rmani have a lot of outstanding review requests, thanks! Colm. On Mon, Feb 13, 2017 at 10:43 PM, Don Bosco Durai wrote: > Does anyone one know how about to do it? > > Thanks > > Bosco > > >

Review Request 56760: RANGER-1388: Improve error messages in AtlasKafkaResourceMapper

2017-02-16 Thread Colm O hEigeartaigh
eport that the cluster name is not found in the qualified name attribute. Diffs - tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java 9f1fc2d Diff: https://reviews.apache.org/r/56760/diff/ Testing --- Thanks, Colm O hEigeartaigh

Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly

2017-02-16 Thread Colm O hEigeartaigh
> On Feb. 15, 2017, 10:53 a.m., Colm O hEigeartaigh wrote: > > Thanks for the patch! Could you strip out the indentation changes as it's > > difficult to see what the changes are in some of the files (e.g. are there > > changes in RangerServiceAtlas.java)? >

Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly

2017-02-16 Thread Colm O hEigeartaigh
. d) The indentation of Results class is not right in ResourceOperationResponse e) In AtlasClient, I think you could have a single method to create a Client, rather than creating one for each of the resources. - Colm O hEigeartaigh

Re: Review Request 56780: RANGER-1391:Error occurred when use EndDate as Search Filter in Audit Access WebPage

2017-02-17 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56780/#review165921 --- Test (ignore) - Colm O hEigeartaigh On Feb. 17, 2017, 7:54 a.m

Re: Review Request 56780: RANGER-1391:Error occurred when use EndDate as Search Filter in Audit Access WebPage

2017-02-17 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56780/#review165922 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 17, 2017, 7

Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly

2017-02-17 Thread Colm O hEigeartaigh
NT;" f) AtlasClient: Change this to 'username': LOG.error("No value found for configuration 'usename'. g) AtlasClient: Indentation wrong on line 315 "return lret;" h) AtlasClient: Indentation wrong in the try block: lines 121 -> 135 i) AtlasClient: getStatu

Re: Plan on kicking off release - ranger-0.7 release on Monday (02/20/2017)

2017-02-17 Thread Colm O hEigeartaigh
se let me know if any of you have any concerns and/or suggestions on > the release process. > > Thanks, > Selva- > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Rangers: Need help to move 9 open JIRA(s) to either RESOLVED state or move out to 1.0.0 version ....

2017-02-20 Thread Colm O hEigeartaigh
I: I have disabled the build.apache.org Jenkin Job that > was publishing our 0.7.0-SNAPSHOT libraries to Apache (since we have > changed the version to 0.7.0 and the release is not yet approved). > > > > Thanks, > > Selva- > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Review Request 56739: RANGER-1387:Remove unused SQL_CONNECTOR_JAR in install.properties of ranger plugin

2017-02-20 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56739/#review166069 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 16, 2017, 7

Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly

2017-02-20 Thread Colm O hEigeartaigh
latest master, it doesn't apply as there was a change to AtlasClient. The other change I'd like to see is that there is still a "atlasResourceParamter" (instead of atlasResourceParameter) in AtlasResourceMgr. - Colm O hEigeartaigh On Feb. 18, 2017, 6:44 a.m

Re: Review Request 56844: There are error logs in SecureClientLogin class

2017-02-20 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56844/#review166076 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 20, 2017, 9

ReviewBoard email address

2017-02-21 Thread Colm O hEigeartaigh
Hi all, I got INFRA (https://issues.apache.org/jira/browse/INFRA-13536) to change the review board email address to remove the "incubator" part, in case anyone has any email filters they want to update... Colm. -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Review Request 56866: RANGER-1399:Do some code improvement in Java method SolrUtil.searchResources

2017-02-21 Thread Colm O hEigeartaigh
java object instanceof Date" to "Search field is not a Java Date Object". - Colm O hEigeartaigh On Feb. 21, 2017, 7:57 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 56862: RANGER-1397:Error method name in the printed logs

2017-02-21 Thread Colm O hEigeartaigh
IMO - Colm O hEigeartaigh On Feb. 21, 2017, 3:42 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: [VOTE] Apache Ranger Release 0.7.0 - rc1

2017-02-21 Thread Colm O hEigeartaigh
.org/confluence/display/RANGER/ > > Apache+Ranger+0.7.0+-+Release+Notes > > > > > > > > Build verification steps can be found at: > > > >http://ranger.apache.org/quick_start_guide.html > > > > > > > > The vote will be open for at least 72 hours or until necessary number of > > votes are reached. > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove (and reason why) > > > > > > > > Here is my +1 (binding). > > > > > > > > Thank you, > > > > Selva- > > > > > > > -- > Regards, > Gautam. > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Review Request 56879: RANGER-1402 - NPE if there is a problem with the HiveClient driverClassName

2017-02-21 Thread Colm O hEigeartaigh
che/ranger/services/hive/client/HiveConnectionMgr.java b36d5da Diff: https://reviews.apache.org/r/56879/diff/ Testing --- Tested that no NPE appears in the logs after the fix. Thanks, Colm O hEigeartaigh

Re: Review Request 56862: RANGER-1397:Error method name in the printed logs

2017-02-22 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56862/#review166343 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 21, 2017, 9

Re: Review Request 57017: When the error occurs, the system does not record the error message in RangerServiceService class

2017-02-27 Thread Colm O hEigeartaigh
change the variable name to uppercase. - Colm O hEigeartaigh On Feb. 24, 2017, 3:51 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 56827: [RANGER-1393] Fix generic types in RangerAuditFields

2017-02-27 Thread Colm O hEigeartaigh
" and then "git format-patch -n HEAD~" instead? - Colm O hEigeartaigh On Feb. 19, 2017, 9:41 p.m., Zsombor Gegesy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 56921: There is a problem in buildks class when delete invalid keystore file.

2017-02-27 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56921/#review166844 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 22, 2017, 7

Re: Review Request 56866: RANGER-1399:Do some code improvement in Java method SolrUtil.searchResources

2017-02-27 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56866/#review166847 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 21, 2017, 9

Re: Review Request 56888: [RANGER-1377] code cleanup in the security admin module - use collection.isEmpty

2017-02-27 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56888/#review166849 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 21, 2017, 3

Re: Review Request 56827: [RANGER-1393] Fix generic types in RangerAuditFields

2017-02-28 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56827/#review167037 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 27, 2017, 9

Re: Review Request 57017: When the error occurs, the system does not record the error message in RangerServiceService class

2017-02-28 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57017/#review167039 --- Ship it! Ship It! - Colm O hEigeartaigh On Feb. 27, 2017

Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly

2017-02-28 Thread Colm O hEigeartaigh
> On Feb. 20, 2017, 9:46 a.m., Colm O hEigeartaigh wrote: > > Thanks for making the changes. Could you update the patch to the latest > > master, it doesn't apply as there was a change to AtlasClient. The other > > change I'd like to see is that there is

Review Request 57239: RANGER-1416 - SunX509 is the hardcoded Algorithm for SSL

2017-03-02 Thread Colm O hEigeartaigh
Diffs - agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java ba3a82e agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSslHelper.java e0b0fd0 Diff: https://reviews.apache.org/r/57239/diff/1/ Testing --- Thanks, Colm O hEigeartaigh

Re: Review Request 57239: RANGER-1416 - SunX509 is the hardcoded Algorithm for SSL

2017-03-02 Thread Colm O hEigeartaigh
(updated) --- Tested Admin Server. Thanks, Colm O hEigeartaigh

Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly

2017-03-02 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review167669 --- Ship it! Ship It! - Colm O hEigeartaigh On March 1, 2017, 9

Re: Review Request 57270: In yarn plugin, there are some wrong logs.

2017-03-03 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57270/#review167800 --- Ship it! Ship It! - Colm O hEigeartaigh On March 3, 2017, 8

Re: Review Request 57271: RANGER-1420:Some error log information in ranger policy module

2017-03-03 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57271/#review167802 --- Ship it! Ship It! - Colm O hEigeartaigh On March 3, 2017, 9

Review Request 57285: RANGER-1421 - Add tag based authorization tests for the supported components

2017-03-03 Thread Colm O hEigeartaigh
26dc151 plugin-kafka/src/test/resources/kafka-policies-tag.json PRE-CREATION plugin-kafka/src/test/resources/kafka-policies.json cc1c927 plugin-kafka/src/test/resources/ranger-kafka-security.xml b2cc5f8 Diff: https://reviews.apache.org/r/57285/diff/1/ Testing --- Thanks, Colm O

Re: Review Request 57272: RANGER-1419:Do some code improvement in Java method XTrxLogService.searchXTrxLogs

2017-03-06 Thread Colm O hEigeartaigh
= entityType.getSingularAttribute(fieldName); This could be moved into the subsequent if statement, as it's only used in there. - Colm O hEigeartaigh On March 3, 2017, 9:27 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 57363: Log should be changed to info level

2017-03-07 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57363/#review168105 --- Ship it! Ship It! - Colm O hEigeartaigh On March 7, 2017, 6

Re: Review Request 57272: RANGER-1419:Do some code improvement in Java method XTrxLogService.searchXTrxLogs

2017-03-07 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57272/#review168108 --- Ship it! Ship It! - Colm O hEigeartaigh On March 7, 2017, 1

Review Request 57371: RANGER-1426 - Change return type of RangerBaseService.validateConfig

2017-03-07 Thread Colm O hEigeartaigh
-agent/src/main/java/org/apache/ranger/services/storm/client/StormResourceMgr.java 43960b3 Diff: https://reviews.apache.org/r/57371/diff/1/ Testing --- Thanks, Colm O hEigeartaigh

Re: Review Board requests

2017-03-07 Thread Colm O hEigeartaigh
tch submitters to close the submitted/discarded > review requests. > > From: Colm O hEigeartaigh > Reply-To: "dev@ranger.apache.org" , " > cohei...@apache.org" > Date: Thursday, February 16, 2017 at 4:56 AM > To: "dev@ranger.apache.org" > Subject: Re

Re: Review Board requests

2017-03-07 Thread Colm O hEigeartaigh
at 1:45 PM, Selvamohan Neethiraj wrote: > Colm: > > I was able to close all older RR from https://reviews.apache.org/r > Do you still see them in your inbox of your review board ? > > Selva- > > On 3/7/17, 7:00 AM, "Colm O hEigeartaigh" wrote: > > As per the I

Re: Review Board requests

2017-03-07 Thread Colm O hEigeartaigh
t; Selva- > > On 3/7/17, 8:50 AM, "Colm O hEigeartaigh" wrote: > > I see 140+ RR associated with the Ranger group: > > https://reviews.apache.org/dashboard/?group=ranger > > If I go to the second page, almost all of the issues appear to be > sh

Re: Review Request 55669: RANGER-1318 - Consolidate XML configuration parsing

2017-03-07 Thread Colm O hEigeartaigh
/UnixAuthenticationService.java 11e0c92 Diff: https://reviews.apache.org/r/55669/diff/5/ Changes: https://reviews.apache.org/r/55669/diff/4-5/ Testing --- Thanks, Colm O hEigeartaigh

Re: Review Request 57409: RANGER-1432:Do some code improvement in UserMgr.java

2017-03-08 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57409/#review168260 --- Ship it! Ship It! - Colm O hEigeartaigh On March 8, 2017, 3

Re: Review Request 55669: RANGER-1318 - Consolidate XML configuration parsing

2017-03-08 Thread Colm O hEigeartaigh
/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 11e0c92 Diff: https://reviews.apache.org/r/55669/diff/6/ Changes: https://reviews.apache.org/r/55669/diff/5-6/ Testing --- Thanks, Colm O hEigeartaigh

Re: Review Request 55669: RANGER-1318 - Consolidate XML configuration parsing

2017-03-08 Thread Colm O hEigeartaigh
s is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55669/#review168243 --- On March 8, 2017, 9:55 a.m., Colm O hEigeartaigh wrote: > > ---

Re: Review Request 57406: RANGER-1431:Do some code improvement in Java method AuthSessionService.mapEntityToViewBean

2017-03-08 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57406/#review168263 --- Ship it! Ship It! - Colm O hEigeartaigh On March 8, 2017, 2

Review Request 57421: RANGER-1433 - Enabled secure processing feature

2017-03-08 Thread Colm O hEigeartaigh
/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java 8fee099 Diff: https://reviews.apache.org/r/57421/diff/1/ Testing --- Thanks, Colm O hEigeartaigh

Re: Can't change the Assignee to oneself?

2017-03-08 Thread Colm O hEigeartaigh
pposed to work? Or do I need extra steps in order to be able to > do so? > > Thanks! > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

  1   2   3   4   5   6   7   8   9   10   >