Fwd: [MAVEN-BUILD] Royale-compiler - Build # 294 - Still Failing

Hi, it seems my commit 730c5a9d9aed1ee3b3f3e5e732cf6e4a7d44f6bc is making build to fail, but looking into it I can see what's wrong, or maybe is not the commit? anyone knows what the cause of this fail? thanks -- Forwarded message -- From: Apache Jenkins Server Date: 2018-04-09

Re: [MAVEN-BUILD] Royale-typedefs - Build # 175 - Failure

Regarding my latest email, it seems that typedefs is as well failing, but with no changes, so this seems something external to the code? 2018-04-09 2:54 GMT+02:00 Apache Jenkins Server : > The Apache Jenkins build system has built Royale-typedefs (build #175) > > Status: Failure > > Check console

RE: [MAVEN-BUILD] Royale-typedefs - Build # 175 - Failure

Could it be that sonar was updated to a newer version on the maven repo? Have u tried the proposed solution there? [1] https://stackoverflow.com/questions/40300653/failed-to-execute-goal-org-sonarsource-scanner-mavensonar-maven-plugin-3-2son From: carlos.rov

YUI compressor for CSS (relates to apache/royale-compiler#39)

Hi, yesterday I was looking how to minify CSS in js-release. I put all the wiring so we can process the final CSS js-release version. To see is working I just put a basic break line removal, but this needs to be a full CSS minification. in Java I see all people use YUI compressor [1]. This librar

Milestones

Hi, as I'm working more in this project I'm founding some things we should use. One is Milestones [1] For example Jewel, emulation components, CSS fixes should be in 0.9.3 Thoughts? [1] https://github.com/apache/royale-compiler/milestones -- Carlos Rovira http://about.me/carlosrovira

Re: Milestones

Hi Carlos, Ahh Yes. In most cases I'm adding it after release, but forgot to do that. Add it also in royale-asjs repository. Of course +1 for the milestones :) Thanks, Piotr 2018-04-09 11:15 GMT+02:00 Carlos Rovira : > Hi, > > as I'm working more in this project I'm founding some things we sho

Re: Milestones

We moved from our local git server to private GitHub repositories here with our company projects. Additional to those "Release Milestones" we've introduced "Monthly sprints Milestones". So, basically +1 for milestones. I guess your "Jewel" project will be processed over several releases. In that c

Re: Milestones

Thanks Piotr, and Olaf, just made some reorganization work in compiler and framework. But this is something to do through more days. Hope the rest would make it as well: * Milestones should be made as soon as we start another development cycle * I create projects for Jewel and Emulation Components

Re: [MAVEN-BUILD] Royale-typedefs - Build # 175 - Failure

Hi Yishay, I'm don't know too much of that part of the project. Can you try it if you know more about that? thanks 2018-04-09 10:49 GMT+02:00 Yishay Weiss : > Could it be that sonar was updated to a newer version on the maven repo? > Have u tried the proposed solution there? > > > > [1] https://s

Build failed in Jenkins: royale-asjs_jsonly #595

See -- [...truncated 220.26 KB...] [echo] ${INFO_DOWNLOADING_FILE_FROM} [echo] basedir is C:\Program Files (x86)\Jenkins\workspace\royale-compiler

RE: [MAVEN-BUILD] Royale-typedefs - Build # 175 - Failure

I’m not either. If the Sonar problems continue I’ll give that solution a try. From: carlos.rov...@gmail.com on behalf of Carlos Rovira Sent: Monday, April 9, 2018 1:14:53 PM To: dev@royale.apache.org Subject: Re: [MAVEN-BUILD] Royale-typedefs - Build # 175 - F

Re: [MAVEN-BUILD] Royale-typedefs - Build # 175 - Failure

Maybe something to ask for to infra team? can you rise them a ticket ? thanks 2018-04-09 12:17 GMT+02:00 Yishay Weiss : > I’m not either. If the Sonar problems continue I’ll give that solution a > try. > > > > > From: carlos.rov...@gmail.com on behalf of > Carlo

Jenkins build is back to normal : royale-asjs_jsonly #596

See

RE: [MAVEN-BUILD] Royale-typedefs - Build # 175 - Failure

From: carlos.rov...@gmail.com on behalf of Carlos Rovira Sent: Monday, April 9, 2018 1:39:32 PM To: dev@royale.apache.org Subject: Re: [MAVEN-BUILD] Royale-typedefs - Build # 175 - Failure Maybe something to ask for to infra team? can you rise them a ticket

Deal with Themes build

Hi, I just committed first No flat themes in 12 color variations and Light / Dark versions. These are 36 * 2 projects = 72 projects Still I must commit the Flat versions this means another 72 theme projects to make a total of 144 project themes You will use it using picking up 3 of them (Primary,

Re: Deal with Themes build

Hi Carlos, Seems like a separate Maven profile and/or Ant target should run SASS to generate the .css files. There is no requirement from other Royale code for the themes to be built into SWCs. You can specify a .CSS file or a .SWC file as a theme. It is only for Maven that theme CSS files are

Re: Layout optimizations

Hi Harbs, I was merging these changes into MXRoyale and discovered some things that aren't PAYG. Measurement should not be assumed on every component. Many components will be fine without ever requiring measurement. There were already some measurement beads around. Measurement should be its ow

Re: YUI compressor for CSS (relates to apache/royale-compiler#39)

I don't see this as a requirement for Royale's success, at least right now. How many bytes will we save by using YUI given that much of the CSS will be written by us committers? IMO, there are much bigger fish to fry. We control what we emit already, so YUI seems like over-kill. It will result

Re: Layout optimizations

Can you be more specific? What isn’t PAYG? The measuredWidth and measuredHeight setters and getters. I can’t think of anything else. I expect to get back to this later this week. > On Apr 9, 2018, at 7:21 PM, Alex Harui wrote: > > Hi Harbs, > > I was merging these changes into MXRoyale and d

Re: Deal with Themes build

Hi Alex, not sure if we are talking about the same problem. I think 1 CSS - 1 project theme relation is ok. maybe as I progress with jewel and its themes we would need to put some code or assets, and so it's ok to have that structure. In the other hand, I choose to break a theme in three pieces (t

Re: Layout optimizations

You can see the areas I commented out or removed in the MXRoyale branch. 1) There is no need for slots for measuredWidth/measuredHeight on UIBase. 2) LayoutBase should not assume each host needs measuring or cares that its measurements might change. 3) The measurement, when needed, should be gener

Re: Deal with Themes build

Hi Carlos, Ideally, all variants of the main theme can be expressed in a single CSS file. I would hope you would be willing to make trade-offs to make that so. I think the main theme can be a SWC and contain assets only used by a single variant. Sort of like a central library. Then the variant

Re: YUI compressor for CSS (relates to apache/royale-compiler#39)

Hi Alex, I don't see it as a long term solution. As you said we can put some of the things, but if you see at the CSSCompressor code in YUI [1], there's so much done there. If you say me that YUI license is not compatible with us, that's ok, we can't use it so we need other solution (maybe yours f

Re: YUI compressor for CSS (relates to apache/royale-compiler#39)

Carlos, Do you think that compression also could be done totally out of Royale ? I'm thinking whether Maven does have some plugins out there that after compilation could minified CSS ? Just thinking loud. Thanks, Piotr 2018-04-09 19:37 GMT+02:00 Carlos Rovira : > Hi Alex, > > I don't see it as

Re: Layout optimizations

1. I will consider #1. There might be a way to inject those values. 2. The only thing I’ve done with LayoutBase is remove code on the JS side. Measurement is *NOT* assumed. Not sure what you mean here. 3. Beads are not a bad idea, but I’d really like to find a cheaper way of getting beads by type

Re: YUI compressor for CSS (relates to apache/royale-compiler#39)

Yes, YUI does lots of things, but how often are folks going to write the CSS it can optimize? If you change our emitter so that it removes line breaks, last semicolon, and most comments, everything else YUI can do will likely have minimal effect. If YUI is BSD it can be used, but I personally do

Re: Layout optimizations

On 4/9/18, 10:42 AM, "Harbs" wrote: >1. I will consider #1. There might be a way to inject those values. The only reasons to put properties on UIBase is for MXML, and for making components look a bit more Flex-like. Those getters/setters often access a bead anyway (and should). Remember the

Re: Deal with Themes build

Hi Alex, 2018-04-09 19:37 GMT+02:00 Alex Harui : > Hi Carlos, > > Ideally, all variants of the main theme can be expressed in a single CSS > file. all variants in a single CSS? so you're talking about an huge CSS file that will be processed by the compiler to only strip the needed rules? mmm...

Re: YUI compressor for CSS (relates to apache/royale-compiler#39)

Hi Piotr, right, YUI exists as a maven plugin and I didn't test it but we can wire it. But that solution will be "only for maven" and I think we don't want that. for that reason I was talking about introduce it in our code so ANT and MAVEN user will benefit it or whatever that uses out compiler an

Re: Deal with Themes build

No each variant can be its own CSS file. Just like you have it. For the Ant builds, there is no need to create a SWC in each of the 144 folders. The -theme option will list the path directly to the CSS file. We are currently only creating a SWC for themes/Basic/src/Basic.css because I haven't fi

Re: YUI compressor for CSS (relates to apache/royale-compiler#39)

Alex, 2018-04-09 19:44 GMT+02:00 Alex Harui : > Yes, YUI does lots of things, but how often are folks going to write the > CSS it can optimize? If you change our emitter so that it removes line > breaks, last semicolon, and most comments, everything else YUI can do will > likely have minimal eff

Re: Deal with Themes build

And what will happen when we introduce classes that draw SWF assets to match styles (ie: checkbox tick and box, gradients,...)? or I introduced a .png, or some component have a ViewBead Class? I'm totally against .css files alone as a production file theme. I think .SWC packaging for both JS and SW

Re: [royale-asjs] 01/01: UIBase className changes to support new cssclassList class methods like addStyles

Hi, this branch has the UIBase modifications that I made in Jewel. I think is time to complete the change so: @Alex: Can you take a look at the diff and see if you are ok with it? I think I do this with the considerations we discussed some weeks ago, but I think you never saw if that was finaly w

Re: YUI compressor for CSS (relates to apache/royale-compiler#39)

Woah. Did I read that right? Anyone who uses Jewel will automatically have a 31k of CSS before any app specific css? That’s a lot of CSS which might or might not be used. My current app has a total of 13KB *including* my custom css. > On Apr 9, 2018, at 9:32 PM, Carlos Rovira wrote: > > Alex,

Re: [royale-asjs] 01/01: UIBase className changes to support new cssclassList class methods like addStyles

This is a huge functional change. I don’t know that I really agree with this. You really haven’t answered my comments about the performance implications. I previously linked to jsperf tests. According to recent tests, addStyle seems to perform much more poorly that changing the className. > On

Re: YUI compressor for CSS (relates to apache/royale-compiler#39)

If you use Jewel Theme yes. If we get it minified, 22k. But that's for non flat theme. Expect flat to be less (not have numbers now) But you always can create your own theme. It's the greatness of jewel, you don't have to go with the look I'm designing. In the other hand I think 31 or 22 k is not

Re: [royale-asjs] 01/01: UIBase className changes to support new cssclassList class methods like addStyles

Harbs, I though I did it. I give links to peformance links that for me proved that people is going through classList. If you read that Alex, replied that for him that kind of tests was not reflecting our use case, but, for me we should separate the performance of classList, from how we use classLi

Re: Deal with Themes build

IMO, no need to make SWCs if you don't need to. The tooling supports CSS as a theme. The main Jewel Theme is a SWC already. Any assets for the variants can be put in the main Jewel Theme SWC and referenced from the variants. I believe the tooling will not output unused assets, or we can make it

Re: YUI compressor for CSS (relates to apache/royale-compiler#39)

Hi Carlos, Each thing that YUI can do will make a certain amount of difference. I would expect removing comments and whitespace will make the biggest difference. I thought you said you already had that code ready. How much does that save? If you want to take on the integration of YUI and be th

Re: [royale-asjs] 01/01: UIBase className changes to support new cssclassList class methods like addStyles

I spent some time reviewing the code and email thread. My current thinking is that we have to agree on the scenarios first and then the code. Here's what I think the scenarios are: 1) Just about every UIBase is going to set className at initialization time. 2) A significant percentage of UIBase

Re: YUI compressor for CSS (relates to apache/royale-compiler#39)

Hi Alex, ok so, I'll defer this for now, and can get back to it as other things settle in some months. I don't see me right now as a release manager, maybe some time in the future, I'm getting new skills as I progress, for example in the last days with fixing things in the compiler, but I can't go

Re: YUI compressor for CSS (relates to apache/royale-compiler#39)

We can probably eliminate the vast majority of code redundancy if that’s true. The problem with CSS is that it’s pretty hard to do the same there. Is there any way to strip the css down to only the classes that are actually used by the components used in the app? I’m guessing that will be really